zero-query 1.2.13 → 1.2.15

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "zero-query",
-  "version": "1.2.13",
+  "version": "1.2.15",
   "description": "Lightweight modern frontend library - jQuery-like selectors, reactive components, SPA router, and state management with zero dependencies.",
   "main": "index.js",
   "types": "index.d.ts",

package/src/webrtc/peer.js

@@ -253,11 +253,12 @@ export class Peer {
         this.pc.onicecandidate = (event) => {
             if (this.closed) return;
             const candidate = event && event.candidate;
-            // End-of-candidates marker (null) -> always forward.
-            if (!candidate) {
-                this.signaling.send('ice', { target: this.id, candidate: null });
-                return;
-            }
+            // End-of-candidates: the @zero-server/webrtc SignalingHub rejects
+            // any ice frame whose `candidate` is not a non-empty string
+            // (BAD_FRAME -> counts toward the protocol-error budget that can
+            // disconnect the peer). Browsers infer end-of-candidates from
+            // iceGatheringState anyway, so we simply drop the marker.
+            if (!candidate) return;
             const cand = typeof candidate === 'string' ? candidate : candidate.candidate;
             if (!cand) return;
             // NOTE: do NOT filter mDNS (.local) candidates. Firefox emits them by
@@ -362,12 +363,17 @@ export class Peer {
             }
             // Older zero-query clients relayed only the bare `a=candidate:` string,
             // which browsers reject with "missing values for both sdpMid and
-            // sdpMLineIndex". Newer clients send a full init dict - normalize both.
+            // sdpMLineIndex". Pass sdpMLineIndex:0 and leave sdpMid null so
+            // the browser binds the candidate to the first (and, under
+            // bundlePolicy:'max-bundle', only) m-section. Passing sdpMid:''
+            // is NOT equivalent to omitting it - the browser treats empty
+            // string as a real mid and fails with "Failed to execute
+            // 'addIceCandidate'" because no m-section has mid="".
             const init = (typeof candidate === 'string')
-                ? { candidate, sdpMid: '', sdpMLineIndex: 0 }
+                ? { candidate, sdpMid: null, sdpMLineIndex: 0 }
                 : {
                     candidate:        candidate.candidate,
-                    sdpMid:           candidate.sdpMid != null ? candidate.sdpMid : '',
+                    sdpMid:           candidate.sdpMid != null ? candidate.sdpMid : null,
                     sdpMLineIndex:    candidate.sdpMLineIndex != null ? candidate.sdpMLineIndex : 0,
                     usernameFragment: candidate.usernameFragment != null ? candidate.usernameFragment : undefined,
                 };

package/tests/webrtc/peer.test.js

@@ -130,26 +130,23 @@ describe('Peer (perfect negotiation)', () => {
     // Outbound: ICE trickle
     // -----------------------------------------------------------------------
 
-    it('forwards trickled ICE candidates as `ice` frames addressed to peerId', async () => {
+    it('forwards trickled ICE candidates as `ice` frames addressed to peerId, dropping the null EOC marker', async () => {
         const sig = await makeOpenSignaling();
         const peer = new Peer('peer_a', sig, { RTCPeerConnection: FakeRTCPeerConnection });
 
         lastPc().fakeIceCandidate('candidate:1 1 udp 2122260223 192.0.2.1 5000 typ host');
         lastPc().fakeIceCandidate('candidate:2 1 udp 1686052607 198.51.100.1 5001 typ srflx');
-        lastPc().fakeIceCandidate(null); // end-of-candidates
-
-        // Bypass coalesce window by reading the queued frames directly: we know
-        // signaling.js batches ICE per 200ms - flush by advancing real time...
-        // ... or simpler: assert the queue has populated by reading send calls
-        // once the timer flushes. Use synchronous expectation on _iceQueue.
-        // The SignalingClient buffers ice frames; we don't want to wait timers
-        // here, so just verify a deterministic side-effect: at minimum the
-        // queue depth matches the candidate count we trickled.
-        expect(sig._iceQueue.length).toBe(3);
+        lastPc().fakeIceCandidate(null); // end-of-candidates - dropped on the floor
+
+        // The SignalingHub rejects ice frames whose candidate is not a
+        // non-empty string (BAD_FRAME, counted against the protocol-error
+        // budget), so the EOC marker must NOT reach the wire. Browsers infer
+        // end-of-candidates from iceGatheringState anyway.
+        expect(sig._iceQueue.length).toBe(2);
         expect(sig._iceQueue[0].target).toBe('peer_a');
         expect(typeof sig._iceQueue[0].candidate).toBe('string');
         expect(sig._iceQueue[0].candidate).toContain('typ host');
-        expect(sig._iceQueue[2].candidate).toBeNull();
+        expect(sig._iceQueue[1].candidate).toContain('typ srflx');
         peer.close();
     });
 
@@ -175,13 +172,12 @@ describe('Peer (perfect negotiation)', () => {
         for (let i = 0; i < 10; i++) {
             lastPc().fakeIceCandidate(`candidate:${i} 1 udp 2122260223 192.0.2.${i} 5000 typ host`);
         }
-        // EOC marker is always allowed past the cap.
+        // EOC marker is dropped (server rejects null candidates as BAD_FRAME).
         lastPc().fakeIceCandidate(null);
 
         const iceFrames = sig._iceQueue;
-        const nonNull = iceFrames.filter((f) => f.candidate !== null);
-        expect(nonNull.length).toBe(3);
-        expect(iceFrames.some((f) => f.candidate === null)).toBe(true);
+        expect(iceFrames.length).toBe(3);
+        expect(iceFrames.every((f) => typeof f.candidate === 'string' && f.candidate.length > 0)).toBe(true);
         peer.close();
     });
 
@@ -237,7 +233,7 @@ describe('Peer (perfect negotiation)', () => {
         expect(lastPc().addIceCandidateCalls).toHaveLength(2);
         expect(lastPc().addIceCandidateCalls[0]).toEqual({
             candidate:     'candidate:7 1 udp 1 192.0.2.7 5000 typ host',
-            sdpMid:        '',
+            sdpMid:        null,
             sdpMLineIndex: 0,
         });
         expect(lastPc().addIceCandidateCalls[1]).toBeNull();