zero-query 1.2.12 → 1.2.14

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "zero-query",
-  "version": "1.2.12",
+  "version": "1.2.14",
   "description": "Lightweight modern frontend library - jQuery-like selectors, reactive components, SPA router, and state management with zero dependencies.",
   "main": "index.js",
   "types": "index.d.ts",

package/src/webrtc/peer.js

@@ -104,6 +104,11 @@ export class Peer {
         this._maxIceCandidates = options.maxIceCandidates || DEFAULT_MAX_ICE_CANDIDATES;
         this._sentCandidates   = 0;
         this._sigUnsub         = [];
+        // Serialize incoming remote events (offer/answer/ice) so an ICE frame
+        // can never call addIceCandidate() while a setRemoteDescription() is
+        // still in flight - that race throws "The remote description was null"
+        // and leaves the PeerConnection stuck in `have-local-offer` forever.
+        this._opChain          = Promise.resolve();
 
         this._attachPc();
         this._attachSignaling();
@@ -294,7 +299,9 @@ export class Peer {
         const guard = (cb) => (msg) => {
             if (this.closed) return;
             if (!msg || msg.from !== this.id) return;
-            cb(msg);
+            // Chain every remote event behind any prior in-flight op so SDP
+            // and ICE never race against each other.
+            this._opChain = this._opChain.then(() => cb(msg)).catch(() => {});
         };
         this._sigUnsub.push(
             this.signaling.on('offer',  guard((m) => this._onRemoteDescription('offer',  m.sdp))),

package/tests/webrtc/peer.test.js

@@ -196,7 +196,7 @@ describe('Peer (perfect negotiation)', () => {
         fakeSockets[0].fakeMessage({ type: 'offer', from: 'peer_a', sdp: 'remote-sdp-blob' });
         // setRemoteDescription + setLocalDescription are awaited inside the
         // handler; yield two microtasks.
-        await Promise.resolve(); await Promise.resolve();
+        await Promise.resolve(); await Promise.resolve(); await Promise.resolve(); await Promise.resolve();
 
         expect(lastPc().setRemoteCalls).toHaveLength(1);
         expect(lastPc().setRemoteCalls[0]).toEqual({ type: 'offer', sdp: 'remote-sdp-blob' });
@@ -214,7 +214,7 @@ describe('Peer (perfect negotiation)', () => {
         // Pretend we previously offered.
         lastPc().signalingState = 'have-local-offer';
         fakeSockets[0].fakeMessage({ type: 'answer', from: 'peer_a', sdp: 'remote-answer-sdp' });
-        await Promise.resolve(); await Promise.resolve();
+        await Promise.resolve(); await Promise.resolve(); await Promise.resolve(); await Promise.resolve();
 
         expect(lastPc().setRemoteCalls).toHaveLength(1);
         expect(lastPc().setRemoteCalls[0].type).toBe('answer');
@@ -229,7 +229,10 @@ describe('Peer (perfect negotiation)', () => {
 
         fakeSockets[0].fakeMessage({ type: 'ice', from: 'peer_a', candidate: 'candidate:7 1 udp 1 192.0.2.7 5000 typ host' });
         fakeSockets[0].fakeMessage({ type: 'ice', from: 'peer_a', candidate: null });
-        await Promise.resolve(); await Promise.resolve();
+        // The peer serializes remote events through an internal microtask chain;
+        // drain it before asserting.
+        await peer._opChain;
+        await peer._opChain;
 
         expect(lastPc().addIceCandidateCalls).toHaveLength(2);
         expect(lastPc().addIceCandidateCalls[0]).toEqual({
@@ -247,7 +250,7 @@ describe('Peer (perfect negotiation)', () => {
 
         fakeSockets[0].fakeMessage({ type: 'offer', from: 'peer_b', sdp: 'other' });
         fakeSockets[0].fakeMessage({ type: 'ice',   from: 'peer_b', candidate: 'foo' });
-        await Promise.resolve(); await Promise.resolve();
+        await Promise.resolve(); await Promise.resolve(); await Promise.resolve(); await Promise.resolve();
 
         expect(lastPc().setRemoteCalls).toHaveLength(0);
         expect(lastPc().addIceCandidateCalls).toHaveLength(0);
@@ -268,7 +271,7 @@ describe('Peer (perfect negotiation)', () => {
         // Simulate an in-flight local offer.
         peer.makingOffer = true;
         fakeSockets[0].fakeMessage({ type: 'offer', from: 'peer_a', sdp: 'collide' });
-        await Promise.resolve(); await Promise.resolve();
+        await Promise.resolve(); await Promise.resolve(); await Promise.resolve(); await Promise.resolve();
 
         expect(peer.ignoreOffer).toBe(true);
         expect(lastPc().setRemoteCalls).toHaveLength(0);
@@ -285,7 +288,7 @@ describe('Peer (perfect negotiation)', () => {
 
         peer.makingOffer = true;
         fakeSockets[0].fakeMessage({ type: 'offer', from: 'peer_a', sdp: 'collide' });
-        await Promise.resolve(); await Promise.resolve();
+        await Promise.resolve(); await Promise.resolve(); await Promise.resolve(); await Promise.resolve();
 
         expect(peer.ignoreOffer).toBe(false);
         expect(lastPc().setRemoteCalls).toHaveLength(1);
@@ -305,7 +308,7 @@ describe('Peer (perfect negotiation)', () => {
         peer.ignoreOffer = true;
         lastPc().failNextAddIce = new Error('stale');
         fakeSockets[0].fakeMessage({ type: 'ice', from: 'peer_a', candidate: 'candidate:foo' });
-        await Promise.resolve(); await Promise.resolve();
+        await Promise.resolve(); await Promise.resolve(); await Promise.resolve(); await Promise.resolve();
 
         expect(errors).toHaveLength(0);
         peer.close();
@@ -372,7 +375,7 @@ describe('Peer (perfect negotiation)', () => {
 
         // Further inbound frames must not touch the (closed) PC.
         fakeSockets[0].fakeMessage({ type: 'offer', from: 'peer_a', sdp: 'late' });
-        await Promise.resolve(); await Promise.resolve();
+        await Promise.resolve(); await Promise.resolve(); await Promise.resolve(); await Promise.resolve();
         expect(lastPc().setRemoteCalls).toHaveLength(0);
     });
 });