zenstack 1.0.16 → 1.1.1

package/language-server/validator/expression-validator.js

@@ -1,18 +1,21 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 const ast_1 = require("@zenstackhq/language/ast");
+const sdk_1 = require("@zenstackhq/sdk");
 const ast_utils_1 = require("../../utils/ast-utils");
 /**
  * Validates expressions.
  */
 class ExpressionValidator {
     validate(expr, accept) {
+        var _a;
+        // deal with a few cases where reference resolution fail silently
         if (!expr.$resolvedType) {
             if ((0, ast_utils_1.isAuthInvocation)(expr)) {
                 // check was done at link time
                 accept('error', 'auth() cannot be resolved because no "User" model is defined', { node: expr });
             }
-            else if (this.isCollectionPredicate(expr)) {
+            else if ((0, ast_utils_1.isCollectionPredicate)(expr)) {
                 accept('error', 'collection predicate can only be used on an array of model type', { node: expr });
             }
             else {
@@ -21,9 +24,111 @@ class ExpressionValidator {
                 });
             }
         }
+        if (((_a = expr.$resolvedType) === null || _a === void 0 ? void 0 : _a.decl) === 'Unsupported') {
+            accept('error', 'Field of "Unsupported" type cannot be used in expressions', { node: expr });
+        }
+        // extra validations by expression type
+        switch (expr.$type) {
+            case 'BinaryExpr':
+                this.validateBinaryExpr(expr, accept);
+                break;
+        }
     }
-    isCollectionPredicate(expr) {
-        return (0, ast_1.isBinaryExpr)(expr) && ['?', '!', '^'].includes(expr.operator);
+    validateBinaryExpr(expr, accept) {
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l;
+        switch (expr.operator) {
+            case 'in': {
+                if (typeof ((_a = expr.left.$resolvedType) === null || _a === void 0 ? void 0 : _a.decl) !== 'string' && !(0, ast_1.isEnum)((_b = expr.left.$resolvedType) === null || _b === void 0 ? void 0 : _b.decl)) {
+                    accept('error', 'left operand of "in" must be of scalar type', { node: expr.left });
+                }
+                if (!((_c = expr.right.$resolvedType) === null || _c === void 0 ? void 0 : _c.array)) {
+                    accept('error', 'right operand of "in" must be an array', {
+                        node: expr.right,
+                    });
+                }
+                break;
+            }
+            case '>':
+            case '>=':
+            case '<':
+            case '<=':
+            case '&&':
+            case '||': {
+                if ((_d = expr.left.$resolvedType) === null || _d === void 0 ? void 0 : _d.array) {
+                    accept('error', 'operand cannot be an array', { node: expr.left });
+                    break;
+                }
+                if ((_e = expr.right.$resolvedType) === null || _e === void 0 ? void 0 : _e.array) {
+                    accept('error', 'operand cannot be an array', { node: expr.right });
+                    break;
+                }
+                let supportedShapes;
+                if (['>', '>=', '<', '<='].includes(expr.operator)) {
+                    supportedShapes = ['Int', 'Float', 'DateTime', 'Any'];
+                }
+                else {
+                    supportedShapes = ['Boolean', 'Any'];
+                }
+                if (typeof ((_f = expr.left.$resolvedType) === null || _f === void 0 ? void 0 : _f.decl) !== 'string' ||
+                    !supportedShapes.includes(expr.left.$resolvedType.decl)) {
+                    accept('error', `invalid operand type for "${expr.operator}" operator`, {
+                        node: expr.left,
+                    });
+                    return;
+                }
+                if (typeof ((_g = expr.right.$resolvedType) === null || _g === void 0 ? void 0 : _g.decl) !== 'string' ||
+                    !supportedShapes.includes(expr.right.$resolvedType.decl)) {
+                    accept('error', `invalid operand type for "${expr.operator}" operator`, {
+                        node: expr.right,
+                    });
+                    return;
+                }
+                // DateTime comparison is only allowed between two DateTime values
+                if (expr.left.$resolvedType.decl === 'DateTime' && expr.right.$resolvedType.decl !== 'DateTime') {
+                    accept('error', 'incompatible operand types', { node: expr });
+                }
+                else if (expr.right.$resolvedType.decl === 'DateTime' &&
+                    expr.left.$resolvedType.decl !== 'DateTime') {
+                    accept('error', 'incompatible operand types', { node: expr });
+                }
+                break;
+            }
+            case '==':
+            case '!=': {
+                if (!!((_h = expr.left.$resolvedType) === null || _h === void 0 ? void 0 : _h.array) !== !!((_j = expr.right.$resolvedType) === null || _j === void 0 ? void 0 : _j.array)) {
+                    accept('error', 'incompatible operand types', { node: expr });
+                    break;
+                }
+                // disallow comparing model type with scalar type or comparison between
+                // incompatible model types
+                const leftType = (_k = expr.left.$resolvedType) === null || _k === void 0 ? void 0 : _k.decl;
+                const rightType = (_l = expr.right.$resolvedType) === null || _l === void 0 ? void 0 : _l.decl;
+                if ((0, ast_1.isDataModel)(leftType) && (0, ast_1.isDataModel)(rightType)) {
+                    if (leftType != rightType) {
+                        // incompatible model types
+                        // TODO: inheritance case?
+                        accept('error', 'incompatible operand types', { node: expr });
+                    }
+                    // not supported:
+                    //   - foo == bar
+                    //   - foo == this
+                    if ((0, sdk_1.isDataModelFieldReference)(expr.left) &&
+                        ((0, ast_1.isThisExpr)(expr.right) || (0, sdk_1.isDataModelFieldReference)(expr.right))) {
+                        accept('error', 'comparison between model-typed fields are not supported', { node: expr });
+                    }
+                    else if ((0, sdk_1.isDataModelFieldReference)(expr.right) &&
+                        ((0, ast_1.isThisExpr)(expr.left) || (0, sdk_1.isDataModelFieldReference)(expr.left))) {
+                        accept('error', 'comparison between model-typed fields are not supported', { node: expr });
+                    }
+                }
+                else if (((0, ast_1.isDataModel)(leftType) && !(0, ast_1.isNullExpr)(expr.right)) ||
+                    ((0, ast_1.isDataModel)(rightType) && !(0, ast_1.isNullExpr)(expr.left))) {
+                    // comparing model against scalar (except null)
+                    accept('error', 'incompatible operand types', { node: expr });
+                }
+                break;
+            }
+        }
     }
 }
 exports.default = ExpressionValidator;

package/language-server/validator/expression-validator.js.map

@@ -1 +1 @@
-{"version":3,"file":"expression-validator.js","sourceRoot":"","sources":["../../../src/language-server/validator/expression-validator.ts"],"names":[],"mappings":";;AAAA,kDAAoE;AAEpE,qDAAyD;AAGzD;;GAEG;AACH,MAAqB,mBAAmB;IACpC,QAAQ,CAAC,IAAgB,EAAE,MAA0B;QACjD,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE;YACrB,IAAI,IAAA,4BAAgB,EAAC,IAAI,CAAC,EAAE;gBACxB,8BAA8B;gBAC9B,MAAM,CAAC,OAAO,EAAE,8DAA8D,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;aACnG;iBAAM,IAAI,IAAI,CAAC,qBAAqB,CAAC,IAAI,CAAC,EAAE;gBACzC,MAAM,CAAC,OAAO,EAAE,iEAAiE,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;aACtG;iBAAM;gBACH,MAAM,CAAC,OAAO,EAAE,+BAA+B,EAAE;oBAC7C,IAAI,EAAE,IAAI;iBACb,CAAC,CAAC;aACN;SACJ;IACL,CAAC;IAEO,qBAAqB,CAAC,IAAgB;QAC1C,OAAO,IAAA,kBAAY,EAAC,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,GAAG,EAAE,GAAG,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;IACzE,CAAC;CACJ;AAnBD,sCAmBC"}
+{"version":3,"file":"expression-validator.js","sourceRoot":"","sources":["../../../src/language-server/validator/expression-validator.ts"],"names":[],"mappings":";;AAAA,kDAQkC;AAClC,yCAA4D;AAE5D,qDAAgF;AAGhF;;GAEG;AACH,MAAqB,mBAAmB;IACpC,QAAQ,CAAC,IAAgB,EAAE,MAA0B;;QACjD,iEAAiE;QACjE,IAAI,CAAC,IAAI,CAAC,aAAa,EAAE;YACrB,IAAI,IAAA,4BAAgB,EAAC,IAAI,CAAC,EAAE;gBACxB,8BAA8B;gBAC9B,MAAM,CAAC,OAAO,EAAE,8DAA8D,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;aACnG;iBAAM,IAAI,IAAA,iCAAqB,EAAC,IAAI,CAAC,EAAE;gBACpC,MAAM,CAAC,OAAO,EAAE,iEAAiE,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;aACtG;iBAAM;gBACH,MAAM,CAAC,OAAO,EAAE,+BAA+B,EAAE;oBAC7C,IAAI,EAAE,IAAI;iBACb,CAAC,CAAC;aACN;SACJ;QAED,IAAI,CAAA,MAAA,IAAI,CAAC,aAAa,0CAAE,IAAI,MAAK,aAAa,EAAE;YAC5C,MAAM,CAAC,OAAO,EAAE,2DAA2D,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;SAChG;QAED,uCAAuC;QACvC,QAAQ,IAAI,CAAC,KAAK,EAAE;YAChB,KAAK,YAAY;gBACb,IAAI,CAAC,kBAAkB,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;gBACtC,MAAM;SACb;IACL,CAAC;IAEO,kBAAkB,CAAC,IAAgB,EAAE,MAA0B;;QACnE,QAAQ,IAAI,CAAC,QAAQ,EAAE;YACnB,KAAK,IAAI,CAAC,CAAC;gBACP,IAAI,OAAO,CAAA,MAAA,IAAI,CAAC,IAAI,CAAC,aAAa,0CAAE,IAAI,CAAA,KAAK,QAAQ,IAAI,CAAC,IAAA,YAAM,EAAC,MAAA,IAAI,CAAC,IAAI,CAAC,aAAa,0CAAE,IAAI,CAAC,EAAE;oBAC7F,MAAM,CAAC,OAAO,EAAE,6CAA6C,EAAE,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,CAAC,CAAC;iBACvF;gBAED,IAAI,CAAC,CAAA,MAAA,IAAI,CAAC,KAAK,CAAC,aAAa,0CAAE,KAAK,CAAA,EAAE;oBAClC,MAAM,CAAC,OAAO,EAAE,wCAAwC,EAAE;wBACtD,IAAI,EAAE,IAAI,CAAC,KAAK;qBACnB,CAAC,CAAC;iBACN;gBACD,MAAM;aACT;YAED,KAAK,GAAG,CAAC;YACT,KAAK,IAAI,CAAC;YACV,KAAK,GAAG,CAAC;YACT,KAAK,IAAI,CAAC;YACV,KAAK,IAAI,CAAC;YACV,KAAK,IAAI,CAAC,CAAC;gBACP,IAAI,MAAA,IAAI,CAAC,IAAI,CAAC,aAAa,0CAAE,KAAK,EAAE;oBAChC,MAAM,CAAC,OAAO,EAAE,4BAA4B,EAAE,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,CAAC,CAAC;oBACnE,MAAM;iBACT;gBAED,IAAI,MAAA,IAAI,CAAC,KAAK,CAAC,aAAa,0CAAE,KAAK,EAAE;oBACjC,MAAM,CAAC,OAAO,EAAE,4BAA4B,EAAE,EAAE,IAAI,EAAE,IAAI,CAAC,KAAK,EAAE,CAAC,CAAC;oBACpE,MAAM;iBACT;gBAED,IAAI,eAAiC,CAAC;gBACtC,IAAI,CAAC,GAAG,EAAE,IAAI,EAAE,GAAG,EAAE,IAAI,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,QAAQ,CAAC,EAAE;oBAChD,eAAe,GAAG,CAAC,KAAK,EAAE,OAAO,EAAE,UAAU,EAAE,KAAK,CAAC,CAAC;iBACzD;qBAAM;oBACH,eAAe,GAAG,CAAC,SAAS,EAAE,KAAK,CAAC,CAAC;iBACxC;gBAED,IACI,OAAO,CAAA,MAAA,IAAI,CAAC,IAAI,CAAC,aAAa,0CAAE,IAAI,CAAA,KAAK,QAAQ;oBACjD,CAAC,eAAe,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,IAAI,CAAC,EACzD;oBACE,MAAM,CAAC,OAAO,EAAE,6BAA6B,IAAI,CAAC,QAAQ,YAAY,EAAE;wBACpE,IAAI,EAAE,IAAI,CAAC,IAAI;qBAClB,CAAC,CAAC;oBACH,OAAO;iBACV;gBACD,IACI,OAAO,CAAA,MAAA,IAAI,CAAC,KAAK,CAAC,aAAa,0CAAE,IAAI,CAAA,KAAK,QAAQ;oBAClD,CAAC,eAAe,CAAC,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,aAAa,CAAC,IAAI,CAAC,EAC1D;oBACE,MAAM,CAAC,OAAO,EAAE,6BAA6B,IAAI,CAAC,QAAQ,YAAY,EAAE;wBACpE,IAAI,EAAE,IAAI,CAAC,KAAK;qBACnB,CAAC,CAAC;oBACH,OAAO;iBACV;gBAED,kEAAkE;gBAClE,IAAI,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,IAAI,KAAK,UAAU,IAAI,IAAI,CAAC,KAAK,CAAC,aAAa,CAAC,IAAI,KAAK,UAAU,EAAE;oBAC7F,MAAM,CAAC,OAAO,EAAE,4BAA4B,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;iBACjE;qBAAM,IACH,IAAI,CAAC,KAAK,CAAC,aAAa,CAAC,IAAI,KAAK,UAAU;oBAC5C,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,IAAI,KAAK,UAAU,EAC7C;oBACE,MAAM,CAAC,OAAO,EAAE,4BAA4B,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;iBACjE;gBAED,MAAM;aACT;YAED,KAAK,IAAI,CAAC;YACV,KAAK,IAAI,CAAC,CAAC;gBACP,IAAI,CAAC,CAAC,CAAA,MAAA,IAAI,CAAC,IAAI,CAAC,aAAa,0CAAE,KAAK,CAAA,KAAK,CAAC,CAAC,CAAA,MAAA,IAAI,CAAC,KAAK,CAAC,aAAa,0CAAE,KAAK,CAAA,EAAE;oBACxE,MAAM,CAAC,OAAO,EAAE,4BAA4B,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;oBAC9D,MAAM;iBACT;gBAED,uEAAuE;gBACvE,2BAA2B;gBAC3B,MAAM,QAAQ,GAAG,MAAA,IAAI,CAAC,IAAI,CAAC,aAAa,0CAAE,IAAI,CAAC;gBAC/C,MAAM,SAAS,GAAG,MAAA,IAAI,CAAC,KAAK,CAAC,aAAa,0CAAE,IAAI,CAAC;gBACjD,IAAI,IAAA,iBAAW,EAAC,QAAQ,CAAC,IAAI,IAAA,iBAAW,EAAC,SAAS,CAAC,EAAE;oBACjD,IAAI,QAAQ,IAAI,SAAS,EAAE;wBACvB,2BAA2B;wBAC3B,0BAA0B;wBAC1B,MAAM,CAAC,OAAO,EAAE,4BAA4B,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;qBACjE;oBAED,iBAAiB;oBACjB,iBAAiB;oBACjB,kBAAkB;oBAClB,IACI,IAAA,+BAAyB,EAAC,IAAI,CAAC,IAAI,CAAC;wBACpC,CAAC,IAAA,gBAAU,EAAC,IAAI,CAAC,KAAK,CAAC,IAAI,IAAA,+BAAyB,EAAC,IAAI,CAAC,KAAK,CAAC,CAAC,EACnE;wBACE,MAAM,CAAC,OAAO,EAAE,yDAAyD,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;qBAC9F;yBAAM,IACH,IAAA,+BAAyB,EAAC,IAAI,CAAC,KAAK,CAAC;wBACrC,CAAC,IAAA,gBAAU,EAAC,IAAI,CAAC,IAAI,CAAC,IAAI,IAAA,+BAAyB,EAAC,IAAI,CAAC,IAAI,CAAC,CAAC,EACjE;wBACE,MAAM,CAAC,OAAO,EAAE,yDAAyD,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;qBAC9F;iBACJ;qBAAM,IACH,CAAC,IAAA,iBAAW,EAAC,QAAQ,CAAC,IAAI,CAAC,IAAA,gBAAU,EAAC,IAAI,CAAC,KAAK,CAAC,CAAC;oBAClD,CAAC,IAAA,iBAAW,EAAC,SAAS,CAAC,IAAI,CAAC,IAAA,gBAAU,EAAC,IAAI,CAAC,IAAI,CAAC,CAAC,EACpD;oBACE,+CAA+C;oBAC/C,MAAM,CAAC,OAAO,EAAE,4BAA4B,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;iBACjE;gBACD,MAAM;aACT;SACJ;IACL,CAAC;CACJ;AA7ID,sCA6IC"}

package/language-server/validator/function-decl-validator.d.ts

@@ -0,0 +1,9 @@
+import { FunctionDecl } from '@zenstackhq/language/ast';
+import { ValidationAcceptor } from 'langium';
+import { AstValidator } from '../types';
+/**
+ * Validates function declarations.
+ */
+export default class FunctionDeclValidator implements AstValidator<FunctionDecl> {
+    validate(funcDecl: FunctionDecl, accept: ValidationAcceptor): void;
+}

package/language-server/validator/function-decl-validator.js

@@ -0,0 +1,13 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const attribute_application_validator_1 = require("./attribute-application-validator");
+/**
+ * Validates function declarations.
+ */
+class FunctionDeclValidator {
+    validate(funcDecl, accept) {
+        funcDecl.attributes.forEach((attr) => (0, attribute_application_validator_1.validateAttributeApplication)(attr, accept));
+    }
+}
+exports.default = FunctionDeclValidator;
+//# sourceMappingURL=function-decl-validator.js.map

package/language-server/validator/function-decl-validator.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"function-decl-validator.js","sourceRoot":"","sources":["../../../src/language-server/validator/function-decl-validator.ts"],"names":[],"mappings":";;AAGA,uFAAiF;AAEjF;;GAEG;AACH,MAAqB,qBAAqB;IACtC,QAAQ,CAAC,QAAsB,EAAE,MAA0B;QACvD,QAAQ,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAA,8DAA4B,EAAC,IAAI,EAAE,MAAM,CAAC,CAAC,CAAC;IACtF,CAAC;CACJ;AAJD,wCAIC"}

package/language-server/validator/function-invocation-validator.d.ts

@@ -0,0 +1,11 @@
+import { Expression, InvocationExpr } from '@zenstackhq/language/ast';
+import { ValidationAcceptor } from 'langium';
+import { AstValidator } from '../types';
+/**
+ * InvocationExpr validation
+ */
+export default class FunctionInvocationValidator implements AstValidator<Expression> {
+    validate(expr: InvocationExpr, accept: ValidationAcceptor): void;
+    private validateArgs;
+    private validateInvocationArg;
+}

package/language-server/validator/function-invocation-validator.js

@@ -0,0 +1,135 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const ast_1 = require("@zenstackhq/language/ast");
+const sdk_1 = require("@zenstackhq/sdk");
+const ts_pattern_1 = require("ts-pattern");
+const ast_utils_1 = require("../../utils/ast-utils");
+const utils_1 = require("./utils");
+/**
+ * InvocationExpr validation
+ */
+class FunctionInvocationValidator {
+    validate(expr, accept) {
+        var _a, _b, _c, _d;
+        const funcDecl = expr.function.ref;
+        if (!funcDecl) {
+            accept('error', 'function cannot be resolved', { node: expr });
+            return;
+        }
+        if (!this.validateArgs(funcDecl, expr.args, accept)) {
+            return;
+        }
+        if ((0, sdk_1.isFromStdlib)(funcDecl)) {
+            // validate standard library functions
+            // find the containing attribute context for the invocation
+            let curr = expr.$container;
+            let containerAttribute;
+            while (curr) {
+                if ((0, ast_1.isDataModelAttribute)(curr) || (0, ast_1.isDataModelFieldAttribute)(curr)) {
+                    containerAttribute = curr;
+                    break;
+                }
+                curr = curr.$container;
+            }
+            // validate the context allowed for the function
+            const exprContext = (0, ts_pattern_1.match)(containerAttribute === null || containerAttribute === void 0 ? void 0 : containerAttribute.decl.$refText)
+                .with('@default', () => sdk_1.ExpressionContext.DefaultValue)
+                .with(ts_pattern_1.P.union('@@allow', '@@deny'), () => sdk_1.ExpressionContext.AccessPolicy)
+                .with('@@validate', () => sdk_1.ExpressionContext.ValidationRule)
+                .otherwise(() => undefined);
+            // get the context allowed for the function
+            const funcAllowedContext = (0, sdk_1.getFunctionExpressionContext)(funcDecl);
+            if (exprContext && !funcAllowedContext.includes(exprContext)) {
+                accept('error', `function "${funcDecl.name}" is not allowed in the current context: ${exprContext}`, {
+                    node: expr,
+                });
+                return;
+            }
+            if (funcAllowedContext.includes(sdk_1.ExpressionContext.AccessPolicy) ||
+                funcAllowedContext.includes(sdk_1.ExpressionContext.ValidationRule)) {
+                // filter operation functions validation
+                // first argument must refer to a model field
+                const firstArg = (_b = (_a = expr.args) === null || _a === void 0 ? void 0 : _a[0]) === null || _b === void 0 ? void 0 : _b.value;
+                if (firstArg) {
+                    if (!(0, ast_utils_1.getDataModelFieldReference)(firstArg)) {
+                        accept('error', 'first argument must be a field reference', { node: firstArg });
+                    }
+                }
+                // second argument must be a literal or array of literal
+                const secondArg = (_d = (_c = expr.args) === null || _c === void 0 ? void 0 : _c[1]) === null || _d === void 0 ? void 0 : _d.value;
+                if (secondArg &&
+                    // literal
+                    !(0, ast_1.isLiteralExpr)(secondArg) &&
+                    // enum field
+                    !(0, sdk_1.isEnumFieldReference)(secondArg) &&
+                    // array of literal/enum
+                    !((0, ast_1.isArrayExpr)(secondArg) &&
+                        secondArg.items.every((item) => (0, ast_1.isLiteralExpr)(item) || (0, sdk_1.isEnumFieldReference)(item)))) {
+                    accept('error', 'second argument must be a literal, an enum, or an array of them', {
+                        node: secondArg,
+                    });
+                }
+            }
+        }
+    }
+    validateArgs(funcDecl, args, accept) {
+        let success = true;
+        for (let i = 0; i < funcDecl.params.length; i++) {
+            const param = funcDecl.params[i];
+            const arg = args[i];
+            if (!arg) {
+                if (!param.optional) {
+                    accept('error', `missing argument for parameter "${param.name}"`, { node: funcDecl });
+                    success = false;
+                }
+            }
+            else {
+                if (!this.validateInvocationArg(arg, param, accept)) {
+                    success = false;
+                }
+            }
+        }
+        // TODO: do we need to complain for extra arguments?
+        return success;
+    }
+    validateInvocationArg(arg, param, accept) {
+        var _a;
+        const argResolvedType = (_a = arg === null || arg === void 0 ? void 0 : arg.value) === null || _a === void 0 ? void 0 : _a.$resolvedType;
+        if (!argResolvedType) {
+            accept('error', 'argument type cannot be resolved', { node: arg });
+            return false;
+        }
+        const dstType = param.type.type;
+        if (!dstType) {
+            accept('error', 'parameter type cannot be resolved', { node: param });
+            return false;
+        }
+        const dstIsArray = param.type.array;
+        const dstRef = param.type.reference;
+        if (dstType === 'Any' && !dstIsArray) {
+            // scalar 'any' can be assigned with anything
+            return true;
+        }
+        if (typeof argResolvedType.decl === 'string') {
+            // scalar type
+            if (!(0, utils_1.typeAssignable)(dstType, argResolvedType.decl, arg.value) || dstIsArray !== argResolvedType.array) {
+                accept('error', `argument is not assignable to parameter`, {
+                    node: arg,
+                });
+                return false;
+            }
+        }
+        else {
+            // enum or model type
+            if (((dstRef === null || dstRef === void 0 ? void 0 : dstRef.ref) !== argResolvedType.decl && dstType !== 'Any') || dstIsArray !== argResolvedType.array) {
+                accept('error', `argument is not assignable to parameter`, {
+                    node: arg,
+                });
+                return false;
+            }
+        }
+        return true;
+    }
+}
+exports.default = FunctionInvocationValidator;
+//# sourceMappingURL=function-invocation-validator.js.map

package/language-server/validator/function-invocation-validator.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"function-invocation-validator.js","sourceRoot":"","sources":["../../../src/language-server/validator/function-invocation-validator.ts"],"names":[],"mappings":";;AAAA,kDAYkC;AAClC,yCAAsH;AAEtH,2CAAsC;AACtC,qDAAmE;AAEnE,mCAAyC;AAEzC;;GAEG;AACH,MAAqB,2BAA2B;IAC5C,QAAQ,CAAC,IAAoB,EAAE,MAA0B;;QACrD,MAAM,QAAQ,GAAG,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC;QACnC,IAAI,CAAC,QAAQ,EAAE;YACX,MAAM,CAAC,OAAO,EAAE,6BAA6B,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;YAC/D,OAAO;SACV;QAED,IAAI,CAAC,IAAI,CAAC,YAAY,CAAC,QAAQ,EAAE,IAAI,CAAC,IAAI,EAAE,MAAM,CAAC,EAAE;YACjD,OAAO;SACV;QAED,IAAI,IAAA,kBAAY,EAAC,QAAQ,CAAC,EAAE;YACxB,sCAAsC;YAEtC,2DAA2D;YAC3D,IAAI,IAAI,GAAwB,IAAI,CAAC,UAAU,CAAC;YAChD,IAAI,kBAA4E,CAAC;YACjF,OAAO,IAAI,EAAE;gBACT,IAAI,IAAA,0BAAoB,EAAC,IAAI,CAAC,IAAI,IAAA,+BAAyB,EAAC,IAAI,CAAC,EAAE;oBAC/D,kBAAkB,GAAG,IAAI,CAAC;oBAC1B,MAAM;iBACT;gBACD,IAAI,GAAG,IAAI,CAAC,UAAU,CAAC;aAC1B;YAED,gDAAgD;YAChD,MAAM,WAAW,GAAG,IAAA,kBAAK,EAAC,kBAAkB,aAAlB,kBAAkB,uBAAlB,kBAAkB,CAAE,IAAI,CAAC,QAAQ,CAAC;iBACvD,IAAI,CAAC,UAAU,EAAE,GAAG,EAAE,CAAC,uBAAiB,CAAC,YAAY,CAAC;iBACtD,IAAI,CAAC,cAAC,CAAC,KAAK,CAAC,SAAS,EAAE,QAAQ,CAAC,EAAE,GAAG,EAAE,CAAC,uBAAiB,CAAC,YAAY,CAAC;iBACxE,IAAI,CAAC,YAAY,EAAE,GAAG,EAAE,CAAC,uBAAiB,CAAC,cAAc,CAAC;iBAC1D,SAAS,CAAC,GAAG,EAAE,CAAC,SAAS,CAAC,CAAC;YAEhC,2CAA2C;YAC3C,MAAM,kBAAkB,GAAG,IAAA,kCAA4B,EAAC,QAAQ,CAAC,CAAC;YAElE,IAAI,WAAW,IAAI,CAAC,kBAAkB,CAAC,QAAQ,CAAC,WAAW,CAAC,EAAE;gBAC1D,MAAM,CAAC,OAAO,EAAE,aAAa,QAAQ,CAAC,IAAI,4CAA4C,WAAW,EAAE,EAAE;oBACjG,IAAI,EAAE,IAAI;iBACb,CAAC,CAAC;gBACH,OAAO;aACV;YAED,IACI,kBAAkB,CAAC,QAAQ,CAAC,uBAAiB,CAAC,YAAY,CAAC;gBAC3D,kBAAkB,CAAC,QAAQ,CAAC,uBAAiB,CAAC,cAAc,CAAC,EAC/D;gBACE,wCAAwC;gBAExC,6CAA6C;gBAC7C,MAAM,QAAQ,GAAG,MAAA,MAAA,IAAI,CAAC,IAAI,0CAAG,CAAC,CAAC,0CAAE,KAAK,CAAC;gBACvC,IAAI,QAAQ,EAAE;oBACV,IAAI,CAAC,IAAA,sCAA0B,EAAC,QAAQ,CAAC,EAAE;wBACvC,MAAM,CAAC,OAAO,EAAE,0CAA0C,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,CAAC,CAAC;qBACnF;iBACJ;gBAED,wDAAwD;gBACxD,MAAM,SAAS,GAAG,MAAA,MAAA,IAAI,CAAC,IAAI,0CAAG,CAAC,CAAC,0CAAE,KAAK,CAAC;gBACxC,IACI,SAAS;oBACT,UAAU;oBACV,CAAC,IAAA,mBAAa,EAAC,SAAS,CAAC;oBACzB,aAAa;oBACb,CAAC,IAAA,0BAAoB,EAAC,SAAS,CAAC;oBAChC,wBAAwB;oBACxB,CAAC,CACG,IAAA,iBAAW,EAAC,SAAS,CAAC;wBACtB,SAAS,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAA,mBAAa,EAAC,IAAI,CAAC,IAAI,IAAA,0BAAoB,EAAC,IAAI,CAAC,CAAC,CACrF,EACH;oBACE,MAAM,CAAC,OAAO,EAAE,iEAAiE,EAAE;wBAC/E,IAAI,EAAE,SAAS;qBAClB,CAAC,CAAC;iBACN;aACJ;SACJ;IACL,CAAC;IAEO,YAAY,CAAC,QAAsB,EAAE,IAAgB,EAAE,MAA0B;QACrF,IAAI,OAAO,GAAG,IAAI,CAAC;QACnB,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE;YAC7C,MAAM,KAAK,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;YACjC,MAAM,GAAG,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;YACpB,IAAI,CAAC,GAAG,EAAE;gBACN,IAAI,CAAC,KAAK,CAAC,QAAQ,EAAE;oBACjB,MAAM,CAAC,OAAO,EAAE,mCAAmC,KAAK,CAAC,IAAI,GAAG,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,CAAC,CAAC;oBACtF,OAAO,GAAG,KAAK,CAAC;iBACnB;aACJ;iBAAM;gBACH,IAAI,CAAC,IAAI,CAAC,qBAAqB,CAAC,GAAG,EAAE,KAAK,EAAE,MAAM,CAAC,EAAE;oBACjD,OAAO,GAAG,KAAK,CAAC;iBACnB;aACJ;SACJ;QACD,oDAAoD;QACpD,OAAO,OAAO,CAAC;IACnB,CAAC;IAEO,qBAAqB,CAAC,GAAa,EAAE,KAAoB,EAAE,MAA0B;;QACzF,MAAM,eAAe,GAAG,MAAA,GAAG,aAAH,GAAG,uBAAH,GAAG,CAAE,KAAK,0CAAE,aAAa,CAAC;QAClD,IAAI,CAAC,eAAe,EAAE;YAClB,MAAM,CAAC,OAAO,EAAE,kCAAkC,EAAE,EAAE,IAAI,EAAE,GAAG,EAAE,CAAC,CAAC;YACnE,OAAO,KAAK,CAAC;SAChB;QAED,MAAM,OAAO,GAAG,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC;QAChC,IAAI,CAAC,OAAO,EAAE;YACV,MAAM,CAAC,OAAO,EAAE,mCAAmC,EAAE,EAAE,IAAI,EAAE,KAAK,EAAE,CAAC,CAAC;YACtE,OAAO,KAAK,CAAC;SAChB;QAED,MAAM,UAAU,GAAG,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC;QACpC,MAAM,MAAM,GAAG,KAAK,CAAC,IAAI,CAAC,SAAS,CAAC;QAEpC,IAAI,OAAO,KAAK,KAAK,IAAI,CAAC,UAAU,EAAE;YAClC,6CAA6C;YAC7C,OAAO,IAAI,CAAC;SACf;QAED,IAAI,OAAO,eAAe,CAAC,IAAI,KAAK,QAAQ,EAAE;YAC1C,cAAc;YACd,IAAI,CAAC,IAAA,sBAAc,EAAC,OAAO,EAAE,eAAe,CAAC,IAAI,EAAE,GAAG,CAAC,KAAK,CAAC,IAAI,UAAU,KAAK,eAAe,CAAC,KAAK,EAAE;gBACnG,MAAM,CAAC,OAAO,EAAE,yCAAyC,EAAE;oBACvD,IAAI,EAAE,GAAG;iBACZ,CAAC,CAAC;gBACH,OAAO,KAAK,CAAC;aAChB;SACJ;aAAM;YACH,qBAAqB;YACrB,IAAI,CAAC,CAAA,MAAM,aAAN,MAAM,uBAAN,MAAM,CAAE,GAAG,MAAK,eAAe,CAAC,IAAI,IAAI,OAAO,KAAK,KAAK,CAAC,IAAI,UAAU,KAAK,eAAe,CAAC,KAAK,EAAE;gBACrG,MAAM,CAAC,OAAO,EAAE,yCAAyC,EAAE;oBACvD,IAAI,EAAE,GAAG;iBACZ,CAAC,CAAC;gBACH,OAAO,KAAK,CAAC;aAChB;SACJ;QAED,OAAO,IAAI,CAAC;IAChB,CAAC;CACJ;AA5ID,8CA4IC"}

package/language-server/validator/schema-validator.d.ts

@@ -1,10 +1,13 @@
 import { Model } from '@zenstackhq/language/ast';
 import { AstValidator } from '../types';
-import { ValidationAcceptor } from 'langium';
+import { LangiumDocuments, ValidationAcceptor } from 'langium';
 /**
  * Validates toplevel schema.
  */
 export default class SchemaValidator implements AstValidator<Model> {
+    protected readonly documents: LangiumDocuments;
+    constructor(documents: LangiumDocuments);
     validate(model: Model, accept: ValidationAcceptor): void;
     private validateDataSources;
+    private validateImports;
 }

package/language-server/validator/schema-validator.js

@@ -3,26 +3,47 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const constants_1 = require("../constants");
 const ast_1 = require("@zenstackhq/language/ast");
 const utils_1 = require("./utils");
+const ast_utils_1 = require("../../utils/ast-utils");
 /**
  * Validates toplevel schema.
  */
 class SchemaValidator {
+    constructor(documents) {
+        this.documents = documents;
+    }
     validate(model, accept) {
-        var _a;
+        var _a, _b;
+        this.validateImports(model, accept);
         (0, utils_1.validateDuplicatedDeclarations)(model.declarations, accept);
-        if (!((_a = model.$document) === null || _a === void 0 ? void 0 : _a.uri.path.endsWith(constants_1.STD_LIB_MODULE_NAME))) {
+        const importedModels = (0, ast_utils_1.resolveTransitiveImports)(this.documents, model);
+        const importedNames = new Set(importedModels.flatMap((m) => m.declarations.map((d) => d.name)));
+        for (const declaration of model.declarations) {
+            if (importedNames.has(declaration.name)) {
+                accept('error', `A ${declaration.name} already exists in an imported module`, {
+                    node: declaration,
+                    property: 'name',
+                });
+            }
+        }
+        if (!((_a = model.$document) === null || _a === void 0 ? void 0 : _a.uri.path.endsWith(constants_1.STD_LIB_MODULE_NAME)) &&
+            !((_b = model.$document) === null || _b === void 0 ? void 0 : _b.uri.path.endsWith(constants_1.PLUGIN_MODULE_NAME))) {
             this.validateDataSources(model, accept);
         }
     }
     validateDataSources(model, accept) {
-        const dataSources = model.declarations.filter((d) => (0, ast_1.isDataSource)(d));
-        if (dataSources.length === 0) {
-            accept('error', 'Model must define a datasource', { node: model });
-        }
-        else if (dataSources.length > 1) {
+        const dataSources = (0, ast_utils_1.getAllDeclarationsFromImports)(this.documents, model).filter((d) => (0, ast_1.isDataSource)(d));
+        if (dataSources.length > 1) {
             accept('error', 'Multiple datasource declarations are not allowed', { node: dataSources[1] });
         }
     }
+    validateImports(model, accept) {
+        model.imports.forEach((imp) => {
+            const importedModel = (0, ast_utils_1.resolveImport)(this.documents, imp);
+            if (!importedModel) {
+                accept('error', `Cannot find model file ${imp.path}.zmodel`, { node: imp });
+            }
+        });
+    }
 }
 exports.default = SchemaValidator;
 //# sourceMappingURL=schema-validator.js.map

package/language-server/validator/schema-validator.js.map

@@ -1 +1 @@
-{"version":3,"file":"schema-validator.js","sourceRoot":"","sources":["../../../src/language-server/validator/schema-validator.ts"],"names":[],"mappings":";;AAAA,4CAAmD;AACnD,kDAA+D;AAG/D,mCAAyD;AAEzD;;GAEG;AACH,MAAqB,eAAe;IAChC,QAAQ,CAAC,KAAY,EAAE,MAA0B;;QAC7C,IAAA,sCAA8B,EAAC,KAAK,CAAC,YAAY,EAAE,MAAM,CAAC,CAAC;QAE3D,IAAI,CAAC,CAAA,MAAA,KAAK,CAAC,SAAS,0CAAE,GAAG,CAAC,IAAI,CAAC,QAAQ,CAAC,+BAAmB,CAAC,CAAA,EAAE;YAC1D,IAAI,CAAC,mBAAmB,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC;SAC3C;IACL,CAAC;IAEO,mBAAmB,CAAC,KAAY,EAAE,MAA0B;QAChE,MAAM,WAAW,GAAG,KAAK,CAAC,YAAY,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAA,kBAAY,EAAC,CAAC,CAAC,CAAC,CAAC;QACtE,IAAI,WAAW,CAAC,MAAM,KAAK,CAAC,EAAE;YAC1B,MAAM,CAAC,OAAO,EAAE,gCAAgC,EAAE,EAAE,IAAI,EAAE,KAAK,EAAE,CAAC,CAAC;SACtE;aAAM,IAAI,WAAW,CAAC,MAAM,GAAG,CAAC,EAAE;YAC/B,MAAM,CAAC,OAAO,EAAE,kDAAkD,EAAE,EAAE,IAAI,EAAE,WAAW,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;SACjG;IACL,CAAC;CACJ;AAjBD,kCAiBC"}
+{"version":3,"file":"schema-validator.js","sourceRoot":"","sources":["../../../src/language-server/validator/schema-validator.ts"],"names":[],"mappings":";;AAAA,4CAAuE;AACvE,kDAA+D;AAG/D,mCAAyD;AACzD,qDAA+G;AAE/G;;GAEG;AACH,MAAqB,eAAe;IAChC,YAA+B,SAA2B;QAA3B,cAAS,GAAT,SAAS,CAAkB;IAAG,CAAC;IAC9D,QAAQ,CAAC,KAAY,EAAE,MAA0B;;QAC7C,IAAI,CAAC,eAAe,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC;QACpC,IAAA,sCAA8B,EAAC,KAAK,CAAC,YAAY,EAAE,MAAM,CAAC,CAAC;QAE3D,MAAM,cAAc,GAAG,IAAA,oCAAwB,EAAC,IAAI,CAAC,SAAS,EAAE,KAAK,CAAC,CAAC;QAEvE,MAAM,aAAa,GAAG,IAAI,GAAG,CAAC,cAAc,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAEhG,KAAK,MAAM,WAAW,IAAI,KAAK,CAAC,YAAY,EAAE;YAC1C,IAAI,aAAa,CAAC,GAAG,CAAC,WAAW,CAAC,IAAI,CAAC,EAAE;gBACrC,MAAM,CAAC,OAAO,EAAE,KAAK,WAAW,CAAC,IAAI,uCAAuC,EAAE;oBAC1E,IAAI,EAAE,WAAW;oBACjB,QAAQ,EAAE,MAAM;iBACnB,CAAC,CAAC;aACN;SACJ;QAED,IACI,CAAC,CAAA,MAAA,KAAK,CAAC,SAAS,0CAAE,GAAG,CAAC,IAAI,CAAC,QAAQ,CAAC,+BAAmB,CAAC,CAAA;YACxD,CAAC,CAAA,MAAA,KAAK,CAAC,SAAS,0CAAE,GAAG,CAAC,IAAI,CAAC,QAAQ,CAAC,8BAAkB,CAAC,CAAA,EACzD;YACE,IAAI,CAAC,mBAAmB,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC;SAC3C;IACL,CAAC;IAEO,mBAAmB,CAAC,KAAY,EAAE,MAA0B;QAChE,MAAM,WAAW,GAAG,IAAA,yCAA6B,EAAC,IAAI,CAAC,SAAS,EAAE,KAAK,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAA,kBAAY,EAAC,CAAC,CAAC,CAAC,CAAC;QACxG,IAAI,WAAW,CAAC,MAAM,GAAG,CAAC,EAAE;YACxB,MAAM,CAAC,OAAO,EAAE,kDAAkD,EAAE,EAAE,IAAI,EAAE,WAAW,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;SACjG;IACL,CAAC;IAEO,eAAe,CAAC,KAAY,EAAE,MAA0B;QAC5D,KAAK,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,GAAG,EAAE,EAAE;YAC1B,MAAM,aAAa,GAAG,IAAA,yBAAa,EAAC,IAAI,CAAC,SAAS,EAAE,GAAG,CAAC,CAAC;YACzD,IAAI,CAAC,aAAa,EAAE;gBAChB,MAAM,CAAC,OAAO,EAAE,0BAA0B,GAAG,CAAC,IAAI,SAAS,EAAE,EAAE,IAAI,EAAE,GAAG,EAAE,CAAC,CAAC;aAC/E;QACL,CAAC,CAAC,CAAC;IACP,CAAC;CACJ;AA1CD,kCA0CC"}

package/language-server/validator/utils.d.ts

@@ -1,4 +1,4 @@
-import { AttributeArg, AttributeParam, BuiltinType, DataModelAttribute, DataModelFieldAttribute, Expression, ExpressionType } from '@zenstackhq/language/ast';
+import { AttributeArg, AttributeParam, BuiltinType, DataModelAttribute, DataModelFieldAttribute, Expression, ExpressionType, InternalAttribute } from '@zenstackhq/language/ast';
 import { AstNode, ValidationAcceptor } from 'langium';
 /**
  * Checks if the given declarations have duplicated names
@@ -17,9 +17,8 @@ export declare function typeAssignable(destType: ExpressionType, sourceType: Exp
 /**
  * Maps a ZModel builtin type to expression type
  */
-export declare function mapBuiltinTypeToExpressionType(type: BuiltinType | 'Any' | 'Null'): ExpressionType | 'Any';
+export declare function mapBuiltinTypeToExpressionType(type: BuiltinType | 'Any' | 'Object' | 'Null' | 'Unsupported'): ExpressionType | 'Any';
 /**
  * Determines if the given attribute argument is assignable to the given attribute parameter
  */
-export declare function assignableToAttributeParam(arg: AttributeArg, param: AttributeParam, attr: DataModelAttribute | DataModelFieldAttribute): boolean;
-export declare function validateAttributeApplication(attr: DataModelAttribute | DataModelFieldAttribute, accept: ValidationAcceptor): boolean | undefined;
+export declare function assignableToAttributeParam(arg: AttributeArg, param: AttributeParam, attr: DataModelAttribute | DataModelFieldAttribute | InternalAttribute): boolean;

package/language-server/validator/utils.js

@@ -1,12 +1,8 @@
 "use strict";
-var __importDefault = (this && this.__importDefault) || function (mod) {
-    return (mod && mod.__esModule) ? mod : { "default": mod };
-};
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.validateAttributeApplication = exports.assignableToAttributeParam = exports.mapBuiltinTypeToExpressionType = exports.typeAssignable = exports.getStringLiteral = exports.validateDuplicatedDeclarations = void 0;
+exports.assignableToAttributeParam = exports.mapBuiltinTypeToExpressionType = exports.typeAssignable = exports.getStringLiteral = exports.validateDuplicatedDeclarations = void 0;
 const ast_1 = require("@zenstackhq/language/ast");
 const sdk_1 = require("@zenstackhq/sdk");
-const pluralize_1 = __importDefault(require("pluralize"));
 /**
  * Checks if the given declarations have duplicated names
  */
@@ -19,8 +15,15 @@ function validateDuplicatedDeclarations(decls, accept) {
     }, {});
     for (const [name, decls] of Object.entries(groupByName)) {
         if (decls.length > 1) {
+            let errorField = decls[1];
+            if (decls[0].$type === 'DataModelField') {
+                const nonInheritedFields = decls.filter((x) => !x.$isInherited);
+                if (nonInheritedFields.length > 0) {
+                    errorField = nonInheritedFields.slice(-1)[0];
+                }
+            }
             accept('error', `Duplicated declaration name "${name}"`, {
-                node: decls[1],
+                node: errorField,
             });
         }
     }
@@ -30,12 +33,7 @@ exports.validateDuplicatedDeclarations = validateDuplicatedDeclarations;
  * Try getting string value from a potential string literal expression
  */
 function getStringLiteral(node) {
-    if ((0, ast_1.isLiteralExpr)(node) && typeof node.value === 'string') {
-        return node.value;
-    }
-    else {
-        return undefined;
-    }
+    return (0, ast_1.isStringLiteral)(node) ? node.value : undefined;
 }
 exports.getStringLiteral = getStringLiteral;
 const isoDateTimeRegex = /^\d{4}(-\d\d(-\d\d(T\d\d:\d\d(:\d\d)?(\.\d+)?(([+-]\d\d:\d\d)|Z)?)?)?)?$/i;
@@ -44,7 +42,7 @@ const isoDateTimeRegex = /^\d{4}(-\d\d(-\d\d(T\d\d:\d\d(:\d\d)?(\.\d+)?(([+-]\d\
  */
 function typeAssignable(destType, sourceType, sourceExpr) {
     // implicit conversion from ISO datetime string to datetime
-    if (destType === 'DateTime' && sourceType === 'String' && sourceExpr && (0, ast_1.isLiteralExpr)(sourceExpr)) {
+    if (destType === 'DateTime' && sourceType === 'String' && sourceExpr && (0, ast_1.isStringLiteral)(sourceExpr)) {
         const literal = getStringLiteral(sourceExpr);
         if (literal && isoDateTimeRegex.test(literal)) {
             // implicitly convert to DateTime
@@ -81,6 +79,10 @@ function mapBuiltinTypeToExpressionType(type) {
         case 'Json':
         case 'Bytes':
             return 'Any';
+        case 'Object':
+            return 'Object';
+        case 'Unsupported':
+            return 'Unsupported';
     }
 }
 exports.mapBuiltinTypeToExpressionType = mapBuiltinTypeToExpressionType;
@@ -96,6 +98,9 @@ function assignableToAttributeParam(arg, param, attr) {
     let dstType = param.type.type;
     let dstIsArray = param.type.array;
     const dstRef = param.type.reference;
+    if (dstType === 'Any' && !dstIsArray) {
+        return true;
+    }
     // destination is field reference or transitive field reference, check if
     // argument is reference or array or reference
     if (dstType === 'FieldReference' || dstType === 'TransitiveFieldReference') {
@@ -138,120 +143,12 @@ function assignableToAttributeParam(arg, param, attr) {
                 dstType = 'Any';
             }
         }
-        return (typeAssignable(dstType, argResolvedType.decl, arg.value) &&
-            (dstType === 'Any' || dstIsArray === argResolvedType.array));
+        return typeAssignable(dstType, argResolvedType.decl, arg.value) && dstIsArray === argResolvedType.array;
     }
     else {
         // reference type
-        return (dstRef === null || dstRef === void 0 ? void 0 : dstRef.ref) === argResolvedType.decl && dstIsArray === argResolvedType.array;
+        return ((dstRef === null || dstRef === void 0 ? void 0 : dstRef.ref) === argResolvedType.decl || dstType === 'Any') && dstIsArray === argResolvedType.array;
     }
 }
 exports.assignableToAttributeParam = assignableToAttributeParam;
-function validateAttributeApplication(attr, accept) {
-    const decl = attr.decl.ref;
-    if (!decl) {
-        return;
-    }
-    const targetDecl = attr.$container;
-    if (decl.name === '@@@targetField' && !(0, ast_1.isAttribute)(targetDecl)) {
-        accept('error', `attribute "${decl.name}" can only be used on attribute declarations`, { node: attr });
-        return;
-    }
-    if ((0, ast_1.isDataModelField)(targetDecl) && !isValidAttributeTarget(decl, targetDecl)) {
-        accept('error', `attribute "${decl.name}" cannot be used on this type of field`, { node: attr });
-    }
-    const filledParams = new Set();
-    for (const arg of attr.args) {
-        let paramDecl;
-        if (!arg.name) {
-            paramDecl = decl.params.find((p) => p.default && !filledParams.has(p));
-            if (!paramDecl) {
-                accept('error', `Unexpected unnamed argument`, {
-                    node: arg,
-                });
-                return false;
-            }
-        }
-        else {
-            paramDecl = decl.params.find((p) => p.name === arg.name);
-            if (!paramDecl) {
-                accept('error', `Attribute "${decl.name}" doesn't have a parameter named "${arg.name}"`, {
-                    node: arg,
-                });
-                return false;
-            }
-        }
-        if (!assignableToAttributeParam(arg, paramDecl, attr)) {
-            accept('error', `Value is not assignable to parameter`, {
-                node: arg,
-            });
-            return false;
-        }
-        if (filledParams.has(paramDecl)) {
-            accept('error', `Parameter "${paramDecl.name}" is already provided`, { node: arg });
-            return false;
-        }
-        filledParams.add(paramDecl);
-        arg.$resolvedParam = paramDecl;
-    }
-    const missingParams = decl.params.filter((p) => !p.type.optional && !filledParams.has(p));
-    if (missingParams.length > 0) {
-        accept('error', `Required ${(0, pluralize_1.default)('parameter', missingParams.length)} not provided: ${missingParams
-            .map((p) => p.name)
-            .join(', ')}`, { node: attr });
-        return false;
-    }
-    return true;
-}
-exports.validateAttributeApplication = validateAttributeApplication;
-function isValidAttributeTarget(attrDecl, targetDecl) {
-    var _a;
-    const targetField = attrDecl.attributes.find((attr) => { var _a; return ((_a = attr.decl.ref) === null || _a === void 0 ? void 0 : _a.name) === '@@@targetField'; });
-    if (!targetField) {
-        // no field type constraint
-        return true;
-    }
-    const fieldTypes = targetField.args[0].value.items.map((item) => { var _a; return (_a = item.target.ref) === null || _a === void 0 ? void 0 : _a.name; });
-    let allowed = false;
-    for (const allowedType of fieldTypes) {
-        switch (allowedType) {
-            case 'StringField':
-                allowed = allowed || targetDecl.type.type === 'String';
-                break;
-            case 'IntField':
-                allowed = allowed || targetDecl.type.type === 'Int';
-                break;
-            case 'BigIntField':
-                allowed = allowed || targetDecl.type.type === 'BigInt';
-                break;
-            case 'FloatField':
-                allowed = allowed || targetDecl.type.type === 'Float';
-                break;
-            case 'DecimalField':
-                allowed = allowed || targetDecl.type.type === 'Decimal';
-                break;
-            case 'BooleanField':
-                allowed = allowed || targetDecl.type.type === 'Boolean';
-                break;
-            case 'DateTimeField':
-                allowed = allowed || targetDecl.type.type === 'DateTime';
-                break;
-            case 'JsonField':
-                allowed = allowed || targetDecl.type.type === 'Json';
-                break;
-            case 'BytesField':
-                allowed = allowed || targetDecl.type.type === 'Bytes';
-                break;
-            case 'ModelField':
-                allowed = allowed || (0, ast_1.isDataModel)((_a = targetDecl.type.reference) === null || _a === void 0 ? void 0 : _a.ref);
-                break;
-            default:
-                break;
-        }
-        if (allowed) {
-            break;
-        }
-    }
-    return allowed;
-}
 //# sourceMappingURL=utils.js.map