zelari-code 2.25.0 → 2.27.0

package/dist/cli/workspace/taskTouchGuard.js

@@ -0,0 +1,181 @@
+/**
+ * taskTouchGuard — declared-vs-observed hygiene guard (t58, plan P1.5).
+ *
+ * Watches post-result write events (t57 ToolRegistry post-result seam) and
+ * flags `completed` tasks whose declared `files` globs are touched by a
+ * LATER session (cross-session rule: sessionStartedAt > completedAt, so the
+ * session that completes a task never auto-flags itself).
+ *
+ * On a match (best-effort, total fail-open — this code must never break a
+ * tool call):
+ *  - one `task_reopened` radio event per task per session
+ *    (`.zelari/radio/<sessionId>.jsonl`, agent `task-guard`);
+ *  - flags.push('reopened') + an appendNote on the plan task, through
+ *    withPlanStore so the shared workspace mutex keeps it consistent with
+ *    concurrent `task_update` calls.
+ *
+ * Supported glob vocabulary (documented, minimal — no new deps):
+ *  - exact root-relative path:      src/cli/foo.ts
+ *  - directory subtree (recursive): src followed by double-star
+ *  - extension suffix (any depth):  *.ts  (leading double-star prefix also ok)
+ *
+ * Excluded, never matched: .zelari, node_modules, dist, build subtrees
+ * (plan.json itself changes constantly by design).
+ *
+ * @since v2.26.0 (t58)
+ */
+import { existsSync } from 'node:fs';
+import path from 'node:path';
+import { appendKrakenRadio } from '../tools/krakenRadio.js';
+import { PLAN_NOTES_MAX, planJsonPathFor, withPlanStore } from './planStore.js';
+/** Native mutating tools (catalog names) + MCP filesystem variants. */
+const NATIVE_WRITE_TOOLS = new Set([
+    'write_file',
+    'edit',
+    'edit_file',
+    'apply_diff',
+]);
+const MCP_FS_WRITE_RE = /^mcp_filesystem_(write_file|edit_file|move_file|create_directory)$/;
+const EXCLUDED_DIR_PREFIXES = ['.zelari/', 'node_modules/', 'dist/', 'build/'];
+export function isMutatingToolName(name) {
+    return NATIVE_WRITE_TOOLS.has(name) || MCP_FS_WRITE_RE.test(name);
+}
+/**
+ * Normalize a tool-supplied path to a root-relative POSIX path.
+ * Absolute paths outside `projectRoot` (and Windows drive crossings) → null.
+ */
+export function toPosixRel(projectRoot, p) {
+    const raw = p.trim().replace(/\\/g, '/');
+    if (raw.startsWith('/') || /^[a-zA-Z]:\//.test(raw)) {
+        let rel;
+        try {
+            rel = path.relative(projectRoot, p);
+        }
+        catch {
+            return null;
+        }
+        if (!rel || rel.startsWith('..') || path.isAbsolute(rel))
+            return null;
+        return rel.replace(/\\/g, '/');
+    }
+    return raw.replace(/^\.\//, '');
+}
+/** Pull the mutated path out of a mutating tool's args (MCP uses `file_path`). */
+export function extractWriteTarget(toolName, toolInput) {
+    if (!isMutatingToolName(toolName))
+        return null;
+    const args = (toolInput ?? {});
+    for (const key of ['path', 'file_path', 'source', 'destination']) {
+        const v = args[key];
+        if (typeof v === 'string' && v.trim())
+            return v.trim();
+    }
+    return null;
+}
+function normalizePattern(raw) {
+    return raw.replace(/\\/g, '/').replace(/^\.\//, '').replace(/^\*\*\//, '');
+}
+/**
+ * Match a root-relative path against declared task globs.
+ * Excluded dirs (.zelari, node_modules, dist, build) never match.
+ */
+export function matchTaskFiles(patterns, relPath) {
+    if (EXCLUDED_DIR_PREFIXES.some((p) => relPath.startsWith(p)))
+        return false;
+    for (const raw of patterns) {
+        const pat = normalizePattern(raw);
+        if (!pat)
+            continue;
+        if (pat === relPath)
+            return true;
+        if (pat.endsWith('/**')) {
+            if (relPath.startsWith(pat.slice(0, -2)))
+                return true;
+        }
+        else if (pat.includes('*')) {
+            const star = pat.indexOf('*');
+            const suffix = pat.slice(star + 1);
+            if (suffix && !suffix.includes('*') && relPath.endsWith(suffix))
+                return true;
+        }
+    }
+    return false;
+}
+/**
+ * Build the t57 listener. Every inspection is chained onto an internal
+ * promise queue so tests (and shutdown paths) can drain() it; the listener
+ * itself stays synchronous and never throws (total fail-open).
+ */
+export function createTaskTouchGuard(opts) {
+    const root = opts.projectRoot;
+    const sessionId = opts.sessionId;
+    const sessionStartedAt = (opts.now ?? Date.now)();
+    const flagged = new Set();
+    let chain = Promise.resolve();
+    const listener = (event) => {
+        try {
+            if (!event.ok)
+                return;
+            const target = extractWriteTarget(event.toolName, event.toolInput);
+            if (!target)
+                return;
+            const rel = toPosixRel(root, target);
+            if (!rel)
+                return;
+            chain = chain.then(() => inspectWrite(rel)).catch(() => undefined);
+        }
+        catch {
+            // fail-open: the guard must never break a tool result
+        }
+    };
+    listener.drain = () => chain;
+    return listener;
+    async function inspectWrite(rel) {
+        try {
+            const planPath = planJsonPathFor(root);
+            if (!existsSync(planPath))
+                return;
+            const tasks = await withPlanStore(root, (store) => store.tasks);
+            for (const task of tasks) {
+                if (task.status !== 'completed' || !task.files?.length || !task.completedAt)
+                    continue;
+                if (flagged.has(task.id))
+                    continue;
+                const doneAt = Date.parse(task.completedAt);
+                if (!Number.isFinite(doneAt) || sessionStartedAt <= doneAt)
+                    continue;
+                if (!matchTaskFiles(task.files, rel))
+                    continue;
+                flagged.add(task.id);
+                appendKrakenRadio(root, sessionId, {
+                    kind: 'task_reopened',
+                    agent: 'task-guard',
+                    description: `completed task ${task.id} file touched after completion`,
+                    contestedFile: rel,
+                    ok: true,
+                    detail: `${task.title} — ${rel}`,
+                });
+                try {
+                    await withPlanStore(root, (store) => {
+                        const live = store.tasks.find((t) => t.id === task.id);
+                        if (!live)
+                            return;
+                        const flags = Array.isArray(live.flags) ? [...live.flags] : [];
+                        if (!flags.includes('reopened'))
+                            live.flags = [...flags, 'reopened'];
+                        const stamp = new Date(sessionStartedAt).toISOString();
+                        const note = `[task-guard ${stamp}] ${rel} modified after completion (reopened)`;
+                        live.notes = `${live.notes ? `${live.notes}\n` : ''}${note}`.slice(0, PLAN_NOTES_MAX);
+                    });
+                }
+                catch {
+                    // flag/note are best-effort; the radio event already went out
+                }
+            }
+        }
+        catch {
+            // fail-open (missing/corrupt plan.json, radio io, …)
+        }
+    }
+}
+//# sourceMappingURL=taskTouchGuard.js.map

package/dist/cli/workspace/taskTouchGuard.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"taskTouchGuard.js","sourceRoot":"","sources":["../../../src/cli/workspace/taskTouchGuard.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;GAyBG;AAEH,OAAO,EAAE,UAAU,EAAE,MAAM,SAAS,CAAC;AACrC,OAAO,IAAI,MAAM,WAAW,CAAC;AAC7B,OAAO,EAAE,iBAAiB,EAAE,MAAM,yBAAyB,CAAC;AAC5D,OAAO,EAAE,cAAc,EAAE,eAAe,EAAE,aAAa,EAAE,MAAM,gBAAgB,CAAC;AAGhF,uEAAuE;AACvE,MAAM,kBAAkB,GAAwB,IAAI,GAAG,CAAC;IACtD,YAAY;IACZ,MAAM;IACN,WAAW;IACX,YAAY;CACb,CAAC,CAAC;AACH,MAAM,eAAe,GAAG,oEAAoE,CAAC;AAE7F,MAAM,qBAAqB,GAAG,CAAC,UAAU,EAAE,eAAe,EAAE,OAAO,EAAE,QAAQ,CAAC,CAAC;AAgB/E,MAAM,UAAU,kBAAkB,CAAC,IAAY;IAC7C,OAAO,kBAAkB,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AACpE,CAAC;AAED;;;GAGG;AACH,MAAM,UAAU,UAAU,CAAC,WAAmB,EAAE,CAAS;IACvD,MAAM,GAAG,GAAG,CAAC,CAAC,IAAI,EAAE,CAAC,OAAO,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC;IACzC,IAAI,GAAG,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,cAAc,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC;QACpD,IAAI,GAAW,CAAC;QAChB,IAAI,CAAC;YACH,GAAG,GAAG,IAAI,CAAC,QAAQ,CAAC,WAAW,EAAE,CAAC,CAAC,CAAC;QACtC,CAAC;QAAC,MAAM,CAAC;YACP,OAAO,IAAI,CAAC;QACd,CAAC;QACD,IAAI,CAAC,GAAG,IAAI,GAAG,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC;YAAE,OAAO,IAAI,CAAC;QACtE,OAAO,GAAG,CAAC,OAAO,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC;IACjC,CAAC;IACD,OAAO,GAAG,CAAC,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;AAClC,CAAC;AAED,kFAAkF;AAClF,MAAM,UAAU,kBAAkB,CAAC,QAAgB,EAAE,SAAkB;IACrE,IAAI,CAAC,kBAAkB,CAAC,QAAQ,CAAC;QAAE,OAAO,IAAI,CAAC;IAC/C,MAAM,IAAI,GAAG,CAAC,SAAS,IAAI,EAAE,CAA4B,CAAC;IAC1D,KAAK,MAAM,GAAG,IAAI,CAAC,MAAM,EAAE,WAAW,EAAE,QAAQ,EAAE,aAAa,CAAC,EAAE,CAAC;QACjE,MAAM,CAAC,GAAG,IAAI,CAAC,GAAG,CAAC,CAAC;QACpB,IAAI,OAAO,CAAC,KAAK,QAAQ,IAAI,CAAC,CAAC,IAAI,EAAE;YAAE,OAAO,CAAC,CAAC,IAAI,EAAE,CAAC;IACzD,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC;AAED,SAAS,gBAAgB,CAAC,GAAW;IACnC,OAAO,GAAG,CAAC,OAAO,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC;AAC7E,CAAC;AAED;;;GAGG;AACH,MAAM,UAAU,cAAc,CAAC,QAA2B,EAAE,OAAe;IACzE,IAAI,qBAAqB,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC;QAAE,OAAO,KAAK,CAAC;IAC3E,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;QAC3B,MAAM,GAAG,GAAG,gBAAgB,CAAC,GAAG,CAAC,CAAC;QAClC,IAAI,CAAC,GAAG;YAAE,SAAS;QACnB,IAAI,GAAG,KAAK,OAAO;YAAE,OAAO,IAAI,CAAC;QACjC,IAAI,GAAG,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,CAAC;YACxB,IAAI,OAAO,CAAC,UAAU,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;gBAAE,OAAO,IAAI,CAAC;QACxD,CAAC;aAAM,IAAI,GAAG,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC;YAC7B,MAAM,IAAI,GAAG,GAAG,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC;YAC9B,MAAM,MAAM,GAAG,GAAG,CAAC,KAAK,CAAC,IAAI,GAAG,CAAC,CAAC,CAAC;YACnC,IAAI,MAAM,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,GAAG,CAAC,IAAI,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAC;gBAAE,OAAO,IAAI,CAAC;QAC/E,CAAC;IACH,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAWD;;;;GAIG;AACH,MAAM,UAAU,oBAAoB,CAAC,IAA2B;IAC9D,MAAM,IAAI,GAAG,IAAI,CAAC,WAAW,CAAC;IAC9B,MAAM,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC;IACjC,MAAM,gBAAgB,GAAG,CAAC,IAAI,CAAC,GAAG,IAAI,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC;IAClD,MAAM,OAAO,GAAG,IAAI,GAAG,EAAU,CAAC;IAClC,IAAI,KAAK,GAAkB,OAAO,CAAC,OAAO,EAAE,CAAC;IAE7C,MAAM,QAAQ,GAAG,CAAC,KAAqB,EAAQ,EAAE;QAC/C,IAAI,CAAC;YACH,IAAI,CAAC,KAAK,CAAC,EAAE;gBAAE,OAAO;YACtB,MAAM,MAAM,GAAG,kBAAkB,CAAC,KAAK,CAAC,QAAQ,EAAE,KAAK,CAAC,SAAS,CAAC,CAAC;YACnE,IAAI,CAAC,MAAM;gBAAE,OAAO;YACpB,MAAM,GAAG,GAAG,UAAU,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;YACrC,IAAI,CAAC,GAAG;gBAAE,OAAO;YACjB,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,GAAG,EAAE,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC,CAAC,KAAK,CAAC,GAAG,EAAE,CAAC,SAAS,CAAC,CAAC;QACrE,CAAC;QAAC,MAAM,CAAC;YACP,sDAAsD;QACxD,CAAC;IACH,CAAC,CAAC;IACF,QAAQ,CAAC,KAAK,GAAG,GAAG,EAAE,CAAC,KAAK,CAAC;IAC7B,OAAO,QAAQ,CAAC;IAEhB,KAAK,UAAU,YAAY,CAAC,GAAW;QACrC,IAAI,CAAC;YACH,MAAM,QAAQ,GAAG,eAAe,CAAC,IAAI,CAAC,CAAC;YACvC,IAAI,CAAC,UAAU,CAAC,QAAQ,CAAC;gBAAE,OAAO;YAClC,MAAM,KAAK,GAAe,MAAM,aAAa,CAAC,IAAI,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;YAC5E,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;gBACzB,IAAI,IAAI,CAAC,MAAM,KAAK,WAAW,IAAI,CAAC,IAAI,CAAC,KAAK,EAAE,MAAM,IAAI,CAAC,IAAI,CAAC,WAAW;oBAAE,SAAS;gBACtF,IAAI,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;oBAAE,SAAS;gBACnC,MAAM,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;gBAC5C,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,gBAAgB,IAAI,MAAM;oBAAE,SAAS;gBACrE,IAAI,CAAC,cAAc,CAAC,IAAI,CAAC,KAAK,EAAE,GAAG,CAAC;oBAAE,SAAS;gBAC/C,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;gBACrB,iBAAiB,CAAC,IAAI,EAAE,SAAS,EAAE;oBACjC,IAAI,EAAE,eAAe;oBACrB,KAAK,EAAE,YAAY;oBACnB,WAAW,EAAE,kBAAkB,IAAI,CAAC,EAAE,gCAAgC;oBACtE,aAAa,EAAE,GAAG;oBAClB,EAAE,EAAE,IAAI;oBACR,MAAM,EAAE,GAAG,IAAI,CAAC,KAAK,MAAM,GAAG,EAAE;iBACjC,CAAC,CAAC;gBACH,IAAI,CAAC;oBACH,MAAM,aAAa,CAAC,IAAI,EAAE,CAAC,KAAK,EAAE,EAAE;wBAClC,MAAM,IAAI,GAAG,KAAK,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,IAAI,CAAC,EAAE,CAAC,CAAC;wBACvD,IAAI,CAAC,IAAI;4BAAE,OAAO;wBAClB,MAAM,KAAK,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;wBAC/D,IAAI,CAAC,KAAK,CAAC,QAAQ,CAAC,UAAU,CAAC;4BAAE,IAAI,CAAC,KAAK,GAAG,CAAC,GAAG,KAAK,EAAE,UAAU,CAAC,CAAC;wBACrE,MAAM,KAAK,GAAG,IAAI,IAAI,CAAC,gBAAgB,CAAC,CAAC,WAAW,EAAE,CAAC;wBACvD,MAAM,IAAI,GAAG,eAAe,KAAK,KAAK,GAAG,uCAAuC,CAAC;wBACjF,IAAI,CAAC,KAAK,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,GAAG,IAAI,CAAC,KAAK,IAAI,CAAC,CAAC,CAAC,EAAE,GAAG,IAAI,EAAE,CAAC,KAAK,CAAC,CAAC,EAAE,cAAc,CAAC,CAAC;oBACxF,CAAC,CAAC,CAAC;gBACL,CAAC;gBAAC,MAAM,CAAC;oBACP,8DAA8D;gBAChE,CAAC;YACH,CAAC;QACH,CAAC;QAAC,MAAM,CAAC;YACP,qDAAqD;QACvD,CAAC;IACH,CAAC;AACH,CAAC"}

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "zelari-code",
-  "version": "2.25.0",
-  "description": "Zelari Code — AI Council coding agent CLI. Multi-agent orchestration (Caronte, Nettuno, Gerione, Plutone, Minosse, Lucifero) with slash commands, provider-agnostic LLM streaming, and self-update.",
+  "version": "2.27.0",
+  "description": "Zelari Code — open-source coding orchestrator CLI. You choose the model; the proof is mandatory. Kraken by default, council when the work earns it: plan/build phases, provider-agnostic LLM streaming, self-update.",
   "author": "Anathema Studio <https://anathema-studio.com/>",
   "license": "Apache-2.0",
   "type": "module",
@@ -53,6 +53,7 @@
     "evolve:propose": "node --experimental-strip-types tools/eval/runEvolvePropose.ts",
     "evolve:decide": "node --experimental-strip-types tools/eval/runEvolveDecide.ts",
     "evolve:validate": "node --experimental-strip-types tools/eval/runEvolveValidate.ts",
+    "edit:bench": "node --experimental-strip-types tools/eval/runEditBench.ts",
     "test:eval": "vitest run tools/eval",
     "test:memory": "vitest run packages/core/src/memory/scoring.test.ts tests/unit/core-agentHarness-memory.test.ts tests/unit/cli-sqliteMemoryV2.test.ts tests/unit/cli-memorySemantic.test.ts tests/unit/cli-memoryMigration.test.ts tests/unit/cli-memoryMcp.test.ts tests/unit/cli-memoryJsonApi.test.ts tests/unit/cli-memoryCommands.test.ts tests/unit/cli-memoryPerformance.test.ts tests/unit/cli-kraken-sharedMemory.test.ts tests/unit/cli-semantic.test.ts tools/eval/memoryMetrics.test.ts"
   },
@@ -65,7 +66,7 @@
   },
   "devDependencies": {
     "@testing-library/react": "^16.3.2",
-    "@zelari/core": "2.25.0",
+    "@zelari/core": "2.27.0",
     "@types/node": "^25.3.0",
     "@types/react": "^19.0.10",
     "esbuild": "^0.25.0",