zdymak 0.4.0 → 0.5.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "zdymak",
-  "version": "0.4.0",
+  "version": "0.5.0",
   "description": "Generate premium, spec-compliant App Store & Google Play preview videos (and store assets) from screenshots — one config-driven CLI across all your projects.",
   "type": "module",
   "bin": {

package/src/capture/index.mjs

@@ -19,8 +19,9 @@ import { spawn, spawnSync } from 'node:child_process';
 import fs from 'node:fs';
 import path from 'node:path';
 import { createCanvas, loadImage } from '@napi-rs/canvas';
+import { rgbPngBuffer } from '../png.mjs';
 
-/** Flatten alpha over black and rewrite as an opaque PNG (App Store & Play reject alpha on screenshots). */
+/** Flatten over black and rewrite as a NO-ALPHA RGB PNG (App Store & Play reject alpha on screenshots). */
 async function stripAlpha(file) {
   const img = await loadImage(file);
   const c = createCanvas(img.width, img.height);
@@ -28,7 +29,7 @@ async function stripAlpha(file) {
   ctx.fillStyle = '#000';
   ctx.fillRect(0, 0, img.width, img.height);
   ctx.drawImage(img, 0, 0);
-  fs.writeFileSync(file, c.toBuffer('image/png'));
+  fs.writeFileSync(file, rgbPngBuffer(c)); // colour-type-2 PNG, no alpha channel
 }
 
 function sh(cmd, args) {
@@ -68,9 +69,16 @@ function bootIosSim(flags) {
   return udid;
 }
 
+const simctlOk = () => spawnSync('xcrun', ['simctl', 'help'], { stdio: 'ignore' }).status === 0;
+
 async function captureIos(flags) {
-  if (spawnSync('xcrun', ['simctl', 'help'], { stdio: 'ignore' }).status !== 0) {
-    throw new Error('xcrun/simctl not found — install Xcode command-line tools.');
+  if (!simctlOk()) {
+    // Common when xcode-select points at the CommandLineTools (no simctl): fall back to Xcode.app.
+    const xc = '/Applications/Xcode.app/Contents/Developer';
+    if (!process.env.DEVELOPER_DIR && fs.existsSync(xc)) process.env.DEVELOPER_DIR = xc;
+    if (!simctlOk()) {
+      throw new Error('xcrun/simctl unavailable — point DEVELOPER_DIR at Xcode (e.g. xcode-select -s /Applications/Xcode.app).');
+    }
   }
   const outDir = path.resolve(flags.out || 'shots');
   fs.mkdirSync(outDir, { recursive: true });
@@ -93,7 +101,7 @@ async function captureIos(flags) {
     }
     const states = flags.states.split(',').map((s) => s.trim()).filter(Boolean);
     const suffix = flags.suffix || '';
-    const settle = Number(flags.settle || 3);
+    const settle = Number(flags.settle || 4);
     const udid = bootIosSim(flags);
 
     if (flags.build !== undefined) {
@@ -108,9 +116,10 @@ async function captureIos(flags) {
       sh('xcrun', ['simctl', 'install', udid, app]);
     }
 
-    // Pin the canonical 9:41 marketing status bar (best-effort).
+    // Pin Apple's canonical marketing status bar: 9:41, full signal/wifi, FULL battery but NOT charging
+    // (a charging bolt reads as a simulator override; Apple's own shots show an unplugged full battery).
     spawnSync('xcrun', ['simctl', 'status_bar', udid, 'override', '--time', '9:41',
-      '--batteryState', 'charging', '--batteryLevel', '100', '--cellularBars', '4', '--wifiBars', '3'], { stdio: 'ignore' });
+      '--batteryState', 'discharging', '--batteryLevel', '100', '--cellularBars', '4', '--wifiBars', '3'], { stdio: 'ignore' });
 
     console.log(`▶︎ Driving ${states.length} screens via "${flags.arg} <id>" on ${flags.bundle}…`);
     for (const st of states) {
@@ -133,6 +142,20 @@ async function captureIos(flags) {
   console.log(`✓ ${out}  (alpha stripped, store-ready)`);
 }
 
+/** Toggle Android SystemUI Demo Mode → a clean, Play-native status bar (Google's own convention):
+ *  pinned clock, full battery UNPLUGGED (no charging), full signal/wifi, notifications hidden. */
+function androidDemo(on, flags) {
+  const b = (...args) => spawnSync('adb', ['shell', 'am', 'broadcast', '-a', 'com.android.systemui.demo', ...args], { stdio: 'ignore' });
+  if (!on) return void b('-e', 'command', 'exit');
+  spawnSync('adb', ['shell', 'settings', 'put', 'global', 'sysui_demo_allowed', '1'], { stdio: 'ignore' });
+  b('-e', 'command', 'enter');
+  b('-e', 'command', 'clock', '-e', 'hhmm', (flags.time || '09:41').replace(':', ''));
+  b('-e', 'command', 'battery', '-e', 'level', '100', '-e', 'plugged', 'false'); // full, NOT charging
+  b('-e', 'command', 'network', '-e', 'wifi', 'show', '-e', 'level', '4');
+  b('-e', 'command', 'network', '-e', 'mobile', 'show', '-e', 'datatype', 'none', '-e', 'level', '4');
+  b('-e', 'command', 'notifications', '-e', 'visible', 'false');
+}
+
 async function captureAndroid(flags) {
   if (spawnSync('adb', ['version'], { stdio: 'ignore' }).status !== 0) {
     throw new Error('adb not found — install Android platform-tools and connect a device/emulator.');
@@ -151,18 +174,69 @@ async function captureAndroid(flags) {
     return;
   }
 
-  const name = flags.name || 'shot';
-  const out = path.join(outDir, `${name}.png`);
-  const buf = spawnSync('adb', ['exec-out', 'screencap', '-p'], { maxBuffer: 64 * 1024 * 1024 });
-  if (buf.status !== 0) throw new Error(`adb screencap failed: ${buf.stderr}`);
-  fs.writeFileSync(out, buf.stdout);
-  await stripAlpha(out);
-  console.log(`✓ ${out}  (alpha stripped, store-ready)`);
+  const grab = async (file) => {
+    const b = spawnSync('adb', ['exec-out', 'screencap', '-p'], { maxBuffer: 64 * 1024 * 1024 });
+    if (b.status !== 0) throw new Error(`adb screencap failed: ${b.stderr}`);
+    fs.writeFileSync(file, b.stdout);
+    await stripAlpha(file);
+  };
+
+  androidDemo(true, flags); // clean marketing status bar (Google convention)
+  try {
+    // Full workflow: drive the app through screens via an intent-extra HANDLE (--component + --arg).
+    if (flags.states) {
+      if (!flags.component || !flags.arg) {
+        throw new Error('android state capture needs --component <pkg/activity> and --arg <extra-key>.');
+      }
+      const states = flags.states.split(',').map((s) => s.trim()).filter(Boolean);
+      const suffix = flags.suffix || '';
+      const settle = Number(flags.settle || 4);
+      console.log(`▶︎ Driving ${states.length} screens via "--es ${flags.arg} <id>" on ${flags.component}…`);
+      for (const st of states) {
+        sh('adb', ['shell', 'am', 'start', '-n', flags.component, '--es', flags.arg, st]);
+        await sleep(settle * 1000);
+        const out = path.join(outDir, `${st}${suffix}.png`);
+        await grab(out);
+        console.log(`   ✓ ${st}${suffix}.png`);
+      }
+      console.log(`Done → ${outDir}`);
+    } else {
+      const out = path.join(outDir, `${flags.name || 'shot'}.png`);
+      await grab(out);
+      console.log(`✓ ${out}  (alpha stripped, store-ready)`);
+    }
+  } finally {
+    androidDemo(false, flags);
+  }
 }
 
+/**
+ * Platform dispatch. NOTE — there is intentionally NO `--platform macos` capture:
+ *
+ * macOS has no `simctl io screenshot` / `adb screencap` equivalent for snapshotting a *driven* app.
+ * Reading a specific native window's pixels requires a macOS TCC permission grant — either **Screen
+ * Recording** (for the `screencapture` CLI, which otherwise returns black frames) or **Accessibility**
+ * (to drive the UI + use XCUITest's own screenshot). Neither is a clean one-command capture like the
+ * mobile SDKs give us.
+ *
+ * The robust, TCC-correct way to capture a Mac app's marketing screens is an **XCUITest** run on the
+ * native-macOS build that drives the same launch-arg handle (`-marketingScreen <id>`) and saves each
+ * screen as an **XCTAttachment** — the sandboxed Mac test-runner can't write PNGs into your repo — then
+ * exports them from the `.xcresult`. That lives project-side (see Asilak's `Scripts/capture-mac.sh`,
+ * which already owns the one-time Accessibility grant + signing). zdymak still **composes** the Mac
+ * screenshots/reels from those captures (premium/bleed at 2880×1800, etc.).
+ *
+ * Folding that xcodebuild-test + xcresult-export flow into zdymak would just wrap an app-specific test
+ * with no real gain; a `screencapture` path would need a *second* TCC grant and is fragile. So Mac
+ * capture is deliberately left to the project's XCUITest script; zdymak captures iOS/Android (clean CLI)
+ * and composes every platform. (Web/Playwright capture is on the roadmap.)
+ */
 export async function runCapture(flags) {
   const platform = flags.platform;
   if (platform === 'ios') return captureIos(flags);
   if (platform === 'android') return captureAndroid(flags);
-  throw new Error('capture needs --platform ios|android. Boot a simulator/emulator (or connect a device) first, navigate to the screen, then run capture --name <screen>.');
+  if (platform === 'macos' || platform === 'mac') {
+    throw new Error('macOS capture is intentionally out of scope (see the note above runCapture): use an XCUITest capture (e.g. Scripts/capture-mac.sh) that drives the launch-arg handle + exports .xcresult attachments, then `zdymak build` composes the Mac assets.');
+  }
+  throw new Error('capture needs --platform ios|android. Boot a simulator/emulator (or connect a device) first, then run a single --name <screen> or the full-workflow form (--bundle --arg --states).');
 }

package/src/cli.mjs

@@ -23,8 +23,15 @@ function parseFlags(argv) {
   const rest = [];
   for (let i = 0; i < argv.length; i++) {
     const a = argv[i];
-    if (a.startsWith('--')) flags[a.slice(2)] = argv[++i];
-    else rest.push(a);
+    if (a.startsWith('--')) {
+      const next = argv[i + 1];
+      // Boolean flag when followed by nothing or another --flag (e.g. `--build --project …`); else it
+      // takes the next token as its value. Single-dash values like `-marketingScreen` ARE values.
+      if (next === undefined || next.startsWith('--')) flags[a.slice(2)] = true;
+      else flags[a.slice(2)] = argv[++i];
+    } else {
+      rest.push(a);
+    }
   }
   return { flags, rest };
 }