zds-pickers 4.0.14 → 4.0.15

package/dist/other/SoundFontProvider.js

@@ -22,7 +22,7 @@ const SoundfontProvider = (props) => {
                 setInstrument(newInstrument);
             });
         }
-        else if (isDefined(instrumentName)) {
+        else if (instrumentName) {
             // the host app has already injected the soundfont into global space
             Soundfont.instrument(audioContext, instrumentName).then(newInstrument => {
                 setInstrument(newInstrument);
@@ -34,7 +34,9 @@ const SoundfontProvider = (props) => {
         }
     }, [audioContext, format, hostname, instrumentName, soundfont]);
     useEffect(() => {
-        loadInstrument(instrumentName);
+        if (instrumentName) {
+            loadInstrument(instrumentName);
+        }
     }, [instrumentName, loadInstrument]);
     useEffect(() => {
         if (isDefined(instrumentName)) {

package/dist/rotaryKnob/helpers/KnobVisualHelpers.js

@@ -1,9 +1,9 @@
 import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
 import React from 'react';
+import { toRadians } from '../utils';
 import { DrawCircle } from './DrawCircle';
 import { DrawLine } from './DrawLine';
 import { HelpersOverlay } from './HelpersOverlay';
-import { toRadians } from '../utils';
 class KnobVisualHelpers extends React.Component {
     constructor() {
         super(...arguments);

package/dist/types/other/OctavePlayer.d.ts

@@ -1,5 +1,11 @@
 import type Soundfont from 'soundfont-player';
 import type { TooltipProps } from './DefaultTooltip';
+type PianoMidiNote = {
+    accidental: boolean;
+    left: number;
+    midiNumber: number;
+    width: number;
+};
 type OctavePlayerProps = {
     disabled?: boolean;
     height: number;
@@ -10,12 +16,12 @@ type WithProviderProps = {
     format?: 'mp3' | 'ogg';
     height: number;
     hostname?: string;
-    instrumentName: Soundfont.InstrumentName;
+    instrumentName?: Soundfont.InstrumentName;
     octave?: number;
     onChange?: (note: number) => void;
     onClick?: (note: number) => void;
     onDoubleClick?: (note: number) => void;
-    onKeyMouseEnter?: (note: number) => void;
+    onKeyMouseEnter?: (note: PianoMidiNote) => void;
     onKeyMouseLeave?: (note: number) => void;
     soundfont?: 'MusyngKite' | 'FluidR3_GM';
     Tooltip?: TooltipProps;
@@ -23,4 +29,4 @@ type WithProviderProps = {
 };
 declare const WithProvider: ({ format, height, hostname, instrumentName, octave, onChange, onClick, onDoubleClick, onKeyMouseEnter, onKeyMouseLeave, soundfont, Tooltip, width, }: WithProviderProps) => import("react/jsx-runtime").JSX.Element;
 export { WithProvider as OctavePlayer };
-export type { OctavePlayerProps, WithProviderProps };
+export type { OctavePlayerProps, PianoMidiNote, WithProviderProps };

package/dist/types/other/SoundFontProvider.d.ts

@@ -3,7 +3,7 @@ type SoundfontProviderProps = {
     audioContext: AudioContext;
     format?: 'mp3' | 'ogg';
     hostname?: string;
-    instrumentName: Soundfont.InstrumentName;
+    instrumentName?: Soundfont.InstrumentName;
     onChange?: (midiNumber: number) => void;
     render: (props: {
         isLoading: boolean;

package/lib/other/OctavePlayer.tsx

@@ -4,6 +4,13 @@ import { Piano as ReactPiano } from 'zds-react-piano'
 import type { TooltipProps } from './DefaultTooltip'
 import { SoundfontProvider } from './SoundFontProvider'
 
+type PianoMidiNote = {
+  accidental: boolean
+  left: number
+  midiNumber: number
+  width: number
+}
+
 const baseNotes = [
   'C',
   'C#',
@@ -67,12 +74,12 @@ type WithProviderProps = {
   format?: 'mp3' | 'ogg'
   height: number
   hostname?: string
-  instrumentName: Soundfont.InstrumentName
+  instrumentName?: Soundfont.InstrumentName
   octave?: number
   onChange?: (note: number) => void
   onClick?: (note: number) => void
   onDoubleClick?: (note: number) => void
-  onKeyMouseEnter?: (note: number) => void
+  onKeyMouseEnter?: (note: PianoMidiNote) => void
   onKeyMouseLeave?: (note: number) => void
   soundfont?: 'MusyngKite' | 'FluidR3_GM'
   Tooltip?: TooltipProps
@@ -138,4 +145,4 @@ const WithProvider = ({
 
 export { WithProvider as OctavePlayer }
 
-export type { OctavePlayerProps, WithProviderProps }
+export type { OctavePlayerProps, PianoMidiNote, WithProviderProps }

package/lib/other/SoundFontProvider.tsx

@@ -11,7 +11,7 @@ type SoundfontProviderProps = {
   audioContext: AudioContext
   format?: 'mp3' | 'ogg'
   hostname?: string
-  instrumentName: Soundfont.InstrumentName
+  instrumentName?: Soundfont.InstrumentName
   onChange?: (midiNumber: number) => void
   render: (props: {
     isLoading: boolean
@@ -54,7 +54,7 @@ const SoundfontProvider = (props: SoundfontProviderProps) => {
         }).then(newInstrument => {
           setInstrument(newInstrument)
         })
-      } else if (isDefined(instrumentName)) {
+      } else if (instrumentName) {
         // the host app has already injected the soundfont into global space
         Soundfont.instrument(audioContext, instrumentName).then(
           newInstrument => {
@@ -70,7 +70,9 @@ const SoundfontProvider = (props: SoundfontProviderProps) => {
   )
 
   useEffect(() => {
-    loadInstrument(instrumentName)
+    if (instrumentName) {
+      loadInstrument(instrumentName)
+    }
   }, [instrumentName, loadInstrument])
 
   useEffect(() => {

package/lib/rotaryKnob/helpers/KnobVisualHelpers.tsx

@@ -1,9 +1,9 @@
 import React from 'react'
 import type { Point } from '../Types'
+import { toRadians } from '../utils'
 import { DrawCircle } from './DrawCircle'
 import { DrawLine } from './DrawLine'
 import { HelpersOverlay } from './HelpersOverlay'
-import { toRadians } from '../utils'
 
 /** Precision visual helpers */
 
@@ -50,7 +50,8 @@ class KnobVisualHelpers extends React.Component<
     //Note: Not sure why we need to subtract 90 here
     const valueMarkerX =
       props.radius * Math.cos(toRadians(props.valueAngle - 90))
-    const valueMarkerY = props.radius * Math.sin(toRadians(props.valueAngle - 90))
+    const valueMarkerY =
+      props.radius * Math.sin(toRadians(props.valueAngle - 90))
 
     return {
       ...state,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "zds-pickers",
-  "version": "4.0.14",
+  "version": "4.0.15",
   "main": "./dist/index.cjs.js",
   "module": "./dist/index.es.js",
   "types": "./dist/types/index.d.ts",