yaver-feedback-react-native 0.9.3 → 0.9.4

package/dist/ShakeDetector.js

@@ -97,6 +97,13 @@ class ShakeDetector {
      * want the extra native surface get the Dev-menu path only.
      */
     subscribeAccelerometer(onShake) {
+        // expo-sensors exposes an Accelerometer facade on web, but browsers have
+        // no native shake gesture and some versions construct a NativeEventEmitter
+        // backed by a module without addListener/removeListeners. Subscribing then
+        // crashes the host app's React commit phase. Preserve the SDK's explicit
+        // controls on web and skip only this impossible sensor transport.
+        if (react_native_1.Platform.OS === 'web')
+            return;
         let Accelerometer = null;
         try {
             // Optional peer dep — if it isn't installed, we simply skip this path.
@@ -113,23 +120,30 @@ class ShakeDetector {
         catch {
             // Some platforms reject zero-value intervals; fall through with defaults
         }
-        this.accelSub = Accelerometer.addListener(({ x, y, z }) => {
-            // Magnitude of acceleration vector (in g). Subtract 1 so a stationary
-            // device reports ~0 rather than the 1g of gravity.
-            const mag = Math.sqrt(x * x + y * y + z * z);
-            if (mag - 1 < ACCEL_THRESHOLD_G - 1)
-                return;
-            const now = Date.now();
-            this.peakTimestamps.push(now);
-            // Drop peaks that fell out of the rolling window.
-            while (this.peakTimestamps.length > 0 &&
-                now - this.peakTimestamps[0] > ACCEL_WINDOW_MS) {
-                this.peakTimestamps.shift();
-            }
-            if (this.peakTimestamps.length >= ACCEL_MIN_HITS) {
-                this.fire(onShake);
-            }
-        });
+        try {
+            this.accelSub = Accelerometer.addListener(({ x, y, z }) => {
+                // Magnitude of acceleration vector (in g). Subtract 1 so a stationary
+                // device reports ~0 rather than the 1g of gravity.
+                const mag = Math.sqrt(x * x + y * y + z * z);
+                if (mag - 1 < ACCEL_THRESHOLD_G - 1)
+                    return;
+                const now = Date.now();
+                this.peakTimestamps.push(now);
+                // Drop peaks that fell out of the rolling window.
+                while (this.peakTimestamps.length > 0 &&
+                    now - this.peakTimestamps[0] > ACCEL_WINDOW_MS) {
+                    this.peakTimestamps.shift();
+                }
+                if (this.peakTimestamps.length >= ACCEL_MIN_HITS) {
+                    this.fire(onShake);
+                }
+            });
+        }
+        catch {
+            // A host may include expo-sensors without linking its native module.
+            // Optional shake support must never take down the host application.
+            this.accelSub = null;
+        }
     }
 }
 exports.ShakeDetector = ShakeDetector;

package/dist/__tests__/ShakeDetectorWeb.test.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/__tests__/ShakeDetectorWeb.test.js

@@ -0,0 +1,27 @@
+"use strict";
+// Browsers cannot provide a native shake gesture. expo-sensors still exports
+// an Accelerometer facade there, and older SDK builds attempted to subscribe
+// to it, crashing the host React tree through NativeEventEmitter.
+Object.defineProperty(exports, "__esModule", { value: true });
+const sensorAddListener = jest.fn(() => ({ remove: jest.fn() }));
+const devEventAddListener = jest.fn(() => ({ remove: jest.fn() }));
+jest.mock('react-native', () => ({
+    Platform: { OS: 'web' },
+    NativeModules: {},
+    DeviceEventEmitter: { addListener: devEventAddListener },
+}));
+jest.mock('expo-sensors', () => ({
+    Accelerometer: {
+        setUpdateInterval: jest.fn(),
+        addListener: sensorAddListener,
+    },
+}), { virtual: true });
+const ShakeDetector_1 = require("../ShakeDetector");
+it('keeps explicit SDK controls alive without touching the native sensor on web', () => {
+    const detector = new ShakeDetector_1.ShakeDetector();
+    expect(() => detector.start(jest.fn())).not.toThrow();
+    expect(sensorAddListener).not.toHaveBeenCalled();
+    // The ordinary DeviceEventEmitter lane remains harmless and removable.
+    expect(devEventAddListener).toHaveBeenCalledTimes(1);
+    expect(() => detector.stop()).not.toThrow();
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "yaver-feedback-react-native",
-  "version": "0.9.3",
+  "version": "0.9.4",
   "description": "Visual feedback SDK for Yaver — bug reports, screen recording, voice vibe coding, and local-first developer workflows",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

package/src/ShakeDetector.ts

@@ -96,6 +96,13 @@ export class ShakeDetector {
    * want the extra native surface get the Dev-menu path only.
    */
   private subscribeAccelerometer(onShake: () => void): void {
+    // expo-sensors exposes an Accelerometer facade on web, but browsers have
+    // no native shake gesture and some versions construct a NativeEventEmitter
+    // backed by a module without addListener/removeListeners. Subscribing then
+    // crashes the host app's React commit phase. Preserve the SDK's explicit
+    // controls on web and skip only this impossible sensor transport.
+    if (Platform.OS === 'web') return;
+
     let Accelerometer: {
       setUpdateInterval: (ms: number) => void;
       addListener: (cb: (d: { x: number; y: number; z: number }) => void) => {
@@ -116,24 +123,30 @@ export class ShakeDetector {
       // Some platforms reject zero-value intervals; fall through with defaults
     }
 
-    this.accelSub = Accelerometer.addListener(({ x, y, z }) => {
-      // Magnitude of acceleration vector (in g). Subtract 1 so a stationary
-      // device reports ~0 rather than the 1g of gravity.
-      const mag = Math.sqrt(x * x + y * y + z * z);
-      if (mag - 1 < ACCEL_THRESHOLD_G - 1) return;
+    try {
+      this.accelSub = Accelerometer.addListener(({ x, y, z }) => {
+        // Magnitude of acceleration vector (in g). Subtract 1 so a stationary
+        // device reports ~0 rather than the 1g of gravity.
+        const mag = Math.sqrt(x * x + y * y + z * z);
+        if (mag - 1 < ACCEL_THRESHOLD_G - 1) return;
 
-      const now = Date.now();
-      this.peakTimestamps.push(now);
-      // Drop peaks that fell out of the rolling window.
-      while (
-        this.peakTimestamps.length > 0 &&
-        now - this.peakTimestamps[0] > ACCEL_WINDOW_MS
-      ) {
-        this.peakTimestamps.shift();
-      }
-      if (this.peakTimestamps.length >= ACCEL_MIN_HITS) {
-        this.fire(onShake);
-      }
-    });
+        const now = Date.now();
+        this.peakTimestamps.push(now);
+        // Drop peaks that fell out of the rolling window.
+        while (
+          this.peakTimestamps.length > 0 &&
+          now - this.peakTimestamps[0] > ACCEL_WINDOW_MS
+        ) {
+          this.peakTimestamps.shift();
+        }
+        if (this.peakTimestamps.length >= ACCEL_MIN_HITS) {
+          this.fire(onShake);
+        }
+      });
+    } catch {
+      // A host may include expo-sensors without linking its native module.
+      // Optional shake support must never take down the host application.
+      this.accelSub = null;
+    }
   }
 }

package/src/__tests__/ShakeDetectorWeb.test.ts

@@ -0,0 +1,30 @@
+// Browsers cannot provide a native shake gesture. expo-sensors still exports
+// an Accelerometer facade there, and older SDK builds attempted to subscribe
+// to it, crashing the host React tree through NativeEventEmitter.
+
+const sensorAddListener = jest.fn(() => ({ remove: jest.fn() }));
+const devEventAddListener = jest.fn(() => ({ remove: jest.fn() }));
+
+jest.mock('react-native', () => ({
+  Platform: { OS: 'web' },
+  NativeModules: {},
+  DeviceEventEmitter: { addListener: devEventAddListener },
+}));
+
+jest.mock('expo-sensors', () => ({
+  Accelerometer: {
+    setUpdateInterval: jest.fn(),
+    addListener: sensorAddListener,
+  },
+}), { virtual: true });
+
+import { ShakeDetector } from '../ShakeDetector';
+
+it('keeps explicit SDK controls alive without touching the native sensor on web', () => {
+  const detector = new ShakeDetector();
+  expect(() => detector.start(jest.fn())).not.toThrow();
+  expect(sensorAddListener).not.toHaveBeenCalled();
+  // The ordinary DeviceEventEmitter lane remains harmless and removable.
+  expect(devEventAddListener).toHaveBeenCalledTimes(1);
+  expect(() => detector.stop()).not.toThrow();
+});