yarramate 1.4.0 → 1.4.1

package/dist/adapters/visual/request.js

@@ -58,7 +58,14 @@ export const buildVisualSessionRequest = (options) => {
     const workspace = loaded.workspace;
     // Same order the session's own recompile uses, so the request's graph and
     // every graph the session rebuilds after a commit come from one input list.
-    const sourcePaths = [...workspace.profiles, ...workspace.documents];
+    // Patterns are compiler input like profiles (#268). Omitting them compiled a
+    // different workspace than the manifest describes, and an instance binding
+    // parts then failed YM419 for a pattern the manifest declared.
+    const sourcePaths = [
+        ...workspace.profiles,
+        ...workspace.patterns,
+        ...workspace.documents,
+    ];
     const sources = [];
     for (const path of sourcePaths) {
         try {

package/dist/adapters/visual/session-server.js

@@ -504,6 +504,13 @@ export const startVisualServer = async (options) => {
         try {
             return [
                 ...resolvedWorkspace.profiles,
+                // Patterns are compiler input like profiles (#268). Without them a
+                // session recompiles a workspace the manifest does not describe: an
+                // instance binding parts fails YM419, `compiledWorkspace` becomes
+                // undefined, and every view's filter then matches nothing while the
+                // rail still shows the initial model - which reads as a filter bug
+                // rather than as a compile that failed.
+                ...resolvedWorkspace.patterns,
                 ...resolvedWorkspace.documents,
             ].map((path) => ({
                 path,

package/dist/apply-command.js

@@ -719,6 +719,10 @@ export const applyOperations = (input) => {
     // single byte is written; any diagnostic rejects the entire batch.
     const compiled = [
         ...resolvedWorkspace.profiles,
+        // Without patterns this gate compiles a workspace the manifest does not
+        // describe, so every commit against a workspace holding pattern instances
+        // was refused with YM419 for a pattern that was declared (#268).
+        ...resolvedWorkspace.patterns,
         ...resolvedWorkspace.documents,
     ].map((path) => ({
         path,
@@ -832,6 +836,9 @@ export const planOperations = (store, input) => {
         // workspace that declares a profile died on it. No operation can target a
         // profile, so they are read to be COMPILED against, never to be written.
         ...input.workspace.profiles,
+        // Patterns are compiled against too, and are no more writable than a
+        // profile: no operation can target one.
+        ...input.workspace.patterns,
         ...input.workspace.documents,
         ...input.workspace.projections,
         ...input.workspace.evidence,

package/dist/ask-command.js

@@ -432,7 +432,11 @@ export function runAskCommand(options, cwd) {
                 return emit(result, `Workspace ${workspace.id}: check failing\n` +
                     `Diagnostics: ${plural(checkPayload.diagnostics.length, 'error')}; run \`yarramate check ${workspacePath}\` for details\n`, 1);
             }
-            const compilation = compileWorkspaceWithProfileContext([...workspace.profiles, ...workspace.documents].map((path) => ({
+            const compilation = compileWorkspaceWithProfileContext([
+                ...workspace.profiles,
+                ...workspace.patterns,
+                ...workspace.documents,
+            ].map((path) => ({
                 path,
                 source: readFileSync(resolve(cwd, path), 'utf8'),
             })));
@@ -514,7 +518,11 @@ export function runAskCommand(options, cwd) {
             return emit(result, `${lines.join('\n')}\n`);
         }
         // Every other mode reads the compiled model directly.
-        const compilation = compileWorkspaceWithProfileContext([...workspace.profiles, ...workspace.documents].map((path) => ({
+        const compilation = compileWorkspaceWithProfileContext([
+            ...workspace.profiles,
+            ...workspace.patterns,
+            ...workspace.documents,
+        ].map((path) => ({
             path,
             source: readFileSync(resolve(cwd, path), 'utf8'),
         })));

package/dist/check-command.js

@@ -274,7 +274,11 @@ export function runCheckCommand(options, cwd) {
         if (ok && result.ok) {
             const successfulCounts = counted;
             const documentCount = result.graph.documents.length;
-            const profileCount = coreSources.length - documentCount;
+            const patternCount = resolved.patterns.length;
+            // Everything in `coreSources` that is not a document was a profile until
+            // patterns joined the source list (#268), and counting them as profiles
+            // said "2 profiles" about a workspace with one.
+            const profileCount = coreSources.length - documentCount - patternCount;
             const mappingCount = mappingSources.length;
             const projectionCount = resolved.projections.length;
             const evidenceCount = resolved.evidence.length;
@@ -286,6 +290,11 @@ export function runCheckCommand(options, cwd) {
                         `${profileCount} ${profileCount === 1 ? 'profile' : 'profiles'}`,
                     ]
                     : []),
+                ...(patternCount > 0
+                    ? [
+                        `${patternCount} ${patternCount === 1 ? 'pattern' : 'patterns'}`,
+                    ]
+                    : []),
                 ...(mappingCount > 0
                     ? [
                         `${mappingCount} ${mappingCount === 1 ? 'adapter mapping' : 'adapter mappings'}`,

package/dist/cli-support.d.ts

@@ -28,6 +28,8 @@ export declare const resolveCliWorkspaceSources: (paths: readonly string[], cwd:
     readonly projections: readonly string[];
     readonly evidence: readonly string[];
     readonly contracts: readonly string[];
+    /** Pattern documents, which ride in `paths` and are not documents. */
+    readonly patterns: readonly string[];
 } | {
     readonly ok: false;
     readonly diagnostics: readonly Diagnostic[];

package/dist/cli-support.js

@@ -50,6 +50,7 @@ export const resolveCliWorkspaceSources = (paths, cwd, options = {}) => {
             projections: [],
             evidence: [],
             contracts: [],
+            patterns: [],
         };
     }
     const manifestPath = paths[0];
@@ -60,6 +61,7 @@ export const resolveCliWorkspaceSources = (paths, cwd, options = {}) => {
             projections: [],
             evidence: [],
             contracts: [],
+            patterns: [],
         };
     }
     const source = readFileSync(resolve(cwd, manifestPath), 'utf8');
@@ -70,6 +72,7 @@ export const resolveCliWorkspaceSources = (paths, cwd, options = {}) => {
             projections: [],
             evidence: [],
             contracts: [],
+            patterns: [],
         };
     }
     const loaded = loadWorkspaceManifest({ path: manifestPath, source }, cwd);
@@ -78,6 +81,15 @@ export const resolveCliWorkspaceSources = (paths, cwd, options = {}) => {
             ok: true,
             paths: [
                 ...loaded.workspace.profiles,
+                // Patterns are compiler input like profiles, and were resolved from
+                // the manifest without ever being handed over (#268): a pattern
+                // document a workspace declared was silently ignored by every verb,
+                // and an instance binding parts then failed YM419 for a pattern that
+                // was sitting right there in the manifest. Every test passed because
+                // each hands the compiler an explicit source list rather than
+                // resolving a workspace - the check that passes was not the check
+                // that mattered.
+                ...loaded.workspace.patterns,
                 ...loaded.workspace.documents,
                 ...(options.includeAdapterMappings === true
                     ? loaded.workspace.adapterMappings
@@ -86,6 +98,7 @@ export const resolveCliWorkspaceSources = (paths, cwd, options = {}) => {
             projections: loaded.workspace.projections,
             evidence: loaded.workspace.evidence,
             contracts: loaded.workspace.contracts,
+            patterns: loaded.workspace.patterns,
         }
         : { ok: false, diagnostics: loaded.diagnostics };
 };

package/dist/cli.js

@@ -37,6 +37,7 @@ const runReconciliation = (options, cwd) => {
         }
         const sourcePaths = [
             ...loadedWorkspace.workspace.profiles,
+            ...loadedWorkspace.workspace.patterns,
             ...loadedWorkspace.workspace.documents,
         ];
         const compilation = compileWorkspace(sourcePaths.map((path) => ({

package/dist/design-command.js

@@ -197,7 +197,11 @@ export function runDesignCommand(options, cwd) {
         });
         if (!loadedCatalogue.ok)
             return failed(loadedCatalogue.diagnostics);
-        const compilation = compileWorkspaceWithProfileContext([...workspace.profiles, ...workspace.documents].map((path) => ({
+        const compilation = compileWorkspaceWithProfileContext([
+            ...workspace.profiles,
+            ...workspace.patterns,
+            ...workspace.documents,
+        ].map((path) => ({
             path,
             source: readFileSync(resolve(cwd, path), 'utf8'),
         })));
@@ -273,8 +277,19 @@ export function runDesignCommand(options, cwd) {
                 stderr: '',
             };
         }
-        const waveSummary = result.progress.waves
-            .map(({ id, open }) => `${id} ${open} open`)
+        // Read from the REPORT rather than from `progress`, because a wave that
+        // has not opened and one with nothing outstanding both count zero (#334).
+        // "implementation 0 open" about a gated wave is the same empty-set
+        // flattery as the completion sentence below it - which was fixed while
+        // this line, directly above it, was not. `progress` keeps its shape: a
+        // consumer wanting wave state reads an interrogation report, and a third
+        // required field on a published format for a convenience summary is not
+        // worth the constructor break.
+        const waveSummary = report.waves
+            .map((wave) => {
+            const open = result.progress.waves.find(({ id }) => id === wave.id)?.open ?? 0;
+            return wave.opened ? `${wave.id} ${open} open` : `${wave.id} not yet`;
+        })
             .join(' · ');
         const lines = [
             `Design interview — workspace ${workspace.id} · catalogue ${report.catalogue}`,

package/dist/export-command.js

@@ -149,7 +149,11 @@ export function runExportCommand(options, cwd) {
         if (!loadedWorkspace.ok)
             return failed(loadedWorkspace.diagnostics);
         const workspace = loadedWorkspace.workspace;
-        const compilation = compileWorkspaceWithProfileContext([...workspace.profiles, ...workspace.documents].map((path) => ({
+        const compilation = compileWorkspaceWithProfileContext([
+            ...workspace.profiles,
+            ...workspace.patterns,
+            ...workspace.documents,
+        ].map((path) => ({
             path,
             source: readFileSync(resolve(cwd, path), 'utf8'),
         })));

package/dist/visual-app-lib/editor.js

@@ -91847,7 +91847,11 @@ var kC = [
 		});
 		if (s.length > 0) return a(s);
 	}
-	let b = [...t.profiles, ...t.documents].map((e) => ({
+	let b = [
+		...t.profiles,
+		...t.patterns,
+		...t.documents
+	].map((e) => ({
 		path: e,
 		source: m.get(e) ?? i(e)
 	})), x = dC(b);
@@ -91909,6 +91913,7 @@ var kC = [
 	let n = /* @__PURE__ */ new Map(), r = [];
 	for (let i of [
 		...t.workspace.profiles,
+		...t.workspace.patterns,
 		...t.workspace.documents,
 		...t.workspace.projections,
 		...t.workspace.evidence,
@@ -92998,7 +93003,11 @@ var uce = (e) => [...e.keys()].map((t) => ({
 	}, o = n.projections.flatMap((e) => {
 		let t = a(e);
 		return t === void 0 ? [] : [t];
-	}), s, c = () => [...n.profiles, ...n.documents].flatMap((e) => {
+	}), s, c = () => [
+		...n.profiles,
+		...n.patterns,
+		...n.documents
+	].flatMap((e) => {
 		let n = t.read(e);
 		return n === void 0 ? [] : [{
 			path: e,
@@ -93020,7 +93029,11 @@ var uce = (e) => [...e.keys()].map((t) => ({
 			initialView: o[0]?.id ?? "",
 			documents: n.documents,
 			layouts: i.layouts,
-			sourceDigests: l([...n.profiles, ...n.documents]),
+			sourceDigests: l([
+				...n.profiles,
+				...n.patterns,
+				...n.documents
+			]),
 			projectionDigests: l(o.map(({ path: e }) => e))
 		}, e.catalogue ?? Bw, e.dismissed);
 		return o = s.views, i = s.model, !0;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "yarramate",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "Tool-neutral semantic architecture engine and guided methodology",
   "license": "MIT",
   "repository": {