yam-flow 0.1.5 → 0.1.7

package/src/lib/trust-kernel.ts

@@ -88,6 +88,30 @@ export interface UeyeSurfaceContext {
   truth_status: TruthStatus;
 }
 
+export interface UeyeDesignGateCheck {
+  id: string;
+  label: string;
+  status: 'pass' | 'fail' | 'warning' | 'not_checked';
+  required: boolean;
+  next_action: string;
+}
+
+export interface UeyeDesignCompletionGate {
+  schema: 'yam.ueye-design-completion-gate.v1';
+  mode: 'fast' | 'strict';
+  completion_claim: 'draft' | 'needs-polish' | 'done';
+  ready_to_claim_done: boolean;
+  design_score: number | null;
+  min_design_score: number;
+  checks: UeyeDesignGateCheck[];
+  p0: string[];
+  p1: string[];
+  warnings: string[];
+  blockers: string[];
+  next_action: string;
+  truth_status: TruthStatus;
+}
+
 export interface RollbackHint {
   schema: 'yam.rollback-hint.v1';
   touched_files: string[];
@@ -113,6 +137,14 @@ export interface RuntimeBackendEvidence {
   evidence_id: string;
   command: string;
   cleanup_checked: boolean;
+  started_at: string;
+  stopped_at: string;
+  exit_code: number | null;
+  pid: number | null;
+  port: number | null;
+  cleanup_method: string;
+  cleanup_observed: boolean;
+  left_running_intentionally: boolean;
   note: string;
   truth_status: TruthStatus;
 }
@@ -122,6 +154,7 @@ export interface UeyeRunReport {
   reference_sources: UeyeVisualProvenance[];
   implementation_sources: UeyeVisualProvenance[];
   surface_context: UeyeSurfaceContext;
+  design_completion_gate: UeyeDesignCompletionGate;
   comparison_result: string;
   design_quality: string;
   blocked_reason: string;
@@ -129,6 +162,10 @@ export interface UeyeRunReport {
   truth_status: TruthStatus;
 }
 
+export interface UeyeRunReportInput extends Partial<Omit<UeyeRunReport, 'design_completion_gate'>> {
+  design_completion_gate?: Partial<UeyeDesignCompletionGate> & Record<string, unknown>;
+}
+
 export interface MediaGenerationProof {
   schema: 'yam.media-generation-proof.v1';
   tool_name: string;
@@ -171,6 +208,7 @@ export interface ProofSummary {
   rollbackHint?: unknown;
   runtimeBackendEvidence?: unknown;
   mediaProof?: unknown;
+  designCompletion?: unknown;
 }
 
 export interface ProofOptions {
@@ -206,6 +244,7 @@ export interface YamCompletionProof {
   rollbackHint: string[];
   runtimeBackendEvidence: string[];
   mediaProof: string[];
+  designCompletion: string[];
   cleanup: unknown;
   changed: string[];
   skipped: string[];
@@ -262,6 +301,94 @@ export function buildUeyeSurfaceContext(input: Partial<UeyeSurfaceContext> = {})
   };
 }
 
+export function buildUeyeDesignCompletionGate(input: Partial<UeyeDesignCompletionGate> & Record<string, unknown> = {}): UeyeDesignCompletionGate {
+  const completionClaim = normalizeUeyeCompletionClaim(input.completion_claim);
+  const mode = String(input.mode || '').toLowerCase() === 'strict' || completionClaim === 'done' ? 'strict' : 'fast';
+  const designScore = numberOrNull(input.design_score);
+  const minDesignScore = numberOrNull(input.min_design_score) ?? 8;
+  const p0 = asList(input.p0);
+  const p1 = asList(input.p1);
+  const hasReference = Boolean(input.has_reference);
+  const hasImplementation = Boolean(input.has_implementation_screenshot);
+  const comparisonResult = String(input.comparison_result || 'not-verified');
+  const designQuality = String(input.design_quality || 'not-checked');
+  const blockedReason = String(input.blocked_reason || '');
+  const strictOrDone = mode === 'strict' || completionClaim === 'done';
+  const checks: UeyeDesignGateCheck[] = [
+    designGateCheck('direction_lock', 'Design direction and target screen were locked before judging completion', Boolean(input.direction_locked) ? 'pass' : 'not_checked', strictOrDone, 'record the target screen and design direction before claiming done'),
+    designGateCheck('reference_read', 'Reference read proof exists when reference is used', !hasReference ? 'not_checked' : Boolean(input.reference_read) ? 'pass' : 'fail', hasReference && strictOrDone, 'record concrete reference observations before claiming reference-led work is done'),
+    designGateCheck('implementation_screenshot', 'Real implementation screenshot or screen evidence exists', hasImplementation ? 'pass' : 'fail', strictOrDone, 'capture or provide implementation screenshot before claiming done'),
+    designGateCheck('reference_comparison', 'Reference comparison is recorded when reference is used', !hasReference ? 'not_checked' : ['matched', 'similar', 'not-applicable'].includes(comparisonResult) ? 'pass' : 'fail', hasReference, 'compare against the reference or mark the difference as intentional before claiming done'),
+    designGateCheck('design_quality', 'Design quality result is pass', designQuality === 'pass' ? 'pass' : designQuality === 'needs-polish' ? 'warning' : 'fail', strictOrDone, 'resolve design quality issues or keep the result as needs-polish/partial'),
+    designGateCheck('p0_clear', 'No P0 visual blockers remain', p0.length ? 'fail' : 'pass', true, 'fix P0 blockers before any done claim'),
+    designGateCheck('p1_clear', 'No P1 major visual issues remain', p1.length ? 'fail' : 'pass', strictOrDone, 'fix or explicitly defer P1 issues before claiming done'),
+    designGateCheck('cta_affordance', 'Primary CTA and interaction affordances were checked', Boolean(input.cta_checked) ? 'pass' : 'not_checked', strictOrDone, 'check primary CTA clarity and interaction affordances before claiming done'),
+    designGateCheck('state_coverage', 'Primary UI states were checked', Boolean(input.states_checked) ? 'pass' : 'not_checked', strictOrDone, 'check default/loading/error/empty/disabled states or keep completion partial'),
+    designGateCheck('mobile_coverage', 'Mobile/responsive behavior was checked', Boolean(input.mobile_checked || input.responsive_checked) ? 'pass' : 'not_checked', strictOrDone, 'check mobile/responsive behavior before claiming done'),
+    designGateCheck('accessibility_visuals', 'Contrast/accessibility-relevant visuals were checked', Boolean(input.contrast_checked || input.accessibility_checked) ? 'pass' : 'not_checked', strictOrDone, 'check contrast/accessibility-relevant visuals before claiming done')
+  ];
+  if (designScore !== null || strictOrDone) {
+    checks.push(designGateCheck('design_score', `Design score is at least ${minDesignScore}`, designScore !== null && designScore >= minDesignScore ? 'pass' : designScore === null ? 'not_checked' : 'fail', false, `record --design-score ${minDesignScore} or higher when using score-based completion`));
+  }
+  const blockers = [
+    ...p0.map((item) => `P0: ${item}`),
+    ...(blockedReason ? [blockedReason] : []),
+    ...checks
+      .filter((check) => check.required && check.status !== 'pass')
+      .map((check) => `${check.id}: ${check.next_action}`)
+  ];
+  const warnings = [
+    ...p1.map((item) => `P1: ${item}`),
+    ...checks
+      .filter((check) => !check.required && ['fail', 'warning', 'not_checked'].includes(check.status))
+      .map((check) => `${check.id}: ${check.next_action}`)
+  ];
+  const ready = completionClaim === 'done' && blockers.length === 0;
+  const truth: TruthStatus = blockers.some((item) => item.startsWith('P0:')) || blockedReason ? 'blocked'
+    : ready ? 'verified'
+      : strictOrDone ? 'partial'
+        : hasImplementation ? 'partial'
+          : 'assumed';
+  return {
+    schema: 'yam.ueye-design-completion-gate.v1',
+    mode,
+    completion_claim: completionClaim,
+    ready_to_claim_done: ready,
+    design_score: designScore,
+    min_design_score: minDesignScore,
+    checks,
+    p0,
+    p1,
+    warnings,
+    blockers,
+    next_action: blockers[0] || (ready ? 'done claim is supported by the recorded design gate' : warnings[0] || 'keep the Ueye result as draft or needs-polish until a done claim is needed'),
+    truth_status: truth
+  };
+}
+
+function normalizeUeyeCompletionClaim(value: unknown = ''): UeyeDesignCompletionGate['completion_claim'] {
+  const text = String(value || '').toLowerCase();
+  if (text === 'done' || text === 'complete' || text === 'completed') return 'done';
+  if (text === 'needs-polish' || text === 'needs_polish' || text === 'polish') return 'needs-polish';
+  return 'draft';
+}
+
+function designGateCheck(id: string, label: string, status: UeyeDesignGateCheck['status'], required: boolean, nextAction: string): UeyeDesignGateCheck {
+  return {
+    id,
+    label,
+    status,
+    required,
+    next_action: nextAction
+  };
+}
+
+function numberOrNull(value: unknown = null): number | null {
+  if (value === undefined || value === null || value === '') return null;
+  const number = Number(value);
+  return Number.isFinite(number) ? number : null;
+}
+
 export function buildRollbackHint(input: Partial<RollbackHint> = {}): RollbackHint {
   return {
     schema: 'yam.rollback-hint.v1',
@@ -290,6 +417,13 @@ export function buildMissionPatchEnvelope(input: Partial<MissionPatchEnvelope> =
 export function buildRuntimeBackendEvidence(input: Partial<RuntimeBackendEvidence> = {}): RuntimeBackendEvidence {
   const backend = normalizeRuntimeBackend(input.backend);
   const claim = normalizeRuntimeClaim(input.claim);
+  const cleanupObserved = Boolean(input.cleanup_observed);
+  const leftRunningIntentionally = Boolean(input.left_running_intentionally);
+  const exitCode = numberOrNull(input.exit_code);
+  const pid = numberOrNull(input.pid);
+  const port = numberOrNull(input.port);
+  const stoppedAt = String(input.stopped_at || '');
+  const cleanupMethod = String(input.cleanup_method || '');
   return {
     schema: 'yam.runtime-backend-evidence.v1',
     backend,
@@ -297,12 +431,28 @@ export function buildRuntimeBackendEvidence(input: Partial<RuntimeBackendEvidenc
     evidence_id: String(input.evidence_id || ''),
     command: String(input.command || ''),
     cleanup_checked: Boolean(input.cleanup_checked),
+    started_at: String(input.started_at || ''),
+    stopped_at: stoppedAt,
+    exit_code: exitCode,
+    pid,
+    port,
+    cleanup_method: cleanupMethod,
+    cleanup_observed: cleanupObserved,
+    left_running_intentionally: leftRunningIntentionally,
     note: String(input.note || ''),
-    truth_status: isTruthStatus(input.truth_status) ? input.truth_status : runtimeBackendTruth(backend, claim, Boolean(input.cleanup_checked))
+    truth_status: isTruthStatus(input.truth_status) ? input.truth_status : runtimeBackendTruth(backend, claim, {
+      cleanupChecked: Boolean(input.cleanup_checked),
+      cleanupObserved,
+      leftRunningIntentionally,
+      stoppedAt,
+      exitCode,
+      pid,
+      cleanupMethod
+    })
   };
 }
 
-export function buildUeyeRunReport(input: Partial<UeyeRunReport> = {}): UeyeRunReport {
+export function buildUeyeRunReport(input: UeyeRunReportInput = {}): UeyeRunReport {
   const references = Array.isArray(input.reference_sources)
     ? input.reference_sources.map((item) => buildUeyeVisualProvenance(item))
     : [];
@@ -317,19 +467,30 @@ export function buildUeyeRunReport(input: Partial<UeyeRunReport> = {}): UeyeRunR
       : comparisonResult === 'matched' && hasImplementation ? 'verified'
         : hasImplementation ? 'partial'
           : 'partial';
+  const gate = buildUeyeDesignCompletionGate({
+    ...input.design_completion_gate,
+    has_reference: references.length > 0,
+    has_implementation_screenshot: hasImplementation,
+    comparison_result: comparisonResult,
+    design_quality: String(input.design_quality || 'not-checked'),
+    blocked_reason: blockedReason
+  });
+  const shouldApplyDesignGate = gate.mode === 'strict' || gate.completion_claim === 'done' || gate.blockers.length > 0;
+  const finalTruth = shouldApplyDesignGate ? weakestTruth(derivedTruth, gate.truth_status) : derivedTruth;
   return {
     schema: 'yam.ueye-run-report.v1',
     reference_sources: references,
     implementation_sources: implementations,
     surface_context: buildUeyeSurfaceContext({
       ...input.surface_context,
-      truth_status: isTruthStatus(input.surface_context?.truth_status) ? input.surface_context?.truth_status : derivedTruth
+      truth_status: isTruthStatus(input.surface_context?.truth_status) ? input.surface_context?.truth_status : finalTruth
     }),
+    design_completion_gate: gate,
     comparison_result: comparisonResult,
     design_quality: String(input.design_quality || 'not-checked'),
     blocked_reason: blockedReason,
-    next_action: String(input.next_action || (derivedTruth === 'verified' ? 'no action required' : 'capture or provide implementation screenshot before claiming verified visual status')),
-    truth_status: isTruthStatus(input.truth_status) ? input.truth_status : derivedTruth
+    next_action: String(input.next_action || gate.blockers[0] || (finalTruth === 'verified' ? 'no action required' : 'capture or provide implementation screenshot before claiming verified visual status')),
+    truth_status: isTruthStatus(input.truth_status) ? input.truth_status : finalTruth
   };
 }
 
@@ -444,6 +605,9 @@ export function classifyEvidenceTruth(summary: ProofSummary = {}, options: Proof
   for (const media of asList(summary.mediaProof)) {
     rows.push(evidenceRow('evidence', media, readStructuredTruth(media, 'partial')));
   }
+  for (const designCompletion of asList(summary.designCompletion)) {
+    rows.push(evidenceRow('visual', designCompletion, readStructuredTruth(designCompletion, 'partial')));
+  }
   for (const runtime of asList(summary.runtime)) {
     rows.push(evidenceRow('runtime', runtime, classifyRuntimeEvidence(runtime, options)));
   }
@@ -473,6 +637,14 @@ export function applyProofTruthCaps(summary: ProofSummary = {}, options: ProofOp
     cappedTruth = weakestTruth(cappedTruth, 'partial');
     unverified.push('real_visual_evidence_missing');
   }
+  const designCompletionTruth = designCompletionCap(summary.designCompletion);
+  if (designCompletionTruth) {
+    cappedTruth = weakestTruth(cappedTruth, designCompletionTruth);
+    if (designCompletionTruth === 'blocked') blockers.push('ueye_design_completion_blocked');
+    if (!['verified', 'proven'].includes(designCompletionTruth)) {
+      unverified.push('ueye_design_completion_not_verified');
+    }
+  }
   if (requested !== cappedTruth) {
     caps.push(`requested ${requested} capped to ${cappedTruth} by evidence`);
   }
@@ -532,6 +704,7 @@ export function buildYamCompletionProof(summary: ProofSummary = {}, options: Pro
     rollbackHint: asList(summary.rollbackHint),
     runtimeBackendEvidence: asList(summary.runtimeBackendEvidence),
     mediaProof: asList(summary.mediaProof),
+    designCompletion: asList(summary.designCompletion),
     cleanup: summary.cleanup || '',
     changed: asList(summary.changed),
     skipped: asList(summary.skipped),
@@ -601,6 +774,12 @@ function readStructuredTruth(value: unknown = '', fallback: TruthStatus = 'parti
   }
 }
 
+function designCompletionCap(value: unknown = ''): TruthStatus | null {
+  const items = asList(value);
+  if (!items.length) return null;
+  return items.reduce<TruthStatus>((weakest, item) => weakestTruth(weakest, readStructuredTruth(item, 'partial')), 'proven');
+}
+
 function strongestSupportedTruth(rows: EvidenceRow[] = []): TruthStatus {
   if (rows.some((row) => row.truth === 'blocked')) return 'blocked';
   if (rows.some((row) => row.truth === 'real_required_missing')) return 'real_required_missing';
@@ -686,11 +865,24 @@ function normalizeRuntimeClaim(value: unknown = ''): RuntimeClaim {
   return 'unknown';
 }
 
-function runtimeBackendTruth(backend: RuntimeBackend, claim: RuntimeClaim, cleanupChecked = false): TruthStatus {
+function runtimeBackendTruth(backend: RuntimeBackend, claim: RuntimeClaim, details: {
+  cleanupChecked?: boolean;
+  cleanupObserved?: boolean;
+  leftRunningIntentionally?: boolean;
+  stoppedAt?: string;
+  exitCode?: number | null;
+  pid?: number | null;
+  cleanupMethod?: string;
+} = {}): TruthStatus {
   if (claim === 'blocked') return 'blocked';
   if (backend === 'none' || claim === 'not_started') return 'skipped';
   if (backend === 'unknown' || claim === 'unknown') return 'partial';
-  if (claim === 'cleanup_verified' || cleanupChecked) return 'proven';
+  const hasClosureEvidence = Boolean(details.stoppedAt || details.exitCode !== null || details.cleanupMethod);
+  if (claim === 'cleanup_verified' || details.cleanupChecked) {
+    if (details.cleanupObserved && hasClosureEvidence) return 'proven';
+    if (details.leftRunningIntentionally && (details.pid !== null || details.cleanupMethod)) return 'partial';
+    return 'real_required_missing';
+  }
   if (claim === 'observed' || claim === 'stopped' || claim === 'started') return 'verified';
   return 'partial';
 }

package/templates/ueye-comparison.md

@@ -112,6 +112,36 @@ Use `pass`, `needs-polish`, or `fails` for each relevant design dimension before
 | Accessibility | needs-polish |  |
 | Brand/mood fit | needs-polish |  |
 
+## Design Completion Gate
+
+| Field | Value |
+| --- | --- |
+| completion_claim | draft / needs-polish / done |
+| mode | fast / strict |
+| ready_to_claim_done | true / false |
+| design_score |  |
+| min_design_score | 8 |
+| direction_locked | true / false |
+| reference_read | true / false / not-applicable |
+| implementation_screenshot | pass / fail / not_checked |
+| reference_comparison | matched / similar / different / not-verified / not-applicable |
+| design_quality | pass / needs-polish / fails / not-checked |
+| p0_clear | pass / fail |
+| p1_clear | pass / fail / deferred |
+| cta_checked | true / false |
+| states_checked | true / false |
+| mobile_checked | true / false |
+| contrast_accessibility_checked | true / false |
+| truth_status | verified / partial / skipped / blocked / assumed |
+
+### Design Gate Blockers
+
+- None.
+
+### Design Gate Warnings
+
+- None.
+
 ### P0 Blockers
 
 - None.
@@ -152,6 +182,18 @@ Use `pass`, `needs-polish`, or `fails` for each relevant design dimension before
     "preserved_url": "",
     "truth_status": "partial"
   },
+  "design_completion_gate": {
+    "completion_claim": "needs-polish",
+    "mode": "fast",
+    "ready_to_claim_done": false,
+    "design_score": null,
+    "min_design_score": 8,
+    "p0": [],
+    "p1": [],
+    "blockers": [],
+    "warnings": [],
+    "truth_status": "partial"
+  },
   "viewport": "",
   "state": "",
   "comparison_result": "not-verified",

package/templates/ueye-review.md

@@ -123,6 +123,36 @@ Status values: matched / similar / different / not-verified / not-applicable.
 
 Result values: pass / needs-polish / fails.
 
+## Design Completion Gate
+
+| Field | Value |
+| --- | --- |
+| completion_claim | draft / needs-polish / done |
+| mode | fast / strict |
+| ready_to_claim_done | true / false |
+| design_score |  |
+| min_design_score | 8 |
+| direction_locked | true / false |
+| reference_read | true / false / not-applicable |
+| implementation_screenshot | pass / fail / not_checked |
+| reference_comparison | matched / similar / different / not-verified / not-applicable |
+| design_quality | pass / needs-polish / fails / not-checked |
+| p0_clear | pass / fail |
+| p1_clear | pass / fail / deferred |
+| cta_checked | true / false |
+| states_checked | true / false |
+| mobile_checked | true / false |
+| contrast_accessibility_checked | true / false |
+| truth_status | verified / partial / skipped / blocked / assumed |
+
+### Design Gate Blockers
+
+- None.
+
+### Design Gate Warnings
+
+- None.
+
 ## P0-P3 Issues
 
 ### P0 Blockers
@@ -184,6 +214,18 @@ Result values: pass / needs-polish / fails.
     "preserved_url": "",
     "truth_status": "partial"
   },
+  "design_completion_gate": {
+    "completion_claim": "needs-polish",
+    "mode": "fast",
+    "ready_to_claim_done": false,
+    "design_score": null,
+    "min_design_score": 8,
+    "p0": [],
+    "p1": [],
+    "blockers": [],
+    "warnings": [],
+    "truth_status": "partial"
+  },
   "viewport": "",
   "state": "",
   "comparison_result": "not-verified",

package/templates/yam.project.md

@@ -46,6 +46,20 @@
 - Risky changes:
 - Public/release changes: scan for external tool names, comparison wording, and attribution wording; remove those hits unless the user explicitly approves keeping them.
 
+## Security Policy
+
+- Sensitive surfaces:
+- Secrets/env handling:
+- Auth/payment/DB policy:
+- Deployment/release policy:
+- Package/dependency policy:
+
+## Report Policy
+
+- Explain changed code in plain language:
+- Always include remaining tasks or useful improvements:
+- Preserve source boundaries for research/proof notes:
+
 ## Known Risks
 
 - Auth/payment/DB/security: