yadflow 4.7.0 → 4.9.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +116 -0
- package/README.md +43 -4
- package/bin/commands.mjs +5 -1
- package/bin/yad.mjs +169 -22
- package/cli/agent-guard.mjs +511 -0
- package/cli/agent-guide.mjs +83 -0
- package/cli/agent-rules.mjs +388 -0
- package/cli/argv-flags.mjs +7 -0
- package/cli/build.mjs +1 -1
- package/cli/ci-check.mjs +492 -0
- package/cli/docs.mjs +1 -1
- package/cli/doctor.mjs +148 -7
- package/cli/epic-state.mjs +3 -3
- package/cli/errors.mjs +1 -0
- package/cli/guide.mjs +549 -0
- package/cli/hook.mjs +32 -3
- package/cli/lib.mjs +46 -0
- package/cli/lifecycle/defaults/2.json +124 -0
- package/cli/lifecycle/lifecycle.schema.json +5 -2
- package/cli/lifecycle.mjs +16 -3
- package/cli/machine.mjs +141 -0
- package/cli/manifest.mjs +75 -0
- package/cli/marked-block.mjs +48 -0
- package/cli/members.mjs +19 -5
- package/cli/migrate.mjs +17 -19
- package/cli/next.mjs +1 -1
- package/cli/openpr.mjs +46 -6
- package/cli/plan.mjs +326 -22
- package/cli/preview.mjs +253 -0
- package/cli/protection.mjs +50 -0
- package/cli/reconcile.mjs +187 -26
- package/cli/repo.mjs +64 -3
- package/cli/report.mjs +62 -14
- package/cli/review.mjs +4 -0
- package/cli/setup.mjs +244 -25
- package/cli/signing.mjs +377 -0
- package/cli/story-frames.mjs +296 -0
- package/cli/test-agents-file.mjs +993 -0
- package/cli/test-ci-check.mjs +616 -0
- package/cli/test-guide.mjs +1267 -0
- package/cli/test-machine.mjs +140 -0
- package/cli/test-node.mjs +129 -0
- package/cli/test-preview.mjs +511 -0
- package/cli/test-setup-agent.mjs +352 -0
- package/cli/test-signing.mjs +524 -0
- package/cli/test-story-frames.mjs +339 -0
- package/cli/toolbox.mjs +35 -1
- package/cli/update-commit.mjs +313 -11
- package/cli/workspace.mjs +37 -12
- package/package.json +6 -4
- package/skills/sdlc/config.yaml +4 -4
- package/skills/sdlc/module-help.csv +1 -0
- package/skills/yad-change/SKILL.md +3 -2
- package/skills/yad-checks/SKILL.md +29 -9
- package/skills/yad-checks/references/check-gates.md +9 -4
- package/skills/yad-checks/templates/checks/package-manager.sh +1 -1
- package/skills/yad-checks/templates/github/yad-checks.yml +1 -1
- package/skills/yad-checks/templates/gitlab/.gitlab-ci.yml +1 -1
- package/skills/yad-checks/templates/gitlab/yad-checks.gitlab-ci.yml +1 -1
- package/skills/yad-checks/templates/gitlab/yad-product-checks.gitlab-ci.yml +1 -1
- package/skills/yad-checks/templates/gitlab/yad-update-guard.gitlab-ci.yml +1 -1
- package/skills/yad-checks/templates/gitlab/yad-verified-commits.gitlab-ci.yml +1 -1
- package/skills/yad-checks/templates/hooks/agent-guard.mjs +116 -0
- package/skills/yad-commit/SKILL.md +4 -3
- package/skills/yad-connect-design/SKILL.md +7 -4
- package/skills/yad-connect-design/references/design-context.md +23 -0
- package/skills/yad-connect-design/references/design-registry.md +3 -3
- package/skills/yad-connect-repos/SKILL.md +13 -3
- package/skills/yad-connect-repos/references/code-context.md +2 -1
- package/skills/yad-connect-repos/references/repos-registry.md +2 -1
- package/skills/yad-docs-overview/references/pipeline-model.md +2 -2
- package/skills/yad-engineer-review/SKILL.md +25 -7
- package/skills/yad-engineer-review/references/ship-and-record.md +7 -4
- package/skills/yad-epic/SKILL.md +2 -1
- package/skills/yad-epic/references/state-schema.md +7 -1
- package/skills/yad-guide/SKILL.md +192 -0
- package/skills/yad-implement/SKILL.md +14 -0
- package/skills/yad-open-pr/SKILL.md +5 -2
- package/skills/yad-pair-review/SKILL.md +19 -5
- package/skills/yad-pr-template/templates/github/pull_request_template.md +1 -0
- package/skills/yad-pr-template/templates/gitlab/merge_request_templates/Default.md +1 -0
- package/skills/yad-product-bridge/SKILL.md +32 -13
- package/skills/yad-product-bridge/references/bridge.md +6 -3
- package/skills/yad-product-bridge/templates/github/yad-gate-sync.yml +2 -2
- package/skills/yad-product-bridge/templates/gitlab/yad-gate-sync.gitlab-ci.yml +1 -1
- package/skills/yad-report/SKILL.md +15 -0
- package/skills/yad-review-companion/SKILL.md +9 -4
- package/skills/yad-review-gate/SKILL.md +13 -9
- package/skills/yad-review-gate/references/gating.md +1 -1
- package/skills/yad-run/SKILL.md +10 -6
- package/skills/yad-run/references/run-loop.md +2 -1
- package/skills/yad-spec/SKILL.md +21 -0
- package/skills/yad-stories/SKILL.md +22 -0
- package/skills/yad-stories/references/story-schema.md +1 -0
- package/skills/yad-sync-repos/SKILL.md +2 -1
- package/skills/yad-ui/SKILL.md +7 -2
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: yad-review-gate
|
|
3
|
-
description: 'The reusable team review + approve gate for the SDLC. Shares an authored artifact for review,
|
|
3
|
+
description: 'The reusable team review + approve gate for the SDLC. Shares an authored artifact for review, syncs the reviewers'' comments and approvals into files, enforces the approver count (1 distinct approver; contract/auth/payments raise the full count, advisory), and the step advances ONLY when approval is recorded. Commenting, approving, advancing and reopening are the person''s acts: an AI agent gives them the exact command and confirms by reading, never runs it. Use when the user says "review the analysis/epic/architecture/UI/stories/test-cases", "comment", "approve", or "advance the gate".'
|
|
4
4
|
---
|
|
5
5
|
|
|
6
6
|
# SDLC — Team Review Gate (build plan §3 piece 2, §4, §5)
|
|
@@ -30,6 +30,10 @@ trigger is a parameter, not a hardcoded human.
|
|
|
30
30
|
- `artifact`: the file under the epic being reviewed (e.g. `epic.md`).
|
|
31
31
|
- `action`: one of `open` | `comment` | `approve` | `sync` | `advance` (default: `open`). With no platform,
|
|
32
32
|
`comment` / `approve` / `advance` are the `yad gate comment|approve|advance` commands (E112).
|
|
33
|
+
**These, and `yad gate reopen`, are the person's to run, never yours (E158).** Give the person the exact
|
|
34
|
+
command (in Claude Code they type it with `!` in front, so its output lands in the chat), wait, then
|
|
35
|
+
confirm by reading — `yad gate status <epic>` — before you go on. Never go on from "done" alone. The agent
|
|
36
|
+
guard hook refuses them if you try.
|
|
33
37
|
- For `comment` / `approve`: the reviewer's platform login (or the name they give, when there is no
|
|
34
38
|
platform). No role and no domain. Ask if not provided.
|
|
35
39
|
- `sync` needs no reviewer input — it reads the platform PR/MR review state (via `yad-product-bridge`).
|
|
@@ -140,7 +144,7 @@ CI records the gate at merge.) Opening the PR records no approvals and never adv
|
|
|
140
144
|
- <comment>
|
|
141
145
|
```
|
|
142
146
|
|
|
143
|
-
Then
|
|
147
|
+
Then the reviewer records the round with the engine — give them the command, and never append to `.sdlc/comments.json` by hand:
|
|
144
148
|
```bash
|
|
145
149
|
yad gate comment <epic> <artifact> --by <name> --count <comments this round> # the round in progress
|
|
146
150
|
yad gate comment <epic> <artifact> --by <name> --count <n> --new-round # after the owner addressed the last round
|
|
@@ -158,14 +162,14 @@ Then help the **owner address the comments** using the agent lens listed for thi
|
|
|
158
162
|
stories → `pm`, with `architect` for technical detail; test-cases → `test architect`). Update the authored artifact in place.
|
|
159
163
|
Repeat comment→address rounds until reviewers are satisfied. **Commenting never advances the gate.**
|
|
160
164
|
|
|
161
|
-
**`approve`** —
|
|
165
|
+
**`approve`** — The reviewer records their approval with the engine — give them the command, and never append to `.sdlc/approvals.json` by hand:
|
|
162
166
|
```bash
|
|
163
167
|
yad gate approve <epic> <artifact> --by <name> [--engagement verified|none]
|
|
164
168
|
```
|
|
165
169
|
One record per person (a second approval by the same name replaces the first). It records no `role` or
|
|
166
170
|
`domain`. The approver must not be the artifact's author: the command warns when `--by` is the epic's
|
|
167
|
-
`owner:` or the artifact's last git author, and records it anyway (it cannot tell who is typing), so
|
|
168
|
-
|
|
171
|
+
`owner:` or the artifact's last git author, and records it anyway (it cannot tell who is typing), so never
|
|
172
|
+
hand it to the author. The record carries the artifact's fingerprint (`artifactHash`), so **an edit to
|
|
169
173
|
the artifact revokes it**, exactly as a platform approval is revoked — the reviewer approves again once they
|
|
170
174
|
have seen the new content. An older hand-written record with no fingerprint still counts until it is
|
|
171
175
|
replaced. This is the **no-platform** path (E112): with a platform the approvals are the PR/MR's, and the
|
|
@@ -228,8 +232,8 @@ writes neither (issue #362). Always **re-evaluate Step 3**. **Never hand-write e
|
|
|
228
232
|
gate sync`), `sync` advances the step when Step 3 passes on a **merged**, fully-resolved, approved PR
|
|
229
233
|
(the merge is the human act); otherwise it records state and holds the step `in_review`.
|
|
230
234
|
|
|
231
|
-
**`advance`** —
|
|
232
|
-
`yad gate advance <epic> <artifact
|
|
235
|
+
**`advance`** — Check the gate predicate (Step 3); only when it passes, the person advances. With no platform
|
|
236
|
+
that is `yad gate advance <epic> <artifact>`, which they run; with a platform it is the merge (`yad gate sync` / `yad gate ci`).
|
|
233
237
|
|
|
234
238
|
### Step 3 — Gate predicate (the only path that advances)
|
|
235
239
|
The step may advance **iff ALL hold**:
|
|
@@ -248,7 +252,7 @@ The step may advance **iff ALL hold**:
|
|
|
248
252
|
`../yad-architecture/references/contract-format.md`): if it no longer matches
|
|
249
253
|
`.sdlc/contract-lock.json`, the surface changed → approvals stale → return to `comment` and re-lock.
|
|
250
254
|
|
|
251
|
-
If the predicate **passes**,
|
|
255
|
+
If the predicate **passes**, hand the person the command that advances it — **never edit `state.json` by hand**:
|
|
252
256
|
|
|
253
257
|
```bash
|
|
254
258
|
yad gate advance <epic> <artifact> # a Product with no platform (E112)
|
|
@@ -337,7 +341,7 @@ write path.
|
|
|
337
341
|
with no error: `yad gate approve`, `yad gate comment` and `yad gate advance` record the review in the
|
|
338
342
|
engine (E112).
|
|
339
343
|
- **A passed gate is taken back only by `yad gate reopen`** (#322), and only before Build starts:
|
|
340
|
-
`yad gate reopen <epic> <step> --reason "<why>"
|
|
344
|
+
the person runs `yad gate reopen <epic> <step> --reason "<why>"`, which walks the chain back to the step and revokes the
|
|
341
345
|
later reviews' approvals, so each gate runs again. Never edit `state.json` or `approvals.json` by hand
|
|
342
346
|
to do it.
|
|
343
347
|
|
|
@@ -210,7 +210,7 @@ approved, never of the default branch when the gate happens to read it (#366). S
|
|
|
210
210
|
cover one artifact (per-story `review/<epic>/stories-S0N` branches, or a re-review on a fresh MR), and
|
|
211
211
|
another one merged in between, without approvals, would otherwise pass on these approvals. So a
|
|
212
212
|
merged review whose head differs from the default branch passes nothing, and the gate says so and
|
|
213
|
-
names the fix: review the artifact as it stands on a fresh PR/MR — fetch with `git fetch --prune origin`, reset the branch `review/<epic>/<artifact>` to the default branch (`git switch -C`: the merged review's branch is usually still there), add a commit (an empty one is enough: `git commit --allow-empty`), push it with `--force-with-lease`, then run `yad gate open <epic> <artifact>`. A default branch
|
|
213
|
+
names the fix: review the artifact as it stands on a fresh PR/MR — fetch with `git fetch --prune origin`, reset the branch `review/<epic>/<artifact>` to the default branch (`git switch -C`: the merged review's branch is usually still there), add a commit (an empty one is enough: `git commit --allow-empty`), push it with `--force-with-lease`, then run `yad gate open <epic> <artifact>`. The force push is the person's (E158: an agent never force-pushes): an agent gives them the steps, and runs `yad gate open` once they say it is pushed and `git ls-remote origin review/<epic>/<artifact>` shows it. A default branch
|
|
214
214
|
with nothing to fingerprint (every story deleted, a contract with no END marker) passes no approval of
|
|
215
215
|
real content either, and solo mode, which counts no approvals, says nothing. A step already done is
|
|
216
216
|
only re-synced: no hold is printed, and its approvals keep the fingerprint they were recorded with.
|
package/skills/yad-run/SKILL.md
CHANGED
|
@@ -39,7 +39,8 @@ beside it as advice and never refuses on it. The kill switch (`yad kill`) holds
|
|
|
39
39
|
`../yad-epic/references/state-schema.md`.
|
|
40
40
|
- These machine-written Build files (`build-state/<story>.json`, the `trust-log/` shards) are
|
|
41
41
|
committed by **`yad checkpoint`** — the Build analogue of the Shape `yad gate` sync; the loop
|
|
42
|
-
calls it each iteration so the state is durable and shared without a human commit
|
|
42
|
+
calls it each iteration so the state is durable and shared without a human commit — its `--push`, which
|
|
43
|
+
lands on the default branch, only after the person says yes (E158). (`yad checkpoint`
|
|
43
44
|
stages the shard dirs; `yad tidy up` later folds finished shards — loose objects + `git gc`.)
|
|
44
45
|
- The orchestrator **calls the existing step skills unchanged** — `yad-spec` (A), `yad-implement`
|
|
45
46
|
(B), `yad-checks` (C). It owns only the *advance decision*, never what a step does.
|
|
@@ -103,7 +104,8 @@ Walk the steps for `repo` starting at `from`/`currentStep`. For each step:
|
|
|
103
104
|
step's skill stopped to ask its human-only questions (its first batch or a later one), the step's
|
|
104
105
|
output is not finished, and a draft is not output to judge: record no trust entry. Run
|
|
105
106
|
`yad build step <story> --repo <repo> <step> blocked [--task <task>] --reason "waiting on human
|
|
106
|
-
decisions: <the questions, short>"`,
|
|
107
|
+
decisions: <the questions, short>"`, ask the person before `yad checkpoint --push` (a push to the default
|
|
108
|
+
branch is asked about every time, E158), and stop — skip steps 3 and 4.
|
|
107
109
|
**Not when the skill also hit its contract STOP** (a contract-change item in its batch): no answer
|
|
108
110
|
lifts that, so it is the step-4 contract-touch halt, with its trust entry, as before.
|
|
109
111
|
3. **Ask the engine for the effective dial:** `yad dial <epic> <story> --repo <repo> <step> --json`, and use
|
|
@@ -140,15 +142,17 @@ Walk the steps for `repo` starting at `from`/`currentStep`. For each step:
|
|
|
140
142
|
gate, which finalizes the trust verdict (confirm/override the provisional one).
|
|
141
143
|
|
|
142
144
|
**Commit the machine-written state.** After each iteration's writes (the trust-log shard in 2 and the
|
|
143
|
-
build-state change in 4), run `yad checkpoint --push` from `{project-root}
|
|
145
|
+
build-state change in 4), ask the person, then run `yad checkpoint --push` from `{project-root}` (a push to
|
|
146
|
+
the default branch is asked about every time, E158). It commits *only* the
|
|
144
147
|
`trust-log/` shards + `build-state/<story>.json` (never a Shape gate file) as one `chore(product): …`
|
|
145
148
|
audit-trail commit, and only ever on the default branch. It is a safe no-op when nothing changed, so
|
|
146
|
-
|
|
149
|
+
offer it every iteration — teammates don't review these machine writes, but CI and the `yad-status` skill on
|
|
147
150
|
other machines must see current trust evidence. Never run it off the default branch (it will refuse):
|
|
148
151
|
an unpushed or branch-stranded trust log leaves the run record `yad dial` shows out of date.
|
|
149
152
|
|
|
150
153
|
### `action: set-dial` — set (or revert) a step's advance dial
|
|
151
|
-
|
|
154
|
+
Only when the person asked for this exact change (E158): run
|
|
155
|
+
`yad dial <epic> <story> --repo <repo> <step> --to <human|auto>` (map `human_approve` → `human` and
|
|
152
156
|
`machine_advance` → `auto` first). The engine writes both dial names on the lane step, refuses a gate and
|
|
153
157
|
a lane step `yad-run` has not written yet, and prints the step's run record in that repo **as advice**.
|
|
154
158
|
Relay its output. There is **no threshold** (E34): the team decides, and "it seems fine" is theirs to
|
|
@@ -158,7 +162,7 @@ For a Shape author step the team wants on auto, point at `yad dial <step> --to a
|
|
|
158
162
|
recorded only: this loop never drives a Shape step.
|
|
159
163
|
|
|
160
164
|
### `action: kill` / `action: unkill` — the kill switch
|
|
161
|
-
|
|
165
|
+
Only when the person asked for it (E158): run `yad kill --reason "<why>"` or `yad unkill [--reason "<why>"]`. The engine records who, when and why
|
|
162
166
|
in `.sdlc/automation.json`; while the switch is on, **every** step's effective dial is `human`. Tell the
|
|
163
167
|
user to commit that file so every machine and CI sees it. Never set a `kill_switch` in `config.yaml`:
|
|
164
168
|
nothing reads it, and `yad doctor` fails on one left `true`.
|
|
@@ -95,7 +95,8 @@ Write it only when you write `done`, and never over a `closed` already on the st
|
|
|
95
95
|
nudge; otherwise `human`. Persist build-state after every transition so a halt leaves an accurate,
|
|
96
96
|
resumable record.
|
|
97
97
|
|
|
98
|
-
`checkpoint` = run `yad checkpoint --push` from `{project-root}
|
|
98
|
+
`checkpoint` = ask the person, then run `yad checkpoint --push` from `{project-root}` (it pushes to the default
|
|
99
|
+
branch, which an agent asks about every time, E158). It commits the machine-written
|
|
99
100
|
Build ledgers (in this loop, the loose `trust-log/` shards this run wrote + `build-state/<story>.json`;
|
|
100
101
|
also the `build-log/` shards at engineer-review) — the shard dirs are what checkpoint stages, the same
|
|
101
102
|
way `git gc` folds loose objects later (`yad tidy up` folds finished shards into the folded
|
package/skills/yad-spec/SKILL.md
CHANGED
|
@@ -117,6 +117,27 @@ The **`test-cases` track may still be `in_progress`**: it is parallel and non-bl
|
|
|
117
117
|
and point the user at `yad-status`. **Do not mutate Shape state** — `ready-for-build` semantics
|
|
118
118
|
stay intact.
|
|
119
119
|
|
|
120
|
+
**Read the story's design frames (#354).** From the Product, run `yad story frames <story> --json`. Its
|
|
121
|
+
`frames` list holds each design-tool frame the story builds: `id`, `name`, `platform` and `url`, read
|
|
122
|
+
from the epic's `design-links.json`. When it has frames, `spec.md` (full or light) gets a
|
|
123
|
+
`## Design frames` section with one line per frame — `- <name> (<platform>) — <id> — <url>` — so the
|
|
124
|
+
spec and the tasks name the screens and nobody has to ask which ones belong to this story. A finding it
|
|
125
|
+
prints (an ID it cannot find, say) is a warning: copy it into that section as an open question, and do
|
|
126
|
+
not guess a frame. `recorded: false` or an empty list means no frames: write no section.
|
|
127
|
+
|
|
128
|
+
**Check the design tool can be reached (#358), before anything else for a story with frames.** The same
|
|
129
|
+
answer carries `preflight`. When `preflight.reachable` is `check`, make the MCP call `preflight.probe`
|
|
130
|
+
describes, now, before the ceremony starts. Some design tools (Pencil, Figma's desktop server) are read
|
|
131
|
+
through the running app, so a closed app or the wrong file open is found here and not half way through.
|
|
132
|
+
- **It answers, with the right file open:** go on.
|
|
133
|
+
- **It fails, or another file is open: STOP.** Print `preflight.stop` word for word and wait. Go on
|
|
134
|
+
without the design tool only when the person says so, and record that in `spec.md`'s
|
|
135
|
+
`## Clarifications` as `- Q: design tool not reachable → A: continue without it, from the frame links`
|
|
136
|
+
(when `spec.md` is not written yet, add the line as soon as it is).
|
|
137
|
+
- **`not-checkable`** (nothing to probe — `preflight.why` says why: for example no design tool, one yad has
|
|
138
|
+
no check for, or design-links.json missing or recorded for another tool): go on from the frame links, and say
|
|
139
|
+
`preflight.why` once. **`preflight: null`** (no frames): nothing to check.
|
|
140
|
+
|
|
120
141
|
### Step 2 — Resolve the target code repo
|
|
121
142
|
Map `repo` → `{project-root}/demo-repos/<repo>/`. Confirm it exists and is its own git repo
|
|
122
143
|
(`demo-repos/<repo>/.git` present). If missing, STOP and point the user at `demo-repos/README.md`
|
|
@@ -74,6 +74,19 @@ Phase 3 build (Spec Kit per repo) accurate anchors instead of invented ones.
|
|
|
74
74
|
`code-context: stale` in the story frontmatter.
|
|
75
75
|
- **Traceability:** record the loaded maps in each story's `code-context:` frontmatter field.
|
|
76
76
|
|
|
77
|
+
### Step 2c — Load the design frames (so no one has to ask which screens a story builds)
|
|
78
|
+
When the UI step drew the screens in a design tool, it recorded them in
|
|
79
|
+
`{project-root}/epics/EP-<slug>/.sdlc/design-links.json`: a `screens` list, each with `name`, `platform`,
|
|
80
|
+
`nodeId` and `url`. Read it. In Step 5 each story lists the `nodeId`s of the screens it builds in its
|
|
81
|
+
`design-frames:` field, so the spec and implement steps read them with `yad story frames <story>`.
|
|
82
|
+
|
|
83
|
+
- **No file, no field:** with no `design-links.json` (no design tool, or the UI step skipped), leave
|
|
84
|
+
the `design-frames:` line out of every story and name the screens in "Notes for build" as before.
|
|
85
|
+
`[]` means "this story has no screens", which is not the same as "no frames were recorded".
|
|
86
|
+
- **IDs only, copied exactly, no quotes.** Copy each `nodeId` character for character, without quote
|
|
87
|
+
marks. The name and link stay in `design-links.json`, so they are written down once. A frame ID holding a comma, a space, `#` or a
|
|
88
|
+
bracket cannot be read back: ask for that frame to get a plain ID in the design tool.
|
|
89
|
+
|
|
77
90
|
### Step 3 — Break down the epic (assist: pm)
|
|
78
91
|
Adopt the **pm** lens. Decompose the epic into the smallest set of
|
|
79
92
|
independently reviewable, independently buildable stories. For each story decide which repos it touches
|
|
@@ -96,6 +109,7 @@ status: draft
|
|
|
96
109
|
owner: <inherit from epic.md owner> # the epic owner carries through; not retyped
|
|
97
110
|
repos: [<subset of epic.repos this story implements>]
|
|
98
111
|
code-context: { repos: [], loaded: <YYYY-MM-DD or none> } # code-maps anchoring "Notes for build" (Step 2b)
|
|
112
|
+
design-frames: []
|
|
99
113
|
---
|
|
100
114
|
|
|
101
115
|
## Story
|
|
@@ -112,6 +126,14 @@ As a <role>, I want <capability>, so that <outcome>.
|
|
|
112
126
|
|
|
113
127
|
`repos` is the field the later build phase reads to know where to scaffold specs — set it precisely.
|
|
114
128
|
|
|
129
|
+
`design-frames` lists the design-tool frame IDs (`nodeId`s from `design-links.json`, Step 2c) of the
|
|
130
|
+
screens this story builds, on ONE line: `design-frames: [12:34, 56:78]`. Leave it `[]` for a story with
|
|
131
|
+
no screens, and take the line out when the epic has no `design-links.json` (Step 2c). **Never put a `# comment` after it**, and never write it as a `- id` list on the lines
|
|
132
|
+
below: this frontmatter reader keeps the rest of the line, so either one makes the list unreadable.
|
|
133
|
+
Before the review, run `yad story frames <story>` for each story: it prints every frame's name and link,
|
|
134
|
+
and warns on an ID it cannot find. The field is part of the story, so the stories review approves it
|
|
135
|
+
like `repos`, and changing it after that review passed means the review must approve it again.
|
|
136
|
+
|
|
115
137
|
### Step 6 — Advance the authoring step (NOT the gate)
|
|
116
138
|
**Check the mode first — the two modes have opposite instructions here.** Read `.sdlc/product.json` (`.sdlc/hub.json` on an older Product that has only that name):
|
|
117
139
|
**verified mode** is `platform` set AND `ledger: "verified"` — or, on a project that has not run `yad migrate` yet, `bridge_enabled` (or legacy `bridge`) `true`. `ledger` wins whenever it is present.
|
|
@@ -13,6 +13,7 @@ Each story authored at Shape step 7 is one Markdown file under `epics/EP-<slug>/
|
|
|
13
13
|
| `status` | `draft` \| `in-review` \| `approved`, then `in-build` \| `shipped` | Story lifecycle: the first three within the stories gate (`yad sync-status` moves them), the last two in Build (`yad build ship` sets `in-build`, `yad build done` sets `shipped`). |
|
|
14
14
|
| `repos` | subset of the epic's `repos` | Which repos must implement this story. **Labels the stories review PR with the touched repos now and (Phase 3) decides where specs are scaffolded.** |
|
|
15
15
|
| `code-context` | `{ repos: [<name@sha>], loaded: <date> }` | Optional. Which connected-repo code-maps anchored "Notes for build" (Shape step 7 Step 2b). The `@sha` (a repo's `syncedHead`) is recommended so freshness is recorded but may be omitted; the SKILL templates show the empty placeholder `{ repos: [], loaded: <date or none> }`. `none` / `[]` when no repos are connected. |
|
|
16
|
+
| `design-frames` | `[<nodeId>, …]` or `[]` | The design-tool frames (Pencil, Figma) of the screens this story builds: each one a `nodeId` from the epic's `.sdlc/design-links.json`, copied exactly. `[]` = the story has no screens; no field = not recorded (also the case for every story of an epic with no `design-links.json`). IDs only: the name, platform and link are read from `design-links.json` by `yad story frames <story>`, which the spec and implement steps run (issue #354). Write it on one line, the IDs without quotes, with no `# comment` after it. Part of the reviewed story: changing it after the stories review passed needs that review again. `yad doctor` warns (`stories:design-frames`) on an ID it cannot find. |
|
|
16
17
|
|
|
17
18
|
## Body
|
|
18
19
|
|
|
@@ -81,7 +81,8 @@ so any repo whose `HEAD` now differs from its registry `syncedHead` has a **stal
|
|
|
81
81
|
the command ends by pointing the human at `yad repo refresh` to repack (that is a separate human
|
|
82
82
|
decision; this skill never repacks or writes the registry). After the repack + AI code-map
|
|
83
83
|
regeneration, `yad repo refresh --push` publishes the refreshed code-maps + registry to the Product's
|
|
84
|
-
default branch as a `chore(product): sync code-context … [skip ci]` audit commit.
|
|
84
|
+
default branch as a `chore(product): sync code-context … [skip ci]` audit commit. It pushes to the default
|
|
85
|
+
branch, so an AI agent asks the person first, every time (E158).
|
|
85
86
|
|
|
86
87
|
## Hard rules
|
|
87
88
|
|
package/skills/yad-ui/SKILL.md
CHANGED
|
@@ -81,8 +81,8 @@ pipeline, infra work), it does not need a UI design. Two signals to watch for:
|
|
|
81
81
|
from before shape 7, `done` with `skipped: true` beside it — the step was marked N/A. If it is
|
|
82
82
|
`deferred`, the team set it aside to come back to later. Either way the `--check` above refuses it
|
|
83
83
|
(`ui-design is already skipped`, or `already deferred`). **STOP**, there is nothing to author now;
|
|
84
|
-
point the user at `yad next EP-<slug>` (the next step is `stories`).
|
|
85
|
-
run `yad undefer EP-<slug> ui-design` first.
|
|
84
|
+
point the user at `yad next EP-<slug>` (the next step is `stories`). When the person asks to pick a
|
|
85
|
+
deferred UI back up, run `yad undefer EP-<slug> ui-design` first.
|
|
86
86
|
- **Should be skipped:** if you reach this step and the epic clearly produces no screens, do **not**
|
|
87
87
|
invent a hollow UI artifact. Offer to mark it N/A instead:
|
|
88
88
|
`yad skip EP-<slug> ui-design --reason "<why, e.g. backend-only service>"`. That marks both the
|
|
@@ -216,6 +216,11 @@ When Step 3b generated or linked a design, write the machine-readable screen→f
|
|
|
216
216
|
Keep the `## Design (<tool>)` section of `ui-design.md` in step with this file. When Step 3b degraded
|
|
217
217
|
(`design: none`), do **not** write `design-links.json`.
|
|
218
218
|
|
|
219
|
+
Each `nodeId` is what a story records later: the stories step lists the frame IDs each story builds in
|
|
220
|
+
its `design-frames:` field, and the spec and implement steps read them with `yad story frames <story>`
|
|
221
|
+
(#354). So record every screen with its real `nodeId`, keep a frame's ID the same when you edit it, and
|
|
222
|
+
give a frame a plain ID — one with a comma, a space, `#` or a bracket cannot be read back from a story.
|
|
223
|
+
|
|
219
224
|
### Step 5 — Advance the authoring step (NOT the gate)
|
|
220
225
|
**Check the mode first — the two modes have opposite instructions here.** Read `.sdlc/product.json` (`.sdlc/hub.json` on an older Product that has only that name):
|
|
221
226
|
**verified mode** is `platform` set AND `ledger: "verified"` — or, on a project that has not run `yad migrate` yet, `bridge_enabled` (or legacy `bridge`) `true`. `ledger` wins whenever it is present.
|