yadflow 4.0.1 → 4.2.0

package/cli/doctor.mjs

@@ -25,6 +25,7 @@ import { soloTeamHint, TEAM_CMD } from './people.mjs';
 import { indexFreshness, INDEX_FILE } from './product-index.mjs';
 import { productGit, resolveDefaultBranch } from './productcommit.mjs';
 import { readOwners } from './owners.mjs';
+import { loadChoices, readToolboxFile } from './toolbox.mjs';
 
 // A registered path doctor may run git in (E81): a checkout the judgement accepts — never a refused
 // entry (git run in a folder the Product shaped as a repo reads its `config`, which can run a command),
@@ -446,6 +447,7 @@ export function projectChecks(checks, root, { headCount = null } = {}) {
   // inside the `project` block. The renderer prints a header every time the section CHANGES, so a
   // `project` check added after the `shape` section prints the word "project" a second time.
   skillBindingChecks(checks, root);
+  toolboxFileChecks(checks, root);
 
   // repos.json: parse + every entry is a live git repo; staleness vs syncedHead
   let registry = { repos: [] };
@@ -2107,6 +2109,28 @@ export function skillBindingChecks(checks, root) {
   }
 }
 
+// `.sdlc/toolbox.json`: which toolbox tools this Product uses or skips, and its own tools (E86). Absent is
+// the normal case. THE FILE ONLY: whether a tool is installed is `yad toolbox check`'s answer, and a
+// missing tool is never a doctor line (decided with E86 — no tool is required). A broken file fails, as
+// skills.json does; a line that does nothing warns, because `yad toolbox list` quietly shows the default.
+export function toolboxFileChecks(checks, root) {
+  const rel = PROJECT_FILES.toolboxConfig;
+  if (!exists(path.join(root, rel))) return;
+  const { error } = readToolboxFile(root);
+  if (error) {
+    check(checks, 'toolbox', 'project', 'fail', `${rel} ${error}`, 'fix the JSON or restore it from git — `yad toolbox list` shows the defaults until then');
+    return;
+  }
+  const { problems, unreachable, shipped, custom } = loadChoices(root);
+  if (problems.length) {
+    // An entry with no id (or an empty one) is out of `remove`'s reach; only hand-editing fixes it.
+    check(checks, 'toolbox', 'project', 'warn', `${rel}: ${problems.length} line(s) do nothing — ${problems.map((p) => p.replace(`${rel}: `, '')).join('; ')} [YAD-CFG-007]`,
+      `fix them by hand, or \`yad toolbox remove <id>\` — it clears whatever the file holds under that id — and add the tool again${unreachable ? ' (an entry with no id, or an empty one: fix it by hand)' : ''}`);
+    return;
+  }
+  check(checks, 'toolbox', 'project', 'ok', `toolbox: ${shipped.size} shipped tool choice(s), ${custom.length} tool(s) of this project's own`);
+}
+
 // A step this release does not recognise. Every step the engine can run has a row in the step
 // catalogue (E4), and that row is what gives it both a phase and a skill. So an id no phase claims is
 // an id with no row at all: one `yad next` cannot guide, `yad gate` has no artifact rule for, and no

package/cli/errors.mjs

@@ -30,6 +30,7 @@ export const CODES = {
   'YAD-CFG-004': 'learning.json names an unknown learning tool (expected one of config.yaml learning.tools, or none)',
   'YAD-CFG-005': 'the Product settings (product.json, or hub.json on a Product that has only that name) set a platform but are missing git_url (required to scope auth + open PRs)',
   'YAD-CFG-006': 'skills.json binds a step to something that is not a skill name (expected a string, or a non-empty list of strings)',
+  'YAD-CFG-007': 'toolbox.json has a line that does nothing — a tool this yadflow does not ship, a choice other than use or skip, or a custom tool that is incomplete, malformed, listed twice or uses a shipped tool\'s id',
   'YAD-CLI-001': 'a --json run needed an answer that only a prompt could give',
 };
 

package/cli/manifest.mjs

@@ -275,6 +275,9 @@ export const PROJECT_FILES = {
   // the normal case and means "every step uses the skill the catalogue names" — like design.json,
   // which is absent on a markdown-only project.
   skillsConfig: '.sdlc/skills.json',
+  // Which toolbox tools this project uses or skips, and its own tools (E86). Absent is the normal case:
+  // the core tools and the connected design, testing and learning tools are the ones in use.
+  toolboxConfig: '.sdlc/toolbox.json',
   // The kill switch and the Shape steps a team has set to `advance: auto` (E34). Absent is the normal
   // case: the switch is off and every Shape step is `human`. A project file, not the module config the
   // switch lived in before (`_bmad/sdlc/config.yaml` then, `.sdlc/config.yaml` since E3) — that one is