yadflow 3.9.1 → 3.9.2

package/CHANGELOG.md

@@ -1,9 +1,9 @@
-## [3.9.1](https://github.com/abdelrahmannasr/yadflow/compare/v3.9.0...v3.9.1) (2026-07-06)
+## [3.9.2](https://github.com/abdelrahmannasr/yadflow/compare/v3.9.1...v3.9.2) (2026-07-06)
 
 
 ### Bug Fixes
 
-* carry ship-backed story status flip in yad checkpoint ([#112](https://github.com/abdelrahmannasr/yadflow/issues/112)) ([478230c](https://github.com/abdelrahmannasr/yadflow/commit/478230cdfccafbcc80913dd3b0a69262a45cbea6))
+* validate explicit --task id format in yad commit ([e3b0527](https://github.com/abdelrahmannasr/yadflow/commit/e3b05276b951dbeab6ce6bcb135e8228f73ede9d))
 
 # [2.2.0](https://github.com/abdelrahmannasr/yadflow/compare/v2.1.0...v2.2.0) (2026-06-14)
 

package/bin/yad.mjs

@@ -124,7 +124,7 @@ ${c.bold('Options')}
   --dir <path>          Target project root (default: cwd)
   --type <t>            commit: feat|fix|docs|refactor|test|perf|build|ci|chore|revert
   -m, --message <s>     commit: subject / PR title
-  --task <id>           commit: Task trailer (else derived from the branch)
+  --task <id>           commit: Task trailer, a <story>-T<NN> id (else derived from the branch)
   --ai <id>             commit: co-author — claude|copilot|cursor|coderabbit|none (default none)
   --contract-change     commit/open-pr: mark the contract surface touched
   --risk <level>        open-pr: low|medium|high (default low)

package/cli/commit.mjs

@@ -2,12 +2,14 @@
 // Subject is Conventional Commits; trailers are emitted in the fixed order
 // Task -> Contract-Change -> Co-Authored-By. The human git author OWNS the commit; the AI is only a
 // co-author (flagged with --ai, or `none` for human-only). An atomic-commit guard keeps diffs small.
+// An explicit --task id is validated against the spec-link gate contract (<story>-T<NN>) so a
+// malformed trailer fails locally rather than after a push.
 import path from 'node:path';
 import fs from 'node:fs';
 import { c, log, ok, info, warn, fail, run, exists } from './lib.mjs';
 import {
   COMMIT_TYPES, AI_COAUTHORS, ATOMIC_FILE_LIMIT,
-  TASK_TRAILER, CONTRACT_CHANGE_TRAILER, COAUTHOR_TRAILER, PROJECT_FILES,
+  TASK_TRAILER, CONTRACT_CHANGE_TRAILER, COAUTHOR_TRAILER, PROJECT_FILES, TASK_ID_RE,
 } from './manifest.mjs';
 
 // PURE — unit tested directly. Build the full commit message text.
@@ -16,6 +18,13 @@ export function buildCommitMessage({ type, subject, task, contractChange = false
   if (!subject || !subject.trim()) throw new Error('commit subject is required');
   if (!(ai in AI_COAUTHORS)) throw new Error(`unknown --ai "${ai}" (one of: ${Object.keys(AI_COAUTHORS).join(', ')})`);
   if (/\.$/.test(subject.trim())) throw new Error('subject must not end with a period');
+  // A malformed task id (e.g. a bare story `EP-x-S01` with no -T<NN>) commits fine locally but
+  // then fails the spec-link CI gate — forcing a history rewrite + force-push. Reject it here so
+  // it never enters a trailer. Well-formed branch-derived ids (taskFromBranch) are stricter and pass;
+  // a lowercase-suffix branch is caught here, matching the case-sensitive spec-link grep.
+  if (task && !TASK_ID_RE.test(task)) {
+    throw new Error(`invalid --task "${task}" (expected <story>-T<NN>, e.g. EP-x-S01-T02) — the spec-link CI gate would reject it`);
+  }
 
   const trailers = [];
   if (task) trailers.push(`${TASK_TRAILER}: ${task}`);

package/cli/manifest.mjs

@@ -170,6 +170,10 @@ export const ATOMIC_FILE_LIMIT = 3;
 export const TASK_TRAILER = 'Task';
 export const CONTRACT_CHANGE_TRAILER = 'Contract-Change';
 export const COAUTHOR_TRAILER = 'Co-Authored-By';
+// A Task trailer id must be a real <story>-T<NN>. Mirrors the spec-link gate contract
+// (checks/spec-link.sh: `.+-T[0-9]+$`) so an explicit --task that would fail CI is
+// rejected locally at commit time instead of after a push + history rewrite.
+export const TASK_ID_RE = /.+-T\d+$/;
 
 // Per-epic ledger files under epics/<epic>/.sdlc/ (the file source of truth the gate reads/writes).
 export const epicFiles = (epicRoot) => ({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "yadflow",
-  "version": "3.9.1",
+  "version": "3.9.2",
   "description": "Yadflow — the gated, team, multi-repo SDLC: author → review → build with a PR-driven review gate and a zero-dependency `yad` CLI (setup, gate, commit, open-pr, ship, repo, thread, reconcile). A BMAD module + 38 yad-* skills.",
   "type": "module",
   "author": "AbdelRahman Nasr",

package/skills/yad-commit/SKILL.md

@@ -20,7 +20,9 @@ and `yad-ship` use. It **never auto-advances**; it just commits.
 - **Subject** — `<type>: <lowercase imperative description, no trailing period>`; types are
   `feat|fix|docs|refactor|test|perf|build|ci|chore|revert`; proper nouns/acronyms keep their case.
 - **Task trailer** — required on a code repo (anchors the `spec-link` + `commit-message` gates). Given
-  with `--task`, else derived from the branch (`feat/<story>-<task>-…`). Hub commits are not
+  with `--task` (a `<story>-T<NN>` id — an explicit value is validated against the `spec-link`
+  contract, so a malformed id like a bare `EP-x-S01` fails locally instead of after a push), else
+  derived from the branch (`feat/<story>-<task>-…`). Hub commits are not
   task-scoped, so the trailer is optional there — a missing-Task warning is informational on the hub
   (`spec-link` is a code-repo gate) and only flags a real gate failure in a code repo.
 - **Contract-Change trailer** — `--contract-change` only when the diff touches the locked contract