yadflow 3.10.0 → 3.10.1

package/CHANGELOG.md

@@ -1,3 +1,11 @@
+## [3.10.1](https://github.com/abdelrahmannasr/yadflow/compare/v3.10.0...v3.10.1) (2026-07-08)
+
+
+### Bug Fixes
+
+* re-run pr-template gate on an edited PR body ([17ad94a](https://github.com/abdelrahmannasr/yadflow/commit/17ad94a4881610b4b653700be50a4eddd7036c5d))
+* stop yad repo refresh --push stranding the regenerated pack.md ([f0b5f4c](https://github.com/abdelrahmannasr/yadflow/commit/f0b5f4ce9f22afcd6078aae3ea1dd5a64885be35))
+
 # [3.10.0](https://github.com/abdelrahmannasr/yadflow/compare/v3.9.4...v3.10.0) (2026-07-08)
 
 

package/cli/repo-publish.mjs

@@ -5,8 +5,13 @@
 // analogue of `yad checkpoint` (cli/checkpoint.mjs) and reuses its default-branch commit machinery.
 //
 // Invariants (shared with checkpoint):
-//   1. Stage an EXPLICIT allowlist — exactly the tracked code-maps + the registry (never `git add -A`,
-//      which would sweep unrelated work in the hub). The gitignored repomix pack.md is never staged.
+//   1. Commit an EXPLICIT allowlist via `git commit -- <paths>` (--only) — the tracked code-maps, the
+//      registry, and (only when its change is the managed pack-ignore block alone) the hub `.gitignore`.
+//      NEVER `git add -A` and NEVER a whole-index `git reset`: both would mutate unrelated staged work.
+//      The repomix pack.md is gitignored (setup + publish scaffold the ignore via ensurePackIgnored) and
+//      never committed as content. A pack committed BEFORE that ignore existed is self-healed here: its
+//      on-disk file is held aside across the --only commit so the deletion is recorded (the regenerable
+//      cache is restored right after), clearing the stranded working tree — see the commit block below.
 //   2. Commit ONLY on the hub's default branch (unless --allow-branch), so the `[skip ci]` audit
 //      commit never enters a PR's base..HEAD range where it would strand required checks.
 import fs from 'node:fs';
@@ -16,6 +21,7 @@ import { PROJECT_FILES } from './manifest.mjs';
 import { loadHub } from './gate.mjs';
 import { resolveCommitterLogin } from './platform.mjs';
 import { hubGit, resolveDefaultBranch, guardDefaultBranch, preflightGuardReadiness } from './hubcommit.mjs';
+import { ensurePackIgnored, PACK_IGNORE_BLOCK } from './setup.mjs';
 import { checkpointAuthor } from './checkpoint.mjs';
 
 // Collapse any whitespace/newline runs to a single space — keeps a hostile `git user.name` or a stray
@@ -25,6 +31,9 @@ const oneLine = (s = '') => String(s).replace(/\s+/g, ' ').trim();
 // The tracked code-map for a repo: the registered path, else the conventional location.
 const codeMapOf = (repo) => repo.codeMap || path.posix.join('.sdlc/code-context', repo.name, 'code-map.md');
 
+// The repomix pack for a repo: the registered path, else the conventional location.
+const packOf = (repo) => repo.contextPack || path.posix.join('.sdlc/code-context', repo.name, 'pack.md');
+
 // PURE — the repo-relative pathspecs to stage: the registry plus each registered repo's code-map that
 // exists on disk. When `name` is given (a scoped `yad repo refresh <name> --push`), only that repo's
 // code-map is staged, so an unrelated repo's uncommitted code-map never rides along in a named refresh's
@@ -41,6 +50,57 @@ export function codeMapPathspecs(root, registry = { repos: [] }, name = null) {
   return out;
 }
 
+// PURE — each registered repo's on-disk pack path (scoped by `name` like codeMapPathspecs). These are
+// UNTRACK candidates, not content to stage: the pack is gitignored, but a hub that committed it before
+// the ignore existed would otherwise strand a dirty pack on every refresh. publishCodeContext keeps only
+// the still-tracked ones and records their removal in the audit commit (see the self-heal block there).
+export function packPathspecs(root, registry = { repos: [] }, name = null) {
+  const out = [];
+  for (const repo of registry.repos || []) {
+    if (name && repo.name !== name) continue;
+    const rel = packOf(repo);
+    if (fs.existsSync(path.join(root, rel))) out.push(rel);
+  }
+  return out;
+}
+
+// True iff committing `.gitignore` would carry ONLY the managed pack-ignore block (comments + glob) and
+// nothing else. Guards invariant 1: a hub whose `.gitignore` also has unrelated uncommitted edits must
+// keep them OUT of the `[skip ci]` audit commit. The publish commit is `git commit -- <paths>` (--only,
+// reads the WORKING TREE), so this compares the working tree — an untracked `.gitignore` must be wholly
+// managed; a tracked one must differ from HEAD by the managed block alone (added, nothing removed).
+// `git` is a hubGit-style accessor; `root` is the hub root. Mirrors checkpoint's stagedStoryIsStatusOnly.
+export function ignoreChangeIsManagedOnly(git, root) {
+  const gi = path.join(root, '.gitignore');
+  if (!fs.existsSync(gi)) return false;
+  const managed = new Set(PACK_IGNORE_BLOCK.map((l) => l.trim()));
+  if (!git('ls-files', '--error-unmatch', '--', '.gitignore').ok) {
+    // untracked: every non-blank line of the whole file must be a managed line
+    let seen = 0;
+    for (const l of fs.readFileSync(gi, 'utf8').split('\n')) {
+      const body = l.trim();
+      if (body === '') continue;
+      if (!managed.has(body)) return false;
+      seen++;
+    }
+    return seen > 0;
+  }
+  // tracked: the working-tree-vs-HEAD diff must ADD only managed lines and remove nothing
+  const d = git('diff', '-U0', 'HEAD', '--', '.gitignore');
+  if (!d.ok) return false;
+  let added = 0;
+  for (const ln of d.stdout.split('\n')) {
+    if (ln.startsWith('+++') || ln.startsWith('---') || ln.startsWith('@@')) continue; // headers/hunks
+    if (ln.startsWith('-')) return false;              // we only ever append — any removal ⇒ not ours
+    if (ln.startsWith('+')) {
+      const body = ln.slice(1).trim();
+      if (body !== '' && !managed.has(body)) return false; // a non-managed added line ⇒ a user edit
+      added++;
+    }
+  }
+  return added > 0;
+}
+
 // PURE — turn the staged pathspecs into the subject `label` + the body's file list. A `<name>` is
 // pulled from any `.sdlc/code-context/<name>/code-map.md` path; a commit that only touched the
 // registry is labelled `registry`.
@@ -49,7 +109,9 @@ export function summarizeCodeContext(files = []) {
   const basenames = [];
   for (const f of files) {
     basenames.push(f);
-    const m = f.match(/\.sdlc\/code-context\/([^/]+)\/code-map\.md$/);
+    // A repo name comes from either its code-map (content) or a pack removal (self-heal), so the
+    // subject label stays accurate even when untracking a stranded pack is the only change.
+    const m = f.match(/\.sdlc\/code-context\/([^/]+)\/(?:code-map|pack)\.md$/);
     if (m) repos.add(m[1]);
   }
   let label;
@@ -88,11 +150,26 @@ export async function publishCodeContext(root, { push = false, allowBranch = fal
   const defaultBranch = resolveDefaultBranch(git, hub);
   if (!guardDefaultBranch(branch, defaultBranch, { allowBranch, cmd: 'yad repo refresh --push' })) return;
 
+  // Stage the EXPLICIT allowlist (code-maps + registry), scoped so an unrelated pre-staged file is never
+  // swept in and the user's index is left untouched — mirrors `runCheckpoint`. NEVER `git add -A` and
+  // NEVER a whole-index `git reset` (both would mutate unrelated staged work). The commit below is
+  // `git commit -- <paths>` (--only), which reads the WORKING TREE for the named paths only.
   const pathspecs = codeMapPathspecs(root, registry, name);
-  if (!pathspecs.length) { info('no code-context to publish — nothing to commit'); return; }
+  if (pathspecs.length) {
+    const add = git('add', '--', ...pathspecs);
+    if (!add.ok) { fail(`git add failed — ${add.stderr.split('\n')[0] || add.code}`); process.exitCode = 1; return; }
+  }
 
-  const add = git('add', '--', ...pathspecs);
-  if (!add.ok) { fail(`git add failed — ${add.stderr.split('\n')[0] || add.code}`); process.exitCode = 1; return; }
+  // Make the "pack is gitignored" assumption true (idempotent; packRepo also does this on refresh) so a
+  // hub whose pack was tracked before the ignore existed stops stranding a dirty tree. Publish `.gitignore`
+  // ONLY when the change is the managed pack-ignore block alone (invariant 1) — a hub whose `.gitignore`
+  // also carries unrelated uncommitted edits keeps them OUT of this audit commit; the pack is still ignored
+  // on disk and the human commits their own `.gitignore` edits through their own change. When we do carry
+  // it, `git add` makes an untracked `.gitignore` known so the --only commit can include it.
+  const ignoreChanged = ensurePackIgnored(root);
+  const commitIgnore = ignoreChangeIsManagedOnly(git, root);
+  if (commitIgnore) git('add', '--', '.gitignore');
+  else if (ignoreChanged) hand('.gitignore has unrelated uncommitted edits — commit them yourself so the pack ignore is published (it is already ignored locally)');
 
   // Push HEAD to its OWN branch — on the default branch this is the same; with --allow-branch it keeps a
   // WIP branch from being force-published onto the default branch. Shared by the fresh-commit path and
@@ -105,7 +182,20 @@ export async function publishCodeContext(root, { push = false, allowBranch = fal
     return false;
   };
 
-  if (git('diff', '--cached', '--quiet', '--', ...pathspecs).ok) {
+  // Self-heal (invariant 1): a pack committed before it was gitignored strands the working tree on every
+  // refresh. Any STILL-TRACKED pack must be recorded as removed in this commit — but `git rm --cached`
+  // can't be committed under --only (which reads the working tree, where the regenerated pack still
+  // exists). So we untrack it below by momentarily removing the on-disk file across the commit (restored
+  // right after), letting --only record a clean deletion while the regenerable cache is preserved.
+  const trackedPacks = packPathspecs(root, registry, name)
+    .filter((p) => git('ls-files', '--error-unmatch', '--', p).ok);
+
+  // The exact files this audit commit will touch: the staged allowlist (+ managed `.gitignore`) plus any
+  // pack removal. Scopes the --only commit and, being all known to git, is a safe commit pathspec.
+  const ignoreSpec = commitIgnore ? ['.gitignore'] : [];
+  const staged = git('diff', '--cached', '--name-only', '--', ...pathspecs, ...ignoreSpec).stdout.split('\n').filter(Boolean);
+  const fileset = [...staged, ...trackedPacks];
+  if (!fileset.length) {
     // Nothing new to commit. A non-push run is simply done. But on a push run a PRIOR run may have
     // committed and then FAILED to push (the commit sits ahead of origin) — a plain re-run must land
     // that commit, not silently no-op and exit 0 while it stays stranded. Push any unpushed commit(s).
@@ -117,27 +207,37 @@ export async function publishCodeContext(root, { push = false, allowBranch = fal
     pushHead();
     return;
   }
-  // The exact files staged from the allowlist — scopes the commit to ONLY the allowlist, so any
-  // unrelated pre-staged file never rides along.
-  const staged = git('diff', '--cached', '--name-only', '--', ...pathspecs).stdout.split('\n').filter(Boolean);
 
   // Only relevant when we are about to push a commit straight to the default branch: warn (never block)
   // if signing/allowlisting would make the yad-update-guard reject it. Gated on `push` and deferred to
   // here so it isn't noise on a guard-refused branch or a nothing-to-commit run.
   if (push) preflightGuardReadiness(root);
 
-  const { label, basenames } = summarizeCodeContext(staged);
+  const { label, basenames } = summarizeCodeContext(fileset);
   const author = checkpointAuthor(resolveCommitterLogin(root, hub?.roster || []), git('config', 'user.name').stdout);
   const message = buildCodeMapMessage({ label, author, basenames });
 
-  const cm = git('commit', '-m', message, '--', ...staged);
-  if (!cm.ok) {
-    git('reset', '-q', '--', ...pathspecs); // don't leave the allowlist staged for an unrelated commit to sweep up
-    fail(`git commit failed — ${cm.stderr.split('\n')[0] || cm.code}`);
-    process.exitCode = 1;
-    return { message };
+  // Untrack the packs by holding their bytes and removing the files across the --only commit, then
+  // restoring them (now gitignored ⇒ a clean tree). try/finally so the regenerable cache is always put
+  // back, even on a commit failure.
+  const held = [];
+  try {
+    for (const p of trackedPacks) {
+      const abs = path.join(root, p);
+      held.push({ abs, buf: fs.readFileSync(abs) });
+      fs.rmSync(abs);
+    }
+    const cm = git('commit', '-m', message, '--', ...fileset); // --only: adds from the tree, packs as deletions
+    if (!cm.ok) {
+      git('reset', '-q', '--', ...pathspecs, ...ignoreSpec); // unstage only OUR allowlist for a clean retry
+      fail(`git commit failed — ${cm.stderr.split('\n')[0] || cm.code}`);
+      process.exitCode = 1;
+      return { message };
+    }
+  } finally {
+    for (const h of held) if (!fs.existsSync(h.abs)) fs.writeFileSync(h.abs, h.buf);
   }
-  ok(`published ${staged.length} file(s): ${c.dim(label)}`);
+  ok(`published ${fileset.length} file(s): ${c.dim(label)}`);
 
   if (!push) return { message };
   pushHead();

package/cli/repo.mjs

@@ -73,8 +73,9 @@ export async function runRepo(root, { action = 'list', name, today, push = false
     if (push) {
       // Publish whatever tracked code-context now differs (the AI-regenerated code-maps + the stamped
       // registry) straight to the hub's default branch as one audit-trail commit. The pack itself is
-      // gitignored; the code-map is regenerated by the AI (yad-connect-repos) — run that first if a
-      // repo's map is stale, then `yad repo refresh --push` lands it.
+      // gitignored (packRepo scaffolds the ignore; publish self-heals a pre-ignore tracked pack); the
+      // code-map is regenerated by the AI (yad-connect-repos) — run that first if a repo's map is stale,
+      // then `yad repo refresh --push` lands it.
       await publishCodeContext(root, { push: true, allowBranch, name });
     } else {
       hand('regenerate the code-map in Claude Code (yad-connect-repos) — the pack is cached, the map is the AI step');

package/cli/setup.mjs

@@ -740,12 +740,40 @@ export async function runSetup(root, opts = {}) {
   log(c.dim('Re-run anytime: `yad check` (report) / `yad check --fix` (reconcile).'));
 }
 
+// The repomix pack is a large, regenerable artifact — the hub tracks the AI-authored code-map, not the
+// pack. `yad repo refresh --push` relies on the pack being gitignored (repo-publish.mjs never stages it);
+// this makes that assumption true in every hub, so a regenerated pack never strands as a dirty tree.
+export const PACK_IGNORE_GLOB = '.sdlc/code-context/*/pack.md';
+
+// The exact lines ensurePackIgnored appends — a comment pair + the glob. Kept as data (not inline
+// strings) so the publish gate can verify a staged `.gitignore` change is ONLY this managed block and
+// never sweep an unrelated user edit into the audit commit (repo-publish.mjs, invariant 1).
+export const PACK_IGNORE_BLOCK = [
+  '# Repomix code-context packs are large, regenerable artifacts (yad repo refresh) — the',
+  '# tracked code-map.md is the reviewed AI output; the pack itself is never committed.',
+  PACK_IGNORE_GLOB,
+];
+
+// Idempotently ensure the hub `.gitignore` ignores the repomix pack. No-op (returns false) if the line
+// is already present (as its own entry); otherwise appends the managed block to a fresh or existing file
+// and returns true.
+export function ensurePackIgnored(root) {
+  const gi = path.join(root, '.gitignore');
+  const lines = exists(gi) ? fs.readFileSync(gi, 'utf8').split('\n') : [];
+  if (lines.some((l) => l.trim() === PACK_IGNORE_GLOB)) return false;
+  const body = lines.join('\n').replace(/\n*$/, '');
+  const prefix = body ? `${body}\n\n` : '';
+  fs.writeFileSync(gi, `${prefix}${PACK_IGNORE_BLOCK.join('\n')}\n`);
+  return true;
+}
+
 // Deterministic repomix pack (code-map generation itself is an AI step, handed off).
 export function packRepo(root, repo) {
   const repoRoot = path.resolve(root, repo.path);
   const out = path.join(root, repo.contextPack);
   if (!has('npx')) { warn(`${repo.name}: npx missing — skipped repomix pack`); return false; }
   fs.mkdirSync(path.dirname(out), { recursive: true });
+  ensurePackIgnored(root); // keep the pack out of git before it is (re)written — see repo-publish.mjs invariant 1
   info(`${repo.name}: packing with repomix …`);
   const r = run('npx', ['repomix@latest', '--compress', '--include-logs', '--style', 'markdown', '-o', out], { cwd: repoRoot });
   if (r.ok) { ok(`${repo.name}: cached ${repo.contextPack}`); hand(`${repo.name}: generate the code-map in Claude Code (yad-connect-repos)`); return true; }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "yadflow",
-  "version": "3.10.0",
+  "version": "3.10.1",
   "description": "Yadflow — the gated, team, multi-repo SDLC: author → review → build with a PR-driven review gate and a zero-dependency `yad` CLI (setup, gate, commit, open-pr, ship, repo, thread, reconcile). A BMAD module + 38 yad-* skills.",
   "type": "module",
   "author": "AbdelRahman Nasr",

package/skills/yad-checks/references/check-gates.md

@@ -215,7 +215,11 @@ The gates run identically under either CI; the config just invokes the scripts w
 
 - **GitHub Actions** — `templates/github/yad-checks.yml` → `.github/workflows/yad-checks.yml`. The
   jobs run on `pull_request` with `fetch-depth: 0`, passing `origin/${{ github.base_ref }}` as base
-  (verified-commits also gets a read-only `GH_TOKEN` for the Verified-badge lookup). The pattern jobs
+  (verified-commits also gets a read-only `GH_TOKEN` for the Verified-badge lookup). The trigger sets
+  `types: [opened, synchronize, reopened, edited]` — the extra `edited` so a title/body correction
+  re-runs the pattern gates without a close/reopen (a plain re-run replays the frozen original payload).
+  The commit-range jobs carry `if: github.event.action != 'edited'` so a bare body/title edit only
+  re-runs `pr-title`/`pr-template`, not the whole suite. The pattern jobs
   read the title/body from the event payload: `pr-title` takes `${{ github.event.pull_request.title }}`
   and `pr-template` writes `${{ github.event.pull_request.body }}` to a temp file. All `--profile code`.
   The Phase 6 thread gates (`lineage-check`, `epic-open`, `reconcile-debt`) run as their own jobs with

package/skills/yad-checks/templates/github/yad-checks.yml

@@ -6,11 +6,16 @@
 name: yad-checks
 on:
   pull_request:
+    # `edited` (beyond the opened/synchronize/reopened defaults) so a PR title/body correction
+    # re-runs the pattern gates without a close/reopen — e.g. fixing a body the pr-template gate held.
+    # The commit-range jobs below skip a bare `edited` (only pr-title/pr-template need to re-check).
+    types: [opened, synchronize, reopened, edited]
     branches: ["**"]
 
 jobs:
   spec-link:
     runs-on: ubuntu-latest
+    if: github.event.action != 'edited'
     steps:
       - uses: actions/checkout@v4
         with: { fetch-depth: 0 }
@@ -18,6 +23,7 @@ jobs:
 
   contract-check:
     runs-on: ubuntu-latest
+    if: github.event.action != 'edited'
     steps:
       - uses: actions/checkout@v4
         with: { fetch-depth: 0 }
@@ -25,6 +31,7 @@ jobs:
 
   build-test-lint:
     runs-on: ubuntu-latest
+    if: github.event.action != 'edited'
     env:
       YAD_TEST_MAX_WORKERS: "2" # cap jest/vitest test workers in CI; ignored by other runners
     steps:
@@ -41,6 +48,7 @@ jobs:
   # story->epic resolution and degrade to a note when the product repo is not reachable from CI.
   lineage-check:
     runs-on: ubuntu-latest
+    if: github.event.action != 'edited'
     steps:
       - uses: actions/checkout@v4
         with: { fetch-depth: 0 }
@@ -48,6 +56,7 @@ jobs:
 
   epic-open:
     runs-on: ubuntu-latest
+    if: github.event.action != 'edited'
     steps:
       - uses: actions/checkout@v4
         with: { fetch-depth: 0 }
@@ -55,14 +64,17 @@ jobs:
 
   reconcile-debt:
     runs-on: ubuntu-latest
+    if: github.event.action != 'edited'
     steps:
       - uses: actions/checkout@v4
         with: { fetch-depth: 0 }
       - run: bash checks/reconcile-debt-check.sh "origin/${{ github.base_ref }}"
 
   # Pattern gates: commit subject + PR title + PR body all follow the convention (profile: code).
+  # commit-message reads the commit range, not the title/body — skip it on a bare `edited` event.
   commit-message:
     runs-on: ubuntu-latest
+    if: github.event.action != 'edited'
     steps:
       - uses: actions/checkout@v4
         with: { fetch-depth: 0 }
@@ -88,8 +100,10 @@ jobs:
           bash checks/pr-template.sh --profile code "$body"
 
   # No unverified commits from unverified users: platform-Verified signature + allowlisted author.
+  # Reads the commit range, not the title/body — skip it on a bare `edited` event.
   verified-commits:
     runs-on: ubuntu-latest
+    if: github.event.action != 'edited'
     permissions:
       contents: read
     env:

package/skills/yad-connect-repos/references/code-context.md

@@ -82,7 +82,13 @@ side-effect:** when a repo is stale (HEAD ≠ `syncedHead`), the phase **flags i
 silently re-packing the whole repo. A phase never refreshes the registry on its own; the human runs
 `yad repo refresh` (or `yad check --fix`). After the AI regenerates the code-map, `yad repo refresh
 --push` publishes the refreshed code-maps + registry to the hub's default branch as a `chore(hub): sync
-code-context … [skip ci]` audit commit (never `pack.md`; `--allow-branch` overrides the branch guard).
+code-context … [skip ci]` audit commit (never the pack's content; `--allow-branch` overrides the branch
+guard). The `pack.md` is gitignored — `yad repo refresh`/`yad setup` scaffold
+`.sdlc/code-context/*/pack.md` into the hub `.gitignore` (so a regenerated pack never dirties the tree),
+and a hub that tracked the pack *before* that ignore existed is self-healed: `--push` untracks it and
+lands the removal + the managed `.gitignore` line in the same audit commit. The commit is a scoped
+`git commit -- <paths>` — it never sweeps unrelated staged work, and an unrelated hand-edit to
+`.gitignore` is left for the human to commit rather than riding the `[skip ci]` audit commit.
 
 ## Why this stays DRY with backfill