xytara 3.1.13 → 3.1.15

package/scripts/verify_mpp_adapter.js

@@ -1,128 +1,128 @@
-"use strict";
-
-// Verifies the MPP (Stripe per-call) adapter (lib/mpp_adapter.js). Offline: the
-// Stripe GET is injected as a mock. Exercises config gating, header parsing, and
-// the paid/amount/reference verification logic.
-
-const assert = require("assert");
-const m = require("../lib/mpp_adapter");
-
-function setEnv(env) {
-  const saved = {};
-  for (const k in env) {
-    saved[k] = process.env[k];
-    if (env[k] === undefined) delete process.env[k];
-    else process.env[k] = env[k];
-  }
-  return () => {
-    for (const k in saved) {
-      if (saved[k] === undefined) delete process.env[k];
-      else process.env[k] = saved[k];
-    }
-  };
-}
-
-async function main() {
-  // 1. Not configured.
-  let restore = setEnv({ XYTARA_MPP_PROVIDER: undefined });
-  let cfg = m.loadMppConfig();
-  assert.strictEqual(cfg.provider, null);
-  assert.strictEqual((await m.verifyMppPayment(cfg, "pi_x", 100)).reason, "mpp_provider_not_configured");
-  restore();
-
-  // 2. Configured (stripe).
-  restore = setEnv({ XYTARA_MPP_PROVIDER: "stripe", STRIPE_SECRET_KEY: "sk_test_x" });
-  cfg = m.loadMppConfig();
-  assert.strictEqual(cfg.provider, "stripe");
-
-  // Header parsing.
-  assert.deepStrictEqual(m.parseMppHeader("SPT pi_abc123"), { reference: "pi_abc123" });
-  assert.deepStrictEqual(m.parseMppHeader("SPT cs_abc123"), { reference: "cs_abc123" });
-  assert.strictEqual(m.parseMppHeader("SPT not_a_ref"), null);
-  assert.strictEqual(m.parseMppHeader("Bearer x"), null);
-
-  // PaymentIntent succeeded + sufficient amount -> ok.
-  let r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 200, json: { status: "succeeded", amount_received: 500, currency: "usd" } }));
-  assert.strictEqual(r.ok, true);
-  assert.strictEqual(r.amount_minor, 500);
-
-  // PaymentIntent not succeeded -> not paid.
-  r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 200, json: { status: "requires_payment_method", amount: 500 } }));
-  assert.strictEqual(r.reason, "mpp_not_paid");
-
-  // Insufficient amount -> rejected.
-  r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 200, json: { status: "succeeded", amount_received: 200 } }));
-  assert.strictEqual(r.reason, "mpp_amount_insufficient");
-
-  // Checkout session paid -> ok.
-  r = await m.verifyMppPayment(cfg, "cs_1", 500, async () => ({ status: 200, json: { payment_status: "paid", amount_total: 900, currency: "usd" } }));
-  assert.strictEqual(r.ok, true);
-  assert.strictEqual(r.amount_minor, 900);
-
-  // Required amount unknown/zero -> never authorize for free.
-  r = await m.verifyMppPayment(cfg, "pi_1", 0, async () => ({ status: 200, json: { status: "succeeded", amount_received: 500, currency: "usd" } }));
-  assert.strictEqual(r.reason, "mpp_required_amount_unknown");
-
-  // Wrong currency -> rejected even if nominal amount is high.
-  r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 200, json: { status: "succeeded", amount_received: 500, currency: "jpy" } }));
-  assert.strictEqual(r.reason, "mpp_currency_mismatch");
-
-  // --- Request binding (production-safe) ---
-  const quoteA = { quote_id: "quote_aaa", amount_minor: 500, currency: "USD_CENTS" };
-  const quoteB = { quote_id: "quote_bbb", amount_minor: 500, currency: "USD_CENTS" };
-  const refA = m.computeBindingRef(cfg.bindingSecret, quoteA);
-  const refB = m.computeBindingRef(cfg.bindingSecret, quoteB);
-  assert.ok(refA.startsWith("nx_"), "binding ref is namespaced");
-  assert.strictEqual(refA, m.computeBindingRef(cfg.bindingSecret, quoteA), "binding ref is deterministic");
-  assert.notStrictEqual(refA, refB, "binding ref differs per quote");
-
-  // Paid object carrying the matching ref -> ok.
-  r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 200, json: { status: "succeeded", amount_received: 500, currency: "usd", metadata: { naxytra_ref: refA } } }), { expectedRef: refA });
-  assert.strictEqual(r.ok, true, "matching binding ref authorizes");
-
-  // Paid object with NO ref when one is expected -> rejected (cannot replay an unrelated payment).
-  r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 200, json: { status: "succeeded", amount_received: 500, currency: "usd", metadata: {} } }), { expectedRef: refA });
-  assert.strictEqual(r.reason, "mpp_binding_ref_missing");
-
-  // Paid object bound to a DIFFERENT quote -> rejected.
-  r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 200, json: { status: "succeeded", amount_received: 500, currency: "usd", metadata: { naxytra_ref: refB } } }), { expectedRef: refA });
-  assert.strictEqual(r.reason, "mpp_binding_ref_mismatch");
-
-  // --- Server-side PaymentIntent creation (stamps the binding ref) ---
-  let captured = null;
-  const created = await m.createMppPaymentIntent(cfg, { amountMinor: 500, currency: "usd", ref: refA, quoteId: quoteA.quote_id }, async (path, form) => {
-    captured = { path, form };
-    return { status: 200, json: { id: "pi_created", client_secret: "pi_created_secret_x" } };
-  });
-  assert.strictEqual(created.ok, true);
-  assert.strictEqual(created.reference, "pi_created");
-  assert.strictEqual(created.client_secret, "pi_created_secret_x");
-  assert.strictEqual(captured.path, "/v1/payment_intents");
-  assert.strictEqual(captured.form.amount, "500");
-  assert.strictEqual(captured.form.currency, "usd");
-  assert.strictEqual(captured.form["metadata[naxytra_ref]"], refA);
-
-  // PI creation rejects a non-positive amount before any network call.
-  const badCreate = await m.createMppPaymentIntent(cfg, { amountMinor: 0, ref: refA }, async () => ({ status: 200, json: {} }));
-  assert.strictEqual(badCreate.reason, "invalid_amount");
-
-  // Invalid reference (not pi_/cs_) -> rejected before fetch.
-  r = await m.verifyMppPayment(cfg, "xyz", 500);
-  assert.strictEqual(r.reason, "mpp_reference_invalid");
-
-  // Stripe 404 -> not found.
-  r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 404, json: { error: { message: "No such payment_intent" } } }));
-  assert.strictEqual(r.reason, "stripe_reference_not_found");
-
-  // Missing secret key -> explicit reason.
-  const noKey = Object.assign({}, cfg, { secretKey: "" });
-  assert.strictEqual((await m.verifyMppPayment(noKey, "pi_1", 500)).reason, "stripe_secret_key_missing");
-  restore();
-
-  console.log("verify_mpp_adapter: all MPP (Stripe per-call) adapter checks passed");
-}
-
-main().catch((error) => {
-  console.error("verify_mpp_adapter failed:", error && error.message ? error.message : error);
-  process.exitCode = 1;
-});
+"use strict";
+
+// Verifies the MPP (Stripe per-call) adapter (lib/mpp_adapter.js). Offline: the
+// Stripe GET is injected as a mock. Exercises config gating, header parsing, and
+// the paid/amount/reference verification logic.
+
+const assert = require("assert");
+const m = require("../lib/mpp_adapter");
+
+function setEnv(env) {
+  const saved = {};
+  for (const k in env) {
+    saved[k] = process.env[k];
+    if (env[k] === undefined) delete process.env[k];
+    else process.env[k] = env[k];
+  }
+  return () => {
+    for (const k in saved) {
+      if (saved[k] === undefined) delete process.env[k];
+      else process.env[k] = saved[k];
+    }
+  };
+}
+
+async function main() {
+  // 1. Not configured.
+  let restore = setEnv({ XYTARA_MPP_PROVIDER: undefined });
+  let cfg = m.loadMppConfig();
+  assert.strictEqual(cfg.provider, null);
+  assert.strictEqual((await m.verifyMppPayment(cfg, "pi_x", 100)).reason, "mpp_provider_not_configured");
+  restore();
+
+  // 2. Configured (stripe).
+  restore = setEnv({ XYTARA_MPP_PROVIDER: "stripe", STRIPE_SECRET_KEY: "sk_test_x" });
+  cfg = m.loadMppConfig();
+  assert.strictEqual(cfg.provider, "stripe");
+
+  // Header parsing.
+  assert.deepStrictEqual(m.parseMppHeader("SPT pi_abc123"), { reference: "pi_abc123" });
+  assert.deepStrictEqual(m.parseMppHeader("SPT cs_abc123"), { reference: "cs_abc123" });
+  assert.strictEqual(m.parseMppHeader("SPT not_a_ref"), null);
+  assert.strictEqual(m.parseMppHeader("Bearer x"), null);
+
+  // PaymentIntent succeeded + sufficient amount -> ok.
+  let r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 200, json: { status: "succeeded", amount_received: 500, currency: "usd" } }));
+  assert.strictEqual(r.ok, true);
+  assert.strictEqual(r.amount_minor, 500);
+
+  // PaymentIntent not succeeded -> not paid.
+  r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 200, json: { status: "requires_payment_method", amount: 500 } }));
+  assert.strictEqual(r.reason, "mpp_not_paid");
+
+  // Insufficient amount -> rejected.
+  r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 200, json: { status: "succeeded", amount_received: 200 } }));
+  assert.strictEqual(r.reason, "mpp_amount_insufficient");
+
+  // Checkout session paid -> ok.
+  r = await m.verifyMppPayment(cfg, "cs_1", 500, async () => ({ status: 200, json: { payment_status: "paid", amount_total: 900, currency: "usd" } }));
+  assert.strictEqual(r.ok, true);
+  assert.strictEqual(r.amount_minor, 900);
+
+  // Required amount unknown/zero -> never authorize for free.
+  r = await m.verifyMppPayment(cfg, "pi_1", 0, async () => ({ status: 200, json: { status: "succeeded", amount_received: 500, currency: "usd" } }));
+  assert.strictEqual(r.reason, "mpp_required_amount_unknown");
+
+  // Wrong currency -> rejected even if nominal amount is high.
+  r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 200, json: { status: "succeeded", amount_received: 500, currency: "jpy" } }));
+  assert.strictEqual(r.reason, "mpp_currency_mismatch");
+
+  // --- Request binding (production-safe) ---
+  const quoteA = { quote_id: "quote_aaa", amount_minor: 500, currency: "USD_CENTS" };
+  const quoteB = { quote_id: "quote_bbb", amount_minor: 500, currency: "USD_CENTS" };
+  const refA = m.computeBindingRef(cfg.bindingSecret, quoteA);
+  const refB = m.computeBindingRef(cfg.bindingSecret, quoteB);
+  assert.ok(refA.startsWith("nx_"), "binding ref is namespaced");
+  assert.strictEqual(refA, m.computeBindingRef(cfg.bindingSecret, quoteA), "binding ref is deterministic");
+  assert.notStrictEqual(refA, refB, "binding ref differs per quote");
+
+  // Paid object carrying the matching ref -> ok.
+  r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 200, json: { status: "succeeded", amount_received: 500, currency: "usd", metadata: { naxytra_ref: refA } } }), { expectedRef: refA });
+  assert.strictEqual(r.ok, true, "matching binding ref authorizes");
+
+  // Paid object with NO ref when one is expected -> rejected (cannot replay an unrelated payment).
+  r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 200, json: { status: "succeeded", amount_received: 500, currency: "usd", metadata: {} } }), { expectedRef: refA });
+  assert.strictEqual(r.reason, "mpp_binding_ref_missing");
+
+  // Paid object bound to a DIFFERENT quote -> rejected.
+  r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 200, json: { status: "succeeded", amount_received: 500, currency: "usd", metadata: { naxytra_ref: refB } } }), { expectedRef: refA });
+  assert.strictEqual(r.reason, "mpp_binding_ref_mismatch");
+
+  // --- Server-side PaymentIntent creation (stamps the binding ref) ---
+  let captured = null;
+  const created = await m.createMppPaymentIntent(cfg, { amountMinor: 500, currency: "usd", ref: refA, quoteId: quoteA.quote_id }, async (path, form) => {
+    captured = { path, form };
+    return { status: 200, json: { id: "pi_created", client_secret: "pi_created_secret_x" } };
+  });
+  assert.strictEqual(created.ok, true);
+  assert.strictEqual(created.reference, "pi_created");
+  assert.strictEqual(created.client_secret, "pi_created_secret_x");
+  assert.strictEqual(captured.path, "/v1/payment_intents");
+  assert.strictEqual(captured.form.amount, "500");
+  assert.strictEqual(captured.form.currency, "usd");
+  assert.strictEqual(captured.form["metadata[naxytra_ref]"], refA);
+
+  // PI creation rejects a non-positive amount before any network call.
+  const badCreate = await m.createMppPaymentIntent(cfg, { amountMinor: 0, ref: refA }, async () => ({ status: 200, json: {} }));
+  assert.strictEqual(badCreate.reason, "invalid_amount");
+
+  // Invalid reference (not pi_/cs_) -> rejected before fetch.
+  r = await m.verifyMppPayment(cfg, "xyz", 500);
+  assert.strictEqual(r.reason, "mpp_reference_invalid");
+
+  // Stripe 404 -> not found.
+  r = await m.verifyMppPayment(cfg, "pi_1", 500, async () => ({ status: 404, json: { error: { message: "No such payment_intent" } } }));
+  assert.strictEqual(r.reason, "stripe_reference_not_found");
+
+  // Missing secret key -> explicit reason.
+  const noKey = Object.assign({}, cfg, { secretKey: "" });
+  assert.strictEqual((await m.verifyMppPayment(noKey, "pi_1", 500)).reason, "stripe_secret_key_missing");
+  restore();
+
+  console.log("verify_mpp_adapter: all MPP (Stripe per-call) adapter checks passed");
+}
+
+main().catch((error) => {
+  console.error("verify_mpp_adapter failed:", error && error.message ? error.message : error);
+  process.exitCode = 1;
+});