xtrm-tools 2.3.0 → 2.4.0

package/project-skills/tdd-guard/src/config/Config.test.ts

@@ -1,538 +0,0 @@
-import { describe, test, expect, beforeEach, afterEach } from 'vitest'
-import {
-  Config,
-  DEFAULT_MODEL_VERSION,
-  DEFAULT_CLIENT,
-  DEFAULT_DATA_DIR,
-} from './Config'
-import { ClientType } from '../contracts/types/ClientType'
-import path from 'path'
-
-describe('Config', () => {
-  const originalEnv = process.env
-
-  beforeEach(() => {
-    process.env = { ...originalEnv }
-  })
-
-  afterEach(() => {
-    process.env = originalEnv
-  })
-
-  describe('dataDir', () => {
-    const projectRoot = '/test/project'
-    const projectDataDir = path.join(projectRoot, DEFAULT_DATA_DIR)
-    let config: Config
-
-    beforeEach(() => {
-      config = new Config({ projectRoot })
-    })
-
-    test('defaults to relative path when no projectRoot provided', () => {
-      const defaultConfig = new Config()
-      expect(defaultConfig.dataDir).toBe(DEFAULT_DATA_DIR)
-    })
-
-    test('uses projectRoot to construct absolute dataDir', () => {
-      expect(config.dataDir).toBe(projectDataDir)
-    })
-
-    test('testResultsFilePath returns test.json path within dataDir', () => {
-      expect(config.testResultsFilePath).toBe(
-        path.join(projectDataDir, 'test.json')
-      )
-    })
-
-    test('todosFilePath returns todos.json path within dataDir', () => {
-      expect(config.todosFilePath).toBe(path.join(projectDataDir, 'todos.json'))
-    })
-
-    test('modificationsFilePath returns modifications.json path within dataDir', () => {
-      expect(config.modificationsFilePath).toBe(
-        path.join(projectDataDir, 'modifications.json')
-      )
-    })
-
-    test('lintFilePath returns lint.json path within dataDir', () => {
-      expect(config.lintFilePath).toBe(path.join(projectDataDir, 'lint.json'))
-    })
-
-    test('configFilePath returns config.json path within dataDir', () => {
-      expect(config.configFilePath).toBe(
-        path.join(projectDataDir, 'config.json')
-      )
-    })
-
-    test('instructionsFilePath returns instructions.md path within dataDir', () => {
-      expect(config.instructionsFilePath).toBe(
-        path.join(projectDataDir, 'instructions.md')
-      )
-    })
-
-    describe('CLAUDE_PROJECT_DIR', () => {
-      let originalCwd: typeof process.cwd
-
-      beforeEach(() => {
-        originalCwd = process.cwd
-      })
-
-      afterEach(() => {
-        process.cwd = originalCwd
-        delete process.env.CLAUDE_PROJECT_DIR
-      })
-
-      test('uses CLAUDE_PROJECT_DIR when available and no projectRoot provided', () => {
-        const claudeProjectDir = '/claude/project/root'
-        process.env.CLAUDE_PROJECT_DIR = claudeProjectDir
-        process.cwd = () => '/claude/project/root/src'
-
-        const configWithClaudeDir = new Config()
-
-        expect(configWithClaudeDir.dataDir).toBe(
-          path.join(claudeProjectDir, DEFAULT_DATA_DIR)
-        )
-      })
-
-      test('projectRoot option takes precedence over CLAUDE_PROJECT_DIR', () => {
-        const claudeProjectDir = '/claude/project/root'
-        const explicitProjectRoot = '/explicit/project/root'
-        process.env.CLAUDE_PROJECT_DIR = claudeProjectDir
-
-        const configWithBoth = new Config({ projectRoot: explicitProjectRoot })
-
-        expect(configWithBoth.dataDir).toBe(
-          path.join(explicitProjectRoot, DEFAULT_DATA_DIR)
-        )
-      })
-
-      test('throws error when CLAUDE_PROJECT_DIR is not an absolute path', () => {
-        process.env.CLAUDE_PROJECT_DIR = 'relative/path'
-
-        expect(() => new Config()).toThrow(
-          'CLAUDE_PROJECT_DIR must be an absolute path'
-        )
-      })
-
-      test('throws error when cwd is outside CLAUDE_PROJECT_DIR', () => {
-        process.env.CLAUDE_PROJECT_DIR = '/project/root'
-        process.cwd = () => '/some/other/path'
-
-        expect(() => new Config()).toThrow(
-          'CLAUDE_PROJECT_DIR must contain the current working directory'
-        )
-      })
-
-      test('uses CLAUDE_PROJECT_DIR when cwd is deeply nested within it', () => {
-        process.env.CLAUDE_PROJECT_DIR = '/project/root'
-        process.cwd = () => '/project/root/src/nested/deeply'
-
-        const configWithNestedCwd = new Config()
-
-        expect(configWithNestedCwd.dataDir).toBe(
-          '/project/root/.claude/tdd-guard/data'
-        )
-      })
-
-      test('throws error when CLAUDE_PROJECT_DIR contains path traversal', () => {
-        process.env.CLAUDE_PROJECT_DIR = '/some/path/../../../other'
-        process.cwd = () => '/other/location'
-
-        expect(() => new Config()).toThrow(
-          'CLAUDE_PROJECT_DIR must not contain path traversal'
-        )
-      })
-    })
-  })
-
-  describe('useSystemClaude', () => {
-    test('can be set via options', () => {
-      const config = new Config({ useSystemClaude: true })
-
-      expect(config.useSystemClaude).toBe(true)
-    })
-
-    test('options take precedence over env var', () => {
-      process.env.USE_SYSTEM_CLAUDE = 'false'
-
-      const config = new Config({ useSystemClaude: true })
-
-      expect(config.useSystemClaude).toBe(true)
-    })
-
-    test('falls back to env var when not in options', () => {
-      process.env.USE_SYSTEM_CLAUDE = 'true'
-
-      const config = new Config({})
-
-      expect(config.useSystemClaude).toBe(true)
-    })
-
-    test('defaults to false when neither options nor env var are set', () => {
-      delete process.env.USE_SYSTEM_CLAUDE
-
-      const config = new Config()
-
-      expect(config.useSystemClaude).toBe(false)
-    })
-
-    test('returns false for non-true env values', () => {
-      // Test with 'false'
-      process.env.USE_SYSTEM_CLAUDE = 'false'
-      let config = new Config()
-      expect(config.useSystemClaude).toBe(false)
-
-      // Test with empty string
-      process.env.USE_SYSTEM_CLAUDE = ''
-      config = new Config()
-      expect(config.useSystemClaude).toBe(false)
-    })
-  })
-
-  describe('anthropicApiKey', () => {
-    test('can be set via options', () => {
-      const config = new Config({ anthropicApiKey: 'options-api-key' })
-
-      expect(config.anthropicApiKey).toBe('options-api-key')
-    })
-
-    test('options take precedence over env var', () => {
-      process.env.TDD_GUARD_ANTHROPIC_API_KEY = 'env-api-key'
-
-      const config = new Config({ anthropicApiKey: 'options-api-key' })
-
-      expect(config.anthropicApiKey).toBe('options-api-key')
-    })
-
-    test('falls back to env var when not in options', () => {
-      process.env.TDD_GUARD_ANTHROPIC_API_KEY = 'env-api-key'
-
-      const config = new Config()
-
-      expect(config.anthropicApiKey).toBe('env-api-key')
-    })
-
-    test('returns undefined when neither options nor env var are set', () => {
-      delete process.env.TDD_GUARD_ANTHROPIC_API_KEY
-
-      const config = new Config()
-
-      expect(config.anthropicApiKey).toBeUndefined()
-    })
-  })
-
-  describe('modelType', () => {
-    test('can be set via options', () => {
-      const config = new Config({ modelType: 'anthropic_api' })
-
-      expect(config.modelType).toBe('anthropic_api')
-    })
-
-    test('options take precedence over env vars', () => {
-      process.env.MODEL_TYPE = 'claude_cli'
-
-      const config = new Config({ modelType: 'anthropic_api' })
-
-      expect(config.modelType).toBe('anthropic_api')
-    })
-
-    test('options take precedence even in test mode with TEST_MODEL_TYPE', () => {
-      process.env.MODEL_TYPE = 'claude_cli'
-      process.env.TEST_MODEL_TYPE = 'test_model'
-
-      const config = new Config({ mode: 'test', modelType: 'anthropic_api' })
-
-      expect(config.modelType).toBe('anthropic_api')
-    })
-
-    test('falls back to MODEL_TYPE env var in production mode', () => {
-      process.env.MODEL_TYPE = 'anthropic_api'
-
-      const config = new Config()
-
-      expect(config.modelType).toBe('anthropic_api')
-    })
-
-    test('uses TEST_MODEL_TYPE in test mode when available', () => {
-      process.env.MODEL_TYPE = 'claude_cli'
-      process.env.TEST_MODEL_TYPE = 'anthropic_api'
-
-      const config = new Config({ mode: 'test' })
-
-      expect(config.modelType).toBe('anthropic_api')
-    })
-
-    test('falls back to MODEL_TYPE in test mode when TEST_MODEL_TYPE is not set', () => {
-      process.env.MODEL_TYPE = 'anthropic_api'
-      delete process.env.TEST_MODEL_TYPE
-
-      const config = new Config({ mode: 'test' })
-
-      expect(config.modelType).toBe('anthropic_api')
-    })
-
-    test('defaults to claude_cli when no env vars are set', () => {
-      delete process.env.MODEL_TYPE
-      delete process.env.TEST_MODEL_TYPE
-
-      const config = new Config()
-
-      expect(config.modelType).toBe('claude_cli')
-    })
-  })
-
-  describe('validationClient', () => {
-    test.each<ClientType>(['sdk', 'cli', 'api'])(
-      'returns %s when VALIDATION_CLIENT env var is set to %s',
-      (value) => {
-        process.env.VALIDATION_CLIENT = value
-
-        const config = new Config()
-
-        expect(config.validationClient).toBe(value)
-      }
-    )
-
-    describe('options.validationClient precedence', () => {
-      test.each([
-        { env: 'VALIDATION_CLIENT', envValue: 'cli', optionValue: 'api' },
-        { env: 'VALIDATION_CLIENT', envValue: 'sdk', optionValue: 'cli' },
-        { env: 'MODEL_TYPE', envValue: 'anthropic_api', optionValue: 'sdk' },
-        { env: 'MODEL_TYPE', envValue: 'claude_cli', optionValue: 'api' },
-      ])(
-        'takes precedence over $env=$envValue (returns $optionValue)',
-        ({ env, envValue, optionValue }) => {
-          process.env[env] = envValue
-
-          const config = new Config({
-            validationClient: optionValue as 'api' | 'cli' | 'sdk',
-          })
-
-          expect(config.validationClient).toBe(optionValue)
-        }
-      )
-    })
-
-    describe('case normalization', () => {
-      describe('VALIDATION_CLIENT', () => {
-        const testCases = [
-          ['API', 'api'],
-          ['Api', 'api'],
-          ['api', 'api'],
-          ['CLI', 'cli'],
-          ['Cli', 'cli'],
-          ['cli', 'cli'],
-          ['SDK', 'sdk'],
-          ['Sdk', 'sdk'],
-          ['sdk', 'sdk'],
-        ]
-
-        test.each(testCases)(
-          'normalizes env var %s to %s',
-          (input, expected) => {
-            process.env.VALIDATION_CLIENT = input
-
-            const config = new Config()
-
-            expect(config.validationClient).toBe(expected)
-          }
-        )
-
-        test.each(testCases)(
-          'normalizes option %s to %s',
-          (input, expected) => {
-            const config = new Config({
-              validationClient: input as ClientType,
-            })
-
-            expect(config.validationClient).toBe(expected)
-          }
-        )
-      })
-
-      describe('MODEL_TYPE (legacy)', () => {
-        const modelTypeCases = [
-          ['ANTHROPIC_API', 'api'],
-          ['Anthropic_Api', 'api'],
-          ['anthropic_api', 'api'],
-          ['CLAUDE_CLI', 'cli'],
-          ['Claude_Cli', 'cli'],
-          ['claude_cli', 'cli'],
-        ]
-
-        test.each(modelTypeCases)(
-          'normalizes env var %s to %s when VALIDATION_CLIENT not set',
-          (modelType, expectedClient) => {
-            delete process.env.VALIDATION_CLIENT
-            process.env.MODEL_TYPE = modelType
-
-            const config = new Config()
-
-            expect(config.validationClient).toBe(expectedClient)
-          }
-        )
-
-        test.each(modelTypeCases)(
-          'normalizes option %s to %s when validationClient not set',
-          (modelType, expectedClient) => {
-            delete process.env.VALIDATION_CLIENT
-            delete process.env.MODEL_TYPE
-
-            const config = new Config({ modelType })
-
-            expect(config.validationClient).toBe(expectedClient)
-          }
-        )
-      })
-    })
-
-    test.each([
-      ['anthropic_api', 'api'],
-      ['claude_cli', 'cli'],
-    ] as const)(
-      'uses %s from MODEL_TYPE=%s when VALIDATION_CLIENT not set',
-      (modelType, expectedClient) => {
-        delete process.env.VALIDATION_CLIENT
-        process.env.MODEL_TYPE = modelType
-
-        const config = new Config()
-
-        expect(config.validationClient).toBe(expectedClient)
-      }
-    )
-
-    test('uses api from options.modelType=anthropic_api when validationClient not set', () => {
-      delete process.env.VALIDATION_CLIENT
-      delete process.env.MODEL_TYPE
-
-      const config = new Config({ modelType: 'anthropic_api' })
-
-      expect(config.validationClient).toBe('api')
-    })
-
-    test('uses cli from options.modelType=claude_cli when validationClient not set', () => {
-      delete process.env.VALIDATION_CLIENT
-      delete process.env.MODEL_TYPE
-
-      const config = new Config({ modelType: 'claude_cli' })
-
-      expect(config.validationClient).toBe('cli')
-    })
-
-    test('uses DEFAULT_CLIENT when nothing is set', () => {
-      delete process.env.VALIDATION_CLIENT
-      delete process.env.MODEL_TYPE
-
-      const config = new Config()
-
-      expect(config.validationClient).toBe(DEFAULT_CLIENT)
-    })
-  })
-
-  describe('modelVersion', () => {
-    test('returns default model version when no configuration provided', () => {
-      const config = new Config()
-
-      expect(config.modelVersion).toBeDefined()
-      expect(config.modelVersion).toBe(DEFAULT_MODEL_VERSION)
-    })
-
-    test('can be set via options', () => {
-      const config = new Config({ modelVersion: 'claude-opus-4-1' })
-
-      expect(config.modelVersion).toBe('claude-opus-4-1')
-    })
-
-    test('options take precedence over env var', () => {
-      process.env.TDD_GUARD_MODEL_VERSION = 'claude-haiku-3-0'
-
-      const config = new Config({ modelVersion: 'claude-opus-4-1' })
-
-      expect(config.modelVersion).toBe('claude-opus-4-1')
-    })
-
-    test('falls back to env var when not in options', () => {
-      process.env.TDD_GUARD_MODEL_VERSION = 'claude-haiku-3-0'
-
-      const config = new Config()
-
-      expect(config.modelVersion).toBe('claude-haiku-3-0')
-    })
-  })
-
-  describe('linterType', () => {
-    test('returns undefined when no configuration provided', () => {
-      delete process.env.LINTER_TYPE
-
-      const config = new Config()
-
-      expect(config.linterType).toBeUndefined()
-    })
-
-    test('returns eslint when LINTER_TYPE env var is set to eslint', () => {
-      process.env.LINTER_TYPE = 'eslint'
-
-      const config = new Config()
-
-      expect(config.linterType).toBe('eslint')
-    })
-
-    test('returns golangci-lint when LINTER_TYPE env var is set to golangci-lint', () => {
-      process.env.LINTER_TYPE = 'golangci-lint'
-
-      const config = new Config()
-
-      expect(config.linterType).toBe('golangci-lint')
-    })
-
-    test('returns value from ConfigOptions when linterType is provided', () => {
-      const config = new Config({ linterType: 'eslint' })
-
-      expect(config.linterType).toBe('eslint')
-    })
-
-    test('returns golangci-lint from ConfigOptions when provided', () => {
-      const config = new Config({ linterType: 'golangci-lint' })
-
-      expect(config.linterType).toBe('golangci-lint')
-    })
-
-    test('ConfigOptions takes precedence over env var', () => {
-      process.env.LINTER_TYPE = 'pylint'
-
-      const config = new Config({ linterType: 'eslint' })
-
-      expect(config.linterType).toBe('eslint')
-    })
-
-    test('returns undefined for empty string env var', () => {
-      process.env.LINTER_TYPE = ''
-
-      const config = new Config()
-
-      expect(config.linterType).toBeUndefined()
-    })
-
-    test('returns future linter types when configured', () => {
-      // Test that the system is extensible for future linter types
-      process.env.LINTER_TYPE = 'pylint'
-
-      const config = new Config()
-
-      expect(config.linterType).toBe('pylint')
-    })
-
-    test('returns linterType in lowercase when env var is uppercase', () => {
-      process.env.LINTER_TYPE = 'ESLINT'
-
-      const config = new Config()
-
-      expect(config.linterType).toBe('eslint')
-    })
-
-    test('returns linterType in lowercase when ConfigOptions is uppercase', () => {
-      const config = new Config({ linterType: 'ESLINT' })
-
-      expect(config.linterType).toBe('eslint')
-    })
-  })
-})

package/project-skills/tdd-guard/src/config/Config.ts

@@ -1,172 +0,0 @@
-import path from 'path'
-import { ConfigOptions } from '../contracts/types/ConfigOptions'
-import { ClientType } from '../contracts/types/ClientType'
-
-const TEST_RESULTS_FILENAME = 'test.json'
-const TODOS_FILENAME = 'todos.json'
-const MODIFICATIONS_FILENAME = 'modifications.json'
-const LINT_FILENAME = 'lint.json'
-const CONFIG_FILENAME = 'config.json'
-const INSTRUCTIONS_FILENAME = 'instructions.md'
-
-export const DEFAULT_MODEL_VERSION = 'claude-sonnet-4-0'
-export const DEFAULT_CLIENT: ClientType = 'sdk'
-export const DEFAULT_DATA_DIR = path.join('.claude', 'tdd-guard', 'data')
-
-const VALID_CLIENTS = new Set<string>(['api', 'cli', 'sdk'])
-const MODEL_TYPE_TO_CLIENT: Record<string, ClientType> = {
-  anthropic_api: 'api',
-  claude_cli: 'cli',
-}
-
-export class Config {
-  readonly dataDir: string
-  readonly useSystemClaude: boolean
-  readonly anthropicApiKey: string | undefined
-  readonly modelType: string
-  readonly linterType: string | undefined
-  readonly modelVersion: string
-  readonly validationClient: ClientType
-
-  constructor(options?: ConfigOptions) {
-    const mode = options?.mode ?? 'production'
-
-    this.dataDir = this.getDataDir(options)
-    this.useSystemClaude = this.getUseSystemClaude(options)
-    this.anthropicApiKey = this.getAnthropicApiKey(options)
-    this.modelType = this.getModelType(options, mode)
-    this.linterType = this.getLinterType(options)
-    this.modelVersion = this.getModelVersion(options)
-    this.validationClient = this.getValidationClient(options)
-  }
-
-  private getDataDir(options?: ConfigOptions): string {
-    // Determine the base directory
-    const baseDir = options?.projectRoot ?? this.getValidatedClaudeProjectDir()
-
-    // If we have a base directory, construct the full path
-    if (baseDir) {
-      return path.join(baseDir, DEFAULT_DATA_DIR)
-    }
-
-    // Default to relative path
-    return DEFAULT_DATA_DIR
-  }
-
-  private getUseSystemClaude(options?: ConfigOptions): boolean {
-    return options?.useSystemClaude ?? process.env.USE_SYSTEM_CLAUDE === 'true'
-  }
-
-  private getAnthropicApiKey(options?: ConfigOptions): string | undefined {
-    return options?.anthropicApiKey ?? process.env.TDD_GUARD_ANTHROPIC_API_KEY
-  }
-
-  private getModelType(
-    options: ConfigOptions | undefined,
-    mode: string
-  ): string {
-    return (
-      options?.modelType ?? this.getEnvironmentModelType(mode) ?? 'claude_cli'
-    )
-  }
-
-  private getEnvironmentModelType(mode: string): string | undefined {
-    if (mode === 'test' && process.env.TEST_MODEL_TYPE) {
-      return process.env.TEST_MODEL_TYPE
-    }
-    return process.env.MODEL_TYPE
-  }
-
-  get testResultsFilePath(): string {
-    return path.join(this.dataDir, TEST_RESULTS_FILENAME)
-  }
-
-  get todosFilePath(): string {
-    return path.join(this.dataDir, TODOS_FILENAME)
-  }
-
-  get modificationsFilePath(): string {
-    return path.join(this.dataDir, MODIFICATIONS_FILENAME)
-  }
-
-  get lintFilePath(): string {
-    return path.join(this.dataDir, LINT_FILENAME)
-  }
-
-  get configFilePath(): string {
-    return path.join(this.dataDir, CONFIG_FILENAME)
-  }
-
-  get instructionsFilePath(): string {
-    return path.join(this.dataDir, INSTRUCTIONS_FILENAME)
-  }
-
-  private getLinterType(options?: ConfigOptions): string | undefined {
-    if (options && 'linterType' in options) {
-      return options.linterType?.toLowerCase()
-    }
-    const envValue = process.env.LINTER_TYPE?.toLowerCase()
-    return envValue && envValue.trim() !== '' ? envValue : undefined
-  }
-
-  private getModelVersion(options?: ConfigOptions): string {
-    return (
-      options?.modelVersion ??
-      process.env.TDD_GUARD_MODEL_VERSION ??
-      DEFAULT_MODEL_VERSION
-    )
-  }
-
-  private getValidationClient(options?: ConfigOptions): ClientType {
-    return (
-      getClientType(options) ?? getLegacyClientType(options) ?? DEFAULT_CLIENT
-    )
-  }
-
-  private getValidatedClaudeProjectDir(): string | null {
-    const projectDir = process.env.CLAUDE_PROJECT_DIR
-    if (!projectDir) {
-      return null
-    }
-
-    // Validate that CLAUDE_PROJECT_DIR is an absolute path
-    if (!path.isAbsolute(projectDir)) {
-      throw new Error('CLAUDE_PROJECT_DIR must be an absolute path')
-    }
-
-    // Validate that CLAUDE_PROJECT_DIR does not contain path traversal
-    if (projectDir.includes('..')) {
-      throw new Error('CLAUDE_PROJECT_DIR must not contain path traversal')
-    }
-
-    // Validate that current working directory is within CLAUDE_PROJECT_DIR
-    const cwd = process.cwd()
-    if (!cwd.startsWith(projectDir)) {
-      throw new Error(
-        'CLAUDE_PROJECT_DIR must contain the current working directory'
-      )
-    }
-
-    return projectDir
-  }
-}
-
-function getClientType(options?: ConfigOptions): ClientType | undefined {
-  const directValue = options?.validationClient ?? process.env.VALIDATION_CLIENT
-  const normalizedValue = directValue?.toLowerCase()
-  return isValidClient(normalizedValue) ? normalizedValue : undefined
-}
-
-function getLegacyClientType(options?: ConfigOptions): ClientType | undefined {
-  const modelType = options?.modelType ?? process.env.MODEL_TYPE
-  return mapModelTypeToClient(modelType)
-}
-
-function isValidClient(value?: string): value is ClientType {
-  return VALID_CLIENTS.has(value ?? '')
-}
-
-function mapModelTypeToClient(modelType?: string): ClientType | undefined {
-  const normalizedType = modelType?.toLowerCase()
-  return normalizedType ? MODEL_TYPE_TO_CLIENT[normalizedType] : undefined
-}