xrpl 3.0.0-beta.0 → 3.0.0

package/src/utils/index.ts

@@ -14,7 +14,13 @@ import {
   isValidXAddress,
   xAddressToClassicAddress,
 } from 'ripple-address-codec'
-import * as rbc from 'ripple-binary-codec'
+import {
+  encode as rbcEncode,
+  decode as rbcDecode,
+  encodeForMultisigning as rbcEncodeForMultisigning,
+  encodeForSigning as rbcEncodeForSigning,
+  encodeForSigningClaim as rbcEncodeForSigningClaim,
+} from 'ripple-binary-codec'
 import { verify as verifyKeypairSignature } from 'ripple-keypairs'
 
 import { LedgerEntry } from '../models/ledger'
@@ -83,7 +89,7 @@ function isValidSecret(secret: string): boolean {
  * @returns A hex string representing the encoded object.
  */
 function encode(object: Transaction | LedgerEntry): string {
-  return rbc.encode(object)
+  return rbcEncode(object)
 }
 
 /**
@@ -93,7 +99,7 @@ function encode(object: Transaction | LedgerEntry): string {
  * @returns A hex string representing the encoded object.
  */
 function encodeForSigning(object: Transaction): string {
-  return rbc.encodeForSigning(object)
+  return rbcEncodeForSigning(object)
 }
 
 /**
@@ -103,7 +109,7 @@ function encodeForSigning(object: Transaction): string {
  * @returns A hex string representing the encoded object.
  */
 function encodeForSigningClaim(object: PaymentChannelClaim): string {
-  return rbc.encodeForSigningClaim(object)
+  return rbcEncodeForSigningClaim(object)
 }
 
 /**
@@ -114,7 +120,7 @@ function encodeForSigningClaim(object: PaymentChannelClaim): string {
  * @returns A hex string representing the encoded object.
  */
 function encodeForMultiSigning(object: Transaction, signer: string): string {
-  return rbc.encodeForMultisigning(object, signer)
+  return rbcEncodeForMultisigning(object, signer)
 }
 
 /**
@@ -124,7 +130,7 @@ function encodeForMultiSigning(object: Transaction, signer: string): string {
  * @returns The hex string decoded according to XRPL serialization format.
  */
 function decode(hex: string): Record<string, unknown> {
-  return rbc.decode(hex)
+  return rbcDecode(hex)
 }
 
 /**

package/src/utils/parseNFTokenID.ts

@@ -1,4 +1,5 @@
 /* eslint-disable @typescript-eslint/no-magic-numbers -- Doing hex string parsing. */
+import { hexToBytes } from '@xrplf/isomorphic/utils'
 import BigNumber from 'bignumber.js'
 import { encodeAccountID } from 'ripple-address-codec'
 
@@ -24,7 +25,17 @@ import { XrplError } from '../errors'
  */
 function unscrambleTaxon(taxon: number, tokenSeq: number): number {
   /* eslint-disable no-bitwise -- XOR is part of the encode/decode scheme. */
-  return (taxon ^ (384160001 * tokenSeq + 2459)) % 4294967296
+  const seed = 384160001
+  const increment = 2459
+  const max = 4294967296
+
+  const scramble = new BigNumber(seed)
+    .multipliedBy(tokenSeq)
+    .modulo(max)
+    .plus(increment)
+    .modulo(max)
+    .toNumber()
+  return (taxon ^ scramble) >>> 0
   /* eslint-enable no-bitwise */
 }
 
@@ -75,7 +86,7 @@ export default function parseNFTokenID(nftokenID: string): {
     NFTokenID: nftokenID,
     Flags: new BigNumber(nftokenID.substring(0, 4), 16).toNumber(),
     TransferFee: new BigNumber(nftokenID.substring(4, 8), 16).toNumber(),
-    Issuer: encodeAccountID(Buffer.from(nftokenID.substring(8, 48), 'hex')),
+    Issuer: encodeAccountID(hexToBytes(nftokenID.substring(8, 48))),
     Taxon: unscrambleTaxon(scrambledTaxon, sequence),
     Sequence: sequence,
   }

package/src/utils/stringConversion.ts

@@ -1,12 +1,17 @@
+import { stringToHex, hexToString } from '@xrplf/isomorphic/utils'
+
 /**
  * Converts a string to its hex equivalent. Useful for Memos.
  *
  * @param string - The string to convert to Hex.
  * @returns The Hex equivalent of the string.
+ *
+ * @deprecated use `@xrplf/isomorphic/utils`'s `stringToHex`
+ *
  * @category Utilities
  */
 function convertStringToHex(string: string): string {
-  return Buffer.from(string, 'utf8').toString('hex').toUpperCase()
+  return stringToHex(string)
 }
 
 /**
@@ -15,13 +20,13 @@ function convertStringToHex(string: string): string {
  * @param hex - The hex to convert to a string.
  * @param encoding - The encoding to use. Defaults to 'utf8' (UTF-8). 'ascii' is also allowed.
  * @returns The converted string.
+ *
+ * @deprecated use `@xrplf/isomorphic/utils`'s `hexToString`
+ *
  * @category Utilities
  */
-function convertHexToString(
-  hex: string,
-  encoding: BufferEncoding = 'utf8',
-): string {
-  return Buffer.from(hex, 'hex').toString(encoding)
+function convertHexToString(hex: string, encoding = 'utf8'): string {
+  return hexToString(hex, encoding)
 }
 
 export { convertHexToString, convertStringToHex }

package/src/utils/xrpConversion.ts

@@ -15,7 +15,7 @@ const SANITY_CHECK = /^-?[0-9.]+$/u
  * @throws When drops amount is invalid.
  * @category Utilities
  */
-export function dropsToXrp(dropsToConvert: BigNumber.Value): string {
+export function dropsToXrp(dropsToConvert: BigNumber.Value): number {
   /*
    * Converting to BigNumber and then back to string should remove any
    * decimal point followed by zeros, e.g. '1.00'.
@@ -50,7 +50,7 @@ export function dropsToXrp(dropsToConvert: BigNumber.Value): string {
     )
   }
 
-  return new BigNumber(drops).dividedBy(DROPS_PER_XRP).toString(BASE_TEN)
+  return new BigNumber(drops).dividedBy(DROPS_PER_XRP).toNumber()
 }
 
 /**