xo 0.51.0 → 0.52.2

package/node_modules/eslint-config-xo-typescript/index.js

@@ -174,6 +174,10 @@ module.exports = {
 			'error',
 			'getters'
 		],
+		'@typescript-eslint/consistent-generic-constructors': [
+			'error',
+			'constructor'
+		],
 		'@typescript-eslint/consistent-indexed-object-style': 'error',
 		'brace-style': 'off',
 		'@typescript-eslint/brace-style': [
@@ -207,12 +211,17 @@ module.exports = {
 				objectLiteralTypeAssertions: 'allow-as-parameter'
 			}
 		],
-
-		// This rule is fine. I just don't want to deal with the churn yet. Enable this in 2023.
-		// '@typescript-eslint/consistent-type-definitions': [
-		// 	'error',
-		// 	'type'
-		// ],
+		'@typescript-eslint/consistent-type-definitions': [
+			'error',
+			'type'
+		],
+		'@typescript-eslint/consistent-type-exports': [
+			'error',
+			{
+				fixMixedExportsWithInlineTypeSpecifier: true
+			}
+		],
+		'@typescript-eslint/consistent-type-imports': 'error',
 
 		// Disabled because it's too annoying. Enable it when it's more mature, smarter, and more flexible.
 		// https://github.com/typescript-eslint/typescript-eslint/search?q=%22explicit-function-return-type%22&state=open&type=Issues
@@ -359,9 +368,6 @@ module.exports = {
 		'@typescript-eslint/no-array-constructor': 'error',
 		'no-dupe-class-members': 'off',
 		'@typescript-eslint/no-dupe-class-members': 'error',
-		'no-duplicate-imports': 'off',
-		'import/no-duplicates': 'off',
-		'@typescript-eslint/no-duplicate-imports': 'error',
 		'@typescript-eslint/no-confusing-void-expression': 'error',
 		'@typescript-eslint/no-duplicate-enum-values': 'error',
 		'@typescript-eslint/no-dynamic-delete': 'error',
@@ -565,7 +571,14 @@ module.exports = {
 		'@typescript-eslint/prefer-includes': 'error',
 		'@typescript-eslint/prefer-literal-enum-member': 'error',
 		'@typescript-eslint/prefer-namespace-keyword': 'error',
-		'@typescript-eslint/prefer-nullish-coalescing': 'error',
+		'@typescript-eslint/prefer-nullish-coalescing': [
+			'error',
+			{
+				ignoreTernaryTests: false,
+				ignoreConditionalTests: false,
+				ignoreMixedLogicalExpressions: false
+			}
+		],
 		'@typescript-eslint/prefer-optional-chain': 'error',
 		'@typescript-eslint/prefer-readonly': 'error',
 
@@ -687,7 +700,10 @@ module.exports = {
 		'unicorn/no-null': 'off',
 
 		// The rule is buggy with TS and it's not needed as TS already enforces valid imports and references at compile-time.
-		'import/namespace': 'off'
+		'import/namespace': 'off',
+
+		// `import/no-duplicates` works better with TypeScript.
+		'no-duplicate-imports': 'off'
 	},
 	overrides: [
 		{

package/node_modules/eslint-config-xo-typescript/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-config-xo-typescript",
-	"version": "0.51.1",
+	"version": "0.53.0",
 	"description": "ESLint shareable config for TypeScript to be used with eslint-config-xo",
 	"license": "MIT",
 	"repository": "xojs/eslint-config-xo-typescript",
@@ -44,14 +44,15 @@
 		"simple"
 	],
 	"devDependencies": {
-		"@typescript-eslint/eslint-plugin": "^5.22.0",
-		"@typescript-eslint/parser": "^5.22.0",
+		"@typescript-eslint/eslint-plugin": "^5.31.0",
+		"@typescript-eslint/parser": "^5.31.0",
 		"ava": "^2.4.0",
 		"eslint": "^7.8.1",
 		"typescript": ">=4.4"
 	},
 	"peerDependencies": {
-		"@typescript-eslint/eslint-plugin": ">=5.22.0",
+		"@typescript-eslint/eslint-plugin": ">=5.31.0",
+		"@typescript-eslint/parser": ">=5.31.0",
 		"eslint": ">=8.0.0",
 		"typescript": ">=4.4"
 	}

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "xo",
-	"version": "0.51.0",
+	"version": "0.52.2",
 	"description": "JavaScript/TypeScript linter (ESLint wrapper) with great defaults",
 	"license": "MIT",
 	"repository": "xojs/xo",
@@ -59,25 +59,25 @@
 	],
 	"dependencies": {
 		"@eslint/eslintrc": "^1.3.0",
-		"@typescript-eslint/eslint-plugin": "^5.27.1",
-		"@typescript-eslint/parser": "^5.27.1",
+		"@typescript-eslint/eslint-plugin": "^5.35.1",
+		"@typescript-eslint/parser": "^5.35.1",
 		"arrify": "^3.0.0",
 		"cosmiconfig": "^7.0.1",
 		"define-lazy-prop": "^3.0.0",
-		"eslint": "^8.17.0",
+		"eslint": "^8.22.0",
 		"eslint-config-prettier": "^8.5.0",
-		"eslint-config-xo": "^0.41.0",
-		"eslint-config-xo-typescript": "^0.51.1",
+		"eslint-config-xo": "^0.42.0",
+		"eslint-config-xo-typescript": "^0.53.0",
 		"eslint-formatter-pretty": "^4.1.0",
 		"eslint-import-resolver-webpack": "^0.13.2",
 		"eslint-plugin-ava": "^13.2.0",
 		"eslint-plugin-eslint-comments": "^3.2.0",
 		"eslint-plugin-import": "^2.26.0",
-		"eslint-plugin-n": "^15.2.2",
+		"eslint-plugin-n": "^15.2.5",
 		"eslint-plugin-no-use-extend-native": "^0.5.0",
 		"eslint-plugin-prettier": "^4.0.0",
 		"eslint-plugin-unicorn": "^42.0.0",
-		"esm-utils": "^4.0.0",
+		"esm-utils": "^4.1.0",
 		"find-cache-dir": "^3.3.2",
 		"find-up": "^6.3.0",
 		"get-stdin": "^9.0.0",
@@ -98,13 +98,13 @@
 	"devDependencies": {
 		"ava": "^4.3.0",
 		"eslint-config-xo-react": "^0.27.0",
-		"eslint-plugin-react": "^7.30.0",
+		"eslint-plugin-react": "^7.31.0",
 		"eslint-plugin-react-hooks": "^4.5.0",
 		"execa": "^6.1.0",
 		"nyc": "^15.1.0",
 		"proxyquire": "^2.1.3",
 		"temp-write": "^5.0.0",
-		"webpack": "^5.73.0"
+		"webpack": "^5.74.0"
 	},
 	"xo": {
 		"ignores": [

package/node_modules/@typescript-eslint/parser/_ts3.4/dist/index.d.ts

@@ -1,4 +0,0 @@
-export { parse, parseForESLint, ParserOptions } from './parser';
-export { ParserServices, clearCaches, createProgram, } from '@typescript-eslint/typescript-estree';
-export declare const version: string;
-//# sourceMappingURL=index.d.ts.map

package/node_modules/@typescript-eslint/parser/_ts3.4/dist/parser.d.ts

@@ -1,20 +0,0 @@
-import { ParserOptions, TSESTree } from '@typescript-eslint/types';
-import { ParserServices, visitorKeys } from '@typescript-eslint/typescript-estree';
-import { ScopeManager } from '@typescript-eslint/scope-manager';
-interface ParseForESLintResult {
-    ast: TSESTree.Program & {
-        range?: [
-            number,
-            number
-        ];
-        tokens?: TSESTree.Token[];
-        comments?: TSESTree.Comment[];
-    };
-    services: ParserServices;
-    visitorKeys: typeof visitorKeys;
-    scopeManager: ScopeManager;
-}
-declare function parse(code: string, options?: ParserOptions): ParseForESLintResult['ast'];
-declare function parseForESLint(code: string, options?: ParserOptions | null): ParseForESLintResult;
-export { parse, parseForESLint, ParserOptions };
-//# sourceMappingURL=parser.d.ts.map

package/node_modules/@typescript-eslint/type-utils/_ts3.4/dist/containsAllTypesByName.d.ts

@@ -1,8 +0,0 @@
-import * as ts from 'typescript';
-/**
- * @param type Type being checked by name.
- * @param allowedNames Symbol names checking on the type.
- * @returns Whether the type is, extends, or contains all of the allowed names.
- */
-export declare function containsAllTypesByName(type: ts.Type, allowAny: boolean, allowedNames: Set<string>): boolean;
-//# sourceMappingURL=containsAllTypesByName.d.ts.map

package/node_modules/@typescript-eslint/type-utils/_ts3.4/dist/getConstrainedTypeAtLocation.d.ts

@@ -1,6 +0,0 @@
-import * as ts from 'typescript';
-/**
- * Resolves the given node's type. Will resolve to the type's generic constraint, if it has one.
- */
-export declare function getConstrainedTypeAtLocation(checker: ts.TypeChecker, node: ts.Node): ts.Type;
-//# sourceMappingURL=getConstrainedTypeAtLocation.d.ts.map

package/node_modules/@typescript-eslint/type-utils/_ts3.4/dist/getContextualType.d.ts

@@ -1,8 +0,0 @@
-import * as ts from 'typescript';
-/**
- * Returns the contextual type of a given node.
- * Contextual type is the type of the target the node is going into.
- * i.e. the type of a called function's parameter, or the defined type of a variable declaration
- */
-export declare function getContextualType(checker: ts.TypeChecker, node: ts.Expression): ts.Type | undefined;
-//# sourceMappingURL=getContextualType.d.ts.map

package/node_modules/@typescript-eslint/type-utils/_ts3.4/dist/getDeclaration.d.ts

@@ -1,6 +0,0 @@
-import * as ts from 'typescript';
-/**
- * Gets the declaration for the given variable
- */
-export declare function getDeclaration(checker: ts.TypeChecker, node: ts.Expression): ts.Declaration | null;
-//# sourceMappingURL=getDeclaration.d.ts.map

package/node_modules/@typescript-eslint/type-utils/_ts3.4/dist/getSourceFileOfNode.d.ts

@@ -1,6 +0,0 @@
-import * as ts from 'typescript';
-/**
- * Gets the source file for a given node
- */
-export declare function getSourceFileOfNode(node: ts.Node): ts.SourceFile;
-//# sourceMappingURL=getSourceFileOfNode.d.ts.map

package/node_modules/@typescript-eslint/type-utils/_ts3.4/dist/getTokenAtPosition.d.ts

@@ -1,3 +0,0 @@
-import * as ts from 'typescript';
-export declare function getTokenAtPosition(sourceFile: ts.SourceFile, position: number): ts.Node;
-//# sourceMappingURL=getTokenAtPosition.d.ts.map

package/node_modules/@typescript-eslint/type-utils/_ts3.4/dist/getTypeArguments.d.ts

@@ -1,3 +0,0 @@
-import * as ts from 'typescript';
-export declare function getTypeArguments(type: ts.TypeReference, checker: ts.TypeChecker): readonly ts.Type[];
-//# sourceMappingURL=getTypeArguments.d.ts.map

package/node_modules/@typescript-eslint/type-utils/_ts3.4/dist/getTypeName.d.ts

@@ -1,8 +0,0 @@
-import * as ts from 'typescript';
-/**
- * Get the type name of a given type.
- * @param typeChecker The context sensitive TypeScript TypeChecker.
- * @param type The type to get the name of.
- */
-export declare function getTypeName(typeChecker: ts.TypeChecker, type: ts.Type): string;
-//# sourceMappingURL=getTypeName.d.ts.map

package/node_modules/@typescript-eslint/type-utils/_ts3.4/dist/index.d.ts

@@ -1,15 +0,0 @@
-export * from './containsAllTypesByName';
-export * from './getConstrainedTypeAtLocation';
-export * from './getContextualType';
-export * from './getDeclaration';
-export * from './getSourceFileOfNode';
-export * from './getTokenAtPosition';
-export * from './getTypeArguments';
-export * from './getTypeName';
-export * from './isTypeReadonly';
-export * from './isUnsafeAssignment';
-export * from './predicates';
-export * from './propertyTypes';
-export * from './requiresQuoting';
-export * from './typeFlagUtils';
-//# sourceMappingURL=index.d.ts.map

package/node_modules/@typescript-eslint/type-utils/_ts3.4/dist/isTypeReadonly.d.ts

@@ -1,20 +0,0 @@
-import * as ts from 'typescript';
-export interface ReadonlynessOptions {
-    readonly treatMethodsAsReadonly?: boolean;
-}
-export declare const readonlynessOptionsSchema: {
-    type: string;
-    additionalProperties: boolean;
-    properties: {
-        treatMethodsAsReadonly: {
-            type: string;
-        };
-    };
-};
-export declare const readonlynessOptionsDefaults: ReadonlynessOptions;
-/**
- * Checks if the given type is readonly
- */
-declare function isTypeReadonly(checker: ts.TypeChecker, type: ts.Type, options?: ReadonlynessOptions): boolean;
-export { isTypeReadonly };
-//# sourceMappingURL=isTypeReadonly.d.ts.map

package/node_modules/@typescript-eslint/type-utils/_ts3.4/dist/isUnsafeAssignment.d.ts

@@ -1,17 +0,0 @@
-import { TSESTree } from '@typescript-eslint/utils';
-import * as ts from 'typescript';
-/**
- * Does a simple check to see if there is an any being assigned to a non-any type.
- *
- * This also checks generic positions to ensure there's no unsafe sub-assignments.
- * Note: in the case of generic positions, it makes the assumption that the two types are the same.
- *
- * @example See tests for examples
- *
- * @returns false if it's safe, or an object with the two types if it's unsafe
- */
-export declare function isUnsafeAssignment(type: ts.Type, receiver: ts.Type, checker: ts.TypeChecker, senderNode: TSESTree.Node | null): false | {
-    sender: ts.Type;
-    receiver: ts.Type;
-};
-//# sourceMappingURL=isUnsafeAssignment.d.ts.map

package/node_modules/@typescript-eslint/type-utils/_ts3.4/dist/predicates.d.ts

@@ -1,52 +0,0 @@
-import * as ts from 'typescript';
-/**
- * Checks if the given type is (or accepts) nullable
- * @param isReceiver true if the type is a receiving type (i.e. the type of a called function's parameter)
- */
-export declare function isNullableType(type: ts.Type, { isReceiver, allowUndefined, }?: {
-    isReceiver?: boolean;
-    allowUndefined?: boolean;
-}): boolean;
-/**
- * Checks if the given type is either an array type,
- * or a union made up solely of array types.
- */
-export declare function isTypeArrayTypeOrUnionOfArrayTypes(type: ts.Type, checker: ts.TypeChecker): boolean;
-/**
- * @returns true if the type is `never`
- */
-export declare function isTypeNeverType(type: ts.Type): boolean;
-/**
- * @returns true if the type is `unknown`
- */
-export declare function isTypeUnknownType(type: ts.Type): boolean;
-export declare function isTypeReferenceType(type: ts.Type): type is ts.TypeReference;
-/**
- * @returns true if the type is `any`
- */
-export declare function isTypeAnyType(type: ts.Type): boolean;
-/**
- * @returns true if the type is `any[]`
- */
-export declare function isTypeAnyArrayType(type: ts.Type, checker: ts.TypeChecker): boolean;
-/**
- * @returns true if the type is `unknown[]`
- */
-export declare function isTypeUnknownArrayType(type: ts.Type, checker: ts.TypeChecker): boolean;
-export declare enum AnyType {
-    Any = 0,
-    AnyArray = 1,
-    Safe = 2
-}
-/**
- * @returns `AnyType.Any` if the type is `any`, `AnyType.AnyArray` if the type is `any[]` or `readonly any[]`,
- *          otherwise it returns `AnyType.Safe`.
- */
-export declare function isAnyOrAnyArrayTypeDiscriminated(node: ts.Node, checker: ts.TypeChecker): AnyType;
-/**
- * @returns Whether a type is an instance of the parent type, including for the parent's base types.
- */
-export declare function typeIsOrHasBaseType(type: ts.Type, parentType: ts.Type): boolean;
-export declare function isTypeBigIntLiteralType(type: ts.Type): type is ts.BigIntLiteralType;
-export declare function isTypeTemplateLiteralType(type: ts.Type): type is ts.TemplateLiteralType;
-//# sourceMappingURL=predicates.d.ts.map

package/node_modules/@typescript-eslint/type-utils/_ts3.4/dist/propertyTypes.d.ts

@@ -1,4 +0,0 @@
-import * as ts from 'typescript';
-export declare function getTypeOfPropertyOfName(checker: ts.TypeChecker, type: ts.Type, name: string, escapedName?: ts.__String): ts.Type | undefined;
-export declare function getTypeOfPropertyOfType(checker: ts.TypeChecker, type: ts.Type, property: ts.Symbol): ts.Type | undefined;
-//# sourceMappingURL=propertyTypes.d.ts.map

package/node_modules/@typescript-eslint/type-utils/_ts3.4/dist/requiresQuoting.d.ts

@@ -1,4 +0,0 @@
-import * as ts from 'typescript';
-declare function requiresQuoting(name: string, target?: ts.ScriptTarget): boolean;
-export { requiresQuoting };
-//# sourceMappingURL=requiresQuoting.d.ts.map

package/node_modules/@typescript-eslint/type-utils/_ts3.4/dist/typeFlagUtils.d.ts

@@ -1,11 +0,0 @@
-import * as ts from 'typescript';
-/**
- * Gets all of the type flags in a type, iterating through unions automatically
- */
-export declare function getTypeFlags(type: ts.Type): ts.TypeFlags;
-/**
- * Checks if the given type is (or accepts) the given flags
- * @param isReceiver true if the type is a receiving type (i.e. the type of a called function's parameter)
- */
-export declare function isTypeFlagSet(type: ts.Type, flagsToCheck: ts.TypeFlags, isReceiver?: boolean): boolean;
-//# sourceMappingURL=typeFlagUtils.d.ts.map