xo 0.37.0 → 0.38.2

package/cli-main.js

@@ -116,6 +116,15 @@ updateNotifier({pkg: cli.pkg}).notify();
 
 const {input, flags: options, showVersion} = cli;
 
+// TODO: Fix this properly instead of the below workaround.
+// Revert behavior of meow >8 to pre-8 (7.1.1) for flags using `isMultiple: true`.
+// Otherwise, options defined in package.json can't be merged by lib/options-manager.js `mergeOptions()`.
+for (const key in options) {
+	if (Array.isArray(options[key]) && options[key].length === 0) {
+		delete options[key];
+	}
+}
+
 // Make data types for `options.space` match those of the API
 // Check for string type because `xo --no-space` sets `options.space` to `false`
 if (typeof options.space === 'string') {

package/config/plugins.js

@@ -152,12 +152,18 @@ module.exports = {
 			}
 		],
 
-		// TODO: Remove this when https://github.com/sindresorhus/eslint-plugin-unicorn/pull/977 is out.
-		'unicorn/import-index': 'off',
+		// TODO: Disabled for now until it becomes more stable: https://github.com/sindresorhus/eslint-plugin-unicorn/search?q=consistent-destructuring+is:issue&state=open&type=issues
+		'unicorn/consistent-destructuring': 'off',
 
 		// TODO: Disabled for now as I don't have time to deal with the backslash that might come from this. Try to enable this rule in 2021.
 		'unicorn/no-null': 'off',
 
+		// We only enforce it for single-line statements to not be too opinionated.
+		'unicorn/prefer-ternary': [
+			'error',
+			'only-single-line'
+		],
+
 		// TODO: Remove this override when the rule is more stable.
 		'unicorn/consistent-function-scoping': 'off',
 
@@ -184,7 +190,12 @@ module.exports = {
 			'error',
 			'always',
 			{
-				ignorePackages: true
+				ignorePackages: true,
+				// TypeScript doesn't yet support using extensions and fails with error TS2691.
+				pattern: {
+					ts: 'never',
+					tsx: 'never'
+				}
 			}
 		],
 
@@ -250,7 +261,9 @@ module.exports = {
 				allow: [
 					'@babel/polyfill',
 					'**/register',
+					'**/register.*',
 					'**/register/**',
+					'**/register/**.*',
 					'**/*.css',
 					'**/*.scss',
 					'**/*.sass',
@@ -268,6 +281,17 @@ module.exports = {
 		// 'node/no-missing-require': 'error',
 
 		'node/no-unpublished-bin': 'error',
+
+		// We have this enabled in addition to `import/extensions` as this one has an auto-fix.
+		'node/file-extension-in-import': [
+			'error',
+			'always',
+			{
+				// TypeScript doesn't yet support using extensions and fails with error TS2691.
+				'.ts': 'never',
+				'.tsx': 'never'
+			}
+		],
 		'node/no-mixed-requires': [
 			'error',
 			{

package/lib/constants.js

@@ -29,6 +29,8 @@ const TYPESCRIPT_EXTENSION = [
 const DEFAULT_EXTENSION = [
 	'js',
 	'jsx',
+	'mjs',
+	'cjs',
 	...TYPESCRIPT_EXTENSION
 ];
 

package/lib/options-manager.js

@@ -317,6 +317,7 @@ const buildXOConfig = options => config => {
 
 	if (options.ts) {
 		config.rules['unicorn/import-style'] = 'off';
+		config.rules['node/file-extension-in-import'] = 'off';
 	}
 
 	if (options.rules) {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "xo",
-	"version": "0.37.0",
+	"version": "0.38.2",
 	"description": "JavaScript/TypeScript linter with great defaults",
 	"license": "MIT",
 	"repository": "xojs/xo",
@@ -51,15 +51,15 @@
 		"typescript"
 	],
 	"dependencies": {
-		"@typescript-eslint/eslint-plugin": "^4.11.1",
-		"@typescript-eslint/parser": "^4.11.1",
+		"@typescript-eslint/eslint-plugin": "^4.15.1",
+		"@typescript-eslint/parser": "^4.15.1",
 		"arrify": "^2.0.1",
 		"cosmiconfig": "^7.0.0",
 		"debug": "^4.3.1",
-		"eslint": "^7.17.0",
-		"eslint-config-prettier": "^7.1.0",
-		"eslint-config-xo": "^0.34.0",
-		"eslint-config-xo-typescript": "^0.37.0",
+		"eslint": "^7.20.0",
+		"eslint-config-prettier": "^7.2.0",
+		"eslint-config-xo": "^0.35.0",
+		"eslint-config-xo-typescript": "^0.38.0",
 		"eslint-formatter-pretty": "^4.0.0",
 		"eslint-import-resolver-webpack": "^0.13.0",
 		"eslint-plugin-ava": "^11.0.0",
@@ -67,21 +67,21 @@
 		"eslint-plugin-import": "^2.22.1",
 		"eslint-plugin-no-use-extend-native": "^0.5.0",
 		"eslint-plugin-node": "^11.1.0",
-		"eslint-plugin-prettier": "^3.3.0",
-		"eslint-plugin-promise": "^4.2.1",
-		"eslint-plugin-unicorn": "^25.0.1",
+		"eslint-plugin-prettier": "^3.3.1",
+		"eslint-plugin-promise": "^4.3.1",
+		"eslint-plugin-unicorn": "^28.0.2",
 		"find-cache-dir": "^3.3.1",
 		"find-up": "^5.0.0",
-		"fs-extra": "^9.0.1",
+		"fs-extra": "^9.1.0",
 		"get-stdin": "^8.0.0",
 		"globby": "^9.2.0",
 		"has-flag": "^4.0.0",
 		"imurmurhash": "^0.1.4",
 		"is-path-inside": "^3.0.2",
 		"json-stable-stringify-without-jsonify": "^1.0.1",
-		"json5": "^2.1.3",
+		"json5": "^2.2.0",
 		"lodash": "^4.17.20",
-		"meow": "^8.1.0",
+		"meow": "^9.0.0",
 		"micromatch": "^4.0.2",
 		"open-editor": "^3.0.0",
 		"p-reduce": "^2.1.0",
@@ -92,8 +92,8 @@
 		"semver": "^7.3.4",
 		"slash": "^3.0.0",
 		"to-absolute-glob": "^2.0.2",
-		"typescript": "^4.1.3",
-		"update-notifier": "^5.0.1"
+		"typescript": "^4.1.5",
+		"update-notifier": "^5.1.0"
 	},
 	"devDependencies": {
 		"ava": "^3.15.0",
@@ -106,7 +106,7 @@
 		"pify": "^5.0.0",
 		"proxyquire": "^2.1.3",
 		"temp-write": "^4.0.0",
-		"webpack": "^5.11.1"
+		"webpack": "^5.23.0"
 	},
 	"eslintConfig": {
 		"extends": "eslint-config-xo",

package/readme.md

@@ -8,7 +8,7 @@
 
 > JavaScript/TypeScript linter with great defaults
 
-[![Coverage Status](https://codecov.io/gh/xojs/xo/branch/master/graph/badge.svg)](https://codecov.io/gh/xojs/xo/branch/master)
+[![Coverage Status](https://codecov.io/gh/xojs/xo/branch/main/graph/badge.svg)](https://codecov.io/gh/xojs/xo/branch/main)
 [![XO code style](https://img.shields.io/badge/code_style-XO-5ed9c7.svg)](https://github.com/xojs/xo)
 
 Opinionated but configurable ESLint wrapper with lots of goodies included. Enforces strict and readable code. Never discuss code style on a pull request again! No decision-making. No `.eslintrc` or `.jshintrc` to manage. It just works!
@@ -19,7 +19,7 @@ Uses [ESLint](https://eslint.org) underneath, so issues regarding rules should b
 
 *Vue components are not supported by default. You'll need [eslint-config-xo-vue](https://github.com/ChocPanda/eslint-config-xo-vue#use-with-xo) for specific linting in a Vue app.*
 
-![](https://raw.githubusercontent.com/sindresorhus/eslint-formatter-pretty/master/screenshot.png)
+![](https://raw.githubusercontent.com/sindresorhus/eslint-formatter-pretty/main/screenshot.png)
 
 ## Highlights
 
@@ -101,7 +101,7 @@ $ xo --help
 - Space after keyword `if (condition) {}`
 - Always `===` instead of `==`
 
-Check out an [example](index.js) and the [ESLint rules](https://github.com/xojs/eslint-config-xo/blob/master/index.js).
+Check out an [example](index.js) and the [ESLint rules](https://github.com/xojs/eslint-config-xo/blob/main/index.js).
 
 ## Workflow
 
@@ -193,7 +193,7 @@ This option exists for pragmatic reasons, but I would strongly recommend you rea
 
 Type: `object`
 
-Override any of the [default rules](https://github.com/xojs/eslint-config-xo/blob/master/index.js). See the [ESLint docs](https://eslint.org/docs/rules/) for more info on each rule.
+Override any of the [default rules](https://github.com/xojs/eslint-config-xo/blob/main/index.js). See the [ESLint docs](https://eslint.org/docs/rules/) for more info on each rule.
 
 Please take a moment to consider if you really need to use this option.
 
@@ -247,7 +247,7 @@ Use one or more [shareable configs](https://eslint.org/docs/developer-guide/shar
 
 Type: `string[]`
 
-Allow more extensions to be linted besides `.js` and `.jsx`. Make sure they're supported by ESLint or an ESLint plugin.
+Allow more extensions to be linted besides `.js`, `.jsx`, `.mjs`, and `.cjs`. Make sure they're supported by ESLint or an ESLint plugin.
 
 ### settings
 
@@ -303,6 +303,8 @@ See [eslint-config-xo-flow#use-with-xo](https://github.com/xojs/eslint-config-xo
 
 XO uses a different formatter when running in a GitHub Actions workflow to be able to get [inline annotations](https://developer.github.com/changes/2019-09-06-more-check-annotations-shown-in-files-changed-tab/). XO also disables warnings here.
 
+**Note**: For this to work, the [setup-node](https://github.com/actions/setup-node) action must be run before XO.
+
 ## Config Overrides
 
 XO makes it easy to override configs for specific files. The `overrides` property must be an array of override objects. Each override object must contain a `files` property which is a glob string, or an array of glob strings, relative to the config file. The remaining properties are identical to those described above, and will override the settings of the base config. If multiple override configs match the same file, each matching override is applied in the order it appears in the array. This means the last override in the array takes precedence over earlier ones. Consider the following example:
@@ -394,7 +396,7 @@ This way your `package.json` will contain the actual minimum Node.js version sup
 
 ### Including files ignored by default
 
-To include files that XO [ignores by default](https://github.com/xojs/xo/blob/master/lib/constants.js#L1), add them as negative globs in the `ignores` option:
+To include files that XO [ignores by default](lib/constants.js#L1), add them as negative globs in the `ignores` option:
 
 ```json
 {