xdrs-core 0.52.2 → 0.53.0

package/lib/lint.test.js

@@ -2245,22 +2245,35 @@ test('reports error when follows references a scope not in workspace', () => {
   const result = lintWorkspace(workspaceRoot, { ignoreExternal: false });
 
   expect(result.errors.join('\n')).toContain('follows references scope "nonexistent-core" which does not exist in the workspace');
-  expect(result.readOnlyScopes.has('myteam')).toBe(false);
 });
 
-test('marks scope read-only instead of erroring when follows references a missing scope for an external scope', () => {
-  const workspaceRoot = createWorkspace('follows-missing-scope-external', {
+test.each([[true], [false]])('does not report a missing follows target of an external scope (ignoreExternal=%s) [022.06]', (ignoreExternal) => {
+  const workspaceRoot = createWorkspace(`follows-missing-scope-external-${ignoreExternal}`, {
     '.xdrs/index.md': rootIndex(['[myteam](myteam/index.md)']),
     '.xdrs/myteam/index.md': '---\nscope-type: standard\nname: myteam\ndescription: Team.\napply-to: Test team\nvalid-from: 2026-01-01\nfollows: nonexistent-core\n---\n\n# myteam Scope Overview\n\n[ADRs](adrs/index.md)\n',
     '.xdrs/myteam/adrs/index.md': teamAdrIndex(['- [001-team](principles/001-team.md) - Team decision']),
     '.xdrs/myteam/adrs/principles/001-team.md': teamXdrDocument('Team decision.'),
-    '.filedist.lock': '.xdrs/myteam/adrs/principles/001-team.md|some-package|1.0.0\n',
+    '.filedist.lock': '.xdrs/myteam/index.md|some-package|1.0.0\n.xdrs/myteam/adrs/index.md|some-package|1.0.0\n.xdrs/myteam/adrs/principles/001-team.md|some-package|1.0.0\n',
+  });
+
+  const result = lintWorkspace(workspaceRoot, { ignoreExternal });
+
+  expect(result.errors.join('\n')).not.toContain('nonexistent-core');
+  expect(result.errors.join('\n')).not.toContain('022.06');
+});
+
+test('does not report a missing extends target of an external scope [022.06]', () => {
+  const workspaceRoot = createWorkspace('extends-missing-scope-external', {
+    '.xdrs/index.md': rootIndex(['[myteam](myteam/index.md)']),
+    '.xdrs/myteam/index.md': '---\nscope-type: standard\nname: myteam\ndescription: Team.\napply-to: Test team\nvalid-from: 2026-01-01\nextends: ghost-lib\n---\n\n# myteam Scope Overview\n\n[ADRs](adrs/index.md)\n',
+    '.xdrs/myteam/adrs/index.md': teamAdrIndex(['- [001-team](principles/001-team.md) - Team decision']),
+    '.xdrs/myteam/adrs/principles/001-team.md': teamXdrDocument('Team decision.'),
+    '.filedist.lock': '.xdrs/myteam/index.md|some-package|1.0.0\n',
   });
 
   const result = lintWorkspace(workspaceRoot, { ignoreExternal: false });
 
-  expect(result.errors.join('\n')).not.toContain('follows references scope "nonexistent-core" which does not exist in the workspace');
-  expect(result.readOnlyScopes.has('myteam')).toBe(true);
+  expect(result.errors.join('\n')).not.toContain('ghost-lib');
 });
 
 test('accepts follows scope that exists in workspace', () => {
@@ -2525,7 +2538,6 @@ test('does not warn when extends-referenced scope also appears in root index', (
   const result = lintWorkspace(workspaceRoot, { ignoreExternal: false });
 
   expect(result.errors.join('\n')).not.toContain('[_core-adr-policy-010.35-extends-index]');
-  expect(result.warnings.join('\n')).not.toContain('[_core-adr-policy-010.35-extends-index]');
   expect(result.errors.join('\n')).not.toContain('_core-adr-policy-022');
 });
 
@@ -5563,7 +5575,6 @@ function scopeFiles(name, extraFields = '', scopeType = 'standard') {
 }
 
 const activationErrors = (result) => result.errors.filter((e) => e.includes('_core-adr-policy-022')).join('\n');
-const activationWarnings = (result) => result.warnings.filter((e) => e.includes('_core-adr-policy-022')).join('\n');
 
 test('passes activation checks when only _core is installed and linked (smoke)', () => {
   const workspaceRoot = createWorkspace('activation-smoke', {
@@ -5572,7 +5583,7 @@ test('passes activation checks when only _core is installed and linked (smoke)',
   });
   const result = lintWorkspace(workspaceRoot, { ignoreExternal: false });
   expect(activationErrors(result)).toBe('');
-  expect(result.readOnlyScopes.size).toBe(0);
+  expect(Object.keys(result).sort()).toEqual(['errors', 'xdrsRoot']);
 });
 
 test('reports unlisted scope without type indexes with a paste-ready line [022.01]', () => {
@@ -5691,7 +5702,6 @@ test('accepts consumer narrowing: extends-only: false with an extends-only tag [
   });
   const result = lintWorkspace(workspaceRoot, { ignoreExternal: false });
   expect(activationErrors(result)).toBe('');
-  expect(activationWarnings(result)).toBe('');
 });
 
 test.each([['quoted', '"true"'], ['capitalised', 'True']])('reports %s extends-only value in a local scope [022.07]', (_label, value) => {
@@ -5703,7 +5713,7 @@ test.each([['quoted', '"true"'], ['capitalised', 'True']])('reports %s extends-o
   expect(activationErrors(result)).toContain('extends-only must be unquoted lowercase true or false');
 });
 
-test('marks external scope with invalid extends-only value read-only, treated as absent [022.06]', () => {
+test('does not report an invalid extends-only value in an external scope [022.07]', () => {
   const workspaceRoot = createWorkspace('activation-field-invalid-external', {
     '.xdrs/index.md': rootIndex(['[_core](_core/index.md)', '[View scope lib](lib/index.md)']),
     ...scopeFiles('lib', 'extends-only: yes\n'),
@@ -5711,7 +5721,6 @@ test('marks external scope with invalid extends-only value read-only, treated as
   });
   const result = lintWorkspace(workspaceRoot, { ignoreExternal: false });
   expect(activationErrors(result)).toBe('');
-  expect(result.readOnlyScopes.get('lib').join('\n')).toContain('invalid extends-only value "yes"');
 });
 
 test('reports extends-only on core-type and _local scopes [022.07]', () => {
@@ -5728,17 +5737,18 @@ test('reports extends-only on core-type and _local scopes [022.07]', () => {
   expect(errors).toContain('_local/index.md [_core-adr-policy-022.07-extends-only-field]');
 });
 
-test('warns when no active scope extends an extends-only scope [022.04]', () => {
+test('reports an error when no active scope extends an extends-only scope [022.04]', () => {
   const workspaceRoot = createWorkspace('activation-unused-extends-only', {
     '.xdrs/index.md': rootIndex(['[_core](_core/index.md)', '[View scope lib](lib/index.md) `extends-only`', ACTIVATION_LEGEND]),
     ...scopeFiles('lib'),
   });
   const result = lintWorkspace(workspaceRoot, { ignoreExternal: false });
-  expect(activationErrors(result)).toBe('');
-  expect(activationWarnings(result)).toContain('Scope "lib" is tagged `extends-only` but no active scope extends it');
+  expect(activationErrors(result)).toContain('Scope "lib" is tagged `extends-only` but no active scope extends it');
+  expect(activationErrors(result)).toContain('add it to the extends: of an active scope or tag it `disabled`');
+  expect(activationErrors(result)).toContain('[_core-adr-policy-022.04-extends-only]');
 });
 
-test('warns when an extends-only scope is reached only through a disabled scope [022.04]', () => {
+test('reports an extends-only scope reached only through a disabled scope, and the frozen extender [022.04, 022.06]', () => {
   const workspaceRoot = createWorkspace('activation-reach-through-disabled', {
     '.xdrs/index.md': rootIndex(['[_core](_core/index.md)', '[View scope lib](lib/index.md) `extends-only`', '[View scope mid](mid/index.md) `disabled`', '[View scope myteam](myteam/index.md)', ACTIVATION_LEGEND]),
     ...scopeFiles('lib'),
@@ -5746,11 +5756,11 @@ test('warns when an extends-only scope is reached only through a disabled scope
     ...scopeFiles('myteam', 'extends: mid\n'),
   });
   const result = lintWorkspace(workspaceRoot, { ignoreExternal: false });
-  expect(activationWarnings(result)).toContain('Scope "lib" is tagged `extends-only`');
-  expect(result.readOnlyScopes.get('myteam').join('\n')).toContain('extends: scope "mid" is tagged `disabled`');
+  expect(activationErrors(result)).toContain('Scope "lib" is tagged `extends-only`');
+  expect(activationErrors(result)).toContain('Local scope "myteam" is frozen (read-only) because extends: scope "mid" is tagged `disabled`');
 });
 
-test('makes a scope following a disabled scope read-only while it still reaches extends-only scopes [022.04, 022.06]', () => {
+test('reports a local scope following a disabled scope as frozen while it still reaches extends-only scopes [022.04, 022.06]', () => {
   const workspaceRoot = createWorkspace('activation-read-only-reaches', {
     '.xdrs/index.md': rootIndex(['[_core](_core/index.md)', '[View scope area-core](area-core/index.md) `disabled`', '[View scope lib](lib/index.md) `extends-only`', '[View scope myteam](myteam/index.md)', ACTIVATION_LEGEND]),
     ...scopeFiles('area-core', '', 'core'),
@@ -5758,22 +5768,24 @@ test('makes a scope following a disabled scope read-only while it still reaches
     ...scopeFiles('myteam', 'follows: area-core\nextends: lib\n'),
   });
   const result = lintWorkspace(workspaceRoot, { ignoreExternal: false });
-  expect(activationWarnings(result)).toBe('');
-  expect(result.readOnlyScopes.get('myteam').join('\n')).toContain('follows: scope "area-core" is tagged `disabled` in the root index; enable it or remove the follows: reference');
+  const errors = activationErrors(result);
+  expect(errors).not.toContain('022.04');
+  expect(errors).toContain('Local scope "myteam" is frozen (read-only) because follows: scope "area-core" is tagged `disabled` in the root index; enable it or remove the follows: reference: ');
+  expect(errors).toContain('myteam/index.md [_core-adr-policy-022.06-read-only-dependencies]');
 });
 
-test('makes an external scope extending a disabled scope read-only [022.06]', () => {
+test('does not report an external scope extending a disabled scope [022.06]', () => {
   const workspaceRoot = createWorkspace('activation-external-extends-disabled', {
     '.xdrs/index.md': rootIndex(['[_core](_core/index.md)', '[View scope lib](lib/index.md) `disabled`', '[View scope vendor](vendor/index.md)', ACTIVATION_LEGEND]),
     ...scopeFiles('lib'),
     ...scopeFiles('vendor', 'extends: lib\n'),
     '.filedist.lock': '.xdrs/vendor/index.md|some-package|1.0.0\n',
   });
-  const result = lintWorkspace(workspaceRoot);
-  expect(result.readOnlyScopes.has('vendor')).toBe(true);
+  expect(activationErrors(lintWorkspace(workspaceRoot))).toBe('');
+  expect(activationErrors(lintWorkspace(workspaceRoot, { ignoreExternal: false }))).toBe('');
 });
 
-test('makes _local extending a disabled scope read-only [022.06]', () => {
+test('reports _local extending a disabled scope as frozen [022.06]', () => {
   const workspaceRoot = createWorkspace('activation-local-extends-disabled', {
     '.xdrs/index.md': rootIndex(['[_core](_core/index.md)', '[View scope lib](lib/index.md) `disabled`', ACTIVATION_LEGEND]),
     ...scopeFiles('lib'),
@@ -5781,10 +5793,10 @@ test('makes _local extending a disabled scope read-only [022.06]', () => {
     ...coreWithScopeTypes(['standard', '_local']),
   });
   const result = lintWorkspace(workspaceRoot, { ignoreExternal: false });
-  expect(result.readOnlyScopes.has('_local')).toBe(true);
+  expect(activationErrors(result)).toContain('Local scope "_local" is frozen (read-only)');
 });
 
-test('makes a scope whose type is defined only in a disabled scope read-only [022.06]', () => {
+test('reports a local scope whose type is defined only in a disabled scope as frozen [022.06]', () => {
   const workspaceRoot = createWorkspace('activation-type-in-disabled-scope', {
     '.xdrs/index.md': rootIndex(['[_core](_core/index.md)', '[View scope widgets-core](widgets-core/index.md) `disabled`', '[View scope shop](shop/index.md)', ACTIVATION_LEGEND]),
     '.xdrs/widgets-core/index.md': scopeIndexWith('widgets-core', '', 'core'),
@@ -5795,10 +5807,22 @@ test('makes a scope whose type is defined only in a disabled scope read-only [02
   });
   const result = lintWorkspace(workspaceRoot, { ignoreExternal: false });
   expect(result.errors.join('\n')).not.toContain('has no corresponding widget-scope-type policy');
-  expect(result.readOnlyScopes.get('shop').join('\n')).toContain('scope type "widget" is defined only in disabled scope(s) "widgets-core"');
+  expect(activationErrors(result)).toContain('Local scope "shop" is frozen (read-only) because scope type "widget" is defined only in disabled scope(s) "widgets-core"');
+});
+
+test('reports missing dependencies of a disabled local scope as errors [022.05]', () => {
+  const workspaceRoot = createWorkspace('activation-disabled-local-missing-deps', {
+    '.xdrs/index.md': rootIndex(['[_core](_core/index.md)', '[View scope myteam](myteam/index.md) `disabled`', ACTIVATION_LEGEND]),
+    ...scopeFiles('myteam', 'follows: ghost-core\nextends: ghost-lib\n', 'phantom'),
+    ...coreWithScopeTypes(['standard']),
+  });
+  const errors = lintWorkspace(workspaceRoot, { ignoreExternal: false }).errors.join('\n');
+  expect(errors).toContain('follows references scope "ghost-core" which does not exist in the workspace');
+  expect(errors).toContain('ghost-lib');
+  expect(errors).toContain('phantom');
 });
 
-test('prints one read-only line per cause citing 022.06', () => {
+test('prints frozen local scopes as errors and never prints warning or READ-ONLY lines [022.06]', () => {
   const workspaceRoot = createWorkspace('activation-cli-read-only', {
     '.xdrs/index.md': rootIndex(['[View scope _core](_core/index.md)', '[View scope area-core](area-core/index.md) `disabled`', '[View scope lib](lib/index.md) `disabled`', '[View scope myteam](myteam/index.md)', ACTIVATION_LEGEND]),
     ...scopeFiles('area-core', '', 'core'),
@@ -5806,22 +5830,40 @@ test('prints one read-only line per cause citing 022.06', () => {
     ...scopeFiles('myteam', 'follows: area-core\nextends: lib\n'),
   });
   const { runLintCli } = require('./lint');
-  const logs = [];
-  const logSpy = jest.spyOn(console, 'log').mockImplementation((msg) => logs.push(msg));
-  const errSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
-  const warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => {});
+  const out = [];
+  const errOut = [];
+  const logSpy = jest.spyOn(console, 'log').mockImplementation((msg) => out.push(msg));
+  const errSpy = jest.spyOn(console, 'error').mockImplementation((msg) => errOut.push(msg));
+  const warnSpy = jest.spyOn(console, 'warn').mockImplementation((msg) => out.push(msg));
+  let code;
   try {
-    runLintCli(['--all', workspaceRoot]);
+    code = runLintCli(['--all', workspaceRoot]);
   } finally {
     logSpy.mockRestore();
     errSpy.mockRestore();
     warnSpy.mockRestore();
   }
-  const result = lintWorkspace(workspaceRoot, { ignoreExternal: false });
-  expect(result.readOnlyScopes.get('myteam')).toHaveLength(2);
-  const readOnlyLines = logs.filter((l) => l.includes('READ-ONLY scope "myteam"'));
-  expect(readOnlyLines).toHaveLength(2);
-  expect(readOnlyLines.every((l) => l.includes('[_core-adr-policy-022.06-read-only-dependencies]'))).toBe(true);
+  expect(code).toBe(1);
+  const frozenLines = errOut.filter((l) => l.includes('Local scope "myteam" is frozen (read-only)'));
+  expect(frozenLines).toHaveLength(2);
+  expect(frozenLines.every((l) => l.includes('[_core-adr-policy-022.06-read-only-dependencies]'))).toBe(true);
+  expect([...out, ...errOut].join('\n')).not.toMatch(/\[warning\]|READ-ONLY/);
+});
+
+test('silently skips freeze-reference exempt checks [002.01]', () => {
+  const frozen = (name) => teamXdrDocument('Frozen decision.')
+    .replace(/^---\n/, `---\nfreeze-reference: true\n`)
+    .replace(/^name: .*$/m, `name: ${name}`);
+  const workspaceRoot = createWorkspace('freeze-reference-silent', {
+    '.xdrs/index.md': rootIndex(['[_core](_core/index.md)', '[View scope myteam](myteam/index.md)']),
+    '.xdrs/myteam/index.md': scopeIndexWith('myteam'),
+    '.xdrs/myteam/adrs/index.md': teamAdrIndex(['- [850-frozen](principles/850-frozen.md) - Frozen']),
+    '.xdrs/myteam/adrs/principles/850-frozen.md': frozen('wrong-name'),
+  });
+  const errors = lintWorkspace(workspaceRoot, { ignoreExternal: false }).errors.join('\n');
+  expect(errors).not.toContain('017.05');
+  expect(errors).not.toContain('Policy frontmatter name must be');
+  expect(errors).not.toContain('Policy title must start with');
 });
 
 test('dry-run workspace: disabled core, extends-only ref, unlisted legacy scope', () => {
@@ -5834,10 +5876,10 @@ test('dry-run workspace: disabled core, extends-only ref, unlisted legacy scope'
   });
   const disabledIndexBefore = fs.readFileSync(path.join(workspaceRoot, '.xdrs/ecomm-core/index.md'), 'utf8');
   const result = lintWorkspace(workspaceRoot, { ignoreExternal: false });
-  expect(result.readOnlyScopes.get('checkout')).toHaveLength(1);
-  expect(activationWarnings(result)).toBe('');
-  expect(activationErrors(result)).toContain('[View scope legacy](legacy/index.md)');
-  expect(activationErrors(result).split('\n')).toHaveLength(1);
+  const errors = activationErrors(result).split('\n');
+  expect(errors).toHaveLength(2);
+  expect(errors.join('\n')).toContain('[View scope legacy](legacy/index.md)');
+  expect(errors.join('\n')).toContain('Local scope "checkout" is frozen (read-only) because follows: scope "ecomm-core" is tagged `disabled`');
   expect(fs.readFileSync(path.join(workspaceRoot, '.xdrs/ecomm-core/index.md'), 'utf8')).toBe(disabledIndexBefore);
 });
 
@@ -5872,7 +5914,7 @@ test('treats a type whose parent chain reaches core as core-type (naming, follow
   expect(errors).toContain('_core-adr-policy-010.12-def-core-scope-policies-must-be-structured');
 });
 
-test('reports missing scope-type for local scopes and marks external ones read-only [010.10, 022.06]', () => {
+test('reports missing scope-type for local scopes only [010.10, 022.06]', () => {
   const noType = (name) => `---\nname: ${name}\ndescription: Scope ${name}.\napply-to: Test teams\nvalid-from: 2026-01-01\n---\n\n# ${name}\n`;
   const workspaceRoot = createWorkspace('scope-type-missing-local-external', {
     '.xdrs/index.md': rootIndex(['[_core](_core/index.md)', '[View scope localone](localone/index.md)', '[View scope vendor](vendor/index.md)']),
@@ -5885,10 +5927,10 @@ test('reports missing scope-type for local scopes and marks external ones read-o
   const missingTypeErrors = result.errors.filter((e) => e.includes('must include a scope-type field'));
   expect(missingTypeErrors.join('\n')).toContain('localone/index.md');
   expect(missingTypeErrors.join('\n')).not.toContain('vendor/index.md');
-  expect(result.readOnlyScopes.get('vendor').join('\n')).toContain('no scope-type');
+  expect(result.errors.join('\n')).not.toContain('022.06');
 });
 
-test('reports missing parent type for local scopes and marks external ones read-only [010.09, 022.06]', () => {
+test('reports missing parent type for local scopes only [010.09, 022.06]', () => {
   const workspaceRoot = createWorkspace('scope-type-missing-parent', {
     '.xdrs/index.md': rootIndex(['[_core](_core/index.md)', '[View scope localone](localone/index.md)', '[View scope vendor](vendor/index.md)']),
     ...scopeFiles('localone', '', 'widget'),
@@ -5900,7 +5942,7 @@ test('reports missing parent type for local scopes and marks external ones read-
   const parentErrors = result.errors.filter((e) => e.includes('declares parent "ghost"'));
   expect(parentErrors).toHaveLength(1);
   expect(parentErrors[0]).toContain('localone/index.md');
-  expect(result.readOnlyScopes.get('vendor').join('\n')).toContain('scope type "ghost"');
+  expect(result.errors.join('\n')).not.toMatch(/vendor\/index\.md.*ghost/);
 });
 
 test('accepts compiled combined with a non-core type [011.10]', () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "xdrs-core",
-  "version": "0.52.2",
+  "version": "0.53.0",
   "description": "XDRS (eXtensible Decision Record System): a framework to structure, compile and distribute Architectural (ADR), Business (BDR), and Engineering (EDR) decision records contents so that AI agents and humans can reliably find and use them with hierarchical scopes and controlled rollout in the format of distributable versioned packages.",
   "repository": {
     "type": "git",