x402-surface-check 0.2.3 → 0.2.5

package/README.md

@@ -24,6 +24,7 @@ npx --yes x402-surface-check --endpoint --method POST https://x402.rpc.ankr.com/
 - HTTPS resource URLs and stable resource metadata
 - Browser CORS allowance for `X-PAYMENT`
 - Over-broad public method surfaces
+- Auth, validation, and free/trial responses that appear before a payment challenge, without piling on missing-field findings when no challenge was actually returned
 
 ## Options
 

package/bin/x402-surface-check.mjs

@@ -78,6 +78,7 @@ function parseArgs(argv) {
 }
 
 function moneyFromAtomic(amount, decimals = 6) {
+  if (amount === '' || amount === null || amount === undefined) return ''
   const numeric = Number(amount)
   if (!Number.isFinite(numeric)) return String(amount ?? '')
   const value = numeric / (10 ** decimals)
@@ -373,6 +374,11 @@ function challengeAccepts(result) {
   return Array.isArray(result.body.json?.accepts) ? result.body.json.accepts : []
 }
 
+function hasPaymentChallenge(result) {
+  const challenge = result.body.json
+  return challengeAccepts(result).length > 0 || Boolean(challenge?.resource || challenge?.payment || result.headers?.['www-authenticate'])
+}
+
 function challengeSummary(result) {
   const challenge = result.body.json
   const firstAccept = challenge?.accepts?.[0] ?? {}
@@ -427,10 +433,27 @@ function findingList(documentResult, challengeResults, preflightResults, entries
   for (const result of challengeResults) {
     const summary = challengeSummary(result)
     if (summary.network) challengeNetworks.add(summary.network)
+    const hasChallenge = hasPaymentChallenge(result)
 
     if (result.status !== 402) {
-      findings.push(`P1 - ${result.name} returned ${result.status}, not 402, for a no-payment ${result.method ?? 'POST'} probe.`)
+      if (result.status >= 200 && result.status < 300) {
+        findings.push(`P3 - ${result.name} returned ${result.status} without a payment challenge for a no-payment ${result.method ?? 'POST'} probe; document this as free/trial access or move the 402 challenge before content.`)
+      }
+      else if (result.status === 400 || result.status === 422) {
+        findings.push(`P1 - ${result.name} returned validation HTTP ${result.status} before a payment challenge for a no-payment ${result.method ?? 'POST'} probe.`)
+      }
+      else if (result.status === 401 || result.status === 403) {
+        findings.push(`P2 - ${result.name} returned auth HTTP ${result.status} before a payment challenge for a no-payment ${result.method ?? 'POST'} probe; document the auth/free-tier order if this is intentional.`)
+      }
+      else {
+        findings.push(`P1 - ${result.name} returned ${result.status}, not 402, for a no-payment ${result.method ?? 'POST'} probe.`)
+      }
     }
+
+    if (!hasChallenge) {
+      continue
+    }
+
     if (summary.resourceUrl.startsWith('http://') || summary.extraResource.startsWith('http://')) {
       findings.push(`P1 - ${result.name} challenge uses a non-HTTPS resource URL: ${summary.resourceUrl || summary.extraResource}.`)
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "x402-surface-check",
-  "version": "0.2.3",
+  "version": "0.2.5",
   "description": "No-payment x402 public-surface checker for manifests, OpenAPI specs, and HTTP 402 challenges.",
   "type": "module",
   "bin": {