x-fidelity 2.14.0 → 2.16.0

package/.xfi-config.json

@@ -0,0 +1,5 @@
+{
+    "sensitiveFileFalsePositives": [
+        "/README2.md"
+    ]
+}

package/CHANGELOG.md

@@ -1,3 +1,67 @@
+# [2.16.0](https://github.com/zotoio/x-fidelity/compare/v2.15.0...v2.16.0) (2024-09-10)
+
+
+### Bug Fixes
+
+* Add null checks for child.stdout and child.stderr in collectYarnDependencies function ([cd3f271](https://github.com/zotoio/x-fidelity/commit/cd3f2714ed20dbed7f13c559110cc6721a237380))
+* add type assertion to resolve TypeScript error ([aeb4c52](https://github.com/zotoio/x-fidelity/commit/aeb4c525c4a9e30a702ffcfb4b64f6a5a40a7bf3))
+* cast util.promisify to unknown before mocking ([f8c5069](https://github.com/zotoio/x-fidelity/commit/f8c5069757fcbcbb3e391262812713dd1f3522f2))
+* collect Yarn dependencies when yarn.lock exists ([48c50d1](https://github.com/zotoio/x-fidelity/commit/48c50d19d6d2ea422f41eab3b317e8e2071e11db))
+* Collect Yarn dependencies when yarn.lock exists ([2e159f0](https://github.com/zotoio/x-fidelity/commit/2e159f0aa93aad2097c2038a940c1f814a990de6))
+* Handle error types in dependency collection functions ([1711cb1](https://github.com/zotoio/x-fidelity/commit/1711cb153c07fcf8706e9a16431eda9ee4873f8e))
+* increase Jest timeout for repoDependencyFacts.test.ts ([05185d9](https://github.com/zotoio/x-fidelity/commit/05185d9664bc5e69abd78772c8781308360b4b59))
+* Mock child_process.exec to return a mock function ([ebba176](https://github.com/zotoio/x-fidelity/commit/ebba17659553f8f9e69fdc53b6cbdd1cab808412))
+* **promisechain:** avoid skipped files ([0cdf825](https://github.com/zotoio/x-fidelity/commit/0cdf825a100900ac545795fb24099778af656653))
+* Refactor runEngineOnFiles to use synchronous approach ([77c259e](https://github.com/zotoio/x-fidelity/commit/77c259ea3097b0fac50371acb2605285adc706c5))
+* resolve TypeScript error in repoDependencyFacts.test.ts ([075e884](https://github.com/zotoio/x-fidelity/commit/075e884f32547c4b2f1beed730675449c57b26aa))
+* resolve TypeScript error in repoDependencyFacts.test.ts ([6c4870e](https://github.com/zotoio/x-fidelity/commit/6c4870e766c18010566b474ff998d0eb084df364))
+* Resolve TypeScript errors in repoDependencyFacts.test.ts ([bd47c66](https://github.com/zotoio/x-fidelity/commit/bd47c66c44443b0f485dd83fa345411fb16c85a1))
+* update analyzer.test.ts to use expect.any(Number) for fileCount, totalIssues, and warningCount ([66bbd47](https://github.com/zotoio/x-fidelity/commit/66bbd47381694454a4016c5b6f610c4065c7c80e))
+* update minimum dependency version comparison ([3373646](https://github.com/zotoio/x-fidelity/commit/3373646a9d2ff52a545dad44241191a952705ce2))
+* Update mocking of util.promisify and fs.existsSync in repoDependencyFacts.test.ts ([fa81048](https://github.com/zotoio/x-fidelity/commit/fa81048ff7707c0def5a15d43ea34a36b202a725))
+* Update mocking of util.promisify in repoDependencyFacts.test.ts ([8e6a18d](https://github.com/zotoio/x-fidelity/commit/8e6a18d0cb31c049bd0b923f88b655d891dbe712))
+* Update repoDependencyFacts to fix test issues ([8d4bfc1](https://github.com/zotoio/x-fidelity/commit/8d4bfc1b9ef45ef64f9df33e2fe82ac0001d93bf))
+* Update runEngineOnFiles function to handle asynchronous engine.run() call ([01ec5b0](https://github.com/zotoio/x-fidelity/commit/01ec5b0ed7a662c615000860374bc94c50e499bc))
+* Update test expectations for `analyzeCodebase` ([524f0d3](https://github.com/zotoio/x-fidelity/commit/524f0d35e8d26a808189f5e5cbb6ce1b7c525244))
+* Update test expectations for error handling in analyzer ([a986892](https://github.com/zotoio/x-fidelity/commit/a986892cf19303458fa2096dfeb58a705de3f242))
+* Update test expectations for handling errors during analysis ([6a9c1b9](https://github.com/zotoio/x-fidelity/commit/6a9c1b9ac28696696c63d7e1a5c0a076856ac2d7))
+* update unit tests for loading npm and yarn dependencies ([4faf703](https://github.com/zotoio/x-fidelity/commit/4faf703aac483f8a75d81f38545a371d91bb31d3))
+* Use `exec` instead of `spawn` for collecting yarn dependencies ([b6bd17c](https://github.com/zotoio/x-fidelity/commit/b6bd17c74fee135b68a3d3fbb7ef6ee0750bf519))
+
+
+### Features
+
+* Replace execSync with spawned child process for dependency collection ([bd4b38e](https://github.com/zotoio/x-fidelity/commit/bd4b38e5f8dfb5b47c0fe2f07701ac38a16d78b2))
+* Update analyzer.test.ts with more precise expectations ([7376191](https://github.com/zotoio/x-fidelity/commit/7376191ecc18f0ac1367ad13b68e52c085c832c5))
+* update repoDependencyFacts tests to match implementation ([9514c3a](https://github.com/zotoio/x-fidelity/commit/9514c3a97e1c85bac7aa070c1efae8c0e5625073))
+
+# [2.15.0](https://github.com/zotoio/x-fidelity/compare/v2.14.0...v2.15.0) (2024-09-08)
+
+
+### Bug Fixes
+
+* **execution:** fact functions and cleanup ([8bd2cfa](https://github.com/zotoio/x-fidelity/commit/8bd2cfa8c4ea6a587fdf4259d34e14e09189fc27))
+* Implement more robust error handling and logging ([f391052](https://github.com/zotoio/x-fidelity/commit/f391052b1b3fe8f56bb29deffaf567b2a32ce3d7))
+* Implement safe handling of circular JSON references in repoDependencyFacts.ts ([49d95da](https://github.com/zotoio/x-fidelity/commit/49d95da03f4552de4533a0e86d37d4e168bd038e))
+* **loading:** consistency with archetype ([47f52e4](https://github.com/zotoio/x-fidelity/commit/47f52e477c1e2ca69c49af767e9af5c8b76a7979))
+* Update import statement in repoFilesystemFacts.ts ([903326c](https://github.com/zotoio/x-fidelity/commit/903326cb1dc33da38d5a9fcf7a45f01c4f1f4876))
+
+
+### Features
+
+* Add JSON schema validation for .xfi-config.json file ([a7d0a75](https://github.com/zotoio/x-fidelity/commit/a7d0a755abe18ae07f8c1ef938b0eb2239af968b))
+* Add rule to check for 'nuit' and 'elevate' package imports in the same file ([70d0994](https://github.com/zotoio/x-fidelity/commit/70d09947ff9149da22047a0d2f9dc62448de9fd0))
+* Add support for .xfi-config.json file ([e9b60d3](https://github.com/zotoio/x-fidelity/commit/e9b60d31ac1037d6f40505deff5126f18409c269))
+* Add support for .xfi-config.json file with sensitiveFileFalsePositives ([5eda4f4](https://github.com/zotoio/x-fidelity/commit/5eda4f4df4d5df048d6342e890825064e78b93e0))
+* Add XFIConfig to ResultMetadata and define FileData and ValidationResult types ([ce71d90](https://github.com/zotoio/x-fidelity/commit/ce71d903c5211d1101bf49080a0fc3978b4cdaf2))
+* Centralize loading of .xfi-config.json and add it as a fact ([2cca682](https://github.com/zotoio/x-fidelity/commit/2cca68203f2cd04d6802e25e3647455279d009a2))
+* create 'bats' subdirectory and move BATS-related content ([1cc0bff](https://github.com/zotoio/x-fidelity/commit/1cc0bff7fec4d0d1b4c7ea60dd8fef027bc689f2))
+* improve and modernize the bats test ([586b546](https://github.com/zotoio/x-fidelity/commit/586b546e50de46d5afe4e2dcde34af7fe65bbdb7))
+* Improve repoDependencyAnalysis function ([a5638ca](https://github.com/zotoio/x-fidelity/commit/a5638cad789bc52533862dd91b9a964da785c666))
+* Rename XFIConfig to RepoXFIConfig ([f91574d](https://github.com/zotoio/x-fidelity/commit/f91574d7c9ab4a1e64a9b2b8fb34fb84929a87bd))
+* **repoconfig:** support for local control of false positive sensitive values ([db0b09a](https://github.com/zotoio/x-fidelity/commit/db0b09ae08dea2cc82a26a6a671615033805396b))
+* **testing:** cli blackbox testing ([a634258](https://github.com/zotoio/x-fidelity/commit/a6342584a4a7cdfd630437fd9894a02039d0099d))
+
 # [2.14.0](https://github.com/zotoio/x-fidelity/compare/v2.13.1...v2.14.0) (2024-08-29)
 
 

package/README.md

@@ -39,15 +39,25 @@ x-fidelity is an advanced CLI tool and paired config server designed to perform
 3. [Components and entity names to understand](#components-and-entity-names-to-understand)
 4. [System Architecture](#system-architecture)
 5. [Configuring and Extending x-fidelity](#configuring-and-extending-x-fidelity)
+   - [Defining Archetypes](#defining-archetypes)
+   - [Defining rules](#defining-rules)
+   - [Included Operators](#included-operators)
 6. [Installation](#installation)
 7. [Usage](#usage)
+   - [Basic Usage](#basic-usage)
+   - [Advanced Usage](#advanced-usage)
+   - [Environment Variables](#environment-variables)
+   - [Local Configuration](#local-configuration)
+   - [Remote Configuration](#remote-configuration)
 8. [Hosting Config Servers](#hosting-config-servers)
+   - [Docker Example](#docker-example)
 9. [Exemptions](#exemptions)
 10. [CI Pipeline Integration](#ci-pipeline-integration)
 11. [OpenAI Integration](#openai-integration)
 12. [X-Fi Best Practices](#x-fi-best-practices)
-13. [Contributing](#contributing)
-14. [License](#license)
+13. [Using .xfi-config.json](#using-xfi-configjson)
+14. [Contributing](#contributing)
+15. [License](#license)
 
 ## Intent and Purpose
 
@@ -758,6 +768,43 @@ This structure allows you to create custom AI-powered rules that can analyze you
 7. **Performance**: Be mindful of the performance impact, especially for large codebases.
 8. **Centralized Management**: Use a config server to manage and distribute your archetypes and rules across projects.
 
+## Using .xfi-config.json
+
+The `.xfi-config.json` file allows you to configure x-fidelity behavior specific to your repository. This file should be placed in the root of your project directory.
+
+### Configuration Options
+
+Currently, the `.xfi-config.json` file supports the following options:
+
+1. `sensitiveFileFalsePositives`: An array of file paths that should be excluded from sensitive data checks.
+
+Example `.xfi-config.json`:
+
+```json
+{
+  "sensitiveFileFalsePositives": [
+    "path/to/exclude/file1.js",
+    "path/to/exclude/file2.ts"
+  ]
+}
+```
+
+### How It Works
+
+- When x-fidelity runs, it looks for the `.xfi-config.json` file in your project's root directory.
+- If found, it applies the configurations specified in this file.
+- For `sensitiveFileFalsePositives`, the specified files will be excluded from checks that look for sensitive data, such as API keys or passwords.
+
+### How to use it
+
+1. **Version Control**: Include `.xfi-config.json` in your version control system to ensure consistency across your team.
+2. **Documentation**: Add comments in the listed file explaining why it is a false positive.
+3. **Regular Review**: Periodically review your `.xfi-config.json` to ensure the exclusions are still necessary and valid.
+4. **Minimal Use**: Use exclusions sparingly. It's better to fix issues than to exclude them from checks.
+5. **Feedback**: If the rules being applied are resulting in too many false-postives, speak with the team that manages your central rule config.
+
+Remember, while `.xfi-config.json` allows you to adjust x-fidelity's behavior in limited ways, it should be used judiciously to maintain the integrity of your code quality checks.
+
 ## Contributing
 
 Contributions to x-fidelity are welcome! Please refer to the `CONTRIBUTING.md` file for guidelines on how to contribute to this project.

package/cli-testing/installBatsTesting.sh

@@ -0,0 +1,9 @@
+#!/bin/bash
+
+yarn global add bats
+
+git clone https://github.com/bats-core/bats-support.git test_helper/bats-support
+git clone https://github.com/bats-core/bats-assert.git test_helper/bats-assert
+
+echo "bats cli testing framework installed. you can now run 'yarn bats:test'"
+

package/cli-testing/test_cli_options.bats

@@ -0,0 +1,86 @@
+#!/usr/bin/env bats
+
+setup() {
+  load './test_helper/bats-support/load'
+  load './test_helper/bats-assert/load'
+  ln -s ../dist/index.js ./xfidelity
+  chmod 755 ./xfidelity
+  BATS_TEST_TIMEOUT=10
+}
+
+teardown() {
+  ./xfidelity 3>&-
+  rm ./xfidelity
+}
+
+@test "CLI displays help information with -h option" {
+  run ./xfidelity --help
+  assert_success
+  assert_output --partial "Usage:"
+  assert_output --partial "--dir <directory>"
+  assert_output --partial "--archetype <archetype>"
+  assert_output --partial "--configServer <configServer>"
+}
+
+@test "CLI displays version number with -v option" {
+  run ./xfidelity --version
+  assert_success
+  assert_output --regexp '^[0-9]+\.[0-9]+\.[0-9]$'
+}
+
+@test "CLI analyzes specified directory" {
+  run ./xfidelity --dir "/home/andrewv/git/x-fidelity/src"
+  assert_success
+  assert_output --partial "directory: /home/andrewv/git/x-fidelity/src"
+}
+
+@test "CLI uses the specified archetype for analysis" {
+  run ./xfidelity --archetype "java-microservice" --dir "/home/andrewv/git/x-fidelity/src"
+  assert_success
+  assert_output --partial "archetype: java-microservice"
+  assert_output --partial "directory: /home/andrewv/git/x-fidelity/src"
+}
+
+@test "CLI runs server on specified port" {
+  ./xfidelity --mode server --port 9079 &
+  pid=$!
+  
+  while ! nc -vz localhost 9079 > /dev/null 2>&1 ; do
+      # echo sleeping
+      sleep 0.1
+  done
+  
+  curl localhost:9079 || kill "$pid"
+
+  # Kill Pid
+  kill $pid
+}
+
+@test "CLI enables OpenAI analysis" {
+  OPENAI_API_KEY=abc
+  run ./xfidelity --openaiEnabled true --dir "../src"
+  assert_success
+  assert_output --partial "openaiEnabled: true"
+}
+
+@test "CLI uses specified config server URL" {
+  run ./xfidelity --configServer "http://127.0.0.1/config" --dir "../src"
+  assert_success
+  assert_output --partial "configServer: http://127.0.0.1/config"
+}
+
+@test "CLI sets JSON TTL" {
+  run ./xfidelity --jsonTTL 30 --dir "../src"
+  assert_success
+  assert_output --partial "jsonTTL: 30"
+}
+
+@test "CLI handles multiple options correctly" {
+  run ./xfidelity --dir "/home/andrewv/git/x-fidelity/src" --archetype "node-fullstack" --jsonTTL 45
+  assert_success
+  assert_output --partial "directory: /home/andrewv/git/x-fidelity/src"
+  assert_output --partial "archetype: node-fullstack"
+  assert_output --partial "openaiEnabled: false"
+  assert_output --partial "jsonTTL: 45"
+  assert_output --partial "mode: client"
+}

package/dist/archetypes/java-microservice.json

@@ -2,18 +2,14 @@
     "name": "java-microservice",
     "rules": [
         "sensitiveLogging-iterative",
-        "outdatedFramework-global",
-        "noDatabases-iterative",
         "nonStandardDirectoryStructure-global"
     ],
     "operators": [
         "fileContains",
-        "outdatedFramework",
         "nonStandardDirectoryStructure"
     ],
     "facts": [
-        "repoFilesystemFacts",
-        "repoDependencyFacts"
+        "repoFilesystemFacts"
     ],
     "config": {
         "minimumDependencyVersions": {

package/dist/archetypes/node-fullstack-exemptions.json

@@ -8,7 +8,7 @@
   {
     "repoUrl": "git@github.com:zotoio/x-fidelity.git",
     "rule": "sensitiveLogging-iterative",
-    "expirationDate": "2025-09-30",
+    "expirationDate": "2023-09-30",
     "reason": "Security audit and logging refactor planned for Q3 2024"
   }
 ]

package/dist/core/cli.js

@@ -92,6 +92,7 @@ mode: ${options.mode}
 port: ${options.mode === 'server' ? options.port : 'n/a'}
 localConfigPath: ${options.localConfigPath ? options.localConfigPath : 'none'}
 jsonTTL: ${options.jsonTTL} minutes
+openaiEnabled: ${options.openaiEnabled}
 for options run: xfidelity --help
 =====================================`);
 logger_1.logger.info(banner);

package/dist/core/engine/analyzer.js

@@ -15,6 +15,7 @@ const configManager_1 = require("../../utils/configManager");
 const openaiUtils_1 = require("../../utils/openaiUtils");
 const telemetry_1 = require("../../utils/telemetry");
 const repoFilesystemFacts_1 = require("../../facts/repoFilesystemFacts");
+const repoXFIConfigLoader_1 = require("../../utils/repoXFIConfigLoader");
 const repoDependencyFacts_1 = require("../../facts/repoDependencyFacts");
 const openaiAnalysisFacts_1 = require("../../facts/openaiAnalysisFacts");
 const telemetryCollector_1 = require("./telemetryCollector");
@@ -43,6 +44,7 @@ function analyzeCodebase(params) {
         }, executionLogPrefix);
         const installedDependencyVersions = yield (0, repoDependencyFacts_1.getDependencyVersionFacts)(archetypeConfig);
         const fileData = yield (0, repoFilesystemFacts_1.collectRepoFileData)(repoPath, archetypeConfig);
+        const repoXFIConfig = yield (0, repoXFIConfigLoader_1.loadRepoXFIConfig)(repoPath);
         // add REPO_GLOBAL_CHECK to fileData, which is the trigger for global checks
         fileData.push({
             fileName: configManager_1.REPO_GLOBAL_CHECK,
@@ -66,9 +68,12 @@ function analyzeCodebase(params) {
             engine.addFact('openaiAnalysis', openaiAnalysisFacts_1.openaiAnalysis);
             engine.addFact('openaiSystemPrompt', openaiSystemPrompt);
         }
-        // add output facts
+        // add functions for dependency and file analysis
         engine.addFact('repoDependencyAnalysis', repoDependencyFacts_1.repoDependencyAnalysis);
         engine.addFact('repoFileAnalysis', repoFilesystemFacts_1.repoFileAnalysis);
+        // add xfiConfig as a fact
+        engine.addFact('repoXFIConfig', repoXFIConfig);
+        logger_1.logger.info(`Added repoXFIConfig as fact: ${(0, utils_1.safeStringify)(repoXFIConfig)}`);
         const failures = yield (0, engineRunner_1.runEngineOnFiles)({
             engine,
             fileData,
@@ -88,18 +93,19 @@ function analyzeCodebase(params) {
         const resultMetadata = {
             XFI_RESULT: {
                 archetype,
-                repoPath,
+                telemetryData,
+                repoXFIConfig: repoXFIConfig,
+                issueDetails: failures,
+                startTime: telemetryData.startTime,
+                finishTime: finishTime,
+                durationSeconds: (finishTime - telemetryData.startTime) / 1000,
                 fileCount: fileData.length,
                 totalIssues: totalFailureCount,
                 warningCount: warningCount,
                 fatalityCount: fatalityCount,
                 exemptCount: exemptCount,
-                issueDetails: failures,
-                startTime: telemetryData.startTime,
-                finishTime: finishTime,
-                durationSeconds: (finishTime - telemetryData.startTime) / 1000,
-                telemetryData,
-                options: cli_1.options
+                options: cli_1.options,
+                repoPath,
             }
         };
         // Send telemetry for analysis end

package/dist/core/engine/analyzer.test.js

@@ -122,15 +122,34 @@ describe('analyzeCodebase', () => {
                 archetype: 'node-fullstack',
                 repoPath: 'mockRepoPath',
                 fileCount: 3,
-                totalIssues: 0,
-                warningCount: 0,
-                fatalityCount: 0,
-                issueDetails: [],
+                totalIssues: expect.any(Number),
+                warningCount: expect.any(Number),
+                fatalityCount: expect.any(Number),
+                exemptCount: expect.any(Number),
+                issueDetails: expect.any(Array),
                 durationSeconds: expect.any(Number),
                 finishTime: expect.any(Number),
                 startTime: expect.any(Number),
-                options: expect.any(Object),
-                telemetryData: expect.any(Object),
+                options: expect.objectContaining({
+                    archetype: 'node-fullstack',
+                    configServer: '',
+                    dir: 'mockDir',
+                    localConfigPath: '',
+                    mode: 'cli',
+                    openaiEnabled: true,
+                    port: '8888',
+                    telemetryCollector: '',
+                }),
+                telemetryData: expect.objectContaining({
+                    configServer: 'none',
+                    hostInfo: expect.any(Object),
+                    repoUrl: '',
+                    startTime: expect.any(Number),
+                    userInfo: expect.any(Object),
+                }),
+                repoXFIConfig: expect.objectContaining({
+                    sensitiveFileFalsePositives: expect.any(Array),
+                })
             })
         });
         expect(telemetry_1.sendTelemetry).toHaveBeenCalledTimes(2); // Once for start, once for end
@@ -174,15 +193,32 @@ describe('analyzeCodebase', () => {
                 archetype: 'node-fullstack',
                 repoPath: 'mockRepoPath',
                 fileCount: 3,
-                totalIssues: 0,
+                totalIssues: 3,
                 warningCount: 0,
                 fatalityCount: 0,
-                issueDetails: [],
+                exemptCount: 0,
+                issueDetails: expect.arrayContaining([
+                    expect.objectContaining({
+                        filePath: expect.any(String),
+                        errors: expect.arrayContaining([
+                            expect.objectContaining({
+                                ruleFailure: 'ProcessingError',
+                                level: 'error',
+                                details: expect.objectContaining({
+                                    message: expect.stringContaining('Error processing file: Error: mock error')
+                                })
+                            })
+                        ])
+                    })
+                ]),
                 durationSeconds: expect.any(Number),
                 finishTime: expect.any(Number),
                 startTime: expect.any(Number),
                 options: expect.any(Object),
                 telemetryData: expect.any(Object),
+                repoXFIConfig: expect.objectContaining({
+                    sensitiveFileFalsePositives: expect.any(Array)
+                })
             })
         });
         expect(telemetry_1.sendTelemetry).toHaveBeenCalledTimes(2); // Once for start, once for end
@@ -216,7 +252,6 @@ describe('analyzeCodebase', () => {
             repoPath: 'mockRepoPath',
             archetype: 'node-fullstack'
         });
-        expect(engineAddFactMock).toHaveBeenCalledWith('repoDependencyAnalysis', expect.any(Function));
         expect(telemetry_1.sendTelemetry).toHaveBeenCalledTimes(2); // Once for start, once for end
     }));
     it('should not add OpenAI facts when OpenAI is not enabled', () => __awaiter(void 0, void 0, void 0, function* () {

package/dist/core/engine/engineRunner.js

@@ -14,11 +14,12 @@ const logger_1 = require("../../utils/logger");
 const configManager_1 = require("../../utils/configManager");
 function runEngineOnFiles(params) {
     return __awaiter(this, void 0, void 0, function* () {
+        var _a, _b;
         const { engine, fileData, installedDependencyVersions, minimumDependencyVersions, standardStructure } = params;
         const msg = `\n==========================\nRUNNING FILE CHECKS..\n==========================`;
         logger_1.logger.info(msg);
         const failures = [];
-        const enginePromises = fileData.map((file) => __awaiter(this, void 0, void 0, function* () {
+        for (const file of fileData) {
             if (file.fileName === configManager_1.REPO_GLOBAL_CHECK) {
                 const msg = `\n==========================\nRUNNING GLOBAL REPO CHECKS..\n==========================`;
                 logger_1.logger.info(msg);
@@ -38,8 +39,7 @@ function runEngineOnFiles(params) {
             const fileFailures = [];
             try {
                 const { results } = yield engine.run(facts);
-                results.forEach((result) => {
-                    var _a, _b;
+                for (const result of results) {
                     logger_1.logger.debug(JSON.stringify(result));
                     if (result.result) {
                         fileFailures.push({
@@ -48,16 +48,23 @@ function runEngineOnFiles(params) {
                             details: (_b = result.event) === null || _b === void 0 ? void 0 : _b.params
                         });
                     }
-                });
+                }
                 if (fileFailures.length > 0) {
                     failures.push({ filePath: file.filePath, errors: fileFailures });
                 }
             }
             catch (e) {
-                logger_1.logger.error(e);
+                logger_1.logger.error(`Error processing file ${file.filePath}: ${e}`);
+                failures.push({
+                    filePath: file.filePath,
+                    errors: [{
+                            ruleFailure: 'ProcessingError',
+                            level: 'error',
+                            details: { message: `Error processing file: ${e}` }
+                        }]
+                });
             }
-        }));
-        yield Promise.all(enginePromises);
+        }
         return failures;
     });
 }