x-fidelity 1.6.0 → 1.6.1

package/.eslintrc.js

@@ -0,0 +1,19 @@
+module.exports = {
+  parser: '@typescript-eslint/parser',
+  extends: [
+    'eslint:recommended',
+    'plugin:@typescript-eslint/recommended',
+  ],
+  parserOptions: {
+    ecmaVersion: 2020,
+    sourceType: 'module',
+  },
+  env: {
+    node: true,
+    es6: true,
+  },
+  rules: {
+    // Add any custom rules here
+    '@typescript-eslint/no-explicit-any': 'off', // Disable no-explicit-any rule
+  },
+};

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [1.6.1](https://github.com/zotoio/x-fidelity/compare/v1.6.0...v1.6.1) (2024-07-27)
+
+
+### Bug Fixes
+
+* **lint:** setup ([f559331](https://github.com/zotoio/x-fidelity/commit/f5593314bc591cb2d6e8cb809c828455fa294b62))
+
 # [1.6.0](https://github.com/zotoio/x-fidelity/compare/v1.5.1...v1.6.0) (2024-07-27)
 
 

package/README.md

@@ -45,8 +45,9 @@ x-fidelity is an advanced CLI tool designed to enforce opinionated framework adh
 7. [OpenAI Integration](#openai-integration)
 8. [Hosting Config Servers](#hosting-config-servers)
 9. [Best Practices](#best-practices)
-10. [Contributing](#contributing)
-11. [License](#license)
+10. [Linting](#linting)
+11. [Contributing](#contributing)
+12. [License](#license)
 
 ## Intent and Purpose
 
@@ -316,6 +317,22 @@ app.listen(8888, () => {
 
 Contributions to x-fidelity are welcome! Please refer to the `CONTRIBUTING.md` file for guidelines on how to contribute to this project.
 
+## Linting
+
+This project uses ESLint for static code analysis. To run the linter:
+
+```sh
+yarn lint
+```
+
+To automatically fix linting issues:
+
+```sh
+yarn lint:fix
+```
+
+ESLint is also integrated into the CI pipeline and runs alongside unit tests in GitHub Actions.
+
 ## License
 
 This project is licensed under the MIT License. See the `LICENSE` file for details.

package/dist/core/engine.js

@@ -107,7 +107,7 @@ function analyzeCodebase(repoPath_1) {
                 logger_1.logger.error(e.message);
             }
         });
-        engine.on('success', (_a, almanac_1) => __awaiter(this, [_a, almanac_1], void 0, function* ({ type, params }, almanac) {
+        engine.on('success', (_a) => __awaiter(this, [_a], void 0, function* ({ type, params }) {
             if (type === 'violation') {
                 logger_1.logger.warn(`violation detected: ${JSON.stringify(params)}}`);
                 yield (0, telemetry_1.sendTelemetry)({
@@ -146,14 +146,14 @@ function analyzeCodebase(repoPath_1) {
         engine.addFact('repoDependencyAnalysis', repoDependencyFacts_1.repoDependencyAnalysis);
         // Run the engine for each file's data    
         logger_1.logger.info(`### Executing rules..`);
-        let failures = [];
+        const failures = [];
         for (const file of fileData) {
             if (file.fileName === config_1.REPO_GLOBAL_CHECK) {
-                let msg = `\n==========================\nSTARTING GLOBAL REPO CHECKS..\n==========================`;
+                const msg = `\n==========================\nSTARTING GLOBAL REPO CHECKS..\n==========================`;
                 logger_1.logger.info(msg);
             }
             else {
-                let msg = `running engine for ${file.filePath}`;
+                const msg = `running engine for ${file.filePath}`;
                 logger_1.logger.info(msg);
             }
             const facts = {
@@ -164,7 +164,7 @@ function analyzeCodebase(repoPath_1) {
                 },
                 standardStructure
             };
-            let fileFailures = [];
+            const fileFailures = [];
             yield engine.run(facts)
                 .then(({ results }) => {
                 results.map((result) => {
@@ -206,11 +206,11 @@ function analyzeCodebase(repoPath_1) {
     });
 }
 const findKeyValuePair = (data, targetKey, targetValue) => {
-    let results = [];
+    const results = [];
     const recursiveSearch = (obj) => {
         if (typeof obj === 'object' && obj !== null) {
-            for (let key in obj) {
-                if (obj.hasOwnProperty(key)) {
+            for (const key in obj) {
+                if (Object.prototype.hasOwnProperty.call(obj, key)) {
                     if (key === targetKey && obj[key] === targetValue) {
                         results.push(obj);
                         return; // Stop searching this branch as we've found the target in this object

package/dist/core/engine.test.js

@@ -67,8 +67,8 @@ describe('analyzeCodebase', () => {
             getConfig: jest.fn().mockReturnValue(archetypes_1.archetypes['node-fullstack']),
             configServer: ''
         });
-        jest.spyOn(console, 'log').mockImplementation(() => { });
-        jest.spyOn(console, 'error').mockImplementation(() => { });
+        jest.spyOn(console, 'log').mockImplementation(() => { console.log('z'); });
+        jest.spyOn(console, 'error').mockImplementation(() => { console.log('z'); });
     });
     it('should analyze the codebase and return results', () => __awaiter(void 0, void 0, void 0, function* () {
         const mockFileData = [

package/dist/facts/index.js

@@ -13,11 +13,13 @@ exports.loadFacts = loadFacts;
 const repoFilesystemFacts_1 = require("./repoFilesystemFacts");
 const repoDependencyFacts_1 = require("./repoDependencyFacts");
 const openaiAnalysisFacts_1 = require("./openaiAnalysisFacts");
+// eslint-disable-next-line @typescript-eslint/ban-types
 const allFacts = {
     repoFilesystemFacts: { name: 'fileData', fn: repoFilesystemFacts_1.collectRepoFileData },
     repoDependencyFacts: { name: 'dependencyData', fn: repoDependencyFacts_1.getDependencyVersionFacts },
     openaiAnalysisFacts: { name: 'openaiAnalysis', fn: openaiAnalysisFacts_1.openaiAnalysis }
 };
+// eslint-disable-next-line @typescript-eslint/ban-types
 function loadFacts(factNames) {
     return __awaiter(this, void 0, void 0, function* () {
         return factNames

package/dist/facts/repoDependencyFacts.js

@@ -50,7 +50,7 @@ const semver = __importStar(require("semver"));
 function collectLocalDependencies() {
     let result = {};
     try {
-        let stdout = (0, child_process_1.execSync)('npm ls -a --json');
+        const stdout = (0, child_process_1.execSync)('npm ls -a --json');
         result = JSON.parse(stdout.toString());
     }
     catch (e) {
@@ -80,11 +80,11 @@ function getDependencyVersionFacts(archetypeConfig) {
  * @returns An array of results.
  */
 function findPropertiesInTree(depGraph, minVersions) {
-    let results = [];
+    const results = [];
     logger_1.logger.debug(`depGraph: ${depGraph}`);
     function walk(depGraph) {
         if (lodash_1.default.isObject(depGraph) && !lodash_1.default.isArray(depGraph)) {
-            for (let depName in depGraph) {
+            for (const depName in depGraph) {
                 if (Object.keys(minVersions).includes(depName)) {
                     results.push({ dep: depName, ver: depGraph[depName].version, min: minVersions[depName] });
                 }
@@ -94,7 +94,7 @@ function findPropertiesInTree(depGraph, minVersions) {
             }
         }
         else if (lodash_1.default.isArray(depGraph)) {
-            for (let item of depGraph) {
+            for (const item of depGraph) {
                 walk(item);
             }
         }
@@ -104,18 +104,18 @@ function findPropertiesInTree(depGraph, minVersions) {
 }
 function repoDependencyAnalysis(params, almanac) {
     return __awaiter(this, void 0, void 0, function* () {
-        let result = { 'result': [] };
+        const result = { 'result': [] };
         const fileData = yield almanac.factValue('fileData');
         if (fileData.fileName !== 'REPO_GLOBAL_CHECK') {
             return result;
         }
-        let analysis = [];
+        const analysis = [];
         const dependencyData = yield almanac.factValue('dependencyData');
         dependencyData.installedDependencyVersions.map((versionData) => {
             logger_1.logger.debug(`outdatedFramework: checking ${versionData.dep}`);
             const requiredRange = new semver.Range(versionData.min);
             if (!semver.gtr(versionData.ver, requiredRange)) {
-                let dependencyFailure = {
+                const dependencyFailure = {
                     'dependency': versionData.dep,
                     'currentVersion': versionData.ver,
                     'requiredVersion': versionData.min
@@ -129,4 +129,3 @@ function repoDependencyAnalysis(params, almanac) {
         return result;
     });
 }
-;

package/dist/index.js

@@ -25,7 +25,7 @@ try {
     }
     else {
         (() => __awaiter(void 0, void 0, void 0, function* () {
-            let results = yield (0, engine_1.analyzeCodebase)(`${process.env.PWD}/${cli_1.options.dir}`, cli_1.options.archetype, cli_1.options.configServer);
+            const results = yield (0, engine_1.analyzeCodebase)(`${process.env.PWD}/${cli_1.options.dir}`, cli_1.options.archetype, cli_1.options.configServer);
             // if results are found, there were warning level issues found in the codebase
             if (results.length > 0) {
                 logger_1.logger.warn('WARNING: lo-fi attributes detected in codebase!');

package/dist/operators/fileContains.js

@@ -7,9 +7,9 @@ const fileContains = {
     'fn': (fileContent, checkString) => {
         let result = false;
         const regex = new RegExp(checkString, 'g');
-        let lines = fileContent.split('\n');
+        const lines = fileContent.split('\n');
         let lineNumber = 0;
-        for (let line of lines) {
+        for (const line of lines) {
             lineNumber++;
             if (regex.test(line)) {
                 logger_1.logger.debug(`fileContains '${checkString}' found in line ${lineNumber}: ${line}`);

package/dist/operators/outdatedFramework.js

@@ -4,7 +4,7 @@ exports.outdatedFramework = void 0;
 const logger_1 = require("../utils/logger");
 const outdatedFramework = {
     'name': 'outdatedFramework',
-    'fn': (repoDependencyAnalysis, repoDependencyFacts) => {
+    'fn': (repoDependencyAnalysis) => {
         var _a;
         let result = false;
         try {

package/dist/rules/index.js

@@ -67,9 +67,6 @@ function loadRules(archetype, ruleNames, configServer, logPrefix, localConfigPat
             else if (localConfigPath) {
                 rule = yield loadLocalConfigRule(ruleName, localConfigPath);
             }
-            else if (localConfigPath) {
-                rule = yield loadLocalConfigRule(ruleName, localConfigPath);
-            }
             else {
                 rule = yield loadLocalRule(ruleName);
             }

package/dist/server/configServer.js

@@ -25,7 +25,7 @@ app.use(express_1.default.json());
 app.use(expressLogger_1.expressLogger);
 const validInput = (value) => {
     // Ensure input contains only alphanumeric characters, hyphens, and underscores
-    const validName = /^[a-zA-Z0-9-_\-]{1,50}$/;
+    const validName = /^[a-zA-Z0-9-_-]{1,50}$/;
     return validName.test(value);
 };
 app.get('/archetypes/:archetype', (req, res) => {
@@ -46,7 +46,7 @@ app.get('/archetypes', (req, res) => {
 app.get('/archetypes/:archetype/rules', (req, res) => __awaiter(void 0, void 0, void 0, function* () {
     logger_1.logger.info(`serving rules for archetype: ${req.params.archetype}`);
     const archetype = req.params.archetype;
-    if (validInput(archetype) && archetypes_1.archetypes.hasOwnProperty(archetype) && archetypes_1.archetypes[archetype].rules) {
+    if (validInput(archetype) && Object.prototype.hasOwnProperty.call(archetypes_1.archetypes, archetype) && archetypes_1.archetypes[archetype].rules) {
         const rules = yield (0, rules_1.loadRules)(archetype, archetypes_1.archetypes[archetype].rules);
         res.json(rules);
     }
@@ -58,7 +58,7 @@ app.get('/archetypes/:archetype/rules/:rule', (req, res) => __awaiter(void 0, vo
     logger_1.logger.info(`serving rule ${req.params.rule} for archetype ${req.params.archetype}..`);
     const archetype = req.params.archetype;
     const rule = req.params.rule;
-    if (validInput(archetype) && validInput(rule) && archetypes_1.archetypes.hasOwnProperty(archetype) && archetypes_1.archetypes[archetype].rules.includes(rule)) {
+    if (validInput(archetype) && validInput(rule) && Object.prototype.hasOwnProperty.call(archetypes_1.archetypes, archetype) && archetypes_1.archetypes[archetype].rules.includes(rule)) {
         const rules = yield (0, rules_1.loadRules)(archetype, archetypes_1.archetypes[archetype].rules);
         const ruleJson = rules.find((r) => r.name === rule);
         res.json(ruleJson);

package/dist/xfidelity

@@ -25,7 +25,7 @@ try {
     }
     else {
         (() => __awaiter(void 0, void 0, void 0, function* () {
-            let results = yield (0, engine_1.analyzeCodebase)(`${process.env.PWD}/${cli_1.options.dir}`, cli_1.options.archetype, cli_1.options.configServer);
+            const results = yield (0, engine_1.analyzeCodebase)(`${process.env.PWD}/${cli_1.options.dir}`, cli_1.options.archetype, cli_1.options.configServer);
             // if results are found, there were warning level issues found in the codebase
             if (results.length > 0) {
                 logger_1.logger.warn('WARNING: lo-fi attributes detected in codebase!');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "x-fidelity",
-  "version": "1.6.0",
+  "version": "1.6.1",
   "description": "cli for opinionated framework adherence checks",
   "main": "dist/xfidelity",
   "bin": {
@@ -10,13 +10,15 @@
     "build": "rimraf dist/ && tsc && yarn copy-files",
     "copy-files": "cp src/rules/*.json dist/rules/ && cp dist/index.js dist/xfidelity",
     "start": "OPENAI_API_KEY= jest --watch",
-    "test": "OPENAI_API_KEY= jest",
+    "test": "yarn lint && OPENAI_API_KEY= jest",
     "test:coverage": "OPENAI_API_KEY= jest --coverage",
-    "commit": "git-cz",
+    "commit": "yarn test && git-cz",
     "release": "semantic-release",
     "test-bin-install": "yarn build && yarn global bin && yarn global add file:$PWD",
     "build-run": "yarn build && node . --dir . | jq -R -r '. as $line | try fromjson catch $line'",
-    "start-server": "ts-node src/index.ts --mode server"
+    "start-server": "ts-node src/index.ts --mode server",
+    "lint": "eslint . --ext .ts",
+    "lint:fix": "eslint . --ext .ts --fix"
   },
   "repository": "git@github.com:zotoio/x-fidelity.git",
   "author": "wyvern8 <io@zoto.io>",
@@ -28,6 +30,9 @@
   "devDependencies": {
     "@jest/globals": "^29.7.0",
     "@semantic-release/changelog": "^6.0.3",
+    "@typescript-eslint/eslint-plugin": "^5.59.0",
+    "@typescript-eslint/parser": "^5.59.0",
+    "eslint": "^8.38.0",
     "@semantic-release/commit-analyzer": "^13.0.0",
     "@semantic-release/git": "^10.0.1",
     "@semantic-release/github": "^10.0.6",

package/src/core/engine.test.ts

@@ -59,8 +59,8 @@ describe('analyzeCodebase', () => {
             getConfig: jest.fn().mockReturnValue(archetypes['node-fullstack']),
             configServer: ''
         });
-        jest.spyOn(console, 'log').mockImplementation(() => {});
-        jest.spyOn(console, 'error').mockImplementation(() => {});
+        jest.spyOn(console, 'log').mockImplementation(() => {console.log('z')});
+        jest.spyOn(console, 'error').mockImplementation(() => {console.log('z')});
     });
 
     it('should analyze the codebase and return results', async () => {

package/src/core/engine.ts

@@ -1,7 +1,7 @@
 import { logger, logPrefix } from '../utils/logger';
-import { Almanac, Engine, EngineResult, Event, RuleProperties, RuleResult } from 'json-rules-engine';
+import { Engine, EngineResult, Event, RuleProperties, RuleResult } from 'json-rules-engine';
 import { FileData, collectRepoFileData } from '../facts/repoFilesystemFacts';
-import { ScanResult, RuleFailure, ArchetypeConfig, OpenAIAnalysisParams } from '../types/typeDefs';
+import { ScanResult, RuleFailure} from '../types/typeDefs';
 import { getDependencyVersionFacts, repoDependencyAnalysis } from '../facts/repoDependencyFacts';
 import { collectOpenaiAnalysisFacts, openaiAnalysis } from '../facts/openaiAnalysisFacts';
 import { loadOperators } from '../operators';
@@ -13,7 +13,7 @@ import { sendTelemetry } from '../utils/telemetry';
 import { execSync } from 'child_process';
 import os from 'os';
 
-async function analyzeCodebase(repoPath: string, archetype: string = 'node-fullstack', configServer: string = '', localConfigPath: string = ''): Promise<any[]> {
+async function analyzeCodebase(repoPath: string, archetype = 'node-fullstack', configServer = '', localConfigPath = ''): Promise<any[]> {
     const configManager = ConfigManager.getInstance();
     await configManager.initialize(archetype, configServer, localConfigPath);
     const archetypeConfig = configManager.getConfig();
@@ -104,7 +104,7 @@ async function analyzeCodebase(repoPath: string, archetype: string = 'node-fulls
         }
     });
 
-    engine.on('success', async ({ type, params }: Event, almanac: Almanac) => {
+    engine.on('success', async ({ type, params }: Event) => {
         if (type === 'violation') {
             logger.warn(`violation detected: ${JSON.stringify(params)}}`);
             await sendTelemetry({
@@ -152,14 +152,14 @@ async function analyzeCodebase(repoPath: string, archetype: string = 'node-fulls
 
     // Run the engine for each file's data    
     logger.info(`### Executing rules..`);
-    let failures: ScanResult[] = [];
+    const failures: ScanResult[] = [];
     for (const file of fileData) {
         if (file.fileName === REPO_GLOBAL_CHECK) {
-            let msg = `\n==========================\nSTARTING GLOBAL REPO CHECKS..\n==========================`
+            const msg = `\n==========================\nSTARTING GLOBAL REPO CHECKS..\n==========================`
             logger.info(msg);
 
         } else {
-            let msg = `running engine for ${file.filePath}`
+            const msg = `running engine for ${file.filePath}`
             logger.info(msg);
         }
         const facts = {
@@ -171,7 +171,7 @@ async function analyzeCodebase(repoPath: string, archetype: string = 'node-fulls
             standardStructure
 
         };
-        let fileFailures: RuleFailure[] = [];
+        const fileFailures: RuleFailure[] = [];
 
         await engine.run(facts)
             .then(({ results }: EngineResult) => {
@@ -222,12 +222,12 @@ const findKeyValuePair = (
     targetKey: string,
     targetValue: any
 ): any[] => {
-    let results: any[] = [];
+    const results: any[] = [];
 
     const recursiveSearch = (obj: any): void => {
         if (typeof obj === 'object' && obj !== null) {
-            for (let key in obj) {
-                if (obj.hasOwnProperty(key)) {
+            for (const key in obj) {
+                if (Object.prototype.hasOwnProperty.call(obj, key)) {
                     if (key === targetKey && obj[key] === targetValue) {
                         results.push(obj);
                         return; // Stop searching this branch as we've found the target in this object

package/src/facts/index.ts

@@ -2,12 +2,14 @@ import { collectRepoFileData } from './repoFilesystemFacts';
 import { getDependencyVersionFacts } from './repoDependencyFacts';
 import { openaiAnalysis } from './openaiAnalysisFacts';
 
+// eslint-disable-next-line @typescript-eslint/ban-types
 const allFacts: Record<string, { name: string, fn: Function }> = {
     repoFilesystemFacts: { name: 'fileData', fn: collectRepoFileData },
     repoDependencyFacts: { name: 'dependencyData', fn: getDependencyVersionFacts },
     openaiAnalysisFacts: { name: 'openaiAnalysis', fn: openaiAnalysis }
 };
 
+// eslint-disable-next-line @typescript-eslint/ban-types
 async function loadFacts(factNames: string[]): Promise<{ name: string, fn: Function }[]> {
     return factNames
         .map(name => allFacts[name])

package/src/facts/repoDependencyFacts.test.ts

@@ -1,8 +1,6 @@
 import { execSync } from 'child_process';
 import { collectLocalDependencies, getDependencyVersionFacts, findPropertiesInTree } from './repoDependencyFacts';
 import { logger } from '../utils/logger';
-import { ConfigManager } from '../utils/config';
-import { arch } from 'os';
 import { archetypes } from '../archetypes';
 
 jest.mock('child_process', () => ({

package/src/facts/repoDependencyFacts.ts

@@ -13,7 +13,7 @@ import { FileData } from './repoFilesystemFacts';
 export function collectLocalDependencies(): LocalDependencies {
     let result: LocalDependencies = {};
     try {
-        let stdout = execSync('npm ls -a --json');
+        const stdout = execSync('npm ls -a --json');
         result = JSON.parse(stdout.toString());
     } catch (e) {
         logger.error(`exec error: ${e}`);
@@ -44,13 +44,13 @@ export async function getDependencyVersionFacts(archetypeConfig: ArchetypeConfig
  * @returns An array of results.
  */
 export function findPropertiesInTree(depGraph: LocalDependencies, minVersions: MinimumDepVersions): VersionData[] {
-    let results: VersionData[] = [];
+    const results: VersionData[] = [];
 
     logger.debug(`depGraph: ${depGraph}`);
 
     function walk(depGraph: LocalDependencies) {
         if (_.isObject(depGraph) && !_.isArray(depGraph)) {
-            for (let depName in depGraph) {
+            for (const depName in depGraph) {
                 if (Object.keys(minVersions).includes(depName)) {
                     results.push({ dep: depName, ver: depGraph[depName].version, min: minVersions[depName] });
                 }
@@ -59,7 +59,7 @@ export function findPropertiesInTree(depGraph: LocalDependencies, minVersions: M
                 }
             }
         } else if (_.isArray(depGraph)) {
-            for (let item of depGraph) {
+            for (const item of depGraph) {
                 walk(item);
             }
         }
@@ -71,14 +71,14 @@ export function findPropertiesInTree(depGraph: LocalDependencies, minVersions: M
 
 export async function repoDependencyAnalysis(params: any, almanac: Almanac) {
 
-    let result: any = {'result': []};
+    const result: any = {'result': []};
     const fileData: FileData = await almanac.factValue('fileData');
 
     if (fileData.fileName !== 'REPO_GLOBAL_CHECK') {
         return result;
     }
 
-    let analysis: any = [];
+    const analysis: any = [];
     const dependencyData: any = await almanac.factValue('dependencyData');
 
     dependencyData.installedDependencyVersions.map((versionData: VersionData) => { 
@@ -86,7 +86,7 @@ export async function repoDependencyAnalysis(params: any, almanac: Almanac) {
 
         const requiredRange = new semver.Range(versionData.min);
         if (!semver.gtr(versionData.ver, requiredRange)) {
-            let dependencyFailure = {
+            const dependencyFailure = {
                 'dependency': versionData.dep,
                 'currentVersion': versionData.ver,
                 'requiredVersion': versionData.min
@@ -102,4 +102,4 @@ export async function repoDependencyAnalysis(params: any, almanac: Almanac) {
     almanac.addRuntimeFact(params.resultFact, result);
 
     return result;
-};
+}

package/src/facts/repoFilesystemFacts.test.ts

@@ -1,7 +1,6 @@
 import { collectRepoFileData, parseFile, isBlacklisted, isWhitelisted } from './repoFilesystemFacts';
 import fs from 'fs';
 import path from 'path';
-import { logger } from '../utils/logger';
 import { ArchetypeConfig } from '../types/typeDefs';
 
 jest.mock('fs', () => ({

package/src/index.ts

@@ -12,7 +12,7 @@ try {
         startServer(options.port);
     } else {
         (async () => {
-            let results = await analyzeCodebase(`${process.env.PWD}/${options.dir}`, options.archetype, options.configServer);
+            const results = await analyzeCodebase(`${process.env.PWD}/${options.dir}`, options.archetype, options.configServer);
 
             // if results are found, there were warning level issues found in the codebase
             if (results.length > 0) {

package/src/operators/fileContains.ts

@@ -7,9 +7,9 @@ const fileContains: OperatorDefn = {
         let result = false;
 
         const regex = new RegExp(checkString, 'g');
-        let lines = fileContent.split('\n');
+        const lines = fileContent.split('\n');
         let lineNumber = 0;
-        for (let line of lines) {
+        for (const line of lines) {
             lineNumber++;
             if (regex.test(line)) {
                 logger.debug(`fileContains '${checkString}' found in line ${lineNumber}: ${line}`);

package/src/operators/index.test.ts

@@ -2,7 +2,6 @@ import { loadOperators } from './index';
 import { outdatedFramework } from './outdatedFramework';
 import { fileContains } from './fileContains';
 import { nonStandardDirectoryStructure } from './nonStandardDirectoryStructure';
-import { openaiAnalysisHighSeverity } from './openaiAnalysisHighSeverity';
 
 jest.mock('./outdatedFramework');
 jest.mock('./fileContains');

package/src/operators/outdatedFramework.test.ts

@@ -1,4 +1,3 @@
-import { logger } from '../utils/logger';
 import { outdatedFramework } from './outdatedFramework';
 
 describe('outdatedFramework', () => {

package/src/operators/outdatedFramework.ts

@@ -1,10 +1,9 @@
 import { logger } from '../utils/logger';
-import { OperatorDefn, VersionData } from '../types/typeDefs';
-import { REPO_GLOBAL_CHECK } from '../utils/config';
+import { OperatorDefn } from '../types/typeDefs';
 
 const outdatedFramework: OperatorDefn = {
     'name': 'outdatedFramework', 
-    'fn': (repoDependencyAnalysis: any, repoDependencyFacts: any) => {
+    'fn': (repoDependencyAnalysis: any) => {
         let result = false;
         
         try {

package/src/rules/index.ts

@@ -3,7 +3,6 @@ import { RuleProperties } from 'json-rules-engine';
 import * as fs from 'fs';
 import * as path from 'path';
 import axios from 'axios';
-import { options } from "../core/cli";
 import { isOpenAIEnabled } from '../utils/openaiUtils';
 
 async function loadRules(archetype: string, ruleNames: string[], configServer?: string, logPrefix?: string, localConfigPath?: string): Promise<RuleProperties[]> {
@@ -31,8 +30,6 @@ async function loadRules(archetype: string, ruleNames: string[], configServer?:
             }
         } else if (localConfigPath) {
             rule = await loadLocalConfigRule(ruleName, localConfigPath);
-        } else if (localConfigPath) {
-            rule = await loadLocalConfigRule(ruleName, localConfigPath);
         } else {
             rule = await loadLocalRule(ruleName);
         }

package/src/server/configServer.ts

@@ -13,7 +13,7 @@ app.use(expressLogger);
 
 const validInput = (value: string): boolean => {
     // Ensure input contains only alphanumeric characters, hyphens, and underscores
-    const validName = /^[a-zA-Z0-9-_\-]{1,50}$/;
+    const validName = /^[a-zA-Z0-9-_-]{1,50}$/;
     return validName.test(value);
 }
 
@@ -36,7 +36,7 @@ app.get('/archetypes', (req, res) => {
 app.get('/archetypes/:archetype/rules', async (req, res) => {
     logger.info(`serving rules for archetype: ${req.params.archetype}`);
     const archetype = req.params.archetype;
-    if (validInput(archetype) && archetypes.hasOwnProperty(archetype) && archetypes[archetype].rules) {
+    if (validInput(archetype) && Object.prototype.hasOwnProperty.call(archetypes, archetype) && archetypes[archetype].rules) {
         const rules = await loadRules(archetype, archetypes[archetype].rules);
         res.json(rules);
     } else {
@@ -48,7 +48,7 @@ app.get('/archetypes/:archetype/rules/:rule', async (req, res) => {
     logger.info(`serving rule ${req.params.rule} for archetype ${req.params.archetype}..`);
     const archetype = req.params.archetype;
     const rule = req.params.rule;
-    if (validInput(archetype) && validInput(rule) && archetypes.hasOwnProperty(archetype) && archetypes[archetype].rules.includes(rule)) {
+    if (validInput(archetype) && validInput(rule) && Object.prototype.hasOwnProperty.call(archetypes, archetype) && archetypes[archetype].rules.includes(rule)) {
         const rules = await loadRules(archetype, archetypes[archetype].rules);
         const ruleJson = rules.find((r) => r.name === rule);
         res.json(ruleJson);

package/src/utils/config.ts

@@ -29,7 +29,7 @@ export class ConfigManager {
         return ConfigManager.instance;
     }
 
-    public async initialize(archetype: string = 'node-fullstack', configServer?: string, localConfigPath?: string): Promise<void> {
+    public async initialize(archetype = 'node-fullstack', configServer?: string, localConfigPath?: string): Promise<void> {
         this.config = archetypes[archetype] || archetypes['node-fullstack'];
         this.configServer = configServer || '';
         this.localConfigPath = localConfigPath || '';