wrec 0.24.7 → 0.24.8

package/package.json

@@ -2,7 +2,7 @@
   "name": "wrec",
   "description": "a small library that greatly simplifies building web components",
   "author": "R. Mark Volkmann",
-  "version": "0.24.7",
+  "version": "0.24.8",
   "license": "MIT",
   "repository": {
     "type": "git",

package/scripts/lint.js

@@ -4,6 +4,7 @@
 // - undefined properties accessed in expressions
 // - undefined instance methods called in expressions
 // - undefined context functions called in expressions
+// - extra arguments passed to methods and context functions
 // - incompatible method arguments in expressions
 // - arithmetic type errors in expressions
 // - invalid computed property references and calls to non-method members
@@ -173,6 +174,17 @@ function analyzeExpression(
               .dotDotDotToken
           );
 
+        if (!isRest && node.arguments.length > parameters.length) {
+          node.arguments.slice(parameters.length).forEach((argument, index) => {
+            findings.extraArguments.push({
+              argument: toUserFacingExpression(argument.getText()),
+              argumentIndex: parameters.length + index + 1,
+              methodName: toUserFacingExpression(callee.getText()),
+              parameterCount: parameters.length
+            });
+          });
+        }
+
         node.arguments.forEach((argument, index) => {
           let parameterSymbol = parameters[index];
           let isRestArgument =
@@ -683,6 +695,7 @@ function formatReport(
     findings.undefinedProperties.length > 0 ||
     findings.undefinedContextFunctions.length > 0 ||
     findings.undefinedMethods.length > 0 ||
+    findings.extraArguments.length > 0 ||
     findings.incompatibleArguments.length > 0 ||
     findings.invalidEventHandlers.length > 0 ||
     findings.unsupportedHtmlAttributes.length > 0 ||
@@ -801,6 +814,15 @@ function formatReport(
     findings.invalidUseStateMaps.forEach(message => lines.push(`  ${message}`));
   }
 
+  if (findings.extraArguments.length > 0) {
+    lines.push('extra arguments:');
+    findings.extraArguments.forEach(finding => {
+      lines.push(
+        `  ${finding.methodName}: argument ${finding.argumentIndex} "${finding.argument}" exceeds the ${finding.parameterCount}-parameter signature`
+      );
+    });
+  }
+
   if (findings.incompatibleArguments.length > 0) {
     lines.push('incompatible arguments:');
     findings.incompatibleArguments.forEach(finding => {
@@ -1177,6 +1199,7 @@ export function lintSource(filePath, sourceText, options = {}) {
   const allMethods = collectClassMethods(classNode);
   const findings = {
     duplicateProperties,
+    extraArguments: [],
     incompatibleArguments: [],
     invalidComputedProperties: [],
     invalidDefaultValues: [],
@@ -1269,6 +1292,11 @@ export function lintSource(filePath, sourceText, options = {}) {
   });
 
   findings.duplicateProperties.sort();
+  findings.extraArguments.sort(
+    (a, b) =>
+      a.methodName.localeCompare(b.methodName) ||
+      a.argumentIndex - b.argumentIndex
+  );
   findings.incompatibleArguments.sort(
     (a, b) =>
       a.methodName.localeCompare(b.methodName) ||