wrangler 2.1.11 → 2.1.12

package/miniflare-dist/index.mjs

@@ -509,7 +509,7 @@ async function generateHandler({
           (async () => {
             try {
               const links = [];
-              const transformedResponse = new HTMLRewriter().on("link[rel=preconnect],link[rel=preload]", {
+              const transformedResponse = new HTMLRewriter().on("link[rel~=preconnect],link[rel~=preload]", {
                 element(element) {
                   for (const [attributeName] of element.attributes) {
                     if (!ALLOWED_EARLY_HINT_LINK_ATTRIBUTES.includes(

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "wrangler",
-	"version": "2.1.11",
+	"version": "2.1.12",
 	"description": "Command-line interface for all things Cloudflare Workers",
 	"keywords": [
 		"wrangler",
@@ -54,6 +54,7 @@
 		"Cloudflare_CA.pem"
 	],
 	"scripts": {
+		"assert-git-version": "node -r esbuild-register scripts/assert-git-version.ts",
 		"build": "npm run clean && npm run bundle && npm run emit-types",
 		"bundle": "node -r esbuild-register scripts/bundle.ts",
 		"check:type": "tsc",
@@ -62,7 +63,7 @@
 		"emit-types": "tsc -p tsconfig.emit.json && node -r esbuild-register scripts/emit-types.ts",
 		"prepublishOnly": "SOURCEMAPS=false npm run build",
 		"start": "npm run bundle && cross-env NODE_OPTIONS=--enable-source-maps ./bin/wrangler.js",
-		"test": "jest --silent=false --verbose=true",
+		"test": "npm run assert-git-version && jest --silent=false --verbose=true",
 		"test-watch": "npm run test -- --runInBand --testTimeout=50000 --watch",
 		"test:ci": "npm run test -- --verbose=true --coverage"
 	},
@@ -99,13 +100,13 @@
 		"@cloudflare/kv-asset-handler": "^0.2.0",
 		"@esbuild-plugins/node-globals-polyfill": "^0.1.1",
 		"@esbuild-plugins/node-modules-polyfill": "^0.1.4",
-		"@miniflare/core": "2.9.0",
-		"@miniflare/d1": "2.9.0",
-		"@miniflare/durable-objects": "2.9.0",
+		"@miniflare/core": "2.10.0",
+		"@miniflare/d1": "2.10.0",
+		"@miniflare/durable-objects": "2.10.0",
 		"blake3-wasm": "^2.1.5",
 		"chokidar": "^3.5.3",
 		"esbuild": "0.14.51",
-		"miniflare": "2.9.0",
+		"miniflare": "2.10.0",
 		"nanoid": "^3.3.3",
 		"path-to-regexp": "^6.2.0",
 		"selfsigned": "^2.0.1",

package/src/__tests__/d1.test.ts

@@ -0,0 +1,70 @@
+import { mockAccountId } from "./helpers/mock-account-id";
+import { mockConsoleMethods } from "./helpers/mock-console";
+import { runWrangler } from "./helpers/run-wrangler";
+
+function endEventLoop() {
+	return new Promise((resolve) => setImmediate(resolve));
+}
+
+describe("d1", () => {
+	const std = mockConsoleMethods();
+
+	mockAccountId();
+
+	it("should show help when no argument is passed", async () => {
+		await runWrangler("d1");
+		await endEventLoop();
+
+		expect(std.out).toMatchInlineSnapshot(`
+		"wrangler d1
+
+		🗄  Interact with a D1 database
+
+		Commands:
+		  wrangler d1 list            List D1 databases
+		  wrangler d1 create <name>   Create D1 database
+		  wrangler d1 delete <name>   Delete D1 database
+		  wrangler d1 backup          Interact with D1 Backups
+		  wrangler d1 execute <name>  Executed command or SQL file
+
+		Flags:
+		  -c, --config   Path to .toml configuration file  [string]
+		  -h, --help     Show help  [boolean]
+		  -v, --version  Show version number  [boolean]
+
+		🚧 'wrangler d1 <command>' is a beta command. Please report any issues to https://github.com/cloudflare/wrangler2/issues/new/choose"
+	`);
+	});
+
+	it("should show help when an invalid argument is passed", async () => {
+		await expect(() => runWrangler("d1 asdf")).rejects.toThrow(
+			"Unknown argument: asdf"
+		);
+
+		expect(std.err).toMatchInlineSnapshot(`
+		"X [ERROR] Unknown argument: asdf
+
+		"
+	`);
+		expect(std.out).toMatchInlineSnapshot(`
+		"
+		wrangler d1
+
+		🗄  Interact with a D1 database
+
+		Commands:
+		  wrangler d1 list            List D1 databases
+		  wrangler d1 create <name>   Create D1 database
+		  wrangler d1 delete <name>   Delete D1 database
+		  wrangler d1 backup          Interact with D1 Backups
+		  wrangler d1 execute <name>  Executed command or SQL file
+
+		Flags:
+		  -c, --config   Path to .toml configuration file  [string]
+		  -h, --help     Show help  [boolean]
+		  -v, --version  Show version number  [boolean]
+
+		🚧 'wrangler d1 <command>' is a beta command. Please report any issues to https://github.com/cloudflare/wrangler2/issues/new/choose"
+	`);
+	});
+});

package/src/__tests__/dev.test.tsx

@@ -301,7 +301,10 @@ describe("wrangler dev", () => {
 			writeWranglerToml({
 				main: "index.js",
 				routes: [
-					{ pattern: "https://some-domain.com/*", zone_name: "some-zone.com" },
+					{
+						pattern: "https://some-zone.com/*",
+						zone_name: "some-zone.com",
+					},
 				],
 			});
 			fs.writeFileSync("index.js", `export default {};`);

package/src/__tests__/helpers/mock-kv.ts

@@ -1,5 +1,5 @@
 import { createFetchResult, setMockRawResponse } from "./mock-cfetch";
-import type { NamespaceKeyInfo } from "../../kv";
+import type { NamespaceKeyInfo } from "../../kv/helpers";
 
 export function mockKeyListRequest(
 	expectedNamespaceId: string,

package/src/__tests__/kv.test.ts

@@ -17,7 +17,11 @@ import { mockGetMemberships } from "./helpers/mock-oauth-flow";
 import { mockProcess } from "./helpers/mock-process";
 import { runInTempDir } from "./helpers/run-in-tmp";
 import { runWrangler } from "./helpers/run-wrangler";
-import type { KeyValue, KVNamespaceInfo, NamespaceKeyInfo } from "../kv";
+import type {
+	KeyValue,
+	KVNamespaceInfo,
+	NamespaceKeyInfo,
+} from "../kv/helpers";
 
 describe("wrangler", () => {
 	mockAccountId();

package/src/__tests__/publish.test.ts

@@ -28,8 +28,8 @@ import { writeWorkerSource } from "./helpers/write-worker-source";
 import writeWranglerToml from "./helpers/write-wrangler-toml";
 import type { Config } from "../config";
 import type { WorkerMetadata } from "../create-worker-upload-form";
-import type { KVNamespaceInfo } from "../kv";
-import type { CustomDomainChangeset, CustomDomain } from "../publish";
+import type { KVNamespaceInfo } from "../kv/helpers";
+import type { CustomDomainChangeset, CustomDomain } from "../publish/publish";
 import type { CfWorkerInit } from "../worker";
 import type { FormData, File } from "undici";
 
@@ -400,17 +400,17 @@ describe("publish", () => {
 				await expect(
 					runWrangler("publish index.js --env some-env --legacy-env true")
 				).rejects.toThrowErrorMatchingInlineSnapshot(`
-                "Processing wrangler.toml configuration:
-                  - No environment found in configuration with name \\"some-env\\".
-                    Before using \`--env=some-env\` there should be an equivalent environment section in the configuration.
-                    The available configured environment names are: [\\"other-env\\"]
+			                "Processing wrangler.toml configuration:
+			                  - No environment found in configuration with name \\"some-env\\".
+			                    Before using \`--env=some-env\` there should be an equivalent environment section in the configuration.
+			                    The available configured environment names are: [\\"other-env\\"]
 
-                    Consider adding an environment configuration section to the wrangler.toml file:
-                    \`\`\`
-                    [env.some-env]
-                    \`\`\`
-                "
-              `);
+			                    Consider adding an environment configuration section to the wrangler.toml file:
+			                    \`\`\`
+			                    [env.some-env]
+			                    \`\`\`
+			                "
+		              `);
 			});
 
 			it("should throw an error w/ helpful message when using --env --name", async () => {
@@ -790,9 +790,9 @@ describe("publish", () => {
 			});
 			await expect(runWrangler("publish ./index --env=staging")).rejects
 				.toThrowErrorMatchingInlineSnapshot(`
-              "Service environments combined with an API token that doesn't have 'All Zones' permissions is not supported.
-              Either turn off service environments by setting \`legacy_env = true\`, creating an API token with 'All Zones' permissions, or logging in via OAuth"
-            `);
+			              "Service environments combined with an API token that doesn't have 'All Zones' permissions is not supported.
+			              Either turn off service environments by setting \`legacy_env = true\`, creating an API token with 'All Zones' permissions, or logging in via OAuth"
+		            `);
 		});
 
 		describe("custom domains", () => {
@@ -1180,11 +1180,11 @@ Update them to point to this script instead?`,
 			});
 			await expect(runWrangler("publish")).rejects
 				.toThrowErrorMatchingInlineSnapshot(`
-              "Processing wrangler.toml configuration:
-                - Don't define both the \`main\` and \`build.upload.main\` fields in your configuration.
-                  They serve the same purpose: to point to the entry-point of your worker.
-                  Delete the \`build.upload.main\` and \`build.upload.dir\` field from your config."
-            `);
+			              "Processing wrangler.toml configuration:
+			                - Don't define both the \`main\` and \`build.upload.main\` fields in your configuration.
+			                  They serve the same purpose: to point to the entry-point of your worker.
+			                  Delete the \`build.upload.main\` and \`build.upload.dir\` field from your config."
+		            `);
 		});
 
 		it("should be able to transpile TypeScript (esm)", async () => {
@@ -1375,9 +1375,9 @@ addEventListener('fetch', event => {});`
 
 			await expect(runWrangler("publish ./index.js")).rejects
 				.toThrowErrorMatchingInlineSnapshot(`
-              "Processing wrangler.toml configuration:
-                - \\"site.bucket\\" is a required field."
-            `);
+			              "Processing wrangler.toml configuration:
+			                - \\"site.bucket\\" is a required field."
+		            `);
 
 			expect(std.out).toMatchInlineSnapshot(`
 			        "
@@ -1521,11 +1521,11 @@ addEventListener('fetch', event => {});`
 
 			await expect(runWrangler("publish")).rejects
 				.toThrowErrorMatchingInlineSnapshot(`
-              "Processing wrangler.toml configuration:
-                - Don't define both the \`main\` and \`site.entry-point\` fields in your configuration.
-                  They serve the same purpose: to point to the entry-point of your worker.
-                  Delete the deprecated \`site.entry-point\` field from your config."
-            `);
+			              "Processing wrangler.toml configuration:
+			                - Don't define both the \`main\` and \`site.entry-point\` fields in your configuration.
+			                  They serve the same purpose: to point to the entry-point of your worker.
+			                  Delete the deprecated \`site.entry-point\` field from your config."
+		            `);
 		});
 
 		it("should error if there is no entry-point specified", async () => {
@@ -3301,7 +3301,7 @@ addEventListener('fetch', event => {});`
 			expect(std.err).toMatchInlineSnapshot(`""`);
 		});
 
-		it("should error politely when publishing to workers_dev when there is no workers.dev subdomain", async () => {
+		it("should offer to create a new workers.dev subdomain when publishing to workers_dev without one", async () => {
 			writeWranglerToml({
 				workers_dev: true,
 			});
@@ -3309,12 +3309,16 @@ addEventListener('fetch', event => {});`
 			mockUploadWorkerRequest();
 			mockSubDomainRequest("does-not-exist", false);
 
+			mockConfirm({
+				text: `Would you like to register a workers.dev subdomain now?`,
+				result: false,
+			});
+
 			await expect(runWrangler("publish ./index")).rejects
 				.toThrowErrorMatchingInlineSnapshot(`
-              "Error: You need to register a workers.dev subdomain before publishing to workers.dev
-              You can either publish your worker to one or more routes by specifying them in wrangler.toml, or register a workers.dev subdomain here:
-              https://dash.cloudflare.com/some-account-id/workers/onboarding"
-            `);
+			"You can either publish your worker to one or more routes by specifying them in wrangler.toml, or register a workers.dev subdomain here:
+			https://dash.cloudflare.com/some-account-id/workers/onboarding"
+		`);
 		});
 
 		it("should not deploy to workers.dev if there are any routes defined", async () => {
@@ -3667,6 +3671,31 @@ addEventListener('fetch', event => {});`
 				`console.log(789);`
 			);
 		});
+
+		it("can be overridden with cli args containing colons", async () => {
+			writeWranglerToml({
+				main: "index.js",
+				define: {
+					abc: "123",
+				},
+			});
+			fs.writeFileSync(
+				"index.js",
+				`
+				console.log(abc);
+			`
+			);
+			mockSubDomainRequest();
+			mockUploadWorkerRequest();
+			await runWrangler(
+				"publish --dry-run --outdir dist --define abc:'https://www.abc.net.au/news/'"
+			);
+
+			expect(fs.readFileSync("dist/index.js", "utf-8")).toContain(
+				// eslint-disable-next-line no-useless-escape
+				`console.log(\"https://www.abc.net.au/news/\");`
+			);
+		});
 	});
 	describe("custom builds", () => {
 		beforeEach(() => {
@@ -3734,9 +3763,9 @@ addEventListener('fetch', event => {});`
 
 			await expect(runWrangler("publish index.js")).rejects
 				.toThrowErrorMatchingInlineSnapshot(`
-              "The expected output file at \\"index.js\\" was not found after running custom build: node -e \\"console.log('custom build');\\".
-              The \`main\` property in wrangler.toml should point to the file generated by the custom build."
-            `);
+			              "The expected output file at \\"index.js\\" was not found after running custom build: node -e \\"console.log('custom build');\\".
+			              The \`main\` property in wrangler.toml should point to the file generated by the custom build."
+		            `);
 			expect(std.out).toMatchInlineSnapshot(`
 			        "Running custom build: node -e \\"console.log('custom build');\\"
 
@@ -3766,16 +3795,16 @@ addEventListener('fetch', event => {});`
 
 			await expect(runWrangler("publish")).rejects
 				.toThrowErrorMatchingInlineSnapshot(`
-              "The expected output file at \\".\\" was not found after running custom build: node -e \\"console.log('custom build');\\".
-              The \`main\` property in wrangler.toml should point to the file generated by the custom build.
-              The provided entry-point path, \\".\\", points to a directory, rather than a file.
-
-              Did you mean to set the main field to one of:
-              \`\`\`
-              main = \\"./worker.js\\"
-              main = \\"./dist/index.ts\\"
-              \`\`\`"
-            `);
+			              "The expected output file at \\".\\" was not found after running custom build: node -e \\"console.log('custom build');\\".
+			              The \`main\` property in wrangler.toml should point to the file generated by the custom build.
+			              The provided entry-point path, \\".\\", points to a directory, rather than a file.
+
+			              Did you mean to set the main field to one of:
+			              \`\`\`
+			              main = \\"./worker.js\\"
+			              main = \\"./dist/index.ts\\"
+			              \`\`\`"
+		            `);
 			expect(std.out).toMatchInlineSnapshot(`
 			        "Running custom build: node -e \\"console.log('custom build');\\"
 
@@ -5538,12 +5567,12 @@ addEventListener('fetch', event => {});`
 
 				await expect(runWrangler("publish index.js")).rejects
 					.toThrowErrorMatchingInlineSnapshot(`
-                              "You seem to be trying to use Durable Objects in a Worker written as a service-worker.
-                              You can use Durable Objects defined in other Workers by specifying a \`script_name\` in your wrangler.toml, where \`script_name\` is the name of the Worker that implements that Durable Object. For example:
-                              { name = EXAMPLE_DO_BINDING, class_name = ExampleDurableObject } ==> { name = EXAMPLE_DO_BINDING, class_name = ExampleDurableObject, script_name = example-do-binding-worker }
-                              Alternatively, migrate your worker to ES Module syntax to implement a Durable Object in this Worker:
-                              https://developers.cloudflare.com/workers/learning/migrating-to-module-workers/"
-                          `);
+			                              "You seem to be trying to use Durable Objects in a Worker written as a service-worker.
+			                              You can use Durable Objects defined in other Workers by specifying a \`script_name\` in your wrangler.toml, where \`script_name\` is the name of the Worker that implements that Durable Object. For example:
+			                              { name = EXAMPLE_DO_BINDING, class_name = ExampleDurableObject } ==> { name = EXAMPLE_DO_BINDING, class_name = ExampleDurableObject, script_name = example-do-binding-worker }
+			                              Alternatively, migrate your worker to ES Module syntax to implement a Durable Object in this Worker:
+			                              https://developers.cloudflare.com/workers/learning/migrating-to-module-workers/"
+		                          `);
 			});
 		});
 

package/src/__tests__/r2.test.ts

@@ -5,7 +5,7 @@ import { mockConsoleMethods } from "./helpers/mock-console";
 import { msw, mswSuccessR2handlers } from "./helpers/msw";
 import { runInTempDir } from "./helpers/run-in-tmp";
 import { runWrangler } from "./helpers/run-wrangler";
-import type { R2BucketInfo } from "../r2";
+import type { R2BucketInfo } from "../r2/helpers";
 
 describe("r2", () => {
 	const std = mockConsoleMethods();

package/src/__tests__/secret.test.ts

@@ -167,12 +167,12 @@ describe("wrangler secret", () => {
 				expect(std.err).toMatchInlineSnapshot(`
 			"X [ERROR] 🚨 Error uploading secret for key: secret-name-1:
 
-			  										Failed to create secret 1
+			                  Failed to create secret 1
 
 
 			X [ERROR] 🚨 Error uploading secret for key: secret-name-2:
 
-			  										Failed to create secret 2
+			                  Failed to create secret 2
 
 			"
 		`);
@@ -226,22 +226,22 @@ describe("wrangler secret", () => {
 				expect(std.err).toMatchInlineSnapshot(`
 			"X [ERROR] 🚨 Error uploading secret for key: secret-name-1:
 
-			  										Failed to create secret 1
+			                  Failed to create secret 1
 
 
 			X [ERROR] 🚨 Error uploading secret for key: secret-name-3:
 
-			  										Failed to create secret 3
+			                  Failed to create secret 3
 
 
 			X [ERROR] 🚨 Error uploading secret for key: secret-name-5:
 
-			  										Failed to create secret 5
+			                  Failed to create secret 5
 
 
 			X [ERROR] 🚨 Error uploading secret for key: secret-name-7:
 
-			  										Failed to create secret 7
+			                  Failed to create secret 7
 
 			"
 		`);

package/src/__tests__/tail.test.ts

@@ -13,7 +13,7 @@ import type {
 	RequestEvent,
 	ScheduledEvent,
 	AlarmEvent,
-} from "../tail";
+} from "../tail/createTail";
 import type { RequestInit } from "undici";
 import type WebSocket from "ws";
 

package/src/__tests__/utils-collectKeyValues.test.ts

@@ -0,0 +1,47 @@
+import { collectKeyValues } from "../utils/collectKeyValues";
+
+describe("collectKeyValues()", () => {
+	it("should return an empty object when passed undefined", () => {
+		expect(collectKeyValues(undefined)).toEqual({});
+	});
+
+	it("should return an empty object when passed an empty array", () => {
+		expect(collectKeyValues([])).toEqual({});
+	});
+
+	it("should parse a key:value string with no value by returning an empty string for the value", () => {
+		expect(collectKeyValues(["some-string-with-no-colon"])).toEqual({
+			"some-string-with-no-colon": "",
+		});
+	});
+
+	it("should return an object with a single key/value pair when passed an array with a single string", () => {
+		expect(collectKeyValues(["some-key:some-value"])).toEqual({
+			"some-key": "some-value",
+		});
+	});
+
+	it("should return an object with multiple key/value pairs when passed an array with multiple strings", () => {
+		expect(
+			collectKeyValues([
+				"some-key:some-value",
+				"some-other-key:some-other-value",
+			])
+		).toEqual({
+			"some-key": "some-value",
+			"some-other-key": "some-other-value",
+		});
+	});
+
+	it("should return an object with multiple key/value pairs when passed an array with multiple strings with multiple colons", () => {
+		expect(
+			collectKeyValues([
+				"some-key:https://some-value.com",
+				"some-other-key:https://some-other-value.com",
+			])
+		).toEqual({
+			"some-key": "https://some-value.com",
+			"some-other-key": "https://some-other-value.com",
+		});
+	});
+});

package/src/d1/index.ts

@@ -6,7 +6,7 @@ import * as List from "./list";
 import { d1BetaWarning } from "./utils";
 import type { Argv } from "yargs";
 
-export const d1api = (yargs: Argv) => {
+export const d1 = (yargs: Argv) => {
 	return (
 		yargs
 			.command("list", "List D1 databases", List.Options, List.Handler)