wrangler 2.1.0 → 2.1.3

package/miniflare-dist/index.mjs

@@ -6033,7 +6033,7 @@ async function generateAssetsFetch(directory, log) {
   let metadata = createMetadataObject({
     redirects,
     headers,
-    logger: log.warn
+    logger: log.warn.bind(log)
   });
   watch([headersFile, redirectsFile], { persistent: true }).on(
     "change",

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "wrangler",
-	"version": "2.1.0",
+	"version": "2.1.3",
 	"description": "Command-line interface for all things Cloudflare Workers",
 	"keywords": [
 		"wrangler",
@@ -148,6 +148,7 @@
 		"jest-fetch-mock": "^3.0.3",
 		"jest-websocket-mock": "^2.3.0",
 		"mime": "^3.0.0",
+		"msw": "^0.47.1",
 		"open": "^8.4.0",
 		"p-queue": "^7.2.0",
 		"pretty-bytes": "^6.0.0",

package/src/__tests__/dev.test.tsx

@@ -1025,7 +1025,8 @@ describe("wrangler dev", () => {
 			  -l, --local                                      Run on my machine  [boolean] [default: false]
 			      --minify                                     Minify the script  [boolean]
 			      --node-compat                                Enable node.js compatibility  [boolean]
-			      --experimental-enable-local-persistence      Enable persistence for this session (only for local mode)  [boolean]
+			      --persist                                    Enable persistence for local mode, using default path: .wrangler/state  [boolean]
+			      --persist-to                                 Specify directory to use for local persistence (implies --persist)  [string]
 			      --inspect                                    Enable dev tools  [deprecated] [boolean]",
 			  "warn": "",
 			}

package/src/__tests__/dialogs.test.tsx

@@ -0,0 +1,40 @@
+jest.unmock("../dialogs");
+import { fromDashMessagePrompt } from "../dialogs";
+import { CI } from "../is-ci";
+
+describe("fromDashMessagePrompt", () => {
+	it("should return undefined in CI when last deployed from api", async () => {
+		//in CI
+		jest.spyOn(CI, "isCI").mockReturnValue(true);
+		const result = await fromDashMessagePrompt("api");
+		expect(result).toBe(undefined);
+	});
+
+	it("should return undefined in CI when last deployed from wrangler", async () => {
+		//in CI
+		jest.spyOn(CI, "isCI").mockReturnValue(true);
+		const result = await fromDashMessagePrompt("wrangler");
+		expect(result).toBe(undefined);
+	});
+
+	it("should return true in CI when last deployed from dash", async () => {
+		//in CI
+		jest.spyOn(CI, "isCI").mockReturnValue(true);
+		const result = await fromDashMessagePrompt("dash");
+		expect(result).toBe(true);
+	});
+
+	it("should return undefined when last deployed from api", async () => {
+		//not in CI
+		jest.spyOn(CI, "isCI").mockReturnValue(false);
+		const result = await fromDashMessagePrompt("api");
+		expect(result).toBe(undefined);
+	});
+
+	it("should return undefined when last deployed from wrangler", async () => {
+		//not in CI
+		jest.spyOn(CI, "isCI").mockReturnValue(false);
+		const result = await fromDashMessagePrompt("wrangler");
+		expect(result).toBe(undefined);
+	});
+});

package/src/__tests__/helpers/mock-cfetch.ts

@@ -4,8 +4,24 @@ import { pathToRegexp } from "path-to-regexp";
 import { Response } from "undici";
 import { getCloudflareApiBaseUrl } from "../../cfetch";
 import type { FetchResult, FetchError } from "../../cfetch";
+import type { fetchInternal, fetchR2Objects } from "../../cfetch/internal";
 import type { RequestInit, BodyInit, HeadersInit } from "undici";
 
+/**
+ * When the custom mocks fallthrough in tests because they aren't set, instead of throwing an error,
+ * we use real fetch to make the request which will use Mock Service Workers.
+ */
+const {
+	fetchInternal: realFetchInternal,
+}: { fetchInternal: typeof fetchInternal } = jest.requireActual(
+	"../../cfetch/internal"
+);
+const {
+	fetchR2Objects: realFetchR2Objects,
+}: { fetchR2Objects: typeof fetchR2Objects } = jest.requireActual(
+	"../../cfetch/internal"
+);
+
 /**
  * The signature of the function that will handle a mock request.
  */
@@ -34,7 +50,7 @@ const mocks: MockFetch<unknown>[] = [];
 export async function mockFetchInternal(
 	resource: string,
 	init: RequestInit = {},
-	queryParams: URLSearchParams = new URLSearchParams()
+	queryParams: URLSearchParams | undefined
 ) {
 	for (const { regexp, method, handler } of mocks) {
 		const resourcePath = new URL(resource, getCloudflareApiBaseUrl()).pathname;
@@ -43,12 +59,13 @@ export async function mockFetchInternal(
 		if (uri !== null && (!method || method === (init.method ?? "GET"))) {
 			// The `resource` regular expression will extract the labelled groups from the URL.
 			// These are passed through to the `handler` call, to allow it to do additional checks or behaviour.
-			return await handler(uri, init, queryParams); // TODO: should we have some kind of fallthrough system? we'll see.
+			return await handler(uri, init, queryParams ?? new URLSearchParams()); // TODO: should we have some kind of fallthrough system? we'll see.
 		}
 	}
-	throw new Error(
-		`no mocks found for ${init.method ?? "any HTTP"} request to ${resource}`
-	);
+
+	// let it fall through to mock-service-worker
+	// (do a real, unmocked fetch)
+	return await realFetchInternal(resource, init, queryParams);
 }
 
 /**
@@ -221,21 +238,24 @@ export async function mockFetchR2Objects(
 		method: "PUT" | "GET" | "DELETE";
 	}
 ): Promise<Response> {
-	/**
-	 * Here we destroy & removeListeners to "drain" the stream, for testing purposes
-	 * mimicking the fetch request taking in the stream and draining it.
-	 */
-	if (bodyInit.body instanceof Readable) {
-		bodyInit.body.destroy();
-		bodyInit.body.removeAllListeners();
-	}
-
 	if (r2GetMocks.has(resource)) {
+		/**
+		 * Here we destroy & removeListeners to "drain" the stream, for testing purposes
+		 * mimicking the fetch request taking in the stream and draining it.
+		 */
+		if (bodyInit.body instanceof Readable) {
+			bodyInit.body.destroy();
+			bodyInit.body.removeAllListeners();
+		}
+
 		const value = r2GetMocks.get(resource);
 
 		return new Response(value);
 	}
-	throw new Error(`no mock found for \`r2 object\` - ${resource}`);
+
+	// No mocks found for ${init.method ?? "any HTTP"} request to ${resource}
+	// let it fall through to Mock Service Worker with a real fetch.
+	return await realFetchR2Objects(resource, bodyInit);
 }
 
 /**

package/src/__tests__/helpers/msw/handlers/index.ts

@@ -0,0 +1,13 @@
+// barrel import for msw handlers
+import { mswNamespacesHandlers } from "./namespaces";
+import { mswOauthHandlers } from "./oauth";
+import { mswR2handlers } from "./r2";
+import { mswUserHandlers } from "./user";
+
+// All the handlers are used in msw/index for setting up the server
+export const mswDefaultHandlers = [
+	...mswOauthHandlers,
+	...mswR2handlers,
+	...mswUserHandlers,
+	...mswNamespacesHandlers,
+];

package/src/__tests__/helpers/msw/handlers/namespaces.ts

@@ -0,0 +1,104 @@
+import { rest } from "msw";
+
+export const mswNamespacesHandlers = [
+	rest.post(
+		"*/accounts/:accountId/workers/dispatch/namespaces",
+		(request, response, context) => {
+			return response(
+				context.status(200),
+				context.json({
+					success: true,
+					errors: [],
+					messages: [],
+					result: {
+						namespace_id: "some-namespace-id",
+						namespace_name: "namespace-name",
+						created_on: "2022-06-29T14:30:08.16152Z",
+						created_by: "1fc1df98cc4420fe00367c3ab68c1639",
+						modified_on: "2022-06-29T14:30:08.16152Z",
+						modified_by: "1fc1df98cc4420fe00367c3ab68c1639",
+					},
+				})
+			);
+		}
+	),
+	rest.delete(
+		"*/accounts/:accountId/workers/dispatch/namespaces/:namespaceName",
+		(_, response, context) => {
+			return response(
+				context.status(200),
+				context.json({
+					success: true,
+					errors: [],
+					messages: [],
+					result: null,
+				})
+			);
+		}
+	),
+	rest.put(
+		"*/accounts/:accountId/workers/dispatch/namespaces/:namespaceName",
+		(_, response, context) => {
+			return response(
+				context.status(200),
+				context.json({
+					success: true,
+					errors: [],
+					messages: [],
+					result: {
+						namespace_id: "some-namespace-id",
+						namespace_name: "namespace-name",
+						created_on: "2022-06-29T14:30:08.16152Z",
+						created_by: "1fc1df98cc4420fe00367c3ab68c1639",
+						modified_on: "2022-06-29T14:30:08.16152Z",
+						modified_by: "1fc1df98cc4420fe00367c3ab68c1639",
+					},
+				})
+			);
+		}
+	),
+	rest.get(
+		"*/accounts/:accountId/workers/dispatch/namespaces/:namespaceName",
+		(_, response, context) => {
+			return response(
+				context.status(200),
+				context.json({
+					success: true,
+					errors: [],
+					messages: [],
+					result: {
+						namespace_id: "some-namespace-id",
+						namespace_name: "namespace-name",
+						created_on: "2022-06-29T14:30:08.16152Z",
+						created_by: "1fc1df98cc4420fe00367c3ab68c1639",
+						modified_on: "2022-06-29T14:30:08.16152Z",
+						modified_by: "1fc1df98cc4420fe00367c3ab68c1639",
+					},
+				})
+			);
+		}
+	),
+	rest.get(
+		"*/accounts/:accountId/workers/dispatch/namespaces",
+		(_, response, context) => {
+			return response(
+				context.status(200),
+				context.json({
+					success: true,
+					errors: [],
+					messages: [],
+					result: [
+						{
+							namespace_id: "some-namespace-id",
+							namespace_name: "namespace-name",
+							created_on: "2022-06-29T14:30:08.16152Z",
+							created_by: "1fc1df98cc4420fe00367c3ab68c1639",
+							modified_on: "2022-06-29T14:30:08.16152Z",
+							modified_by: "1fc1df98cc4420fe00367c3ab68c1639",
+						},
+					],
+				})
+			);
+		}
+	),
+];

package/src/__tests__/helpers/msw/handlers/oauth.ts

@@ -0,0 +1,36 @@
+import { rest } from "msw";
+
+export const mswOauthHandlers = [
+	rest.all("*/oauth/callback", (_, response, context) => {
+		return response(
+			context.status(200),
+			context.json({
+				success: true,
+				errors: [],
+				messages: [],
+				code: "test-oauth-code",
+			})
+		);
+	}),
+	// revoke access token
+	rest.post(
+		"https://dash.cloudflare.com/oauth2/revoke",
+		(_, response, context) => response(context.status(200), context.text(""))
+	),
+
+	// exchange (auth code | refresh token) for access token
+	rest.post(
+		"https://dash.cloudflare.com/oauth2/token",
+		(_, response, context) => {
+			return response(
+				context.status(200),
+				context.json({
+					access_token: "test-access-token",
+					expires_in: 100000,
+					refresh_token: "test-refresh-token",
+					scope: "account:read",
+				})
+			);
+		}
+	),
+];

package/src/__tests__/helpers/msw/handlers/r2.ts

@@ -0,0 +1,80 @@
+import { rest } from "msw";
+
+export const mswR2handlers = [
+	// List endpoint r2Buckets
+	rest.get("*/accounts/:accountId/r2/buckets", (_, response, context) =>
+		response(
+			context.status(200),
+			context.json({
+				success: true,
+				errors: [],
+				messages: [],
+				result: {
+					buckets: [
+						{ name: "bucket-1", creation_date: "01-01-2001" },
+						{ name: "bucket-2", creation_date: "01-01-2001" },
+					],
+				},
+			})
+		)
+	),
+	rest.post("*/accounts/:accountId/r2/buckets", (_, response, context) =>
+		response(
+			context.status(200),
+			context.json({ success: true, errors: [], messages: [], result: {} })
+		)
+	),
+	rest.put(
+		"*/accounts/:accountId/r2/buckets/:bucketName",
+		(_, response, context) =>
+			response(
+				context.status(200),
+				context.json({ success: true, errors: [], messages: [], result: {} })
+			)
+	),
+	rest.delete(
+		"*/accounts/:accountId/r2/buckets/:bucketName",
+		(_, response, context) =>
+			response(
+				context.status(200),
+				context.json({ success: true, errors: [], messages: [], result: null })
+			)
+	),
+	rest.get(
+		"*/accounts/:accountId/r2/buckets/:bucketName/objects/:objectName",
+		(_, response, context) => {
+			const imageBuffer = Buffer.from("wormhole-img.png");
+			return response(
+				context.set("Content-Length", imageBuffer.byteLength.toString()),
+				context.set("Content-Type", "image/png"),
+				context.status(200),
+				context.body(imageBuffer)
+			);
+		}
+	),
+	rest.put(
+		"*/accounts/:accountId/r2/buckets/:bucketName/objects/:objectName",
+		(_, response, context) =>
+			response(
+				context.status(200),
+				context.json({
+					success: true,
+					errors: [],
+					messages: [],
+					result: {
+						accountId: "some-account-id",
+						bucketName: "bucketName-object-test",
+						objectName: "wormhole-img.png",
+					},
+				})
+			)
+	),
+	rest.delete(
+		"*/accounts/:accountId/r2/buckets/:bucketName/objects/:objectName",
+		(_, response, context) =>
+			response(
+				context.status(200),
+				context.json({ success: true, errors: [], messages: [], result: null })
+			)
+	),
+];

package/src/__tests__/helpers/msw/handlers/user.ts

@@ -0,0 +1,63 @@
+import { rest } from "msw";
+
+export const mswUserHandlers = [
+	rest.get("*/user", (_, res, cxt) => {
+		return res(
+			cxt.status(200),
+			cxt.json({
+				success: true,
+				errors: [],
+				messages: [],
+				result: {
+					id: "7c5dae5552338874e5053f2534d2767a",
+					email: "user@example.com",
+					first_name: "John",
+					last_name: "Appleseed",
+					username: "cfuser12345",
+					telephone: "+1 123-123-1234",
+					country: "US",
+					zipcode: "12345",
+					created_on: "2014-01-01T05:20:00Z",
+					modified_on: "2014-01-01T05:20:00Z",
+					two_factor_authentication_enabled: false,
+					suspended: false,
+				},
+			})
+		);
+	}),
+	rest.get("*/accounts", (_, res, cxt) => {
+		return res(
+			cxt.status(200),
+			cxt.json({
+				success: true,
+				errors: [],
+				messages: [],
+				result: [
+					{ name: "Account One", id: "account-1" },
+					{ name: "Account Two", id: "account-2" },
+					{ name: "Account Three", id: "account-3" },
+				],
+			})
+		);
+	}),
+	rest.get("*/memberships", (_, response, context) => {
+		return response(
+			context.status(200),
+			context.json({
+				success: true,
+				errors: [],
+				messages: [],
+				result: [
+					{
+						id: "membership-id-1",
+						account: { id: "account-id-1", name: "My Personal Account" },
+					},
+					{
+						id: "membership-id-2",
+						account: { id: "account-id-2", name: "Enterprise Account" },
+					},
+				],
+			})
+		);
+	}),
+];

package/src/__tests__/helpers/msw/index.ts

@@ -0,0 +1,4 @@
+import { setupServer } from "msw/node";
+import { mswDefaultHandlers } from "./handlers";
+
+export const msw = setupServer(...mswDefaultHandlers);

package/src/__tests__/index.test.ts

@@ -36,6 +36,7 @@ describe("wrangler", () => {
 			  wrangler publish [script]    🆙 Publish your Worker to Cloudflare.
 			  wrangler tail [worker]       🦚 Starts a log tailing session for a published Worker.
 			  wrangler secret              🤫 Generate a secret that can be referenced in a Worker
+			  wrangler secret:bulk <json>  🗄️ Bulk upload secrets for a Worker
 			  wrangler kv:namespace        🗂️  Interact with your Workers KV Namespaces
 			  wrangler kv:key              🔑 Individually manage Workers KV key-value pairs
 			  wrangler kv:bulk             💪 Interact with multiple Workers KV key-value pairs at once
@@ -75,6 +76,7 @@ describe("wrangler", () => {
 			  wrangler publish [script]    🆙 Publish your Worker to Cloudflare.
 			  wrangler tail [worker]       🦚 Starts a log tailing session for a published Worker.
 			  wrangler secret              🤫 Generate a secret that can be referenced in a Worker
+			  wrangler secret:bulk <json>  🗄️ Bulk upload secrets for a Worker
 			  wrangler kv:namespace        🗂️  Interact with your Workers KV Namespaces
 			  wrangler kv:key              🔑 Individually manage Workers KV key-value pairs
 			  wrangler kv:bulk             💪 Interact with multiple Workers KV key-value pairs at once

package/src/__tests__/jest.setup.ts

@@ -14,6 +14,7 @@ import {
 	mockFetchR2Objects,
 } from "./helpers/mock-cfetch";
 import { MockWebSocket } from "./helpers/mock-web-socket";
+import { msw } from "./helpers/msw";
 
 /**
  * The relative path between the bundled code and the Wrangler package.
@@ -57,6 +58,21 @@ fetchMock.doMock(() => {
 
 jest.mock("../package-manager");
 
+// requests not mocked with `jest-fetch-mock` fall through
+// to `mock-service-worker`
+fetchMock.dontMock();
+beforeAll(() => {
+	msw.listen({
+		onUnhandledRequest: (request) => {
+			throw new Error(
+				`No mock found for ${request.method} ${request.url.href}`
+			);
+		},
+	});
+});
+afterEach(() => msw.resetHandlers());
+afterAll(() => msw.close());
+
 jest.mock("../cfetch/internal");
 (fetchInternal as jest.Mock).mockImplementation(mockFetchInternal);
 (fetchKVGetValue as jest.Mock).mockImplementation(mockFetchKVGetValue);

package/src/__tests__/publish.test.ts

@@ -6488,6 +6488,58 @@ addEventListener('fetch', event => {});`
 		`);
 		});
 	});
+
+	it("should publish if the last deployed source check fails", async () => {
+		unsetAllMocks();
+		writeWorkerSource();
+		writeWranglerToml();
+		mockSubDomainRequest();
+		mockUploadWorkerRequest();
+		setMockRawResponse(
+			"/accounts/:accountId/workers/services/:scriptName",
+			"GET",
+			() => {
+				return createFetchResult(null, false, [
+					{ code: 10090, message: "workers.api.error.service_not_found" },
+				]);
+			}
+		);
+
+		await runWrangler("publish index.js");
+		expect(std).toMatchInlineSnapshot(`
+		Object {
+		  "debug": "",
+		  "err": "",
+		  "out": "Total Upload: xx KiB / gzip: xx KiB
+		Uploaded test-name (TIMINGS)
+		Published test-name (TIMINGS)
+		  https://test-name.test-sub-domain.workers.dev",
+		  "warn": "",
+		}
+	`);
+	});
+
+	it("should not publish if there's any other kind of error when checking deployment source", async () => {
+		unsetAllMocks();
+		writeWorkerSource();
+		writeWranglerToml();
+		mockSubDomainRequest();
+		mockUploadWorkerRequest();
+		setMockRawResponse(
+			"/accounts/:accountId/workers/services/:scriptName",
+			"GET",
+			() => {
+				return createFetchResult(null, false, [
+					{ code: 10000, message: "Authentication error" },
+				]);
+			}
+		);
+
+		await runWrangler("publish index.js");
+		expect(std.err).toContain(
+			`A request to the Cloudflare API (/accounts/some-account-id/workers/services/test-name) failed`
+		);
+	});
 });
 
 /** Write mock assets to the file system so they can be uploaded. */