wrangler 0.0.0-ee6b413 → 0.0.0-ee6c421

package/bin/wrangler.js

@@ -6,6 +6,10 @@ const os = require("os");
 const semiver = require("semiver");
 
 const MIN_NODE_VERSION = "16.7.0";
+const debug =
+	process.env["WRANGLER_LOG"] === "debug"
+		? (...args) => console.log(...args)
+		: () => {};
 
 let wranglerProcess;
 
@@ -52,9 +56,6 @@ Consider using a Node.js version manager such as https://volta.sh/ or https://gi
 	return spawn(
 		process.execPath,
 		[
-			...(semiver(process.versions.node, "18.0.0") >= 0
-				? ["--no-experimental-fetch"] // TODO: remove this when https://github.com/cloudflare/wrangler2/issues/834 is properly fixed
-				: []),
 			"--no-warnings",
 			"--experimental-vm-modules",
 			...process.execArgv,
@@ -87,9 +88,8 @@ function runDelegatedWrangler() {
 	} = JSON.parse(fs.readFileSync(packageJsonPath));
 	const resolvedBinaryPath = path.resolve(packageJsonPath, "..", binaryPath);
 
-	console.log(
-		`Delegating to locally-installed version of wrangler @ v${version}`
-	);
+	debug(`Delegating to locally-installed version of wrangler @ v${version}`);
+
 	// this call to `spawn` is simpler because the delegated version will do all
 	// of the other work.
 	return spawn(

package/miniflare-dist/index.mjs

@@ -4846,6 +4846,13 @@ var getRequestContextCheckOptions = async () => {
 };
 
 // src/miniflare-cli/index.ts
+var NoOpLog = class extends Log {
+  log() {
+  }
+  error(message) {
+    throw message;
+  }
+};
 async function main() {
   const args = await yargs_default(hideBin(process.argv)).help(false).version(false).option("log", {
     choices: enumKeys(LogLevel)
@@ -4854,9 +4861,9 @@ async function main() {
   const requestContextCheckOptions = await getRequestContextCheckOptions();
   const config = {
     ...JSON.parse(args._[0] ?? "{}"),
-    ...requestContextCheckOptions,
-    log: new Log(logLevel)
+    ...requestContextCheckOptions
   };
+  config.log = config.disableLogs ? new NoOpLog() : new Log(logLevel);
   if (logLevel > LogLevel.INFO) {
     console.log("OPTIONS:\n", JSON.stringify(config, null, 2));
   }
@@ -4864,6 +4871,7 @@ async function main() {
   try {
     await mf.startServer();
     await mf.startScheduler();
+    process.send && process.send("ready");
   } catch (e) {
     mf.log.error(e);
     process.exitCode = 1;

package/package.json

@@ -1,17 +1,7 @@
 {
 	"name": "wrangler",
-	"version": "0.0.0-ee6b413",
-	"author": "wrangler@cloudflare.com",
+	"version": "0.0.0-ee6c421",
 	"description": "Command-line interface for all things Cloudflare Workers",
-	"bin": {
-		"wrangler": "./bin/wrangler.js",
-		"wrangler2": "./bin/wrangler.js"
-	},
-	"license": "MIT OR Apache-2.0",
-	"bugs": {
-		"url": "https://github.com/cloudflare/wrangler2/issues"
-	},
-	"homepage": "https://github.com/cloudflare/wrangler2#readme",
 	"keywords": [
 		"wrangler",
 		"cloudflare",
@@ -28,31 +18,87 @@
 		"webassembly",
 		"rust",
 		"emscripten",
-		"rust",
 		"typescript",
 		"graphql",
 		"router",
 		"http",
 		"cli"
 	],
+	"homepage": "https://github.com/cloudflare/wrangler2#readme",
+	"bugs": {
+		"url": "https://github.com/cloudflare/wrangler2/issues"
+	},
+	"license": "MIT OR Apache-2.0",
+	"author": "wrangler@cloudflare.com",
+	"main": "wrangler-dist/cli.js",
+	"types": "wrangler-dist/cli.d.ts",
+	"bin": {
+		"wrangler": "./bin/wrangler.js",
+		"wrangler2": "./bin/wrangler.js"
+	},
+	"files": [
+		"src",
+		"bin",
+		"miniflare-config-stubs",
+		"miniflare-dist",
+		"wrangler-dist",
+		"templates",
+		"vendor",
+		"import_meta_url.js",
+		"kv-asset-handler.js",
+		"Cloudflare_CA.pem"
+	],
+	"scripts": {
+		"build": "npm run clean && npm run bundle && npm run emit-types",
+		"bundle": "node -r esbuild-register scripts/bundle.ts",
+		"check:type": "tsc",
+		"clean": "rm -rf wrangler-dist miniflare-dist emitted-types",
+		"dev": "npm run clean && concurrently -c black,blue 'npm run bundle -- --watch' 'npm run check:type -- --watch --preserveWatchOutput'",
+		"emit-types": "tsc -p tsconfig.emit.json && node -r esbuild-register scripts/emit-types.ts",
+		"prepublishOnly": "SOURCEMAPS=false npm run build",
+		"start": "npm run bundle && NODE_OPTIONS=--enable-source-maps ./bin/wrangler.js",
+		"test": "jest --silent=false --verbose=true",
+		"test-watch": "npm run test -- --runInBand --testTimeout=50000 --watch"
+	},
+	"jest": {
+		"moduleNameMapper": {
+			"clipboardy": "<rootDir>/src/__tests__/helpers/clipboardy-mock.js",
+			"miniflare/cli": "<rootDir>/../../node_modules/miniflare/dist/src/cli.js"
+		},
+		"restoreMocks": true,
+		"setupFilesAfterEnv": [
+			"<rootDir>/src/__tests__/jest.setup.ts"
+		],
+		"testRegex": ".*.(test|spec)\\.[jt]sx?$",
+		"testTimeout": 30000,
+		"transform": {
+			"^.+\\.c?(t|j)sx?$": [
+				"esbuild-jest",
+				{
+					"sourcemap": true
+				}
+			]
+		},
+		"transformIgnorePatterns": [
+			"node_modules/(?!find-up|locate-path|p-locate|p-limit|p-timeout|p-queue|yocto-queue|path-exists|execa|strip-final-newline|npm-run-path|path-key|onetime|mimic-fn|human-signals|is-stream|get-port|supports-color|pretty-bytes)"
+		]
+	},
 	"dependencies": {
 		"@cloudflare/kv-asset-handler": "^0.2.0",
 		"@esbuild-plugins/node-globals-polyfill": "^0.1.1",
 		"@esbuild-plugins/node-modules-polyfill": "^0.1.4",
 		"blake3-wasm": "^2.1.5",
-		"esbuild": "0.14.34",
-		"miniflare": "^2.5.1",
+		"esbuild": "0.14.47",
+		"miniflare": "^2.6.0",
 		"nanoid": "^3.3.3",
 		"path-to-regexp": "^6.2.0",
 		"selfsigned": "^2.0.1",
 		"semiver": "^1.1.0",
 		"xxhash-wasm": "^1.0.1"
 	},
-	"optionalDependencies": {
-		"fsevents": "~2.3.2"
-	},
 	"devDependencies": {
 		"@iarna/toml": "^3.0.0",
+		"@microsoft/api-extractor": "^7.28.3",
 		"@types/command-exists": "^1.2.0",
 		"@types/glob-to-regexp": "0.4.1",
 		"@types/mime": "^2.0.3",
@@ -105,53 +151,10 @@
 		"ws": "^8.5.0",
 		"yargs": "^17.4.1"
 	},
-	"files": [
-		"src",
-		"bin",
-		"miniflare-config-stubs",
-		"miniflare-dist",
-		"wrangler-dist",
-		"templates",
-		"vendor",
-		"import_meta_url.js",
-		"kv-asset-handler.js",
-		"Cloudflare_CA.pem"
-	],
-	"scripts": {
-		"clean": "rm -rf wrangler-dist miniflare-dist",
-		"check:type": "tsc",
-		"bundle": "node -r esbuild-register scripts/bundle.ts",
-		"build": "npm run clean && npm run bundle",
-		"dev": "npm run clean && concurrently -c black,blue 'npm run bundle -- --watch' 'npm run check:type -- --watch --preserveWatchOutput'",
-		"prepublishOnly": "SOURCEMAPS=false npm run build",
-		"start": "npm run bundle && NODE_OPTIONS=--enable-source-maps ./bin/wrangler.js",
-		"test": "jest --silent=false --verbose=true",
-		"test-watch": "npm run test -- --runInBand --testTimeout=50000 --watch"
+	"optionalDependencies": {
+		"fsevents": "~2.3.2"
 	},
 	"engines": {
 		"node": ">=16.7.0"
-	},
-	"jest": {
-		"restoreMocks": true,
-		"testTimeout": 30000,
-		"testRegex": ".*.(test|spec)\\.[jt]sx?$",
-		"transformIgnorePatterns": [
-			"node_modules/(?!find-up|locate-path|p-locate|p-limit|p-timeout|p-queue|yocto-queue|path-exists|execa|strip-final-newline|npm-run-path|path-key|onetime|mimic-fn|human-signals|is-stream|get-port|supports-color|pretty-bytes)"
-		],
-		"moduleNameMapper": {
-			"clipboardy": "<rootDir>/src/__tests__/helpers/clipboardy-mock.js",
-			"miniflare/cli": "<rootDir>/../../node_modules/miniflare/dist/src/cli.js"
-		},
-		"transform": {
-			"^.+\\.c?(t|j)sx?$": [
-				"esbuild-jest",
-				{
-					"sourcemap": true
-				}
-			]
-		},
-		"setupFilesAfterEnv": [
-			"<rootDir>/src/__tests__/jest.setup.ts"
-		]
 	}
 }

package/src/__tests__/config-cache-without-cache-dir.test.ts

@@ -0,0 +1,38 @@
+import { getConfigCache, saveToConfigCache } from "../config-cache";
+import { mockConsoleMethods } from "./helpers/mock-console";
+import { runInTempDir } from "./helpers/run-in-tmp";
+
+interface PagesConfigCache {
+	account_id: string;
+	pages_project_name: string;
+}
+
+describe("config cache", () => {
+	runInTempDir();
+	mockConsoleMethods();
+	// In this set of tests, we don't create a node_modules folder
+	const pagesConfigCacheFilename = "pages-config-cache.json";
+
+	it("should return an empty config if no file exists", () => {
+		expect(
+			getConfigCache<PagesConfigCache>(pagesConfigCacheFilename)
+		).toMatchInlineSnapshot(`Object {}`);
+	});
+
+	it("should ignore attempts to cache values ", () => {
+		saveToConfigCache<PagesConfigCache>(pagesConfigCacheFilename, {
+			account_id: "some-account-id",
+			pages_project_name: "foo",
+		});
+		expect(getConfigCache<PagesConfigCache>(pagesConfigCacheFilename)).toEqual(
+			{}
+		);
+
+		saveToConfigCache<PagesConfigCache>(pagesConfigCacheFilename, {
+			pages_project_name: "bar",
+		});
+		expect(getConfigCache<PagesConfigCache>(pagesConfigCacheFilename)).toEqual(
+			{}
+		);
+	});
+});

package/src/__tests__/config-cache.test.ts

@@ -1,4 +1,6 @@
+import { mkdirSync } from "node:fs";
 import { getConfigCache, saveToConfigCache } from "../config-cache";
+import { mockConsoleMethods } from "./helpers/mock-console";
 import { runInTempDir } from "./helpers/run-in-tmp";
 
 interface PagesConfigCache {
@@ -8,6 +10,10 @@ interface PagesConfigCache {
 
 describe("config cache", () => {
 	runInTempDir();
+	mockConsoleMethods();
+	beforeEach(() => {
+		mkdirSync("node_modules");
+	});
 
 	const pagesConfigCacheFilename = "pages-config-cache.json";