wrangler 0.0.0-e95bea2 → 0.0.0-ea8e701

package/src/__tests__/publish.test.ts

@@ -1,15 +1,18 @@
 import * as fs from "node:fs";
 import * as path from "node:path";
 import * as TOML from "@iarna/toml";
+import { writeAuthConfigFile } from "../user";
 import { mockAccountId, mockApiToken } from "./helpers/mock-account-id";
 import {
   createFetchResult,
   setMockRawResponse,
   setMockResponse,
   unsetAllMocks,
+  unsetMockFetchKVGetValues,
 } from "./helpers/mock-cfetch";
 import { mockConsoleMethods } from "./helpers/mock-console";
 import { mockKeyListRequest } from "./helpers/mock-kv";
+import { mockOAuthFlow } from "./helpers/mock-oauth-flow";
 import { runInTempDir } from "./helpers/run-in-tmp";
 import { runWrangler } from "./helpers/run-wrangler";
 import writeWranglerToml from "./helpers/write-wrangler-toml";
@@ -18,24 +21,96 @@ import type { KVNamespaceInfo } from "../kv";
 import type { FormData, File } from "undici";
 
 describe("publish", () => {
+  mockAccountId();
+  mockApiToken();
+  runInTempDir({ homedir: "./home" });
+  const std = mockConsoleMethods();
+  const { mockGrantAccessToken, mockGrantAuthorization } = mockOAuthFlow();
+
   beforeEach(() => {
     // @ts-expect-error we're using a very simple setTimeout mock here
     jest.spyOn(global, "setTimeout").mockImplementation((fn, _period) => {
-      fn();
+      setImmediate(fn);
     });
   });
-  mockAccountId();
-  mockApiToken();
-  runInTempDir();
-  const std = mockConsoleMethods();
 
   afterEach(() => {
     unsetAllMocks();
+    unsetMockFetchKVGetValues();
+  });
+
+  describe("authentication", () => {
+    mockApiToken({ apiToken: null });
+    beforeEach(() => {
+      // @ts-expect-error disable the mock we'd setup earlier
+      // or else our server won't bother listening for oauth requests
+      // and will timeout and fail
+      global.setTimeout.mockRestore();
+    });
+
+    it("drops a user into the login flow if they're unauthenticated", async () => {
+      writeWranglerToml();
+      writeWorkerSource();
+      mockSubDomainRequest();
+      mockUploadWorkerRequest();
+
+      const accessTokenRequest = mockGrantAccessToken({ respondWith: "ok" });
+      mockGrantAuthorization({ respondWith: "success" });
+
+      await expect(runWrangler("publish index.js")).resolves.toBeUndefined();
+
+      expect(accessTokenRequest.actual.url).toEqual(
+        accessTokenRequest.expected.url
+      );
+
+      expect(std.out).toMatchInlineSnapshot(`
+        "Attempting to login via OAuth...
+        Successfully logged in.
+        Uploaded test-name (TIMINGS)
+        Published test-name (TIMINGS)
+          test-name.test-sub-domain.workers.dev"
+      `);
+      expect(std.warn).toMatchInlineSnapshot(`""`);
+      expect(std.err).toMatchInlineSnapshot(`""`);
+    });
+
+    it("warns a user when they're authenticated with an API token in wrangler config file", async () => {
+      writeWranglerToml();
+      writeWorkerSource();
+      mockSubDomainRequest();
+      mockUploadWorkerRequest();
+      writeAuthConfigFile({
+        api_token: "some-api-token",
+      });
+
+      const accessTokenRequest = mockGrantAccessToken({ respondWith: "ok" });
+      mockGrantAuthorization({ respondWith: "success" });
+
+      await expect(runWrangler("publish index.js")).resolves.toBeUndefined();
+
+      expect(accessTokenRequest.actual.url).toEqual(
+        accessTokenRequest.expected.url
+      );
+
+      expect(std.out).toMatchInlineSnapshot(`
+        "Attempting to login via OAuth...
+        Successfully logged in.
+        Uploaded test-name (TIMINGS)
+        Published test-name (TIMINGS)
+          test-name.test-sub-domain.workers.dev"
+      `);
+      expect(std.warn).toMatchInlineSnapshot(`
+        "It looks like you have used Wrangler 1's \`config\` command to login with an API token.
+        This is no longer supported in the current version of Wrangler.
+        If you wish to authenticate via an API token then please set the \`CLOUDFLARE_API_TOKEN\` environment variable."
+      `);
+      expect(std.err).toMatchInlineSnapshot(`""`);
+    });
   });
 
   describe("environments", () => {
     it("should use legacy environments by default", async () => {
-      writeWranglerToml();
+      writeWranglerToml({ env: { "some-env": {} } });
       writeWorkerSource();
       mockSubDomainRequest();
       mockUploadWorkerRequest({
@@ -70,8 +145,8 @@ describe("publish", () => {
         expect(std.warn).toMatchInlineSnapshot(`""`);
       });
 
-      it("appends the environment name when provided", async () => {
-        writeWranglerToml();
+      it("appends the environment name when provided, and there is associated config", async () => {
+        writeWranglerToml({ env: { "some-env": {} } });
         writeWorkerSource();
         mockSubDomainRequest();
         mockUploadWorkerRequest({
@@ -87,6 +162,70 @@ describe("publish", () => {
         expect(std.err).toMatchInlineSnapshot(`""`);
         expect(std.warn).toMatchInlineSnapshot(`""`);
       });
+
+      it("appends the environment name when provided (with a warning), if there are no configured environments", async () => {
+        writeWranglerToml({});
+        writeWorkerSource();
+        mockSubDomainRequest();
+        mockUploadWorkerRequest({
+          env: "some-env",
+          legacyEnv: true,
+        });
+        await runWrangler("publish index.js --env some-env --legacy-env true");
+        expect(std.out).toMatchInlineSnapshot(`
+          "Uploaded test-name-some-env (TIMINGS)
+          Published test-name-some-env (TIMINGS)
+            test-name-some-env.test-sub-domain.workers.dev"
+        `);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+        expect(std.warn).toMatchInlineSnapshot(`
+          "Processing wrangler.toml configuration:
+            - No environment found in configuration with name \\"some-env\\".
+              Before using \`--env=some-env\` there should be an equivalent environment section in the configuration.
+
+              Consider adding an environment configuration section to the wrangler.toml file:
+              \`\`\`
+              [env.some-env]
+              \`\`\`
+          "
+        `);
+      });
+
+      it("should throw an error when an environment name when provided, which doesn't match those in the config", async () => {
+        writeWranglerToml({ env: { "other-env": {} } });
+        writeWorkerSource();
+        mockSubDomainRequest();
+        await expect(
+          runWrangler("publish index.js --env some-env --legacy-env true")
+        ).rejects.toThrowErrorMatchingInlineSnapshot(`
+                "Processing wrangler.toml configuration:
+                  - No environment found in configuration with name \\"some-env\\".
+                    Before using \`--env=some-env\` there should be an equivalent environment section in the configuration.
+                    The available configured environment names are: [\\"other-env\\"]
+
+                    Consider adding an environment configuration section to the wrangler.toml file:
+                    \`\`\`
+                    [env.some-env]
+                    \`\`\`
+                "
+              `);
+      });
+
+      it("should throw an error w/ helpful message when using --env --name", async () => {
+        writeWranglerToml({ env: { "some-env": {} } });
+        writeWorkerSource();
+        mockSubDomainRequest();
+        await runWrangler(
+          "publish index.js --name voyager --env some-env --legacy-env true"
+        ).catch((err) =>
+          expect(err).toMatchInlineSnapshot(`
+            [Error: In legacy environment mode you cannot use --name and --env together. If you want to specify a Worker name for a specific environment you can add the following to your wrangler.toml config:
+                [env.some-env]
+                name = "voyager"
+                ]
+          `)
+        );
+      });
     });
 
     describe("services", () => {
@@ -108,7 +247,7 @@ describe("publish", () => {
       });
 
       it("publishes as an environment when provided", async () => {
-        writeWranglerToml();
+        writeWranglerToml({ env: { "some-env": {} } });
         writeWorkerSource();
         mockSubDomainRequest();
         mockUploadWorkerRequest({
@@ -585,6 +724,7 @@ export default{
         uploading as assets/file-1.2ca234f380.txt...
         reading assets/file-2.txt...
         uploading as assets/file-2.5938485188.txt...
+        ↗️  Done syncing assets
         Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
           test-name.test-sub-domain.workers.dev"
@@ -640,6 +780,7 @@ export default{
         uploading as assets/file-1.2ca234f380.txt...
         reading assets/file-2.txt...
         uploading as assets/file-2.5938485188.txt...
+        ↗️  Done syncing assets
         Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
           test-name.test-sub-domain.workers.dev"
@@ -689,6 +830,7 @@ export default{
         uploading as assets/file-1.2ca234f380.txt...
         reading assets/file-2.txt...
         uploading as assets/file-2.5938485188.txt...
+        ↗️  Done syncing assets
         Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
           test-name.test-sub-domain.workers.dev"
@@ -711,6 +853,7 @@ export default{
         site: {
           bucket: "assets",
         },
+        env: { "some-env": {} },
       });
       writeWorkerSource();
       writeAssets(assets);
@@ -735,6 +878,7 @@ export default{
         uploading as assets/file-1.2ca234f380.txt...
         reading assets/file-2.txt...
         uploading as assets/file-2.5938485188.txt...
+        ↗️  Done syncing assets
         Uploaded test-name (some-env) (TIMINGS)
         Published test-name (some-env) (TIMINGS)
           some-env.test-name.test-sub-domain.workers.dev"
@@ -757,6 +901,7 @@ export default{
         site: {
           bucket: "assets",
         },
+        env: { "some-env": {} },
       });
       writeWorkerSource();
       writeAssets(assets);
@@ -782,6 +927,7 @@ export default{
         uploading as assets/file-1.2ca234f380.txt...
         reading assets/file-2.txt...
         uploading as assets/file-2.5938485188.txt...
+        ↗️  Done syncing assets
         Uploaded test-name-some-env (TIMINGS)
         Published test-name-some-env (TIMINGS)
           test-name-some-env.test-sub-domain.workers.dev"
@@ -810,7 +956,9 @@ export default{
       mockSubDomainRequest();
       mockListKVNamespacesRequest(kvNamespace);
       // Put file-1 in the KV namespace
-      mockKeyListRequest(kvNamespace.id, ["assets/file-1.2ca234f380.txt"]);
+      mockKeyListRequest(kvNamespace.id, [
+        { name: "assets/file-1.2ca234f380.txt" },
+      ]);
       // Check we do not upload file-1
       mockUploadAssetsToKVRequest(
         kvNamespace.id,
@@ -823,6 +971,7 @@ export default{
         skipping - already uploaded
         reading assets/file-2.txt...
         uploading as assets/file-2.5938485188.txt...
+        ↗️  Done syncing assets
         Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
           test-name.test-sub-domain.workers.dev"
@@ -861,6 +1010,7 @@ export default{
       expect(std.out).toMatchInlineSnapshot(`
         "reading assets/file-1.txt...
         uploading as assets/file-1.2ca234f380.txt...
+        ↗️  Done syncing assets
         Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
           test-name.test-sub-domain.workers.dev"
@@ -899,6 +1049,7 @@ export default{
       expect(std.out).toMatchInlineSnapshot(`
         "reading assets/file-1.txt...
         uploading as assets/file-1.2ca234f380.txt...
+        ↗️  Done syncing assets
         Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
           test-name.test-sub-domain.workers.dev"
@@ -938,6 +1089,7 @@ export default{
       expect(std.out).toMatchInlineSnapshot(`
         "reading assets/file-1.txt...
         uploading as assets/file-1.2ca234f380.txt...
+        ↗️  Done syncing assets
         Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
           test-name.test-sub-domain.workers.dev"
@@ -977,6 +1129,7 @@ export default{
       expect(std.out).toMatchInlineSnapshot(`
         "reading assets/file-1.txt...
         uploading as assets/file-1.2ca234f380.txt...
+        ↗️  Done syncing assets
         Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
           test-name.test-sub-domain.workers.dev"
@@ -1016,6 +1169,7 @@ export default{
       expect(std.out).toMatchInlineSnapshot(`
         "reading assets/file-1.txt...
         uploading as assets/file-1.2ca234f380.txt...
+        ↗️  Done syncing assets
         Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
           test-name.test-sub-domain.workers.dev"
@@ -1055,6 +1209,7 @@ export default{
       expect(std.out).toMatchInlineSnapshot(`
         "reading assets/file-1.txt...
         uploading as assets/file-1.2ca234f380.txt...
+        ↗️  Done syncing assets
         Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
           test-name.test-sub-domain.workers.dev"
@@ -1096,6 +1251,7 @@ export default{
       expect(std.out).toMatchInlineSnapshot(`
         "reading assets/directory-1/file-1.txt...
         uploading as assets/directory-1/file-1.2ca234f380.txt...
+        ↗️  Done syncing assets
         Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
           test-name.test-sub-domain.workers.dev"
@@ -1141,6 +1297,7 @@ export default{
       expect(std.out).toMatchInlineSnapshot(`
         "reading assets/.well-known/file-2.txt...
         uploading as assets/.well-known/file-2.5938485188.txt...
+        ↗️  Done syncing assets
         Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
           test-name.test-sub-domain.workers.dev"
@@ -1232,6 +1389,62 @@ export default{
         %s If you think this is a bug then please create an issue at https://github.com/cloudflare/wrangler2/issues/new."
       `);
     });
+
+    it("should delete uploaded assets that aren't included anymore", async () => {
+      const assets = [
+        { filePath: "assets/file-1.txt", content: "Content of file-1" },
+        { filePath: "assets/file-2.txt", content: "Content of file-2" },
+      ];
+      const kvNamespace = {
+        title: "__test-name-workers_sites_assets",
+        id: "__test-name-workers_sites_assets-id",
+      };
+      writeWranglerToml({
+        main: "./index.js",
+        site: {
+          bucket: "assets",
+        },
+      });
+      writeWorkerSource();
+      writeAssets(assets);
+      mockUploadWorkerRequest();
+      mockSubDomainRequest();
+      mockListKVNamespacesRequest(kvNamespace);
+      mockKeyListRequest(kvNamespace.id, [
+        // Put file-1 in the KV namespace
+        { name: "assets/file-1.2ca234f380.txt" },
+        // As well as a couple from a previous upload
+        { name: "assets/file-3.somehash.txt" },
+        { name: "assets/file-4.anotherhash.txt" },
+      ]);
+
+      // we upload only file-1.txt
+      mockUploadAssetsToKVRequest(kvNamespace.id, [
+        ...assets.filter((a) => a.filePath !== "assets/file-1.txt"),
+      ]);
+
+      // and mark file-3 and file-4 for deletion
+      mockDeleteUnusedAssetsRequest(kvNamespace.id, [
+        "assets/file-3.somehash.txt",
+        "assets/file-4.anotherhash.txt",
+      ]);
+
+      await runWrangler("publish");
+
+      expect(std.out).toMatchInlineSnapshot(`
+        "reading assets/file-1.txt...
+        skipping - already uploaded
+        reading assets/file-2.txt...
+        uploading as assets/file-2.5938485188.txt...
+        deleting assets/file-3.somehash.txt from the asset store...
+        deleting assets/file-4.anotherhash.txt from the asset store...
+        ↗️  Done syncing assets
+        Uploaded test-name (TIMINGS)
+        Published test-name (TIMINGS)
+          test-name.test-sub-domain.workers.dev"
+      `);
+      expect(std.err).toMatchInlineSnapshot(`""`);
+    });
   });
 
   describe("workers_dev setting", () => {
@@ -1522,442 +1735,1275 @@ export default{
               https://dash.cloudflare.com/some-account-id/workers/onboarding"
             `);
     });
-  });
 
-  describe("custom builds", () => {
-    beforeEach(() => {
-      // @ts-expect-error disable the mock we'd setup earlier
-      // or else custom builds will timeout immediately
-      global.setTimeout.mockRestore();
-    });
-    it("should run a custom build before publishing", async () => {
+    it("should not deploy to workers.dev if there are any routes defined", async () => {
       writeWranglerToml({
-        build: {
-          command: `node -e "console.log('custom build'); require('fs').writeFileSync('index.js', 'export default { fetch(){ return new Response(123) } }')"`,
-        },
-      });
-
-      mockUploadWorkerRequest({
-        expectedEntry: "return new Response(123)",
+        routes: ["http://example.com/*"],
       });
+      writeWorkerSource();
       mockSubDomainRequest();
-
+      mockUploadWorkerRequest();
+      mockUpdateWorkerRequest({
+        enabled: false,
+      });
+      mockPublishRoutesRequest({ routes: ["http://example.com/*"] });
       await runWrangler("publish index.js");
+
       expect(std.out).toMatchInlineSnapshot(`
-        "running: node -e \\"console.log('custom build'); require('fs').writeFileSync('index.js', 'export default { fetch(){ return new Response(123) } }')\\"
-        Uploaded test-name (TIMINGS)
+        "Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
-          test-name.test-sub-domain.workers.dev"
+          http://example.com/*"
       `);
       expect(std.err).toMatchInlineSnapshot(`""`);
       expect(std.warn).toMatchInlineSnapshot(`""`);
     });
 
-    if (process.platform !== "win32") {
-      it("should run a custom build of multiple steps combined by && before publishing", async () => {
-        writeWranglerToml({
-          build: {
-            command: `echo "custom build" && echo "export default { fetch(){ return new Response(123) } }" > index.js`,
+    it("should not deploy to workers.dev if there are any routes defined (environments)", async () => {
+      writeWranglerToml({
+        routes: ["http://example.com/*"],
+        env: {
+          production: {
+            routes: ["http://production.example.com/*"],
           },
-        });
-
-        mockUploadWorkerRequest({
-          expectedEntry: "return new Response(123)",
-        });
-        mockSubDomainRequest();
-
-        await runWrangler("publish index.js");
-        expect(std.out).toMatchInlineSnapshot(`
-          "running: echo \\"custom build\\" && echo \\"export default { fetch(){ return new Response(123) } }\\" > index.js
-          Uploaded test-name (TIMINGS)
-          Published test-name (TIMINGS)
-            test-name.test-sub-domain.workers.dev"
-        `);
-        expect(std.err).toMatchInlineSnapshot(`""`);
-        expect(std.warn).toMatchInlineSnapshot(`""`);
+        },
       });
-    }
+      writeWorkerSource();
+      mockSubDomainRequest();
+      mockUploadWorkerRequest({ env: "production", legacyEnv: true });
+      mockUpdateWorkerRequest({
+        enabled: false,
+        env: "production",
+        legacyEnv: true,
+      });
+      mockPublishRoutesRequest({
+        routes: ["http://production.example.com/*"],
+        env: "production",
+        legacyEnv: true,
+      });
+      await runWrangler("publish index.js --env production");
 
-    it("should throw an error if the entry doesn't exist after the build finishes", async () => {
+      expect(std.out).toMatchInlineSnapshot(`
+        "Uploaded test-name-production (TIMINGS)
+        Published test-name-production (TIMINGS)
+          http://production.example.com/*"
+      `);
+      expect(std.err).toMatchInlineSnapshot(`""`);
+      expect(std.warn).toMatchInlineSnapshot(`""`);
+    });
+
+    it("should not deploy to workers.dev if there are any routes defined (only in environments)", async () => {
       writeWranglerToml({
-        main: "index.js",
-        build: {
-          command: `node -e "console.log('custom build');"`,
+        env: {
+          production: {
+            routes: ["http://production.example.com/*"],
+          },
         },
       });
+      writeWorkerSource();
+      mockSubDomainRequest();
+      mockUploadWorkerRequest({ env: "production", legacyEnv: true });
+      mockUpdateWorkerRequest({
+        enabled: false,
+        env: "production",
+        legacyEnv: true,
+      });
+      mockPublishRoutesRequest({
+        routes: ["http://production.example.com/*"],
+        env: "production",
+        legacyEnv: true,
+      });
+      await runWrangler("publish index.js --env production");
 
-      await expect(
-        runWrangler("publish index.js")
-      ).rejects.toThrowErrorMatchingInlineSnapshot(
-        `"Could not resolve \\"index.js\\" after running custom build: node -e \\"console.log('custom build');\\""`
-      );
-      expect(std.out).toMatchInlineSnapshot(
-        `"running: node -e \\"console.log('custom build');\\""`
-      );
-      expect(std.err).toMatchInlineSnapshot(`
-        "Could not resolve \\"index.js\\" after running custom build: node -e \\"console.log('custom build');\\"
-
-        %s If you think this is a bug then please create an issue at https://github.com/cloudflare/wrangler2/issues/new."
+      expect(std.out).toMatchInlineSnapshot(`
+        "Uploaded test-name-production (TIMINGS)
+        Published test-name-production (TIMINGS)
+          http://production.example.com/*"
       `);
+      expect(std.err).toMatchInlineSnapshot(`""`);
       expect(std.warn).toMatchInlineSnapshot(`""`);
     });
-  });
 
-  describe("[wasm_modules]", () => {
-    it("should be able to define wasm modules for service-worker format workers", async () => {
+    it("can deploy to both workers.dev and routes if both defined ", async () => {
       writeWranglerToml({
-        wasm_modules: {
-          TESTWASMNAME: "./path/to/test.wasm",
-        },
-      });
-      writeWorkerSource({ type: "sw" });
-      fs.mkdirSync("./path/to", { recursive: true });
-      fs.writeFileSync("./path/to/test.wasm", "SOME WASM CONTENT");
-      mockUploadWorkerRequest({
-        expectedType: "sw",
-        expectedModules: { TESTWASMNAME: "SOME WASM CONTENT" },
-        expectedBindings: [
-          { name: "TESTWASMNAME", part: "TESTWASMNAME", type: "wasm_module" },
-        ],
+        workers_dev: true,
+        routes: ["http://example.com/*"],
       });
+      writeWorkerSource();
       mockSubDomainRequest();
+      mockUploadWorkerRequest();
+      mockUpdateWorkerRequest({
+        enabled: false,
+      });
+      mockPublishRoutesRequest({
+        routes: ["http://example.com/*"],
+      });
       await runWrangler("publish index.js");
+
       expect(std.out).toMatchInlineSnapshot(`
         "Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
-          test-name.test-sub-domain.workers.dev"
+          test-name.test-sub-domain.workers.dev
+          http://example.com/*"
       `);
       expect(std.err).toMatchInlineSnapshot(`""`);
       expect(std.warn).toMatchInlineSnapshot(`""`);
     });
 
-    it("should error when defining wasm modules for modules format workers", async () => {
+    it("can deploy to both workers.dev and routes if both defined (environments: 1)", async () => {
       writeWranglerToml({
-        wasm_modules: {
-          TESTWASMNAME: "./path/to/test.wasm",
+        workers_dev: true,
+        env: {
+          production: {
+            routes: ["http://production.example.com/*"],
+          },
         },
       });
-      writeWorkerSource({ type: "esm" });
-      fs.mkdirSync("./path/to", { recursive: true });
-      fs.writeFileSync("./path/to/test.wasm", "SOME WASM CONTENT");
-
-      await expect(
-        runWrangler("publish index.js")
-      ).rejects.toThrowErrorMatchingInlineSnapshot(
-        `"You cannot configure [wasm_modules] with an ES module worker. Instead, import the .wasm module directly in your code"`
-      );
-      expect(std.out).toMatchInlineSnapshot(`""`);
-      expect(std.err).toMatchInlineSnapshot(`
-        "You cannot configure [wasm_modules] with an ES module worker. Instead, import the .wasm module directly in your code
+      writeWorkerSource();
+      mockSubDomainRequest();
+      mockUploadWorkerRequest({ env: "production", legacyEnv: true });
+      mockUpdateWorkerRequest({
+        enabled: false,
+        env: "production",
+        legacyEnv: true,
+      });
+      mockPublishRoutesRequest({
+        routes: ["http://production.example.com/*"],
+        env: "production",
+        legacyEnv: true,
+      });
+      await runWrangler("publish index.js --env production");
 
-        %s If you think this is a bug then please create an issue at https://github.com/cloudflare/wrangler2/issues/new."
+      expect(std.out).toMatchInlineSnapshot(`
+        "Uploaded test-name-production (TIMINGS)
+        Published test-name-production (TIMINGS)
+          test-name-production.test-sub-domain.workers.dev
+          http://production.example.com/*"
       `);
+      expect(std.err).toMatchInlineSnapshot(`""`);
       expect(std.warn).toMatchInlineSnapshot(`""`);
     });
 
-    it("should resolve wasm modules relative to the wrangler.toml file", async () => {
-      fs.mkdirSync("./path/to/and/the/path/to/", { recursive: true });
-      fs.writeFileSync(
-        "./path/to/wrangler.toml",
-        TOML.stringify({
-          compatibility_date: "2022-01-12",
-          name: "test-name",
-          wasm_modules: {
-            TESTWASMNAME: "./and/the/path/to/test.wasm",
+    it("can deploy to both workers.dev and routes if both defined (environments: 2)", async () => {
+      writeWranglerToml({
+        env: {
+          production: {
+            workers_dev: true,
+            routes: ["http://production.example.com/*"],
           },
-        }),
-
-        "utf-8"
-      );
-
-      writeWorkerSource({ type: "sw" });
-      fs.writeFileSync(
-        "./path/to/and/the/path/to/test.wasm",
-        "SOME WASM CONTENT"
-      );
-      mockUploadWorkerRequest({
-        expectedType: "sw",
-        expectedModules: { TESTWASMNAME: "SOME WASM CONTENT" },
-        expectedBindings: [
-          { name: "TESTWASMNAME", part: "TESTWASMNAME", type: "wasm_module" },
-        ],
-        expectedCompatibilityDate: "2022-01-12",
+        },
       });
+      writeWorkerSource();
       mockSubDomainRequest();
-      await runWrangler("publish index.js --config ./path/to/wrangler.toml");
+      mockUploadWorkerRequest({ env: "production", legacyEnv: true });
+      mockUpdateWorkerRequest({
+        enabled: false,
+        env: "production",
+        legacyEnv: true,
+      });
+      mockPublishRoutesRequest({
+        routes: ["http://production.example.com/*"],
+        env: "production",
+        legacyEnv: true,
+      });
+      await runWrangler("publish index.js --env production");
+
       expect(std.out).toMatchInlineSnapshot(`
-        "Uploaded test-name (TIMINGS)
-        Published test-name (TIMINGS)
-          test-name.test-sub-domain.workers.dev"
+        "Uploaded test-name-production (TIMINGS)
+        Published test-name-production (TIMINGS)
+          test-name-production.test-sub-domain.workers.dev
+          http://production.example.com/*"
       `);
       expect(std.err).toMatchInlineSnapshot(`""`);
       expect(std.warn).toMatchInlineSnapshot(`""`);
     });
 
-    it("should be able to import .wasm modules from service-worker format workers", async () => {
-      writeWranglerToml();
-      fs.writeFileSync("./index.js", "import TESTWASMNAME from './test.wasm';");
-      fs.writeFileSync("./test.wasm", "SOME WASM CONTENT");
-      mockUploadWorkerRequest({
-        expectedType: "sw",
-        expectedModules: {
-          __94b240d0d692281e6467aa42043986e5c7eea034_test_wasm:
-            "SOME WASM CONTENT",
+    it("will deploy only to routes when workers_dev is false (environments 1) ", async () => {
+      writeWranglerToml({
+        workers_dev: false,
+        env: {
+          production: {
+            routes: ["http://production.example.com/*"],
+          },
         },
-        expectedBindings: [
-          {
-            name: "__94b240d0d692281e6467aa42043986e5c7eea034_test_wasm",
-            part: "__94b240d0d692281e6467aa42043986e5c7eea034_test_wasm",
-            type: "wasm_module",
+      });
+      writeWorkerSource();
+      mockSubDomainRequest();
+      mockUploadWorkerRequest({ env: "production", legacyEnv: true });
+      mockUpdateWorkerRequest({
+        enabled: false,
+        env: "production",
+        legacyEnv: true,
+      });
+      mockPublishRoutesRequest({
+        routes: ["http://production.example.com/*"],
+        env: "production",
+        legacyEnv: true,
+      });
+      await runWrangler("publish index.js --env production");
+
+      expect(std.out).toMatchInlineSnapshot(`
+        "Uploaded test-name-production (TIMINGS)
+        Published test-name-production (TIMINGS)
+          http://production.example.com/*"
+      `);
+      expect(std.err).toMatchInlineSnapshot(`""`);
+      expect(std.warn).toMatchInlineSnapshot(`""`);
+    });
+
+    it("will deploy only to routes when workers_dev is false (environments 2) ", async () => {
+      writeWranglerToml({
+        env: {
+          production: {
+            workers_dev: false,
+            routes: ["http://production.example.com/*"],
           },
-        ],
+        },
+      });
+      writeWorkerSource();
+      mockSubDomainRequest();
+      mockUploadWorkerRequest({ env: "production", legacyEnv: true });
+      mockUpdateWorkerRequest({
+        enabled: false,
+        env: "production",
+        legacyEnv: true,
+      });
+      mockPublishRoutesRequest({
+        routes: ["http://production.example.com/*"],
+        env: "production",
+        legacyEnv: true,
+      });
+      await runWrangler("publish index.js --env production");
+
+      expect(std.out).toMatchInlineSnapshot(`
+        "Uploaded test-name-production (TIMINGS)
+        Published test-name-production (TIMINGS)
+          http://production.example.com/*"
+      `);
+      expect(std.err).toMatchInlineSnapshot(`""`);
+      expect(std.warn).toMatchInlineSnapshot(`""`);
+    });
+  });
+
+  describe("custom builds", () => {
+    beforeEach(() => {
+      // @ts-expect-error disable the mock we'd setup earlier
+      // or else custom builds will timeout immediately
+      global.setTimeout.mockRestore();
+    });
+    it("should run a custom build before publishing", async () => {
+      writeWranglerToml({
+        build: {
+          command: `node -e "console.log('custom build'); require('fs').writeFileSync('index.js', 'export default { fetch(){ return new Response(123) } }')"`,
+        },
+      });
+
+      mockUploadWorkerRequest({
+        expectedEntry: "return new Response(123)",
       });
       mockSubDomainRequest();
+
       await runWrangler("publish index.js");
       expect(std.out).toMatchInlineSnapshot(`
-        "Uploaded test-name (TIMINGS)
+        "running: node -e \\"console.log('custom build'); require('fs').writeFileSync('index.js', 'export default { fetch(){ return new Response(123) } }')\\"
+        Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
           test-name.test-sub-domain.workers.dev"
       `);
       expect(std.err).toMatchInlineSnapshot(`""`);
       expect(std.warn).toMatchInlineSnapshot(`""`);
     });
+
+    if (process.platform !== "win32") {
+      it("should run a custom build of multiple steps combined by && before publishing", async () => {
+        writeWranglerToml({
+          build: {
+            command: `echo "custom build" && echo "export default { fetch(){ return new Response(123) } }" > index.js`,
+          },
+        });
+
+        mockUploadWorkerRequest({
+          expectedEntry: "return new Response(123)",
+        });
+        mockSubDomainRequest();
+
+        await runWrangler("publish index.js");
+        expect(std.out).toMatchInlineSnapshot(`
+          "running: echo \\"custom build\\" && echo \\"export default { fetch(){ return new Response(123) } }\\" > index.js
+          Uploaded test-name (TIMINGS)
+          Published test-name (TIMINGS)
+            test-name.test-sub-domain.workers.dev"
+        `);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+        expect(std.warn).toMatchInlineSnapshot(`""`);
+      });
+    }
+
+    it("should throw an error if the entry doesn't exist after the build finishes", async () => {
+      writeWranglerToml({
+        main: "index.js",
+        build: {
+          command: `node -e "console.log('custom build');"`,
+        },
+      });
+
+      await expect(
+        runWrangler("publish index.js")
+      ).rejects.toThrowErrorMatchingInlineSnapshot(
+        `"Could not resolve \\"index.js\\" after running custom build: node -e \\"console.log('custom build');\\""`
+      );
+      expect(std.out).toMatchInlineSnapshot(
+        `"running: node -e \\"console.log('custom build');\\""`
+      );
+      expect(std.err).toMatchInlineSnapshot(`
+        "Could not resolve \\"index.js\\" after running custom build: node -e \\"console.log('custom build');\\"
+
+        %s If you think this is a bug then please create an issue at https://github.com/cloudflare/wrangler2/issues/new."
+      `);
+      expect(std.warn).toMatchInlineSnapshot(`""`);
+    });
   });
 
-  describe("[text_blobs]", () => {
-    it("should be able to define text blobs for service-worker format workers", async () => {
+  describe("bindings", () => {
+    it("should allow bindings with different names", async () => {
       writeWranglerToml({
+        durable_objects: {
+          bindings: [
+            {
+              name: "DURABLE_OBJECT_ONE",
+              class_name: "SomeDurableObject",
+              script_name: "some-durable-object-worker",
+            },
+            {
+              name: "DURABLE_OBJECT_TWO",
+              class_name: "AnotherDurableObject",
+              script_name: "another-durable-object-worker",
+            },
+          ],
+        },
+        kv_namespaces: [
+          { binding: "KV_NAMESPACE_ONE", id: "kv-ns-one-id" },
+          { binding: "KV_NAMESPACE_TWO", id: "kv-ns-two-id" },
+        ],
+        r2_buckets: [
+          { binding: "R2_BUCKET_ONE", bucket_name: "r2-bucket-one-name" },
+          { binding: "R2_BUCKET_TWO", bucket_name: "r2-bucket-two-name" },
+        ],
         text_blobs: {
-          TESTTEXTBLOBNAME: "./path/to/text.file",
+          TEXT_BLOB_ONE: "./my-entire-app-depends-on-this.cfg",
+          TEXT_BLOB_TWO: "./the-entirety-of-human-knowledge.txt",
+        },
+        unsafe: {
+          bindings: [
+            {
+              name: "UNSAFE_BINDING_ONE",
+              type: "some unsafe thing",
+              data: { some: { unsafe: "thing" } },
+            },
+            {
+              name: "UNSAFE_BINDING_TWO",
+              type: "another unsafe thing",
+              data: 1337,
+            },
+          ],
+        },
+        vars: {
+          ENV_VAR_ONE: 123,
+          ENV_VAR_TWO: "Hello, I'm an environment variable",
+        },
+        wasm_modules: {
+          WASM_MODULE_ONE: "./some_wasm.wasm",
+          WASM_MODULE_TWO: "./more_wasm.wasm",
         },
       });
+
       writeWorkerSource({ type: "sw" });
-      fs.mkdirSync("./path/to", { recursive: true });
-      fs.writeFileSync("./path/to/text.file", "SOME TEXT CONTENT");
+      fs.writeFileSync("./my-entire-app-depends-on-this.cfg", "config = value");
+      fs.writeFileSync(
+        "./the-entirety-of-human-knowledge.txt",
+        "Everything's bigger in Texas"
+      );
+      fs.writeFileSync("./some_wasm.wasm", "some wasm");
+      fs.writeFileSync("./more_wasm.wasm", "more wasm");
+
       mockUploadWorkerRequest({
         expectedType: "sw",
-        expectedModules: { TESTTEXTBLOBNAME: "SOME TEXT CONTENT" },
         expectedBindings: [
           {
-            name: "TESTTEXTBLOBNAME",
-            part: "TESTTEXTBLOBNAME",
-            type: "text_blob",
+            name: "KV_NAMESPACE_ONE",
+            namespace_id: "kv-ns-one-id",
+            type: "kv_namespace",
+          },
+          {
+            name: "KV_NAMESPACE_TWO",
+            namespace_id: "kv-ns-two-id",
+            type: "kv_namespace",
+          },
+          {
+            class_name: "SomeDurableObject",
+            name: "DURABLE_OBJECT_ONE",
+            script_name: "some-durable-object-worker",
+            type: "durable_object_namespace",
+          },
+          {
+            class_name: "AnotherDurableObject",
+            name: "DURABLE_OBJECT_TWO",
+            script_name: "another-durable-object-worker",
+            type: "durable_object_namespace",
+          },
+          {
+            bucket_name: "r2-bucket-one-name",
+            name: "R2_BUCKET_ONE",
+            type: "r2_bucket",
+          },
+          {
+            bucket_name: "r2-bucket-two-name",
+            name: "R2_BUCKET_TWO",
+            type: "r2_bucket",
+          },
+          { json: 123, name: "ENV_VAR_ONE", type: "json" },
+          {
+            name: "ENV_VAR_TWO",
+            text: "Hello, I'm an environment variable",
+            type: "plain_text",
+          },
+          {
+            name: "WASM_MODULE_ONE",
+            part: "WASM_MODULE_ONE",
+            type: "wasm_module",
+          },
+          {
+            name: "WASM_MODULE_TWO",
+            part: "WASM_MODULE_TWO",
+            type: "wasm_module",
+          },
+          { name: "TEXT_BLOB_ONE", part: "TEXT_BLOB_ONE", type: "text_blob" },
+          { name: "TEXT_BLOB_TWO", part: "TEXT_BLOB_TWO", type: "text_blob" },
+          {
+            data: { some: { unsafe: "thing" } },
+            name: "UNSAFE_BINDING_ONE",
+            type: "some unsafe thing",
+          },
+          {
+            data: 1337,
+            name: "UNSAFE_BINDING_TWO",
+            type: "another unsafe thing",
           },
         ],
       });
       mockSubDomainRequest();
-      await runWrangler("publish index.js");
+
+      await expect(runWrangler("publish index.js")).resolves.toBeUndefined();
       expect(std.out).toMatchInlineSnapshot(`
         "Uploaded test-name (TIMINGS)
         Published test-name (TIMINGS)
           test-name.test-sub-domain.workers.dev"
       `);
       expect(std.err).toMatchInlineSnapshot(`""`);
-      expect(std.warn).toMatchInlineSnapshot(`""`);
+      expect(std.warn).toMatchInlineSnapshot(`
+        "Processing wrangler.toml configuration:
+          - \\"unsafe\\" fields are experimental and may change or break at any time."
+      `);
     });
 
-    it("should error when defining text blobs for modules format workers", async () => {
-      writeWranglerToml({
-        text_blobs: {
-          TESTTEXTBLOBNAME: "./path/to/text.file",
-        },
+    it("should error when bindings of different types have the same name", async () => {
+      writeWranglerToml({
+        durable_objects: {
+          bindings: [
+            {
+              name: "CONFLICTING_NAME_ONE",
+              class_name: "SomeDurableObject",
+              script_name: "some-durable-object-worker",
+            },
+            {
+              name: "CONFLICTING_NAME_TWO",
+              class_name: "AnotherDurableObject",
+              script_name: "another-durable-object-worker",
+            },
+          ],
+        },
+        kv_namespaces: [
+          { binding: "CONFLICTING_NAME_ONE", id: "kv-ns-one-id" },
+          { binding: "CONFLICTING_NAME_TWO", id: "kv-ns-two-id" },
+        ],
+        r2_buckets: [
+          {
+            binding: "CONFLICTING_NAME_ONE",
+            bucket_name: "r2-bucket-one-name",
+          },
+          {
+            binding: "CONFLICTING_NAME_THREE",
+            bucket_name: "r2-bucket-two-name",
+          },
+        ],
+        text_blobs: {
+          CONFLICTING_NAME_THREE: "./my-entire-app-depends-on-this.cfg",
+          CONFLICTING_NAME_FOUR: "./the-entirety-of-human-knowledge.txt",
+        },
+        unsafe: {
+          bindings: [
+            {
+              name: "CONFLICTING_NAME_THREE",
+              type: "some unsafe thing",
+              data: { some: { unsafe: "thing" } },
+            },
+            {
+              name: "CONFLICTING_NAME_FOUR",
+              type: "another unsafe thing",
+              data: 1337,
+            },
+          ],
+        },
+        vars: {
+          ENV_VAR_ONE: 123,
+          CONFLICTING_NAME_THREE: "Hello, I'm an environment variable",
+        },
+        wasm_modules: {
+          WASM_MODULE_ONE: "./some_wasm.wasm",
+          CONFLICTING_NAME_THREE: "./more_wasm.wasm",
+        },
+      });
+
+      writeWorkerSource({ type: "sw" });
+      fs.writeFileSync("./my-entire-app-depends-on-this.cfg", "config = value");
+      fs.writeFileSync(
+        "./the-entirety-of-human-knowledge.txt",
+        "Everything's bigger in Texas"
+      );
+      fs.writeFileSync("./some_wasm.wasm", "some wasm");
+      fs.writeFileSync("./more_wasm.wasm", "more wasm");
+
+      await expect(runWrangler("publish index.js")).rejects
+        .toMatchInlineSnapshot(`
+              [Error: Processing wrangler.toml configuration:
+                - CONFLICTING_NAME_ONE assigned to Durable Object, KV Namespace, and R2 Bucket bindings.
+                - CONFLICTING_NAME_TWO assigned to Durable Object and KV Namespace bindings.
+                - CONFLICTING_NAME_THREE assigned to R2 Bucket, Text Blob, Unsafe, Environment Variable, and WASM Module bindings.
+                - CONFLICTING_NAME_FOUR assigned to Text Blob and Unsafe bindings.
+                - Bindings must have unique names, so that they can all be referenced in the worker.
+                  Please change your bindings to have unique names.]
+            `);
+      expect(std.out).toMatchInlineSnapshot(`""`);
+      expect(std.err).toMatchInlineSnapshot(`
+        "Processing wrangler.toml configuration:
+          - CONFLICTING_NAME_ONE assigned to Durable Object, KV Namespace, and R2 Bucket bindings.
+          - CONFLICTING_NAME_TWO assigned to Durable Object and KV Namespace bindings.
+          - CONFLICTING_NAME_THREE assigned to R2 Bucket, Text Blob, Unsafe, Environment Variable, and WASM Module bindings.
+          - CONFLICTING_NAME_FOUR assigned to Text Blob and Unsafe bindings.
+          - Bindings must have unique names, so that they can all be referenced in the worker.
+            Please change your bindings to have unique names.
+
+        %s If you think this is a bug then please create an issue at https://github.com/cloudflare/wrangler2/issues/new."
+      `);
+      expect(std.warn).toMatchInlineSnapshot(`
+        "Processing wrangler.toml configuration:
+          - \\"unsafe\\" fields are experimental and may change or break at any time."
+      `);
+    });
+
+    it("should error when bindings of the same type have the same name", async () => {
+      writeWranglerToml({
+        durable_objects: {
+          bindings: [
+            {
+              name: "CONFLICTING_DURABLE_OBJECT_NAME",
+              class_name: "SomeDurableObject",
+              script_name: "some-durable-object-worker",
+            },
+            {
+              name: "CONFLICTING_DURABLE_OBJECT_NAME",
+              class_name: "AnotherDurableObject",
+              script_name: "another-durable-object-worker",
+            },
+          ],
+        },
+        kv_namespaces: [
+          { binding: "CONFLICTING_KV_NAMESPACE_NAME", id: "kv-ns-one-id" },
+          { binding: "CONFLICTING_KV_NAMESPACE_NAME", id: "kv-ns-two-id" },
+        ],
+        r2_buckets: [
+          {
+            binding: "CONFLICTING_R2_BUCKET_NAME",
+            bucket_name: "r2-bucket-one-name",
+          },
+          {
+            binding: "CONFLICTING_R2_BUCKET_NAME",
+            bucket_name: "r2-bucket-two-name",
+          },
+        ],
+        unsafe: {
+          bindings: [
+            {
+              name: "CONFLICTING_UNSAFE_NAME",
+              type: "some unsafe thing",
+              data: { some: { unsafe: "thing" } },
+            },
+            {
+              name: "CONFLICTING_UNSAFE_NAME",
+              type: "another unsafe thing",
+              data: 1337,
+            },
+          ],
+        },
+        // text_blobs, vars, and wasm_modules are fine because they're object literals,
+        // and by definition cannot have two keys of the same name
+        //
+        // text_blobs: {
+        //   CONFLICTING_TEXT_BLOB_NAME: "./my-entire-app-depends-on-this.cfg",
+        //   CONFLICTING_TEXT_BLOB_NAME: "./the-entirety-of-human-knowledge.txt",
+        // },
+        // vars: {
+        //   CONFLICTING_VARS_NAME: 123,
+        //   CONFLICTING_VARS_NAME: "Hello, I'm an environment variable",
+        // },
+        // wasm_modules: {
+        //   CONFLICTING_WASM_MODULE_NAME: "./some_wasm.wasm",
+        //   CONFLICTING_WASM_MODULE_NAME: "./more_wasm.wasm",
+        // },
+      });
+
+      writeWorkerSource({ type: "sw" });
+
+      await expect(runWrangler("publish index.js")).rejects
+        .toMatchInlineSnapshot(`
+              [Error: Processing wrangler.toml configuration:
+                - CONFLICTING_DURABLE_OBJECT_NAME assigned to multiple Durable Object bindings.
+                - CONFLICTING_KV_NAMESPACE_NAME assigned to multiple KV Namespace bindings.
+                - CONFLICTING_R2_BUCKET_NAME assigned to multiple R2 Bucket bindings.
+                - CONFLICTING_UNSAFE_NAME assigned to multiple Unsafe bindings.
+                - Bindings must have unique names, so that they can all be referenced in the worker.
+                  Please change your bindings to have unique names.]
+            `);
+      expect(std.out).toMatchInlineSnapshot(`""`);
+      expect(std.err).toMatchInlineSnapshot(`
+        "Processing wrangler.toml configuration:
+          - CONFLICTING_DURABLE_OBJECT_NAME assigned to multiple Durable Object bindings.
+          - CONFLICTING_KV_NAMESPACE_NAME assigned to multiple KV Namespace bindings.
+          - CONFLICTING_R2_BUCKET_NAME assigned to multiple R2 Bucket bindings.
+          - CONFLICTING_UNSAFE_NAME assigned to multiple Unsafe bindings.
+          - Bindings must have unique names, so that they can all be referenced in the worker.
+            Please change your bindings to have unique names.
+
+        %s If you think this is a bug then please create an issue at https://github.com/cloudflare/wrangler2/issues/new."
+      `);
+      expect(std.warn).toMatchInlineSnapshot(`
+        "Processing wrangler.toml configuration:
+          - \\"unsafe\\" fields are experimental and may change or break at any time."
+      `);
+    });
+
+    it("should error correctly when bindings of the same and different types use the same name", async () => {
+      writeWranglerToml({
+        durable_objects: {
+          bindings: [
+            {
+              name: "CONFLICTING_DURABLE_OBJECT_NAME",
+              class_name: "SomeDurableObject",
+              script_name: "some-durable-object-worker",
+            },
+            {
+              name: "CONFLICTING_DURABLE_OBJECT_NAME",
+              class_name: "AnotherDurableObject",
+              script_name: "another-durable-object-worker",
+            },
+          ],
+        },
+        kv_namespaces: [
+          {
+            binding: "CONFLICTING_KV_NAMESPACE_NAME",
+            id: "kv-ns-one-id",
+          },
+          {
+            binding: "CONFLICTING_KV_NAMESPACE_NAME",
+            id: "kv-ns-two-id",
+          },
+          { binding: "CONFLICTING_NAME_ONE", id: "kv-ns-three-id" },
+          { binding: "CONFLICTING_NAME_TWO", id: "kv-ns-four-id" },
+        ],
+        r2_buckets: [
+          {
+            binding: "CONFLICTING_R2_BUCKET_NAME",
+            bucket_name: "r2-bucket-one-name",
+          },
+          {
+            binding: "CONFLICTING_R2_BUCKET_NAME",
+            bucket_name: "r2-bucket-two-name",
+          },
+          {
+            binding: "CONFLICTING_NAME_THREE",
+            bucket_name: "r2-bucket-three-name",
+          },
+          {
+            binding: "CONFLICTING_NAME_FOUR",
+            bucket_name: "r2-bucket-four-name",
+          },
+        ],
+        text_blobs: {
+          CONFLICTING_NAME_THREE: "./my-entire-app-depends-on-this.cfg",
+          CONFLICTING_NAME_FOUR: "./the-entirety-of-human-knowledge.txt",
+        },
+        unsafe: {
+          bindings: [
+            {
+              name: "CONFLICTING_UNSAFE_NAME",
+              type: "some unsafe thing",
+              data: { some: { unsafe: "thing" } },
+            },
+            {
+              name: "CONFLICTING_UNSAFE_NAME",
+              type: "another unsafe thing",
+              data: 1337,
+            },
+            {
+              name: "CONFLICTING_NAME_THREE",
+              type: "yet another unsafe thing",
+              data: "how is a string unsafe?",
+            },
+            {
+              name: "CONFLICTING_NAME_FOUR",
+              type: "a fourth unsafe thing",
+              data: null,
+            },
+          ],
+        },
+        vars: {
+          ENV_VAR_ONE: 123,
+          CONFLICTING_NAME_THREE: "Hello, I'm an environment variable",
+        },
+        wasm_modules: {
+          WASM_MODULE_ONE: "./some_wasm.wasm",
+          CONFLICTING_NAME_THREE: "./more_wasm.wasm",
+        },
+      });
+
+      writeWorkerSource({ type: "sw" });
+      fs.writeFileSync("./my-entire-app-depends-on-this.cfg", "config = value");
+      fs.writeFileSync(
+        "./the-entirety-of-human-knowledge.txt",
+        "Everything's bigger in Texas"
+      );
+      fs.writeFileSync("./some_wasm.wasm", "some wasm");
+      fs.writeFileSync("./more_wasm.wasm", "more wasm");
+
+      await expect(runWrangler("publish index.js")).rejects
+        .toMatchInlineSnapshot(`
+              [Error: Processing wrangler.toml configuration:
+                - CONFLICTING_DURABLE_OBJECT_NAME assigned to multiple Durable Object bindings.
+                - CONFLICTING_KV_NAMESPACE_NAME assigned to multiple KV Namespace bindings.
+                - CONFLICTING_R2_BUCKET_NAME assigned to multiple R2 Bucket bindings.
+                - CONFLICTING_NAME_THREE assigned to R2 Bucket, Text Blob, Unsafe, Environment Variable, and WASM Module bindings.
+                - CONFLICTING_NAME_FOUR assigned to R2 Bucket, Text Blob, and Unsafe bindings.
+                - CONFLICTING_UNSAFE_NAME assigned to multiple Unsafe bindings.
+                - Bindings must have unique names, so that they can all be referenced in the worker.
+                  Please change your bindings to have unique names.]
+            `);
+      expect(std.out).toMatchInlineSnapshot(`""`);
+      expect(std.err).toMatchInlineSnapshot(`
+        "Processing wrangler.toml configuration:
+          - CONFLICTING_DURABLE_OBJECT_NAME assigned to multiple Durable Object bindings.
+          - CONFLICTING_KV_NAMESPACE_NAME assigned to multiple KV Namespace bindings.
+          - CONFLICTING_R2_BUCKET_NAME assigned to multiple R2 Bucket bindings.
+          - CONFLICTING_NAME_THREE assigned to R2 Bucket, Text Blob, Unsafe, Environment Variable, and WASM Module bindings.
+          - CONFLICTING_NAME_FOUR assigned to R2 Bucket, Text Blob, and Unsafe bindings.
+          - CONFLICTING_UNSAFE_NAME assigned to multiple Unsafe bindings.
+          - Bindings must have unique names, so that they can all be referenced in the worker.
+            Please change your bindings to have unique names.
+
+        %s If you think this is a bug then please create an issue at https://github.com/cloudflare/wrangler2/issues/new."
+      `);
+      expect(std.warn).toMatchInlineSnapshot(`
+        "Processing wrangler.toml configuration:
+          - \\"unsafe\\" fields are experimental and may change or break at any time."
+      `);
+    });
+
+    describe("[wasm_modules]", () => {
+      it("should be able to define wasm modules for service-worker format workers", async () => {
+        writeWranglerToml({
+          wasm_modules: {
+            TESTWASMNAME: "./path/to/test.wasm",
+          },
+        });
+        writeWorkerSource({ type: "sw" });
+        fs.mkdirSync("./path/to", { recursive: true });
+        fs.writeFileSync("./path/to/test.wasm", "SOME WASM CONTENT");
+        mockUploadWorkerRequest({
+          expectedType: "sw",
+          expectedModules: { TESTWASMNAME: "SOME WASM CONTENT" },
+          expectedBindings: [
+            { name: "TESTWASMNAME", part: "TESTWASMNAME", type: "wasm_module" },
+          ],
+        });
+        mockSubDomainRequest();
+        await runWrangler("publish index.js");
+        expect(std.out).toMatchInlineSnapshot(`
+                  "Uploaded test-name (TIMINGS)
+                  Published test-name (TIMINGS)
+                    test-name.test-sub-domain.workers.dev"
+              `);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+        expect(std.warn).toMatchInlineSnapshot(`""`);
+      });
+
+      it("should error when defining wasm modules for modules format workers", async () => {
+        writeWranglerToml({
+          wasm_modules: {
+            TESTWASMNAME: "./path/to/test.wasm",
+          },
+        });
+        writeWorkerSource({ type: "esm" });
+        fs.mkdirSync("./path/to", { recursive: true });
+        fs.writeFileSync("./path/to/test.wasm", "SOME WASM CONTENT");
+
+        await expect(
+          runWrangler("publish index.js")
+        ).rejects.toThrowErrorMatchingInlineSnapshot(
+          `"You cannot configure [wasm_modules] with an ES module worker. Instead, import the .wasm module directly in your code"`
+        );
+        expect(std.out).toMatchInlineSnapshot(`""`);
+        expect(std.err).toMatchInlineSnapshot(`
+                  "You cannot configure [wasm_modules] with an ES module worker. Instead, import the .wasm module directly in your code
+
+                  %s If you think this is a bug then please create an issue at https://github.com/cloudflare/wrangler2/issues/new."
+              `);
+        expect(std.warn).toMatchInlineSnapshot(`""`);
+      });
+
+      it("should resolve wasm modules relative to the wrangler.toml file", async () => {
+        fs.mkdirSync("./path/to/and/the/path/to/", { recursive: true });
+        fs.writeFileSync(
+          "./path/to/wrangler.toml",
+          TOML.stringify({
+            compatibility_date: "2022-01-12",
+            name: "test-name",
+            wasm_modules: {
+              TESTWASMNAME: "./and/the/path/to/test.wasm",
+            },
+          }),
+
+          "utf-8"
+        );
+
+        writeWorkerSource({ type: "sw" });
+        fs.writeFileSync(
+          "./path/to/and/the/path/to/test.wasm",
+          "SOME WASM CONTENT"
+        );
+        mockUploadWorkerRequest({
+          expectedType: "sw",
+          expectedModules: { TESTWASMNAME: "SOME WASM CONTENT" },
+          expectedBindings: [
+            { name: "TESTWASMNAME", part: "TESTWASMNAME", type: "wasm_module" },
+          ],
+          expectedCompatibilityDate: "2022-01-12",
+        });
+        mockSubDomainRequest();
+        await runWrangler("publish index.js --config ./path/to/wrangler.toml");
+        expect(std.out).toMatchInlineSnapshot(`
+                  "Uploaded test-name (TIMINGS)
+                  Published test-name (TIMINGS)
+                    test-name.test-sub-domain.workers.dev"
+              `);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+        expect(std.warn).toMatchInlineSnapshot(`""`);
+      });
+
+      it("should be able to import .wasm modules from service-worker format workers", async () => {
+        writeWranglerToml();
+        fs.writeFileSync(
+          "./index.js",
+          "import TESTWASMNAME from './test.wasm';"
+        );
+        fs.writeFileSync("./test.wasm", "SOME WASM CONTENT");
+        mockUploadWorkerRequest({
+          expectedType: "sw",
+          expectedModules: {
+            __94b240d0d692281e6467aa42043986e5c7eea034_test_wasm:
+              "SOME WASM CONTENT",
+          },
+          expectedBindings: [
+            {
+              name: "__94b240d0d692281e6467aa42043986e5c7eea034_test_wasm",
+              part: "__94b240d0d692281e6467aa42043986e5c7eea034_test_wasm",
+              type: "wasm_module",
+            },
+          ],
+        });
+        mockSubDomainRequest();
+        await runWrangler("publish index.js");
+        expect(std.out).toMatchInlineSnapshot(`
+                  "Uploaded test-name (TIMINGS)
+                  Published test-name (TIMINGS)
+                    test-name.test-sub-domain.workers.dev"
+              `);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+        expect(std.warn).toMatchInlineSnapshot(`""`);
+      });
+    });
+
+    describe("[text_blobs]", () => {
+      it("should be able to define text blobs for service-worker format workers", async () => {
+        writeWranglerToml({
+          text_blobs: {
+            TESTTEXTBLOBNAME: "./path/to/text.file",
+          },
+        });
+        writeWorkerSource({ type: "sw" });
+        fs.mkdirSync("./path/to", { recursive: true });
+        fs.writeFileSync("./path/to/text.file", "SOME TEXT CONTENT");
+        mockUploadWorkerRequest({
+          expectedType: "sw",
+          expectedModules: { TESTTEXTBLOBNAME: "SOME TEXT CONTENT" },
+          expectedBindings: [
+            {
+              name: "TESTTEXTBLOBNAME",
+              part: "TESTTEXTBLOBNAME",
+              type: "text_blob",
+            },
+          ],
+        });
+        mockSubDomainRequest();
+        await runWrangler("publish index.js");
+        expect(std.out).toMatchInlineSnapshot(`
+                  "Uploaded test-name (TIMINGS)
+                  Published test-name (TIMINGS)
+                    test-name.test-sub-domain.workers.dev"
+              `);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+        expect(std.warn).toMatchInlineSnapshot(`""`);
+      });
+
+      it("should error when defining text blobs for modules format workers", async () => {
+        writeWranglerToml({
+          text_blobs: {
+            TESTTEXTBLOBNAME: "./path/to/text.file",
+          },
+        });
+        writeWorkerSource({ type: "esm" });
+        fs.mkdirSync("./path/to", { recursive: true });
+        fs.writeFileSync("./path/to/text.file", "SOME TEXT CONTENT");
+
+        await expect(
+          runWrangler("publish index.js")
+        ).rejects.toThrowErrorMatchingInlineSnapshot(
+          `"You cannot configure [text_blobs] with an ES module worker. Instead, import the file directly in your code, and optionally configure \`[build.upload.rules]\` in your wrangler.toml"`
+        );
+        expect(std.out).toMatchInlineSnapshot(`""`);
+        expect(std.err).toMatchInlineSnapshot(`
+                  "You cannot configure [text_blobs] with an ES module worker. Instead, import the file directly in your code, and optionally configure \`[build.upload.rules]\` in your wrangler.toml
+
+                  %s If you think this is a bug then please create an issue at https://github.com/cloudflare/wrangler2/issues/new."
+              `);
+        expect(std.warn).toMatchInlineSnapshot(`""`);
+      });
+
+      it("should resolve text blobs relative to the wrangler.toml file", async () => {
+        fs.mkdirSync("./path/to/and/the/path/to/", { recursive: true });
+        fs.writeFileSync(
+          "./path/to/wrangler.toml",
+          TOML.stringify({
+            compatibility_date: "2022-01-12",
+            name: "test-name",
+            text_blobs: {
+              TESTTEXTBLOBNAME: "./and/the/path/to/text.file",
+            },
+          }),
+
+          "utf-8"
+        );
+
+        writeWorkerSource({ type: "sw" });
+        fs.writeFileSync(
+          "./path/to/and/the/path/to/text.file",
+          "SOME TEXT CONTENT"
+        );
+        mockUploadWorkerRequest({
+          expectedType: "sw",
+          expectedModules: { TESTTEXTBLOBNAME: "SOME TEXT CONTENT" },
+          expectedBindings: [
+            {
+              name: "TESTTEXTBLOBNAME",
+              part: "TESTTEXTBLOBNAME",
+              type: "text_blob",
+            },
+          ],
+          expectedCompatibilityDate: "2022-01-12",
+        });
+        mockSubDomainRequest();
+        await runWrangler("publish index.js --config ./path/to/wrangler.toml");
+        expect(std.out).toMatchInlineSnapshot(`
+                  "Uploaded test-name (TIMINGS)
+                  Published test-name (TIMINGS)
+                    test-name.test-sub-domain.workers.dev"
+              `);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+        expect(std.warn).toMatchInlineSnapshot(`""`);
+      });
+    });
+
+    describe("[vars]", () => {
+      it("should support json bindings", async () => {
+        writeWranglerToml({
+          vars: {
+            text: "plain ol' string",
+            count: 1,
+            complex: { enabled: true, id: 123 },
+          },
+        });
+        writeWorkerSource();
+        mockSubDomainRequest();
+        mockUploadWorkerRequest({
+          expectedBindings: [
+            { name: "text", type: "plain_text", text: "plain ol' string" },
+            { name: "count", type: "json", json: 1 },
+            {
+              name: "complex",
+              type: "json",
+              json: { enabled: true, id: 123 },
+            },
+          ],
+        });
+
+        await runWrangler("publish index.js");
+        expect(std.out).toMatchInlineSnapshot(`
+                  "Uploaded test-name (TIMINGS)
+                  Published test-name (TIMINGS)
+                    test-name.test-sub-domain.workers.dev"
+              `);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+        expect(std.warn).toMatchInlineSnapshot(`""`);
       });
-      writeWorkerSource({ type: "esm" });
-      fs.mkdirSync("./path/to", { recursive: true });
-      fs.writeFileSync("./path/to/text.file", "SOME TEXT CONTENT");
+    });
 
-      await expect(
-        runWrangler("publish index.js")
-      ).rejects.toThrowErrorMatchingInlineSnapshot(
-        `"You cannot configure [text_blobs] with an ES module worker. Instead, import the file directly in your code, and optionally configure \`[build.upload.rules]\` in your wrangler.toml"`
-      );
-      expect(std.out).toMatchInlineSnapshot(`""`);
-      expect(std.err).toMatchInlineSnapshot(`
-        "You cannot configure [text_blobs] with an ES module worker. Instead, import the file directly in your code, and optionally configure \`[build.upload.rules]\` in your wrangler.toml
+    describe("[r2_buckets]", () => {
+      it("should support r2 bucket bindings", async () => {
+        writeWranglerToml({
+          r2_buckets: [{ binding: "FOO", bucket_name: "foo-bucket" }],
+        });
+        writeWorkerSource();
+        mockSubDomainRequest();
+        mockUploadWorkerRequest({
+          expectedBindings: [
+            { bucket_name: "foo-bucket", name: "FOO", type: "r2_bucket" },
+          ],
+        });
 
-        %s If you think this is a bug then please create an issue at https://github.com/cloudflare/wrangler2/issues/new."
-      `);
-      expect(std.warn).toMatchInlineSnapshot(`""`);
+        await runWrangler("publish index.js");
+        expect(std.out).toMatchInlineSnapshot(`
+                  "Uploaded test-name (TIMINGS)
+                  Published test-name (TIMINGS)
+                    test-name.test-sub-domain.workers.dev"
+              `);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+        expect(std.warn).toMatchInlineSnapshot(`""`);
+      });
     });
 
-    it("should resolve text blobs relative to the wrangler.toml file", async () => {
-      fs.mkdirSync("./path/to/and/the/path/to/", { recursive: true });
-      fs.writeFileSync(
-        "./path/to/wrangler.toml",
-        TOML.stringify({
-          compatibility_date: "2022-01-12",
-          name: "test-name",
-          text_blobs: {
-            TESTTEXTBLOBNAME: "./and/the/path/to/text.file",
+    describe("[durable_objects]", () => {
+      it("should support durable object bindings", async () => {
+        writeWranglerToml({
+          durable_objects: {
+            bindings: [
+              {
+                name: "EXAMPLE_DO_BINDING",
+                class_name: "ExampleDurableObject",
+              },
+            ],
           },
-        }),
+        });
+        writeWorkerSource({ type: "esm" });
+        mockSubDomainRequest();
+        mockUploadWorkerRequest({
+          expectedBindings: [
+            {
+              class_name: "ExampleDurableObject",
+              name: "EXAMPLE_DO_BINDING",
+              type: "durable_object_namespace",
+            },
+          ],
+        });
 
-        "utf-8"
-      );
+        await runWrangler("publish index.js");
+        expect(std.out).toMatchInlineSnapshot(`
+                  "Uploaded test-name (TIMINGS)
+                  Published test-name (TIMINGS)
+                    test-name.test-sub-domain.workers.dev"
+              `);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+        expect(std.warn).toMatchInlineSnapshot(`""`);
+      });
 
-      writeWorkerSource({ type: "sw" });
-      fs.writeFileSync(
-        "./path/to/and/the/path/to/text.file",
-        "SOME TEXT CONTENT"
-      );
-      mockUploadWorkerRequest({
-        expectedType: "sw",
-        expectedModules: { TESTTEXTBLOBNAME: "SOME TEXT CONTENT" },
-        expectedBindings: [
-          {
-            name: "TESTTEXTBLOBNAME",
-            part: "TESTTEXTBLOBNAME",
-            type: "text_blob",
+      it("should support service-workers binding to external durable objects", async () => {
+        writeWranglerToml({
+          durable_objects: {
+            bindings: [
+              {
+                name: "EXAMPLE_DO_BINDING",
+                class_name: "ExampleDurableObject",
+                script_name: "example-do-binding-worker",
+              },
+            ],
           },
-        ],
-        expectedCompatibilityDate: "2022-01-12",
-      });
-      mockSubDomainRequest();
-      await runWrangler("publish index.js --config ./path/to/wrangler.toml");
-      expect(std.out).toMatchInlineSnapshot(`
-        "Uploaded test-name (TIMINGS)
-        Published test-name (TIMINGS)
-          test-name.test-sub-domain.workers.dev"
-      `);
-      expect(std.err).toMatchInlineSnapshot(`""`);
-      expect(std.warn).toMatchInlineSnapshot(`""`);
-    });
-  });
+        });
+        writeWorkerSource({ type: "sw" });
+        mockSubDomainRequest();
+        mockUploadWorkerRequest({
+          expectedType: "sw",
+          expectedBindings: [
+            {
+              name: "EXAMPLE_DO_BINDING",
+              class_name: "ExampleDurableObject",
+              script_name: "example-do-binding-worker",
+              type: "durable_object_namespace",
+            },
+          ],
+        });
 
-  describe("vars bindings", () => {
-    it("should support json bindings", async () => {
-      writeWranglerToml({
-        vars: {
-          text: "plain ol' string",
-          count: 1,
-          complex: { enabled: true, id: 123 },
-        },
+        await runWrangler("publish index.js");
+        expect(std.out).toMatchInlineSnapshot(`
+                  "Uploaded test-name (TIMINGS)
+                  Published test-name (TIMINGS)
+                    test-name.test-sub-domain.workers.dev"
+              `);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+        expect(std.warn).toMatchInlineSnapshot(`""`);
       });
-      writeWorkerSource();
-      mockSubDomainRequest();
-      mockUploadWorkerRequest({
-        expectedBindings: [
-          { name: "text", type: "plain_text", text: "plain ol' string" },
-          { name: "count", type: "json", json: 1 },
-          {
-            name: "complex",
-            type: "json",
-            json: { enabled: true, id: 123 },
+
+      it("should support module workers implementing durable objects", async () => {
+        writeWranglerToml({
+          durable_objects: {
+            bindings: [
+              {
+                name: "EXAMPLE_DO_BINDING",
+                class_name: "ExampleDurableObject",
+              },
+            ],
           },
-        ],
+        });
+        writeWorkerSource({ type: "esm" });
+        mockSubDomainRequest();
+        mockUploadWorkerRequest({
+          expectedType: "esm",
+          expectedBindings: [
+            {
+              name: "EXAMPLE_DO_BINDING",
+              class_name: "ExampleDurableObject",
+              type: "durable_object_namespace",
+            },
+          ],
+        });
+
+        await runWrangler("publish index.js");
+        expect(std.out).toMatchInlineSnapshot(`
+                  "Uploaded test-name (TIMINGS)
+                  Published test-name (TIMINGS)
+                    test-name.test-sub-domain.workers.dev"
+              `);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+        expect(std.warn).toMatchInlineSnapshot(`""`);
       });
 
-      await runWrangler("publish index.js");
-      expect(std.out).toMatchInlineSnapshot(`
-        "Uploaded test-name (TIMINGS)
-        Published test-name (TIMINGS)
-          test-name.test-sub-domain.workers.dev"
-      `);
-      expect(std.err).toMatchInlineSnapshot(`""`);
-      expect(std.warn).toMatchInlineSnapshot(`""`);
-    });
-  });
+      it("should error when detecting service workers implementing  durable objects", async () => {
+        writeWranglerToml({
+          durable_objects: {
+            bindings: [
+              {
+                name: "EXAMPLE_DO_BINDING",
+                class_name: "ExampleDurableObject",
+              },
+            ],
+          },
+        });
+        writeWorkerSource({ type: "sw" });
+        mockSubDomainRequest();
 
-  describe("r2 bucket bindings", () => {
-    it("should support r2 bucket bindings", async () => {
-      writeWranglerToml({
-        r2_buckets: [{ binding: "FOO", bucket_name: "foo-bucket" }],
-      });
-      writeWorkerSource();
-      mockSubDomainRequest();
-      mockUploadWorkerRequest({
-        expectedBindings: [
-          { bucket_name: "foo-bucket", name: "FOO", type: "r2_bucket" },
-        ],
+        await expect(runWrangler("publish index.js")).rejects
+          .toThrowErrorMatchingInlineSnapshot(`
+                              "You seem to be trying to use Durable Objects in a Worker written with Service Worker syntax.
+                              You can use Durable Objects defined in other Workers by specifying a \`script_name\` in your wrangler.toml, where \`script_name\` is the name of the Worker that implements that Durable Object. For example:
+                              { name = EXAMPLE_DO_BINDING, class_name = ExampleDurableObject } ==> { name = EXAMPLE_DO_BINDING, class_name = ExampleDurableObject, script_name = example-do-binding-worker }
+                              Alternatively, migrate your worker to ES Module syntax to implement a Durable Object in this Worker:
+                              https://developers.cloudflare.com/workers/learning/migrating-to-module-workers/"
+                          `);
       });
-
-      await runWrangler("publish index.js");
-      expect(std.out).toMatchInlineSnapshot(`
-        "Uploaded test-name (TIMINGS)
-        Published test-name (TIMINGS)
-          test-name.test-sub-domain.workers.dev"
-      `);
-      expect(std.err).toMatchInlineSnapshot(`""`);
-      expect(std.warn).toMatchInlineSnapshot(`""`);
     });
-  });
 
-  describe("unsafe bindings", () => {
-    it("should warn if using unsafe bindings", async () => {
-      writeWranglerToml({
-        unsafe: {
-          bindings: [
+    describe("[unsafe]", () => {
+      it("should warn if using unsafe bindings", async () => {
+        writeWranglerToml({
+          unsafe: {
+            bindings: [
+              {
+                name: "my-binding",
+                type: "binding-type",
+                param: "binding-param",
+              },
+            ],
+          },
+        });
+        writeWorkerSource();
+        mockSubDomainRequest();
+        mockUploadWorkerRequest({
+          expectedBindings: [
             {
               name: "my-binding",
               type: "binding-type",
               param: "binding-param",
             },
           ],
-        },
+        });
+
+        await runWrangler("publish index.js");
+        expect(std.out).toMatchInlineSnapshot(`
+                  "Uploaded test-name (TIMINGS)
+                  Published test-name (TIMINGS)
+                    test-name.test-sub-domain.workers.dev"
+              `);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+        expect(std.warn).toMatchInlineSnapshot(`
+                  "Processing wrangler.toml configuration:
+                    - \\"unsafe\\" fields are experimental and may change or break at any time."
+              `);
       });
-      writeWorkerSource();
-      mockSubDomainRequest();
-      mockUploadWorkerRequest({
-        expectedBindings: [
-          {
-            name: "my-binding",
-            type: "binding-type",
-            param: "binding-param",
+      it("should warn if using unsafe bindings already handled by wrangler", async () => {
+        writeWranglerToml({
+          unsafe: {
+            bindings: [
+              {
+                name: "my-binding",
+                type: "plain_text",
+                text: "text",
+              },
+            ],
           },
-        ],
-      });
-
-      await runWrangler("publish index.js");
-      expect(std.out).toMatchInlineSnapshot(`
-        "Uploaded test-name (TIMINGS)
-        Published test-name (TIMINGS)
-          test-name.test-sub-domain.workers.dev"
-      `);
-      expect(std.err).toMatchInlineSnapshot(`""`);
-      expect(std.warn).toMatchInlineSnapshot(`
-        "Processing wrangler.toml configuration:
-          - \\"unsafe\\" fields are experimental and may change or break at any time."
-      `);
-    });
-    it("should warn if using unsafe bindings already handled by wrangler", async () => {
-      writeWranglerToml({
-        unsafe: {
-          bindings: [
+        });
+        writeWorkerSource();
+        mockSubDomainRequest();
+        mockUploadWorkerRequest({
+          expectedBindings: [
             {
               name: "my-binding",
               type: "plain_text",
               text: "text",
             },
           ],
-        },
-      });
-      writeWorkerSource();
-      mockSubDomainRequest();
-      mockUploadWorkerRequest({
-        expectedBindings: [
-          {
-            name: "my-binding",
-            type: "plain_text",
-            text: "text",
-          },
-        ],
-      });
+        });
 
-      await runWrangler("publish index.js");
-      expect(std.out).toMatchInlineSnapshot(`
-        "Uploaded test-name (TIMINGS)
-        Published test-name (TIMINGS)
-          test-name.test-sub-domain.workers.dev"
-      `);
-      expect(std.err).toMatchInlineSnapshot(`""`);
-      expect(std.warn).toMatchInlineSnapshot(`
-        "Processing wrangler.toml configuration:
-          - \\"unsafe\\" fields are experimental and may change or break at any time.
-          - \\"unsafe.bindings[0]\\": {\\"name\\":\\"my-binding\\",\\"type\\":\\"plain_text\\",\\"text\\":\\"text\\"}
-            - The binding type \\"plain_text\\" is directly supported by wrangler.
-              Consider migrating this unsafe binding to a format for 'plain_text' bindings that is supported by wrangler for optimal support.
-              For more details, see https://developers.cloudflare.com/workers/cli-wrangler/configuration"
-      `);
+        await runWrangler("publish index.js");
+        expect(std.out).toMatchInlineSnapshot(`
+                  "Uploaded test-name (TIMINGS)
+                  Published test-name (TIMINGS)
+                    test-name.test-sub-domain.workers.dev"
+              `);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+        expect(std.warn).toMatchInlineSnapshot(`
+                  "Processing wrangler.toml configuration:
+                    - \\"unsafe\\" fields are experimental and may change or break at any time.
+                    - \\"unsafe.bindings[0]\\": {\\"name\\":\\"my-binding\\",\\"type\\":\\"plain_text\\",\\"text\\":\\"text\\"}
+                      - The binding type \\"plain_text\\" is directly supported by wrangler.
+                        Consider migrating this unsafe binding to a format for 'plain_text' bindings that is supported by wrangler for optimal support.
+                        For more details, see https://developers.cloudflare.com/workers/cli-wrangler/configuration"
+              `);
+      });
     });
   });
 
@@ -2154,6 +3200,40 @@ export default{
         The default module rule {\\"type\\":\\"Text\\",\\"globs\\":[\\"**/*.txt\\",\\"**/*.html\\"]} has the same type as a previous rule (at position 0, {\\"type\\":\\"Text\\",\\"globs\\":[\\"**/*.file\\"]}). This rule will be ignored. To the previous rule, add \`fallthrough = true\` to allow the default one to also be used, or \`fallthrough = false\` to silence this warning."
       `);
     });
+
+    describe("inject process.env.NODE_ENV", () => {
+      let actualProcessEnvNodeEnv: string | undefined;
+      beforeEach(() => {
+        actualProcessEnvNodeEnv = process.env.NODE_ENV;
+        process.env.NODE_ENV = "some-node-env";
+      });
+      afterEach(() => {
+        process.env.NODE_ENV = actualProcessEnvNodeEnv;
+      });
+      it("should replace `process.env.NODE_ENV` in scripts", async () => {
+        writeWranglerToml();
+        fs.writeFileSync(
+          "./index.js",
+          `export default {
+            fetch(){
+              return new Response(process.env.NODE_ENV);
+            }
+          }`
+        );
+        mockSubDomainRequest();
+        mockUploadWorkerRequest({
+          expectedEntry: `return new Response("some-node-env");`,
+        });
+        await runWrangler("publish index.js");
+        expect(std.out).toMatchInlineSnapshot(`
+          "Uploaded test-name (TIMINGS)
+          Published test-name (TIMINGS)
+            test-name.test-sub-domain.workers.dev"
+        `);
+        expect(std.err).toMatchInlineSnapshot(`""`);
+        expect(std.warn).toMatchInlineSnapshot(`""`);
+      });
+    });
   });
 
   describe("legacy module specifiers", () => {
@@ -2211,6 +3291,30 @@ export default{
       `"Deprecation warning: detected a legacy module import in \\"./index.js\\". This will stop working in the future. Replace references to \\"index.wasm\\" with \\"./index.wasm\\";"`
     );
   });
+
+  it("should not match regular module specifiers when there aren't any possible legacy module matches", async () => {
+    // see https://github.com/cloudflare/wrangler2/issues/655 for bug details
+
+    fs.writeFileSync(
+      "./index.js",
+      `import inner from './inner/index.js'; export default {};`
+    );
+    fs.mkdirSync("./inner", { recursive: true });
+    fs.writeFileSync("./inner/index.js", `export default 123`);
+    mockSubDomainRequest();
+    mockUploadWorkerRequest();
+
+    await runWrangler(
+      "publish index.js --compatibility-date 2022-03-17 --name test-name"
+    );
+    expect(std.out).toMatchInlineSnapshot(`
+      "Uploaded test-name (TIMINGS)
+      Published test-name (TIMINGS)
+        test-name.test-sub-domain.workers.dev"
+    `);
+    expect(std.err).toMatchInlineSnapshot(`""`);
+    expect(std.warn).toMatchInlineSnapshot(`""`);
+  });
 });
 
 /** Write a mock Worker script to disk. */
@@ -2417,7 +3521,12 @@ function mockListKVNamespacesRequest(...namespaces: KVNamespaceInfo[]) {
 /** Create a mock handler for the request that tries to do a bulk upload of assets to a KV namespace. */
 function mockUploadAssetsToKVRequest(
   expectedNamespaceId: string,
-  assets: { filePath: string; content: string }[]
+  assets: {
+    filePath: string;
+    content: string;
+    expiration?: number;
+    expiration_ttl?: number;
+  }[]
 ) {
   setMockResponse(
     "/accounts/:accountId/storage/kv/namespaces/:namespaceId/bulk",
@@ -2446,8 +3555,28 @@ function mockUploadAssetsToKVRequest(
         expect(Buffer.from(upload.value, "base64").toString()).toEqual(
           asset.content
         );
+        expect(upload.expiration).toEqual(asset.expiration);
+        expect(upload.expiration_ttl).toEqual(asset.expiration_ttl);
       }
       return null;
     }
   );
 }
+
+/** Create a mock handler for thr request that does a bulk delete of unused assets */
+function mockDeleteUnusedAssetsRequest(
+  expectedNamespaceId: string,
+  assets: string[]
+) {
+  setMockResponse(
+    "/accounts/:accountId/storage/kv/namespaces/:namespaceId/bulk",
+    "DELETE",
+    ([_url, accountId, namespaceId], { body }) => {
+      expect(accountId).toEqual("some-account-id");
+      expect(namespaceId).toEqual(expectedNamespaceId);
+      const deletes = JSON.parse(body as string);
+      expect(assets).toEqual(deletes);
+      return null;
+    }
+  );
+}