wrangler 0.0.0-e7a0cd5b → 0.0.0-e87ad068

package/src/queues/cli/commands/consumer/remove.ts

@@ -1,16 +1,12 @@
-import { type Argv } from "yargs";
 import { readConfig } from "../../../../config";
 import { logger } from "../../../../logger";
 import { deleteConsumer } from "../../../client";
-import type { CommonYargsOptions } from "../../../../yargs-types";
+import type {
+	CommonYargsArgv,
+	StrictYargsOptionsToInterface,
+} from "../../../../yargs-types";
 
-type Args = CommonYargsOptions & {
-	config?: string;
-	["queue-name"]: string;
-	["script-name"]: string;
-};
-
-export function options(yargs: Argv<CommonYargsOptions>): Argv<Args> {
+export function options(yargs: CommonYargsArgv) {
 	return yargs
 		.positional("queue-name", {
 			type: "string",
@@ -24,15 +20,12 @@ export function options(yargs: Argv<CommonYargsOptions>): Argv<Args> {
 		});
 }
 
-export async function handler(args: Args) {
+export async function handler(
+	args: StrictYargsOptionsToInterface<typeof options>
+) {
 	const config = readConfig(args.config, args);
 
-	logger.log(`Removing consumer from queue ${args["queue-name"]}.`);
-	await deleteConsumer(
-		config,
-		args["queue-name"],
-		args["script-name"],
-		args.env
-	);
-	logger.log(`Removed consumer from queue ${args["queue-name"]}.`);
+	logger.log(`Removing consumer from queue ${args.queueName}.`);
+	await deleteConsumer(config, args.queueName, args.scriptName, args.env);
+	logger.log(`Removed consumer from queue ${args.queueName}.`);
 }

package/src/queues/cli/commands/create.ts

@@ -1,14 +1,12 @@
-import { type Argv } from "yargs";
 import { readConfig } from "../../../config";
 import { logger } from "../../../logger";
 import { createQueue } from "../../client";
+import type {
+	CommonYargsArgv,
+	StrictYargsOptionsToInterface,
+} from "../../../yargs-types";
 
-interface Args {
-	config?: string;
-	name: string;
-}
-
-export function options(yargs: Argv): Argv<Args> {
+export function options(yargs: CommonYargsArgv) {
 	return yargs.positional("name", {
 		type: "string",
 		demandOption: true,
@@ -16,7 +14,9 @@ export function options(yargs: Argv): Argv<Args> {
 	});
 }
 
-export async function handler(args: Args) {
+export async function handler(
+	args: StrictYargsOptionsToInterface<typeof options>
+) {
 	const config = readConfig(args.config, args);
 
 	logger.log(`Creating queue ${args.name}.`);

package/src/queues/cli/commands/delete.ts

@@ -1,14 +1,12 @@
-import { type Argv } from "yargs";
 import { readConfig } from "../../../config";
 import { logger } from "../../../logger";
 import { deleteQueue } from "../../client";
+import type {
+	CommonYargsArgv,
+	StrictYargsOptionsToInterface,
+} from "../../../yargs-types";
 
-interface Args {
-	config?: string;
-	name: string;
-}
-
-export function options(yargs: Argv): Argv<Args> {
+export function options(yargs: CommonYargsArgv) {
 	// TODO(soon) --force option
 	return yargs.positional("name", {
 		type: "string",
@@ -17,7 +15,9 @@ export function options(yargs: Argv): Argv<Args> {
 	});
 }
 
-export async function handler(args: Args) {
+export async function handler(
+	args: StrictYargsOptionsToInterface<typeof options>
+) {
 	const config = readConfig(args.config, args);
 
 	logger.log(`Deleting queue ${args.name}.`);

package/src/queues/cli/commands/index.ts

@@ -1,12 +1,12 @@
-import { type BuilderCallback } from "yargs";
-import { type CommonYargsOptions } from "../../../yargs-types";
+import { HandleUnauthorizedError } from "../../utils";
 import { consumers } from "./consumer";
 
 import { options as createOptions, handler as createHandler } from "./create";
 import { options as deleteOptions, handler as deleteHandler } from "./delete";
 import { options as listOptions, handler as listHandler } from "./list";
+import type { CommonYargsArgv } from "../../../yargs-types";
 
-export const queues: BuilderCallback<CommonYargsOptions, unknown> = (yargs) => {
+export function queues(yargs: CommonYargsArgv) {
 	yargs.command("list", "List Queues", listOptions, listHandler);
 
 	yargs.command(
@@ -30,4 +30,6 @@ export const queues: BuilderCallback<CommonYargsOptions, unknown> = (yargs) => {
 			await consumers(consumersYargs);
 		}
 	);
-};
+
+	yargs.fail(HandleUnauthorizedError);
+}

package/src/queues/cli/commands/list.ts

@@ -1,14 +1,12 @@
-import { type Argv } from "yargs";
 import { readConfig } from "../../../config";
 import { logger } from "../../../logger";
 import { listQueues } from "../../client";
+import type {
+	CommonYargsArgv,
+	StrictYargsOptionsToInterface,
+} from "../../../yargs-types";
 
-interface Args {
-	config?: string;
-	page?: number;
-}
-
-export function options(yargs: Argv): Argv<Args> {
+export function options(yargs: CommonYargsArgv) {
 	return yargs.options({
 		page: {
 			type: "number",
@@ -17,7 +15,9 @@ export function options(yargs: Argv): Argv<Args> {
 	});
 }
 
-export async function handler(args: Args) {
+export async function handler(
+	args: StrictYargsOptionsToInterface<typeof options>
+) {
 	const config = readConfig(args.config, args);
 
 	const queues = await listQueues(config, args.page);

package/src/queues/client.ts

@@ -90,6 +90,7 @@ export interface ConsumerSettings {
 	batch_size?: number;
 	max_retries?: number;
 	max_wait_time_ms?: number;
+	max_concurrency?: number | null;
 }
 
 export interface ConsumerResponse extends PostConsumerBody {

package/src/queues/utils.ts

@@ -0,0 +1,18 @@
+import { logger } from "../logger";
+import { type ParseError } from "../parse";
+import { getAccountId } from "../user";
+
+const isFetchError = (err: unknown): err is ParseError => err instanceof Error;
+
+export const HandleUnauthorizedError = async (_msg: string, err: Error) => {
+	//@ts-expect-error non-standard property on Error
+	if (isFetchError(err) && err.code === 10023) {
+		const accountId = await getAccountId();
+		if (accountId) {
+			return logger.log(
+				`Queues is not currently enabled on this account. Go to https://dash.cloudflare.com/${accountId}/workers/queues to enable it.`
+			);
+		}
+	}
+	throw err;
+};

package/src/r2/constants.ts

@@ -0,0 +1,4 @@
+/**
+ * The maximum file size we can upload using the V4 API.
+ */
+export const MAX_UPLOAD_SIZE = 300 * 1024 * 1024;

package/src/r2/helpers.ts

@@ -113,6 +113,7 @@ export async function putR2Object(
 			body: object,
 			headers,
 			method: "PUT",
+			duplex: "half",
 		}
 	);
 }

package/src/r2/index.ts

@@ -1,11 +1,14 @@
 import * as fs from "node:fs";
 import * as stream from "node:stream";
 
+import prettyBytes from "pretty-bytes";
 import { readConfig } from "../config";
+import { FatalError } from "../errors";
 import { CommandLineArgsError, printWranglerBanner } from "../index";
 import { logger } from "../logger";
 import * as metrics from "../metrics";
 import { requireAuth } from "../user";
+import { MAX_UPLOAD_SIZE } from "./constants";
 import {
 	bucketAndKeyFromObjectPath,
 	createR2Bucket,
@@ -16,22 +19,23 @@ import {
 	putR2Object,
 } from "./helpers";
 
-import type { ConfigPath } from "../index";
+import type { CommonYargsArgv } from "../yargs-types";
 import type { Readable } from "node:stream";
-import type { BuilderCallback } from "yargs";
 
-export const r2: BuilderCallback<unknown, unknown> = (r2Yargs) => {
+export function r2(r2Yargs: CommonYargsArgv) {
 	return r2Yargs
 		.command("object", "Manage R2 objects", (r2ObjectYargs) => {
 			return r2ObjectYargs
 				.command(
 					"get <objectPath>",
 					"Fetch an object from an R2 bucket",
-					(Objectyargs) => {
-						return Objectyargs.positional("objectPath", {
-							describe: "The source object path in the form of {bucket}/{key}",
-							type: "string",
-						})
+					(objectArgs) => {
+						return objectArgs
+							.positional("objectPath", {
+								describe:
+									"The source object path in the form of {bucket}/{key}",
+								type: "string",
+							})
 							.option("file", {
 								describe: "The destination file to create",
 								alias: "f",
@@ -48,10 +52,7 @@ export const r2: BuilderCallback<unknown, unknown> = (r2Yargs) => {
 							});
 					},
 					async (objectGetYargs) => {
-						const config = readConfig(
-							objectGetYargs.config as ConfigPath,
-							objectGetYargs
-						);
+						const config = readConfig(objectGetYargs.config, objectGetYargs);
 						const accountId = await requireAuth(config);
 						const { objectPath, pipe } = objectGetYargs;
 						const { bucket, key } = bucketAndKeyFromObjectPath(objectPath);
@@ -141,10 +142,7 @@ export const r2: BuilderCallback<unknown, unknown> = (r2Yargs) => {
 					async (objectPutYargs) => {
 						await printWranglerBanner();
 
-						const config = readConfig(
-							objectPutYargs.config as ConfigPath,
-							objectPutYargs
-						);
+						const config = readConfig(objectPutYargs.config, objectPutYargs);
 						const accountId = await requireAuth(config);
 						const { objectPath, file, pipe, ...options } = objectPutYargs;
 						const { bucket, key } = bucketAndKeyFromObjectPath(objectPath);
@@ -176,6 +174,15 @@ export const r2: BuilderCallback<unknown, unknown> = (r2Yargs) => {
 							objectSize = object.byteLength;
 						}
 
+						if (objectSize > MAX_UPLOAD_SIZE) {
+							throw new FatalError(
+								`Error: Wrangler only supports uploading files up to ${prettyBytes(
+									MAX_UPLOAD_SIZE
+								)} in size\n${key} is ${prettyBytes(objectSize)} in size`,
+								1
+							);
+						}
+
 						logger.log(`Creating object "${key}" in bucket "${bucket}".`);
 						await putR2Object(accountId, bucket, key, object, {
 							...options,
@@ -198,7 +205,7 @@ export const r2: BuilderCallback<unknown, unknown> = (r2Yargs) => {
 						const { objectPath } = args;
 						await printWranglerBanner();
 
-						const config = readConfig(args.config as ConfigPath, args);
+						const config = readConfig(args.config, args);
 						const accountId = await requireAuth(config);
 						const { bucket, key } = bucketAndKeyFromObjectPath(objectPath);
 						logger.log(`Deleting object "${key}" from bucket "${bucket}".`);
@@ -223,7 +230,7 @@ export const r2: BuilderCallback<unknown, unknown> = (r2Yargs) => {
 				async (args) => {
 					await printWranglerBanner();
 
-					const config = readConfig(args.config as ConfigPath, args);
+					const config = readConfig(args.config, args);
 
 					const accountId = await requireAuth(config);
 
@@ -236,16 +243,21 @@ export const r2: BuilderCallback<unknown, unknown> = (r2Yargs) => {
 				}
 			);
 
-			r2BucketYargs.command("list", "List R2 buckets", {}, async (args) => {
-				const config = readConfig(args.config as ConfigPath, args);
+			r2BucketYargs.command(
+				"list",
+				"List R2 buckets",
+				(listArgs) => listArgs,
+				async (args) => {
+					const config = readConfig(args.config, args);
 
-				const accountId = await requireAuth(config);
+					const accountId = await requireAuth(config);
 
-				logger.log(JSON.stringify(await listR2Buckets(accountId), null, 2));
-				await metrics.sendMetricsEvent("list r2 buckets", {
-					sendMetrics: config.send_metrics,
-				});
-			});
+					logger.log(JSON.stringify(await listR2Buckets(accountId), null, 2));
+					await metrics.sendMetricsEvent("list r2 buckets", {
+						sendMetrics: config.send_metrics,
+					});
+				}
+			);
 
 			r2BucketYargs.command(
 				"delete <name>",
@@ -260,7 +272,7 @@ export const r2: BuilderCallback<unknown, unknown> = (r2Yargs) => {
 				async (args) => {
 					await printWranglerBanner();
 
-					const config = readConfig(args.config as ConfigPath, args);
+					const config = readConfig(args.config, args);
 
 					const accountId = await requireAuth(config);
 
@@ -274,4 +286,4 @@ export const r2: BuilderCallback<unknown, unknown> = (r2Yargs) => {
 			);
 			return r2BucketYargs;
 		});
-};
+}

package/src/secret/index.ts

@@ -13,14 +13,12 @@ import * as metrics from "../metrics";
 import { parseJSON, readFileSync } from "../parse";
 import { requireAuth } from "../user";
 
-import type { ConfigPath } from "../index";
 import type {
-	CommonYargsOptions,
-	YargsOptionsToInterface,
+	CommonYargsArgv,
+	StrictYargsOptionsToInterface,
 } from "../yargs-types";
-import type { Argv } from "yargs";
 
-export const secret = (secretYargs: Argv<CommonYargsOptions>) => {
+export const secret = (secretYargs: CommonYargsArgv) => {
 	return secretYargs
 		.option("legacy-env", {
 			type: "boolean",
@@ -44,7 +42,7 @@ export const secret = (secretYargs: Argv<CommonYargsOptions>) => {
 			},
 			async (args) => {
 				await printWranglerBanner();
-				const config = readConfig(args.config as ConfigPath, args);
+				const config = readConfig(args.config, args);
 
 				const scriptName = getLegacyScriptName(args, config);
 				if (!scriptName) {
@@ -58,7 +56,7 @@ export const secret = (secretYargs: Argv<CommonYargsOptions>) => {
 				const isInteractive = process.stdin.isTTY;
 				const secretValue = trimTrailingWhitespace(
 					isInteractive
-						? await prompt("Enter a secret value:", "password")
+						? await prompt("Enter a secret value:", { isSecret: true })
 						: await readFromStdin()
 				);
 
@@ -102,19 +100,23 @@ export const secret = (secretYargs: Argv<CommonYargsOptions>) => {
 								},
 								bindings: {
 									kv_namespaces: [],
+									send_email: [],
 									vars: {},
-									metadata_binding: undefined,
 									durable_objects: { bindings: [] },
 									queues: [],
 									r2_buckets: [],
 									d1_databases: [],
+									constellation: [],
 									services: [],
+									analytics_engine_datasets: [],
 									wasm_modules: {},
+									browser: undefined,
 									text_blobs: {},
 									data_blobs: {},
 									dispatch_namespaces: [],
+									mtls_certificates: [],
 									logfwdr: { schema: undefined, bindings: [] },
-									unsafe: [],
+									unsafe: { bindings: undefined, metadata: undefined },
 								},
 								modules: [],
 								migrations: undefined,
@@ -123,6 +125,8 @@ export const secret = (secretYargs: Argv<CommonYargsOptions>) => {
 								usage_model: undefined,
 								keepVars: false, // this doesn't matter since it's a new script anyway
 								logpush: false,
+								placement: undefined,
+								tail_consumers: undefined,
 							}),
 						}
 					);
@@ -172,7 +176,7 @@ export const secret = (secretYargs: Argv<CommonYargsOptions>) => {
 					});
 			},
 			async (args) => {
-				const config = readConfig(args.config as ConfigPath, args);
+				const config = readConfig(args.config, args);
 
 				const scriptName = getLegacyScriptName(args, config);
 				if (!scriptName) {
@@ -222,7 +226,7 @@ export const secret = (secretYargs: Argv<CommonYargsOptions>) => {
 				});
 			},
 			async (args) => {
-				const config = readConfig(args.config as ConfigPath, args);
+				const config = readConfig(args.config, args);
 
 				const scriptName = getLegacyScriptName(args, config);
 				if (!scriptName) {
@@ -246,7 +250,7 @@ export const secret = (secretYargs: Argv<CommonYargsOptions>) => {
 		);
 };
 
-export const secretBulkOptions = (yargs: Argv<CommonYargsOptions>) => {
+export const secretBulkOptions = (yargs: CommonYargsArgv) => {
 	return yargs
 		.positional("json", {
 			describe: `The JSON file of key-value pairs to upload, in form {"key": value, ...}`,
@@ -301,14 +305,11 @@ function readFromStdin(): Promise<string> {
 	});
 }
 
-type SecretBulkArgs = YargsOptionsToInterface<typeof secretBulkOptions>;
+type SecretBulkArgs = StrictYargsOptionsToInterface<typeof secretBulkOptions>;
 
 export const secretBulkHandler = async (secretBulkArgs: SecretBulkArgs) => {
 	await printWranglerBanner();
-	const config = readConfig(
-		secretBulkArgs.config as ConfigPath,
-		secretBulkArgs
-	);
+	const config = readConfig(secretBulkArgs.config, secretBulkArgs);
 
 	const scriptName = getLegacyScriptName(secretBulkArgs, config);
 	if (!scriptName) {