wrangler 0.0.0-c2940160 → 0.0.0-c2b2dfb8

package/bin/wrangler.js

@@ -62,15 +62,21 @@ Consider using a Node.js version manager such as https://volta.sh/ or https://gi
 			...process.argv.slice(2),
 		],
 		{
-			stdio: "inherit",
+			stdio: ["inherit", "inherit", "inherit", "ipc"],
 			env: {
 				...process.env,
 				NODE_EXTRA_CA_CERTS: pathToCACerts,
 			},
 		}
-	).on("exit", (code) =>
-		process.exit(code === undefined || code === null ? 0 : code)
-	);
+	)
+		.on("exit", (code) =>
+			process.exit(code === undefined || code === null ? 0 : code)
+		)
+		.on("message", (message) => {
+			if (process.send) {
+				process.send(message);
+			}
+		});
 }
 
 /**
@@ -87,7 +93,15 @@ function runDelegatedWrangler() {
 	} = JSON.parse(fs.readFileSync(packageJsonPath));
 	const resolvedBinaryPath = path.resolve(packageJsonPath, "..", binaryPath);
 
-	debug(`Delegating to locally-installed version of wrangler @ v${version}`);
+	// Make sure the user knows we're delegating to a different installation
+	const currentPackageJsonPath = path.resolve(__dirname, "..", "package.json");
+	const currentPackage = JSON.parse(fs.readFileSync(currentPackageJsonPath));
+	const argv = process.argv.slice(2).join(" ");
+	console.log(
+		`Delegating to locally-installed wrangler@${version} over global wrangler@${currentPackage.version}...
+Run \`npx wrangler ${argv}\` to use the local version directly.
+`
+	);
 
 	// this call to `spawn` is simpler because the delegated version will do all
 	// of the other work.
@@ -95,11 +109,17 @@ function runDelegatedWrangler() {
 		process.execPath,
 		[resolvedBinaryPath, ...process.argv.slice(2)],
 		{
-			stdio: "inherit",
+			stdio: ["inherit", "inherit", "inherit", "ipc"],
 		}
-	).on("exit", (code) =>
-		process.exit(code === undefined || code === null ? 0 : code)
-	);
+	)
+		.on("exit", (code) =>
+			process.exit(code === undefined || code === null ? 0 : code)
+		)
+		.on("message", (message) => {
+			if (process.send) {
+				process.send(message);
+			}
+		});
 }
 
 /**

package/miniflare-dist/index.mjs

@@ -128,23 +128,45 @@ var init_environment_polyfills = __esm({
   }
 });
 
+// ../pages-shared/environment-polyfills/miniflare-tre.ts
+var miniflare_tre_exports = {};
+__export(miniflare_tre_exports, {
+  default: () => miniflare_tre_default
+});
+var miniflare_tre_default;
+var init_miniflare_tre = __esm({
+  "../pages-shared/environment-polyfills/miniflare-tre.ts"() {
+    init_environment_polyfills();
+    miniflare_tre_default = async () => {
+      const mf = await import("@miniflare/tre");
+      polyfill({
+        fetch: mf.fetch,
+        Headers: mf.Headers,
+        Request: mf.Request,
+        Response: mf.Response
+      });
+    };
+  }
+});
+
 // ../pages-shared/environment-polyfills/miniflare.ts
 var miniflare_exports = {};
-import {
-  fetch as miniflareFetch,
-  Headers as MiniflareHeaders,
-  Request as MiniflareRequest,
-  Response as MiniflareResponse
-} from "@miniflare/core";
+__export(miniflare_exports, {
+  default: () => miniflare_default
+});
+var miniflare_default;
 var init_miniflare = __esm({
   "../pages-shared/environment-polyfills/miniflare.ts"() {
     init_environment_polyfills();
-    polyfill({
-      fetch: miniflareFetch,
-      Headers: MiniflareHeaders,
-      Request: MiniflareRequest,
-      Response: MiniflareResponse
-    });
+    miniflare_default = async () => {
+      const mf = await import("@miniflare/core");
+      polyfill({
+        fetch: mf.fetch,
+        Headers: mf.Headers,
+        Request: mf.Request,
+        Response: mf.Response
+      });
+    };
   }
 });
 
@@ -329,6 +351,15 @@ var init_rulesEngine = __esm({
   }
 });
 
+// ../pages-shared/asset-server/url.ts
+function stringifyURLToRootRelativePathname(url) {
+  return `${url.pathname}${url.search}${url.hash}`;
+}
+var init_url = __esm({
+  "../pages-shared/asset-server/url.ts"() {
+  }
+});
+
 // ../pages-shared/asset-server/handler.ts
 var handler_exports = {};
 __export(handler_exports, {
@@ -339,6 +370,7 @@ __export(handler_exports, {
   HEADERS_VERSION_V1: () => HEADERS_VERSION_V1,
   REDIRECTS_VERSION: () => REDIRECTS_VERSION2,
   generateHandler: () => generateHandler,
+  getResponseFromMatch: () => getResponseFromMatch,
   normaliseHeaders: () => normaliseHeaders,
   parseQualityWeightedList: () => parseQualityWeightedList
 });
@@ -409,22 +441,7 @@ async function generateHandler({
   async function generateResponse() {
     const match = staticRedirectsMatcher() || generateRedirectsMatcher()({ request })[0];
     if (match) {
-      const { status, to } = match;
-      const destination = new URL(to, request.url);
-      const location = destination.origin === new URL(request.url).origin ? `${destination.pathname}${destination.search || search}${destination.hash}` : `${destination.href}${destination.search ? "" : search}${destination.hash}`;
-      switch (status) {
-        case 301:
-          return new MovedPermanentlyResponse(location);
-        case 303:
-          return new SeeOtherResponse(location);
-        case 307:
-          return new TemporaryRedirectResponse(location);
-        case 308:
-          return new PermanentRedirectResponse(location);
-        case 302:
-        default:
-          return new FoundResponse(location);
-      }
+      return getResponseFromMatch(match, url);
     }
     if (!request.method.match(/^(get|head)$/i)) {
       return new MethodNotAllowedResponse();
@@ -703,6 +720,27 @@ async function generateHandler({
     );
   }
 }
+function getResponseFromMatch({
+  status,
+  to
+}, requestUrl) {
+  const destination = new URL(to, requestUrl);
+  destination.search = destination.search || requestUrl.search;
+  const location = destination.origin === requestUrl.origin ? stringifyURLToRootRelativePathname(destination) : destination.toString();
+  switch (status) {
+    case 301:
+      return new MovedPermanentlyResponse(location);
+    case 303:
+      return new SeeOtherResponse(location);
+    case 307:
+      return new TemporaryRedirectResponse(location);
+    case 308:
+      return new PermanentRedirectResponse(location);
+    case 302:
+    default:
+      return new FoundResponse(location);
+  }
+}
 function parseQualityWeightedList(list = "") {
   const items = {};
   list.replace(/\s/g, "").split(",").forEach((el) => {
@@ -728,6 +766,7 @@ var init_handler = __esm({
   "../pages-shared/asset-server/handler.ts"() {
     init_responses();
     init_rulesEngine();
+    init_url();
     ASSET_PRESERVATION_CACHE = "assetPreservationCache";
     CACHE_CONTROL_PRESERVATION = "public, s-maxage=604800";
     CACHE_CONTROL_BROWSER = "public, max-age=0, must-revalidate";
@@ -749,8 +788,8 @@ import {
   Log as MiniflareLog,
   LogLevel as MiniflareLogLevel,
   Miniflare,
-  Request as MiniflareRequest3,
-  Response as MiniflareResponse3
+  Request as MiniflareRequest,
+  Response as MiniflareResponse
 } from "miniflare";
 
 // ../../node_modules/yargs/lib/platform-shims/esm.mjs
@@ -5632,7 +5671,11 @@ function constructRedirects({
   for (const rule of redirects.rules) {
     if (!rule.from.match(SPLAT_REGEX) && !rule.from.match(PLACEHOLDER_REGEX)) {
       if (canCreateStaticRule) {
-        staticRedirects[rule.from] = { status: rule.status, to: rule.to };
+        staticRedirects[rule.from] = {
+          status: rule.status,
+          to: rule.to,
+          lineNumber: rule.lineNumber
+        };
         continue;
       } else {
         logger(
@@ -5974,11 +6017,6 @@ function parseRedirects(input) {
 
 // src/miniflare-cli/assets.ts
 var import_mime = __toESM(require_mime());
-import { fetch as miniflareFetch2 } from "@miniflare/core";
-import {
-  Response as MiniflareResponse2,
-  Request as MiniflareRequest2
-} from "@miniflare/core";
 import { watch } from "chokidar";
 
 // src/pages/hash.tsx
@@ -5994,28 +6032,34 @@ var hashFile = (filepath) => {
 
 // src/miniflare-cli/assets.ts
 async function generateASSETSBinding(options) {
-  const assetsFetch = options.directory !== void 0 ? await generateAssetsFetch(options.directory, options.log) : invalidAssetsFetch;
+  const assetsFetch = options.directory !== void 0 ? await generateAssetsFetch(options.directory, options.log, options.tre) : invalidAssetsFetch;
+  const miniflare = options.tre ? await import("@miniflare/tre") : await import("@miniflare/core");
+  const Request = miniflare.Request;
+  const Response2 = miniflare.Response;
+  const fetch2 = options.tre ? miniflare.fetch : (await import("@miniflare/web-sockets")).upgradingFetch;
   return async function(miniflareRequest) {
     if (options.proxyPort) {
       try {
         const url = new URL(miniflareRequest.url);
         url.host = `localhost:${options.proxyPort}`;
-        return await miniflareFetch2(url, miniflareRequest);
+        const proxyRequest = new Request(url, miniflareRequest);
+        if (proxyRequest.headers.get("Upgrade") === "websocket") {
+          proxyRequest.headers.delete("Sec-WebSocket-Accept");
+          proxyRequest.headers.delete("Sec-WebSocket-Key");
+        }
+        return await fetch2(proxyRequest);
       } catch (thrown) {
         options.log.error(new Error(`Could not proxy request: ${thrown}`));
-        return new MiniflareResponse2(
-          `[wrangler] Could not proxy request: ${thrown}`,
-          {
-            status: 502
-          }
-        );
+        return new Response2(`[wrangler] Could not proxy request: ${thrown}`, {
+          status: 502
+        });
       }
     } else {
       try {
         return await assetsFetch(miniflareRequest);
       } catch (thrown) {
         options.log.error(new Error(`Could not serve static asset: ${thrown}`));
-        return new MiniflareResponse2(
+        return new Response2(
           `[wrangler] Could not serve static asset: ${thrown}`,
           { status: 502 }
         );
@@ -6023,8 +6067,11 @@ async function generateASSETSBinding(options) {
     }
   };
 }
-async function generateAssetsFetch(directory, log) {
-  await Promise.resolve().then(() => (init_miniflare(), miniflare_exports));
+async function generateAssetsFetch(directory, log, tre) {
+  const polyfill2 = tre ? (await Promise.resolve().then(() => (init_miniflare_tre(), miniflare_tre_exports))).default : (await Promise.resolve().then(() => (init_miniflare(), miniflare_exports))).default;
+  await polyfill2();
+  const miniflare = tre ? await import("@miniflare/tre") : await import("@miniflare/core");
+  const Request = miniflare.Request;
   const { generateHandler: generateHandler2, parseQualityWeightedList: parseQualityWeightedList2 } = await Promise.resolve().then(() => (init_handler(), handler_exports));
   const headersFile = join(directory, "_headers");
   const redirectsFile = join(directory, "_redirects");
@@ -6118,7 +6165,7 @@ async function generateAssetsFetch(directory, log) {
     });
   };
   return async (input, init) => {
-    const request = new MiniflareRequest2(input, init);
+    const request = new Request(input, init);
     return await generateResponse(request);
   };
 }
@@ -6186,12 +6233,12 @@ async function main() {
         namespace.get = (id) => {
           const stub = new DurableObjectStub(factory, id);
           stub.fetch = (...reqArgs) => {
-            const requestFromArgs = new MiniflareRequest3(...reqArgs);
+            const requestFromArgs = new MiniflareRequest(...reqArgs);
             const url = new URL(requestFromArgs.url);
             url.host = host;
             if (port !== void 0)
               url.port = port.toString();
-            const request = new MiniflareRequest3(
+            const request = new MiniflareRequest(
               url.toString(),
               requestFromArgs
             );
@@ -6224,7 +6271,8 @@ async function main() {
       const options = {
         log: config.log,
         proxyPort: opts.proxyPort,
-        directory: opts.directory
+        directory: opts.directory,
+        tre: false
       };
       config.serviceBindings = {
         ...config.serviceBindings,
@@ -6250,7 +6298,7 @@ async function main() {
 				}`,
         serviceBindings: {
           DO: async (request) => {
-            request = new MiniflareRequest3(request);
+            request = new MiniflareRequest(request);
             const name = request.headers.get("x-miniflare-durable-object-name");
             const idString = request.headers.get(
               "x-miniflare-durable-object-id"
@@ -6258,7 +6306,7 @@ async function main() {
             request.headers.delete("x-miniflare-durable-object-name");
             request.headers.delete("x-miniflare-durable-object-id");
             if (!name || !idString) {
-              return new MiniflareResponse3(
+              return new MiniflareResponse(
                 "[durable-object-proxy-err] Missing `x-miniflare-durable-object-name` or `x-miniflare-durable-object-id` headers.",
                 { status: 400 }
               );
@@ -6266,14 +6314,14 @@ async function main() {
             const namespace = await mf?.getDurableObjectNamespace(name);
             const id = namespace?.idFromString(idString);
             if (!id) {
-              return new MiniflareResponse3(
+              return new MiniflareResponse(
                 "[durable-object-proxy-err] Could not generate an ID. Possibly due to a mismatched DO name and ID?",
                 { status: 500 }
               );
             }
             const stub = namespace?.get(id);
             if (!stub) {
-              return new MiniflareResponse3(
+              return new MiniflareResponse(
                 "[durable-object-proxy-err] Could not generate a stub. Possibly due to a mismatched DO name and ID?",
                 { status: 500 }
               );

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "wrangler",
-	"version": "0.0.0-c2940160",
+	"version": "0.0.0-c2b2dfb8",
 	"description": "Command-line interface for all things Cloudflare Workers",
 	"keywords": [
 		"wrangler",
@@ -57,7 +57,7 @@
 		"assert-git-version": "node -r esbuild-register scripts/assert-git-version.ts",
 		"build": "npm run clean && npm run bundle && npm run emit-types",
 		"bundle": "node -r esbuild-register scripts/bundle.ts",
-		"check:type": "tsc",
+		"check:type": "node -r esbuild-register scripts/tsc-all.ts",
 		"clean": "rimraf wrangler-dist miniflare-dist emitted-types",
 		"dev": "npm run clean && concurrently -c black,blue --kill-others-on-fail false 'npm run bundle -- --watch' 'npm run check:type -- --watch --preserveWatchOutput'",
 		"emit-types": "tsc -p tsconfig.emit.json && node -r esbuild-register scripts/emit-types.ts",
@@ -115,11 +115,12 @@
 	},
 	"devDependencies": {
 		"@cloudflare/types": "^6.18.4",
+		"@cloudflare/workers-types": "^4.20221111.1",
 		"@databases/split-sql-query": "^1.0.3",
 		"@databases/sql": "^3.2.0",
 		"@iarna/toml": "^3.0.0",
 		"@microsoft/api-extractor": "^7.28.3",
-		"@miniflare/tre": "^3.0.0-next.7",
+		"@miniflare/tre": "^3.0.0-next.8",
 		"@types/better-sqlite3": "^7.6.0",
 		"@types/busboy": "^1.5.0",
 		"@types/command-exists": "^1.2.0",
@@ -136,6 +137,7 @@
 		"@types/yargs": "^17.0.10",
 		"@webcontainer/env": "^1.0.1",
 		"body-parser": "^1.20.0",
+		"chalk": "^2.4.2",
 		"clipboardy": "^3.0.0",
 		"cmd-shim": "^4.1.0",
 		"command-exists": "^1.2.9",
@@ -162,7 +164,7 @@
 		"jest-websocket-mock": "^2.3.0",
 		"mime": "^3.0.0",
 		"minimatch": "^5.1.0",
-		"msw": "^0.47.1",
+		"msw": "^0.49.1",
 		"npx-import": "^1.1.3",
 		"open": "^8.4.0",
 		"p-queue": "^7.2.0",

package/src/__tests__/api-dev.test.ts

@@ -5,7 +5,7 @@ import { runInTempDir } from "./helpers/run-in-tmp";
 
 jest.unmock("undici");
 
-describe.skip("unstable_dev", () => {
+describe("unstable_dev", () => {
 	it("should return Hello World", async () => {
 		const worker = await unstable_dev(
 			"src/__tests__/helpers/worker-scripts/hello-world-worker.js",

package/src/__tests__/api-devregistry.test.js

@@ -1,13 +1,13 @@
 import { unstable_dev } from "../api";
 import { fetch } from "undici";
 
-// jest.unmock("undici");
+jest.unmock("undici");
 
 /**
  * a huge caveat to how testing multi-worker scripts works:
  * you can't shutdown the first worker you spun up, or it'll kill the devRegistry
  */
-describe.skip("multi-worker testing", () => {
+describe("multi-worker testing", () => {
 	let childWorker;
 	let parentWorker;