wp-advads 1.0.37 → 1.0.39

package/package.json

@@ -1,7 +1,7 @@
 {
   "type": "module",
   "name": "wp-advads",
-  "version": "1.0.37",
+  "version": "1.0.39",
   "description": "Create an Advanced Ads WordPress plugin ecosystem.",
   "author": {
     "name": "Shakeeb Ahmed",

package/src/utilities/shell.js

@@ -3,6 +3,14 @@
  */
 import { spawn } from 'node:child_process'
 
+function spawnArgv( file, args, spawnOpts ) {
+	if ( process.platform !== 'win32' ) {
+		return spawn( file, args, { ...spawnOpts, shell: false } )
+	}
+
+	return spawn( file, args, { ...spawnOpts, shell: true } )
+}
+
 /**
  * Run a command in the terminal.
  *
@@ -38,7 +46,7 @@ export function execCommand( command, callback, options = {} ) {
 	}
 
 	const child = Array.isArray( command )
-		? spawn( command[0], command.slice( 1 ), { ...spawnOpts, shell: false } )
+		? spawnArgv( command[0], command.slice( 1 ), spawnOpts )
 		: spawn( command, { ...spawnOpts, shell: true } )
 
 	let stdout = ''

package/test/shell.test.js

@@ -3,7 +3,7 @@
  * TASK-005: argv is not interpolated through a shell.
  */
 import assert from 'node:assert/strict'
-import { existsSync, rmSync } from 'node:fs'
+import { existsSync, readFileSync, rmSync } from 'node:fs'
 import { tmpdir } from 'node:os'
 import { join } from 'node:path'
 import { test } from 'node:test'
@@ -130,3 +130,11 @@ test( 'execCommand does not ENOBUFS on stdout larger than 1MB', async () => {
 		console.log = originalLog
 	}
 } )
+
+test( 'Windows argv spawn uses a shell so PATHEXT commands like wp.cmd resolve', () => {
+	const src = readFileSync( new URL( '../src/utilities/shell.js', import.meta.url ), 'utf8' )
+	const spawnArgv = src.split( 'function spawnArgv' )[1].split( 'export function' )[0]
+	assert.match( spawnArgv, /process\.platform !== 'win32'/ )
+	assert.match( spawnArgv, /shell:\s*false/ )
+	assert.match( spawnArgv, /shell:\s*true/ )
+} )