workspace-tools 0.24.0 → 0.25.0

package/CHANGELOG.json

@@ -2,7 +2,22 @@
   "name": "workspace-tools",
   "entries": [
     {
-      "date": "Wed, 20 Jul 2022 22:31:28 GMT",
+      "date": "Thu, 21 Jul 2022 21:11:05 GMT",
+      "tag": "workspace-tools_v0.25.0",
+      "version": "0.25.0",
+      "comments": {
+        "minor": [
+          {
+            "author": "dlannoye@microsoft.com",
+            "package": "workspace-tools",
+            "comment": "BREAKING CHANGE: Improve detection of git root and throw if not found",
+            "commit": "00be591c06d9c14eba7f2b76cb8aac5f0246fdec"
+          }
+        ]
+      }
+    },
+    {
+      "date": "Wed, 20 Jul 2022 22:31:31 GMT",
       "tag": "workspace-tools_v0.24.0",
       "version": "0.24.0",
       "comments": {

package/CHANGELOG.md

@@ -1,12 +1,20 @@
 # Change Log - workspace-tools
 
-This log was last generated on Wed, 20 Jul 2022 22:31:28 GMT and should not be manually modified.
+This log was last generated on Thu, 21 Jul 2022 21:11:05 GMT and should not be manually modified.
 
 <!-- Start content -->
 
+## 0.25.0
+
+Thu, 21 Jul 2022 21:11:05 GMT
+
+### Minor changes
+
+- BREAKING CHANGE: Improve detection of git root and throw if not found (dlannoye@microsoft.com)
+
 ## 0.24.0
 
-Wed, 20 Jul 2022 22:31:28 GMT
+Wed, 20 Jul 2022 22:31:31 GMT
 
 ### Minor changes
 

package/lib/git/getDefaultRemote.js

@@ -20,9 +20,6 @@ function getDefaultRemote(cwdOrOptions) {
         log(message);
     };
     const gitRoot = (0, paths_1.findGitRoot)(cwd);
-    if (!gitRoot) {
-        throw new Error(`Directory "${cwd}" does not appear to be in a git repository`);
-    }
     let packageJson = {};
     const packageJsonPath = path_1.default.join(gitRoot, "package.json");
     try {

package/lib/paths.d.ts

@@ -3,9 +3,10 @@
  */
 export declare function searchUp(pathName: string, cwd: string): string | null;
 /**
- * Starting from `cwd`, searches up the directory hierarchy for `.git`.
+ * Starting from `cwd`, uses `git rev-parse --show-toplevel` to find the root of the git repo.
+ * Throws if `cwd` is not in a Git repository.
  */
-export declare function findGitRoot(cwd: string): string | null;
+export declare function findGitRoot(cwd: string): string;
 /**
  * Starting from `cwd`, searches up the directory hierarchy for `package.json`.
  */
@@ -14,5 +15,5 @@ export declare function findPackageRoot(cwd: string): string | null;
  * Starting from `cwd`, searches up the directory hierarchy for the workspace root,
  * falling back to the git root if no workspace is detected.
  */
-export declare function findProjectRoot(cwd: string): string | null;
+export declare function findProjectRoot(cwd: string): string;
 export declare function isChildOf(child: string, parent: string): boolean;

package/lib/paths.js

@@ -7,6 +7,7 @@ exports.isChildOf = exports.findProjectRoot = exports.findPackageRoot = exports.
 const path_1 = __importDefault(require("path"));
 const fs_1 = __importDefault(require("fs"));
 const getWorkspaceRoot_1 = require("./workspaces/getWorkspaceRoot");
+const git_1 = require("./git");
 /**
  * Starting from `cwd`, searches up the directory hierarchy for `pathName`.
  */
@@ -27,10 +28,15 @@ function searchUp(pathName, cwd) {
 }
 exports.searchUp = searchUp;
 /**
- * Starting from `cwd`, searches up the directory hierarchy for `.git`.
+ * Starting from `cwd`, uses `git rev-parse --show-toplevel` to find the root of the git repo.
+ * Throws if `cwd` is not in a Git repository.
  */
 function findGitRoot(cwd) {
-    return searchUp(".git", cwd);
+    const output = (0, git_1.git)(["rev-parse", "--show-toplevel"], { cwd });
+    if (!output.success) {
+        throw new Error(`Directory "${cwd}" is not in a git repository`);
+    }
+    return path_1.default.normalize(output.stdout);
 }
 exports.findGitRoot = findGitRoot;
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "workspace-tools",
-  "version": "0.24.0",
+  "version": "0.25.0",
   "license": "MIT",
   "repository": {
     "type": "git",