wolverine-ai 4.1.0 → 4.2.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "wolverine-ai",
-  "version": "4.1.0",
+  "version": "4.2.0",
   "description": "Self-healing Node.js server framework powered by AI. Catches crashes, diagnoses errors, generates fixes, verifies, and restarts — automatically.",
   "main": "src/index.js",
   "bin": {

package/src/core/error-hook.js

@@ -34,7 +34,15 @@ Module._load = function (request, parent, isMain) {
       _hookFastify(instance);
       return instance;
     };
-    Object.keys(originalFastify).forEach((key) => { wrapped[key] = originalFastify[key]; });
+    // #23: Copy all own properties (including non-enumerable and symbols) to preserve prototype chain
+    for (const key of Object.getOwnPropertyNames(originalFastify)) {
+      if (key !== "length" && key !== "name" && key !== "prototype") {
+        try { wrapped[key] = originalFastify[key]; } catch {}
+      }
+    }
+    for (const sym of Object.getOwnPropertySymbols(originalFastify)) {
+      try { wrapped[sym] = originalFastify[sym]; } catch {}
+    }
     wrapped.default = wrapped; // ESM compat
     return wrapped;
   }
@@ -48,7 +56,15 @@ Module._load = function (request, parent, isMain) {
       _hookExpress(app);
       return app;
     };
-    Object.keys(originalExpress).forEach((key) => { wrapped[key] = originalExpress[key]; });
+    // #23: Copy all own properties (including non-enumerable and symbols)
+    for (const key of Object.getOwnPropertyNames(originalExpress)) {
+      if (key !== "length" && key !== "name" && key !== "prototype") {
+        try { wrapped[key] = originalExpress[key]; } catch {}
+      }
+    }
+    for (const sym of Object.getOwnPropertySymbols(originalExpress)) {
+      try { wrapped[sym] = originalExpress[sym]; } catch {}
+    }
     return wrapped;
   }
 
@@ -94,9 +110,13 @@ function _hookExpress(app) {
   // Wrap app.listen to inject error middleware AFTER all user middleware
   const originalListen = app.listen;
   app.listen = function (...args) {
-    app.use(function _wolverineErrorHook(err, req, res, next) {
-      _reportError(req.originalUrl || req.url, req.method, err);
-      next(err);
+    // #24: Use process.nextTick to ensure our error middleware is added AFTER
+    // any middleware registered synchronously after listen() is called
+    process.nextTick(() => {
+      app.use(function _wolverineErrorHook(err, req, res, next) {
+        _reportError(req.originalUrl || req.url, req.method, err);
+        next(err);
+      });
     });
     return originalListen.apply(this, args);
   };
@@ -114,7 +134,8 @@ function _reportError(url, method, error) {
     let file = null, line = null;
     if (error.stack) {
       for (const frame of error.stack.split("\n")) {
-        const m = frame.match(/\(([^)]+):(\d+):(\d+)\)/) || frame.match(/at\s+([^\s(]+):(\d+):(\d+)/);
+        // #25: Second regex uses (.+) instead of ([^\s(]+) to handle Windows paths with spaces
+        const m = frame.match(/\(([^)]+):(\d+):(\d+)\)/) || frame.match(/at\s+(.+):(\d+):(\d+)/);
         if (m && !m[1].includes("node_modules") && !m[1].includes("node:")) {
           file = m[1]; line = parseInt(m[2], 10); break;
         }

package/src/core/runner.js

@@ -284,7 +284,9 @@ class WolverineRunner {
     this._clearStabilityTimer();
     // Clear any pending heals — restart is a clean slate
     this._pendingErrorHeal = null;
-    this._healInProgress = false;
+    // #1: Don't clear _healInProgress here — only the heal function itself should clear it
+    // #6: Clear stale heal status so dashboard doesn't show phantom heals
+    this._healStatus = null;
 
     if (this.child) {
       const oldChild = this.child;
@@ -295,11 +297,9 @@ class WolverineRunner {
       const onExit = () => {
         if (spawned) return; // Prevent double-spawn from exit + force-kill timeout
         spawned = true;
+        // #7: Don't call _ensurePortFree() here — _spawn() already calls it
         // Give port time to fully release (TIME_WAIT)
-        setTimeout(() => {
-          this._ensurePortFree();
-          setTimeout(() => this._spawn(), 500);
-        }, 500);
+        setTimeout(() => this._spawn(), 500);
       };
 
       oldChild.removeAllListeners("exit");
@@ -314,7 +314,7 @@ class WolverineRunner {
         }
       }, 3000);
     } else {
-      this._ensurePortFree();
+      // #7: Don't call _ensurePortFree() here — _spawn() already calls it
       setTimeout(() => this._spawn(), 500);
     }
   }
@@ -394,7 +394,12 @@ class WolverineRunner {
       process.stderr.write(text);
     });
 
-    this._startStabilityTimer();
+    // #27: Only start stability timer if there's a backup to promote — don't clear
+    // an existing timer on every spawn (e.g., auto-update restart shouldn't reset
+    // the stability countdown for a previously healed backup)
+    if (this._lastBackupId) {
+      this._startStabilityTimer();
+    }
 
     // Start process monitor (memory, CPU, heartbeat)
     if (this.child && this.child.pid) {
@@ -418,32 +423,46 @@ class WolverineRunner {
     this.healthMonitor.stop();
     this.healthMonitor.reset();
     this.healthMonitor.start(async (reason) => {
-      if (this._healInProgress || !this.running) return;
-      console.log(chalk.red(`\n🚨 Health check triggered heal (reason: ${reason})`));
-      this.logger.error(EVENT_TYPES.HEALTH_UNRESPONSIVE, `Server unresponsive: ${reason}`, { reason });
-      this.healthMonitor.stop();
-
-      // Kill the hung process — remove exit listener to prevent double-heal
-      if (this.child) {
-        const pid = this.child.pid;
-        this.child.removeAllListeners("exit");
-        this._killProcessTree(pid, "SIGKILL");
-        this.child = null;
-      }
+      try {
+        if (this._healInProgress || !this.running) return;
+        // #26: Claim the heal lock immediately — prevents exit event from starting
+        // a concurrent heal between our check and the child kill below
+        this._healInProgress = true;
+        console.log(chalk.red(`\n🚨 Health check triggered heal (reason: ${reason})`));
+        this.logger.error(EVENT_TYPES.HEALTH_UNRESPONSIVE, `Server unresponsive: ${reason}`, { reason });
+        this.healthMonitor.stop();
+
+        // Kill the hung process — remove exit listener to prevent double-heal
+        if (this.child) {
+          const pid = this.child.pid;
+          this.child.removeAllListeners("exit");
+          this._killProcessTree(pid, "SIGKILL");
+          this.child = null;
+        }
 
-      // Synthesize error context for the heal pipeline
-      this._stderrBuffer = `Server became unresponsive. Health check failed: ${reason}\n` +
-        `The server was running but stopped responding to HTTP requests.\n` +
-        `Possible causes: infinite loop, deadlock, memory exhaustion, blocked event loop.`;
+        // Synthesize error context for the heal pipeline
+        this._stderrBuffer = `Server became unresponsive. Health check failed: ${reason}\n` +
+          `The server was running but stopped responding to HTTP requests.\n` +
+          `Possible causes: infinite loop, deadlock, memory exhaustion, blocked event loop.`;
 
-      this.retryCount++;
-      if (this.retryCount > this.maxRetries) {
-        console.log(chalk.red(`\n🛑 Max retries reached.`));
-        this._logRollbackHint();
-        this.running = false;
-        return;
+        this.retryCount++;
+        if (this.retryCount > this.maxRetries) {
+          console.log(chalk.red(`\n🛑 Max retries reached.`));
+          this._logRollbackHint();
+          this.running = false;
+          this._healInProgress = false;
+          return;
+        }
+        // Release lock so _healAndRestart can acquire it
+        this._healInProgress = false;
+        await this._healAndRestart();
+      } catch (err) {
+        // #5: Prevent unhandled errors in health callback from crashing the parent
+        console.log(chalk.red(`  ⚠️  Health callback error: ${err.message}`));
+        this._healInProgress = false;
+        this._healStatus = null;
+        if (this.running) this._spawn();
       }
-      await this._healAndRestart();
     });
 
     this.child.on("exit", async (code, signal) => {
@@ -541,6 +560,8 @@ class WolverineRunner {
 
   async _healAndRestart() {
     if (this._healInProgress) return;
+    // #9: Bail if stop() was called during the window between crash and heal
+    if (this._shuttingDown) return;
     this._healInProgress = true;
     this._healStatus = { active: true, error: this._stderrBuffer.slice(0, 200), phase: "diagnosing", startedAt: Date.now() };
 
@@ -567,6 +588,8 @@ class WolverineRunner {
     }
 
     try {
+      // #9: Check again before expensive heal — stop() may have been called during loop guard
+      if (this._shuttingDown) { this._healInProgress = false; return; }
       const result = await heal({
         stderr: this._stderrBuffer,
         cwd: this.cwd,
@@ -606,6 +629,8 @@ class WolverineRunner {
         this._healStatus = null;
         // Clear pending errors — the heal fixed the root cause, stale errors are irrelevant
         this._pendingErrorHeal = null;
+        // #9: Don't restart if stop() was called while heal was running
+        if (this._shuttingDown) return;
         // Use restart() to properly kill old child before spawning — prevents EADDRINUSE
         this.restart();
       } else {
@@ -673,6 +698,15 @@ class WolverineRunner {
     }
     this._healInProgress = true;
 
+    // #8: Safety timeout — if heal hangs, force-release the lock after 6 minutes
+    const healTimeout = setTimeout(() => {
+      if (this._healInProgress) {
+        console.log(chalk.red(`  ⚠️  _healFromError safety timeout (6min) — releasing heal lock`));
+        this._healInProgress = false;
+        this._healStatus = null;
+      }
+    }, 360000);
+
     console.log(chalk.yellow(`\n🐺 Wolverine healing caught error on ${routePath}...`));
     this._healStatus = { active: true, route: routePath, error: errorDetails?.message?.slice(0, 200), phase: "diagnosing", startedAt: Date.now() };
     this.logger.info("heal.error_monitor", `Healing caught 500 on ${routePath}`, { route: routePath });
@@ -727,6 +761,7 @@ class WolverineRunner {
         routeContext: { path: routePath, method: errorDetails?.method },
       });
 
+      clearTimeout(healTimeout);
       if (result.healed) {
         console.log(chalk.green(`\n🐺 Wolverine healed ${routePath} via ${result.mode}! Restarting...\n`));
         this.retryCount = 0; // Fresh start after successful heal
@@ -748,6 +783,7 @@ class WolverineRunner {
         this._healStatus = null;
       }
     } catch (err) {
+      clearTimeout(healTimeout);
       console.log(chalk.red(`\n🐺 Error during heal: ${err.message}`));
       this._healInProgress = false;
       this._healStatus = null;

package/src/core/verifier.js

@@ -23,6 +23,8 @@ const BOOT_PROBE_TIMEOUT_MS = 10000; // 10 seconds
  */
 function syntaxCheck(scriptPath) {
   return new Promise((resolve) => {
+    // #21: Guard against double resolve from exit + error firing in sequence
+    let settled = false;
     const child = spawn("node", ["--check", scriptPath], {
       stdio: ["ignore", "ignore", "pipe"],
       timeout: 5000,
@@ -32,6 +34,8 @@ function syntaxCheck(scriptPath) {
     child.stderr.on("data", (data) => { stderr += data.toString(); });
 
     child.on("exit", (code) => {
+      if (settled) return;
+      settled = true;
       resolve({
         valid: code === 0,
         error: code !== 0 ? stderr.trim() : undefined,
@@ -39,6 +43,8 @@ function syntaxCheck(scriptPath) {
     });
 
     child.on("error", (err) => {
+      if (settled) return;
+      settled = true;
       resolve({ valid: false, error: err.message });
     });
   });
@@ -71,6 +77,8 @@ function bootProbe(scriptPath, cwd, originalErrorSignature) {
     child.on("exit", (code) => {
       if (settled) return;
       settled = true;
+      // #19: Always ensure the child is killed after settling (handles orphan sub-processes)
+      try { child.kill("SIGTERM"); } catch {}
 
       if (code === 0) {
         resolve({ status: "alive" });
@@ -101,6 +109,8 @@ function bootProbe(scriptPath, cwd, originalErrorSignature) {
     child.on("error", (err) => {
       if (settled) return;
       settled = true;
+      // #19: Always ensure the child is killed after settling
+      try { child.kill("SIGTERM"); } catch {}
       resolve({ status: "crashed", stderr: err.message, sameError: false, exitCode: null });
     });
 
@@ -192,9 +202,10 @@ async function verifyFix(scriptPath, cwd, originalErrorSignature, routeContext)
     const relPath = path.relative(cwd, changedFile).replace(/\\/g, "/");
     if (relPath.startsWith("server/") && relPath.endsWith(".js")) {
       try {
-        const { execSync } = require("child_process");
+        const { execFileSync } = require("child_process");
+        // #22: Use execFileSync with args array to prevent path injection via relPath
         const testCode = `try{require('./${relPath}');console.log('MODULE_OK')}catch(e){console.error(e.message);process.exit(1)}`;
-        const out = execSync(`node -e "${testCode}"`, {
+        const out = execFileSync("node", ["-e", testCode], {
           cwd, timeout: 5000, encoding: "utf-8",
           env: { ...process.env, NODE_PATH: path.join(cwd, "node_modules") },
         });
@@ -237,6 +248,14 @@ function routeProbe(scriptPath, cwd, routeContext) {
     child.stdout.on("data", (d) => { stdout += d.toString(); });
     child.stderr.on("data", (d) => { stderr += d.toString(); });
 
+    // #20: Handle spawn errors (e.g., node binary not found)
+    child.on("error", (err) => {
+      clearInterval(checkPort);
+      if (settled) return;
+      settled = true;
+      resolve({ status: "failed", statusCode: 0, body: err.message });
+    });
+
     child.on("exit", () => {
       if (settled) return;
       settled = true;

package/src/core/wolverine.js

@@ -165,7 +165,7 @@ async function _healImpl({ stderr, cwd, sandbox, notifier, rateLimiter, backupMa
   // 4c. Pre-heal operational fix — detect common non-code errors
   // Some crashes aren't code bugs (missing npm packages, missing config files).
   // Fix these directly without wasting AI tokens.
-  const opsFix = await tryOperationalFix(parsed, cwd, logger);
+  const opsFix = await tryOperationalFix(parsed, cwd, logger, sandbox);
   if (opsFix.fixed) {
     console.log(chalk.green(`  ⚡ Operational fix applied: ${opsFix.action}`));
     if (logger) logger.info(EVENT_TYPES.HEAL_SUCCESS, `Operational fix: ${opsFix.action}`, { action: opsFix.action });
@@ -297,8 +297,15 @@ async function _healImpl({ stderr, cwd, sandbox, notifier, rateLimiter, backupMa
     goal: `Fix: ${parsed.errorMessage.slice(0, 80)}`,
 
     onAttempt: async (iteration, researchCtx, priorAttempts) => {
-      // Create backup for this attempt
-      const bid = backupManager.createBackup(`heal attempt ${iteration}: ${parsed.errorMessage.slice(0, 60)}`);
+      // #12: Create backup for this attempt — if backup fails, skip the attempt entirely
+      let bid;
+      try {
+        bid = backupManager.createBackup(`heal attempt ${iteration}: ${parsed.errorMessage.slice(0, 60)}`);
+      } catch (backupErr) {
+        console.log(chalk.red(`  ⚠️  Backup creation failed: ${backupErr.message} — skipping attempt`));
+        if (logger) logger.error(EVENT_TYPES.BACKUP_CREATED, `Backup failed: ${backupErr.message}`);
+        return { healed: false, explanation: `Backup creation failed: ${backupErr.message}` };
+      }
       backupManager.setErrorSignature(bid, errorSignature);
       if (logger) logger.info(EVENT_TYPES.BACKUP_CREATED, `Backup ${bid} (iteration ${iteration})`, { backupId: bid });
 
@@ -532,7 +539,7 @@ async function _healImpl({ stderr, cwd, sandbox, notifier, rateLimiter, backupMa
  * Try to fix common operational errors without AI.
  * Returns { fixed: boolean, action: string }
  */
-async function tryOperationalFix(parsed, cwd, logger) {
+async function tryOperationalFix(parsed, cwd, logger, sandbox) {
   const { execSync } = require("child_process");
   const msg = parsed.errorMessage || "";
 
@@ -565,9 +572,14 @@ async function tryOperationalFix(parsed, cwd, logger) {
 
     // Only auto-create if it's inside the project and looks like a config/data file
     const rel = path.relative(cwd, missingFile).replace(/\\/g, "/");
-    if (!rel.startsWith("..") && /\.(json|yaml|yml|toml|ini|conf|cfg|env|log|txt|csv|db|sqlite)$/i.test(missingFile)) {
+    // #18: Validate through sandbox to prevent creating files outside allowed paths
+    let safePath = missingFile;
+    if (sandbox) {
+      try { safePath = sandbox.resolve(missingFile); } catch { safePath = null; }
+    }
+    if (safePath && !rel.startsWith("..") && /\.(json|yaml|yml|toml|ini|conf|cfg|env|log|txt|csv|db|sqlite)$/i.test(missingFile)) {
       try {
-        fs.mkdirSync(path.dirname(missingFile), { recursive: true });
+        fs.mkdirSync(path.dirname(safePath), { recursive: true });
         const ext = path.extname(missingFile).toLowerCase();
 
         // For JSON config files, try to infer expected structure from the code or error message
@@ -600,7 +612,7 @@ async function tryOperationalFix(parsed, cwd, logger) {
           content = defaults[ext] || "";
         }
 
-        fs.writeFileSync(missingFile, content, "utf-8");
+        fs.writeFileSync(safePath, content, "utf-8");
         console.log(chalk.blue(`  📄 Created missing file: ${rel}`));
         return { fixed: true, action: `Created missing file: ${rel} with ${content === "{}" ? "empty" : "inferred"} config` };
       } catch {}
@@ -659,10 +671,13 @@ function _inferJsonConfig(missingFile, cwd, parsed) {
   const sourceFile = parsed.filePath;
   if (!sourceFile) return null;
 
+  // #17: Escape all regex special characters in basename to prevent regex injection
+  const escapedBasename = basename.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+
   try {
     const source = fs.readFileSync(sourceFile, "utf-8");
     // Look for property accesses on the loaded config: config.apiUrl, config.timeout, etc.
-    const configVarMatch = source.match(new RegExp(`(?:const|let|var)\\s+(\\w+)\\s*=\\s*(?:require|JSON\\.parse).*${basename.replace(".", "\\.")}`));
+    const configVarMatch = source.match(new RegExp(`(?:const|let|var)\\s+(\\w+)\\s*=\\s*(?:require|JSON\\.parse).*${escapedBasename}`));
     if (!configVarMatch) return null;
 
     const varName = configVarMatch[1];