wogiflow 2.4.2 → 2.4.4

package/scripts/flow-step-pr-tests.js

@@ -10,84 +10,73 @@
 
 const fs = require('node:fs');
 const path = require('node:path');
-const { getProjectRoot, colors, readJson } = require('./flow-utils');
+const { BaseWorkflowStep } = require('./base-workflow-step');
+const { colors, readJson, PATHS } = require('./flow-utils');
+
+class PrTestStep extends BaseWorkflowStep {
+  constructor() {
+    super('prTestAnalyzer', {
+      extensions: ['.js', '.ts', '.jsx', '.tsx'],
+      excludeTests: true,
+      excludeDts: true,
+    });
+  }
 
-const PROJECT_ROOT = getProjectRoot();
+  // Override filterFiles for PR-test-specific exclusions
+  filterFiles(files) {
+    return super.filterFiles(files).filter(f =>
+      !f.includes('__tests__') && !f.includes('__mocks__')
+    );
+  }
 
-/**
- * Run PR test analysis as a workflow step
- *
- * @param {object} options
- * @param {string[]} options.files - Files modified
- * @param {object} options.stepConfig - Step configuration
- * @param {string} options.mode - Step mode (block/warn/prompt/auto)
- * @returns {object} - { passed: boolean, message: string, details?: object }
- */
-async function run(options = {}) {
-  const { files = [], stepConfig = {} } = options;
-  const checkCoverage = stepConfig.checkCoverage !== false;
-  const checkQuality = stepConfig.checkQuality !== false;
-  const minCoverageForModified = stepConfig.minCoverageForModified || 70;
-
-  // Filter to source files (not test files)
-  const sourceExtensions = ['.js', '.ts', '.jsx', '.tsx'];
-  const sourceFiles = files.filter(f =>
-    sourceExtensions.some(ext => f.endsWith(ext)) &&
-    !f.includes('.test.') &&
-    !f.includes('.spec.') &&
-    !f.includes('.d.ts') &&
-    !f.includes('__tests__') &&
-    !f.includes('__mocks__')
-  );
+  async execute(sourceFiles, options) {
+    const { stepConfig = {} } = options;
+    const checkCoverage = stepConfig.checkCoverage !== false;
+    const checkQuality = stepConfig.checkQuality !== false;
+    const minCoverageForModified = stepConfig.minCoverageForModified || 70;
 
-  if (sourceFiles.length === 0) {
-    return { passed: true, message: 'No source files to analyze' };
-  }
+    // We need the original unfiltered files for test quality analysis
+    const allFiles = options.files ?? sourceFiles;
 
-  const issues = [];
-  const coverageReport = {};
-  const qualityReport = {};
-
-  // Check coverage for modified files
-  if (checkCoverage) {
-    const coverageIssues = await analyzeCoverage(sourceFiles, minCoverageForModified);
-    issues.push(...coverageIssues.issues);
-    Object.assign(coverageReport, coverageIssues.report);
-  }
+    const issues = [];
+    const coverageReport = {};
+    const qualityReport = {};
 
-  // Check test quality
-  if (checkQuality) {
-    const qualityIssues = await analyzeTestQuality(sourceFiles, files);
-    issues.push(...qualityIssues.issues);
-    Object.assign(qualityReport, qualityIssues.report);
-  }
+    if (checkCoverage) {
+      const coverageIssues = await analyzeCoverage(sourceFiles, minCoverageForModified);
+      issues.push(...coverageIssues.issues);
+      Object.assign(coverageReport, coverageIssues.report);
+    }
+
+    if (checkQuality) {
+      const qualityIssues = await analyzeTestQuality(sourceFiles, allFiles);
+      issues.push(...qualityIssues.issues);
+      Object.assign(qualityReport, qualityIssues.report);
+    }
 
-  // Report findings
-  if (issues.length > 0) {
-    console.log(colors.yellow + '\n  PR Test Analysis Issues:' + colors.reset);
-    for (const issue of issues) {
-      const icon = issue.severity === 'high' ? '\u{1F534}' : '\u{1F7E1}';
-      console.log(`    ${icon} ${issue.file}`);
-      console.log(`       ${issue.type}: ${issue.message}`);
-      if (issue.suggestion) {
-        console.log(colors.dim + `       \u{2192} ${issue.suggestion}` + colors.reset);
+    if (issues.length > 0) {
+      console.log(colors.yellow + '\n  PR Test Analysis Issues:' + colors.reset);
+      for (const issue of issues) {
+        const icon = issue.severity === 'high' ? '\u{1F534}' : '\u{1F7E1}';
+        console.log(`    ${icon} ${issue.file}`);
+        console.log(`       ${issue.type}: ${issue.message}`);
+        if (issue.suggestion) {
+          console.log(colors.dim + `       \u{2192} ${issue.suggestion}` + colors.reset);
+        }
       }
     }
-  }
 
-  const highSeverity = issues.filter(i => i.severity === 'high');
+    const highSeverity = issues.filter(i => i.severity === 'high');
 
-  return {
-    passed: highSeverity.length === 0,
-    message: issues.length === 0
+    const message = issues.length === 0
       ? `Test analysis passed (${sourceFiles.length} files)`
-      : `${issues.length} issue(s) found (${highSeverity.length} high severity)`,
-    details: {
-      issues,
-      coverage: coverageReport,
-      quality: qualityReport,
-    },
-  };
+      : `${issues.length} issue(s) found (${highSeverity.length} high severity)`;
+    const details = { issues, coverage: coverageReport, quality: qualityReport };
+
+    return highSeverity.length === 0
+      ? { passed: true, message, details }
+      : this.fail(message, details);
+  }
 }
 
 /**
@@ -98,7 +87,7 @@ async function analyzeCoverage(sourceFiles, minCoverage) {
   const report = { checked: [], missing: [], below: [] };
 
   // Check if coverage report exists
-  const coveragePath = path.join(PROJECT_ROOT, 'coverage', 'coverage-summary.json');
+  const coveragePath = path.join(PATHS.root, 'coverage', 'coverage-summary.json');
   let coverageData = null;
 
   if (fs.existsSync(coveragePath)) {
@@ -106,7 +95,7 @@ async function analyzeCoverage(sourceFiles, minCoverage) {
   }
 
   for (const file of sourceFiles) {
-    const filePath = path.join(PROJECT_ROOT, file);
+    const filePath = path.join(PATHS.root, file);
     if (!fs.existsSync(filePath)) continue;
 
     // Find corresponding test file
@@ -118,7 +107,7 @@ async function analyzeCoverage(sourceFiles, minCoverage) {
     ];
 
     const hasTest = testPatterns.some(pattern => {
-      const testPath = path.join(PROJECT_ROOT, pattern);
+      const testPath = path.join(PATHS.root, pattern);
       return fs.existsSync(testPath);
     });
 
@@ -144,7 +133,7 @@ async function analyzeCoverage(sourceFiles, minCoverage) {
 
     // Check coverage if available
     if (coverageData) {
-      const absPath = path.resolve(PROJECT_ROOT, file);
+      const absPath = path.resolve(PATHS.root, file);
       const fileCoverage = coverageData[absPath];
 
       if (fileCoverage) {
@@ -182,7 +171,7 @@ async function analyzeTestQuality(sourceFiles, allFiles) {
   );
 
   for (const testFile of testFiles) {
-    const testPath = path.join(PROJECT_ROOT, testFile);
+    const testPath = path.join(PATHS.root, testFile);
     if (!fs.existsSync(testPath)) continue;
 
     try {
@@ -203,7 +192,7 @@ async function analyzeTestQuality(sourceFiles, allFiles) {
 
   // Also check source files for testability concerns
   for (const sourceFile of sourceFiles) {
-    const sourcePath = path.join(PROJECT_ROOT, sourceFile);
+    const sourcePath = path.join(PATHS.root, sourceFile);
     if (!fs.existsSync(sourcePath)) continue;
 
     try {
@@ -357,4 +346,5 @@ function checkTestability(content, fileName) {
   return issues;
 }
 
-module.exports = { run, analyzeCoverage, analyzeTestQuality };
+const step = new PrTestStep();
+module.exports = { run: (opts) => step.run(opts), analyzeCoverage, analyzeTestQuality };

package/scripts/flow-step-regression.js

@@ -9,9 +9,7 @@
 
 const { execSync } = require('node:child_process');
 const path = require('node:path');
-const { getProjectRoot } = require('./flow-utils');
-
-const PROJECT_ROOT = getProjectRoot();
+const { getProjectRoot, PATHS } = require('./flow-utils');
 
 /**
  * Run regression tests as a workflow step
@@ -28,9 +26,9 @@ async function run(options = {}) {
 
   try {
     // Run regression tests
-    const regressionScript = path.join(PROJECT_ROOT, 'scripts', 'flow-regression.js');
+    const regressionScript = path.join(PATHS.root, 'scripts', 'flow-regression.js');
     const result = execSync(`node "${regressionScript}" --count ${sampleSize} --json`, {
-      cwd: PROJECT_ROOT,
+      cwd: PATHS.root,
       encoding: 'utf8',
       stdio: ['pipe', 'pipe', 'pipe'],
     });

package/scripts/flow-step-review.js

@@ -14,9 +14,8 @@
 
 const fs = require('node:fs');
 const path = require('node:path');
-const { getProjectRoot, colors } = require('./flow-utils');
-
-const PROJECT_ROOT = getProjectRoot();
+const { BaseWorkflowStep } = require('./base-workflow-step');
+const { colors, PATHS } = require('./flow-utils');
 
 // High-risk patterns that trigger multi-agent review
 const HIGH_RISK_PATTERNS = [
@@ -28,120 +27,103 @@ const HIGH_RISK_PATTERNS = [
   'database', 'migration', 'schema',
 ];
 
-/**
- * Run code review as a workflow step
- *
- * @param {object} options
- * @param {string[]} options.files - Files modified
- * @param {object} options.stepConfig - Step configuration
- * @param {string} options.mode - Step mode (block/warn/prompt/auto)
- * @param {string} options.taskType - Type of task (feature/bugfix/refactor)
- * @returns {object} - { passed: boolean, message: string, details?: object[] }
- */
-async function run(options = {}) {
-  const { files = [], stepConfig = {}, taskType } = options;
-  const multiAgentThreshold = stepConfig.multiAgentThreshold || 5;
-  const confidenceThreshold = stepConfig.confidenceThreshold || 80;
-  const highRiskPatterns = stepConfig.highRiskPatterns || HIGH_RISK_PATTERNS;
-
-  // Filter to reviewable files
-  const reviewableExtensions = ['.js', '.ts', '.jsx', '.tsx', '.py', '.go', '.rs'];
-  const reviewableFiles = files.filter(f =>
-    reviewableExtensions.some(ext => f.endsWith(ext)) &&
-    !f.includes('.test.') &&
-    !f.includes('.spec.') &&
-    !f.includes('.d.ts')
-  );
-
-  if (reviewableFiles.length === 0) {
-    return { passed: true, message: 'No reviewable files modified' };
+class ReviewStep extends BaseWorkflowStep {
+  constructor() {
+    super('codeReview', {
+      extensions: ['.js', '.ts', '.jsx', '.tsx', '.py', '.go', '.rs'],
+      excludeTests: true,
+      excludeDts: true,
+    });
   }
 
-  // Determine if high-risk
-  const isHighRisk = taskType === 'refactor' ||
-    reviewableFiles.some(f => highRiskPatterns.some(p => f.toLowerCase().includes(p)));
+  async execute(files, options) {
+    const { stepConfig = {}, taskType } = options;
+    const multiAgentThreshold = stepConfig.multiAgentThreshold || 5;
+    const confidenceThreshold = stepConfig.confidenceThreshold || 80;
+    const highRiskPatterns = stepConfig.highRiskPatterns || HIGH_RISK_PATTERNS;
 
-  // Choose review mode
-  const useMultiAgent = reviewableFiles.length > multiAgentThreshold || isHighRisk;
+    // Determine if high-risk
+    const isHighRisk = taskType === 'refactor' ||
+      files.some(f => highRiskPatterns.some(p => f.toLowerCase().includes(p)));
 
-  let issues;
-  if (useMultiAgent) {
-    console.log(colors.cyan + '  Running multi-agent code review...' + colors.reset);
-    issues = await runMultiAgentReview(reviewableFiles, stepConfig);
-  } else {
-    console.log(colors.cyan + '  Running simple code review...' + colors.reset);
-    issues = await runSimpleReview(reviewableFiles, stepConfig);
-  }
+    // Choose review mode
+    const useMultiAgent = files.length > multiAgentThreshold || isHighRisk;
 
-  // Filter by confidence threshold
-  const reportableIssues = issues.filter(i => i.confidence >= confidenceThreshold);
+    let issues;
+    if (useMultiAgent) {
+      console.log(colors.cyan + '  Running multi-agent code review...' + colors.reset);
+      issues = await runMultiAgentReview(files, stepConfig);
+    } else {
+      console.log(colors.cyan + '  Running simple code review...' + colors.reset);
+      issues = await runSimpleReview(files, stepConfig);
+    }
 
-  if (reportableIssues.length === 0) {
-    return {
-      passed: true,
-      message: useMultiAgent
-        ? `Multi-agent review passed (${reviewableFiles.length} files)`
-        : `Simple review passed (${reviewableFiles.length} files)`,
-    };
-  }
+    // Filter by confidence threshold
+    const reportableIssues = issues.filter(i => i.confidence >= confidenceThreshold);
 
-  // Report issues
-  console.log(colors.yellow + '\n  Code Review Issues:' + colors.reset);
+    if (reportableIssues.length === 0) {
+      return this.pass(useMultiAgent
+        ? `Multi-agent review passed (${files.length} files)`
+        : `Simple review passed (${files.length} files)`);
+    }
 
-  const criticalIssues = reportableIssues.filter(i => i.severity === 'critical');
-  const importantIssues = reportableIssues.filter(i => i.severity === 'important');
+    // Report issues
+    console.log(colors.yellow + '\n  Code Review Issues:' + colors.reset);
 
-  if (criticalIssues.length > 0) {
-    console.log(colors.red + '  Critical:' + colors.reset);
-    for (const issue of criticalIssues) {
-      printIssue(issue);
-    }
-  }
+    const criticalIssues = reportableIssues.filter(i => i.severity === 'critical');
+    const importantIssues = reportableIssues.filter(i => i.severity === 'important');
 
-  if (importantIssues.length > 0) {
-    console.log(colors.yellow + '  Important:' + colors.reset);
-    for (const issue of importantIssues) {
-      printIssue(issue);
+    if (criticalIssues.length > 0) {
+      console.log(colors.red + '  Critical:' + colors.reset);
+      for (const issue of criticalIssues) {
+        printIssue(issue);
+      }
     }
-  }
-
-  // Critical issues block, important issues warn
-  const hasCritical = criticalIssues.length > 0;
 
-  // Auto-capture learnings from issues found
-  if (reportableIssues.length > 0) {
-    try {
-      const { captureFromSessionReview } = require('./flow-auto-learn');
-      captureFromSessionReview(reportableIssues);
-    } catch (err) {
-      // Auto-learn not available or failed - continue silently
+    if (importantIssues.length > 0) {
+      console.log(colors.yellow + '  Important:' + colors.reset);
+      for (const issue of importantIssues) {
+        printIssue(issue);
+      }
     }
 
-    // Also capture to tech debt ledger for persistent tracking
-    try {
-      const { TechDebtManager } = require('./flow-tech-debt');
-      const debtManager = new TechDebtManager();
-      const { added, updated } = debtManager.addIssues(reportableIssues.map(issue => ({
-        file: issue.file,
-        line: issue.line,
-        category: issue.perspective || 'code',
-        severity: issue.severity === 'critical' ? 'critical' : (issue.severity === 'important' ? 'high' : 'medium'),
-        description: issue.description,
-        fix: issue.fix || ''
-      })));
-      if (added > 0 || updated > 0) {
-        console.log(colors.dim + `  Tech debt: ${added} new, ${updated} updated` + colors.reset);
+    // Auto-capture learnings from issues found
+    if (reportableIssues.length > 0) {
+      try {
+        const { captureFromSessionReview } = require('./flow-auto-learn');
+        captureFromSessionReview(reportableIssues);
+      } catch (_err) {
+        // Auto-learn not available or failed - continue silently
+      }
+
+      try {
+        const { TechDebtManager } = require('./flow-tech-debt');
+        const debtManager = new TechDebtManager();
+        const { added, updated } = debtManager.addIssues(reportableIssues.map(issue => ({
+          file: issue.file,
+          line: issue.line,
+          category: issue.perspective || 'code',
+          severity: issue.severity === 'critical' ? 'critical' : (issue.severity === 'important' ? 'high' : 'medium'),
+          description: issue.description,
+          fix: issue.fix || ''
+        })));
+        if (added > 0 || updated > 0) {
+          console.log(colors.dim + `  Tech debt: ${added} new, ${updated} updated` + colors.reset);
+        }
+      } catch (_err) {
+        // Tech debt manager not available or failed - continue silently
       }
-    } catch (err) {
-      // Tech debt manager not available or failed - continue silently
     }
-  }
 
-  return {
-    passed: !hasCritical,
-    message: `${reportableIssues.length} issue(s) found (${criticalIssues.length} critical, ${importantIssues.length} important)`,
-    details: reportableIssues,
-  };
+    const hasCritical = criticalIssues.length > 0;
+
+    return hasCritical
+      ? this.fail(
+          `${reportableIssues.length} issue(s) found (${criticalIssues.length} critical, ${importantIssues.length} important)`,
+          reportableIssues
+        )
+      : this.pass(`${reportableIssues.length} issue(s) found (${criticalIssues.length} critical, ${importantIssues.length} important)`);
+  }
 }
 
 /**
@@ -164,7 +146,7 @@ async function runMultiAgentReview(files, config) {
   const allIssues = [];
 
   for (const file of files) {
-    const filePath = path.join(PROJECT_ROOT, file);
+    const filePath = path.join(PATHS.root, file);
     if (!fs.existsSync(filePath)) continue;
 
     try {
@@ -198,7 +180,7 @@ async function runSimpleReview(files, config) {
   const allIssues = [];
 
   for (const file of files) {
-    const filePath = path.join(PROJECT_ROOT, file);
+    const filePath = path.join(PATHS.root, file);
     if (!fs.existsSync(filePath)) continue;
 
     try {
@@ -532,4 +514,5 @@ function mergeIssues(issues) {
   return merged;
 }
 
-module.exports = { run, runMultiAgentReview, runSimpleReview };
+const step = new ReviewStep();
+module.exports = { run: (opts) => step.run(opts), runMultiAgentReview, runSimpleReview };