wogiflow 2.4.2 → 2.4.3

package/scripts/flow-scanner-base.js

@@ -14,9 +14,7 @@
 
 const fs = require('node:fs');
 const path = require('node:path');
-const { getProjectRoot, getConfig, color, success, warn, error } = require('./flow-utils');
-
-const PROJECT_ROOT = getProjectRoot();
+const { getProjectRoot, getConfig, color, success, warn, error, PATHS } = require('./flow-utils');
 
 // ============================================================
 // Base Scanner Class
@@ -81,7 +79,7 @@ class BaseScanner {
 
     // 1. Explicit directories from config
     for (const dir of this.config.directories) {
-      const fullPath = path.join(PROJECT_ROOT, dir);
+      const fullPath = path.join(PATHS.root, dir);
       if (fs.existsSync(fullPath) && fs.statSync(fullPath).isDirectory()) {
         found.add(fullPath);
       }
@@ -161,7 +159,7 @@ class BaseScanner {
       }
     };
 
-    walk(PROJECT_ROOT, 0, 0);
+    walk(PATHS.root, 0, 0);
     return results;
   }
 
@@ -171,7 +169,7 @@ class BaseScanner {
    * @returns {boolean} True if file should be excluded
    */
   shouldExclude(filePath) {
-    const relativePath = path.relative(PROJECT_ROOT, filePath);
+    const relativePath = path.relative(PATHS.root, filePath);
 
     for (const regex of this._excludeRegexps) {
       if (regex.test(relativePath)) {
@@ -494,5 +492,5 @@ class BaseScanner {
 
 module.exports = {
   BaseScanner,
-  PROJECT_ROOT
+  PROJECT_ROOT: PATHS.root
 };

package/scripts/flow-scenario-engine.js

@@ -16,12 +16,10 @@
  *   const { executeScenario, generateScenario, resolveVariables, extractByPath } = require('./flow-scenario-engine');
  */
 
-'use strict';
-
 const fs = require('node:fs');
 const path = require('node:path');
 const crypto = require('node:crypto');
-const { getProjectRoot, safeJsonParseString } = require('./flow-utils');
+const { getProjectRoot, safeJsonParseString, PATHS } = require('./flow-utils');
 
 let verificationProfile;
 try {
@@ -30,8 +28,6 @@ try {
   verificationProfile = null;
 }
 
-const PROJECT_ROOT = getProjectRoot();
-
 // ============================================================
 // Constants
 // ============================================================

package/scripts/flow-security.js

@@ -578,6 +578,31 @@ const CREDENTIAL_SCAN_PATTERNS = [
   }
 ];
 
+// ============================================================
+// Shell Argument Sanitization
+// ============================================================
+
+/**
+ * Sanitize a string for safe use in shell commands.
+ * Only allows alphanumeric, underscore, hyphen, and dot characters.
+ * @param {string} str - String to sanitize
+ * @returns {string} Sanitized string
+ */
+function sanitizeShellArg(str) {
+  if (!str || typeof str !== 'string') return '';
+  return str.replace(/[^a-zA-Z0-9_.-]/g, '');
+}
+
+/**
+ * Escape a path for safe use in shell commands.
+ * @param {string} p - Path to escape
+ * @returns {string} Escaped path
+ */
+function escapeShellPath(p) {
+  if (!p || typeof p !== 'string') return '';
+  return p.replace(/(["\s'$`\\!*?#~<>^()[\]{}|;&])/g, '\\$1');
+}
+
 // ============================================================
 // Exports
 // ============================================================
@@ -608,6 +633,10 @@ module.exports = {
   // URL/Network safety
   isPrivateIP,
 
+  // Shell argument safety
+  sanitizeShellArg,
+  escapeShellPath,
+
   // Constants
   MAX_REGEX_LENGTH,
   VALID_CODE_EXTENSIONS,

package/scripts/flow-session-end.js

@@ -10,7 +10,7 @@ const {
   execSync,
   execFileSync,
   spawnSync } = require('node:child_process');
-const readline = require('node:readline');
+const readline = require('node:readline/promises');
 const path = require('node:path');
 const {
   PATHS,
@@ -22,7 +22,8 @@ const {
   readFile,
   writeFile,
   isGitRepo,
-  getGitStatus
+  getGitStatus,
+  safeJsonParse
 } = require('./flow-utils')
 const { color, printSection, success, warn, error } = require('./flow-output');;
 
@@ -109,18 +110,15 @@ try {
 /**
  * Prompt user for input
  */
-function prompt(question) {
+async function prompt(question) {
   const rl = readline.createInterface({
     input: process.stdin,
     output: process.stdout
   });
 
-  return new Promise(resolve => {
-    rl.question(question, answer => {
-      rl.close();
-      resolve(answer);
-    });
-  });
+  const answer = await rl.question(question);
+  rl.close();
+  return answer;
 }
 
 /**
@@ -132,7 +130,7 @@ function checkRequirements() {
   console.log(color('yellow', 'Checking session-end requirements...'));
 
   const config = getConfig();
-  const steps = config.mandatorySteps?.onSessionEnd || [];
+  const steps = config.mandatorySteps?.onSessionEnd ?? [];
 
   if (steps.length > 0) {
     console.log('Required:');
@@ -244,7 +242,7 @@ function analyzeSessionForLearnings() {
   if (!sessionLearning) return;
 
   const config = getConfig();
-  const sessionLearningConfig = config.learning?.session || {};
+  const sessionLearningConfig = config.learning?.session ?? {};
 
   // Check if enabled (default: true)
   if (sessionLearningConfig.enabled === false) return;
@@ -350,7 +348,7 @@ function reviewPendingCorrections() {
 
       const truncatedMsg = correction.userMessage?.length > 60
         ? correction.userMessage.slice(0, 60) + '...'
-        : correction.userMessage || '(empty)';
+        : correction.userMessage ?? '(empty)';
 
       console.log(`  ${i + 1}. ${color(confidenceColor, `[${correction.confidence}%]`)} ${correction.correctionType || 'unknown'}`);
       console.log(`     "${truncatedMsg}"`);
@@ -407,7 +405,7 @@ function analyzeCrossSessionPatterns() {
   if (!sessionLearning || !patternEnforcer) return null;
 
   const config = getConfig();
-  const crossSessionConfig = config.learning?.crossSession || {};
+  const crossSessionConfig = config.learning?.crossSession ?? {};
 
   // Check if enabled (default: true)
   if (crossSessionConfig.enabled === false) return null;
@@ -420,8 +418,8 @@ function analyzeCrossSessionPatterns() {
     }
 
     const patterns = sessionLearning.detectCrossSessionPatterns({
-      lookbackDays: crossSessionConfig.lookbackDays || 30,
-      minOccurrences: crossSessionConfig.minOccurrences || 3,
+      lookbackDays: crossSessionConfig.lookbackDays ?? 30,
+      minOccurrences: crossSessionConfig.minOccurrences ?? 3,
       similarityThreshold: threshold
     });
 
@@ -480,9 +478,9 @@ function saveSessionSummaryToState() {
 
     // Build summary from session data
     const summary = {
-      tasksCompleted: sessionState.metrics?.tasksCompleted || 0,
-      filesModified: sessionState.recentFiles?.slice(0, 5) || [],
-      decisions: sessionState.recentDecisions?.map(d => d.decision).slice(0, 3) || [],
+      tasksCompleted: sessionState.metrics?.tasksCompleted ?? 0,
+      filesModified: sessionState.recentFiles?.slice(0, 5) ?? [],
+      decisions: sessionState.recentDecisions?.map(d => d.decision).slice(0, 3) ?? [],
       summary: memoryBlocks?.keyFacts?.slice(-3).join('; ') || 'Session ended'
     };
 
@@ -624,7 +622,7 @@ async function automaticMemoryManagement() {
   if (!memoryDb) return;
 
   const config = getConfig();
-  const memConfig = config.memory?.automatic || {};
+  const memConfig = config.memory?.automatic ?? {};
 
   if (!memConfig.enabled) return;
 
@@ -635,8 +633,8 @@ async function automaticMemoryManagement() {
     // 1. Apply relevance decay
     if (memConfig.relevanceDecay?.enabled !== false) {
       const decayResult = await memoryDb.applyRelevanceDecay({
-        decayRate: memConfig.relevanceDecay?.decayRate || 0.033,
-        neverAccessedPenalty: memConfig.relevanceDecay?.neverAccessedPenalty || 0.1
+        decayRate: memConfig.relevanceDecay?.decayRate ?? 0.033,
+        neverAccessedPenalty: memConfig.relevanceDecay?.neverAccessedPenalty ?? 0.1
       });
       if (decayResult.decayed > 0) {
         console.log(`  Relevance decay: ${decayResult.decayed} facts updated`);
@@ -644,10 +642,10 @@ async function automaticMemoryManagement() {
     }
 
     // 2. Check entropy and compact if needed
-    const memoryConfig = { maxLocalFacts: config.memory?.maxLocalFacts || 1000 };
+    const memoryConfig = { maxLocalFacts: config.memory?.maxLocalFacts ?? 1000 };
     const entropy = await memoryDb.getEntropyStats(memoryConfig);
 
-    const _threshold = memConfig.entropyThreshold || 0.7;  
+    const _threshold = memConfig.entropyThreshold ?? 0.7;
     const statusColor = entropy.status === 'healthy' ? 'green'
       : entropy.status === 'moderate' ? 'yellow' : 'red';
 
@@ -659,7 +657,7 @@ async function automaticMemoryManagement() {
 
       // Demote low-relevance facts
       const demotion = await memoryDb.demoteToColdStorage({
-        relevanceThreshold: memConfig.demotion?.relevanceThreshold || 0.3
+        relevanceThreshold: memConfig.demotion?.relevanceThreshold ?? 0.3
       });
       if (demotion.demoted > 0) {
         console.log(`    Demoted: ${demotion.demoted} facts`);
@@ -673,7 +671,7 @@ async function automaticMemoryManagement() {
 
       // Purge old cold facts
       const purge = await memoryDb.purgeColdFacts({
-        coldRetentionDays: memConfig.demotion?.coldRetentionDays || 90
+        coldRetentionDays: memConfig.demotion?.coldRetentionDays ?? 90
       });
       if (purge.purged > 0) {
         console.log(`    Purged: ${purge.purged} old facts`);
@@ -681,11 +679,11 @@ async function automaticMemoryManagement() {
     }
 
     // 3. Check for promotion candidates and auto-promote if enabled
-    const promoConfig = config.memory?.promotion || {};
+    const promoConfig = config.memory?.promotion ?? {};
     if (promoConfig.enabled) {
       const candidates = await memoryDb.getPromotionCandidates({
-        minRelevance: promoConfig.minRelevance || 0.8,
-        minAccessCount: promoConfig.threshold || 3
+        minRelevance: promoConfig.minRelevance ?? 0.8,
+        minAccessCount: promoConfig.threshold ?? 3
       });
 
       const unpromoted = candidates.filter(c => !c.promoted_to);
@@ -752,15 +750,8 @@ async function syncRulesIfChanged() {
 
     // Load last hash from state
     const hashStatePath = path.join(STATE_DIR, 'decisions-hash.json');
-    let lastHash = null;
-    if (fileExists(hashStatePath)) {
-      try {
-        const hashState = JSON.parse(readFile(hashStatePath));
-        lastHash = hashState.hash;
-      } catch (_err) {
-        // Ignore parse errors
-      }
-    }
+    const hashState = safeJsonParse(hashStatePath, null);
+    const lastHash = hashState ? hashState.hash : null;
 
     // Compare hashes
     if (currentHash === lastHash) {
@@ -809,7 +800,7 @@ async function syncRulesIfChanged() {
  */
 async function offerKnowledgeSync() {
   const config = getConfig();
-  const morningConfig = config.morningBriefing || {};
+  const morningConfig = config.morningBriefing ?? {};
 
   // Skip if disabled or if auto-regenerate handled it in morning
   if (morningConfig.checkKnowledgeSync === false) {
@@ -873,7 +864,7 @@ async function offerKnowledgeSync() {
  */
 async function offerDebtCleanup() {
   const config = getConfig();
-  const techDebtConfig = config.techDebt || {};
+  const techDebtConfig = config.techDebt ?? {};
 
   if (!techDebtConfig.promptOnSessionEnd) {
     return;
@@ -996,7 +987,7 @@ async function offerDebtCleanup() {
 async function cleanupStaleTasks() {
   try {
     const readyData = getReadyData();
-    const inProgress = readyData.inProgress || [];
+    const inProgress = readyData.inProgress ?? [];
 
     // Find auto-created tasks
     const autoCreatedTasks = inProgress.filter(task =>
@@ -1094,7 +1085,7 @@ async function cleanupStaleTasks() {
           completedBy: 'session-end-cleanup'
         };
 
-        readyData.recentlyCompleted = readyData.recentlyCompleted || [];
+        readyData.recentlyCompleted = readyData.recentlyCompleted ?? [];
         readyData.recentlyCompleted.unshift(completedTask);
         readyData.recentlyCompleted = readyData.recentlyCompleted.slice(0, 10);
       }

package/scripts/flow-session-learning.js

@@ -586,6 +586,7 @@ function applyLearnings(learnings, options = {}) {
 
 /**
  * Add learning to feedback-patterns.md
+ * Routes through the learning orchestrator for locking and dedup.
  */
 function addToFeedbackPatterns(learning) {
   if (!fileExists(FEEDBACK_PATTERNS_PATH)) {
@@ -594,45 +595,44 @@ function addToFeedbackPatterns(learning) {
   }
 
   try {
-    let content = fs.readFileSync(FEEDBACK_PATTERNS_PATH, 'utf-8');
+    const { modifyFeedbackPatterns } = require('./flow-learning-orchestrator');
     const today = getTodayDateString();
 
-    // Check if pattern already exists
-    if (content.includes(learning.pattern)) {
-      // Update count instead of adding duplicate
-      return true;
-    }
-
-    // Find or create Session Analysis section
-    const sectionHeader = '## Session Analysis Patterns';
-    const tableHeader = '| Date | Pattern | Source | Count | Confidence | Status |';
-    const tableSeparator = '|------|---------|--------|-------|------------|--------|';
-
     const newRow = `| ${today} | ${learning.pattern} | ${learning.source} | ${learning.occurrences} | ${learning.confidence}% | Monitor |`;
 
-    if (content.includes(sectionHeader)) {
-      // Add to existing section
-      const sectionEnd = content.indexOf('\n## ', content.indexOf(sectionHeader) + 1);
-      const insertPos = sectionEnd > 0 ? sectionEnd : content.length;
+    modifyFeedbackPatterns((currentContent) => {
+      let content = currentContent;
 
-      // Find the table and add row
-      const tableEnd = content.lastIndexOf('|', insertPos);
-      if (tableEnd > content.indexOf(sectionHeader)) {
-        const lineEnd = content.indexOf('\n', tableEnd);
-        content = content.slice(0, lineEnd + 1) + newRow + '\n' + content.slice(lineEnd + 1);
+      // Check if pattern already exists
+      if (content.includes(learning.pattern)) {
+        return null; // Signal no write needed (already exists)
       }
-    } else {
-      // Add new section before "## Promotion History" or at end
-      const newSection = `\n---\n\n${sectionHeader}\n\n${tableHeader}\n${tableSeparator}\n${newRow}\n`;
 
-      if (content.includes('## Promotion History')) {
-        content = content.replace('## Promotion History', newSection + '\n## Promotion History');
+      // Find or create Session Analysis section
+      const sectionHeader = '## Session Analysis Patterns';
+      const tableHeader = '| Date | Pattern | Source | Count | Confidence | Status |';
+      const tableSeparator = '|------|---------|--------|-------|------------|--------|';
+
+      if (content.includes(sectionHeader)) {
+        const sectionEnd = content.indexOf('\n## ', content.indexOf(sectionHeader) + 1);
+        const insertPos = sectionEnd > 0 ? sectionEnd : content.length;
+        const tableEnd = content.lastIndexOf('|', insertPos);
+        if (tableEnd > content.indexOf(sectionHeader)) {
+          const lineEnd = content.indexOf('\n', tableEnd);
+          content = content.slice(0, lineEnd + 1) + newRow + '\n' + content.slice(lineEnd + 1);
+        }
       } else {
-        content = content.trimEnd() + newSection;
+        const newSection = `\n---\n\n${sectionHeader}\n\n${tableHeader}\n${tableSeparator}\n${newRow}\n`;
+        if (content.includes('## Promotion History')) {
+          content = content.replace('## Promotion History', newSection + '\n## Promotion History');
+        } else {
+          content = content.trimEnd() + newSection;
+        }
       }
-    }
 
-    fs.writeFileSync(FEEDBACK_PATTERNS_PATH, content, 'utf-8');
+      return { content, entryText: learning.pattern };
+    }, { caller: 'flow-session-learning/addToFeedbackPatterns' });
+
     return true;
   } catch (err) {
     if (process.env.DEBUG) console.error(`[DEBUG] addToFeedbackPatterns: ${err.message}`);
@@ -642,6 +642,7 @@ function addToFeedbackPatterns(learning) {
 
 /**
  * Add high-confidence learning to decisions.md
+ * Routes through the learning orchestrator for locking and dedup.
  */
 function addToDecisions(learning) {
   if (!fileExists(DECISIONS_PATH)) {
@@ -650,16 +651,19 @@ function addToDecisions(learning) {
   }
 
   try {
-    let content = fs.readFileSync(DECISIONS_PATH, 'utf-8');
+    const { modifyDecisions } = require('./flow-learning-orchestrator');
     const today = getTodayDateString();
 
-    // Check if pattern already exists
-    if (content.includes(learning.pattern)) {
-      return true; // Already exists
-    }
+    modifyDecisions((currentContent) => {
+      let content = currentContent;
 
-    // Create decision entry
-    const decisionEntry = `
+      // Check if pattern already exists
+      if (content.includes(learning.pattern)) {
+        return null; // Already exists, no write needed
+      }
+
+      // Create decision entry
+      const decisionEntry = `
 ### ${learning.pattern} (${today})
 <!-- PIN: ${learning.pattern} -->
 
@@ -670,21 +674,21 @@ ${learning.description}
 **Recommendation**: ${learning.recommendation}
 `;
 
-    // Find Session Learnings section or create one
-    const sectionHeader = '## Session-Learned Patterns';
+      // Find Session Learnings section or create one
+      const sectionHeader = '## Session-Learned Patterns';
 
-    if (content.includes(sectionHeader)) {
-      // Add after section header
-      const sectionIndex = content.indexOf(sectionHeader);
-      const nextSection = content.indexOf('\n## ', sectionIndex + sectionHeader.length);
-      const insertPos = nextSection > 0 ? nextSection : content.length;
-      content = content.slice(0, insertPos) + decisionEntry + content.slice(insertPos);
-    } else {
-      // Add new section at the end
-      content = content.trimEnd() + '\n\n---\n\n' + sectionHeader + '\n' + decisionEntry;
-    }
+      if (content.includes(sectionHeader)) {
+        const sectionIndex = content.indexOf(sectionHeader);
+        const nextSection = content.indexOf('\n## ', sectionIndex + sectionHeader.length);
+        const insertPos = nextSection > 0 ? nextSection : content.length;
+        content = content.slice(0, insertPos) + decisionEntry + content.slice(insertPos);
+      } else {
+        content = content.trimEnd() + '\n\n---\n\n' + sectionHeader + '\n' + decisionEntry;
+      }
+
+      return { content, entryText: learning.pattern };
+    }, { caller: 'flow-session-learning/addToDecisions' });
 
-    fs.writeFileSync(DECISIONS_PATH, content, 'utf-8');
     return true;
   } catch (err) {
     if (process.env.DEBUG) console.error(`[DEBUG] addToDecisions: ${err.message}`);

package/scripts/flow-setup-hooks.js

@@ -17,12 +17,11 @@ const fs = require('node:fs');
 const path = require('node:path');
 const {
   getProjectRoot,
-  getConfig
+  getConfig, PATHS
 } = require('./flow-utils')
 const { color, success, warn, error } = require('./flow-output');;
 
-const PROJECT_ROOT = getProjectRoot();
-const GIT_DIR = path.join(PROJECT_ROOT, '.git');
+const GIT_DIR = path.join(PATHS.root, '.git');
 const HOOKS_DIR = path.join(GIT_DIR, 'hooks');
 
 // Hook marker to identify our managed hooks

package/scripts/flow-skill-create.js

@@ -13,13 +13,12 @@
 
 const fs = require('node:fs');
 const path = require('node:path');
-const readline = require('node:readline');
-const { getProjectRoot, colors } = require('./flow-utils');
+const readline = require('node:readline/promises');
+const { getProjectRoot, colors, PATHS } = require('./flow-utils');
 const { success, warn, error: errorMsg, info, print } = require('./flow-output');
 const { getAllSkills, getSkillDir } = require('./flow-skill-matcher');
 
-const PROJECT_ROOT = getProjectRoot();
-const SKILLS_DIR = path.join(PROJECT_ROOT, '.claude', 'skills');
+const SKILLS_DIR = path.join(PATHS.root, '.claude', 'skills');
 const TEMPLATE_DIR = path.join(SKILLS_DIR, '_template');
 
 function log(color, ...args) {
@@ -33,13 +32,9 @@ async function prompt(question, defaultValue = '') {
   });
 
   const defaultHint = defaultValue ? ` (${defaultValue})` : '';
-
-  return new Promise(resolve => {
-    rl.question(`${question}${defaultHint}: `, answer => {
-      rl.close();
-      resolve(answer.trim() || defaultValue);
-    });
-  });
+  const answer = await rl.question(`${question}${defaultHint}: `);
+  rl.close();
+  return answer.trim() || defaultValue;
 }
 
 async function confirm(question) {
@@ -187,7 +182,7 @@ _Add key patterns here._
 }
 
 async function createFromPatterns() {
-  const feedbackPath = path.join(PROJECT_ROOT, '.workflow', 'state', 'feedback-patterns.md');
+  const feedbackPath = PATHS.feedbackPatterns;
 
   if (!fs.existsSync(feedbackPath)) {
     warn('No feedback-patterns.md found');

package/scripts/flow-skill-generator.js

@@ -7,7 +7,7 @@
 
 const fs = require('node:fs');
 const path = require('node:path');
-const { ensureDir, getConfig, invalidateConfigCache, writeJson, PATHS, success } = require('./flow-utils');
+const { ensureDir, getConfig, invalidateConfigCache, writeJson, PATHS, success, safeJsonParse } = require('./flow-utils');
 const { getTodayDate } = require('./flow-output');
 
 // Import helper functions from tech options
@@ -890,10 +890,14 @@ function updateDecisionsMd(selections, technologies, projectRoot) {
   // Append tech stack section
   content = content.trimEnd() + '\n' + techStackSection;
 
-  fs.writeFileSync(decisionsPath, content, 'utf8');
-
-  // Sync to .claude/rules/ for Claude Code integration
-  syncDecisionsToRules();
+  // Route through orchestrator for locking and dedup
+  try {
+    const { writeToDecisions } = require('./flow-learning-orchestrator');
+    writeToDecisions({ content, entryText: 'Tech Stack (auto-generated)', caller: 'flow-skill-generator/updateDecisions', skipDedup: true, syncRules: true }).catch(() => {});
+  } catch (_err) {
+    fs.writeFileSync(decisionsPath, content, 'utf8');
+    syncDecisionsToRules();
+  }
 }
 
 function updateConfigJson(technologies, _projectRoot) {
@@ -1466,17 +1470,9 @@ For manual use, run the wizard first: node flow-stack-wizard.js
       process.exit(1);
     }
 
-    let selections;
-    try {
-      const content = fs.readFileSync(selectionsPath, 'utf8');
-      const parsed = JSON.parse(content);
-      if (typeof parsed !== 'object' || parsed === null) {
-        console.error('stack-selections.json is not a valid object');
-        process.exit(1);
-      }
-      selections = parsed;
-    } catch (err) {
-      console.error(`Failed to parse stack-selections.json: ${err.message}`);
+    const selections = safeJsonParse(selectionsPath, null);
+    if (!selections) {
+      console.error('stack-selections.json is not a valid object or could not be parsed');
       process.exit(1);
     }
     const { collectTechnologiesFromSelections } = require('./flow-tech-options');

package/scripts/flow-skill-learn.js

@@ -20,13 +20,10 @@
 const fs = require('node:fs');
 const path = require('node:path');
 const { execSync } = require('node:child_process');
-const { getProjectRoot, getConfig, colors } = require('./flow-utils');
+const { getProjectRoot, getConfig, colors, PATHS } = require('./flow-utils');
 const { getAllSkills, getSkillDir } = require('./flow-skill-matcher');
 
-const PROJECT_ROOT = getProjectRoot();
-const WORKFLOW_DIR = path.join(PROJECT_ROOT, '.workflow');
-const SKILLS_DIR = path.join(PROJECT_ROOT, '.claude', 'skills');
-const STATE_DIR = path.join(WORKFLOW_DIR, 'state');
+const SKILLS_DIR = path.join(PATHS.root, '.claude', 'skills');
 
 function log(color, ...args) {
   console.log(colors[color] + args.join(' ') + colors.reset);
@@ -582,7 +579,7 @@ function getFileSignature(files) {
  * Log unmatched files to feedback-patterns.md with proper count tracking
  */
 function logToFeedbackPatterns(context, unmatchedFiles) {
-  const feedbackPath = path.join(STATE_DIR, 'feedback-patterns.md');
+  const feedbackPath = PATHS.feedbackPatterns;
 
   if (!fs.existsSync(feedbackPath)) return;
 
@@ -641,7 +638,19 @@ function logToFeedbackPatterns(context, unmatchedFiles) {
     content = content.slice(0, headerEnd) + entry + '\n' + content.slice(headerEnd);
   }
 
-  fs.writeFileSync(feedbackPath, content);
+  try {
+    const { writeToFeedbackPatterns } = require('./flow-learning-orchestrator');
+    writeToFeedbackPatterns({
+      content,
+      entryText: `Files changed with no matching skill: ${filesPreview}`,
+      caller: 'flow-skill-learn/logToFeedbackPatterns',
+      skipDedup: true // We already handle dedup above via foundExisting check
+    }).catch(_err => {
+      if (process.env.DEBUG) console.error(`[DEBUG] logToFeedbackPatterns: ${_err.message}`);
+    });
+  } catch (_err) {
+    if (process.env.DEBUG) console.error(`[DEBUG] logToFeedbackPatterns: ${_err.message}`);
+  }
 }
 
 // ============================================================
@@ -814,7 +823,7 @@ module.exports = {
 };
 
 if (require.main === module) {
-  main().catch(e => {
+  main().catch(err => {
     log('red', `Error: ${err.message}`);
     process.exit(1);
   });

package/scripts/flow-skill-matcher.js

@@ -31,8 +31,7 @@ function getSkillFilePath(dir) {
 const { getProjectRoot, getConfig, PATHS, colors } = require('./flow-utils');
 const { error: errorMsg } = require('./flow-output');
 
-const PROJECT_ROOT = getProjectRoot();
-const SKILLS_DIR = path.join(PROJECT_ROOT, '.claude', 'skills');
+const SKILLS_DIR = path.join(PATHS.root, '.claude', 'skills');
 
 // Maximum nesting depth for skill directories (prevents runaway recursion)
 const MAX_SKILL_NESTING_DEPTH = 3;