wkappbot-code 0.3.29 → 0.3.32

package/bin/wkappbot-code.js

@@ -41,7 +41,7 @@ import {
 import { homedir, tmpdir } from "node:os";
 import { dirname, isAbsolute, join, relative, resolve } from "node:path";
 import { fileURLToPath, pathToFileURL } from "node:url";
-import { quietCheck, runUpdate, updateRow } from "../lib/update.js"; import { rmTreeHard, waitForArchive } from "../lib/rmtree.js"; import { plainFileUrl } from "../lib/fileurl.js"; import { removeStaleWkskill } from "../lib/stale-wkskill.js"; import { checkPath, installBothLinks, removeCreatedLinks } from "../lib/doctor-path.js";
+import { quietCheck, runUpdate, updateRow } from "../lib/update.js"; import { rmTreeHard, waitForArchive, holderReport } from "../lib/rmtree.js"; import { waitForHolders } from "../lib/holders.js"; import { plainFileUrl } from "../lib/fileurl.js"; import { removeStaleWkskill } from "../lib/stale-wkskill.js"; import { checkPath, installBothLinks, removeCreatedLinks } from "../lib/doctor-path.js";
 import { applySets, askEach, buildConfig, configRow, detect, lineDiff, printDetected } from "../lib/config.js";
 import { aiCliRows, installAiClis, removeAiClis } from "../lib/ai-clis.js";
 import { providerCli, providerRow } from "../lib/providers.js";
@@ -436,6 +436,9 @@ function install(o) {
   let bad = 0;
   // 0.3.13 (owner 2026-11-09: Git Bash is a required tool too): bash, sh, curl, tar and git first; on Windows a Git that
   // is not on PATH is used from its folder, and a missing one is installed with winget (lib/prereq.js)
+  // 0.3.32 (2026-11-12, kih ROOT 3): the uninstall also waits for every process whose command line names the harness dir (lib/holders.js) and prints the holders as one line the SDK e2e cause filter keeps.
+  // 0.3.31 (2026-11-12, spokesman order): provider add on a clean machine creates the OpenCode config folder (lib/providers.js mkdirSync) instead of dying with ENOENT, and the opencode.json backup of provider add and remove goes under <config dir>/wkappbot-code/backups, which uninstall removes with the rest of its state, so no opencode.json.bak-<stamp> stays in the user config folder.
+  // 0.3.30 (2026-11-12, spokesman order after gate runs 43246725941 and 43247534046): 0.3.29 left the EPERM on .claude/hooks/wkharness-run.sh in one of two win-x64-nopy runs. The detached shadow run (wkjs_shadow) and the skill-draft child of the hook script were still started inside the harness copy with the script fd open; both now start from cwd / with the fd closed (wk_detach_prep), like the archive child. A failing tree removal on Windows now prints lib/rmtree.js holderReport: every Win32_Process row naming the harness dir plus every shell, node and python process with pid, ppid and command line, so a run that still hits EPERM names the real holder.
   // 0.3.29 (2026-11-12, spokesman order after SDK gate run 43227049219): uninstall waits (bounded 15 s) for a RECORDED archive pid before it removes the harness copy (lib/rmtree.js waitForArchive; the detached archive child starts from cwd / with the script fd closed), so no EPERM on .claude/hooks/wkharness-run.sh; install records st.opencodeBackups and uninstall leaves no opencode.json.bak-<stamp> of its own.
   // 0.3.28 (owner 2026-11-12 via the spokesman): uninstall removes only the settings backup the install recorded (st.settingsBackup); the .cmd twins of the core links are shim candidates; the clean-baseline guard no longer reads --model of non-delegating commands; doctor sets process.exitCode.
   st.prereq = ensurePrereqs({ log });
@@ -602,10 +605,11 @@ function uninstall(o) {
   const rmTree = (p, what) => {
     const r = rmTreeHard(p); if (r.ok) { if (what) log(what + ": removed " + p); return; }
     rc = 1; log((what || "remove") + ": could not remove " + p + " -- blocked by " + r.blockers.slice(0, 5).join("; ") + " -- delete it by hand");
-    if (IS_WIN) { const d = spawnSync("tasklist.exe", ["/v"], { encoding: "utf8", timeout: 15000 }); log("remove diagnostics (process list, not file owners): " + String(d.stdout || d.stderr || "").slice(0, 4000)); }
+    if (IS_WIN) { const d = spawnSync("tasklist.exe", ["/v"], { encoding: "utf8", timeout: 15000 }); log("remove diagnostics (process list, not file owners): " + String(d.stdout || d.stderr || "").slice(0, 2000)); log("harness holders blocked by (rows naming " + p + " first, then other shell/node/python processes with parent pid and command line; one line so the SDK e2e cause filter keeps it) " + holderReport(p).split("\n").join(" ;; ")); }
   };
   // (B) the detached per-turn archive child may still hold .claude/hooks/wkharness-run.sh (Windows EPERM): wait for its RECORDED pid first.
   if (existsSync(HARNESS_DIR())) { const w = waitForArchive(HARNESS_DIR()); if (w.waited) log("harness: waited " + w.waited + " ms for the archive child" + (w.alive.length ? " (pid " + w.alive.join(",") + " still running)" : "")); }
+  if (st.harness && st.harness.mode === "web" && pr.harnessDirExisted !== true && existsSync(HARNESS_DIR())) { const h = waitForHolders(HARNESS_DIR()); if (h.waited) log("harness: waited " + h.waited + " ms for process(es) naming the harness dir" + (h.alive.length ? " (pid " + h.alive.join(",") + " still running)" : "")); }
   if (st.harness && st.harness.mode === "web" && pr.harnessDirExisted !== true && existsSync(HARNESS_DIR())) rmTree(HARNESS_DIR(), "harness");
   if (pr.hooksDirExisted !== true && existsSync(HOOKS_DIR())) rmTree(HOOKS_DIR(), "push-gate");
   const cfgFile = join(configDir(o), "opencode.json");

package/lib/holders.js

@@ -0,0 +1,32 @@
+// holders.js -- wait for the processes that still hold the harness copy before an uninstall removes it (kih ROOT 3 2026-11-12, 0.3.32).
+// The 0.3.30 holder report named a live bash.exe at the failing Windows uninstall (SDK gate runs 43264303070 and 43269021533). lib/rmtree.js waitForArchive only waits
+// for the RECORDED archive pid, so any other detached hook child (the shadow run, the skill-draft child, a flock wrapper) still held .claude/hooks/wkharness-run.sh.
+// waitForHolders waits (bounded) for every process whose command line names the harness dir, never the uninstall's own pid or parent pid. exec and sleep are injectable.
+import { spawnSync } from "node:child_process";
+
+const sleepMs = (ms) => { try { Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, ms); } catch { /* no wait available */ } };
+const procExec = (cmd, args) => { const r = spawnSync(cmd, args, { encoding: "utf8", timeout: 20000 }); return String(r.stdout || r.stderr || ""); };
+
+export function listHolders(dir, opts = {}) {
+  const exec = opts.exec || procExec, isWin = opts.win ?? (process.platform === "win32");
+  const needle = String(dir).replace(/\\/g, "/").toLowerCase(), own = new Set([process.pid, process.ppid]);
+  let table = "";
+  try {
+    table = isWin ? exec("powershell.exe", ["-NoProfile", "-NonInteractive", "-Command", "Get-CimInstance Win32_Process | ForEach-Object { \"$($_.ProcessId)`t$($_.ParentProcessId)`t$($_.Name)`t$([string]$_.CommandLine)\" }"])
+      : exec("ps", ["-eo", "pid=,ppid=,comm=,args="]).split(/\r?\n/).map((l) => l.trim().replace(/\s+/g, "\t")).join("\n");
+  } catch { return []; }
+  const pids = [];
+  for (const line of String(table).split(/\r?\n/)) {
+    const f = line.split("\t"), pid = parseInt(f[0], 10);
+    if (f.length < 4 || !(pid > 0) || own.has(pid)) continue;
+    if (f.slice(3).join(" ").replace(/\\/g, "/").toLowerCase().includes(needle)) pids.push(pid);
+  }
+  return pids;
+}
+
+export function waitForHolders(dir, opts = {}) {
+  const maxMs = opts.maxMs ?? 20000, gap = opts.gap || 500, nap = opts.sleep || sleepMs;
+  let alive = listHolders(dir, opts), waited = 0;
+  while (alive.length && waited < maxMs) { nap(gap); waited += gap; alive = listHolders(dir, opts); }
+  return { waited, alive };
+}

package/lib/providers.js

@@ -3,7 +3,8 @@
 // ("{env:VAR}"); a key or a URL typed where a name belongs is refused and never echoed, and no env var value is read
 // except by the doctor row, which only checks that a variable is set and prints its name.
 // Pure build/merge/remove functions first, then the CLI body. Spec: wkappbot skill read agent-harness-landscape-2026
-import { copyFileSync, existsSync, readFileSync, renameSync, writeFileSync } from "node:fs";
+import { copyFileSync, existsSync, mkdirSync, readFileSync, renameSync, writeFileSync } from "node:fs";
+import { dirname, join } from "node:path";
 
 export const NPM = "@ai-sdk/openai-compatible";
 export const ENV_NAME = /^[A-Z_][A-Z0-9_]*$/;
@@ -118,7 +119,8 @@ export function providerCli(argv, { target, log = console.log, err = console.err
     next = m.cfg;
   }
   const text = JSON.stringify(next, null, 2) + "\n";
-  if (raw) { const bak = target + ".bak-" + stamp(); copyFileSync(target, bak); log("backup " + bak); }
+  if (raw) { const bdir = join(dirname(target), "wkappbot-code", "backups"); mkdirSync(bdir, { recursive: true }); const bak = join(bdir, "opencode.json.bak-" + stamp()); copyFileSync(target, bak); log("backup " + bak); }   // under the state folder uninstall removes, never beside the user file (kih ROOT 3 2026-11-12)
+  mkdirSync(dirname(target), { recursive: true });   // a clean machine has no OpenCode config folder yet (kih ROOT 3 2026-11-12)
   writeFileSync(target + ".tmp", text);
   renameSync(target + ".tmp", target);
   log("provider " + o.id + (o.sub === "add" ? " added to " : " removed from ") + target);

package/lib/rmtree.js

@@ -2,6 +2,7 @@
 // rmTreeHard(p, rm) -> { ok, blockers[] }: a long bounded retry first, then a per-entry pass that names what stays.
 import { existsSync, lstatSync, readdirSync, readFileSync, rmSync } from "node:fs";
 import { join } from "node:path";
+import { spawnSync } from "node:child_process";
 
 const sleepMs = (ms) => { try { Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, ms); } catch { /* no wait available */ } };
 
@@ -9,6 +10,34 @@ const sleepMs = (ms) => { try { Atomics.wait(new Int32Array(new SharedArrayBuffe
 // pid in <harnessDir>/.tmp/hippo-archive/archive-SID.pid and removes it on exit. A Windows uninstall that runs inside that child's
 // lifetime hits EPERM on .claude/hooks/wkharness-run.sh, so uninstall waits (bounded) for every RECORDED pid to leave first.
 // isAlive and sleep are injectable so the selftest fakes a held handle. A pid file whose pid is dead is stale and ignored.
+// holderReport(dir, opts) -> text: who could be holding the harness copy (kih ROOT 3 2026-11-12, spokesman order for 0.3.30). tasklist /v names no file owner, so on
+// Windows this asks Win32_Process for every process whose command line or image path names the dir, plus every shell, node, python and setsid process with its
+// parent pid and command line; the SDK e2e uninstall prints it when the tree removal fails, so a run that hits EPERM names the real holder. exec is injectable.
+export function holderReport(dir, opts = {}) {
+  const exec = opts.exec || ((cmd, args) => { const r = spawnSync(cmd, args, { encoding: "utf8", timeout: 20000 }); return String(r.stdout || r.stderr || ""); });
+  const isWin = opts.win ?? (process.platform === "win32");
+  const needle = String(dir).replace(/\\/g, "/").toLowerCase();
+  try {
+    if (isWin) {
+      const ps = "Get-CimInstance Win32_Process | ForEach-Object { $c = [string]$_.CommandLine; $p = [string]$_.ExecutablePath; \"$($_.ProcessId)`t$($_.ParentProcessId)`t$($_.Name)`t$c`t$p\" }";
+      return filterHolderRows(exec("powershell.exe", ["-NoProfile", "-NonInteractive", "-Command", ps]), needle);
+    }
+    return filterHolderRows(exec("ps", ["-eo", "pid=,ppid=,comm=,args="]).split(/\r?\n/).map((l) => l.trim().replace(/\s+/g, "\t")).join("\n"), needle);
+  } catch (e) { return "holderReport failed: " + (e && e.message); }
+}
+const HOLDER_NAMES = /^(?:bash|sh|node|python3?|pwsh|powershell|setsid|flock|git|wk[\w.-]*)(?:\.exe)?$/i;
+function filterHolderRows(out, needle) {
+  const rows = [];
+  for (const line of String(out).split(/\r?\n/)) {
+    const f = line.split("\t");
+    if (f.length < 3) continue;
+    const hay = f.slice(3).join(" ").replace(/\\/g, "/").toLowerCase();
+    const named = hay.includes(needle), shellish = HOLDER_NAMES.test(String(f[2]).trim());
+    if (named || shellish) rows.push((named ? "HOLDS-DIR " : "shell      ") + "pid=" + f[0] + " ppid=" + f[1] + " " + f[2] + " " + f.slice(3).join(" ").slice(0, 300));
+  }
+  return rows.length ? rows.slice(0, 60).join("\n") : "no process names the harness dir and no shell, node or python process is running";
+}
+
 const defaultAlive = (pid) => { try { process.kill(pid, 0); return true; } catch (e) { return !!e && e.code === "EPERM"; } };
 export function waitForArchive(harnessDir, opts = {}) {
   const isAlive = opts.isAlive || defaultAlive, maxMs = opts.maxMs ?? 15000, gap = opts.gap || 250, nap = opts.sleep || sleepMs;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "wkappbot-code",
-  "version": "0.3.29",
+  "version": "0.3.32",
   "description": "wkappbot-code -- Wisdom Kernel: the pinned OpenCode bridge plus the reflex harness plugin, the wkappbot core, the web harness and the latest public skills in one install",
   "type": "module",
   "scripts": {