windowsweep 1.0.1 → 1.2.0

package/modules/menu.ps1

@@ -1,61 +1,63 @@
-# menu.ps1 - jump-to menu: run one section at a time; toggle dry-run and auto-yes.
-
-function Show-Menu {
-  $ws = $Script:WS
-  Write-UiLine '' 'Gray'
-  Write-Banner
-  $sys = New-Object IO.DriveInfo($Script:P.SD)
-  $dry = 'OFF'
-  if ($ws.DryRun) { $dry = 'ON' }
-  $yes = 'OFF'
-  if ($ws.Yes) { $yes = 'ON' }
-  $adm = 'no'
-  if ($ws.IsAdmin) { $adm = 'yes' }
-  Write-UiLine ("  system drive free: {0}   dry-run: {1}   auto-yes: {2}   elevated: {3}" -f (Format-Bytes $sys.AvailableFreeSpace), $dry, $yes, $adm) 'Cyan'
-  Write-UiLine '' 'Gray'
-  foreach ($s in $Script:WS_SECTIONS) {
-    $mark = ' '
-    if ($ws.Report.steps | Where-Object { $_.section -eq $s.Id -and $_.status -in 'ran', 'dry-run' }) { $mark = $ws.Glyph.ok }
-    $flags = ''
-    if ($s.Admin) { $flags += ' [admin]' }
-    if ($s.Batch -eq 'deep') { $flags += ' [deep]' }
-    if ($s.Batch -eq 'interactive') { $flags += ' [interactive]' }
-    $color = 'Gray'
-    if ($s.Admin -and -not $ws.IsAdmin) { $color = 'DarkGray' }
-    Write-UiLine ("  {0} [{1,2}] {2}{3}" -f $mark, $s.Id, $s.Title, $flags) $color
-  }
-  Write-UiLine '' 'Gray'
-  Write-UiLine '   [A] run the safe batch     [D] toggle dry-run     [Y] toggle auto-yes     [S] summary     [Q] quit' 'White'
-}
-
-function Invoke-Menu {
-  $ws = $Script:WS
-  if (-not $ws.Interactive) {
-    Write-Err 'The menu needs an interactive console. For unattended runs use:  windowsweep --all --yes'
-    $ws.ExitCode = $Script:WS_EXIT_USAGE
-    return
-  }
-  while ($true) {
-    Show-Menu
-    $choice = Read-Choice -Prompt '  Select [0-21 / A / D / Y / S / Q]: ' -Default ''
-    if ($choice -eq '') { continue }
-    switch -Regex ($choice) {
-      '^q' { Show-SessionSummary; return }
-      '^a' {
-        $ids = @($Script:WS_SAFE_BATCH)
-        if ($ws.IsAdmin) { $ids += $Script:WS_SAFE_BATCH_ADMIN }
-        $ws.BatchMode = $true
-        try { foreach ($id in $ids) { Invoke-SectionById -Id $id } } finally { $ws.BatchMode = $false }
-        Wait-Enter
-      }
-      '^d' { $ws.DryRun = -not $ws.DryRun }
-      '^y' { $ws.Yes = -not $ws.Yes }
-      '^s' { Show-SessionSummary; Wait-Enter }
-      '^\d+$' {
-        $id = [int]$choice
-        if (Get-Section $id) { Invoke-SectionById -Id $id; Wait-Enter } else { Write-Warn "no section $id" }
-      }
-      default { Write-Warn "unrecognised choice: $choice" }
-    }
-  }
-}
+# menu.ps1 - jump-to menu: run one section at a time; toggle dry-run and auto-yes.
+
+function Show-Menu {
+  $ws = $Script:WS
+  Write-UiLine '' 'Gray'
+  Write-Banner
+  $sys = New-Object IO.DriveInfo($Script:P.SD)
+  $dry = 'OFF'
+  if ($ws.DryRun) { $dry = 'ON' }
+  $yes = 'OFF'
+  if ($ws.Yes) { $yes = 'ON' }
+  $adm = 'no'
+  if ($ws.IsAdmin) { $adm = 'yes' }
+  Write-UiLine ("  system drive free: {0}   dry-run: {1}   auto-yes: {2}   elevated: {3}" -f (Format-Bytes $sys.AvailableFreeSpace), $dry, $yes, $adm) 'Cyan'
+  Write-UiLine '' 'Gray'
+  foreach ($s in $Script:WS_SECTIONS) {
+    $mark = ' '
+    if ($ws.Report.steps | Where-Object { $_.section -eq $s.Id -and $_.status -in 'ran', 'dry-run' }) { $mark = $ws.Glyph.ok }
+    $flags = ''
+    if ($s.Admin) { $flags += ' [admin]' }
+    if ($s.Batch -eq 'deep') { $flags += ' [deep]' }
+    if ($s.Batch -eq 'interactive') { $flags += ' [interactive]' }
+    $color = 'Gray'
+    if ($s.Admin -and -not $ws.IsAdmin) { $color = 'DarkGray' }
+    Write-UiLine ("  {0} [{1,2}] {2}{3}" -f $mark, $s.Id, $s.Title, $flags) $color
+  }
+  Write-UiLine '' 'Gray'
+  Write-UiLine '   [A] run the safe batch     [D] toggle dry-run     [Y] toggle auto-yes     [S] summary     [Q] quit' 'White'
+}
+
+function Invoke-Menu {
+  $ws = $Script:WS
+  if (-not $ws.Interactive) {
+    Write-Err 'The menu needs an interactive console. For unattended runs use:  windowsweep --all --yes'
+    $ws.ExitCode = $Script:WS_EXIT_USAGE
+    return
+  }
+  while ($true) {
+    Show-Menu
+    $lo = ($Script:WS_SECTIONS | Measure-Object Id -Minimum).Minimum
+    $hi = ($Script:WS_SECTIONS | Measure-Object Id -Maximum).Maximum
+    $choice = Read-Choice -Prompt "  Select [$lo-$hi / A / D / Y / S / Q]: " -Default ''
+    if ($choice -eq '') { continue }
+    switch -Regex ($choice) {
+      '^q' { Show-SessionSummary; return }
+      '^a' {
+        $ids = @($Script:WS_SAFE_BATCH)
+        if ($ws.IsAdmin) { $ids += $Script:WS_SAFE_BATCH_ADMIN }
+        $ws.BatchMode = $true
+        try { foreach ($id in $ids) { Invoke-SectionById -Id $id } } finally { $ws.BatchMode = $false }
+        Wait-Enter
+      }
+      '^d' { $ws.DryRun = -not $ws.DryRun }
+      '^y' { $ws.Yes = -not $ws.Yes }
+      '^s' { Show-SessionSummary; Wait-Enter }
+      '^\d+$' {
+        $id = [int]$choice
+        if (Get-Section $id) { Invoke-SectionById -Id $id; Wait-Enter } else { Write-Warn "no section $id" }
+      }
+      default { Write-Warn "unrecognised choice: $choice" }
+    }
+  }
+}

package/modules/notify.ps1

@@ -0,0 +1,60 @@
+# notify.ps1 - --notify: one Windows notification when a run ends.
+#
+# Off by default. --quiet still notifies (that is the point of the flag when a Scheduled Task runs it).
+# Every path is wrapped: a notification that cannot be shown is not a failed run, so this NEVER touches the
+# exit code and NEVER writes to stdout - --json promises exactly one line there.
+
+function Get-RunNotificationText {
+  <# .SYNOPSIS The two lines a notification carries. Pure, so the self-test can read it without a toast. #>
+  $ws = $Script:WS
+  $ran = @($ws.Report.steps | Where-Object { $_.status -in 'ran', 'dry-run' }).Count
+  if ($ws.DryRun) {
+    return [pscustomobject]@{ Title = "$Script:WS_NAME - dry run finished"; Body = ("about " + (Format-Bytes $ws.TotalEstimated) + " could be freed across $ran section(s)") }
+  }
+  return [pscustomobject]@{ Title = "$Script:WS_NAME finished"; Body = ("freed " + (Format-Bytes $ws.TotalFreed) + " across $ran section(s)") }
+}
+
+function Show-ToastNotification {
+  <# .SYNOPSIS Windows PowerShell 5.1: a real toast through WinRT, under the PowerShell AppUserModelId. #>
+  param([string] $Title, [string] $Body)
+  $appId = '{1AC14E77-02E7-4E5D-B744-2EB1AE5198B7}\WindowsPowerShell\v1.0\powershell.exe'
+  $null = [Windows.UI.Notifications.ToastNotificationManager, Windows.UI.Notifications, ContentType = WindowsRuntime]
+  $null = [Windows.Data.Xml.Dom.XmlDocument, Windows.Data.Xml.Dom.XmlDocument, ContentType = WindowsRuntime]
+  $tpl = [Windows.UI.Notifications.ToastNotificationManager]::GetTemplateContent([Windows.UI.Notifications.ToastTemplateType]::ToastText02)
+  $texts = $tpl.GetElementsByTagName('text')
+  $null = $texts.Item(0).AppendChild($tpl.CreateTextNode($Title))
+  $null = $texts.Item(1).AppendChild($tpl.CreateTextNode($Body))
+  $toast = New-Object Windows.UI.Notifications.ToastNotification($tpl)
+  [Windows.UI.Notifications.ToastNotificationManager]::CreateToastNotifier($appId).Show($toast)
+}
+
+function Show-BalloonNotification {
+  <# .SYNOPSIS PowerShell 7 has no WinRT projection by default: a tray balloon instead. #>
+  param([string] $Title, [string] $Body)
+  Add-Type -AssemblyName System.Windows.Forms -ErrorAction Stop
+  Add-Type -AssemblyName System.Drawing -ErrorAction Stop
+  $icon = New-Object System.Windows.Forms.NotifyIcon
+  try {
+    $icon.Icon = [System.Drawing.SystemIcons]::Information
+    $icon.Visible = $true
+    $icon.ShowBalloonTip(5000, $Title, $Body, [System.Windows.Forms.ToolTipIcon]::Info)
+    # The balloon needs the tray icon to survive a moment; without this it is created and destroyed unseen.
+    Start-Sleep -Milliseconds 600
+  } finally {
+    $icon.Visible = $false
+    $icon.Dispose()
+  }
+}
+
+function Send-RunNotification {
+  <# .SYNOPSIS --notify: show the end-of-run notification, or say quietly in the log why it could not. #>
+  if (-not $Script:WS.Notify) { return }
+  $text = Get-RunNotificationText
+  try {
+    if ($PSVersionTable.PSEdition -eq 'Core') { Show-BalloonNotification -Title $text.Title -Body $text.Body }
+    else { Show-ToastNotification -Title $text.Title -Body $text.Body }
+    Write-LogLine "notification shown: $($text.Title) - $($text.Body)"
+  } catch {
+    Write-LogLine "notification could not be shown (this never affects the exit code): $($_.Exception.Message)"
+  }
+}

package/modules/orphaned_appdata.ps1

@@ -0,0 +1,189 @@
+# orphaned_appdata.ps1 - section 23: folders directly under %APPDATA% and %LOCALAPPDATA% that belong to no
+# installed program. Interactive only; selected folders go to the Recycle Bin.
+#
+# The dangerous direction here is calling something orphaned when it is not, so every test errs the other
+# way: matching is generous, the exclusion list is long, and an EMPTY program index produces ZERO candidates
+# rather than "everything is orphaned".
+
+# Windows' own folders, shared infrastructure, and vendors whose data outlives an uninstall.
+$Script:WS_ORPHAN_EXCLUDE = @(
+  'Microsoft', 'Windows', 'WindowsPowerShell', 'PowerShell', 'Packages', 'Programs', 'Temp', 'Tmp', 'Comms',
+  'ConnectedDevicesPlatform', 'D3DSCache', 'Google', 'Mozilla', 'CrashDumps', 'VirtualStore', 'PeerDistRepub',
+  'Publishers', 'History', 'IconCache', 'ElevatedDiagnostics', 'Application Data', 'Local Settings',
+  'Deployment', 'assembly', 'GroupPolicy', 'Roaming', 'Local', 'LocalLow', 'Low', 'Diagnostics',
+  'PlaceholderTileLogoFolder', 'Desktop', 'Downloads', 'Documents', 'Start Menu', 'SendTo',
+  'Recent', 'NetHood', 'PrintHood', 'Templates', 'Cookies',
+  # Platform folders that belong to Windows or .NET rather than to any one program: they look orphaned
+  # because no uninstall entry names them, and one of them holds settings a .NET app wrote.
+  'IsolatedStorage', 'ToastNotificationManagerCompat', 'AppV', 'Package Cache', 'DBG', 'CLR_v4.0', 'CLR_v4.0_32'
+)
+
+function ConvertTo-MatchToken {
+  <# .SYNOPSIS Lower-case, alphanumerics only - so "Slack Technologies, Inc." and "slack" compare equal. #>
+  param([string] $Text)
+  if ([string]::IsNullOrWhiteSpace($Text)) { return '' }
+  return ($Text.ToLowerInvariant() -replace '[^a-z0-9]', '')
+}
+
+function Add-MatchTokens {
+  <# .SYNOPSIS Add a display string to the token set: the whole thing, plus each word of 4+ characters. #>
+  param([System.Collections.Generic.HashSet[string]] $Set, [string] $Text)
+  $whole = ConvertTo-MatchToken $Text
+  if ($whole.Length -ge 3) { $null = $Set.Add($whole) }
+  foreach ($w in ($Text -split '[^A-Za-z0-9]+')) {
+    $t = ConvertTo-MatchToken $w
+    if ($t.Length -ge 4) { $null = $Set.Add($t) }
+  }
+}
+
+function Get-InstalledProgramRows {
+  <# .SYNOPSIS Raw uninstall-hive rows from all three registry views. Shared with section 24. #>
+  $rows = @()
+  $hives = @(
+    'HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall',
+    'HKLM:\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall',
+    'HKCU:\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall'
+  )
+  foreach ($h in $hives) {
+    $keys = @()
+    try { $keys = @(Get-ChildItem -LiteralPath $h -ErrorAction Stop) } catch { $keys = @() }
+    foreach ($k in $keys) {
+      $props = $null
+      try { $props = Get-ItemProperty -LiteralPath $k.PSPath -ErrorAction Stop } catch { continue }
+      if (-not $props.DisplayName) { continue }
+      $rows += [pscustomobject]@{
+        DisplayName = [string]$props.DisplayName; DisplayVersion = [string]$props.DisplayVersion
+        Publisher = [string]$props.Publisher; InstallDate = [string]$props.InstallDate
+        EstimatedSizeKb = [long]0 + $props.EstimatedSize; InstallLocation = [string]$props.InstallLocation
+        UninstallString = [string]$props.UninstallString; SystemComponent = [int]0 + $props.SystemComponent
+      }
+    }
+  }
+  return $rows
+}
+
+function Get-InstalledProgramIndex {
+  <# .SYNOPSIS Everything that says "a program owns this name": uninstall entries, program folders, Store
+     package names and running processes. RegistryCount drives the fail-closed gate in section 23. #>
+  $P = $Script:P
+  $set = New-Object System.Collections.Generic.HashSet[string]([StringComparer]::Ordinal)
+  $rows = @(Get-InstalledProgramRows)
+  foreach ($r in $rows) {
+    Add-MatchTokens -Set $set -Text $r.DisplayName
+    Add-MatchTokens -Set $set -Text $r.Publisher
+    if ($r.InstallLocation) { Add-MatchTokens -Set $set -Text (Split-Path -Leaf ($r.InstallLocation.TrimEnd('\'))) }
+  }
+  foreach ($dir in @($P.PF, $P.PF86, (Join-Path $P.L 'Programs'), (Join-Path $P.L 'Microsoft\WindowsApps'), (Join-Path $P.PD 'Microsoft\Windows\Start Menu\Programs'))) {
+    if (-not $dir -or -not (Test-DirPresent $dir)) { continue }
+    foreach ($e in (Get-ChildEntries $dir)) { Add-MatchTokens -Set $set -Text (($e.Name -split '_')[0]) }
+  }
+  foreach ($e in (Get-ChildEntries (Join-Path $P.L 'Packages'))) { Add-MatchTokens -Set $set -Text (($e.Name -split '_')[0]) }
+  try { foreach ($proc in (Get-Process -ErrorAction SilentlyContinue)) { Add-MatchTokens -Set $set -Text $proc.ProcessName } } catch { $null = $_ }
+  return [pscustomobject]@{ Tokens = $set; RegistryCount = $rows.Count; Rows = $rows }
+}
+
+function Get-OrphanExclusions {
+  <# .SYNOPSIS Folder names section 23 never offers: the fixed list plus, derived at run time, the first
+     segment under AppData of every target the tool already declares - so a vendor folder we clean can never
+     also be offered for deletion, and the list cannot drift as sections are added. #>
+  $P = $Script:P
+  $set = New-Object System.Collections.Generic.HashSet[string]([StringComparer]::OrdinalIgnoreCase)
+  foreach ($n in $Script:WS_ORPHAN_EXCLUDE) { $null = $set.Add($n) }
+  $prefixes = @("$($P.A)\", "$($P.L)\")
+  foreach ($t in (Get-AllTargets)) {
+    $path = [string]$t.Path
+    foreach ($pre in $prefixes) {
+      if ($path.StartsWith($pre, [StringComparison]::OrdinalIgnoreCase)) {
+        $seg = ($path.Substring($pre.Length) -split '\\')[0]
+        if ($seg) { $null = $set.Add($seg) }
+      }
+    }
+  }
+  # ,$set - a bare `return $set` UNROLLS the HashSet into an Object[], whose .Contains is case-SENSITIVE,
+  # so a folder named "slack" would slip past the "Slack" entry. The comma keeps the set a set.
+  return , $set
+}
+
+function Test-OrphanFolderName {
+  <# .SYNOPSIS True when NOTHING installed claims this folder name. Deliberately generous in the other
+     direction: a token that merely starts with the name (or the reverse) counts as a claim. #>
+  param([string] $Name, [pscustomobject] $Index)
+  $n = ConvertTo-MatchToken $Name
+  if ($n.Length -lt 3) { return $false }
+  if ($Index.Tokens.Contains($n)) { return $false }
+  foreach ($t in $Index.Tokens) {
+    if ($t.Length -lt 4) { continue }
+    if ($t.StartsWith($n) -or $n.StartsWith($t)) { return $false }
+  }
+  return $true
+}
+
+function Find-OrphanedAppData {
+  <# .SYNOPSIS Top-level AppData folders idle N+ days that no installed program claims. Fails closed.
+     -Index is for the self-test: it proves the fail-closed gate without touching the real registry. #>
+  param([int] $Days, [pscustomobject] $Index = $null)
+  $P = $Script:P
+  $index = $Index
+  if ($null -eq $index) { $index = Get-InstalledProgramIndex }
+  if ($index.RegistryCount -eq 0) {
+    Write-Warn 'no uninstall entries could be read: refusing to call anything orphaned (fail closed).'
+    return @()
+  }
+  Write-Note "cross-checked against $($index.RegistryCount) installed-program entries"
+  $exclude = Get-OrphanExclusions
+  $out = @()
+  foreach ($root in @($P.A, $P.L)) {
+    if (-not (Test-DirPresent $root)) { continue }
+    foreach ($e in (Get-ChildEntries $root)) {
+      if (-not ($e -is [IO.DirectoryInfo]) -or (Test-ReparsePoint $e)) { continue }
+      if ($exclude.Contains($e.Name)) { continue }
+      $full = Remove-LongPrefix $e.FullName
+      if (Get-ProtectionReason $full) { continue }
+      if (-not (Test-OrphanFolderName -Name $e.Name -Index $index)) { continue }
+      $idle = Get-IdleDays $full
+      if ($idle -lt $Days) { continue }
+      $out += [pscustomobject]@{ Name = $e.Name; Path = $full; Root = (Get-FullPath $root); Idle = $idle; Bytes = [long](Get-DirectoryBytes $full) }
+    }
+  }
+  return @($out | Sort-Object Bytes -Descending | Select-Object -First 200)
+}
+
+function Get-Targets23 {
+  <# .SYNOPSIS Informational rows: the candidates are found at run time, never declared as fixed paths. #>
+  $P = $Script:P
+  $t = @()
+  foreach ($r in @($P.A, $P.L)) {
+    if (Test-DirPresent $r) { $t += (New-Target 23 'AppData root scanned for orphans' (Get-FullPath $r) -Kind cmd -Note 'top-level folders only; you pick what goes, and it lands in the Recycle Bin') }
+  }
+  return $t
+}
+
+function Invoke-Section23 {
+  $ws = $Script:WS
+  Write-SectionIntro @(
+    'Uninstalling a program usually leaves its AppData folder behind. This lists top-level folders under',
+    "Roaming and Local that no installed program, Store package or running process claims and that nothing",
+    "has touched for $($ws.Days)+ days. You pick what goes; it lands in the Recycle Bin."
+  )
+  $rows = @(Find-OrphanedAppData -Days $ws.Days)
+  if ($rows.Count -eq 0) { Write-Info 'no orphaned application data found'; return }
+  Write-UiLine ("  {0,3}  {1,10} {2,6}  {3}" -f '#', 'SIZE', 'IDLE', 'FOLDER') 'White'
+  $i = 1; $total = [long]0
+  foreach ($r in $rows) {
+    Write-UiLine ("  {0,3}  {1,10} {2,5}d  {3}" -f $i, (Format-Bytes $r.Bytes), $r.Idle, $r.Path) 'Gray'
+    Add-JsonCandidate -Section 23 -Index $i -Path $r.Path -Bytes $r.Bytes -IdleDays $r.Idle
+    $total += $r.Bytes; $i++
+  }
+  Write-Info ('total: ' + (Format-Bytes $total))
+  Write-Note 'a folder here can still hold settings or a licence for a program you plan to reinstall - read the list.'
+  $dest = 'the Recycle Bin'
+  if ($ws.Permanent) { $dest = 'PERMANENT deletion (--permanent)' }
+  Write-Note "selected folders go to $dest"
+  $picks = @(Read-MultiSelect -Total $rows.Count -NoAutoYes -Candidates @($rows | ForEach-Object { $_.Path }))
+  if ($picks.Count -eq 0) { Write-Info 'nothing selected'; return }
+  if (-not $ws.DryRun) {
+    # Orphaned app data never auto-confirms: --yes does not apply. An explicit --select / --select-file does.
+    if (-not (Confirm-Ui -Prompt "Move $($picks.Count) folder(s) to $dest ?" -Default 'n' -NoAutoYes -ScriptedOk)) { Write-Info 'skipped'; return }
+  }
+  foreach ($k in $picks) { $null = Send-ToRecycleBin -Path $rows[$k - 1].Path -Within $rows[$k - 1].Root }
+}

package/modules/personal.ps1

@@ -1,124 +1,126 @@
-# personal.ps1 - sections 18 and 19: personal files in Downloads. Interactive only; the Recycle Bin is the destination.
-
-$Script:WS_PARTIAL_PATTERNS = @('*.crdownload', '*.part', '*.partial', '*.fdmdownload', '*.opdownload', '*.!ut', '*.aria2', '*.download', '*.bc!', '*.tmp')
-
-function Get-PersonalRoots {
-  $roots = @()
-  $d = Join-Path $Script:P.U 'Downloads'
-  if (Test-DirPresent $d) { $roots += (Get-FullPath $d) }
-  return $roots
-}
-
-function Get-Targets18 {
-  $t = @()
-  foreach ($r in (Get-PersonalRoots)) { $t += (New-Target 18 'Partial / orphan downloads' $r -Kind cmd -Note ($Script:WS_PARTIAL_PATTERNS -join ' ')) }
-  return $t
-}
-
-function Get-Targets19 {
-  $t = @()
-  foreach ($r in (Get-PersonalRoots)) { $t += (New-Target 19 "Files >= $($Script:WS.LargeFileMb) MB idle $($Script:WS.Days)+ days" $r -Kind cmd -Note 'moved to the Recycle Bin after you pick them') }
-  return $t
-}
-
-function Get-FilesUnder {
-  <# .SYNOPSIS Files under Root up to MaxDepth, never following links, never entering protected folders. #>
-  param([string] $Root, [int] $MaxDepth = 4)
-  $out = New-Object System.Collections.Generic.List[object]
-  $stack = New-Object System.Collections.Generic.Stack[object]
-  $stack.Push(@($Root, 0))
-  while ($stack.Count -gt 0) {
-    $item = $stack.Pop()
-    foreach ($e in (Get-ChildEntries ([string]$item[0]))) {
-      if (Test-ReparsePoint $e) { continue }
-      if ($e -is [IO.DirectoryInfo]) { if ([int]$item[1] -lt $MaxDepth) { $stack.Push(@((Remove-LongPrefix $e.FullName), [int]$item[1] + 1)) }; continue }
-      $out.Add($e)
-    }
-  }
-  return $out
-}
-
-function Get-PartialDownloads {
-  $list = @()
-  foreach ($root in (Get-PersonalRoots)) {
-    foreach ($f in (Get-FilesUnder -Root $root -MaxDepth 4)) {
-      foreach ($pat in $Script:WS_PARTIAL_PATTERNS) {
-        if ($f.Name -like $pat) { $list += [pscustomobject]@{ Path = (Remove-LongPrefix $f.FullName); Bytes = [long]$f.Length; Idle = [int][math]::Floor(([datetime]::UtcNow - (Get-NewestTimestampUtc $f)).TotalDays); Root = $root }; break }
-      }
-    }
-  }
-  return @($list | Sort-Object Bytes -Descending)
-}
-
-function Get-LargeStaleFiles {
-  $ws = $Script:WS
-  $min = [long]$ws.LargeFileMb * 1MB
-  $list = @()
-  foreach ($root in (Get-PersonalRoots)) {
-    foreach ($f in (Get-FilesUnder -Root $root -MaxDepth 4)) {
-      if ([long]$f.Length -lt $min) { continue }
-      $idle = [int][math]::Floor(([datetime]::UtcNow - (Get-NewestTimestampUtc $f)).TotalDays)
-      if ($idle -lt $ws.Days) { continue }
-      $list += [pscustomobject]@{ Path = (Remove-LongPrefix $f.FullName); Bytes = [long]$f.Length; Idle = $idle; Root = $root }
-    }
-  }
-  return @($list | Sort-Object Bytes -Descending | Select-Object -First 100)
-}
-
-function Show-FileTable {
-  param([object[]] $Rows)
-  Write-UiLine ("  {0,3}  {1,10} {2,6}  {3}" -f '#', 'SIZE', 'IDLE', 'FILE') 'White'
-  $i = 1
-  foreach ($r in $Rows) { Write-UiLine ("  {0,3}  {1,10} {2,5}d  {3}" -f $i, (Format-Bytes $r.Bytes), $r.Idle, $r.Path) 'Gray'; $i++ }
-}
-
-function Invoke-PersonalPicker {
-  param([object[]] $Rows, [string] $Prompt)
-  $ws = $Script:WS
-  $Rows = @($Rows)
-  if ($Rows.Count -eq 0) { Write-Info 'none found'; return }
-  Show-FileTable $Rows
-  $total = [long]0
-  foreach ($r in $Rows) { $total += $r.Bytes }
-  Write-Info ("total: " + (Format-Bytes $total))
-  $dest = 'the Recycle Bin'
-  if ($ws.Permanent) { $dest = 'PERMANENT deletion (--permanent)' }
-  Write-Note "selected files go to $dest"
-  $picks = @(Read-MultiSelect -Total $Rows.Count -NoAutoYes)
-  if ($picks.Count -eq 0) { Write-Info 'nothing selected'; return }
-  if (-not $ws.DryRun) {
-    # Personal files never auto-confirm: --yes does not apply here.
-    if (-not (Confirm-Ui -Prompt "$Prompt ($($picks.Count) file(s))?" -Default 'n' -NoAutoYes)) { Write-Info 'skipped'; return }
-  }
-  foreach ($k in $picks) { $null = Send-ToRecycleBin -Path $Rows[$k - 1].Path -Within $Rows[$k - 1].Root }
-}
-
-function Invoke-Section18 {
-  Write-SectionIntro @(
-    'Half-finished downloads left behind by browsers and download managers (.crdownload, .part, .tmp, ...).',
-    'You pick what goes; it lands in the Recycle Bin. Desktop and cloud-synced folders are never scanned.'
-  )
-  if (@(Get-PersonalRoots).Count -eq 0) { Write-Info 'no Downloads folder found'; return }
-  Invoke-PersonalPicker -Rows @(Get-PartialDownloads) -Prompt 'Move the selected partial downloads to the Recycle Bin'
-}
-
-function Invoke-Section19 {
-  $ws = $Script:WS
-  Write-SectionIntro @(
-    "Files of $($ws.LargeFileMb) MB or more in Downloads that nothing has touched for $($ws.Days)+ days: old installers, ISOs,",
-    'archives you already extracted. You pick what goes; it lands in the Recycle Bin.'
-  )
-  if (@(Get-PersonalRoots).Count -eq 0) { Write-Info 'no Downloads folder found'; return }
-  Invoke-PersonalPicker -Rows @(Get-LargeStaleFiles) -Prompt 'Move the selected files to the Recycle Bin'
-}
-
-function Show-PersonalScan {
-  <# .SYNOPSIS Read-only listing used by --scan. #>
-  Write-Box 'Personal files (read-only)' 'Sections 18 and 19 are interactive only - nothing here is deleted'
-  Write-Section 'Partial / orphan downloads'
-  $p = @(Get-PartialDownloads)
-  if ($p.Count -eq 0) { Write-Info 'none found' } else { Show-FileTable @($p | Select-Object -First 30) }
-  Write-Section "Files >= $($Script:WS.LargeFileMb) MB idle $($Script:WS.Days)+ days in Downloads"
-  $l = @(Get-LargeStaleFiles)
-  if ($l.Count -eq 0) { Write-Info 'none found' } else { Show-FileTable @($l | Select-Object -First 30) }
-}
+# personal.ps1 - sections 18 and 19: personal files in Downloads. Interactive only; the Recycle Bin is the destination.
+
+$Script:WS_PARTIAL_PATTERNS = @('*.crdownload', '*.part', '*.partial', '*.fdmdownload', '*.opdownload', '*.!ut', '*.aria2', '*.download', '*.bc!', '*.tmp')
+
+function Get-PersonalRoots {
+  $roots = @()
+  $d = Join-Path $Script:P.U 'Downloads'
+  if (Test-DirPresent $d) { $roots += (Get-FullPath $d) }
+  return $roots
+}
+
+function Get-Targets18 {
+  $t = @()
+  foreach ($r in (Get-PersonalRoots)) { $t += (New-Target 18 'Partial / orphan downloads' $r -Kind cmd -Note ($Script:WS_PARTIAL_PATTERNS -join ' ')) }
+  return $t
+}
+
+function Get-Targets19 {
+  $t = @()
+  foreach ($r in (Get-PersonalRoots)) { $t += (New-Target 19 "Files >= $($Script:WS.LargeFileMb) MB idle $($Script:WS.Days)+ days" $r -Kind cmd -Note 'moved to the Recycle Bin after you pick them') }
+  return $t
+}
+
+function Get-FilesUnder {
+  <# .SYNOPSIS Files under Root up to MaxDepth, never following links, never entering protected folders. #>
+  param([string] $Root, [int] $MaxDepth = 4)
+  $out = New-Object System.Collections.Generic.List[object]
+  $stack = New-Object System.Collections.Generic.Stack[object]
+  $stack.Push(@($Root, 0))
+  while ($stack.Count -gt 0) {
+    $item = $stack.Pop()
+    foreach ($e in (Get-ChildEntries ([string]$item[0]))) {
+      if (Test-ReparsePoint $e) { continue }
+      if ($e -is [IO.DirectoryInfo]) { if ([int]$item[1] -lt $MaxDepth) { $stack.Push(@((Remove-LongPrefix $e.FullName), [int]$item[1] + 1)) }; continue }
+      $out.Add($e)
+    }
+  }
+  return $out
+}
+
+function Get-PartialDownloads {
+  $list = @()
+  foreach ($root in (Get-PersonalRoots)) {
+    foreach ($f in (Get-FilesUnder -Root $root -MaxDepth 4)) {
+      foreach ($pat in $Script:WS_PARTIAL_PATTERNS) {
+        if ($f.Name -like $pat) { $list += [pscustomobject]@{ Path = (Remove-LongPrefix $f.FullName); Bytes = [long]$f.Length; Idle = [int][math]::Floor(([datetime]::UtcNow - (Get-NewestTimestampUtc $f)).TotalDays); Root = $root }; break }
+      }
+    }
+  }
+  return @($list | Sort-Object Bytes -Descending)
+}
+
+function Get-LargeStaleFiles {
+  $ws = $Script:WS
+  $min = [long]$ws.LargeFileMb * 1MB
+  $list = @()
+  foreach ($root in (Get-PersonalRoots)) {
+    foreach ($f in (Get-FilesUnder -Root $root -MaxDepth 4)) {
+      if ([long]$f.Length -lt $min) { continue }
+      $idle = [int][math]::Floor(([datetime]::UtcNow - (Get-NewestTimestampUtc $f)).TotalDays)
+      if ($idle -lt $ws.Days) { continue }
+      $list += [pscustomobject]@{ Path = (Remove-LongPrefix $f.FullName); Bytes = [long]$f.Length; Idle = $idle; Root = $root }
+    }
+  }
+  return @($list | Sort-Object Bytes -Descending | Select-Object -First 100)
+}
+
+function Show-FileTable {
+  param([object[]] $Rows)
+  Write-UiLine ("  {0,3}  {1,10} {2,6}  {3}" -f '#', 'SIZE', 'IDLE', 'FILE') 'White'
+  $i = 1
+  foreach ($r in $Rows) { Write-UiLine ("  {0,3}  {1,10} {2,5}d  {3}" -f $i, (Format-Bytes $r.Bytes), $r.Idle, $r.Path) 'Gray'; $i++ }
+}
+
+function Invoke-PersonalPicker {
+  param([object[]] $Rows, [string] $Prompt, [int] $Section = 0)
+  $ws = $Script:WS
+  $Rows = @($Rows)
+  if ($Rows.Count -eq 0) { Write-Info 'none found'; return }
+  Show-FileTable $Rows
+  $total = [long]0
+  $i = 1
+  foreach ($r in $Rows) { $total += $r.Bytes; Add-JsonCandidate -Section $Section -Index $i -Path $r.Path -Bytes $r.Bytes -IdleDays $r.Idle; $i++ }
+  Write-Info ("total: " + (Format-Bytes $total))
+  $dest = 'the Recycle Bin'
+  if ($ws.Permanent) { $dest = 'PERMANENT deletion (--permanent)' }
+  Write-Note "selected files go to $dest"
+  $picks = @(Read-MultiSelect -Total $Rows.Count -NoAutoYes -Candidates @($Rows | ForEach-Object { $_.Path }))
+  if ($picks.Count -eq 0) { Write-Info 'nothing selected'; return }
+  if (-not $ws.DryRun) {
+    # Personal files never auto-confirm: --yes does not apply here. An explicit --select / --select-file
+    # choice does, because it is a person naming these exact files in advance.
+    if (-not (Confirm-Ui -Prompt "$Prompt ($($picks.Count) file(s))?" -Default 'n' -NoAutoYes -ScriptedOk)) { Write-Info 'skipped'; return }
+  }
+  foreach ($k in $picks) { $null = Send-ToRecycleBin -Path $Rows[$k - 1].Path -Within $Rows[$k - 1].Root }
+}
+
+function Invoke-Section18 {
+  Write-SectionIntro @(
+    'Half-finished downloads left behind by browsers and download managers (.crdownload, .part, .tmp, ...).',
+    'You pick what goes; it lands in the Recycle Bin. Desktop and cloud-synced folders are never scanned.'
+  )
+  if (@(Get-PersonalRoots).Count -eq 0) { Write-Info 'no Downloads folder found'; return }
+  Invoke-PersonalPicker -Rows @(Get-PartialDownloads) -Prompt 'Move the selected partial downloads to the Recycle Bin' -Section 18
+}
+
+function Invoke-Section19 {
+  $ws = $Script:WS
+  Write-SectionIntro @(
+    "Files of $($ws.LargeFileMb) MB or more in Downloads that nothing has touched for $($ws.Days)+ days: old installers, ISOs,",
+    'archives you already extracted. You pick what goes; it lands in the Recycle Bin.'
+  )
+  if (@(Get-PersonalRoots).Count -eq 0) { Write-Info 'no Downloads folder found'; return }
+  Invoke-PersonalPicker -Rows @(Get-LargeStaleFiles) -Prompt 'Move the selected files to the Recycle Bin' -Section 19
+}
+
+function Show-PersonalScan {
+  <# .SYNOPSIS Read-only listing used by --scan. #>
+  Write-Box 'Personal files (read-only)' 'Sections 18 and 19 are interactive only - nothing here is deleted'
+  Write-Section 'Partial / orphan downloads'
+  $p = @(Get-PartialDownloads)
+  if ($p.Count -eq 0) { Write-Info 'none found' } else { Show-FileTable @($p | Select-Object -First 30) }
+  Write-Section "Files >= $($Script:WS.LargeFileMb) MB idle $($Script:WS.Days)+ days in Downloads"
+  $l = @(Get-LargeStaleFiles)
+  if ($l.Count -eq 0) { Write-Info 'none found' } else { Show-FileTable @($l | Select-Object -First 30) }
+}