windmill-components 1.695.1 → 1.698.0

package/package/components/Editor.svelte

@@ -58,7 +58,7 @@ import { resource, useDebounce, watch } from 'runed';
 // import EditorTheme from './EditorTheme.svelte'
 let divEl = $state(null);
 let editor = $state(null);
-let { code = $bindable(), cmdEnterAction = undefined, formatAction = undefined, automaticLayout = true, websocketAlive = $bindable(), shouldBindKey = true, fixedOverflowWidgets = true, path = undefined, yContent = undefined, awareness = undefined, folding = false, args = undefined, useWebsockets = true, small = false, scriptLang, disabled = false, lineNumbersMinChars = 3, files = {}, extraLib = undefined, changeTimeout = 500, loadAsync = false, key = undefined, class: clazz = undefined, moduleId = undefined, enablePreprocessorSnippet = false, rawAppRunnableKey = undefined, preparedAssetsSqlQueries, customTag } = $props();
+let { code = $bindable(), cmdEnterAction = undefined, formatAction = undefined, automaticLayout = true, websocketAlive = $bindable(), shouldBindKey = true, fixedOverflowWidgets = true, path = undefined, yContent = undefined, awareness = undefined, folding = false, args = undefined, useWebsockets = true, small = false, scriptLang, workflowAsCode = false, disabled = false, lineNumbersMinChars = 3, files = {}, extraLib = undefined, changeTimeout = 500, loadAsync = false, key = undefined, class: clazz = undefined, moduleId = undefined, enablePreprocessorSnippet = false, rawAppRunnableKey = undefined, preparedAssetsSqlQueries, customTag } = $props();
 $effect.pre(() => {
     if (websocketAlive == undefined) {
         websocketAlive = {
@@ -627,11 +627,11 @@ function addChatHandler(editor) {
     }
 }
 let autocompletor = $state(undefined);
-function addAutoCompletor(editor, scriptLang) {
+function addAutoCompletor(editor, scriptLang, workflowAsCode) {
     if (autocompletor) {
         autocompletor.dispose();
     }
-    autocompletor = new Autocompletor(editor, scriptLang);
+    autocompletor = new Autocompletor(editor, scriptLang, { workflowAsCode });
 }
 const outputChannel = {
     name: 'Language Server Client',
@@ -1543,13 +1543,14 @@ $effect(() => {
     (!dbSchema || lang !== 'graphql') && untrack(() => disposeGaphqlService());
 });
 $effect(() => {
+    const currentWorkflowAsCode = workflowAsCode;
     $copilotInfo.enabled &&
         $codeCompletionSessionEnabled &&
         Autocompletor.isProviderModelSupported($copilotInfo.codeCompletionModel) &&
         initialized &&
         editor &&
         scriptLang &&
-        untrack(() => editor && addAutoCompletor(editor, scriptLang));
+        untrack(() => editor && addAutoCompletor(editor, scriptLang, currentWorkflowAsCode));
 });
 $effect(() => {
     $copilotInfo.enabled && initialized && editor && untrack(() => editor && addChatHandler(editor));

package/package/components/Editor.svelte.d.ts

@@ -23,6 +23,7 @@ interface Props {
     useWebsockets?: boolean;
     small?: boolean;
     scriptLang: Preview['language'] | 'bunnative' | 'tsx' | 'jsx' | 'json' | undefined;
+    workflowAsCode?: boolean;
     disabled?: boolean;
     lineNumbersMinChars?: number;
     files?: Record<string, {

package/package/components/FilterSearchbar.svelte

@@ -185,7 +185,7 @@ import Button from './common/button/Button.svelte';
 import Badge from './common/badge/Badge.svelte';
 import InlineCalendarInput, { fromCalendarDate, toCalendarDate } from './common/InlineCalendarInput.svelte';
 import { ButtonType } from './common';
-let { schema, value: valueInput = $bindable(), presets: _presets = [], class: className, placeholder = 'Filter...' } = $props();
+let { schema, value: valueInput = $bindable(), presets: _presets = [], class: className, placeholder = 'Filter...', autofocus } = $props();
 let _value = new DebouncedTempValue(() => clone(valueInput), (v) => !errors.length && (valueInput = clone(v)), (t) => Object.entries(t));
 let value = $derived(_value.current);
 let errors = $derived(validateFilterInstance(schema, value));
@@ -493,6 +493,8 @@ function appendFilterAsText(presetValue) {
 			inputSizeClasses.md
 		)}
 		{placeholder}
+		onKeyDown={() => (open = true)}
+		{autofocus}
 	/>
 	{#if asText.val}
 		<CloseButton small class="mr-1.5" onClick={() => (_value.current = {})} />

package/package/components/FilterSearchbar.svelte.d.ts

@@ -81,6 +81,7 @@ type Props<SchemaT extends FilterSchemaRec> = {
     }[];
     class?: string;
     placeholder?: string;
+    autofocus?: boolean;
 };
 declare const FilterSearchbar: import("svelte").Component<Props<FilterSchemaRec>, {}, "value">;
 type FilterSearchbar = ReturnType<typeof FilterSearchbar>;

package/package/components/ForkWorkspaceBanner.svelte

@@ -213,6 +213,22 @@ function forkAheadBehindMessage(changesAhead, changesBehind) {
 												: ''}
 										</span>
 									{/if}
+									{#if comparison.summary.schedules_changed > 0}
+										<span class="text-blue-700 dark:text-blue-100">
+											{comparison.summary.schedules_changed} schedule{comparison.summary
+												.schedules_changed !== 1
+												? 's'
+												: ''}
+										</span>
+									{/if}
+									{#if comparison.summary.triggers_changed > 0}
+										<span class="text-blue-700 dark:text-blue-100">
+											{comparison.summary.triggers_changed} trigger{comparison.summary
+												.triggers_changed !== 1
+												? 's'
+												: ''}
+										</span>
+									{/if}
 								</div>
 
 								{#if ciTestTotal > 0}

package/package/components/LogViewer.svelte

@@ -12,6 +12,7 @@ const S3_LOG_SEARCH_LIMIT = 2000;
 import { Button, Drawer, DrawerContent } from './common';
 import { copyToClipboard } from '../utils';
 import { base } from '../base';
+import { withExternalDomain } from '../externalDomain';
 import { workspaceStore } from '../stores';
 import { AnsiUp } from 'ansi_up';
 import NoWorkerWithTagWarning from './runs/NoWorkerWithTagWarning.svelte';
@@ -24,7 +25,7 @@ let { content, isLoading, duration = undefined, mem = undefined, wrapperClass =
 const ansi_up = $state(new AnsiUp());
 ansi_up.use_classes = true;
 let scroll = $state(true);
-let div = $state(null);
+let preEl = $state(null);
 // let downloadStartUrl: string | undefined = undefined
 let LOG_INC = 10000;
 let LOG_LIMIT = $state(LOG_INC);
@@ -95,8 +96,8 @@ function truncateContent(jobContent, loadedFromObjectStore, limit) {
     return content;
 }
 export function scrollToBottom() {
-    // console.log('scrollToBottom', scroll, div)
-    scroll && setTimeout(() => div?.scroll({ top: div?.scrollHeight, behavior: 'smooth' }), 100);
+    scroll &&
+        setTimeout(() => preEl?.scroll({ top: preEl?.scrollHeight, behavior: 'smooth' }), 100);
 }
 let logViewer = $state();
 async function getStoreLogs() {
@@ -132,6 +133,7 @@ $effect.pre(() => {
         scroll = true;
     }
 });
+let downloadHref = $derived(withExternalDomain(`${base}/api/w/${$workspaceStore}/jobs_u/get_logs/${jobId}`));
 let truncatedContent = $derived(truncateContent(content, loadedFromObjectStore, LOG_LIMIT));
 let prefixInfo = $derived(findPrefixInfo(truncatedContent));
 let downloadStartUrl = $derived(findStartUrl(truncatedContent, prefixInfo));
@@ -170,7 +172,7 @@ let html = $derived.by(() => {
 		{#snippet actions()}
 			{#if jobId && download}
 				<Button
-					href="{base}/api/w/{$workspaceStore}/jobs_u/get_logs/{jobId}"
+					href={downloadHref}
 					download="windmill_logs_{jobId}.txt"
 					color="light"
 					size="xs"
@@ -199,12 +201,12 @@ let html = $derived.by(() => {
 				>{#if content}{@const len =
 						(content?.length ?? 0) +
 						(loadedFromObjectStore?.length ?? 0)}{#if splitHtml}{@html splitHtml.before}<button
-								onclick={getStoreLogs}
-								>Show more... <Tooltip>{tooltipText(prefixInfo)}</Tooltip></button
-							>{@html splitHtml.after}{:else if downloadStartUrl}<button
 							onclick={getStoreLogs}
 							>Show more... <Tooltip>{tooltipText(prefixInfo)}</Tooltip></button
-						><br />{@html html}{:else if len > LOG_LIMIT}(truncated to the last {LOG_LIMIT} characters)...<br
+						>{@html splitHtml.after}{:else if downloadStartUrl}<button onclick={getStoreLogs}
+							>Show more... <Tooltip>{tooltipText(prefixInfo)}</Tooltip></button
+						><br
+						/>{@html html}{:else if len > LOG_LIMIT}(truncated to the last {LOG_LIMIT} characters)...<br
 						/><button onclick={() => showMoreTruncate(len)}>Show more..</button><br
 						/>{@html html}{:else}{@html html}{/if}{:else if isLoading}Waiting for job to start...{:else}No logs are available yet{/if}</pre
 			>
@@ -215,18 +217,41 @@ let html = $derived.by(() => {
 <div class="w-full h-full {wrapperClass}">
 	<div class="w-full h-full relative">
 		<div
-			bind:this={div}
-			class="w-full h-full overflow-auto bg-surface-secondary pt-4 {noMaxH ? '' : 'max-h-screen'}"
+			class="w-full h-full bg-surface-secondary flex flex-col {noMaxH ? '' : 'max-h-screen'}"
 			data-nav-id={navigationId}
 		>
-			<div class="absolute z-10 top-0 right-0 flex flex-row-reverse justify-between text-xs">
-				<div class="flex gap-2">
+			<div class="flex gap-2 ml-2 {small ? 'py-1' : 'py-2'} border-b">
+				{#if isLoading}
+					<div class="flex gap-2 items-center">
+						<Loader2 class="animate-spin" />
+						{#if tag}
+							<div class="flex flex-row items-center gap-1">
+								<div class="text-secondary text-2xs">{tagLabel ?? 'tag'}: {tag}</div>
+								<NoWorkerWithTagWarning {tagLabel} {tag} />
+							</div>
+						{/if}
+						{#if jobId}
+							<QueuePosition {jobId} />
+						{/if}
+					</div>
+				{:else if duration}
+					<span
+						class={twMerge('text-secondary dark:text-gray-400', small ? '!text-2xs' : '!text-xs')}
+						>took {duration}ms</span
+					>
+				{/if}
+				{#if mem}
+					<span class="{small ? '!text-2xs' : '!text-xs'} text-secondary dark:text-gray-400"
+						>mem peak: {(mem / 1024).toPrecision(4)}MB</span
+					>
+				{/if}
+				<div class="flex gap-2 justify-end flex-1">
 					{#if jobId && download}
 						<div class="flex items-center">
 							<a
 								class="text-primary pb-0.5"
 								target="_blank"
-								href="{base}/api/w/{$workspaceStore}/jobs_u/get_logs/{jobId}"
+								href={downloadHref}
 								download="windmill_logs_{jobId}.txt"
 								><Download size="14" />
 							</a>
@@ -234,67 +259,33 @@ let html = $derived.by(() => {
 					{/if}
 					<button onclick={logViewer.openDrawer}><Expand size="12" /></button>
 					{#if !noAutoScroll}
-						<label
-							class="{small
-								? ''
-								: 'py-2'} pr-2 text-2xs flex gap-2 font-normal text-primary items-center"
-						>
+						<label class="pr-2 text-2xs flex gap-2 font-normal text-primary items-center">
 							Auto scroll
 							<input class="windmillapp" type="checkbox" bind:checked={scroll} />
 						</label>
 					{/if}
 				</div>
 			</div>
-			{#if isLoading}
-				<div class="flex gap-2 absolute top-2 left-2 items-center z-10">
-					<Loader2 class="animate-spin" />
-					{#if tag}
-						<div class="flex flex-row items-center gap-1">
-							<div class="text-primary text-2xs">{tagLabel ?? 'tag'}: {tag}</div>
-							<NoWorkerWithTagWarning {tagLabel} {tag} />
-						</div>
-					{/if}
-					{#if jobId}
-						<QueuePosition {jobId} />
-					{/if}
-				</div>
-			{:else if duration}
-				<span
-					class={twMerge(
-						'absolute  text-primary dark:text-gray-400',
-						small ? '!text-2xs' : '!text-xs',
-						small ? 'top-0' : 'top-2',
-						noPadding ? '' : 'left-2'
-					)}>took {duration}ms</span
-				>
-			{/if}
-			{#if mem}
-				<span
-					class="absolute {small ? '!text-2xs' : '!text-xs'} text-primary dark:text-gray-400 {small
-						? 'top-0'
-						: 'top-2'}  left-36">mem peak: {(mem / 1024).toPrecision(4)}MB</span
-				>
-			{/if}
 			<pre
+				bind:this={preEl}
 				class={twMerge(
-					'whitespace-pre break-words w-full ',
+					'whitespace-pre break-words w-full flex-1 overflow-auto',
 					small ? '!text-2xs' : '!text-xs',
 					noPadding ? '' : 'p-2'
 				)}
 				>{#if content}{@const len =
-						(content?.length ?? 0) +
-						(loadedFromObjectStore?.length ?? 0)}{#if splitHtml}<span>{@html splitHtml.before}</span><button
-								onclick={getStoreLogs}
-								>Show more... &nbsp;<Tooltip>{tooltipText(prefixInfo)}</Tooltip></button
-							><span>{@html splitHtml.after}</span
-						>{:else if downloadStartUrl}<button
+						(content?.length ?? 0) + (loadedFromObjectStore?.length ?? 0)}{#if splitHtml}<span
+							>{@html splitHtml.before}</span
+						><button onclick={getStoreLogs}
+							>Show more... &nbsp;<Tooltip>{tooltipText(prefixInfo)}</Tooltip></button
+						><span>{@html splitHtml.after}</span>{:else if downloadStartUrl}<button
 							onclick={getStoreLogs}
 							>Show more... &nbsp;<Tooltip>{tooltipText(prefixInfo)}</Tooltip></button
-						><br /><span>{@html html}</span
-						>{:else if len > LOG_LIMIT}<button onclick={() => showMoreTruncate(len)}
-							>Show more..</button
-						>&nbsp;({LOG_LIMIT}/{len} chars)<br /><span>{@html html}</span
-						>{:else}<span>{@html html}</span>{/if}{:else if !isLoading}<span>{customEmptyMessage}</span>{/if}</pre
+						><br /><span>{@html html}</span>{:else if len > LOG_LIMIT}<button
+							onclick={() => showMoreTruncate(len)}>Show more..</button
+						>&nbsp;({LOG_LIMIT}/{len} chars)<br /><span>{@html html}</span>{:else}<span
+							>{@html html}</span
+						>{/if}{:else if !isLoading}<span>{customEmptyMessage}</span>{/if}</pre
 			>
 		</div>
 	</div>

package/package/components/OnBehalfOfSelector.svelte

@@ -1,13 +1,16 @@
-<script lang="ts" module>/**
+<script lang="ts" module>import { isTriggerOrScheduleKind } from 'windmill-utils-internal';
+/**
  * Check if an item needs on_behalf_of selection.
  * Shows the selector when the source item has an on_behalf_of value set.
  */
 export function needsOnBehalfOfSelection(kind, sourceValue) {
-    if (kind !== 'flow' &&
-        kind !== 'script' &&
-        kind !== 'app' &&
-        kind !== 'raw_app' &&
-        kind !== 'trigger')
+    const supported = kind === 'flow' ||
+        kind === 'script' ||
+        kind === 'app' ||
+        kind === 'raw_app' ||
+        kind === 'trigger' ||
+        isTriggerOrScheduleKind(kind);
+    if (!supported)
         return false;
     return !!sourceValue;
 }
@@ -20,7 +23,7 @@ import { userStore } from '../stores';
 import { UserService } from '../gen';
 import TextInput from './text_input/TextInput.svelte';
 let { targetWorkspace, targetValue, selected, onSelect, kind, canPreserve, customValue, isDeployment = true, folderDefault = undefined } = $props();
-const isTrigger = $derived(kind === 'trigger');
+const isTrigger = $derived(kind === 'trigger' || isTriggerOrScheduleKind(kind));
 let label = $derived(isTrigger
     ? 'Set the user this will be permissioned as:'
     : 'Set the user this will be run on behalf of:');