windmill-components 1.655.2 → 1.665.1

package/package/components/OnBehalfOfSelector.svelte.d.ts

@@ -1,18 +1,28 @@
 export type OnBehalfOfChoice = 'target' | 'me' | 'custom' | undefined;
+export interface OnBehalfOfDetails {
+    email: string;
+    permissionedAs: string;
+}
 /**
  * Check if an item needs on_behalf_of selection.
- * Shows the selector when the source item has an on_behalf_of_email set.
+ * Shows the selector when the source item has an on_behalf_of value set.
  */
-export declare function needsOnBehalfOfSelection(kind: string, sourceEmail: string | undefined): boolean;
+export declare function needsOnBehalfOfSelection(kind: string, sourceValue: string | undefined): boolean;
 interface Props {
     targetWorkspace: string;
-    targetEmail: string | undefined;
+    /** The target value: email for flows/scripts, permissioned_as (u/username) for triggers */
+    targetValue: string | undefined;
     selected: OnBehalfOfChoice;
-    onSelect: (choice: OnBehalfOfChoice, email?: string, username?: string) => void;
+    /**
+     * Called when the user picks a choice.
+     * For 'custom', `details` contains both `email` and `permissionedAs` (u/{username}).
+     * Callers pick whichever format they need.
+     */
+    onSelect: (choice: OnBehalfOfChoice, details?: OnBehalfOfDetails) => void;
     kind: string;
     canPreserve: boolean;
-    /** The email of the custom-selected user (for display) */
-    customEmail?: string | undefined;
+    /** The value of the custom-selected user (for display) */
+    customValue?: string | undefined;
     /** When false, labels say "current" instead of "target" and modal text refers to "this workspace" */
     isDeployment?: boolean;
 }

package/package/components/ResourceEditor.svelte

@@ -21,7 +21,9 @@ import GitHubAppIntegration from './GitHubAppIntegration.svelte';
 import Button from './common/button/Button.svelte';
 import { clearJsonSchemaResourceCache } from './schema/jsonSchemaResource.svelte';
 import ResourceGen from './copilot/ResourceGen.svelte';
-let { canSave = $bindable(true), resource_type = $bindable(undefined), path = $bindable(''), hidePath = false, onChange, defaultValues = undefined } = $props();
+import SyncResourceTypes from './SyncResourceTypes.svelte';
+let { canSave = $bindable(true), resource_type = $bindable(undefined), path = $bindable(''), hidePath = false, onChange, defaultValues = undefined, workspace = undefined } = $props();
+let effectiveWorkspace = $derived(workspace ?? $workspaceStore);
 let isValid = $state(true);
 let jsonError = $state('');
 let can_write = $state(true);
@@ -40,13 +42,13 @@ let newResource = $derived(!path);
 const dispatch = createEventDispatcher();
 let rawCode = $state(undefined);
 async function initEdit() {
-    resourceToEdit = await ResourceService.getResource({ workspace: $workspaceStore, path });
+    resourceToEdit = await ResourceService.getResource({ workspace: effectiveWorkspace, path });
     description = resourceToEdit.description ?? '';
     resource_type = resourceToEdit.resource_type;
     args = resourceToEdit?.value ?? {};
     loadResourceType();
     can_write =
-        resourceToEdit.workspace_id == $workspaceStore &&
+        resourceToEdit.workspace_id == effectiveWorkspace &&
             canWrite(path, resourceToEdit.extra_perms ?? {}, $userStore);
     linkedVars = Object.entries(args)
         .filter(([_, v]) => typeof v == 'string' && v == `$var:${initialPath}`)
@@ -64,12 +66,12 @@ else {
 export async function editResource() {
     if (resourceToEdit) {
         await ResourceService.updateResource({
-            workspace: $workspaceStore,
+            workspace: effectiveWorkspace,
             path: resourceToEdit.path,
             requestBody: { path, value: args, description }
         });
         if (resourceToEdit.resource_type === 'json_schema') {
-            clearJsonSchemaResourceCache(resourceToEdit.path, $workspaceStore);
+            clearJsonSchemaResourceCache(resourceToEdit.path, effectiveWorkspace);
         }
         sendUserToast(`Updated resource at ${path}`);
         dispatch('refresh', path);
@@ -80,7 +82,7 @@ export async function editResource() {
 }
 export async function createResource() {
     await ResourceService.createResource({
-        workspace: $workspaceStore,
+        workspace: effectiveWorkspace,
         requestBody: { path, value: args, description, resource_type: resource_type }
     });
     sendUserToast(`Updated resource at ${path}`);
@@ -90,7 +92,7 @@ async function loadResourceType() {
     if (resource_type) {
         try {
             const resourceType = await ResourceService.getResourceType({
-                workspace: $workspaceStore,
+                workspace: effectiveWorkspace,
                 path: resource_type
             });
             resourceTypeInfo = resourceType;
@@ -312,10 +314,13 @@ run(() => {
 					<input type="text" disabled value={rawCode} />
 				{:else}
 					{#if !viewJsonSchema}
-						<p class="italic text-secondary text-xs mb-4">
-							No corresponding resource type found in your workspace for {resource_type}. Define the
-							value in JSON directly
-						</p>
+						<div class="flex flex-col gap-2 mb-4">
+							<p class="text-red-500 dark:text-red-400 text-xs">
+								Resource type '{resource_type}' not found in your workspace
+							</p>
+							<SyncResourceTypes onSynced={loadResourceType} />
+							<p class="italic text-secondary text-xs"> Define the value in JSON directly </p>
+						</div>
 					{/if}
 
 					{#if !emptyString(jsonError)}<span class="text-red-400 text-xs mb-1 flex flex-row-reverse"

package/package/components/ResourceEditor.svelte.d.ts

@@ -9,6 +9,7 @@ interface Props {
         description: string;
     }) => void;
     defaultValues?: Record<string, any> | undefined;
+    workspace?: string | undefined;
 }
 interface $$__sveltets_2_IsomorphicComponent<Props extends Record<string, any> = any, Events extends Record<string, any> = any, Slots extends Record<string, any> = any, Exports = {}, Bindings = string> {
     new (options: import('svelte').ComponentConstructorOptions<Props>): import('svelte').SvelteComponent<Props, Events, Slots> & {

package/package/components/ResourceEditorDrawer.svelte

@@ -1,6 +1,7 @@
 <script lang="ts">import { Button, Drawer } from './common';
 import DrawerContent from './common/drawer/DrawerContent.svelte';
 import { Loader2, Save } from 'lucide-svelte';
+let { workspace = undefined, disableChatOffset = false } = $props();
 let drawer = $state();
 let canSave = $state(true);
 let resource_type = $state(undefined);
@@ -21,7 +22,7 @@ export async function initNew(resourceType, nDefaultValues) {
 let mode = $derived(!path ? 'new' : 'edit');
 </script>
 
-<Drawer bind:this={drawer} size="800px">
+<Drawer bind:this={drawer} size="800px" {disableChatOffset}>
 	<DrawerContent
 		title={mode == 'edit' ? 'Edit ' + path : 'Add a resource'}
 		on:close={drawer?.closeDrawer}
@@ -33,6 +34,7 @@ let mode = $derived(!path ? 'new' : 'edit');
 				{path}
 				{resource_type}
 				{defaultValues}
+				{workspace}
 				on:refresh
 				bind:this={resourceEditor}
 				bind:canSave

package/package/components/ResourceEditorDrawer.svelte.d.ts

@@ -1,8 +1,12 @@
+type $$ComponentProps = {
+    workspace?: string;
+    disableChatOffset?: boolean;
+};
 interface $$__sveltets_2_IsomorphicComponent<Props extends Record<string, any> = any, Events extends Record<string, any> = any, Slots extends Record<string, any> = any, Exports = {}, Bindings = string> {
     new (options: import('svelte').ComponentConstructorOptions<Props>): import('svelte').SvelteComponent<Props, Events, Slots> & {
         $$bindings?: Bindings;
     } & Exports;
-    (internal: unknown, props: {
+    (internal: unknown, props: Props & {
         $$events?: Events;
         $$slots?: Slots;
     }): Exports & {
@@ -11,7 +15,7 @@ interface $$__sveltets_2_IsomorphicComponent<Props extends Record<string, any> =
     };
     z_$$bindings?: Bindings;
 }
-declare const ResourceEditorDrawer: $$__sveltets_2_IsomorphicComponent<Record<string, never>, {
+declare const ResourceEditorDrawer: $$__sveltets_2_IsomorphicComponent<$$ComponentProps, {
     refresh: any;
 } & {
     [evt: string]: CustomEvent<any>;

package/package/components/ResourcePicker.svelte

@@ -9,7 +9,8 @@ import { sendUserToast } from '../toast';
 import Select from './select/Select.svelte';
 import ExploreAssetButton, { assetCanBeExplored } from './ExploreAssetButton.svelte';
 import DropdownV2 from './DropdownV2.svelte';
-let { initialValue = $bindable(undefined), value = $bindable(undefined), valueType = $bindable(undefined), resourceType = undefined, disabled = false, disablePortal = false, showSchemaExplorer = false, selectFirst = false, expressOAuthSetup = false, defaultValues = undefined, placeholder = undefined, selectInputClass = '', class: className = '', onClear = undefined, excludedValues = undefined, datatableAsPgResource = false } = $props();
+let { initialValue = $bindable(undefined), value = $bindable(undefined), valueType = $bindable(undefined), resourceType = undefined, disabled = false, disablePortal = false, showSchemaExplorer = false, selectFirst = false, expressOAuthSetup = false, defaultValues = undefined, placeholder = undefined, selectInputClass = '', class: className = '', onClear = undefined, excludedValues = undefined, datatableAsPgResource = false, workspace = undefined, disableChatOffset = false } = $props();
+let effectiveWorkspace = $derived(workspace ?? $workspaceStore);
 if (initialValue && value == undefined) {
     value = initialValue;
 }
@@ -55,7 +56,7 @@ async function loadResources(resourceType) {
     try {
         const resourceTypesToQuery = resourceType === 'snowflake' ? ['snowflake', 'snowflake_oauth'] : [resourceType];
         const resources = await Promise.all(resourceTypesToQuery.map((rt) => ResourceService.listResource({
-            workspace: $workspaceStore,
+            workspace: effectiveWorkspace,
             resourceType: rt
         })));
         const nc = resources
@@ -70,7 +71,7 @@ async function loadResources(resourceType) {
         if (datatableAsPgResource && resourceType === 'postgresql') {
             try {
                 const datatables = await WorkspaceService.listDataTables({
-                    workspace: $workspaceStore
+                    workspace: effectiveWorkspace
                 });
                 for (const dt of datatables) {
                     nc.push({
@@ -102,7 +103,7 @@ async function loadResources(resourceType) {
 }
 let previousResourceType = untrack(() => resourceType);
 $effect(() => {
-    $workspaceStore && resourceType;
+    effectiveWorkspace && resourceType;
     untrack(() => {
         if (previousResourceType != resourceType) {
             previousResourceType = resourceType;
@@ -113,7 +114,7 @@ $effect(() => {
 });
 $effect(() => {
     excludedValues;
-    if ($workspaceStore && resourceType && !disabled) {
+    if (effectiveWorkspace && resourceType && !disabled) {
         untrack(() => loadResources(resourceType));
     }
 });
@@ -131,9 +132,13 @@ let isDatatableSelected = $derived(value?.startsWith('datatable://') ?? false);
 	}}
 	bind:this={appConnect}
 	{expressOAuthSetup}
+	{workspace}
+	{disableChatOffset}
 />
 <ResourceEditorDrawer
 	bind:this={resourceEditor}
+	{workspace}
+	{disableChatOffset}
 	on:refresh={async (e) => {
 		await loadResources(resourceType)
 		if (e.detail) {

package/package/components/ResourcePicker.svelte.d.ts

@@ -15,6 +15,8 @@ interface Props {
     onClear?: () => void;
     excludedValues?: string[];
     datatableAsPgResource?: boolean;
+    workspace?: string | undefined;
+    disableChatOffset?: boolean;
 }
 declare const ResourcePicker: import("svelte").Component<Props, {
     askNewResource: () => Promise<void>;

package/package/components/S3FilePickerInner.svelte

@@ -453,10 +453,18 @@ $effect.pre(() => {
 						<input type="text" placeholder="Folder prefix" bind:value={filter} class="text-xl" />
 					</div>
 				{/if}
-				{#if fileListLoading === false && displayedFileKeys.length === 0}
-					<div class="p-4 text-primary text-xs text-center italic">
-						No files in the workspace S3 bucket at that prefix
-					</div>
+				{#if displayedFileKeys.length === 0}
+					{#if fileListLoading}
+						<div class="grow min-h-0 flex justify-center items-center">
+							<div class="flex text-secondary text-xs items-center">
+								<Loader2 size={12} class="animate-spin mr-1" /> Loading content
+							</div>
+						</div>
+					{:else}
+						<div class="p-4 text-primary text-xs text-center italic">
+							No files in the workspace S3 bucket at that prefix
+						</div>
+					{/if}
 				{:else}
 					<div class="grow min-h-0" bind:clientHeight={listDivHeight}>
 						<VirtualList

package/package/components/SchemaForm.svelte

@@ -13,10 +13,10 @@ import { Plus } from 'lucide-svelte';
 import ArgInput from './ArgInput.svelte';
 import { createEventDispatcher, untrack } from 'svelte';
 import { deepEqual } from 'fast-equals';
-import { dragHandleZone } from '@windmill-labs/svelte-dnd-action';
+import { dragHandleZone, SHADOW_ITEM_MARKER_PROPERTY_NAME } from '@windmill-labs/svelte-dnd-action';
 import ResizeTransitionWrapper from './common/ResizeTransitionWrapper.svelte';
 import { twMerge } from 'tailwind-merge';
-let { schema = $bindable(), hiddenArgs = [], schemaFieldTooltip = {}, args = $bindable(undefined), disabledArgs = [], disabled = false, isValid = $bindable(true), autofocus = false, defaultValues = {}, shouldHideNoInputs = false, compact = false, linkedSecret = $bindable(undefined), linkedSecretCandidates = undefined, noVariablePicker = false, flexWrap = false, noDelete = false, prettifyHeader = false, disablePortal = false, showSchemaExplorer = false, showReset = false, onlyMaskPassword = false, dndConfig = undefined, items = undefined, helperScript = undefined, lightHeader = false, diff = {}, nestedParent = undefined, shouldDispatchChanges = false, nestedClasses = '', dynamicEnums = {}, largeGap = false, css = undefined, displayType = true, appPath = undefined, className = '', lightHeaderFont = false, computeS3ForceViewerPolicies = undefined, workspace = undefined, chatInputEnabled = false, actions: actions_render = undefined } = $props();
+let { schema = $bindable(), hiddenArgs = [], schemaFieldTooltip = {}, args = $bindable(undefined), disabledArgs = [], disabled = false, isValid = $bindable(true), autofocus = false, defaultValues = {}, shouldHideNoInputs = false, compact = false, linkedSecrets = $bindable([]), linkedSecretCandidates = undefined, noVariablePicker = false, flexWrap = false, noDelete = false, prettifyHeader = false, disablePortal = false, showSchemaExplorer = false, showReset = false, onlyMaskPassword = false, dndConfig = undefined, items = undefined, helperScript = undefined, lightHeader = false, diff = {}, nestedParent = undefined, shouldDispatchChanges = false, nestedClasses = '', dynamicEnums = {}, largeGap = false, css = undefined, displayType = true, appPath = undefined, className = '', lightHeaderFont = false, computeS3ForceViewerPolicies = undefined, workspace = undefined, chatInputEnabled = false, actions: actions_render = undefined } = $props();
 const dispatch = createEventDispatcher();
 let inputCheck = $state({});
 export function setDefaults() {
@@ -177,7 +177,9 @@ $effect.pre(() => {
 				class={twMerge(
 					typeof diff[argName] === 'object' &&
 						diff[argName].diff !== 'same' &&
-						'bg-red-300 dark:bg-red-800 rounded-md'
+						'bg-red-300 dark:bg-red-800 rounded-md',
+					item[SHADOW_ITEM_MARKER_PROPERTY_NAME] &&
+						'!visible border-2 border-dashed border-blue-300 dark:border-blue-600 bg-blue-50 dark:bg-blue-900/20 rounded-md [&>*]:invisible'
 				)}
 				innerClass="w-full"
 			>
@@ -215,7 +217,7 @@ $effect.pre(() => {
 								{variableEditor}
 								{itemPicker}
 								{pickForField}
-								password={linkedSecret == argName}
+								password={linkedSecrets.includes(argName)}
 								extra={formerProperty}
 								{showSchemaExplorer}
 								simpleTooltip={schemaFieldTooltip[argName]}
@@ -280,22 +282,24 @@ $effect.pre(() => {
 									customErrorMessage={prop?.customErrorMessage}
 									bind:properties={
 										() => prop?.properties,
-										(v) => { if (prop) prop.properties = v }
+										(v) => {
+											if (prop) prop.properties = v
+										}
 									}
 									bind:order={
 										() => prop?.order,
-										(v) => { if (prop) prop.order = v }
+										(v) => {
+											if (prop) prop.order = v
+										}
 									}
 									nestedRequired={prop?.required}
 									itemsType={prop?.items}
-									disabled={disabledArgs.includes(argName) ||
-										disabled ||
-										prop?.disabled}
+									disabled={disabledArgs.includes(argName) || disabled || prop?.disabled}
 									{compact}
 									{variableEditor}
 									{itemPicker}
 									bind:pickForField
-									password={linkedSecret == argName}
+									password={linkedSecrets.includes(argName)}
 									extra={prop}
 									{showSchemaExplorer}
 									simpleTooltip={schemaFieldTooltip[argName]}
@@ -322,12 +326,14 @@ $effect.pre(() => {
 										{#if linkedSecretCandidates?.includes(argName)}
 											<div class="relative">
 												<ToggleButtonGroup
-													selected={linkedSecret == argName ? 'secret' : 'inlined'}
+													selected={linkedSecrets.includes(argName) ? 'secret' : 'inlined'}
 													on:selected={(e) => {
 														if (e.detail === 'secret') {
-															linkedSecret = argName
-														} else if (linkedSecret == argName) {
-															linkedSecret = undefined
+															if (!linkedSecrets.includes(argName)) {
+																linkedSecrets = [...linkedSecrets, argName]
+															}
+														} else {
+															linkedSecrets = linkedSecrets.filter((s) => s !== argName)
 														}
 													}}
 												>

package/package/components/SchemaForm.svelte.d.ts

@@ -15,7 +15,7 @@ interface Props {
     defaultValues?: Record<string, any>;
     shouldHideNoInputs?: boolean;
     compact?: boolean;
-    linkedSecret?: string | undefined;
+    linkedSecrets?: string[];
     linkedSecretCandidates?: string[] | undefined;
     noVariablePicker?: boolean;
     flexWrap?: boolean;
@@ -85,6 +85,6 @@ declare const SchemaForm: $$__sveltets_2_IsomorphicComponent<Props, {
     [evt: string]: CustomEvent<any>;
 }, {}, {
     setDefaults: () => void;
-}, "args" | "schema" | "linkedSecret" | "isValid">;
+}, "args" | "schema" | "linkedSecrets" | "isValid">;
 type SchemaForm = InstanceType<typeof SchemaForm>;
 export default SchemaForm;