windmill-components 1.623.2 → 1.642.0

package/package/components/FlowStatusViewerInner.svelte.d.ts

@@ -18,7 +18,6 @@ interface Props {
     } | undefined;
     innerModule?: FlowModuleValue | undefined;
     render?: boolean;
-    isOwner?: boolean;
     selectedNode?: string | undefined;
     globalModuleStates: Record<string, GraphModuleState>[];
     globalDurationStatuses?: Record<string, DurationStatus>[];
@@ -26,7 +25,6 @@ interface Props {
     isSubflow?: boolean;
     reducedPolling?: boolean;
     wideResults?: boolean;
-    hideFlowResult?: boolean;
     topModuleStates?: Record<string, GraphModuleState>;
     workspace?: string | undefined;
     prefix?: string | undefined;
@@ -67,6 +65,8 @@ interface Props {
         isToolCallToBeLoaded: (storeKey: string) => boolean;
         addToolCallToLoad: (storeKey: string) => void;
     };
+    showLogsWithResult?: boolean;
+    showJobDetailHeader?: boolean;
 }
 export type FlowModuleForTimeline = {
     id: string;

package/package/components/FlowStatusWaitingForEvents.svelte

@@ -107,17 +107,15 @@ $effect(() => {
 });
 </script>
 
-<div class="w-full h-full mt-2 text-xs text-primary">
-	{#if !light}
-		<p>Waiting to be resumed</p>
-	{/if}
+<div class="w-full h-full text-xs text-primary">
 	{#if description != undefined}
 		<DisplayResult {workspaceId} noControls result={description} language={job?.language} />
+		<div class="mt-2"></div>
 	{/if}
 	<div>
 		{#if isOwner || resumeUrl}
-			<div class={twMerge('flex gap-2 mt-2', light ? 'flex-col' : 'flex-row ')}>
-				{#if cancelUrl && !hide_cancel}
+			<div class={twMerge('flex gap-2', light ? 'flex-col' : 'flex-row ')}>
+				{#if !hide_cancel}
 					<div>
 						<Button
 							title="Cancel the step"
@@ -125,13 +123,15 @@ $effect(() => {
 							iconOnly
 							startIcon={{ icon: X }}
 							variant="default"
+							disabled={!cancelUrl}
 							destructive
+							unifiedSize="md"
 							on:click={() => continu(false)}
 						/>
 					</div>
 				{/if}
 				<div>
-					<Button variant="accent" on:click={() => continu(true)} {loading}>
+					<Button variant="accent" onClick={() => continu(true)} {loading} unifiedSize="md">
 						Resume
 						<Tooltip class="text-white">
 							Since you are an owner of this flow, you can send resume events without necessarily
@@ -149,10 +149,11 @@ $effect(() => {
 					>
 						<SchemaForm onlyMaskPassword bind:args={default_payload} {defaultValues} {schema} />
 					</div>
+					<Tooltip>
+						The payload is optional, it is passed to the following step through the `resume`
+						variable
+					</Tooltip>
 				{/if}
-				<Tooltip>
-					The payload is optional, it is passed to the following step through the `resume` variable
-				</Tooltip>
 			</div>
 		{:else}
 			You cannot resume the flow yourself without receiving the resume secret since you are not an

package/package/components/FolderPicker.svelte

@@ -1,98 +1,228 @@
 <script lang="ts">import { FolderService } from '../gen';
 import { workspaceStore, userStore } from '../stores';
-import { Plus, Eye } from 'lucide-svelte';
+import { Pen, PlusIcon } from 'lucide-svelte';
 import { Button, Drawer, DrawerContent } from './common';
 import FolderEditor from './FolderEditor.svelte';
+import Select from './select/Select.svelte';
+import TextInput from './text_input/TextInput.svelte';
+import Label from './Label.svelte';
+import InputError from './InputError.svelte';
+import { tick } from 'svelte';
+import { sendUserToast } from '../toast';
+const VALID_FOLDER_NAME = /^[a-zA-Z_0-9]+$/;
 let folders = $state([]);
+let filterText = $state('');
+let selectOpen = $state(false);
+let nameInput = $state();
 let newFolder = $state(null);
 let viewFolder = $state(null);
 let newFolderName = $state('');
 let folderCreated = $state(undefined);
-let { folderName = $bindable(''), initialPath = $bindable(undefined), disabled = $bindable(undefined), disableEditing = $bindable(undefined), } = $props();
+let creating = $state(false);
+let loadingFolders = $state(true);
+let editingFolder = $state('');
+let { folderName = $bindable(''), initialPath = $bindable(undefined), disabled = $bindable(undefined), disableEditing = $bindable(undefined), size = 'md', drawerOffset = 0 } = $props();
+let hovering = $state(false);
 async function loadFolders() {
-    let initialFolders = [];
-    let initialFolder = '';
-    if (initialPath?.split('/')?.[0] == 'f') {
-        initialFolder = initialPath?.split('/')?.[1];
-        initialFolders.push({ name: initialFolder, write: true });
+    loadingFolders = true;
+    try {
+        let initialFolders = [];
+        let initialFolder = '';
+        if (initialPath?.split('/')?.[0] == 'f') {
+            initialFolder = initialPath?.split('/')?.[1];
+            initialFolders.push({ name: initialFolder, write: true });
+        }
+        const excludedFolders = [initialFolder, 'app_groups', 'app_custom', 'app_themes'];
+        folders = initialFolders.concat((await FolderService.listFolderNames({
+            workspace: $workspaceStore
+        }))
+            .filter((x) => !excludedFolders.includes(x))
+            .map((x) => ({
+            name: x,
+            write: $userStore?.folders?.includes(x) == true ||
+                ($userStore?.is_admin ?? false) ||
+                ($userStore?.is_super_admin ?? false)
+        })));
+    }
+    catch (e) {
+        sendUserToast(`Could not load folders: ${e}`, true);
+    }
+    finally {
+        loadingFolders = false;
     }
-    const excludedFolders = [initialFolder, 'app_groups', 'app_custom', 'app_themes'];
-    folders = initialFolders.concat((await FolderService.listFolderNames({
-        workspace: $workspaceStore
-    }))
-        .filter((x) => !excludedFolders.includes(x))
-        .map((x) => ({
-        name: x,
-        write: $userStore?.folders?.includes(x) == true ||
-            ($userStore?.is_admin ?? false) ||
-            ($userStore?.is_super_admin ?? false)
-    })));
+}
+async function openCreateFolder() {
+    newFolderName = filterText;
+    folderCreated = undefined;
+    newFolder?.openDrawer();
+    await tick();
+    nameInput?.focus();
 }
 async function addFolder() {
-    await FolderService.createFolder({
-        workspace: $workspaceStore ?? '',
-        requestBody: { name: newFolderName }
-    });
-    folderCreated = newFolderName;
-    $userStore?.folders?.push(newFolderName);
-    folderName = newFolderName;
-    loadFolders();
+    if (nameError || !newFolderName || creating)
+        return;
+    creating = true;
+    try {
+        await FolderService.createFolder({
+            workspace: $workspaceStore ?? '',
+            requestBody: { name: newFolderName }
+        });
+        folderCreated = newFolderName;
+        await loadFolders();
+        folderName = newFolderName;
+        // Writing $userStore.folders = [...] would call userStore.set(),
+        // which re-triggers Path.svelte's $effect.pre and calls initPath()/reset(),
+        // switching the owner toggle from "Folder" back to "User".
+        if ($userStore) {
+            if (!$userStore.folders)
+                $userStore.folders = [];
+            $userStore.folders.push(newFolderName);
+        }
+    }
+    catch (e) {
+        sendUserToast(`Could not create folder: ${e}`, true);
+    }
+    finally {
+        creating = false;
+    }
+}
+let selectItems = $derived(folders.map((f) => ({
+    value: f.name,
+    label: f.name + (f.write ? '' : ' (read-only)'),
+    disabled: !f.write
+})));
+let nameError = $derived(!newFolderName
+    ? ''
+    : !VALID_FOLDER_NAME.test(newFolderName)
+        ? 'Folder name can only contain alphanumeric characters and underscores'
+        : folders.some((f) => f.name === newFolderName)
+            ? 'A folder with this name already exists'
+            : '');
+let noMatchingItems = $derived(filterText &&
+    !selectItems.some((item) => item.label.toLowerCase().includes(filterText.toLowerCase())));
+function handleSelectKeydown(e) {
+    if (e.key === 'Enter' && selectOpen && noMatchingItems) {
+        e.preventDefault();
+        selectOpen = false;
+        openCreateFolder();
+    }
 }
 loadFolders();
 </script>
 
-<Drawer bind:this={newFolder} name="newFolder">
+<Drawer bind:this={newFolder} name="newFolder" offset={drawerOffset}>
 	<DrawerContent
-		title="New Folder"
+		title={folderCreated ? `Folder ${folderCreated}` : 'Create folder'}
 		on:close={() => {
 			newFolder?.closeDrawer()
 			folderCreated = undefined
 		}}
 	>
-		{#if !folderCreated}
-			<div class="flex flex-col gap-2">
-				<input placeholder="New folder name" bind:value={newFolderName} />
-				<Button size="md" startIcon={{ icon: Plus }} disabled={!newFolderName} on:click={addFolder}>
-					New&nbsp;folder
+		{#if folderCreated}
+			<FolderEditor name={folderCreated} />
+		{:else}
+			<div class="flex flex-col gap-4">
+				<Label label="Folder name">
+					<TextInput
+						bind:this={nameInput}
+						bind:value={newFolderName}
+						error={!!nameError}
+						inputProps={{
+							placeholder: 'folder_name',
+							onkeydown: (e: KeyboardEvent) => {
+								if (e.key === 'Enter' && newFolderName) {
+									e.preventDefault()
+									addFolder()
+								}
+							}
+						}}
+					/>
+					<InputError error={nameError} />
+				</Label>
+				<Button
+					variant="accent"
+					disabled={!newFolderName || !!nameError || creating}
+					loading={creating}
+					onClick={addFolder}
+				>
+					Create
 				</Button>
 			</div>
-		{:else}
-			<FolderEditor name={folderCreated} />
 		{/if}
 	</DrawerContent>
 </Drawer>
 
-<Drawer bind:this={viewFolder}>
-	<DrawerContent title="Folder {folderName}" on:close={viewFolder.closeDrawer}>
-		<FolderEditor name={folderName ?? ''} />
+<Drawer bind:this={viewFolder} offset={drawerOffset}>
+	<DrawerContent title="Folder {editingFolder}" on:close={viewFolder.closeDrawer}>
+		<FolderEditor name={editingFolder} />
 	</DrawerContent>
 </Drawer>
 
-<div class="flex flex-row items-center gap-1 w-full">
-	<select class="grow w-full" disabled={disabled || disableEditing} bind:value={folderName}>
-		{#if folders?.length == 0}
-			<option disabled>No folders</option>
-		{/if}
-		{#each folders as { name, write }}
-			<option disabled={!write}>{name}{write ? '' : ' (read-only)'}</option>
-		{/each}
-	</select>
-	<Button
-		title="View folder"
-		variant="default"
-		unifiedSize="md"
-		disabled={!folderName || folderName == ''}
-		on:click={viewFolder.openDrawer}
-		iconOnly
-		startIcon={{ icon: Eye }}
-	/>
-	<Button
-		title="New folder"
-		variant="default"
-		unifiedSize="md"
-		{disabled}
-		on:click={newFolder.openDrawer}
-		iconOnly
-		startIcon={{ icon: Plus }}
-	/>
+<!-- svelte-ignore a11y_no_static_element_interactions -->
+<!-- svelte-ignore a11y_no_noninteractive_element_interactions -->
+<div
+	class="flex flex-row w-full items-center relative"
+	role="group"
+	onkeydown={handleSelectKeydown}
+	onmouseenter={() => (hovering = true)}
+	onmouseleave={() => (hovering = false)}
+>
+	<Select
+		bind:value={folderName}
+		bind:filterText
+		bind:open={selectOpen}
+		items={selectItems}
+		disabled={disabled || disableEditing}
+		loading={loadingFolders}
+		{size}
+		placeholder="Select folder"
+		class="grow min-w-0"
+	>
+		{#snippet endSnippet({ item, close })}
+			<Button
+				disabled={disabled || disableEditing}
+				variant="subtle"
+				unifiedSize="xs"
+				wrapperClasses="-mr-2 pl-1 -my-2"
+				btnClasses="hover:bg-surface-tertiary"
+				onClick={() => {
+					editingFolder = item.value ?? ''
+					viewFolder?.openDrawer()
+					close()
+				}}
+				startIcon={{ icon: Pen }}
+				iconOnly
+			/>
+		{/snippet}
+		{#snippet bottomSnippet({ close })}
+			<button
+				class="sticky py-2 px-4 w-full text-left text-xs font-medium hover:bg-surface-hover flex items-center justify-center gap-2 border-t border-border-light {noMatchingItems
+					? 'bg-surface-hover'
+					: ''}"
+				onclick={() => {
+					close()
+					openCreateFolder()
+				}}
+			>
+				<PlusIcon class="inline" size={16} />
+				Create folder
+			</button>
+		{/snippet}
+	</Select>
+	{#if folderName && hovering && !loadingFolders && !disabled && !disableEditing}
+		<div class="absolute right-2 z-20">
+			<Button
+				variant="subtle"
+				unifiedSize="xs"
+				wrapperClasses="pl-1"
+				btnClasses="hover:bg-surface-tertiary"
+				onClick={() => {
+					editingFolder = folderName
+					viewFolder?.openDrawer()
+				}}
+				startIcon={{ icon: Pen }}
+				iconOnly
+			/>
+		</div>
+	{/if}
 </div>

package/package/components/FolderPicker.svelte.d.ts

@@ -3,6 +3,8 @@ type Props = {
     initialPath?: string;
     disabled?: boolean;
     disableEditing?: boolean;
+    size?: 'sm' | 'md';
+    drawerOffset?: number;
 };
 declare const FolderPicker: import("svelte").Component<Props, {}, "disabled" | "folderName" | "initialPath" | "disableEditing">;
 type FolderPicker = ReturnType<typeof FolderPicker>;

package/package/components/HistoricInputs.svelte

@@ -73,14 +73,13 @@ let jobsLoader = useJobsLoader(() => ({
     filters: {
         show_skipped: false,
         path: runnableId,
-        success: 'running',
-        arg: searchArgs ? JSON.stringify(searchArgs) : '',
-        per_page: 5
+        status: 'running',
+        arg: searchArgs ? JSON.stringify(searchArgs) : ''
     },
+    perPage: 5,
     jobKinds: getJobKinds(runnableType),
     syncQueuedRunsCount: false,
     refreshRate: 10000,
-    computeMinAndMax: undefined,
     currentWorkspace: $workspaceStore ?? '',
     skip: !runnableId
 }));

package/package/components/IconedResourceType.svelte

@@ -1,5 +1,5 @@
 <script>
-	import { FileText } from 'lucide-svelte'
+	import { FileText, FolderOpen } from 'lucide-svelte'
 	import { APP_TO_ICON_COMPONENT } from './icons'
 	/**
 	 * @typedef {Object} Props
@@ -11,6 +11,7 @@
 	 * @property {boolean} [center]
 	 * @property {boolean} [isSelected]
 	 * @property {any} [formatExtension]
+	 * @property {boolean} [isFileset]
 	 */
 
 	/** @type {Props} */
@@ -22,7 +23,8 @@
 		width = '24px',
 		center = false,
 		isSelected = false,
-		formatExtension = undefined
+		formatExtension = undefined,
+		isFileset = false
 	} = $props()
 
 	let iconComponent = $derived(
@@ -45,6 +47,10 @@
 		<span class={isSelected ? 'text-secondary' : 'text-secondary'}>
 			<SvelteComponent {height} {width} size={widthInPixels} />
 		</span>
+	{:else if isFileset}
+		<span class={isSelected ? 'text-secondary' : 'text-secondary grayscale'}>
+			<FolderOpen {height} {width} />
+		</span>
 	{:else if formatExtension}
 		<span class={isSelected ? 'text-secondary' : 'text-secondary grayscale'}>
 			<FileText {height} {width} />

package/package/components/IconedResourceType.svelte.d.ts

@@ -12,6 +12,7 @@ declare const IconedResourceType: import("svelte").Component<{
     center?: boolean | undefined;
     isSelected?: boolean | undefined;
     formatExtension?: any;
+    isFileset?: boolean | undefined;
 }, {}, "">;
 type Props = {
     name: any;
@@ -22,4 +23,5 @@ type Props = {
     center?: boolean | undefined;
     isSelected?: boolean | undefined;
     formatExtension?: any;
+    isFileset?: boolean | undefined;
 };

package/package/components/InputError.svelte

@@ -0,0 +1,9 @@
+<script lang="ts">import { slide } from 'svelte/transition';
+let { error } = $props();
+</script>
+
+{#if error}
+	<div transition:slide={{ duration: 150 }} class="text-red-600 dark:text-red-400 text-xs mt-1">
+		{error}
+	</div>
+{/if}

package/package/components/InputError.svelte.d.ts

@@ -0,0 +1,6 @@
+interface Props {
+    error: string;
+}
+declare const InputError: import("svelte").Component<Props, {}, "">;
+type InputError = ReturnType<typeof InputError>;
+export default InputError;