windmill-components 1.389.3 → 1.394.3

package/package/components/instanceSettings.js

@@ -1,7 +1,7 @@
 export const settings = {
     Core: [
         {
-            label: 'Base Url',
+            label: 'Base url',
             description: 'Public base url of the instance',
             key: 'base_url',
             fieldType: 'text',
@@ -24,7 +24,7 @@ export const settings = {
             placeholder: 'mail.windmill.com'
         },
         {
-            label: 'Request Size Limit In MB',
+            label: 'Request size limit in MB',
             description: 'Maximum size of HTTP requests in MB.',
             cloudonly: true,
             key: 'request_size_limit_mb',
@@ -41,7 +41,7 @@ export const settings = {
             cloudonly: false
         },
         {
-            label: 'Max Timeout for sync endpoints',
+            label: 'Max timeout for sync endpoints',
             key: 'timeout_wait_result',
             cloudonly: true,
             fieldType: 'seconds',
@@ -49,8 +49,8 @@ export const settings = {
             storage: 'config'
         },
         {
-            label: 'License Key',
-            description: 'License Key required to use the EE (switch image for windmill-ee)',
+            label: 'License key',
+            description: 'License key required to use the EE (switch image for windmill-ee)',
             key: 'license_key',
             fieldType: 'license_key',
             placeholder: 'only needed to prepare upgrade to EE',
@@ -65,7 +65,7 @@ export const settings = {
             ee_only: 'This is only relevant for EE'
         },
         {
-            label: 'Retention Period in secs',
+            label: 'Retention period in secs',
             key: 'retention_period_secs',
             description: 'How long to keep the jobs data in the database (max 30 days on CE)',
             fieldType: 'seconds',
@@ -76,14 +76,14 @@ export const settings = {
         },
         {
             label: 'Expose metrics',
-            description: 'Expose prometheus metrics for workers and servers on port 8001 at /metrics',
+            description: 'Expose Prometheus metrics for workers and servers on port 8001 at /metrics',
             key: 'expose_metrics',
             fieldType: 'boolean',
             storage: 'setting',
             ee_only: ''
         },
         {
-            label: 'S3/Azure for Python/Go Cache & Large Logs',
+            label: 'S3/Azure for Python/Go cache & large logs',
             description: 'Bucket to store large logs and global cache for Python and Go.',
             key: 'object_store_cache_config',
             fieldType: 'object_store_config',
@@ -91,8 +91,8 @@ export const settings = {
             ee_only: ''
         },
         {
-            label: 'Critical Alert Channels',
-            description: 'Channels to send critical alerts to. SMTP must be configured for the email channel.',
+            label: 'Critical alert channels',
+            description: 'Channels to send critical alerts to. SMTP must be configured for the email channel. A Slack workspace must be connected to the instance for the Slack channel.',
             key: 'critical_error_channels',
             fieldType: 'critical_error_channels',
             storage: 'setting',
@@ -107,8 +107,8 @@ export const settings = {
             ee_only: ''
         },
         {
-            label: 'Private hub base url',
-            description: 'Base url of your private hub instance, without trailing slash',
+            label: 'Private Hub base url',
+            description: 'Base url of your private Hub instance, without trailing slash',
             placeholder: 'https://hub.company.com',
             key: 'hub_base_url',
             fieldType: 'text',
@@ -197,9 +197,18 @@ export const settings = {
             storage: 'config'
         }
     ],
+    Slack: [
+        {
+            label: 'Slack',
+            key: 'slack',
+            fieldType: 'slack_connect',
+            storage: 'setting',
+            ee_only: ''
+        }
+    ],
     'SCIM/SAML': [
         {
-            label: 'SCIM Token',
+            label: 'SCIM token',
             description: 'Token used to authenticate requests from the IdP',
             key: 'scim_token',
             fieldType: 'text',
@@ -219,14 +228,14 @@ export const settings = {
     ],
     Debug: [
         {
-            label: 'Keep Job Directories',
+            label: 'Keep job directories',
             key: 'keep_job_dir',
             fieldType: 'boolean',
             tooltip: 'Keep Job directories after execution at /tmp/windmill/<worker>/<job_id>',
             storage: 'setting'
         },
         {
-            label: 'Expose Debug Metrics',
+            label: 'Expose debug metrics',
             key: 'expose_debug_metrics',
             fieldType: 'boolean',
             tooltip: 'Expose additional metrics (require metrics to be enabled)',

package/package/components/runs/JobLoader.svelte

@@ -105,7 +105,19 @@ function computeJobKinds(jobKindsCat) {
     }
 }
 let loadingFetch = false;
-async function fetchJobs(startedBefore, startedAfter, startedAfterCompletedJobs) {
+export async function loadExtraJobs() {
+    if (jobs && jobs.length > 0) {
+        const lastJob = jobs[jobs.length - 1];
+        // const minCreated = lastJob?.created_at
+        const minCreated = new Date(new Date(lastJob.created_at).getTime() - 1).toISOString();
+        let olderJobs = await fetchJobs(undefined, minTs, undefined, minCreated);
+        jobs = jobs.concat(olderJobs);
+        computeCompletedJobs();
+        return olderJobs?.length < 1000;
+    }
+    return false;
+}
+async function fetchJobs(startedBefore, startedAfter, startedAfterCompletedJobs, createdBefore) {
     loadingFetch = true;
     try {
         let scriptPathStart = folder === null || folder === '' ? undefined : `f/${folder}/`;
@@ -117,6 +129,7 @@ async function fetchJobs(startedBefore, startedAfter, startedAfterCompletedJobs)
             createdOrStartedAfterCompletedJobs: startedAfterCompletedJobs,
             schedulePath,
             scriptPathExact,
+            createdBefore,
             createdBy: user === null || user === '' ? undefined : user,
             scriptPathStart: scriptPathStart,
             jobKinds,
@@ -128,9 +141,7 @@ async function fetchJobs(startedBefore, startedAfter, startedAfterCompletedJobs)
                     : undefined,
             isSkipped: isSkipped ? undefined : false,
             // isFlowStep: jobKindsCat != 'all' ? false : undefined,
-            hasNullParent: scriptPathExact != undefined || scriptPathStart != undefined || jobKindsCat != 'all'
-                ? true
-                : undefined,
+            hasNullParent: jobKindsCat != 'all' ? true : undefined,
             label: label === null || label === '' ? undefined : label,
             tag: tag === null || tag === '' ? undefined : tag,
             isNotSchedule: showSchedules == false ? true : undefined,
@@ -229,7 +240,7 @@ async function loadJobsIntern(shouldGetCount) {
         // lookback won't be needed anymore (just filter ended_at > minTs instead
         const extendedMinTs = subtractDaysFromDateString(minTs, lookback);
         if (concurrencyKey == null || concurrencyKey === '') {
-            let newJobs = await fetchJobs(maxTs, undefined, extendedMinTs);
+            let newJobs = await fetchJobs(maxTs, undefined, extendedMinTs, undefined);
             extendedJobs = { jobs: newJobs, obscured_jobs: [] };
             // Filter on minTs here and not in the backend
             // to get enough data for the concurrency graph
@@ -328,7 +339,7 @@ async function syncer() {
                 loading = true;
                 let newJobs;
                 if (concurrencyKey == null || concurrencyKey === '') {
-                    newJobs = await fetchJobs(maxTs, minTs ?? ts, undefined);
+                    newJobs = await fetchJobs(maxTs, minTs ?? ts, undefined, undefined);
                 }
                 else {
                     // Obscured jobs have no ids, so we have to do the full request

package/package/components/runs/JobLoader.svelte.d.ts

@@ -39,6 +39,7 @@ declare const __propDef: {
         } | undefined) | undefined;
         lookback?: number | undefined;
         perPage?: number | undefined;
+        loadExtraJobs?: (() => Promise<boolean>) | undefined;
         loadJobs?: ((nMinTs: string | undefined, nMaxTs: string | undefined, reset: boolean, shouldGetCount?: boolean) => Promise<void>) | undefined;
     };
     events: {
@@ -50,6 +51,7 @@ export type JobLoaderProps = typeof __propDef.props;
 export type JobLoaderEvents = typeof __propDef.events;
 export type JobLoaderSlots = typeof __propDef.slots;
 export default class JobLoader extends SvelteComponent<JobLoaderProps, JobLoaderEvents, JobLoaderSlots> {
+    get loadExtraJobs(): () => Promise<boolean>;
     get loadJobs(): (nMinTs: string | undefined, nMaxTs: string | undefined, reset: boolean, shouldGetCount?: boolean | undefined) => Promise<void>;
 }
 export {};

package/package/components/runs/RunRow.svelte

@@ -193,14 +193,14 @@ function isJobCancelable(j) {
 		{/if}
 	</div>
 	{#if containsLabel}
-		<div class="w-3/12 flex justify-start">
+		<div class="w-3/12 flex justify-start px-0.5">
 			{#if job && job?.['labels']}
 				<div class="flex flex-row items-center gap-1 overflow-x-auto">
 					{#if Array.isArray(job?.['labels'])}
 						{#each job?.['labels'] as label}
 							<Button
 								variant="border"
-								size="xs2"
+								size="xs3"
 								btnClasses={twMerge(
 									activeLabel == label ? 'bg-blue-50 dark:bg-blue-900/50' : '',
 									'!text-2xs !font-normal truncate max-w-28'
@@ -209,9 +209,9 @@ function isJobCancelable(j) {
 								on:click={() => {
 									dispatch('filterByLabel', label)
 								}}
+								endIcon={{ icon: ListFilter }}
 							>
 								{label}
-								<ListFilter size={10} />
 							</Button>
 						{/each}
 					{/if}
@@ -229,7 +229,7 @@ function isJobCancelable(j) {
 					btnClasses="font-normal"
 					on:click={() => scheduleEditor?.openEdit(job.schedule_path ?? '', job.job_kind == 'flow')}
 				>
-					<div class="truncate text-ellipsis text-left">
+					<div class="truncate text-ellipsis text-left" title={job.schedule_path}>
 						{truncateRev(job.schedule_path, 20)}
 					</div>
 				</Button>
@@ -245,15 +245,15 @@ function isJobCancelable(j) {
 			</div>
 		{:else}
 			<div class="flex flex-row gap-1 items-center">
-				<div class="text-xs">
-					{job.created_by}
+				<div class="text-xs truncate text-ellipsis text-left" title={job.created_by}>
+					{truncateRev(job.created_by ?? '', 20)}
 				</div>
 				{#if !isExternal}
 					<Button
 						size="xs2"
 						color="light"
 						on:click={() => {
-							dispatch('filterByUser', job.created_by)
+							dispatch('filterByUser', job.created_by ?? '')
 						}}
 					>
 						<ListFilter size={10} />

package/package/components/runs/RunsFilter.svelte

@@ -249,6 +249,7 @@ let tagTimeout = undefined;
 							></span
 						>
 
+						<!-- svelte-ignore a11y-autofocus -->
 						<input
 							autofocus
 							type="text"
@@ -290,6 +291,7 @@ let tagTimeout = undefined;
 							</Tooltip></span
 						>
 
+						<!-- svelte-ignore a11y-autofocus -->
 						<input
 							autofocus
 							type="text"
@@ -323,6 +325,7 @@ let tagTimeout = undefined;
 						{/if}
 						<span class="text-xs absolute -top-4"> Tag </span>
 
+						<!-- svelte-ignore a11y-autofocus -->
 						<input
 							autofocus
 							type="text"
@@ -356,6 +359,7 @@ let tagTimeout = undefined;
 						{/if}
 						<span class="text-xs absolute -top-4"> Schedule Path </span>
 
+						<!-- svelte-ignore a11y-autofocus -->
 						<input
 							autofocus
 							type="text"
@@ -470,7 +474,7 @@ let tagTimeout = undefined;
 				<CloseButton on:close={() => close(null)} />
 			</svelte:fragment>
 
-			<div class="w-80 flex flex-col gap-4">
+			<div class="w-102 flex flex-col gap-4">
 				{#if mobile}
 					<Label label="Filter by">
 						<ToggleButtonGroup
@@ -603,6 +607,7 @@ let tagTimeout = undefined;
 										</button>
 									{/if}
 
+									<!-- svelte-ignore a11y-autofocus -->
 									<input
 										autofocus
 										type="text"
@@ -637,6 +642,7 @@ let tagTimeout = undefined;
 										</button>
 									{/if}
 
+									<!-- svelte-ignore a11y-autofocus -->
 									<input
 										autofocus
 										type="text"
@@ -671,6 +677,7 @@ let tagTimeout = undefined;
 										</button>
 									{/if}
 
+									<!-- svelte-ignore a11y-autofocus -->
 									<input
 										autofocus
 										type="text"

package/package/components/runs/RunsTable.svelte

@@ -16,6 +16,7 @@ export let selectedIds = [];
 export let selectedWorkspace = undefined;
 export let activeLabel = null;
 // const loadMoreQuantity: number = 100
+export let lastFetchWentToEnd = false;
 function getTime(job) {
     return job['started_at'] ?? job['scheduled_for'] ?? job['created_at'];
 }
@@ -123,9 +124,12 @@ function selectAll() {
 let cancelableJobCount = 0;
 $: isSelectingJobsToCancel && (allSelected = selectedIds.length === cancelableJobCount);
 $: isSelectingJobsToCancel && (cancelableJobCount = jobs?.filter(isJobCancelable).length ?? 0);
-function jobCountString(jobCount) {
+function jobCountString(jobCount, lastFetchWentToEnd) {
+    if (jobCount === undefined) {
+        return '';
+    }
     const jc = jobCount;
-    const isTruncated = jc >= 1000;
+    const isTruncated = jc >= 1000 && !lastFetchWentToEnd;
     return `${jc}${isTruncated ? '+' : ''} job${jc != 1 ? 's' : ''}`;
 }
 function computeHeight() {
@@ -166,14 +170,14 @@ const dispatch = createEventDispatcher();
 			{#if showExternalJobs && externalJobs.length > 0}
 				<div class="w-1/12 text-2xs">
 					<div class="flex flex-row">
-						{jobs && jobCountString(jobs.length + externalJobs.length)}<Tooltip
-							>{externalJobs.length} jobs obscured</Tooltip
-						>
+						{jobs
+							? jobCountString(jobs.length + externalJobs.length, lastFetchWentToEnd)
+							: ''}<Tooltip>{externalJobs.length} jobs obscured</Tooltip>
 					</div>
 				</div>
 			{:else if $workspaceStore !== 'admins' && omittedObscuredJobs}
 				<div class="w-1/12 text-2xs flex flex-row">
-					{jobs && jobCountString(jobs.length)}
+					{jobs ? jobCountString(jobs.length, lastFetchWentToEnd) : ''}
 					<Popover>
 						<AlertTriangle size={16} class="ml-0.5 text-yellow-500" />
 						<svelte:fragment slot="text">
@@ -183,9 +187,11 @@ const dispatch = createEventDispatcher();
 					</Popover>
 				</div>
 			{:else}
-				<div class="w-1/12 text-2xs">{jobs && jobCountString(jobs.length)}</div>
+				<div class="w-1/12 text-2xs"
+					>{jobs ? jobCountString(jobs.length, lastFetchWentToEnd) : ''}</div
+				>
 			{/if}
-			<div class="w-4/12 text-xs font-semibold">Timestamp</div>
+			<div class="w-4/12 text-xs font-semibold" />
 			<div class="w-4/12 text-xs font-semibold">Path</div>
 			{#if containsLabel}
 				<div class="w-3/12 text-xs font-semibold">Label</div>
@@ -262,6 +268,22 @@ const dispatch = createEventDispatcher();
 					</div>
 				{/if}
 			</div>
+			<div slot="footer"
+				>{#if !lastFetchWentToEnd && jobs && jobs.length >= 1000}
+					<button
+						class="text-xs text-blue-600 text-center w-full pb-2"
+						on:click={() => {
+							dispatch('loadExtra')
+						}}>Load next 1000 jobs</button
+					>
+				{/if}</div
+			>
 		</VirtualList>
 	{/if}
 </div>
+
+<style>
+	:global(.virtual-list-wrapper:hover::-webkit-scrollbar) {
+		width: 8px !important;
+		height: 8px !important;
+	}</style>

package/package/components/runs/RunsTable.svelte.d.ts

@@ -10,6 +10,7 @@ declare const __propDef: {
         selectedIds?: string[] | undefined;
         selectedWorkspace?: string | undefined;
         activeLabel?: string | null | undefined;
+        lastFetchWentToEnd?: boolean | undefined;
     };
     events: {
         focus: FocusEvent;
@@ -20,6 +21,7 @@ declare const __propDef: {
         filterByConcurrencyKey: CustomEvent<any>;
         filterBySchedule: CustomEvent<any>;
         select: CustomEvent<any>;
+        loadExtra: CustomEvent<any>;
     } & {
         [evt: string]: CustomEvent<any>;
     };

package/package/components/schema/PropertyEditor.svelte

@@ -202,9 +202,4 @@ function updateSchema() {
 	input::-webkit-inner-spin-button {
 		-webkit-appearance: none !important;
 		margin: 0;
-	}
-
-	/* Firefox */
-	input[type='number'] {
-		-moz-appearance: textfield !important;
 	}</style>

package/package/components/settings/WorkspaceUserSettings.svelte

@@ -290,7 +290,7 @@ $: showInvites = invites?.length > 0 || (auto_invite_domain != undefined && !aut
 			{#if filteredUsers}
 				{#each filteredUsers.slice(0, nbDisplayed) as { email, username, is_admin, operator, disabled } (email)}
 					<tr class="!hover:bg-surface-hover">
-						<Cell first>{truncate(email, 20)}</Cell>
+						<Cell first><a href="mailto:{email}">{truncate(email, 20)}</a></Cell>
 						<Cell>{truncate(username, 30)}</Cell>
 						<Cell
 							>{#if usage?.[email] != undefined}{usage?.[email]}{:else}<Loader2

package/package/components/sidebar/MenuLink.svelte

@@ -1,6 +1,7 @@
 <script>import { classNames } from '../../utils';
 import { navigating, page } from '$app/stores';
 import Popover from '../Popover.svelte';
+import { base } from '$app/paths';
 export let label;
 export let href;
 export let icon = undefined;
@@ -9,7 +10,7 @@ export let disabled = false;
 export let lightMode = false;
 let isSelected = false;
 navigating.subscribe(() => {
-    if (href === '/') {
+    if (href === `${base}/`) {
         isSelected = $page.url.pathname === href;
     }
     else {

package/package/components/sidebar/WorkspaceMenu.svelte

@@ -26,10 +26,13 @@ async function toggleSwitchWorkspace(id) {
     const isOnEditPage = editPages.some((editPage) => $page.route.id?.includes(editPage) ?? false);
     if (!isOnEditPage) {
         switchWorkspace(id);
+        if ($page.url.searchParams.get('workspace')) {
+            $page.url.searchParams.set('workspace', id);
+        }
     }
     else {
-        await goto('/');
         switchWorkspace(id);
+        await goto('/');
     }
 }
 </script>

package/package/components/sidebar/changelogs.js

@@ -1,4 +1,34 @@
 const changelogs = [
+    {
+        label: 'Directly edit flow YAML',
+        href: 'https://www.windmill.dev/changelog/flow-yaml-editor',
+        date: '2024-09-02'
+    },
+    {
+        label: 'Critical alert channels',
+        href: 'https://www.windmill.dev/changelog/critical-alert-channels',
+        date: '2024-09-01'
+    },
+    {
+        label: 'See service logs directly in Windmill',
+        href: 'https://www.windmill.dev/changelog/service-logs',
+        date: '2024-09-01'
+    },
+    {
+        label: 'Vim support for Monaco/webeditor',
+        href: 'https://www.windmill.dev/changelog/vim-support',
+        date: '2024-08-28'
+    },
+    {
+        label: 'Hide / Show App Editor Panels',
+        href: 'https://www.windmill.dev/changelog/hide-show-app-panels',
+        date: '2024-08-26'
+    },
+    {
+        label: 'Email triggers',
+        href: 'https://www.windmill.dev/changelog/email-triggers',
+        date: '2024-08-06'
+    },
     {
         label: 'Continue on disapproval/timeout',
         href: 'https://www.windmill.dev/changelog/continue-on-disapproval',

package/package/components/tutorials/FlowBuilderTutorialsForLoop.svelte

@@ -130,8 +130,8 @@ export function runTutorial(indexToInsertAt) {
 							}
 
 							$flowStateStore[newId] = emptyFlowModuleState()
-
-							$flowStateStore[newId].schema.properties = {
+							let schema = $flowStateStore[newId].schema ?? { properties: {} }
+							schema.properties = {
 								x: {
 									type: 'string',
 									description: '',

package/package/gen/core/OpenAPI.js

@@ -21,7 +21,7 @@ export const OpenAPI = {
     PASSWORD: undefined,
     TOKEN: undefined,
     USERNAME: undefined,
-    VERSION: '1.388.0',
+    VERSION: '1.394.3',
     WITH_CREDENTIALS: false,
     interceptors: {
         request: new Interceptors(),

package/package/gen/schemas.gen.d.ts

@@ -1251,6 +1251,12 @@ export declare const $Schedule: {
         readonly on_recovery_extra_args: {
             readonly $ref: "#/components/schemas/ScriptArgs";
         };
+        readonly on_success: {
+            readonly type: "string";
+        };
+        readonly on_success_extra_args: {
+            readonly $ref: "#/components/schemas/ScriptArgs";
+        };
         readonly ws_error_handler_muted: {
             readonly type: "boolean";
         };
@@ -1345,6 +1351,12 @@ export declare const $NewSchedule: {
         readonly on_recovery_extra_args: {
             readonly $ref: "#/components/schemas/ScriptArgs";
         };
+        readonly on_success: {
+            readonly type: "string";
+        };
+        readonly on_success_extra_args: {
+            readonly $ref: "#/components/schemas/ScriptArgs";
+        };
         readonly ws_error_handler_muted: {
             readonly type: "boolean";
         };
@@ -1400,6 +1412,12 @@ export declare const $EditSchedule: {
         readonly on_recovery_extra_args: {
             readonly $ref: "#/components/schemas/ScriptArgs";
         };
+        readonly on_success: {
+            readonly type: "string";
+        };
+        readonly on_success_extra_args: {
+            readonly $ref: "#/components/schemas/ScriptArgs";
+        };
         readonly ws_error_handler_muted: {
             readonly type: "boolean";
         };
@@ -2762,6 +2780,9 @@ export declare const $PathScript: {
             readonly type: "string";
             readonly enum: readonly ["script"];
         };
+        readonly tag_override: {
+            readonly type: "string";
+        };
     };
     readonly required: readonly ["type", "path", "input_transforms"];
 };

package/package/gen/schemas.gen.js

@@ -1281,6 +1281,12 @@ export const $Schedule = {
         on_recovery_extra_args: {
             '$ref': '#/components/schemas/ScriptArgs'
         },
+        on_success: {
+            type: 'string'
+        },
+        on_success_extra_args: {
+            '$ref': '#/components/schemas/ScriptArgs'
+        },
         ws_error_handler_muted: {
             type: 'boolean'
         },
@@ -1378,6 +1384,12 @@ export const $NewSchedule = {
         on_recovery_extra_args: {
             '$ref': '#/components/schemas/ScriptArgs'
         },
+        on_success: {
+            type: 'string'
+        },
+        on_success_extra_args: {
+            '$ref': '#/components/schemas/ScriptArgs'
+        },
         ws_error_handler_muted: {
             type: 'boolean'
         },
@@ -1433,6 +1445,12 @@ export const $EditSchedule = {
         on_recovery_extra_args: {
             '$ref': '#/components/schemas/ScriptArgs'
         },
+        on_success: {
+            type: 'string'
+        },
+        on_success_extra_args: {
+            '$ref': '#/components/schemas/ScriptArgs'
+        },
         ws_error_handler_muted: {
             type: 'boolean'
         },
@@ -2815,6 +2833,9 @@ export const $PathScript = {
         type: {
             type: 'string',
             enum: ['script']
+        },
+        tag_override: {
+            type: 'string'
         }
     },
     required: ['type', 'path', 'input_transforms']