wind-agent-cli 1.37.2 → 1.37.3

package/server/shared/interfaces.ts

@@ -1,179 +1,179 @@
-import type {
-  AnyRecord,
-  FetchHistoryOptions,
-  FetchHistoryResult,
-  LLMProvider,
-  McpScope,
-  NormalizedMessage,
-  ProviderSkill,
-  ProviderSkillListOptions,
-  ProviderAuthStatus,
-  ProviderCurrentActiveModel,
-  ProviderModelsDefinition,
-  ProviderMcpServer,
-  ProviderSkillCreateInput,
-  ProviderSkillRemoveInput,
-  ProviderRuntimeContext,
-  ProviderRuntimePermissionGateway,
-  ProviderRuntimeWriter,
-  UpsertProviderMcpServerInput,
-} from '@/shared/types.js';
-
-//----------------- PROVIDER CONTRACT INTERFACES ------------
-
-/**
- * Live execution contract implemented by each provider SDK/CLI adapter.
- *
- * The provider registry owns this adapter as one facet of `IProvider`; runtime
- * execution context is supplied by the application service at call time.
- */
-export interface IProviderRuntime {
-  run(
-    command: string,
-    options: AnyRecord,
-    writer: ProviderRuntimeWriter,
-    context: ProviderRuntimeContext,
-  ): Promise<unknown>;
-  abort(sessionId: string): boolean | Promise<boolean>;
-  permissions?: ProviderRuntimePermissionGateway;
-}
-
-/**
- * Main provider contract for CLI and SDK integrations.
- *
- * Each concrete provider owns its MCP/auth handlers plus the provider-specific
- * logic for converting native events/history into the app's normalized shape.
- */
-export interface IProvider {
-  readonly id: LLMProvider;
-  readonly runtime: IProviderRuntime;
-  readonly models: IProviderModels;
-  readonly mcp: IProviderMcp;
-  readonly auth: IProviderAuth;
-  readonly skills: IProviderSkills;
-  readonly sessions: IProviderSessions;
-  readonly sessionSynchronizer: IProviderSessionSynchronizer;
-}
-
-// ---------------------------
-//----------------- PROVIDER MODEL INTERFACE ------------
-/**
- * Model catalog contract for one provider.
- *
- * Implementations supply CloudCLI's curated predefined models and can inspect
- * provider-native session state. The Providers service merges these immutable
- * source-controlled definitions with user-created SQLite rows at read time.
- */
-export interface IProviderModels {
-  /**
-   * Returns the curated predefined catalog owned by this provider adapter.
-   */
-  getSupportedModels(): Promise<ProviderModelsDefinition>;
-
-  /**
-   * Reads the model the provider itself believes one session is running with.
-   *
-   * Only consulted for sessions the app has never recorded a model for — a
-   * session started directly in the provider CLI, for example. Selecting a
-   * model in the app is persisted on the session row instead, so adapters here
-   * are read-only and must fall back to the catalog default when the
-   * provider-specific lookup finds nothing.
-   */
-  getCurrentActiveModel(sessionId?: string): Promise<ProviderCurrentActiveModel>;
-}
-
-// ---------------------------
-//----------------- PROVIDER AUTH INTERFACE ------------
-/**
- * Auth contract for one provider.
- *
- * Implementations should return a complete installation/authentication status
- * without throwing for normal "not installed" or "not authenticated" states.
- */
-export interface IProviderAuth {
-  /**
-   * Checks whether the provider is installed and has usable credentials.
-   */
-  getStatus(): Promise<ProviderAuthStatus>;
-}
-
-// ---------------------------
-//----------------- PROVIDER SKILLS INTERFACE ------------
-/**
- * Skills contract for one provider.
- *
- * Implementations discover provider-native skill markdown locations and return
- * normalized skill records with the exact command syntax expected by that
- * provider. Each skill is read from a `SKILL.md` file under its skill directory.
- */
-export interface IProviderSkills {
-  /**
-   * Lists all skills visible to this provider for the optional workspace.
-   */
-  listSkills(options?: ProviderSkillListOptions): Promise<ProviderSkill[]>;
-
-  /**
-   * Writes one or more global user-scoped skills for this provider.
-   *
-   * Implementations should install the supplied markdown entries into the
-   * provider's writable user skill folder and return the normalized skill
-   * records that were written.
-   */
-  addSkills(input: ProviderSkillCreateInput): Promise<ProviderSkill[]>;
-
-  removeSkill(
-    input: ProviderSkillRemoveInput,
-  ): Promise<{ removed: boolean; provider: LLMProvider; directoryName: string }>;
-}
-
-// ---------------------------
-//----------------- PROVIDER MCP INTERFACE ------------
-/**
- * MCP contract for one provider.
- *
- * Implementations must map provider-native MCP config formats to shared
- * `ProviderMcpServer` records used by routes and frontend state.
- */
-export interface IProviderMcp {
-  listServers(options?: { workspacePath?: string }): Promise<Record<McpScope, ProviderMcpServer[]>>;
-  listServersForScope(scope: McpScope, options?: { workspacePath?: string }): Promise<ProviderMcpServer[]>;
-  upsertServer(input: UpsertProviderMcpServerInput): Promise<ProviderMcpServer>;
-  removeServer(
-    input: { name: string; scope?: McpScope; workspacePath?: string },
-  ): Promise<{ removed: boolean; provider: LLMProvider; name: string; scope: McpScope }>;
-}
-
-// ---------------------------
-//----------------- PROVIDER SESSION INTERFACE ------------
-/**
- * Session/history contract for one provider.
- *
- * Implementations normalize provider-specific events and message history into
- * shared transport shapes consumed by API routes and realtime streams.
- */
-export interface IProviderSessions {
-  normalizeMessage(raw: unknown, sessionId: string | null): NormalizedMessage[];
-  fetchHistory(sessionId: string, options?: FetchHistoryOptions): Promise<FetchHistoryResult>;
-}
-
-// ---------------------------
-//----------------- PROVIDER SESSION SYNCHRONIZER INTERFACE ------------
-/**
- * Session indexing contract for one provider.
- *
- * Implementations scan provider-specific session artifacts on disk and upsert
- * normalized session metadata into the database. The service layer uses this
- * interface for both full rescans and single-file incremental sync triggered
- * by filesystem watcher events.
- */
-export interface IProviderSessionSynchronizer {
-  /**
-   * Scans provider session artifacts and upserts discovered sessions into DB.
-   */
-  synchronize(since?: Date): Promise<number>;
-
-  /**
-   * Parses and upserts one provider artifact file without running a full scan.
-   */
-  synchronizeFile(filePath: string): Promise<string | null>;
-}
+import type {
+  AnyRecord,
+  FetchHistoryOptions,
+  FetchHistoryResult,
+  LLMProvider,
+  McpScope,
+  NormalizedMessage,
+  ProviderSkill,
+  ProviderSkillListOptions,
+  ProviderAuthStatus,
+  ProviderCurrentActiveModel,
+  ProviderModelsDefinition,
+  ProviderMcpServer,
+  ProviderSkillCreateInput,
+  ProviderSkillRemoveInput,
+  ProviderRuntimeContext,
+  ProviderRuntimePermissionGateway,
+  ProviderRuntimeWriter,
+  UpsertProviderMcpServerInput,
+} from '@/shared/types.js';
+
+//----------------- PROVIDER CONTRACT INTERFACES ------------
+
+/**
+ * Live execution contract implemented by each provider SDK/CLI adapter.
+ *
+ * The provider registry owns this adapter as one facet of `IProvider`; runtime
+ * execution context is supplied by the application service at call time.
+ */
+export interface IProviderRuntime {
+  run(
+    command: string,
+    options: AnyRecord,
+    writer: ProviderRuntimeWriter,
+    context: ProviderRuntimeContext,
+  ): Promise<unknown>;
+  abort(sessionId: string): boolean | Promise<boolean>;
+  permissions?: ProviderRuntimePermissionGateway;
+}
+
+/**
+ * Main provider contract for CLI and SDK integrations.
+ *
+ * Each concrete provider owns its MCP/auth handlers plus the provider-specific
+ * logic for converting native events/history into the app's normalized shape.
+ */
+export interface IProvider {
+  readonly id: LLMProvider;
+  readonly runtime: IProviderRuntime;
+  readonly models: IProviderModels;
+  readonly mcp: IProviderMcp;
+  readonly auth: IProviderAuth;
+  readonly skills: IProviderSkills;
+  readonly sessions: IProviderSessions;
+  readonly sessionSynchronizer: IProviderSessionSynchronizer;
+}
+
+// ---------------------------
+//----------------- PROVIDER MODEL INTERFACE ------------
+/**
+ * Model catalog contract for one provider.
+ *
+ * Implementations supply CloudCLI's curated predefined models and can inspect
+ * provider-native session state. The Providers service merges these immutable
+ * source-controlled definitions with user-created SQLite rows at read time.
+ */
+export interface IProviderModels {
+  /**
+   * Returns the curated predefined catalog owned by this provider adapter.
+   */
+  getSupportedModels(): Promise<ProviderModelsDefinition>;
+
+  /**
+   * Reads the model the provider itself believes one session is running with.
+   *
+   * Only consulted for sessions the app has never recorded a model for — a
+   * session started directly in the provider CLI, for example. Selecting a
+   * model in the app is persisted on the session row instead, so adapters here
+   * are read-only and must fall back to the catalog default when the
+   * provider-specific lookup finds nothing.
+   */
+  getCurrentActiveModel(sessionId?: string): Promise<ProviderCurrentActiveModel>;
+}
+
+// ---------------------------
+//----------------- PROVIDER AUTH INTERFACE ------------
+/**
+ * Auth contract for one provider.
+ *
+ * Implementations should return a complete installation/authentication status
+ * without throwing for normal "not installed" or "not authenticated" states.
+ */
+export interface IProviderAuth {
+  /**
+   * Checks whether the provider is installed and has usable credentials.
+   */
+  getStatus(): Promise<ProviderAuthStatus>;
+}
+
+// ---------------------------
+//----------------- PROVIDER SKILLS INTERFACE ------------
+/**
+ * Skills contract for one provider.
+ *
+ * Implementations discover provider-native skill markdown locations and return
+ * normalized skill records with the exact command syntax expected by that
+ * provider. Each skill is read from a `SKILL.md` file under its skill directory.
+ */
+export interface IProviderSkills {
+  /**
+   * Lists all skills visible to this provider for the optional workspace.
+   */
+  listSkills(options?: ProviderSkillListOptions): Promise<ProviderSkill[]>;
+
+  /**
+   * Writes one or more global user-scoped skills for this provider.
+   *
+   * Implementations should install the supplied markdown entries into the
+   * provider's writable user skill folder and return the normalized skill
+   * records that were written.
+   */
+  addSkills(input: ProviderSkillCreateInput): Promise<ProviderSkill[]>;
+
+  removeSkill(
+    input: ProviderSkillRemoveInput,
+  ): Promise<{ removed: boolean; provider: LLMProvider; directoryName: string }>;
+}
+
+// ---------------------------
+//----------------- PROVIDER MCP INTERFACE ------------
+/**
+ * MCP contract for one provider.
+ *
+ * Implementations must map provider-native MCP config formats to shared
+ * `ProviderMcpServer` records used by routes and frontend state.
+ */
+export interface IProviderMcp {
+  listServers(options?: { workspacePath?: string }): Promise<Record<McpScope, ProviderMcpServer[]>>;
+  listServersForScope(scope: McpScope, options?: { workspacePath?: string }): Promise<ProviderMcpServer[]>;
+  upsertServer(input: UpsertProviderMcpServerInput): Promise<ProviderMcpServer>;
+  removeServer(
+    input: { name: string; scope?: McpScope; workspacePath?: string },
+  ): Promise<{ removed: boolean; provider: LLMProvider; name: string; scope: McpScope }>;
+}
+
+// ---------------------------
+//----------------- PROVIDER SESSION INTERFACE ------------
+/**
+ * Session/history contract for one provider.
+ *
+ * Implementations normalize provider-specific events and message history into
+ * shared transport shapes consumed by API routes and realtime streams.
+ */
+export interface IProviderSessions {
+  normalizeMessage(raw: unknown, sessionId: string | null): NormalizedMessage[];
+  fetchHistory(sessionId: string, options?: FetchHistoryOptions): Promise<FetchHistoryResult>;
+}
+
+// ---------------------------
+//----------------- PROVIDER SESSION SYNCHRONIZER INTERFACE ------------
+/**
+ * Session indexing contract for one provider.
+ *
+ * Implementations scan provider-specific session artifacts on disk and upsert
+ * normalized session metadata into the database. The service layer uses this
+ * interface for both full rescans and single-file incremental sync triggered
+ * by filesystem watcher events.
+ */
+export interface IProviderSessionSynchronizer {
+  /**
+   * Scans provider session artifacts and upserts discovered sessions into DB.
+   */
+  synchronize(since?: Date): Promise<number>;
+
+  /**
+   * Parses and upserts one provider artifact file without running a full scan.
+   */
+  synchronizeFile(filePath: string): Promise<string | null>;
+}

package/server/shared/tests/claude-cli-path.test.ts

@@ -1,61 +1,61 @@
-import assert from 'node:assert/strict';
-import test from 'node:test';
-
-import {
-  resolveClaudeCodeExecutablePath,
-  type ResolveClaudeCodeExecutablePathDependencies,
-} from '@/shared/claude-cli-path.js';
-
-test('resolveClaudeCodeExecutablePath resolves the npm Claude wrapper to its native exe on Windows', () => {
-  const wrapperDir = 'C:\\nvm4w\\nodejs';
-  const nativePath = `${wrapperDir}\\node_modules\\@anthropic-ai\\claude-code\\bin\\claude.exe`;
-  const execFileSync =
-    (() => `${wrapperDir}\\claude\r\n${wrapperDir}\\claude.cmd\r\n`) as unknown as ResolveClaudeCodeExecutablePathDependencies['execFileSync'];
-  const readFileSync = (() => '') as unknown as ResolveClaudeCodeExecutablePathDependencies['readFileSync'];
-
-  const resolved = resolveClaudeCodeExecutablePath('claude', {
-    platform: 'win32',
-    execFileSync,
-    existsSync: (candidate) => candidate === nativePath,
-    readFileSync,
-  });
-
-  assert.equal(resolved, nativePath);
-});
-
-test('resolveClaudeCodeExecutablePath keeps an explicit JavaScript launcher path unchanged', () => {
-  const scriptPath = 'C:\\tools\\claude.js';
-
-  const resolved = resolveClaudeCodeExecutablePath(scriptPath, {
-    platform: 'win32',
-  });
-
-  assert.equal(resolved, scriptPath);
-});
-
-test('resolveClaudeCodeExecutablePath can parse a wrapper file path containing letters r and n before claude.exe', () => {
-  const wrapperPath = 'C:\\tools\\claude';
-  const nativePath = 'C:\\tools\\custom\\bin\\node_modules\\@anthropic-ai\\claude-code\\bin\\claude.exe';
-  const readFileSync = (() => `exec "$basedir/custom/bin/node_modules/@anthropic-ai/claude-code/bin/claude.exe" "$@"`) as unknown as ResolveClaudeCodeExecutablePathDependencies['readFileSync'];
-
-  const resolved = resolveClaudeCodeExecutablePath(wrapperPath, {
-    platform: 'win32',
-    existsSync: (candidate) => candidate === nativePath,
-    readFileSync,
-  });
-
-  assert.equal(resolved, nativePath);
-});
-
-test('resolveClaudeCodeExecutablePath falls back to the configured command when PATH lookup fails', () => {
-  const execFileSync = (() => {
-    throw new Error('not found');
-  }) as unknown as ResolveClaudeCodeExecutablePathDependencies['execFileSync'];
-
-  const resolved = resolveClaudeCodeExecutablePath('claude', {
-    platform: 'win32',
-    execFileSync,
-  });
-
-  assert.equal(resolved, 'claude');
-});
+import assert from 'node:assert/strict';
+import test from 'node:test';
+
+import {
+  resolveClaudeCodeExecutablePath,
+  type ResolveClaudeCodeExecutablePathDependencies,
+} from '@/shared/claude-cli-path.js';
+
+test('resolveClaudeCodeExecutablePath resolves the npm Claude wrapper to its native exe on Windows', () => {
+  const wrapperDir = 'C:\\nvm4w\\nodejs';
+  const nativePath = `${wrapperDir}\\node_modules\\@anthropic-ai\\claude-code\\bin\\claude.exe`;
+  const execFileSync =
+    (() => `${wrapperDir}\\claude\r\n${wrapperDir}\\claude.cmd\r\n`) as unknown as ResolveClaudeCodeExecutablePathDependencies['execFileSync'];
+  const readFileSync = (() => '') as unknown as ResolveClaudeCodeExecutablePathDependencies['readFileSync'];
+
+  const resolved = resolveClaudeCodeExecutablePath('claude', {
+    platform: 'win32',
+    execFileSync,
+    existsSync: (candidate) => candidate === nativePath,
+    readFileSync,
+  });
+
+  assert.equal(resolved, nativePath);
+});
+
+test('resolveClaudeCodeExecutablePath keeps an explicit JavaScript launcher path unchanged', () => {
+  const scriptPath = 'C:\\tools\\claude.js';
+
+  const resolved = resolveClaudeCodeExecutablePath(scriptPath, {
+    platform: 'win32',
+  });
+
+  assert.equal(resolved, scriptPath);
+});
+
+test('resolveClaudeCodeExecutablePath can parse a wrapper file path containing letters r and n before claude.exe', () => {
+  const wrapperPath = 'C:\\tools\\claude';
+  const nativePath = 'C:\\tools\\custom\\bin\\node_modules\\@anthropic-ai\\claude-code\\bin\\claude.exe';
+  const readFileSync = (() => `exec "$basedir/custom/bin/node_modules/@anthropic-ai/claude-code/bin/claude.exe" "$@"`) as unknown as ResolveClaudeCodeExecutablePathDependencies['readFileSync'];
+
+  const resolved = resolveClaudeCodeExecutablePath(wrapperPath, {
+    platform: 'win32',
+    existsSync: (candidate) => candidate === nativePath,
+    readFileSync,
+  });
+
+  assert.equal(resolved, nativePath);
+});
+
+test('resolveClaudeCodeExecutablePath falls back to the configured command when PATH lookup fails', () => {
+  const execFileSync = (() => {
+    throw new Error('not found');
+  }) as unknown as ResolveClaudeCodeExecutablePathDependencies['execFileSync'];
+
+  const resolved = resolveClaudeCodeExecutablePath('claude', {
+    platform: 'win32',
+    execFileSync,
+  });
+
+  assert.equal(resolved, 'claude');
+});