wiki-plugin-allyabase 0.0.6 → 0.0.8

package/BUGFIXES.md

@@ -0,0 +1,277 @@
+# Allyabase Plugin - Critical Bug Fixes
+
+## Date: February 9, 2026
+
+### Critical Bug #1: Invalid Express Route Wildcard
+
+**Problem:**
+Multiple routes used the wildcard `*` syntax which is invalid in newer versions of path-to-regexp (used by Express):
+
+```javascript
+// Federation route (line 291)
+app.use('/plugin/allyabase/federation/*', function(req, res, next) {
+
+// Service proxy routes (line 633)
+app.all(`/plugin/allyabase/${service}/*`, function(req, res) {
+```
+
+This caused:
+```
+PathError: Missing parameter name at index 30: /plugin/allyabase/federation/*
+PathError: Missing parameter name at index 25: /plugin/allyabase/julia/*
+```
+
+**Fix:**
+Changed both to use regex patterns:
+
+```javascript
+// Federation route (line 291)
+app.use(/^\/plugin\/allyabase\/federation\/.*/, function(req, res, next) {
+
+// Service proxy routes (line 633)
+app.all(new RegExp(`^\\/plugin\\/allyabase\\/${service}\\/.*`), function(req, res) {
+```
+
+**Locations:**
+- `server/server.js:291` - Federation route
+- `server/server.js:633` - Service proxy routes (all 14 services)
+
+**Impact:** Plugin would crash immediately on load, making all federation endpoints and service proxies unusable.
+
+---
+
+### Critical Bug #2: Process Suicide in Docker Containers
+
+**Problem:**
+The `cleanupOrphanedProcesses()` function scans ports and kills any process using them. In Docker containers:
+- PID 1 is always the main container process (the wiki server)
+- When the plugin finds the wiki using a port, it tries to kill PID 1
+- This kills the entire container
+
+**Symptoms:**
+```
+[wiki-plugin-allyabase] Found process 1 using port 3005
+[wiki-plugin-allyabase] Attempting to kill process 1...
+[wiki-plugin-allyabase] Process 1 still running, sending SIGKILL...
+```
+
+Followed by container crash.
+
+**Fix #1: PID Protection**
+Added safety checks to `killProcessByPid()`:
+```javascript
+// CRITICAL: Never kill PID 1 in Docker containers
+if (pid === 1) {
+  console.log('⚠️  Skipping PID 1 (init process)');
+  return false;
+}
+
+// Also don't kill our own process
+if (pid === process.pid) {
+  console.log('⚠️  Skipping PID ${pid} (this is us!)');
+  return false;
+}
+```
+
+**Fix #2: Docker Detection**
+Added Docker environment detection to skip port cleanup entirely:
+```javascript
+const isDocker = fs.existsSync('/.dockerenv') || fs.existsSync('/run/.containerenv');
+
+if (isDocker) {
+  console.log('🐳 Detected Docker environment - skipping port cleanup');
+  console.log('In Docker, services should run in separate containers');
+  return;
+}
+```
+
+**Location:** `server/server.js:63-100, 156-175`
+
+**Rationale:**
+In Docker/containerized environments:
+- Each service runs in its own container
+- Services don't share the same process space
+- Attempting to kill processes by port is:
+  - Dangerous (can kill the wiki itself)
+  - Unnecessary (services are isolated)
+  - Won't work anyway (can't kill processes in other containers)
+
+---
+
+## Testing the Fixes
+
+### Before Fix:
+```bash
+# Install allyabase plugin
+docker exec -u node -w /home/node/lib/node_modules/wiki wiki-dave npm install wiki-plugin-allyabase
+
+# Restart wiki
+docker-compose restart wiki-dave
+
+# Result: Wiki crashes immediately
+# Logs show: Attempting to kill process 1... [crash]
+```
+
+### After Fix:
+```bash
+# Install allyabase plugin
+docker exec -u node -w /home/node/lib/node_modules/wiki wiki-dave npm install wiki-plugin-allyabase
+
+# Restart wiki
+docker-compose restart wiki-dave
+
+# Result: Wiki starts successfully
+# Logs show:
+#   🐳 Detected Docker environment - skipping port cleanup
+#   ✅ wiki-plugin-allyabase ready!
+```
+
+---
+
+## Architecture Implications
+
+### Original Design (Non-Docker):
+```
+┌─────────────────────────────┐
+│   Single Machine/VM         │
+│                             │
+│  ┌──────────────────────┐   │
+│  │ Wiki (PID 123)       │   │
+│  │ Port 3333            │   │
+│  └──────────────────────┘   │
+│                             │
+│  ┌──────────────────────┐   │
+│  │ PM2                  │   │
+│  │  ├─ Fount (PID 456)  │   │
+│  │  ├─ BDO (PID 789)    │   │
+│  │  ├─ Joan (PID 101)   │   │
+│  │  └─ ...13 more       │   │
+│  └──────────────────────┘   │
+│                             │
+│  Allyabase plugin can:      │
+│  - Kill orphaned PM2        │
+│  - Kill processes on ports  │
+│  - Restart services         │
+└─────────────────────────────┘
+```
+
+### Docker Design (Current):
+```
+┌──────────────────┐  ┌──────────────────┐  ┌──────────────────┐
+│ Wiki Container   │  │ Fount Container  │  │ BDO Container    │
+│                  │  │                  │  │                  │
+│ ┌──────────────┐ │  │ ┌──────────────┐ │  │ ┌──────────────┐ │
+│ │ Wiki (PID 1) │ │  │ │ Fount (PID 1)│ │  │ │ BDO (PID 1)  │ │
+│ │ Port 3000    │ │  │ │ Port 3006    │ │  │ │ Port 3003    │ │
+│ └──────────────┘ │  │ └──────────────┘ │  │ └──────────────┘ │
+└──────────────────┘  └──────────────────┘  └──────────────────┘
+         │                     │                      │
+         └─────────────────────┴──────────────────────┘
+                               │
+                      Docker Network
+
+Each container:
+- Has its own PID 1 (init process)
+- Isolated process space
+- Cannot kill processes in other containers
+- Managed by Docker Compose, not PM2
+
+Allyabase plugin in Docker:
+- ✅ Provides proxy routes to services
+- ✅ Handles federation resolution
+- ❌ Cannot manage service lifecycles (that's Docker's job)
+- ❌ Cannot kill processes (dangerous and won't work)
+```
+
+---
+
+## Future Considerations
+
+### Service Management in Docker
+
+The plugin's service management features (launch, healthcheck) need rethinking for Docker:
+
+**Current Approach (Non-Docker):**
+- `POST /plugin/allyabase/launch` - Runs `allyabase_setup.sh` which spawns PM2
+- PM2 manages all 14 services as child processes
+- Plugin can kill/restart services
+
+**Docker Approach Options:**
+
+1. **Docker Compose (Recommended):**
+   ```yaml
+   services:
+     wiki:
+       image: wiki-federation:latest
+     fount:
+       image: fount:latest
+     bdo:
+       image: bdo:latest
+     # ...etc
+   ```
+   - Services managed by Docker Compose
+   - Plugin acts as pure proxy layer
+   - No lifecycle management in plugin
+
+2. **Docker API Integration:**
+   - Plugin calls Docker API to start/stop containers
+   - Requires Docker socket mount
+   - More complex but gives control
+
+3. **Hybrid (Current State):**
+   - Plugin works as proxy in Docker
+   - Manual service management via docker-compose CLI
+   - Plugin's /launch endpoint doesn't work in Docker (services already running)
+
+### Recommendation
+
+For Docker deployments:
+1. Use docker-compose to manage all services
+2. Allyabase plugin provides:
+   - ✅ Service proxy routes
+   - ✅ Federation resolution
+   - ✅ Healthcheck endpoint (checks if services respond)
+   - ❌ Launch/lifecycle management (handled by Docker)
+
+For non-Docker deployments:
+1. Original design works as intended
+2. PM2 process management
+3. Full lifecycle control via plugin
+
+---
+
+## Files Modified
+
+1. **server/server.js**
+   - Line 291: Fixed Express federation route wildcard (`*` → regex)
+   - Line 633: Fixed Express service proxy route wildcards (all 14 services, `*` → regex)
+   - Lines 63-100: Added PID 1 protection and self-protection
+   - Lines 156-175: Added Docker detection and port cleanup skip
+
+## Backward Compatibility
+
+These changes are **fully backward compatible**:
+
+- **Non-Docker environments:** Port cleanup still works (unless PID 1 or self)
+- **Docker environments:** Automatically detected and handled safely
+- **Existing functionality:** All proxy routes, federation, and endpoints unchanged
+
+## Testing Checklist
+
+- [ ] Plugin loads without crash in Docker
+- [ ] Federation endpoints respond (no PathError)
+- [ ] Wiki doesn't kill itself on startup
+- [ ] Proxy routes work (e.g., `/plugin/allyabase/bdo/*`)
+- [ ] Healthcheck endpoint works
+- [ ] Docker detection logs appear
+- [ ] Non-Docker deployment still works (if applicable)
+
+---
+
+## Related Issues
+
+- Original crash report: Dave's wiki crashed when allyabase installed
+- Error 1: `PathError: Missing parameter name at index 30`
+- Error 2: `Attempting to kill process 1` followed by container death
+
+Both issues now resolved.

package/client/allyabase.js

@@ -139,6 +139,128 @@ function emit($item, item) {
     console.log('[allyabase] Fork detected from:', forkInfo);
   }
 
+  // Add configuration section
+  const configContainer = document.createElement('div');
+  configContainer.style.padding = '10px';
+  configContainer.style.marginBottom = '15px';
+  configContainer.style.backgroundColor = '#f0f8ff';
+  configContainer.style.borderRadius = '5px';
+  configContainer.style.border = '1px solid #cce5ff';
+
+  const configTitle = document.createElement('div');
+  configTitle.style.fontWeight = 'bold';
+  configTitle.style.marginBottom = '10px';
+  configTitle.textContent = '⚙️ Configuration';
+  configContainer.appendChild(configTitle);
+
+  // Location Emoji Input
+  const locationLabel = document.createElement('div');
+  locationLabel.style.fontSize = '12px';
+  locationLabel.style.marginBottom = '4px';
+  locationLabel.textContent = 'Location Emoji (3 emoji):';
+  configContainer.appendChild(locationLabel);
+
+  const locationInput = document.createElement('input');
+  locationInput.type = 'text';
+  locationInput.id = 'location-emoji-input';
+  locationInput.style.width = '200px';
+  locationInput.style.padding = '5px';
+  locationInput.style.fontSize = '16px';
+  locationInput.style.marginBottom = '10px';
+  locationInput.placeholder = 'e.g., 🔥💎🌟';
+  configContainer.appendChild(locationInput);
+
+  // Federation Emoji Input
+  const federationLabel = document.createElement('div');
+  federationLabel.style.fontSize = '12px';
+  federationLabel.style.marginBottom = '4px';
+  federationLabel.textContent = 'Federation Emoji (1 emoji):';
+  configContainer.appendChild(federationLabel);
+
+  const federationInput = document.createElement('input');
+  federationInput.type = 'text';
+  federationInput.id = 'federation-emoji-input';
+  federationInput.style.width = '200px';
+  federationInput.style.padding = '5px';
+  federationInput.style.fontSize = '16px';
+  federationInput.style.marginBottom = '10px';
+  federationInput.placeholder = 'e.g., 💚';
+  federationInput.value = '💚';
+  configContainer.appendChild(federationInput);
+
+  // Save button
+  const saveConfigBtn = document.createElement('button');
+  saveConfigBtn.textContent = 'Save Configuration';
+  saveConfigBtn.style.padding = '8px 15px';
+  saveConfigBtn.style.fontSize = '12px';
+  saveConfigBtn.style.cursor = 'pointer';
+  saveConfigBtn.style.marginTop = '5px';
+  saveConfigBtn.style.backgroundColor = '#4CAF50';
+  saveConfigBtn.style.color = 'white';
+  saveConfigBtn.style.border = 'none';
+  saveConfigBtn.style.borderRadius = '4px';
+  configContainer.appendChild(saveConfigBtn);
+
+  // Config status message
+  const configStatus = document.createElement('div');
+  configStatus.id = 'config-status';
+  configStatus.style.fontSize = '11px';
+  configStatus.style.marginTop = '8px';
+  configStatus.style.minHeight = '16px';
+  configContainer.appendChild(configStatus);
+
+  container.appendChild(configContainer);
+
+  // Load current configuration
+  async function loadConfig() {
+    try {
+      const response = await get('/plugin/allyabase/config');
+      const data = await response.json();
+      if (data.success && data.config) {
+        locationInput.value = data.config.locationEmoji || '';
+        federationInput.value = data.config.federationEmoji || '💚';
+      }
+    } catch (err) {
+      console.error('[allyabase] Error loading config:', err);
+    }
+  }
+
+  // Save configuration
+  saveConfigBtn.addEventListener('click', async () => {
+    try {
+      configStatus.textContent = 'Saving...';
+      configStatus.style.color = '#666';
+
+      const response = await post('/plugin/allyabase/config', {
+        locationEmoji: locationInput.value.trim(),
+        federationEmoji: federationInput.value.trim() || '💚'
+      });
+
+      const result = await response.json();
+
+      if (result.success) {
+        configStatus.textContent = '✓ Configuration saved successfully!';
+        configStatus.style.color = 'green';
+        // Reload base emoji display
+        loadBaseEmoji();
+      } else {
+        configStatus.textContent = `✗ Error: ${result.error}`;
+        configStatus.style.color = 'red';
+      }
+
+      setTimeout(() => {
+        configStatus.textContent = '';
+      }, 3000);
+    } catch (err) {
+      console.error('[allyabase] Error saving config:', err);
+      configStatus.textContent = `✗ Error: ${err.message}`;
+      configStatus.style.color = 'red';
+    }
+  });
+
+  // Load config on initialization
+  loadConfig();
+
   // Add base emoji identifier section
   const baseEmojiContainer = document.createElement('div');
   baseEmojiContainer.style.padding = '10px';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "wiki-plugin-allyabase",
-  "version": "0.0.6",
+  "version": "0.0.8",
   "description": "Allyabase management plugin for the federated wiki",
   "keywords": [
     "wiki",

package/server/server.js

@@ -29,6 +29,9 @@ const SERVICE_PORTS = {
 // PID file for tracking PM2 process
 const PM2_PID_FILE = path.join(__dirname, 'allyabase-pm2.pid');
 
+// Plugin configuration file (stores locationEmoji, federationEmoji, etc.)
+const CONFIG_FILE = path.join(__dirname, 'plugin-config.json');
+
 let baseStatus = {
   running: false,
   services: {},
@@ -37,7 +40,38 @@ let baseStatus = {
 
 let allyabaseProcess = null;
 
-// Function to load wiki's owner.json for keypair and location emoji
+// Load plugin configuration (locationEmoji, federationEmoji, etc.)
+function loadPluginConfig() {
+  try {
+    if (fs.existsSync(CONFIG_FILE)) {
+      return JSON.parse(fs.readFileSync(CONFIG_FILE, 'utf8'));
+    }
+    // Return defaults if no config file exists
+    return {
+      locationEmoji: null,
+      federationEmoji: '💚'
+    };
+  } catch (err) {
+    console.error('[wiki-plugin-allyabase] Error loading plugin config:', err);
+    return {
+      locationEmoji: null,
+      federationEmoji: '💚'
+    };
+  }
+}
+
+// Save plugin configuration
+function savePluginConfig(config) {
+  try {
+    fs.writeFileSync(CONFIG_FILE, JSON.stringify(config, null, 2), 'utf8');
+    return true;
+  } catch (err) {
+    console.error('[wiki-plugin-allyabase] Error saving plugin config:', err);
+    return false;
+  }
+}
+
+// Function to load wiki's sessionless keys from owner.json (authentication only)
 function loadWikiKeypair() {
   try {
     const ownerPath = path.join(process.env.HOME || '/root', '.wiki/status/owner.json');
@@ -46,9 +80,7 @@ function loadWikiKeypair() {
       if (ownerData.sessionlessKeys) {
         return {
           pubKey: ownerData.sessionlessKeys.pubKey,
-          privateKey: ownerData.sessionlessKeys.privateKey,
-          locationEmoji: ownerData.locationEmoji,
-          federationEmoji: ownerData.federationEmoji
+          privateKey: ownerData.sessionlessKeys.privateKey
         };
       }
     }
@@ -63,6 +95,18 @@ function loadWikiKeypair() {
 // Function to kill process by PID
 function killProcessByPid(pid) {
   try {
+    // CRITICAL: Never kill PID 1 in Docker containers - it's the main container process
+    if (pid === 1) {
+      console.log(`[wiki-plugin-allyabase] ⚠️  Skipping PID 1 (init process) - this is likely the wiki server itself in Docker`);
+      return false;
+    }
+
+    // Also don't kill our own process
+    if (pid === process.pid) {
+      console.log(`[wiki-plugin-allyabase] ⚠️  Skipping PID ${pid} (this is us!)`);
+      return false;
+    }
+
     console.log(`[wiki-plugin-allyabase] Attempting to kill process ${pid}...`);
     process.kill(pid, 'SIGTERM');
 
@@ -156,7 +200,18 @@ async function cleanupOrphanedProcesses() {
   // Stop PM2 if it's running (cleans up all managed services)
   await stopPM2();
 
-  // Fallback: kill any processes using our ports
+  // Detect if we're in a Docker container
+  // In Docker, services run in separate containers, so port cleanup is unnecessary and dangerous
+  const isDocker = fs.existsSync('/.dockerenv') || fs.existsSync('/run/.containerenv');
+
+  if (isDocker) {
+    console.log('[wiki-plugin-allyabase] 🐳 Detected Docker environment - skipping port cleanup');
+    console.log('[wiki-plugin-allyabase] In Docker, services should run in separate containers, not as processes on ports');
+    console.log('[wiki-plugin-allyabase] Cleanup complete (Docker mode)');
+    return;
+  }
+
+  // Fallback: kill any processes using our ports (only in non-Docker environments)
   console.log('[wiki-plugin-allyabase] Cleaning up any processes on service ports...');
   for (const [service, port] of Object.entries(SERVICE_PORTS)) {
     await killProcessByPort(port);
@@ -288,7 +343,8 @@ async function startServer(params) {
 
   // CORS middleware for federation endpoints
   // Allows cross-origin requests from other federated wikis
-  app.use('/plugin/allyabase/federation/*', function(req, res, next) {
+  // Use regex to match all federation paths (Express doesn't support * wildcard in newer versions)
+  app.use(/^\/plugin\/allyabase\/federation\/.*/, function(req, res, next) {
     res.setHeader('Access-Control-Allow-Origin', '*');
     res.setHeader('Access-Control-Allow-Methods', 'GET, POST, OPTIONS');
     res.setHeader('Access-Control-Allow-Headers', 'Content-Type');
@@ -497,8 +553,8 @@ async function startServer(params) {
       if (targetWikiUrls && targetWikiUrls.length > 0) {
         // This is a cross-wiki request - try all registered URLs
         const currentWikiUrl = `http://localhost:${req.socket.localPort}`;
-        const wikiInfo = loadWikiKeypair();
-        const thisWikiLocationEmoji = wikiInfo ? wikiInfo.locationEmoji : null;
+        const config = loadPluginConfig();
+        const thisWikiLocationEmoji = config.locationEmoji;
 
         console.log('[BDO EMOJI] Cross-wiki request detected');
         console.log('[BDO EMOJI] Target wikis (${targetWikiUrls.length}): ${targetWikiUrls.join(', ')}');
@@ -606,7 +662,8 @@ async function startServer(params) {
   // Create proxy routes for each service
   Object.entries(SERVICE_PORTS).forEach(([service, port]) => {
     // Proxy all methods (GET, POST, PUT, DELETE, etc.)
-    app.all(`/plugin/allyabase/${service}/*`, function(req, res) {
+    // Use regex pattern instead of wildcard to avoid PathError in newer path-to-regexp
+    app.all(new RegExp(`^\\/plugin\\/allyabase\\/${service}\\/.*`), function(req, res) {
       const targetPath = req.url.replace(`/plugin/allyabase/${service}`, '');
       console.log(`[PROXY] ${req.method} /plugin/allyabase/${service}${targetPath} -> http://localhost:${port}${targetPath}`);
       console.log(`[PROXY] Headers:`, JSON.stringify(req.headers, null, 2));
@@ -726,58 +783,122 @@ async function startServer(params) {
     res.send(baseStatus);
   });
 
-  // Endpoint to get wiki's base emoji identifier
+  // Endpoint to get wiki's base emoji identifier (from plugin config)
   app.get('/plugin/allyabase/base-emoji', function(req, res) {
     try {
-      const ownerPath = path.join(process.env.HOME || '/root', '.wiki/status/owner.json');
-      if (fs.existsSync(ownerPath)) {
-        const ownerData = JSON.parse(fs.readFileSync(ownerPath, 'utf8'));
-
-        const response = {
-          federationEmoji: ownerData.federationEmoji || '💚',
-          locationEmoji: ownerData.locationEmoji || null,
-          baseEmoji: (ownerData.federationEmoji || '💚') + (ownerData.locationEmoji || ''),
-          warnings: []
-        };
+      const config = loadPluginConfig();
+      const keypair = loadWikiKeypair();
 
-        // Validation warnings
-        if (!ownerData.locationEmoji) {
-          response.warnings.push({
-            severity: 'error',
-            message: 'Missing locationEmoji in owner.json',
-            fix: 'Add "locationEmoji": "🔥💎🌟" (3 emoji) to your owner.json'
-          });
-        } else if (!ownerData.federationEmoji) {
-          response.warnings.push({
-            severity: 'warning',
-            message: 'Missing federationEmoji in owner.json, using default 💚',
-            fix: 'Add "federationEmoji": "💚" to your owner.json'
+      const response = {
+        federationEmoji: config.federationEmoji || '💚',
+        locationEmoji: config.locationEmoji || null,
+        baseEmoji: (config.federationEmoji || '💚') + (config.locationEmoji || ''),
+        warnings: []
+      };
+
+      // Validation warnings
+      if (!config.locationEmoji) {
+        response.warnings.push({
+          severity: 'error',
+          message: 'Location emoji not configured',
+          fix: 'Set your 3-emoji location identifier in the plugin settings'
+        });
+      }
+
+      if (!keypair || !keypair.pubKey) {
+        response.warnings.push({
+          severity: 'error',
+          message: 'Missing sessionless keys in owner.json',
+          fix: 'BDO operations will fail without sessionless keys in ~/.wiki/status/owner.json'
+        });
+      }
+
+      res.send(response);
+    } catch (err) {
+      console.error('Error reading base emoji config:', err);
+      res.status(500).send({
+        error: 'Failed to load base emoji',
+        message: err.message
+      });
+    }
+  });
+
+  // Endpoint to get plugin configuration
+  app.get('/plugin/allyabase/config', function(req, res) {
+    try {
+      const config = loadPluginConfig();
+      res.send({
+        success: true,
+        config: config
+      });
+    } catch (err) {
+      console.error('Error loading plugin config:', err);
+      res.status(500).send({
+        success: false,
+        error: 'Failed to load configuration',
+        message: err.message
+      });
+    }
+  });
+
+  // Endpoint to save plugin configuration (requires owner auth)
+  app.post('/plugin/allyabase/config', owner, function(req, res) {
+    try {
+      const { locationEmoji, federationEmoji } = req.body;
+
+      // Validate locationEmoji (should be exactly 3 emoji)
+      if (locationEmoji) {
+        const emojiRegex = /[\u{1F1E6}-\u{1F1FF}]{2}|(?:[\u{1F3F4}\u{1F3F3}][\u{FE0F}]?(?:\u{200D}[\u{2620}\u{2695}\u{2696}\u{2708}\u{1F308}][\u{FE0F}]?)?)|(?:\p{Emoji_Presentation}|\p{Emoji}\uFE0F)(?:\u{200D}(?:\p{Emoji_Presentation}|\p{Emoji}\uFE0F))*/gu;
+        const emojis = locationEmoji.match(emojiRegex) || [];
+
+        if (emojis.length !== 3) {
+          return res.status(400).send({
+            success: false,
+            error: 'Location emoji must be exactly 3 emoji characters',
+            got: emojis.length
           });
         }
+      }
+
+      // Validate federationEmoji (should be exactly 1 emoji)
+      if (federationEmoji) {
+        const emojiRegex = /[\u{1F1E6}-\u{1F1FF}]{2}|(?:[\u{1F3F4}\u{1F3F3}][\u{FE0F}]?(?:\u{200D}[\u{2620}\u{2695}\u{2696}\u{2708}\u{1F308}][\u{FE0F}]?)?)|(?:\p{Emoji_Presentation}|\p{Emoji}\uFE0F)(?:\u{200D}(?:\p{Emoji_Presentation}|\p{Emoji}\uFE0F))*/gu;
+        const emojis = federationEmoji.match(emojiRegex) || [];
 
-        if (!ownerData.sessionlessKeys) {
-          response.warnings.push({
-            severity: 'error',
-            message: 'Missing sessionlessKeys in owner.json',
-            fix: 'BDO operations will fail without sessionless keys'
+        if (emojis.length !== 1) {
+          return res.status(400).send({
+            success: false,
+            error: 'Federation emoji must be exactly 1 emoji character',
+            got: emojis.length
           });
         }
+      }
+
+      const config = loadPluginConfig();
 
-        res.send(response);
+      // Update config with provided values
+      if (locationEmoji !== undefined) config.locationEmoji = locationEmoji;
+      if (federationEmoji !== undefined) config.federationEmoji = federationEmoji;
+
+      const saved = savePluginConfig(config);
+
+      if (saved) {
+        res.send({
+          success: true,
+          config: config,
+          message: 'Configuration saved successfully'
+        });
       } else {
-        res.status(404).send({
-          error: 'Owner configuration not found',
-          warnings: [{
-            severity: 'error',
-            message: 'owner.json file not found',
-            fix: 'Create ~/.wiki/status/owner.json with locationEmoji and sessionlessKeys'
-          }]
+        res.status(500).send({
+          success: false,
+          error: 'Failed to save configuration'
         });
       }
     } catch (err) {
-      console.error('Error reading owner.json:', err);
+      console.error('Error saving plugin config:', err);
       res.status(500).send({
-        error: 'Failed to load base emoji',
+        success: false,
+        error: 'Failed to save configuration',
         message: err.message
       });
     }