wiggum-cli 0.17.2 → 0.18.3

package/dist/templates/prompts/PROMPT_review_auto.md.tmpl

@@ -11,6 +11,34 @@ Capture any review feedback patterns for future iterations.
 All implementation and E2E tasks are complete. Create PR and request review.
 Complete ALL steps in a single pass — do not end the session between steps.
 
+### Step 0: Verify Spec Requirements
+Before creating the PR, verify the implementation meets the spec requirements and update spec files.
+
+1. Read @.ralph/specs/$FEATURE.md and for each requirement under "## Requirements":
+   - Check if it was implemented (review implementation plan tasks)
+   - Mark as `[x]` if complete, leave as `[ ]` if not implemented (add a note explaining why)
+
+2. For each item under "## Acceptance Criteria":
+   - Verify against implementation and test results
+   - Mark as `[x]` if verified, leave as `[ ]` with a note if not met
+
+3. Update spec status:
+   - Change `**Status:** Planned` (or `Draft`) to `**Status:** Completed` if all requirements met, or `**Status:** Partial` if some are missing
+   - Update `**Last Updated:**` to today's date
+
+4. Update @.ralph/specs/README.md Active Specs table:
+   - Update ONLY the row for $FEATURE (do NOT remove or modify other rows)
+   - Change status and update Last Updated date
+
+5. If any requirements were not fully met, add an "## Implementation Notes" section documenting gaps and reasons.
+
+6. Commit spec updates:
+   ```bash
+   git -C {{appDir}} add ../.ralph/specs/
+   git -C {{appDir}} commit -m "docs($FEATURE): verify spec requirements"
+   git -C {{appDir}} push origin feat/$FEATURE
+   ```
+
 ### Step 1: Verify Ready State
 1. Check all tasks are complete in implementation plan (no `- [ ]` items)
 2. Verify tests pass: `cd {{appDir}} && {{testCommand}}`
@@ -62,63 +90,37 @@ cd {{appDir}} && gh pr create --base main --head feat/$FEATURE \
 
 Closes #[Read the source issue number from the spec file metadata or context section]
 
-Generated with Claude Code
+Generated with Wiggum Loop
 EOF
 )"
 ```
 
-### Step 4: Request Claude Code Review
-
-Run automated code review using Claude Code CLI:
-
-```bash
-# Check if Claude Code CLI is installed
-if ! command -v claude &> /dev/null; then
-    echo "WARNING: Claude Code CLI not installed. Manual review needed."
-    cd {{appDir}} && gh pr comment --body "Manual review requested - Claude Code CLI not available. Install: https://docs.anthropic.com/en/docs/claude-code/overview"
-else
-    echo "Running Claude Code review..."
-
-    cd {{appDir}} && claude -p "You are reviewing a PR for the $FEATURE feature.
-
-Review the git diff against main and check:
-- Code quality and patterns consistency
-- Test coverage adequacy
-- Potential bugs or edge cases
-- Security concerns (injection, XSS, etc.)
-- Performance implications
-- Error handling completeness
-
-Run: git diff main
-
-Then:
-1. Post your complete review as a comment on the PR using:
-   gh pr comment --body '<your review in markdown>'
-   Format the comment with: a summary, specific issues with file:line refs (if any), and the verdict.
-2. Print your final verdict as the LAST line of stdout. Print exactly one of:
-   VERDICT: APPROVED
-   VERDICT: NOT APPROVED
-   This line is parsed by the automation — do not omit it."
-fi
-```
-
-After the review completes, check its output:
-- If it contains "VERDICT: APPROVED", echo that line so the automation detects it:
-  ```bash
-  echo "VERDICT: APPROVED"
-  ```
-- If issues were found, echo:
-  ```bash
-  echo "VERDICT: NOT APPROVED"
-  ```
+### Step 4: Run Automated Review
+
+Use the current review CLI session (`$REVIEW_CLI`) to perform a full review:
+
+1. Review `git diff main` for:
+   - Code quality and consistency
+   - Test coverage and missing tests
+   - Potential bugs and edge cases
+   - Security risks (injection, auth, data exposure)
+   - Performance and error handling
+2. Post review feedback to the PR with `gh pr comment --body ...`
+3. Print your final verdict as the **LAST** line of stdout, exactly one of:
+   - `VERDICT: APPROVED`
+   - `VERDICT: NOT APPROVED`
+4. Before printing `VERDICT: APPROVED`, wait for CI to complete and pass:
+   - Run `cd {{appDir}} && gh pr checks feat/$FEATURE --watch --interval 10`
+   - If checks are pending, keep waiting
+   - If any check fails, output `VERDICT: NOT APPROVED` and list failing checks
 
 **Handle review feedback:**
-- If Claude outputs "VERDICT: APPROVED" -> Done. The PR is ready for manual merge by the user.
-- If Claude lists issues:
+- If verdict is `VERDICT: APPROVED` -> Done. The PR is ready for manual merge by the user.
+- If verdict is `VERDICT: NOT APPROVED`:
   1. Address each issue with code fixes
   2. Commit: `git -C {{appDir}} add -A && git -C {{appDir}} commit -m "fix($FEATURE): address review feedback"`
   3. Push: `git -C {{appDir}} push origin feat/$FEATURE`
-  4. Re-run the Claude review command above
+  4. Re-run this review step
 - Max 3 review iterations before requiring manual intervention
 
 ### Step 5: Final Summary
@@ -133,6 +135,7 @@ no implementation found" so the harness can trigger a new implementation iterati
 
 ## Rules
 - **NEVER approve if any tests are failing.** Output "VERDICT: NOT APPROVED — test failures" if any tests fail.
+- **NEVER approve while CI checks are pending/failing.** Wait until checks complete and pass.
 - Do NOT merge the PR — auto mode only reviews, the user merges
 - Do NOT implement missing features — only review and fix minor issues
 - Address ALL review comments before marking as approved
@@ -143,7 +146,7 @@ no implementation found" so the harness can trigger a new implementation iterati
 - **gh: command not found** -> Install GitHub CLI: `brew install gh`
 - **gh auth error** -> Run: `gh auth login`
 - **PR already exists** -> Use: `gh pr view` to see status
-- **Claude Code CLI not installed** -> Install: `npm install -g @anthropic-ai/claude-code`
+- **Review CLI missing** -> Install the configured `$REVIEW_CLI` binary and retry
 
 ## Learning Capture
 If the review revealed patterns worth remembering, append to @.ralph/LEARNINGS.md:

package/dist/templates/prompts/PROMPT_review_manual.md.tmpl

@@ -11,6 +11,34 @@ Capture any review feedback patterns for future iterations.
 All implementation and E2E tasks are complete. Create PR for manual review.
 Complete ALL steps in a single pass — do not end the session between steps.
 
+### Step 0: Verify Spec Requirements
+Before creating the PR, verify the implementation meets the spec requirements and update spec files.
+
+1. Read @.ralph/specs/$FEATURE.md and for each requirement under "## Requirements":
+   - Check if it was implemented (review implementation plan tasks)
+   - Mark as `[x]` if complete, leave as `[ ]` if not implemented (add a note explaining why)
+
+2. For each item under "## Acceptance Criteria":
+   - Verify against implementation and test results
+   - Mark as `[x]` if verified, leave as `[ ]` with a note if not met
+
+3. Update spec status:
+   - Change `**Status:** Planned` (or `Draft`) to `**Status:** Completed` if all requirements met, or `**Status:** Partial` if some are missing
+   - Update `**Last Updated:**` to today's date
+
+4. Update @.ralph/specs/README.md Active Specs table:
+   - Update ONLY the row for $FEATURE (do NOT remove or modify other rows)
+   - Change status and update Last Updated date
+
+5. If any requirements were not fully met, add an "## Implementation Notes" section documenting gaps and reasons.
+
+6. Commit spec updates:
+   ```bash
+   git -C {{appDir}} add ../.ralph/specs/
+   git -C {{appDir}} commit -m "docs($FEATURE): verify spec requirements"
+   git -C {{appDir}} push origin feat/$FEATURE
+   ```
+
 ### Step 1: Verify Ready State
 1. Check all tasks are complete in implementation plan (no `- [ ]` items)
 2. Verify tests pass: `cd {{appDir}} && {{testCommand}}`
@@ -62,7 +90,7 @@ cd {{appDir}} && gh pr create --base main --head feat/$FEATURE \
 
 Closes #[Read the source issue number from the spec file metadata or context section]
 
-Generated with Claude Code
+Generated with Wiggum Loop
 EOF
 )"
 ```
@@ -78,7 +106,7 @@ The feature branch has been prepared and pushed. A pull request has been created
 2. Address any review comments
 3. Merge when approved
 
-Note: Spec status updates are handled in the Spec Verification phase before PR creation.
+Note: Spec status updates are handled in Step 0 above, before PR creation.
 
 ## Rules
 - Manual review mode stops after PR creation

package/dist/templates/prompts/PROMPT_review_merge.md.tmpl

@@ -11,6 +11,34 @@ Capture any review feedback patterns for future iterations.
 All implementation and E2E tasks are complete. Create PR, review, and merge.
 Complete ALL steps in a single pass — do not end the session between steps.
 
+### Step 0: Verify Spec Requirements
+Before creating the PR, verify the implementation meets the spec requirements and update spec files.
+
+1. Read @.ralph/specs/$FEATURE.md and for each requirement under "## Requirements":
+   - Check if it was implemented (review implementation plan tasks)
+   - Mark as `[x]` if complete, leave as `[ ]` if not implemented (add a note explaining why)
+
+2. For each item under "## Acceptance Criteria":
+   - Verify against implementation and test results
+   - Mark as `[x]` if verified, leave as `[ ]` with a note if not met
+
+3. Update spec status:
+   - Change `**Status:** Planned` (or `Draft`) to `**Status:** Completed` if all requirements met, or `**Status:** Partial` if some are missing
+   - Update `**Last Updated:**` to today's date
+
+4. Update @.ralph/specs/README.md Active Specs table:
+   - Update ONLY the row for $FEATURE (do NOT remove or modify other rows)
+   - Change status and update Last Updated date
+
+5. If any requirements were not fully met, add an "## Implementation Notes" section documenting gaps and reasons.
+
+6. Commit spec updates:
+   ```bash
+   git -C {{appDir}} add ../.ralph/specs/
+   git -C {{appDir}} commit -m "docs($FEATURE): verify spec requirements"
+   git -C {{appDir}} push origin feat/$FEATURE
+   ```
+
 ### Step 1: Verify Ready State
 1. Check all tasks are complete in implementation plan (no `- [ ]` items)
 2. Verify tests pass: `cd {{appDir}} && {{testCommand}}`
@@ -62,63 +90,37 @@ cd {{appDir}} && gh pr create --base main --head feat/$FEATURE \
 
 Closes #[Read the source issue number from the spec file metadata or context section]
 
-Generated with Claude Code
+Generated with Wiggum Loop
 EOF
 )"
 ```
 
-### Step 4: Request Claude Code Review
-
-Run automated code review using Claude Code CLI:
-
-```bash
-# Check if Claude Code CLI is installed
-if ! command -v claude &> /dev/null; then
-    echo "WARNING: Claude Code CLI not installed. Manual review needed."
-    cd {{appDir}} && gh pr comment --body "Manual review requested - Claude Code CLI not available. Install: https://docs.anthropic.com/en/docs/claude-code/overview"
-else
-    echo "Running Claude Code review..."
-
-    cd {{appDir}} && claude -p "You are reviewing a PR for the $FEATURE feature.
-
-Review the git diff against main and check:
-- Code quality and patterns consistency
-- Test coverage adequacy
-- Potential bugs or edge cases
-- Security concerns (injection, XSS, etc.)
-- Performance implications
-- Error handling completeness
-
-Run: git diff main
-
-Then:
-1. Post your complete review as a comment on the PR using:
-   gh pr comment --body '<your review in markdown>'
-   Format the comment with: a summary, specific issues with file:line refs (if any), and the verdict.
-2. Print your final verdict as the LAST line of stdout. Print exactly one of:
-   VERDICT: APPROVED
-   VERDICT: NOT APPROVED
-   This line is parsed by the automation — do not omit it."
-fi
-```
-
-After the review completes, check its output:
-- If it contains "VERDICT: APPROVED", echo that line so the automation detects it:
-  ```bash
-  echo "VERDICT: APPROVED"
-  ```
-- If issues were found, echo:
-  ```bash
-  echo "VERDICT: NOT APPROVED"
-  ```
+### Step 4: Run Automated Review
+
+Use the current review CLI session (`$REVIEW_CLI`) to perform a full review:
+
+1. Review `git diff main` for:
+   - Code quality and consistency
+   - Test coverage and missing tests
+   - Potential bugs and edge cases
+   - Security risks (injection, auth, data exposure)
+   - Performance and error handling
+2. Post review feedback to the PR with `gh pr comment --body ...`
+3. Print your final verdict as the **LAST** line of stdout, exactly one of:
+   - `VERDICT: APPROVED`
+   - `VERDICT: NOT APPROVED`
+4. Before printing `VERDICT: APPROVED`, wait for CI to complete and pass:
+   - Run `cd {{appDir}} && gh pr checks feat/$FEATURE --watch --interval 10`
+   - If checks are pending, keep waiting
+   - If any check fails, output `VERDICT: NOT APPROVED` and list failing checks
 
 **Handle review feedback:**
-- If Claude outputs "VERDICT: APPROVED" -> Proceed to Step 5 (rebase and merge)
-- If Claude lists issues:
+- If verdict is `VERDICT: APPROVED` -> Proceed to Step 5 (rebase and merge)
+- If verdict is `VERDICT: NOT APPROVED`:
   1. Address each issue with code fixes
   2. Commit: `git -C {{appDir}} add -A && git -C {{appDir}} commit -m "fix($FEATURE): address review feedback"`
   3. Push: `git -C {{appDir}} push origin feat/$FEATURE`
-  4. Re-run the Claude review command above
+  4. Re-run this review step
 - Max 3 review iterations before requiring manual intervention
 
 ### Step 5: Rebase Before Merge (for Parallel Execution)
@@ -142,26 +144,13 @@ Push rebased branch:
 cd {{appDir}} && git push --force-with-lease origin feat/$FEATURE
 ```
 
-### Step 6: Merge PR
-**Pre-merge gate:** Confirm ALL tests pass. Run `cd {{appDir}} && {{testCommand}}` one final time. If ANY test fails, STOP — do not merge. Fix the failures first, then re-run.
-
-When Claude review is approved, all tests pass, and branch is rebased:
-```bash
-cd {{appDir}} && gh pr merge --squash --delete-branch
-```
-
-### Step 7: Post-Merge Cleanup
-1. If using worktree, remove it:
-   ```bash
-   # Only if this feature used a worktree ({{appDir}}-$FEATURE directory exists)
-   git -C {{appDir}} worktree remove "../{{appDir}}-$FEATURE" 2>/dev/null || true
-   ```
-2. Checkout main and pull:
-   ```bash
-   git -C {{appDir}} checkout main && git -C {{appDir}} pull
-   ```
+### Step 6: Hand Off For Merge
+After review is approved, CI is green, and branch is rebased:
+- Do **NOT** run `gh pr merge` in this prompt.
+- The loop harness performs the final merge after enforcing CI and post-approval gates.
+- End this review session after handoff. Do not run local post-merge cleanup commands here.
 
-Note: Spec status updates are handled in the Spec Verification phase before PR creation.
+Note: Spec status updates are handled in Step 0 above, before PR creation.
 
 ## IMPORTANT: Review scope
 If you discover that no implementation code exists (empty diff, no source files changed),
@@ -170,7 +159,8 @@ no implementation found" so the harness can trigger a new implementation iterati
 
 ## Rules
 - **NEVER merge if any tests are failing.** If tests fail after rebase, fix them first. If unfixable, output "VERDICT: NOT APPROVED — test failures" and stop.
-- Do NOT merge without Claude Code approval
+- Do NOT merge without explicit review approval (`VERDICT: APPROVED`)
+- Do NOT merge directly in this prompt; hand off to the harness after approval
 - Do NOT implement missing features — only review and fix minor issues
 - Address ALL review comments before merging
 - Use squash merge to keep history clean
@@ -181,7 +171,7 @@ no implementation found" so the harness can trigger a new implementation iterati
 - **gh: command not found** -> Install GitHub CLI: `brew install gh`
 - **gh auth error** -> Run: `gh auth login`
 - **PR already exists** -> Use: `gh pr view` to see status
-- **Claude Code CLI not installed** -> Install: `npm install -g @anthropic-ai/claude-code`
+- **Review CLI missing** -> Install the configured `$REVIEW_CLI` binary and retry
 - **Rebase conflicts** -> Resolve carefully, re-run all tests after
 
 ## Learning Capture

package/dist/templates/prompts/PROMPT_verify.md.tmpl

@@ -1,3 +1,10 @@
+> **REFERENCE ONLY — NOT INVOKED BY LOOP**
+> This file is not executed by `feature-loop.sh`. Verification responsibilities
+> (spec status updates, acceptance criteria checks, README updates) have been
+> merged into the review prompt templates (`PROMPT_review_manual.md`,
+> `PROMPT_review_auto.md`, `PROMPT_review_merge.md`) under "Step 0: Verify Spec
+> Requirements". This file is retained as a reference for the verification steps.
+
 ## Context
 Study @.ralph/specs/$FEATURE.md for original specification.
 Study @.ralph/specs/$FEATURE-implementation-plan.md for completed tasks.

package/dist/templates/root/README.md.tmpl

@@ -12,7 +12,7 @@ This directory contains configuration and guidance for AI-assisted development o
 |   |-- PROMPT.md                # Main implementation prompt
 |   |-- PROMPT_feature.md        # Feature planning prompt
 |   |-- PROMPT_e2e.md            # E2E testing prompt
-|   |-- PROMPT_verify.md         # Verification prompt
+|   |-- PROMPT_verify.md         # Verification prompt (reference only, not invoked by loop)
 |   |-- PROMPT_review_manual.md  # PR review prompt (manual)
 |   |-- PROMPT_review_auto.md    # PR review prompt (auto merge)
 |-- guides/            # Reference documentation
@@ -39,8 +39,7 @@ Reference these files in your prompts:
 1. **Plan**: Use `PROMPT_feature.md` to create implementation plan
 2. **Implement**: Use `PROMPT.md` for iterative task completion
 3. **Test**: Use `PROMPT_e2e.md` for browser-based testing
-4. **Verify**: Use `PROMPT_verify.md` to verify spec requirements
-5. **Review**: Use `PROMPT_review_manual.md` (manual) or `PROMPT_review_auto.md` (auto merge) to create PR
+4. **Review**: Use `PROMPT_review_manual.md` (manual) or `PROMPT_review_auto.md` (auto merge) to create PR — includes spec verification (Step 0)
 
 ### Specs