wicked-crew 0.9.1 → 0.9.3

package/dist/core/adapter.js

@@ -11,7 +11,7 @@ import { randomUUID } from 'node:crypto';
 import { DEFAULT_SETTINGS } from './types.js';
 import { BASE_SKILL_REF_SHAPE } from '../skills/base-skill.js';
 import { execCapped } from './exec.js';
-import { BUG_FIX_SWEEP_INSTRUCTIONS, composeDeliverWorkflow, DELIVER_PHASE_ID, deliverPresetStep, deliverIdentityFor, deliverRepoFor, EVIDENCE_FLOOR_PIN, ghSignedInLogins, isGitHubLogin, readDeliverOriginUrl } from './deliver.js';
+import { BUG_FIX_SWEEP_INSTRUCTIONS, composeDeliverWorkflow, DELIVER_PHASE_ID, deliverPresetStep, deliverIdentityFor, deliverRepoFor, EVIDENCE_FLOOR_PIN, isGitHubLogin, pushIdentityOf, readDeliverOriginUrl } from './deliver.js';
 import { engineCampaignDef, engineRosterJson } from './engine-roster.js';
 import { QE_AUTHOR_TESTS_WORKFLOW_DEF } from '../qe/author-workflow.js';
 import { CAMPAIGN_WORKFLOW_PREFIX } from '../campaigns/plan.js';
@@ -349,11 +349,22 @@ function addonSupportsExtraWriteRoots() {
 function addonSupportsExcludeSeats() {
     return addonAtLeast(0, 7, 35);
 }
+/** Does the installed addon judge a plan or preset launch's declared deliverables
+ *  (`LaunchOptions.deliverables`, wicked-core#858, >= 0.7.48)? Same doctrine: an older addon
+ *  ignores the field, and the run would never be held to its deliverable. */
+export function addonSupportsLaunchDeliverables() {
+    return addonAtLeast(0, 7, 48);
+}
 /** Does the installed addon carry the assurance contract (`LaunchOptions.reducedAssurance`,
  *  wicked-core#850, >= 0.7.46)? Same doctrine. */
 export function addonSupportsReducedAssurance() {
     return addonAtLeast(0, 7, 46);
 }
+/** Does the installed addon carry the QE acceptance decision (`LaunchOptions.skipQeAcceptanceReason`
+ *  / `forceQeAcceptance`, `assurance.qe`; QE-IN-APP-WORKFLOWS, >= 0.7.49)? Same doctrine. */
+export function addonSupportsQeOverride() {
+    return addonAtLeast(0, 7, 49);
+}
 /**
  * Does the installed addon understand `LaunchOptions.projectGraph` (≥ 0.7.1)?
  *
@@ -457,6 +468,10 @@ const CORE_SEEDED_WORKFLOWS = new Set(['feature', 'bug', 'migration']);
 // (see CORE_SEEDED_WORKFLOWS).
 // `is_system` is NOT spelled on these defs: `withSystemFlag` stamps it from `SYSTEM_WORKFLOWS`
 // (core/run-identity.ts), the one list keyed by name that also classifies served runs (seam X2).
+/** QE-IN-APP-WORKFLOWS (operator ruling 2026-10-10): what a workflow that makes application changes
+ *  requires — the defaults plus `qe_acceptance` — exactly as core's `feature`/`bug`/`migration`/
+ *  `mcp-server` defs declare it (the mirror guards compare field for field). */
+const APP_CHANGE_INSTRUMENTS = ['distinct_evaluator', 'judge', 'qe_acceptance'];
 export const BUILTIN_WORKFLOWS = [
     {
         id: 'feature',
@@ -468,6 +483,7 @@ export const BUILTIN_WORKFLOWS = [
             { id: 'test', kind: 'test', gate_type: 'execution', gate: { human_confirm_if: 'verdict_not_pass' }, executes_code: false, verified_evidence: true, required_deliverables: [], depends_on: ['build'], role: 'neutral', skill_ref: null, allowed_skills: [], validator_pin: EVIDENCE_FLOOR_PIN },
             { id: 'review', kind: 'review', gate_type: 'execution', gate: 'auto', executes_code: false, verified_evidence: false, required_deliverables: [], depends_on: ['test'], role: 'neutral', skill_ref: null, allowed_skills: [], validator_pin: null },
         ],
+        required_instruments: APP_CHANGE_INSTRUMENTS,
     },
     {
         id: 'bug',
@@ -480,6 +496,7 @@ export const BUILTIN_WORKFLOWS = [
             { id: 'fix', kind: 'build', instructions: BUG_FIX_SWEEP_INSTRUCTIONS, gate_type: 'execution', gate: 'auto', executes_code: true, verified_evidence: false, required_deliverables: [], depends_on: ['reproduce'], role: 'creator', skill_ref: null, allowed_skills: [], validator_pin: EVIDENCE_FLOOR_PIN },
             { id: 'verify', kind: 'test', gate_type: 'execution', gate: { human_confirm_if: 'verdict_not_pass' }, executes_code: false, verified_evidence: true, required_deliverables: [], depends_on: ['fix'], role: 'evaluator', skill_ref: null, allowed_skills: [], validator_pin: EVIDENCE_FLOOR_PIN },
         ],
+        required_instruments: APP_CHANGE_INSTRUMENTS,
     },
     {
         id: 'migration',
@@ -490,6 +507,7 @@ export const BUILTIN_WORKFLOWS = [
             { id: 'verify', kind: 'test', gate_type: 'execution', gate: { human_confirm_if: 'verdict_not_pass' }, executes_code: false, verified_evidence: true, required_deliverables: [], depends_on: ['cutover'], role: 'evaluator', skill_ref: null, allowed_skills: [], validator_pin: EVIDENCE_FLOOR_PIN },
             { id: 'cleanup', kind: 'build', gate_type: null, gate: 'auto', executes_code: false, verified_evidence: false, required_deliverables: [], depends_on: ['verify'], role: 'neutral', skill_ref: null, allowed_skills: [], validator_pin: null },
         ],
+        required_instruments: APP_CHANGE_INSTRUMENTS,
     },
     {
         // capture-learnings (DES-MEM-FACETED-001 write side, onboarding): survey a just-indexed repo,
@@ -646,6 +664,7 @@ export const BUILTIN_WORKFLOWS = [
             { id: "install-plan", kind: "build", gate_type: "execution", gate: "auto", executes_code: false, verified_evidence: false, required_deliverables: [], depends_on: ["security-review", "observability-review"], role: "neutral", skill_ref: null, allowed_skills: [], validator_pin: null, executor: { "type": "tool", "cmd": ["bash", "-c", "exec \"${WICKED_GARDEN_ROOT:?the engine handed this Tool phase no garden root; refusing to resolve wicked-garden from PATH}/scripts/wicked-garden\" run scripts/mcp/install.py --from-run --dry-run --json"] }, instructions: "Plan the install without writing anything: resolve, on this host and as the daemon user, every file and directory each install choice would write — Install for workers (the default: the staged copy under ~/.wicked/mcp-servers/<key>/current, the wicked-crew MCP tools registry and the worker homes' CLI configurations under ~/.wicked-worker) and Also install into my CLIs (the worker set plus your own CLI configurations, such as ~/.claude.json, ~/.codex/config.toml and the opencode configuration) — and print them as one JSON plan line, so the install's consent gate can list them before you answer." },
             { id: "install", kind: "build", gate_type: "execution", gate: "consent_before", executes_code: false, verified_evidence: false, required_deliverables: [], depends_on: ["install-plan"], role: "neutral", skill_ref: null, allowed_skills: [], validator_pin: null, executor: { "type": "tool", "cmd": ["bash", "-c", "exec \"${WICKED_GARDEN_ROOT:?the engine handed this Tool phase no garden root; refusing to resolve wicked-garden from PATH}/scripts/wicked-garden\" run scripts/mcp/install.py --from-run --target \"${WICKED_CONSENT_CHOICE:?the consent gate recorded no install choice}\" --json"] }, instructions: "Install for running — or update the installed copy when this server key is already installed. Nothing has been installed yet: this asks before the install runs, and each answer lists exactly the files it would write (from the install-plan dry run). Install for workers (the default) builds the server from this run's tree into ~/.wicked/mcp-servers/<key>/current, registers it in wicked-crew's MCP tools under its key (an existing entry is re-registered in place; the first use of a changed tool still asks) and writes it into the worker homes' CLI MCP configurations — program-owned files only. Also install into my CLIs does the same and also writes it into your own CLI MCP configurations through wicked-installer (one entry per key, never a second copy; CLI entries carry no secret). Both probe tools/list. The one secret variable <SERVER>_TOKEN is named, never written: when the daemon cannot resolve it the registration is reported as pending with the remedy. Writes happen on the daemon host as the daemon user. Decline for not now — the pull request already delivered stays as it is." },
         ],
+        required_instruments: APP_CHANGE_INSTRUMENTS,
     },
 ].map(withSystemFlag);
 /**
@@ -1321,18 +1340,32 @@ export class CoreAdapter {
     }
     /** Whether this engine carries the plan approval gate (DES-TEAMING-002 T3) — see
      *  [`engineSupportsPlanLaunch`]. An instance method so a partial-stub adapter can say either. */
+    /**
+     * (wicked-core#858, X-MIG M9) Hand a plan or preset launch's declared deliverables to the engine
+     * (`LaunchOptions.deliverables`). Fails CLOSED on an addon before the field (napi ignores it, so
+     * the run would never be held to them).
+     */
+    passLaunchDeliverables(opts, deliverables, what) {
+        if (deliverables.length === 0)
+            return;
+        if (!addonSupportsLaunchDeliverables()) {
+            throw new Error(`requireDeliverables on ${what} needs wicked-core-ts >= 0.7.48 (LaunchOptions.deliverables, ` +
+                'wicked-core#858); the installed addon would drop them and the run would not be held to them');
+        }
+        opts.deliverables = deliverables;
+    }
     supportsPlanLaunch() {
         return engineSupportsPlanLaunch();
     }
     /**
      * (crew#549, crew#737) The CONFIGURED deliver identity for a launch: the repository's own pin
-     * (`deliverIdentityByRepo[repoRef]`) else the daemon-wide `deliverIdentityLogin`, and — for a
-     * delivering launch — whether that login is signed in to gh on this machine (a bounded
-     * `gh auth status`). RETURNED, never stashed on the adapter: two concurrent delivering launches
+     * (`deliverIdentityByRepo[repoRef]`) else the daemon-wide `deliverIdentityLogin`. Whether that
+     * login has a gh token here is the credential preflight's question ({@link deliverCredentialsProbe},
+     * crew#940). RETURNED, never stashed on the adapter: two concurrent delivering launches
      * on different repositories must not read each other's identity (the F2 origin rule). A LOGIN
      * only: no token is ever read here. `login: ''` ⇒ nothing configured (`GH_ACCOUNT` decides).
      */
-    async resolveDeliverIdentity(repoRef, probe) {
+    async resolveDeliverIdentity(repoRef) {
         let login = '';
         let source = 'setting';
         try {
@@ -1343,12 +1376,7 @@ export class CoreAdapter {
             // failing the launch — the deliver script still cross-checks gh against git's credential.
             login = '';
         }
-        let signedIn = null;
-        if (probe && login !== '') {
-            const logins = await ghSignedInLogins().catch(() => null);
-            signedIn = logins === null ? null : logins.includes(login);
-        }
-        return { login, source, signedIn };
+        return { login, source };
     }
     /**
      * The origin the deliver push will actually go to (F2) so the deliver GATE CARD says what will
@@ -1402,7 +1430,6 @@ export class CoreAdapter {
             originUrl,
             deliverIdentity: identity.login,
             deliverIdentitySource: identity.source,
-            deliverIdentitySignedIn: identity.signedIn,
             credentials,
         });
     }
@@ -1410,12 +1437,12 @@ export class CoreAdapter {
     async launchRun(input) {
         // (crew#549, crew#737) Read the configured deliver identity BEFORE anything composes the deliver
         // phase: the compose paths below are synchronous and bake it into the script. Launch-local.
-        const deliverIdentity = await this.resolveDeliverIdentity(input.repoRef, input.deliver === 'pr');
+        const deliverIdentity = await this.resolveDeliverIdentity(input.repoRef);
         // (F2) And the origin the push would go to — read once, for the gate card's target sentence.
         // Only a delivering launch composes a deliver phase, so only a delivering launch pays for it.
         const deliverOriginUrl = input.deliver === 'pr' ? await this.resolveDeliverOrigin(input.repoRef) : null;
         // (crew#720) And whether the provider credential is there — presence only, read once.
-        const deliverCredentials = input.deliver === 'pr' ? await deliverCredentialsProbe(deliverOriginUrl, process.env) : null;
+        const deliverCredentials = input.deliver === 'pr' ? await deliverCredentialsProbe(deliverOriginUrl, process.env, undefined, pushIdentityOf(deliverIdentity.login)) : null;
         const opts = {
             problem: input.problem,
             sessionId: input.sessionId,
@@ -1489,6 +1516,19 @@ export class CoreAdapter {
             }
             opts.reducedAssurance = true;
         }
+        if (input.skipQeAcceptanceReason !== undefined || input.forceQeAcceptance === true) {
+            // Fail CLOSED on an old addon (napi ignores undeclared fields): a dropped skip would leave a
+            // run the operator meant to skip refusing its delivery, and a dropped force would let a score
+            // waive what the operator required — either way the record and the run would disagree.
+            if (!addonSupportsQeOverride()) {
+                throw new Error('skipQeAcceptance / forceQeAcceptance need wicked-core-ts >= 0.7.49; the installed addon ' +
+                    'has no QE acceptance decision to apply them to');
+            }
+            if (input.skipQeAcceptanceReason !== undefined)
+                opts.skipQeAcceptanceReason = input.skipQeAcceptanceReason;
+            if (input.forceQeAcceptance === true)
+                opts.forceQeAcceptance = true;
+        }
         // SAFETY NET (grounding follow-on #1): ANY project-filed launch that did not already resolve a
         // project-graph binding gets one here, so no future project-filed caller can silently ship a run
         // that sees only its own repo — the exact gap the chat/edit seams had (projectId filed WITHOUT
@@ -1539,13 +1579,11 @@ export class CoreAdapter {
             if (input.workflow !== undefined) {
                 throw new Error('a launch carries a plan or names a workflow (a preset), not both');
             }
-            if ((input.requireDeliverables ?? []).length > 0) {
-                throw new Error('requireDeliverables with a plan is refused: the deliverable floor has no engine-side ' +
-                    'step yet — launch the plan without it');
-            }
             if (!this.supportsPlanLaunch())
                 throw new PlanLaunchUnsupportedError('A plan launch');
             opts.planJson = JSON.stringify(input.plan);
+            // (wicked-core#858, X-MIG M9) The engine judges a plan's declared deliverables itself.
+            this.passLaunchDeliverables(opts, input.requireDeliverables ?? [], 'a plan');
             // T8: a delivering plan hands the engine its deliver step, exactly as a preset launch does.
             if (input.deliver === 'pr') {
                 opts.deliverStepJson = JSON.stringify(this.deliverStep(null, [], input, deliverOriginUrl, deliverIdentity, deliverCredentials));
@@ -1560,14 +1598,18 @@ export class CoreAdapter {
             (input.deliver === 'pr' || requireDeliverablesAll.length > 0) &&
             (await this.presetNamed(input.workflow, input.projectId)) !== null;
         if (namesPreset && input.workflow !== undefined) {
-            if (requireDeliverablesAll.length > 0) {
-                throw new Error(`requireDeliverables on a preset launch ('${input.workflow}') is refused: the deliverable ` +
-                    'floor would have to be composed into a per-run def, which skips the plan_approval gate');
-            }
             if (!this.supportsPlanLaunch())
                 throw new PlanLaunchUnsupportedError('Delivering a preset launch');
-            const step = this.deliverStep(input.workflow, this.getWorkflow(input.workflow)?.phases ?? [], input, deliverOriginUrl, deliverIdentity, deliverCredentials);
-            opts.deliverStepJson = JSON.stringify(step);
+            // (wicked-core#858, X-MIG M9) A preset launch's deliverables ride the launch: the engine joins
+            // them to the plan's last creator step and its deliverable floor judges them — never a per-run
+            // def composed past the plan_approval gate.
+            this.passLaunchDeliverables(opts, requireDeliverablesAll, `a preset launch ('${input.workflow}')`);
+            // Only a DELIVERING preset gets the deliver step: a preset launched for its deliverables alone
+            // pushes nothing (codex r1 on #930).
+            if (input.deliver === 'pr') {
+                const step = this.deliverStep(input.workflow, this.getWorkflow(input.workflow)?.phases ?? [], input, deliverOriginUrl, deliverIdentity, deliverCredentials);
+                opts.deliverStepJson = JSON.stringify(step);
+            }
             opts.workflow = input.workflow;
         }
         else if (input.workflow !== undefined) {
@@ -1640,7 +1682,6 @@ export class CoreAdapter {
                         // own pin wins, and the card says when it is not signed in here.
                         deliverIdentity: deliverIdentity.login,
                         deliverIdentitySource: deliverIdentity.source,
-                        deliverIdentitySignedIn: deliverIdentity.signedIn,
                         // crew#720 — the provider credential preflight, said on the card before approval.
                         credentials: deliverCredentials,
                     });
@@ -1680,7 +1721,8 @@ export class CoreAdapter {
             // believing a PR opens at the end — the exact operator gap crew#293 closes.
             throw new Error('deliver: "pr" requires a workflow — a free-text run has no def to append the deliver phase to');
         }
-        else if ((input.requireDeliverables ?? []).length > 0) {
+        else if ((input.requireDeliverables ?? []).length > 0 && input.plan === undefined) {
+            // (A plan hands its deliverables to the engine above, wicked-core#858.)
             // Same rule for the floor (Copilot, #319): a caller that declares what a run MUST produce
             // and gets no enforcement is worse off than one that never declared it — it would watch a
             // free-text run complete and believe the artifacts were re-derived. There is no def to
@@ -2091,8 +2133,8 @@ export class CoreAdapter {
         // (F2) The preview shows the deliver step's gate-card text, so it reads the same origin the
         // launch would. Local to this call, like the launch's.
         const previewOriginUrl = opts.deliver === true ? await this.resolveDeliverOrigin(opts.repoRef) : null;
-        const previewIdentity = await this.resolveDeliverIdentity(opts.repoRef, opts.deliver === true);
-        const previewCredentials = opts.deliver === true ? await deliverCredentialsProbe(previewOriginUrl, process.env) : null;
+        const previewIdentity = await this.resolveDeliverIdentity(opts.repoRef);
+        const previewCredentials = opts.deliver === true ? await deliverCredentialsProbe(previewOriginUrl, process.env, undefined, pushIdentityOf(previewIdentity.login)) : null;
         const deliverStep = opts.deliver === true
             ? JSON.stringify(
             // The launch's own step for a plan (`deliverStep(null, [], input)`); the run id is a