wicked-crew 0.8.4 → 0.8.6

package/dist/api/routes.js

@@ -23,7 +23,7 @@ import { chatSeatAdmission } from './seat-standing.js';
 import { rosterWithStandingFactory } from './roster-standing.js';
 import { ChatTurnIndex } from './chat-turns.js';
 import { ChatScopeIndex, chatScopeDeps, chatScopeStatement, prepareChatScratch, removeChatScratch, namedKindRefusal, resolveChatScope, } from './chat-scope.js';
-import { AskPathIndex, answerStep } from './ask-paths.js';
+import { ASK_TURN_BUDGET_SECS, AskPathIndex, answerStep, isAskTurn } from './ask-paths.js';
 import { allowedRootsFor, isInsideRoot, openWithSystemDefault } from './open-path.js';
 import { InvalidDiffBaseError, MERGE_BASE_LITERAL, NotARegularFileError, UnresolvableDiffBaseError, branchDiff, isGitStopped, isPlainRef, readFileCapped, worktreeDiff, } from './run-files.js';
 import { DocRunIndex } from '../interactive/doc-run-index.js';
@@ -52,7 +52,7 @@ import { noEligibleSeatBody, parseNoEligibleSeat } from '../core/engine-roster.j
 import { ProjectSettingsStore } from '../projects/settings.js';
 import { isHumanOperator } from './watch-routes.js';
 import { boundOrigin, InteractiveBridgePool } from '../interactive/bridge-pool.js';
-import { composeDeliverText, configuredPublicOrigin, extractFollowUps, factsFromRun, FOLLOW_UPS_MAX, framedDeliverText, runUrlFor, } from '../core/deliver-text.js';
+import { composeDeliverText, configuredPublicOrigin, extractFollowUps, factsFromRun, reportsFromOutputs, FOLLOW_UPS_MAX, framedDeliverText, runUrlFor, } from '../core/deliver-text.js';
 import { deliverRepoFor, deliverTargetView, isGitHubLogin, readDeliverOriginUrl, resolvePullRequest as resolvePullRequestViaGh, } from '../core/deliver.js';
 import { registerInteractiveProxy } from '../interactive/proxy-routes.js';
 import { registerInteractiveDocDelete } from '../interactive/doc-delete-routes.js';
@@ -274,6 +274,8 @@ const RegisterRepoSchema = z
     /** crew#496 / crew#632: the launch surface and caller, recorded on the run's launch entry. */
     channel: z.enum(['studio', 'cli', 'api']).optional(),
     actor: z.string().min(1).max(256).optional(),
+    /** crew#552: `false` = this onboarding chains no capture-learnings run (a one-off). */
+    autoCapture: z.boolean().optional(),
 })
     .strict()
     .refine((d) => {
@@ -289,6 +291,8 @@ const OnboardBodySchema = z
     projectId: z.string().min(1).max(128).optional(),
     channel: z.enum(['studio', 'cli', 'api']).optional(),
     actor: z.string().min(1).max(256).optional(),
+    /** crew#552: `false` = this onboarding chains no capture-learnings run (a one-off). */
+    autoCapture: z.boolean().optional(),
 })
     .strict();
 /**
@@ -670,6 +674,15 @@ runtime = {}) {
     // no def ⇒ `runCanDeliver(view, null)` ⇒ candidate — byte-for-byte today's read.
     const canDeliver = runtime.canDeliver ??
         canDeliverResolver(() => (typeof adapter.listWorkflows === 'function' ? adapter.listWorkflows() : []), (m) => app.log.warn(m));
+    const deliveryResolver = runtime.deliveryResolver;
+    /** crew#851: await the shared resolution for every served view still inside the completion
+     *  window — BOUNDED (`READ_PATH_SETTLE_MS`): a hung engine read costs this poll the bound, not
+     *  the request; the run falls through to its stat-derived label until the read lands. */
+    const settleDeliveries = async (views) => {
+        if (deliveryResolver === undefined)
+            return;
+        await deliveryResolver.settle(views, runtime.deliverySettleMs);
+    };
     const deliveryCache = runtime.deliveryCache ??
         new DeliveryDerivationCache({
             listViews: () => adapter.sessionsDetail(),
@@ -775,6 +788,15 @@ runtime = {}) {
         }
         return out.slice(0, FOLLOW_UPS_MAX);
     };
+    /** crew#860: the creator and evaluator seats' final reports (and the recipe exit codes they
+     *  pasted), read from their captured output for the PR body's done-when evidence. Absent when
+     *  the adapter keeps no transcripts — the body then says the output could not be read. */
+    const seatReports = async (view) => {
+        if (typeof adapter.workOutput !== 'function')
+            return undefined;
+        const read = adapter.workOutput.bind(adapter);
+        return reportsFromOutputs(view, (u) => read(coreUnitId(view.session.id, u)));
+    };
     // The run-DTO joins (DES-UX-001 §8.2/§8.3, DES-UX-002 §7.2): `project_id` from the membership
     // record — `null` = genuinely unfiled, so the field is ALWAYS present on served runs —
     // `retry_of` from the lineage index and `guidance` from the guidance index, each set only
@@ -910,6 +932,17 @@ runtime = {}) {
         const chatId = runTimingIndex.chatIdFor(view.session.id);
         if (chatId !== undefined)
             view.session.chat_id = chatId;
+        // crew#552: the onboarding run a chained capture was launched from — ABSENT otherwise.
+        const chainedFrom = runTimingIndex.chainedFromOf(view.session.id);
+        if (chainedFrom !== undefined)
+            view.session.chained_from = chainedFrom;
+        // crew#854: an ask's run, and whether it waits at its TURN gate (answered by the next message,
+        // never a gate for the Needs-you count).
+        if (runTimingIndex.isAskPath(view.session.id)) {
+            view.session.ask_path = true;
+            if (isAskTurn(view))
+                view.session.ask_turn = true;
+        }
         return view;
     };
     // Resolved ONCE and shared by the project routes (which read/write `interactiveRoot`) and the
@@ -1423,6 +1456,7 @@ runtime = {}) {
         recordRunLaunched(audit, runTimingIndex, actorOf(req), runId, {
             workflow: 'onboarding',
             repoRef: repoId,
+            ...(opts.autoCapture === false ? { autoCapture: false } : {}),
             ...(opts.projectId !== undefined ? { projectId: opts.projectId } : {}),
             ...(opts.channel !== undefined ? { channel: opts.channel } : {}),
             ...(opts.actor !== undefined ? { actor: opts.actor } : {}),
@@ -1473,7 +1507,7 @@ runtime = {}) {
         const refused = await onboardRefusal();
         if (refused !== null)
             return reply.code(refused.status).send(refused.body);
-        const { name, rootPath, gitUrl, projectId, channel, actor } = parsed.data;
+        const { name, rootPath, gitUrl, projectId, channel, actor, autoCapture } = parsed.data;
         let repo;
         let runId;
         try {
@@ -1496,7 +1530,7 @@ runtime = {}) {
         catch (err) {
             return reply.code(400).send({ error: message(err) });
         }
-        const projectAttachError = await recordOnboardingLaunch(req, runId, repo.id, { projectId, channel, actor });
+        const projectAttachError = await recordOnboardingLaunch(req, runId, repo.id, { projectId, channel, actor, autoCapture });
         return reply.code(201).send({ repo, onboardRunId: runId, ...(projectAttachError !== undefined ? { projectAttachError } : {}) });
     });
     // Return the onboarding run id for a repo (so the UI can navigate to it).
@@ -1950,7 +1984,9 @@ runtime = {}) {
             : views.filter((v) => v.session.archived_at == null);
         const visible = doc === undefined ? unarchived : unarchived.filter((v) => docRuns.documentOf(v.session.id) === doc.trim());
         const ordered = sortActionableFirst(visible);
-        return { runs: (cap !== undefined ? ordered.slice(0, cap) : ordered).map(decorateRun) };
+        const served = cap !== undefined ? ordered.slice(0, cap) : ordered;
+        await settleDeliveries(served);
+        return { runs: served.map(decorateRun) };
     });
     // ── Run archival (crew#265) — write-off, not delete ────────────────────────
     const ArchiveSchema = z.object({
@@ -2010,6 +2046,7 @@ runtime = {}) {
         const run = views.find((v) => v.session.id === id);
         if (!run)
             return reply.code(404).send({ error: 'Run not found' });
+        await settleDeliveries([run]);
         return { run: decorateRun(run) };
     });
     // ── Deliver text (crew#524 / F-3R2-014) — the PR title + body a run's delivery carries ──
@@ -2027,11 +2064,13 @@ runtime = {}) {
         if (!run)
             return reply.code(404).send({ error: 'Run not found' });
         const followUps = await evaluatorFollowUps(run);
+        const reports = await seatReports(run);
         // The run's preset or workflow NAME, as the engine recorded it (seam X2).
         const text = composeDeliverText(factsFromRun(decorateRun(run), runUrlFor(configuredPublicOrigin(), id), {
             workflowId: runIdentityOf(run).name,
             revisesPr: retryIndex.revisesPrFor(id) ?? null,
             ...(followUps !== undefined ? { followUps } : {}),
+            ...(reports !== undefined ? { reports } : {}),
         }));
         return reply.type('text/plain; charset=utf-8').send(framedDeliverText(text));
     });
@@ -2187,6 +2226,7 @@ runtime = {}) {
                         revisesPr = { number: revising.number, headRef: again.pr.headRef, url: again.pr.url };
                     }
                     const followUps = await evaluatorFollowUps(run);
+                    const reports = await seatReports(run);
                     result = await deliverExec(workdir, s.problem ?? undefined, {
                         runId: id,
                         apiOrigin: origin,
@@ -2194,6 +2234,7 @@ runtime = {}) {
                             workflowId: workflowName,
                             revisesPr: revisesPr === null ? null : { number: revisesPr.number, url: revisesPr.url },
                             ...(followUps !== undefined ? { followUps } : {}),
+                            ...(reports !== undefined ? { reports } : {}),
                         }),
                         revisesPr,
                         // R1 (Copilot on crew#736): the post-hoc delivery binds `gh pr create --repo` to the
@@ -2436,7 +2477,7 @@ runtime = {}) {
             const admissionKind = scope.kind === 'repos' && scope.repos.length === 1 ? 'path-bound' : 'path';
             const refused = [];
             // The standing roster, read ONCE: the default admission below and the engine-drop
-            // attribution after `chatOpen` both consult it (F-A45-011).
+            // attribution after the engine's open both consult it (F-A45-011).
             const standing = rosterWithStanding();
             // ASK-C1: admission applies to the DEFAULT roster and to seats NAMED in `clis` alike — the
             // engine no longer refuses a seat at open (nothing is warmed), so this is the only gate
@@ -2663,7 +2704,8 @@ runtime = {}) {
                 ...(path.runId !== undefined ? { runId: path.runId } : {}),
             });
         }
-        const turn = chatTurns.begin(id, audience, text);
+        // crew#826: the turn lives as long as its answer step may (`budget_secs`), not 3× the pool knob.
+        const turn = chatTurns.begin(id, audience, text, ASK_TURN_BUDGET_SECS);
         const turnId = turn?.turnId ?? randomUUID();
         // What an ACCEPTED message records — the engine has it, so a persistence failure here is
         // logged, never a retraction of a turn that is already being answered (codex on #808 r2, 9).
@@ -2698,9 +2740,12 @@ runtime = {}) {
                 const roster = rosterWithStanding().filter((seat) => path.eligible.includes(String(seat.key)));
                 const rules = (await considerations.inForceFor(scope?.projectId ?? null)).rules;
                 const pending = await considerations.pendingPreface(id, { inForce: rules });
-                const instructions = withPreface(pending.preface);
+                // crew#823: the run is titled by the operator's question (every reader titles a run from
+                // `problem`); the scope statement grounds the seats from the first answer step's
+                // instructions instead of standing in as the run's title.
+                const instructions = scope !== undefined ? `${chatScopeStatement(id, scope, rules)}\n\n${withPreface(pending.preface)}` : withPreface(pending.preface);
                 const input = {
-                    problem: scope !== undefined ? chatScopeStatement(id, scope, rules) : text,
+                    problem: text,
                     sessionId: randomUUID(),
                     clisJson: JSON.stringify(roster),
                     plan: { steps: [answerStep(stepId, instructions)], monitors: { asked: 1 } },
@@ -2719,6 +2764,13 @@ runtime = {}) {
                 pending.commit();
                 persistAccepted(pending.preface, () => {
                     runtime.linkChatRun?.(id, runId);
+                    if (projectId !== undefined) {
+                        // crew#823: the engine attached the crew.run membership with the launch record (as for
+                        // POST /runs); this is the post-commit half — the run DTO's `project_id` and the /ws
+                        // frames read the index, and the membership event says the run joined the chat's project.
+                        projects.index.set(runId, projectId);
+                        projects.bus?.emit(MEMBERSHIP_ATTACHED, { project_id: projectId, member: { kind: 'crew.run', ref: runId }, actor: actorOf(req).id }, membershipAttachedKey(projectId, 'crew.run', runId, Date.now()));
+                    }
                     recordRunLaunched(audit, runTimingIndex, actorOf(req), runId, {
                         chatId: id,
                         askPath: true,
@@ -4625,6 +4677,23 @@ runtime = {}) {
             if (typeof login === 'string')
                 patch.deliverIdentityLogin = login.trim();
         }
+        // deliverIdentityByRepo (crew#737): repo id → a GitHub login, each checked like
+        // deliverIdentityLogin; an entry of '' removes that repo's pin. A typo is a 400 naming the repo.
+        if (Object.hasOwn(patch, 'deliverIdentityByRepo')) {
+            const m = patch.deliverIdentityByRepo;
+            if (m === null || typeof m !== 'object' || Array.isArray(m)) {
+                return reply.code(400).send({ error: 'deliverIdentityByRepo must be an object of repo id → GitHub login' });
+            }
+            const kept = {};
+            for (const [repo, login] of Object.entries(m)) {
+                if (typeof login !== 'string' || (login.trim() !== '' && !isGitHubLogin(login.trim()))) {
+                    return reply.code(400).send({ error: `deliverIdentityByRepo.${repo} must be a GitHub login (letters, digits and single hyphens, up to 39 characters), or "" to use the daemon-wide identity` });
+                }
+                if (login.trim() !== '')
+                    kept[repo] = login.trim();
+            }
+            patch.deliverIdentityByRepo = kept;
+        }
         // deliverDefault (crew#393): the repo-scoped launch delivery default. Two values only —
         // this knob decides whether completed code runs open PRs, so a typo must be a 400, never
         // a silently-dropped key that leaves the operator believing they flipped it.
@@ -4636,6 +4705,10 @@ runtime = {}) {
                     .send({ error: "deliverDefault must be 'pr' or 'none'" });
             }
         }
+        // onboardingAutoCapture (crew#552): whether a completed onboarding chains capture-learnings.
+        if (Object.hasOwn(patch, 'onboardingAutoCapture') && typeof patch.onboardingAutoCapture !== 'boolean') {
+            return reply.code(400).send({ error: 'onboardingAutoCapture must be true or false' });
+        }
         // baseSkillRef / baseSkillPolicy (crew#554 / wicked-core#468): the discipline skill EVERY
         // governed unit is told to follow, and what a snapshot without it means. Both decide whether
         // launches carry the directive or are refused at intake, so a typo is a 400, never a silently
@@ -4716,7 +4789,9 @@ runtime = {}) {
             'workerStallEscalateAction',
             'workerStallMaxEscalations',
             'deliverDefault',
+            'onboardingAutoCapture',
             'deliverIdentityLogin',
+            'deliverIdentityByRepo',
             'baseSkillRef',
             'baseSkillPolicy',
         ];