whistle 2.10.9 → 2.10.11

package/biz/webui/lib/index.js

@@ -35,6 +35,7 @@ var uploadUrlencodedParser = bodyParser.urlencoded(UPLOAD_PARSE_CONF);
 var uploadJsonParser = bodyParser.json(UPLOAD_PARSE_CONF);
 var GET_METHOD_RE = /^get$/i;
 var WEINRE_RE = /^\/weinre\/.*/;
+var IMPORT_CGI = '/cgi-bin/import-remote';
 var ALLOW_PLUGIN_PATHS = ['/cgi-bin/rules/list2', '/cgi-bin/values/list2', '/cgi-bin/get-custom-certs-info'];
 var DONT_CHECK_PATHS = ['/cgi-bin/server-info', '/cgi-bin/plugins/is-enable', '/cgi-bin/plugins/get-plugins',
   '/preview.html', '/cgi-bin/rootca', '/cgi-bin/check-update', '/cgi-bin/log/set', '/cgi-bin/status'];
@@ -70,11 +71,14 @@ function isTempFile(query) {
   return common.getTempFile(query.filename);
 }
 
+function sendForbidden(res) {
+  res.setHeader('Content-Type', 'application/json; charset=utf-8');
+  res.end('{"ec":0,"value":"","forbidden":true}');
+}
+
 function sendToService(req, res) {
   if (!hasLogin() && req.path === '/cgi-bin/temp/get' && !isTempFile(req.query)) {
-    res.setHeader('Content-Type', 'application/json; charset=utf-8');
-    res.end('{"ec":0,"value":"","forbidden":true}');
-    return;
+    return sendForbidden(res);
   }
   loadService(function(err, options) {
     if (err) {
@@ -135,6 +139,9 @@ function requireLogin(req, res, msg) {
     }
     return res.status(404).end();
   }
+  if (req.path === IMPORT_CGI) {
+    return sendForbidden(res);
+  }
   res.setHeader('WWW-Authenticate', ' Basic realm=User Login');
   res.setHeader('Content-Type', 'text/html; charset=utf8');
   res.status(401).end(msg || 'Access denied, please <a href="javascript:;" onclick="location.reload()">try again</a>');
@@ -410,32 +417,7 @@ function cgiHandler(req, res) {
     handleResponse();
   });
 }
-app.get('/cgi-bin/import-remote', function(req, res) {
-  var url = req.query.url;
-  if (HTTP_RE.test(url)) {
-    util.request({
-      url: url,
-      maxLength: MAX_LEN
-    }, function(err, body, r) {
-      if (err) {
-        var msg = err.code === 'EEXCEED'  ? 'The size of response body exceeds 6MB' : err.message;
-        return res.json({ec: 2, em: msg});
-      }
-      var status = r.statusCode;
-      if (status !== 200) {
-        var em = status > 200 && status < 400 ? 'No data' : 'Request failed';
-        return res.json({ec: 2, em: em + ' (statusCode: ' + status + ')'});
-      }
-      return res.json({ec: 0, body: body});
-    });
-  } else if (util.isString(url)) {
-    req.url = '/cgi-bin/temp/get?filename=' + encodeURIComponent(url);
-    req.query.filename = url;
-    sendToService(req, res);
-  } else {
-    res.json({ec: 400, em: 'Bad url'});
-  }
-});
+
 app.all('/service/*', sendToService);
 app.all('/cgi-bin/service/*', sendToService);
 app.all('/cgi-bin/sessions/*', sendToService);
@@ -448,7 +430,7 @@ function readPluginPage(req, res, plugin, html, config) {
   res.write(config);
   res.write(html);
   var index = req.path.indexOf('/', 1);
-  if (index === -1) {
+  if (index === -1 || common.existsUpPath(req.path)) {
     res.end();
   } else {
     var filepath = req.path.substring(index + 1);
@@ -528,6 +510,33 @@ app.use(function(req, res, next) {
   }
 });
 
+app.get(IMPORT_CGI, function(req, res) {
+  var url = req.query.url;
+  if (HTTP_RE.test(url)) {
+    util.request({
+      url: url,
+      maxLength: MAX_LEN
+    }, function(err, body, r) {
+      if (err) {
+        var msg = err.code === 'EEXCEED'  ? 'The size of response body exceeds 6MB' : err.message;
+        return res.json({ec: 2, em: msg});
+      }
+      var status = r.statusCode;
+      if (status !== 200) {
+        var em = status > 200 && status < 400 ? 'No data' : 'Request failed';
+        return res.json({ec: 2, em: em + ' (statusCode: ' + status + ')'});
+      }
+      return res.json({ec: 0, body: body});
+    });
+  } else if (util.isString(url)) {
+    req.url = '/cgi-bin/temp/get?filename=' + encodeURIComponent(url);
+    req.query.filename = url;
+    sendToService(req, res);
+  } else {
+    res.json({ec: 400, em: 'Bad url'});
+  }
+});
+
 app.post('/cgi-bin/composer', function(req, res) {
   req.headers[config.CLIENT_IP_HEADER] = util.getClientIp(req);
   req.headers[config.CLIENT_PORT_HEADER] = util.getClientPort(req);

package/index.js

@@ -8,7 +8,6 @@ var os = require('os');
 var assert = require('assert');
 var common = require('./lib/util/common');
 
-var ver = process.version.substring(1).split('.');
 var PROD_RE = /(^|\|)prod(uction)?($|\|)/;
 var noop = function () {};
 var state = {};
@@ -16,21 +15,20 @@ var INTERVAL = 1000;
 var TIMEOUT = 10000;
 var MASTER_TIMEOUT = 12000;
 
-if (ver[0] >= 7 && ver[1] >= 7) {
-  var connect = net.Socket.prototype.connect;
-  if (typeof connect === 'function') {
-    //fix: Node v7.7.0+引入的 `"listener" argument must be a function` 问题
-    net.Socket.prototype.connect = function (options, cb) {
-      if (options && typeof options === 'object' && typeof cb !== 'function') {
-        return connect.call(this, options, null);
-      }
-      return connect.apply(this, arguments);
-    };
-  }
+var connect = net.Socket.prototype.connect;
+if (typeof connect === 'function') {
+  //fix: Node v7.7.0+引入的 `"listener" argument must be a function` 问题
+  net.Socket.prototype.connect = function (options, cb) {
+    if (options && typeof options === 'object' && typeof cb !== 'function') {
+      return connect.call(this, options, null);
+    }
+    return connect.apply(this, arguments);
+  };
 }
 
 var env = process.env || '';
 env.WHISTLE_ROOT = __dirname;
+env.PFORK_MAX_HTTP_HEADER_SIZE = 1024 * 1024;
 if (typeof tls.checkServerIdentity == 'function') {
   var checkServerIdentity = tls.checkServerIdentity;
   tls.checkServerIdentity = function () {

package/lib/config.js

@@ -1,12 +1,11 @@
 var path = require('path');
-var http = require('http');
 var fs = require('fs');
 var net = require('net');
 var dns = require('dns');
 var qs = require('querystring');
 var LRU = require('lru-cache');
-var httpAgent = http.Agent;
-var httpsAgent = require('https').Agent;
+var HttpAgent = require('http').Agent;
+var HttpsAgent = require('https').Agent;
 var parseUrl = require('./util/parse-url-safe');
 var fse = require('fs-extra2');
 var extend = require('extend');
@@ -25,14 +24,11 @@ var CMD_RE = /^[\w]{1,12}(?:\s+-g)?$/;
 var httpsAgents = new LRU({ max: 360 });
 var socksAgents = new LRU({ max: 100 });
 var version = process.version.substring(1).split('.');
-var disableAgent = version[0] > 10;
-var useVerbatim = version[0] >= 17;
-var hasIPv6First = version[0] >= 22 && version[1] >= 1;
+var hasIPv6First = (version[0] === 22 && version[1] >= 1) || version[0] > 22;
 var hasDnsOrder = typeof dns.setDefaultResultOrder === 'function';
 var uid = Date.now().toString(16) + (process.pid * 10000 + Math.floor(Math.random() * 10000)).toString(16);
 var IPV4_RE = /^([\d.]+)(:\d{1,5})?$/;
 var IPV6_RE = /^\[([\w:]+)\](:\d{1,5})?$/;
-var noop = function () {};
 var DATA_KEY_RE = /^(clientip|clientid|tunneldata)([=.])([\w.-]+)$/i;
 var DNS_ORDERS = ['ipv4First', 'ipv4first', 'ipv6first', 'ipv6First', 'verbatim'];
 var LOCAL_UI_HOST_LIST = [
@@ -61,18 +57,12 @@ var variableProperties = [
   'disableInstaller'
 ];
 if (hasDnsOrder) {
-  if (hasIPv6First) {
-    config.verbatim = 2;
-  } else {
-    config.verbatim = 1;
-  }
+  config.verbatim = hasIPv6First ? 2 : 1;
 }
 
 config.appName = common.upperFirst(config.name);
-config.defaultDnsOrder = useVerbatim ? 1 : 2;
 config.uid = uid;
 config.rejectUnauthorized = false;
-config.enableH2 = version[0] > 12; // 支持 HTTP2 要求的最低 Node 版本
 config.ASSESTS_PATH = path.join(__dirname, '../assets');
 config.WHISTLE_POLICY_HEADER = 'x-whistle-policy';
 config.CLIENT_IP_HEADER = common.CLIENT_IP_HEADER;
@@ -119,16 +109,18 @@ config.PLUGIN_HOOKS = {
 
 var KEEP_ALIVE_MSECS = 10000;
 var CONN_TIMEOUT = common.CONN_TIMEOUT;
-var DNS_ORDERS_OPTS = ['', 'verbatim', 'ipv4first', hasIPv6First ? 'ipv6first' : ''];
+var DNS_ORDERS_OPTS = ['', 'ipv4first', 'ipv4first', hasIPv6First ? 'ipv6first' : '', '', 'verbatim'];
 var DOMAIN_STAR_RE = /([*~]+)(\\.)?/g;
 
 config.CONN_TIMEOUT = CONN_TIMEOUT;
 
 var getWhistlePath = common.getWhistlePath;
 var getHostPort = common.getHostPort;
+var WHISTLE_PATH = getWhistlePath();
 
-var ALL_WHISTLES_PATH = path.join(getWhistlePath(), 'all_whistles');
+var ALL_WHISTLES_PATH = path.join(WHISTLE_PATH, 'all_whistles');
 
+config.WHISTLE_PATH = WHISTLE_PATH;
 
 function domainToRegExp(_, star, dot) {
   var len = star.length;
@@ -143,16 +135,16 @@ function domainToRegExp(_, star, dot) {
 }
 
 function getDataDir(dirname) {
-  var dir = path.join(getWhistlePath(), dirname || '.' + config.name);
+  var dir = path.join(WHISTLE_PATH, dirname || '.' + config.name);
   fse.ensureDirSync(dir);
   return dir;
 }
 
 config.baseDir = getDataDir();
-config.CUSTOM_PLUGIN_PATH = path.join(getWhistlePath(), 'custom_plugins');
-config.CUSTOM_CERTS_DIR = path.resolve(getWhistlePath(), 'custom_certs');
-config.SAVED_SESSIONS_PATH = path.resolve(getWhistlePath(), 'saved_sessions');
-config.DEV_PLUGINS_PATH = path.resolve(getWhistlePath(), 'dev_plugins');
+config.CUSTOM_PLUGIN_PATH = path.join(WHISTLE_PATH, 'custom_plugins');
+config.CUSTOM_CERTS_DIR = path.resolve(WHISTLE_PATH, 'custom_certs');
+config.SAVED_SESSIONS_PATH = path.resolve(WHISTLE_PATH, 'saved_sessions');
+config.DEV_PLUGINS_PATH = path.resolve(WHISTLE_PATH, 'dev_plugins');
 config.rulesDir = path.join(config.baseDir, 'rules');
 config.valuesDir = path.join(config.baseDir, 'values');
 config.propertiesDir = path.join(config.baseDir, 'properties');
@@ -173,55 +165,6 @@ try {
 
 exports.getWhistlePath = getWhistlePath;
 exports.getDataDir = getDataDir;
-var async_id_symbol;
-if (version[0] < 16) {
-  try {
-    async_id_symbol = process.binding('async_wrap').async_id_symbol;
-  } catch (e) {}
-}
-var emptyHandle = {
-  asyncReset: noop,
-  getAsyncId: noop
-};
-
-function createAgent(agentConfig, https) {
-  var agent = new (https ? httpsAgent : httpAgent)(agentConfig);
-  if (async_id_symbol) {
-    var addRequest = agent.addRequest;
-    agent.addRequest = function (req, options) {
-      // fix: https://github.com/nodejs/node/issues/13539
-      var freeSockets = this.freeSockets[this.getName(options)];
-      if (freeSockets && freeSockets.length) {
-        var socket = freeSockets[0];
-        var handle = socket._handle;
-        if (!handle) {
-          socket._handle = emptyHandle;
-        } else if (typeof handle.asyncReset !== 'function') {
-          handle.asyncReset = noop;
-        }
-        var originalRef = socket.ref;
-        socket.ref = function () {
-          socket.ref = originalRef;
-          if (socket._handle === emptyHandle) {
-            delete socket._handle;
-          } else if (socket._handle.asyncReset === noop) {
-            delete socket._handle.asyncReset;
-          }
-          socket.ref();
-        };
-      }
-      var onSocket = req.onSocket;
-      req.onSocket = function (socket) {
-        try {
-          socket[async_id_symbol] = socket._handle.getAsyncId();
-        } catch (e) {}
-        onSocket.apply(this, arguments);
-      };
-      addRequest.apply(this, arguments);
-    };
-  }
-  return agent;
-}
 
 function getHttpsAgent(options, reqOpts) {
   var key = getCacheKey(options);
@@ -305,13 +248,16 @@ function getAuths(_url) {
 
 exports.getAuths = getAuths;
 
+function getDnsOrder(order) {
+  return order == 1 ? 2 : order;
+}
+
 function setDefaultResultOrder(order) {
   if (!hasDnsOrder) {
     return;
   }
-  order = DNS_ORDERS_OPTS.indexOf(order) === -1 ? DNS_ORDERS_OPTS[order] : order;
-  if (!order) {
-    return;
+  if (DNS_ORDERS_OPTS.indexOf(order) === -1) {
+    order = DNS_ORDERS_OPTS[order] || DNS_ORDERS_OPTS[1];
   }
   config.ipv4First = false;
   config.ipv6First = false;
@@ -321,10 +267,10 @@ function setDefaultResultOrder(order) {
     config.ipv4First = true;
   }
   try {
-    if (dns.getDefaultResultOrder() !== order) {
+    if (!dns.getDefaultResultOrder || dns.getDefaultResultOrder() !== order) {
       dns.setDefaultResultOrder(order);
     }
-    config.dnsOrder = DNS_ORDERS_OPTS.indexOf(order);
+    config.dnsOrder = getDnsOrder(DNS_ORDERS_OPTS.indexOf(order));
     return true;
   } catch (e) {}
 }
@@ -1096,10 +1042,10 @@ exports.extend = function (newConf) {
     keepAliveMsecs: KEEP_ALIVE_MSECS,
     maxFreeSockets: 0
   };
-  // node 11及以上版本缓存连接有问题，先禁掉
-  disableAgent = !newAgentConf && !useAgent && (disableAgent || config.debug);
-  config.httpAgent = disableAgent ? false : createAgent(agentConfig);
-  config.httpsAgent = disableAgent ? false : createAgent(agentConfig, true);
+  // node 11及以上版本缓存连接有问题，默认禁掉
+  var disableAgent = !newAgentConf && !useAgent;
+  config.httpAgent = disableAgent ? false : new HttpAgent(agentConfig);
+  config.httpsAgent = disableAgent ? false : new HttpsAgent(agentConfig);
   config.getSocksAgent = function (options) {
     var key = getCacheKey(options, true);
     var agent = socksAgents.get(key);

package/lib/handlers/file-proxy.js

@@ -157,7 +157,7 @@ function getRawResByPath(protocol, path, req, size, callback, body) {
       }
     });
     reader.on('error', response);
-    reader.on('end', response);
+    reader.once('end', response);
   } else {
     callback(reader, range, size);
   }

package/lib/https/ca.js

@@ -43,9 +43,9 @@ var ILEGAL_CHAR_RE = /[^a-z\d-]/i;
 // https://cloud.tencent.com/developer/ask/sof/58155
 var RANDOM_SERIAL = '/' + Date.now() + '/' + process.pid + '/' + Math.floor(Math.random() * 100);
 var ONE_DAY = 1000 * 60 * 60 * 24;
-var MIN_DATE = ONE_DAY * 20;
-var CLEAR_CERTS_INTERVAL = ONE_DAY * 20;
-var MAX_INNTERFAL = 16;
+var ONE_YEAR = ONE_DAY * 365;
+var MIN_DATE = ONE_DAY * 7;
+var MAX_DATE = ONE_DAY * 36;
 var PORT_RE = /:\d*$/;
 var pureCertFiles = {};
 var customRoot;
@@ -71,13 +71,16 @@ function resetAllCerts() {
 }
 
 // When delay is larger than 2147483647 or less than 1, the delay will be set to 1. Non-integer delays are truncated to an integer.
-var intervalCount = 0;
+var startTime = Date.now();
+var INTERVAL = ONE_DAY;
+var MAX_AGE = MAX_DATE - INTERVAL * 2;
 var timer = setInterval(function () {
-  if (++intervalCount >= MAX_INNTERFAL) {
-    intervalCount = 0;
+  var now = Date.now();
+  if (now - startTime >= MAX_AGE) {
+    startTime = now;
     resetAllCerts();
   }
-}, CLEAR_CERTS_INTERVAL);
+}, INTERVAL);
 
 if (timer && typeof timer.unref === 'function') {
   timer.unref();
@@ -553,18 +556,16 @@ function createCert(publicKey, serialNumber, isShortPeriod) {
   var cert = pki.createCertificate();
   cert.publicKey = publicKey;
   cert.serialNumber = serialNumber || '01';
-  var curDate = new Date();
-  var curYear = curDate.getFullYear();
+  var now = Date.now();
+  // https://www.ssls.com/blog/apples-new-ssl-lifetime-limitation-and-what-it-means-for-you/
+  // https://chromium.googlesource.com/chromium/src/+/refs/heads/master/net/cert/cert_verify_proc.cc#900
   if (isShortPeriod) {
-    cert.validity.notBefore = new Date(curDate.getTime() - MIN_DATE);
+    cert.validity.notBefore = new Date(now - MIN_DATE);
+    cert.validity.notAfter = new Date(now + MAX_DATE);
   } else {
-    cert.validity.notBefore = new Date();
-    cert.validity.notBefore.setFullYear(curYear - 1);
+    cert.validity.notBefore = new Date(now - ONE_YEAR);
+    cert.validity.notAfter = new Date(now + ONE_YEAR * 10);
   }
-  // https://www.ssls.com/blog/apples-new-ssl-lifetime-limitation-and-what-it-means-for-you/
-  // https://chromium.googlesource.com/chromium/src/+/refs/heads/master/net/cert/cert_verify_proc.cc#900
-  cert.validity.notAfter = new Date();
-  cert.validity.notAfter.setFullYear(curYear + (isShortPeriod ? 1 : 10));
   return cert;
 }
 
@@ -690,7 +691,7 @@ exports.getHttp2Server = function (listener, callback) {
 };
 
 exports.getSNIServer = function (listener, callback, disableH2, requestCert) {
-  var enableH2 = config.enableH2 && !disableH2;
+  var enableH2 = !disableH2;
   var name = (enableH2 ? 'h2Sni' : 'sni') + (requestCert ? 'WithCert' : '');
   var curPort = ports[name];
   if (curPort) {

package/lib/https/h2.js

@@ -5,7 +5,7 @@ var sockx = require('sockx');
 var util = require('../util');
 var config = require('../config');
 var extend = require('extend');
-var http2 = config.enableH2 ? require('http2') : null;
+var http2 = require('http2');
 
 var SUPPORTED_PROTOS = ['h2', 'http/1.1', 'http/1.0'];
 var H2_SETTINGS = { enablePush: false };
@@ -33,33 +33,43 @@ function onClose(stream, callback) {
   });
 }
 
+function closeClose(client, name) {
+  try {
+    client.close();
+  } catch (e) {}
+  delete clients[name];
+}
+
 setInterval(function () {
   var now = Date.now();
   Object.keys(clients).forEach(function (name) {
     var client = clients[name];
-    if (now - client._updateTime > CACHE_TIMEOUT) {
-      client.close();
-      delete clients[name];
+    if (isClosed(client) || now - client._updateTime > CACHE_TIMEOUT) {
+      closeClose(client, name);
     }
   });
 }, INTERVAL);
 
-function getKey(options) {
+function getOrigin(req) {
+  return (req.useHttpH2 ? 'http' : 'https') + '://' + req.headers.host;
+}
+
+function getKey(options, req) {
   var proxyOpts = options._proxyOptions;
   var proxyType = '';
   if (proxyOpts) {
-    var auth =
-      (proxyOpts.headers && proxyOpts.headers['proxy-authorization']) || '';
+    var headers = proxyOpts.headers || {};
     proxyType = [
       proxyOpts.proxyType,
       proxyOpts.proxyHost,
       proxyOpts.proxyPort,
-      proxyOpts.headers.host,
+      headers.host,
       proxyOpts.proxyTunnelPath || '',
-      auth
+      headers['proxy-authorization'] || ''
     ].join(':');
   }
   return [
+    getOrigin(req),
     options.servername,
     options.host,
     options.port || '',
@@ -222,35 +232,35 @@ function getSocket(options, callback, req) {
 }
 
 function getClient(req, socket, name, callback) {
-  var origin = (req.useHttpH2 ? 'http' : 'https') + '://' + req.headers.host;
   var handleCallback = function(err, clt) {
     if (callback) {
       clearTimeout(timer);
       if (err || !clt) {
-        delete clients[name];
+        closeClose(client, name);
         socket.destroy();
-        client.close();
       }
       callback(clt);
       callback = timer = null;
     }
   };
   var timer = setTimeout(handleCallback, REQ_TIMEOUT);
-  var client = http2.connect(
-    origin, util.setRejectUnauthorized(req, {
-      settings: H2_SETTINGS,
-      maxSessionMemory: MSM,
-      peerMaxConcurrentStreams: PMCS,
-      streamResetBurst: RESET_BURST,
-      streamResetRate: RESET_RATE,
-      createConnection: function () {
-        return socket;
-      }
-    }), function() {
-      handleCallback(null, client);
-    });
+  var client = http2.connect(getOrigin(req), util.setRejectUnauthorized(req, {
+    settings: H2_SETTINGS,
+    maxSessionMemory: MSM,
+    peerMaxConcurrentStreams: PMCS,
+    streamResetBurst: RESET_BURST,
+    streamResetRate: RESET_RATE,
+    createConnection: function () {
+      return socket;
+    }
+  }), function() {
+    handleCallback(null, client);
+  });
   clients[name] = client;
   client._updateTime = Date.now();
+  client.once('goaway', function() {
+    closeClose(client, name);
+  });
   onClose(client, handleCallback);
   onClose(socket, handleCallback);
   return client;
@@ -261,11 +271,6 @@ function requestH2(client, req, res, callback) {
     return;
   }
   var headers = util.formatH2Headers(req.headers);
-  delete req.headers.connection;
-  delete req.headers['keep-alive'];
-  delete req.headers['http2-settings'];
-  delete req.headers['proxy-connection'];
-  delete req.headers['transfer-encoding'];
   var options = req.options;
   var responsed;
   headers[':path'] = options.path;
@@ -327,8 +332,10 @@ function requestH2(client, req, res, callback) {
     });
     req.pipe(h2Session);
   } catch (e) {
-    !responsed && callback();
-    responsed = true;
+    if (!responsed) {
+      callback();
+      responsed = true;
+    }
   }
 }
 
@@ -380,12 +387,16 @@ function checkTlsError(err) {
   return typeof code === 'string' && (code.indexOf('ERR_TLS_') === 0 || code.indexOf('ERR_SSL_') === 0);
 }
 
+function isClosed(client) {
+  return client.destroyed || client.closed;
+}
+
 exports.request = function (req, res, callback) {
   var options = req.useH2 && req.options;
   if (!options || options.isPlugin || req._isInternalProxy) {
     return callback();
   }
-  var key = getKey(options);
+  var key = getKey(options, req);
   var reqId = req.disable.keepH2Session ? '' : req._h2ReqId;
   var name = (reqId || req.clientIp) + '\n' + key;
   var client = clients[name];
@@ -395,13 +406,21 @@ exports.request = function (req, res, callback) {
         name = name + '\n' + client.curIndex;
         client.curIndex = ++client.curIndex % CONCURRENT;
         client = clients[name];
+        if (client && isClosed(client)) {
+          delete clients[name];
+          client = null;
+        }
       } else {
         client.curIndex = 1;
       }
     }
     if (client) {
-      client._updateTime = Date.now();
-      return requestH2(client, req, res, callback);
+      if (!isClosed(client)) {
+        client._updateTime = Date.now();
+        return requestH2(client, req, res, callback);
+      }
+      delete clients[name];
+      client = null;
     }
   }
   var time = notH2.peek(key);