whatsapp-pi 1.0.42 → 1.0.44

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "whatsapp-pi",
-  "version": "1.0.42",
+  "version": "1.0.44",
   "type": "module",
   "description": "WhatsApp integration extension for Pi",
   "main": "whatsapp-pi.ts",
@@ -27,6 +27,7 @@
   "author": "Rapha",
   "license": "MIT",
   "scripts": {
+    "lint": "eslint whatsapp-pi.ts \"src/**/*.ts\" \"tests/**/*.ts\"",
     "test": "vitest run",
     "typecheck": "tsc --noEmit"
   },
@@ -36,10 +37,14 @@
     "qrcode-terminal": "^0.12.0"
   },
   "devDependencies": {
+    "@eslint/js": "^9.39.4",
     "@mariozechner/pi-coding-agent": "latest",
     "@types/node": "^20.11.0",
     "@types/qrcode-terminal": "^0.12.2",
+    "@typescript-eslint/eslint-plugin": "^8.58.1",
+    "@typescript-eslint/parser": "^8.58.1",
     "@vitest/coverage-v8": "^1.6.1",
+    "eslint": "^9.39.4",
     "ts-node": "^10.9.2",
     "tsx": "^4.7.0",
     "typescript": "^5.3.0",

package/src/services/incoming-media.service.ts

@@ -102,7 +102,7 @@ export class IncomingMediaService {
     }
 
     private async saveDocument(fileName: string, buffer: Buffer): Promise<string> {
-        const sanitized = fileName.replace(/[^a-z0-9\._-]/gi, '_');
+        const sanitized = fileName.replace(/[^a-z0-9._-]/gi, '_');
         const savedFileName = `${Date.now()}_${sanitized}`;
         const documentDir = join(process.cwd(), '.pi-data', 'whatsapp', 'documents');
         const absolutePath = join(documentDir, savedFileName);

package/src/services/session.manager.ts

@@ -1,27 +1,33 @@
-import { useMultiFileAuthState } from '@whiskeysockets/baileys';
-import { join } from 'path';
-import { readFile, writeFile, mkdir, rm, readdir } from 'fs/promises';
+import { useMultiFileAuthState } from '@whiskeysockets/baileys';
+import { join } from 'path';
+import { readFile, writeFile, mkdir, rm, rename } from 'fs/promises';
 import { homedir } from 'os';
 import { SessionStatus } from '../models/whatsapp.types.js';
 
-export interface Contact {
-    number: string;
-    name?: string;
-}
-
-export class SessionManager {
-    // Data is stored in the user's home directory to persist across updates
-    private readonly baseDir = join(homedir(), '.pi', 'whatsapp-pi');
-    private readonly authStateDir = join(this.baseDir, 'auth');
-    private readonly configPath = join(this.baseDir, 'config.json');
+export interface Contact {
+    number: string;
+    name?: string;
+}
+
+export class SessionManager {
+    // Data is stored in the user's home directory to persist across updates
+    private readonly baseDir: string;
+    private readonly authStateDir: string;
+    private readonly configPath: string;
 
     private status: SessionStatus = 'logged-out';
     private allowList: Contact[] = [];
     private blockList: Contact[] = [];
     private ignoredNumbers: Contact[] = [];
     private hasAuthState = false;
-    private openaiKey: string = '';
-    private visionModel: string = 'gpt-4o';
+    private openaiKey: string = '';
+    private visionModel: string = 'gpt-4o';
+
+    constructor(baseDir = join(homedir(), '.pi', 'whatsapp-pi')) {
+        this.baseDir = baseDir;
+        this.authStateDir = join(this.baseDir, 'auth');
+        this.configPath = join(this.baseDir, 'config.json');
+    }
 
     private async ensureStorageDirectories() {
         await mkdir(this.baseDir, { recursive: true });
@@ -33,15 +39,17 @@ export class SessionManager {
             await this.ensureStorageDirectories();
             await this.loadConfig();
             await this.syncAuthStateFromDisk();
-        } catch (error) {}
+        } catch {
+            // Initialization is best-effort; callers can continue with defaults.
+        }
     }
 
-    private async loadConfig() {
-        try {
-            const data = await readFile(this.configPath, 'utf-8');
-            const config = JSON.parse(data);
-            
-            const cleanContact = (item: any): Contact | null => {
+    private async loadConfig() {
+        try {
+            const data = await readFile(this.configPath, 'utf-8');
+            const { config, recovered } = this.parseConfig(data);
+            
+            const cleanContact = (item: any): Contact | null => {
                 if (typeof item === 'string') return { number: item };
                 if (item && typeof item === 'object') {
                     let num = item.number;
@@ -60,30 +68,91 @@ export class SessionManager {
             this.blockList = (config.blockList || []).map(cleanContact).filter(Boolean) as Contact[];
             this.ignoredNumbers = (config.ignoredNumbers || []).map(cleanContact).filter(Boolean) as Contact[];
             this.status = config.status || 'logged-out';
-            this.hasAuthState = Boolean(config.hasAuthState);
-            this.openaiKey = config.openaiKey || '';
-            this.visionModel = config.visionModel || 'gpt-4o';
-        } catch (error) {
-            // File not found is fine
-        }
-    }
-
-    public async saveConfig() {
-        try {
-            const config = {
-                allowList: this.allowList,
+            this.hasAuthState = Boolean(config.hasAuthState);
+            this.openaiKey = config.openaiKey || '';
+            this.visionModel = config.visionModel || 'gpt-4o';
+
+            if (recovered) {
+                await this.saveConfig();
+            }
+        } catch {
+            // File not found is fine
+        }
+    }
+
+    private parseConfig(data: string): { config: any; recovered: boolean } {
+        try {
+            return { config: JSON.parse(data), recovered: false };
+        } catch (error) {
+            const objectEnd = this.findFirstJsonObjectEnd(data);
+            if (objectEnd < 0) {
+                throw error;
+            }
+
+            return {
+                config: JSON.parse(data.slice(0, objectEnd + 1)),
+                recovered: true
+            };
+        }
+    }
+
+    private findFirstJsonObjectEnd(data: string): number {
+        let depth = 0;
+        let inString = false;
+        let escaped = false;
+
+        for (let i = 0; i < data.length; i++) {
+            const char = data[i];
+
+            if (inString) {
+                if (escaped) {
+                    escaped = false;
+                } else if (char === '\\') {
+                    escaped = true;
+                } else if (char === '"') {
+                    inString = false;
+                }
+                continue;
+            }
+
+            if (char === '"') {
+                inString = true;
+                continue;
+            }
+
+            if (char === '{') {
+                depth++;
+            } else if (char === '}') {
+                depth--;
+                if (depth === 0) {
+                    return i;
+                }
+            }
+        }
+
+        return -1;
+    }
+
+    public async saveConfig() {
+        const tempPath = `${this.configPath}.${process.pid}.${Date.now()}.tmp`;
+        try {
+            const config = {
+                allowList: this.allowList,
                 blockList: this.blockList,
                 ignoredNumbers: this.ignoredNumbers,
                 status: this.status,
                 hasAuthState: this.hasAuthState,
-                openaiKey: this.openaiKey,
-                visionModel: this.visionModel
-            };
-            await writeFile(this.configPath, JSON.stringify(config, null, 2));
-        } catch (error) {
-            console.error('Failed to save config:', error);
-        }
-    }
+                openaiKey: this.openaiKey,
+                visionModel: this.visionModel
+            };
+            await mkdir(this.baseDir, { recursive: true });
+            await writeFile(tempPath, JSON.stringify(config, null, 2));
+            await rename(tempPath, this.configPath);
+        } catch (error) {
+            await rm(tempPath, { force: true }).catch(() => {});
+            console.error('Failed to save config:', error);
+        }
+    }
 
     getAllowList(): Contact[] {
         return this.allowList;
@@ -205,17 +274,10 @@ export class SessionManager {
         }
     }
 
-    public async isRegistered(): Promise<boolean> {
-        try {
-            const credsPah = join(this.authStateDir, 'creds.json');
-            await readFile(credsPah);
-            this.hasAuthState = true;
-            return true;
-        } catch {
-            await this.syncAuthStateFromDisk();
-            return this.hasAuthState;
-        }
-    }
+    public async isRegistered(): Promise<boolean> {
+        await this.syncAuthStateFromDisk();
+        return this.hasAuthState;
+    }
 
     async markAuthStateAvailable() {
         if (!this.hasAuthState) {
@@ -229,19 +291,27 @@ export class SessionManager {
         return await useMultiFileAuthState(this.authStateDir);
     }
 
-    private async syncAuthStateFromDisk() {
-        try {
-            const entries = await readdir(this.authStateDir);
-            if (entries.length > 0) {
-                if (!this.hasAuthState) {
-                    this.hasAuthState = true;
-                    await this.saveConfig();
-                }
-            }
-        } catch {
-            // Ignore missing directory / empty auth state
-        }
-    }
+    private async syncAuthStateFromDisk() {
+        const nextHasAuthState = await this.hasCredentialsFile();
+        const nextStatus = nextHasAuthState || this.status !== 'connected'
+            ? this.status
+            : 'disconnected';
+
+        if (nextHasAuthState !== this.hasAuthState || nextStatus !== this.status) {
+            this.hasAuthState = nextHasAuthState;
+            this.status = nextStatus;
+            await this.saveConfig();
+        }
+    }
+
+    private async hasCredentialsFile(): Promise<boolean> {
+        try {
+            await readFile(join(this.authStateDir, 'creds.json'));
+            return true;
+        } catch {
+            return false;
+        }
+    }
 
     async deleteAuthState() {
         try {

package/src/services/whatsapp.service.ts

@@ -82,7 +82,7 @@ export class WhatsAppService {
     private restoreBaileysConsoleFilter?: () => void;
     private reconnectTimeout?: ReturnType<typeof setTimeout>;
     private onQRCode?: (qr: string) => void;
-    private onMessage?: (m: unknown) => void;
+    private onMessage?: (m: MessagesUpsertEvent) => void;
     private onStatusUpdate?: (status: string) => void;
     private lastRemoteJid: string | null = null;
 
@@ -295,7 +295,7 @@ export class WhatsAppService {
     private async handlePairingQr(qr: string) {
         this.sessionManager.setStatus('pairing');
         this.onQRCode?.(qr);
-        this.onStatusUpdate?.('| WhatsApp: type /whatsapp to connect');
+        this.onStatusUpdate?.('| WhatsApp: Disconnected');
     }
 
     private async handleConnectionOpen() {
@@ -339,35 +339,27 @@ export class WhatsAppService {
             console.error(`Connection closed [${statusCode}]. Reconnecting: ${shouldReconnect}`);
         }
 
-        if (shouldTreatAsLoggedOut) {
-            if (isAuthRejected && !isBadMac && allowPairingOnAuthFailure) {
-                if (this.verboseMode) {
-                    console.error(`Session rejected [${statusCode}] - clearing auth state and starting pairing`);
-                }
-                await this.sessionManager.deleteAuthState();
-                this.cleanupSocket();
-                this.socket = undefined;
-                this.isReconnecting = false;
-                await this.start({ allowPairingOnAuthFailure: false });
-                return;
-            }
-
-            if (this.verboseMode) {
-                console.error(`Session invalid or logged out [${statusCode}] - preserving auth state and requiring re-auth`);
-            }
-            if (isBadMac) {
-                if (this.verboseMode) {
-                    console.error('[WhatsApp-Pi] Bad MAC error detected. Your session keys are corrupted.');
-                    console.error('[WhatsApp-Pi] Run /whatsapp-logout to clear auth state, then reconnect with /whatsapp-connect');
-                }
-                this.onStatusUpdate?.('| WhatsApp: Session Error (Bad MAC)');
-            }
-            this.sessionManager.setStatus('logged-out');
-            if (!isBadMac) {
-                this.onStatusUpdate?.('| WhatsApp: Logged out');
-            }
-            return;
-        }
+        if (shouldTreatAsLoggedOut) {
+            if (this.verboseMode) {
+                console.error(`Session rejected [${statusCode}] - preserving auth state`);
+            }
+            if (isBadMac) {
+                if (this.verboseMode) {
+                    console.error('[WhatsApp-Pi] Bad MAC error detected. Your session keys are corrupted.');
+                    console.error('[WhatsApp-Pi] Use Logoff (Delete Session) only if reconnect keeps failing.');
+                }
+                this.onStatusUpdate?.('| WhatsApp: Session Error (Bad MAC)');
+            } else if (isAuthRejected && allowPairingOnAuthFailure) {
+                this.onStatusUpdate?.('| WhatsApp: Session Preserved (Reconnect Failed)');
+            }
+            this.cleanupSocket();
+            this.isReconnecting = false;
+            await this.sessionManager.setStatus('disconnected');
+            if (!isBadMac) {
+                this.onStatusUpdate?.('| WhatsApp: Disconnected');
+            }
+            return;
+        }
 
         if (statusCode === DisconnectReason.connectionReplaced) {
             if (this.verboseMode) {
@@ -465,7 +457,7 @@ export class WhatsAppService {
         this.onQRCode = callback;
     }
 
-    setMessageCallback(callback: (m: unknown) => void) {
+    setMessageCallback(callback: (m: MessagesUpsertEvent) => void) {
         this.onMessage = callback;
     }
 

package/src/ui/menu.handler.ts

@@ -63,13 +63,14 @@ export class MenuHandler {
                 await this.whatsappService.stop();
                 ctx.ui.notify('WhatsApp Agent Disconnected', 'warning');
                 break;
-            case 'Logoff (Delete Session)':
-                const confirmLogoff = await ctx.ui.confirm('Logoff', 'Delete all credentials?');
-                if (confirmLogoff) {
-                    await this.whatsappService.logout();
-                    ctx.ui.notify('Logged off and credentials deleted', 'info');
-                }
-                break;
+            case 'Logoff (Delete Session)': {
+                const confirmLogoff = await ctx.ui.confirm('Logoff', 'Delete all credentials?');
+                if (confirmLogoff) {
+                    await this.whatsappService.logout();
+                    ctx.ui.notify('Logged off and credentials deleted', 'info');
+                }
+                break;
+            }
             case 'Allowed Numbers':
                 await this.manageAllowList(ctx);
                 break;

package/src/ui/message-detail.view.ts

@@ -29,11 +29,10 @@ export class MessageDetailView {
         ) {
             this.props.onClose();
         }
-    }
-
-    render(width: number): string[] {
-        const title = this.props.title.trim() || 'Message Details';
-        const bodyText = this.props.text.length > 0 ? this.props.text : '[No readable text available]';
+    }
+
+    render(width: number): string[] {
+        const bodyText = this.props.text.length > 0 ? this.props.text : '[No readable text available]';
 
         const availableWidth = Math.max(20, width - 4);
         const rawHeaderLines = [

package/whatsapp-pi.ts

@@ -60,7 +60,7 @@ export default function (pi: ExtensionAPI) {
     };
 
     // Initial status setup
-    pi.on("session_start", async (event, ctx) => {
+    pi.on("session_start", async (_event, ctx) => {
         _ctx = ctx;
         // Check verbose mode
         const isVerboseFlagSet = process.argv.includes("--verbose");
@@ -86,10 +86,10 @@ export default function (pi: ExtensionAPI) {
                 await whatsappService.stop();
             }
         };
-        whatsappService.setIncomingMessageRecorder(async (message) => {
-            await recentsService.recordMessage({
-                messageId: message.id,
-                senderNumber: `+${message.remoteJid.split('@')[0]}`,
+        whatsappService.setIncomingMessageRecorder(async (message) => {
+            await recentsService.recordMessage({
+                messageId: message.id,
+                senderNumber: `+${message.remoteJid.split('@')[0]}`,
                 senderName: message.pushName,
                 text: message.text || '',
                 direction: 'incoming',
@@ -97,19 +97,20 @@ export default function (pi: ExtensionAPI) {
             });
         });
 
-        const savedStateEntry = [...ctx.sessionManager.getEntries()]
-            .reverse()
-            .find(entry => entry.type === "custom" && entry.customType === "whatsapp-state");
-        const isWhatsappPiOn = event.reason === "startup" && pi.getFlag("whatsapp-pi-online") === true;
-
-        if (savedStateEntry) {
-            const data = (savedStateEntry as { data?: any }).data;
-            if (data.status) {
-                const restoredStatus = data.status === 'connected' && !isWhatsappPiOn
-                    ? 'disconnected'
-                    : data.status;
-                await sessionManager.setStatus(restoredStatus);
-            }
+        const savedStateEntry = [...ctx.sessionManager.getEntries()]
+            .reverse()
+            .find(entry => entry.type === "custom" && entry.customType === "whatsapp-state");
+        const isWhatsappPiOn = pi.getFlag("whatsapp-pi-online") === true;
+        const registered = await sessionManager.isRegistered();
+
+        if (savedStateEntry) {
+            const data = (savedStateEntry as { data?: any }).data;
+            if (data.status) {
+                const restoredStatus = data.status === 'connected' && !(isWhatsappPiOn && registered)
+                    ? 'disconnected'
+                    : data.status;
+                await sessionManager.setStatus(restoredStatus);
+            }
             if (Array.isArray(data.allowList)) {
                 for (const n of data.allowList) {
                     const num = typeof n === "string" ? n : n.number;
@@ -117,13 +118,10 @@ export default function (pi: ExtensionAPI) {
                     await sessionManager.addNumber(num, name);
                 }
             }
-        }
-
-        // Check whatsapp flag — only auto-connect on initial startup, not reloads/new sessions
-        const registered = await sessionManager.isRegistered();
-
-        if (isWhatsappPiOn && registered) {
-            ctx.ui.setStatus('whatsapp', '| WhatsApp: Auto-connecting...');
+        }
+
+        if (isWhatsappPiOn && registered) {
+            ctx.ui.setStatus('whatsapp', '| WhatsApp: Auto-connecting...');
 
             // Retry logic (max 3 attempts, 3s delay)
             let attempts = 0;
@@ -133,7 +131,7 @@ export default function (pi: ExtensionAPI) {
                 attempts++;
                 try {
                     await whatsappService.start({ allowPairingOnAuthFailure: false });
-                } catch (error) {
+                } catch {
                     if (attempts < maxAttempts) {
                         ctx.ui.notify(`WhatsApp: Connection attempt ${attempts} failed. Retrying...`, 'warning');
                         setTimeout(tryConnect, 3000);
@@ -145,9 +143,11 @@ export default function (pi: ExtensionAPI) {
             };
 
             await tryConnect();
-        } else {
-            ctx.ui.notify('WhatsApp: Use Connect / Reconnect WhatsApp. QR code will appear only if pairing is needed.', 'info');
-        }
+        } else if (isWhatsappPiOn) {
+            ctx.ui.notify('WhatsApp: Auto-connect requested, but no saved WhatsApp credentials were found. Use Connect WhatsApp once to scan the QR code.', 'warning');
+        } else {
+            ctx.ui.notify('WhatsApp: Use Connect / Reconnect WhatsApp. QR code will appear only if pairing is needed.', 'info');
+        }
 
         ctx.ui.notify('WhatsApp: Session reset via /new is now fully supported.', 'info');
 
@@ -157,7 +157,7 @@ export default function (pi: ExtensionAPI) {
             if (code !== 0 && code !== 99) { // 99 is a common exit code for -v in some versions
                 throw new Error(`pdftotext returned code ${code}`);
             }
-        } catch (e) {
+        } catch {
             ctx.ui.notify('WhatsApp: pdftotext not found. PDF document support will be limited to storage only.', 'warning');
             logger.warn('[WhatsApp-Pi] Warning: pdftotext not found in system PATH.');
         }
@@ -165,8 +165,8 @@ export default function (pi: ExtensionAPI) {
 
     // Handle incoming messages by injecting them as user prompts
     whatsappService.setMessageCallback(async (m) => {
-        const msg = m.messages[0];
-        if (!msg.message) return;
+        const msg = m.messages?.[0];
+        if (!msg?.message) return;
 
         const sender = msg.key.remoteJid?.split('@')[0] || "unknown";
         const pushName = msg.pushName || "WhatsApp User";
@@ -333,7 +333,7 @@ export default function (pi: ExtensionAPI) {
                     } else {
                         ctx.ui.notify(`Failed to send WhatsApp reply`, 'error');
                     }
-                } catch (error) {
+                } catch {
                     ctx.ui.notify(`Failed to send WhatsApp reply`, 'error');
                 }
             }