what-core 0.6.1 → 0.7.0

package/dist/testing.js

@@ -8,42 +8,41 @@ var insideComputed = false;
 var batchDepth = 0;
 var pendingEffects = [];
 var pendingNeedSort = false;
-var subSetOwner = /* @__PURE__ */ new WeakMap();
 var NEEDS_UPSTREAM = /* @__PURE__ */ Symbol("needs_upstream");
 function signal(initial, debugName) {
   let value = initial;
   const subs = /* @__PURE__ */ new Set();
-  function sig(...args) {
-    if (args.length === 0) {
-      if (currentEffect) {
-        subs.add(currentEffect);
-        currentEffect.deps.push(subs);
-      }
-      return value;
-    }
+  let lastTracked = null;
+  let lastTrackedEpoch = 0;
+  function _sigWrite(next) {
     if (__DEV__ && insideComputed) {
       console.warn(
         "[what] Signal.set() called inside a computed function. This may cause infinite loops. Use effect() instead." + (debugName ? ` (signal: ${debugName})` : "")
       );
     }
-    const nextVal = typeof args[0] === "function" ? args[0](value) : args[0];
-    if (Object.is(value, nextVal)) return;
+    const nextVal = typeof next === "function" ? next(value) : next;
+    if (value === nextVal || value !== value && nextVal !== nextVal) return;
     value = nextVal;
+    lastTracked = null;
     if (__DEV__ && __devtools) __devtools.onSignalUpdate(sig);
     if (subs.size > 0) notify(subs);
   }
-  sig.set = (next) => {
-    if (__DEV__ && insideComputed) {
-      console.warn(
-        "[what] Signal.set() called inside a computed function. This may cause infinite loops. Use effect() instead." + (debugName ? ` (signal: ${debugName})` : "")
-      );
+  function sig(newVal) {
+    if (arguments.length === 0) {
+      const ce = currentEffect;
+      if (ce !== null) {
+        if (ce !== lastTracked || ce._epoch !== lastTrackedEpoch) {
+          lastTracked = ce;
+          lastTrackedEpoch = ce._epoch;
+          subs.add(ce);
+          ce.deps.push(subs);
+        }
+      }
+      return value;
     }
-    const nextVal = typeof next === "function" ? next(value) : next;
-    if (Object.is(value, nextVal)) return;
-    value = nextVal;
-    if (__DEV__ && __devtools) __devtools.onSignalUpdate(sig);
-    if (subs.size > 0) notify(subs);
-  };
+    _sigWrite(newVal);
+  }
+  sig.set = _sigWrite;
   sig.peek = () => value;
   sig.subscribe = (fn) => {
     return effect(() => fn(sig()));
@@ -60,7 +59,7 @@ function _updateLevel(e) {
   let maxDepLevel = 0;
   const deps = e.deps;
   for (let i = 0; i < deps.length; i++) {
-    const owner = subSetOwner.get(deps[i]);
+    const owner = deps[i]._owner;
     if (owner) {
       const depLevel = owner._level;
       if (depLevel > maxDepLevel) maxDepLevel = depLevel;
@@ -106,8 +105,12 @@ function _createEffect(fn, lazy) {
     // reference to the computed's subscriber set
     _isDirty: null,
     // function to check if computed is dirty (set by computed())
-    _markDirty: null
+    _markDirty: null,
     // function to mark computed dirty (set by computed())
+    _cleanup: null,
+    // cleanup function returned by effect fn (declared upfront for shape)
+    _epoch: 0
+    // incremented on cleanup — used by signal lastTracked cache
   };
   if (__DEV__ && __devtools) __devtools.onEffectCreate(e);
   return e;
@@ -137,12 +140,13 @@ function _runEffect(e) {
     if (__DEV__ && __devtools?.onEffectRun) __devtools.onEffectRun(e);
     return;
   }
+  const singleDep = e.deps.length === 1 ? e.deps[0] : null;
   cleanup(e);
   if (e._cleanup) {
     try {
       e._cleanup();
     } catch (err) {
-      if (__devtools?.onError) __devtools.onError(err, { type: "effect-cleanup", effect: e });
+      if (__DEV__ && __devtools?.onError) __devtools.onError(err, { type: "effect-cleanup", effect: e });
       if (__DEV__) console.warn("[what] Error in effect cleanup:", err);
     }
     e._cleanup = null;
@@ -156,11 +160,14 @@ function _runEffect(e) {
     }
   } catch (err) {
     if (err === NEEDS_UPSTREAM) throw err;
-    if (__devtools?.onError) __devtools.onError(err, { type: "effect", effect: e });
+    if (__DEV__ && __devtools?.onError) __devtools.onError(err, { type: "effect", effect: e });
     throw err;
   } finally {
     currentEffect = prev;
   }
+  if (singleDep !== null && e.deps.length === 1 && e.deps[0] === singleDep && !e._cleanup && !e._pending) {
+    e._stable = true;
+  }
   if (__DEV__ && __devtools?.onEffectRun) __devtools.onEffectRun(e);
 }
 function _disposeEffect(e) {
@@ -180,45 +187,51 @@ function cleanup(e) {
   const deps = e.deps;
   for (let i = 0; i < deps.length; i++) deps[i].delete(e);
   deps.length = 0;
+  e._epoch++;
 }
 var notifyDepth = 0;
 var notifyQueue = null;
 var notifyQueueLen = 0;
+function _processSubscriber(e) {
+  if (e.disposed) return;
+  if (e._onNotify) {
+    e._onNotify();
+  } else if (!e._pending) {
+    if (batchDepth === 0 && e._stable) {
+      const prev = currentEffect;
+      currentEffect = null;
+      try {
+        const result = e.fn();
+        if (typeof result === "function") {
+          if (e._cleanup) try {
+            e._cleanup();
+          } catch (err) {
+          }
+          e._cleanup = result;
+        }
+      } catch (err) {
+        if (__DEV__ && __devtools?.onError) __devtools.onError(err, { type: "effect", effect: e });
+        if (__DEV__) console.warn("[what] Error in stable effect:", err);
+      } finally {
+        currentEffect = prev;
+      }
+    } else {
+      e._pending = true;
+      const level = e._level;
+      const len = pendingEffects.length;
+      if (len > 0 && pendingEffects[len - 1]._level > level) {
+        pendingNeedSort = true;
+      }
+      pendingEffects.push(e);
+    }
+  }
+}
 function notify(subs) {
   if (notifyDepth === 0) {
     notifyDepth = 1;
     try {
       for (const e of subs) {
-        if (e.disposed) continue;
-        if (e._onNotify) {
-          e._onNotify();
-        } else if (batchDepth === 0 && e._stable) {
-          const prev = currentEffect;
-          currentEffect = null;
-          try {
-            const result = e.fn();
-            if (typeof result === "function") {
-              if (e._cleanup) try {
-                e._cleanup();
-              } catch (err) {
-              }
-              e._cleanup = result;
-            }
-          } catch (err) {
-            if (__devtools?.onError) __devtools.onError(err, { type: "effect", effect: e });
-            if (__DEV__) console.warn("[what] Error in stable effect:", err);
-          } finally {
-            currentEffect = prev;
-          }
-        } else if (!e._pending) {
-          e._pending = true;
-          const level = e._level;
-          const len = pendingEffects.length;
-          if (len > 0 && pendingEffects[len - 1]._level > level) {
-            pendingNeedSort = true;
-          }
-          pendingEffects.push(e);
-        }
+        _processSubscriber(e);
       }
       if (notifyQueueLen > 0) {
         let qi = 0;
@@ -227,36 +240,7 @@ function notify(subs) {
           notifyQueue[qi] = null;
           qi++;
           for (const e of queuedSubs) {
-            if (e.disposed) continue;
-            if (e._onNotify) {
-              e._onNotify();
-            } else if (batchDepth === 0 && e._stable) {
-              const prev = currentEffect;
-              currentEffect = null;
-              try {
-                const result = e.fn();
-                if (typeof result === "function") {
-                  if (e._cleanup) try {
-                    e._cleanup();
-                  } catch (err) {
-                  }
-                  e._cleanup = result;
-                }
-              } catch (err) {
-                if (__devtools?.onError) __devtools.onError(err, { type: "effect", effect: e });
-                if (__DEV__) console.warn("[what] Error in stable effect:", err);
-              } finally {
-                currentEffect = prev;
-              }
-            } else if (!e._pending) {
-              e._pending = true;
-              const level = e._level;
-              const len = pendingEffects.length;
-              if (len > 0 && pendingEffects[len - 1]._level > level) {
-                pendingNeedSort = true;
-              }
-              pendingEffects.push(e);
-            }
+            _processSubscriber(e);
           }
         }
         notifyQueueLen = 0;
@@ -312,8 +296,6 @@ function flush() {
       iterations++;
     }
     if (iterations >= 25) {
-      for (let i = 0; i < pendingEffects.length; i++) pendingEffects[i]._pending = false;
-      pendingEffects.length = 0;
       if (__DEV__) {
         const remaining = pendingEffects.slice(0, 3);
         const effectNames = remaining.map((e) => e.fn?.name || e.fn?.toString().slice(0, 60) || "(anonymous)");
@@ -323,6 +305,8 @@ function flush() {
       } else {
         console.warn("[what] Possible infinite effect loop detected");
       }
+      for (let i = 0; i < pendingEffects.length; i++) pendingEffects[i]._pending = false;
+      pendingEffects.length = 0;
     }
   } finally {
     isFlushing = false;
@@ -411,9 +395,22 @@ function _disposeRoot(root) {
 
 // packages/core/src/h.js
 var EMPTY_OBJ = /* @__PURE__ */ Object.create(null);
-function h(tag, props, ...children) {
+var EMPTY_ARR = [];
+function h(tag, props) {
   props = props || EMPTY_OBJ;
-  const flat = flattenChildren(children);
+  const argLen = arguments.length;
+  let flat;
+  if (argLen <= 2) {
+    flat = EMPTY_ARR;
+  } else if (argLen === 3) {
+    flat = _flattenSingle(arguments[2]);
+  } else {
+    const out = [];
+    for (let i = 2; i < argLen; i++) {
+      _flattenInto(arguments[i], out);
+    }
+    flat = out;
+  }
   const key = props.key ?? null;
   if (props.key !== void 0) {
     props = { ...props };
@@ -421,22 +418,30 @@ function h(tag, props, ...children) {
   }
   return { tag, props, children: flat, key, _vnode: true };
 }
-function flattenChildren(children) {
-  const out = [];
-  for (let i = 0; i < children.length; i++) {
-    const child = children[i];
-    if (child == null || child === false || child === true) continue;
-    if (Array.isArray(child)) {
-      out.push(...flattenChildren(child));
-    } else if (typeof child === "object" && child._vnode) {
-      out.push(child);
-    } else if (typeof child === "function") {
-      out.push(child);
-    } else {
-      out.push(String(child));
-    }
+function _flattenSingle(child) {
+  if (child == null || child === false || child === true) return EMPTY_ARR;
+  if (Array.isArray(child)) {
+    const out = [];
+    _flattenInto(child, out);
+    return out;
+  }
+  if (typeof child === "object" && child._vnode) return [child];
+  if (typeof child === "function") return [child];
+  return [String(child)];
+}
+function _flattenInto(child, out) {
+  if (child == null || child === false || child === true) return;
+  if (Array.isArray(child)) {
+    for (let i = 0; i < child.length; i++) {
+      _flattenInto(child[i], out);
+    }
+  } else if (typeof child === "object" && child._vnode) {
+    out.push(child);
+  } else if (typeof child === "function") {
+    out.push(child);
+  } else {
+    out.push(String(child));
   }
-  return out;
 }
 
 // packages/core/src/components.js
@@ -570,9 +575,11 @@ function disposeTree(node) {
   if (node._componentCtx) {
     disposeComponent(node._componentCtx);
   }
-  const commentCtx = _commentCtxMap.get(node);
-  if (commentCtx) {
-    disposeComponent(commentCtx);
+  if (node.nodeType === 8) {
+    const commentCtx = _commentCtxMap.get(node);
+    if (commentCtx) {
+      disposeComponent(commentCtx);
+    }
   }
   if (node._dispose) {
     try {
@@ -588,9 +595,10 @@ function disposeTree(node) {
       }
     }
   }
-  if (node.childNodes) {
-    for (const child of node.childNodes) {
-      disposeTree(child);
+  const children = node.childNodes;
+  if (children && children.length > 0) {
+    for (let i = 0; i < children.length; i++) {
+      disposeTree(children[i]);
     }
   }
 }
@@ -668,6 +676,27 @@ function createDOM(vnode, parent, isSvg) {
   }
   return document.createTextNode(String(vnode));
 }
+var _propsProxyHandler = {
+  get(target, key) {
+    if (key === "_sig") return void 0;
+    return target._sig()[key];
+  },
+  has(target, key) {
+    if (key === "_sig") return false;
+    return key in target._sig();
+  },
+  ownKeys(target) {
+    return Reflect.ownKeys(target._sig());
+  },
+  getOwnPropertyDescriptor(target, key) {
+    if (key === "_sig") return void 0;
+    const current = target._sig();
+    if (key in current) {
+      return { value: current[key], writable: false, enumerable: true, configurable: true };
+    }
+    return void 0;
+  }
+};
 var componentStack = [];
 function getCurrentComponent() {
   return componentStack[componentStack.length - 1];
@@ -693,6 +722,21 @@ function createComponent(vnode, parent, isSvg) {
   if (Component === "__portal" || vnode.tag === "__portal") {
     return createPortalDOM(vnode, parent);
   }
+  const parentCtx = componentStack[componentStack.length - 1] || null;
+  let errorBoundary = null;
+  if (parentCtx) {
+    errorBoundary = parentCtx._errorBoundary || null;
+    if (!errorBoundary) {
+      let p = parentCtx._parentCtx;
+      while (p) {
+        if (p._errorBoundary) {
+          errorBoundary = p._errorBoundary;
+          break;
+        }
+        p = p._parentCtx;
+      }
+    }
+  }
   const ctx = {
     hooks: [],
     hookIndex: 0,
@@ -701,15 +745,8 @@ function createComponent(vnode, parent, isSvg) {
     mounted: false,
     disposed: false,
     Component,
-    _parentCtx: componentStack[componentStack.length - 1] || null,
-    _errorBoundary: (() => {
-      let p = componentStack[componentStack.length - 1];
-      while (p) {
-        if (p._errorBoundary) return p._errorBoundary;
-        p = p._parentCtx;
-      }
-      return null;
-    })()
+    _parentCtx: parentCtx,
+    _errorBoundary: errorBoundary
   };
   const startComment = document.createComment("c:start");
   const endComment = document.createComment("c:end");
@@ -722,29 +759,15 @@ function createComponent(vnode, parent, isSvg) {
   mountedComponents.add(ctx);
   if (__DEV__ && __devtools?.onComponentMount) __devtools.onComponentMount(ctx);
   const propsChildren = children.length === 0 ? void 0 : children.length === 1 ? children[0] : children;
-  const propsSignal = signal({ ...props, children: propsChildren });
+  let mergedProps;
+  if (propsChildren !== void 0) {
+    mergedProps = props ? Object.assign({}, props, { children: propsChildren }) : { children: propsChildren };
+  } else {
+    mergedProps = props ? Object.assign({}, props) : {};
+  }
+  const propsSignal = signal(mergedProps);
   ctx._propsSignal = propsSignal;
-  const reactiveProps = new Proxy({}, {
-    get(_, key) {
-      const current = propsSignal();
-      return current[key];
-    },
-    has(_, key) {
-      const current = propsSignal();
-      return key in current;
-    },
-    ownKeys() {
-      const current = propsSignal();
-      return Reflect.ownKeys(current);
-    },
-    getOwnPropertyDescriptor(_, key) {
-      const current = propsSignal();
-      if (key in current) {
-        return { value: current[key], writable: false, enumerable: true, configurable: true };
-      }
-      return void 0;
-    }
-  });
+  const reactiveProps = new Proxy({ _sig: propsSignal }, _propsProxyHandler);
   componentStack.push(ctx);
   let result;
   try {
@@ -925,21 +948,22 @@ function createElementFromVNode(vnode, parent, isSvg) {
   if (props) {
     applyProps(el, props, {}, svgContext);
   }
-  for (const child of children) {
-    const node = createDOM(child, el, svgContext && tag !== "foreignObject");
+  const isSvgChildren = svgContext && tag !== "foreignObject";
+  for (let i = 0; i < children.length; i++) {
+    const node = createDOM(children[i], el, isSvgChildren);
     if (node) el.appendChild(node);
   }
   el._vnode = vnode;
   return el;
 }
 function applyProps(el, newProps, oldProps, isSvg) {
-  newProps = newProps || {};
-  oldProps = oldProps || {};
+  if (!newProps) return;
   for (const key in newProps) {
     if (key === "key" || key === "children") continue;
     if (key === "ref") {
-      if (typeof newProps.ref === "function") newProps.ref(el);
-      else if (newProps.ref) newProps.ref.current = el;
+      const ref = newProps.ref;
+      if (typeof ref === "function") ref(el);
+      else if (ref) ref.current = el;
       continue;
     }
     setProp(el, key, newProps[key], isSvg);
@@ -976,8 +1000,9 @@ function setProp(el, key, value, isSvg) {
     if (!el._events) el._events = {};
     const wrappedHandler = (e) => {
       if (!e.nativeEvent) e.nativeEvent = e;
-      return untrack(() => value(e));
+      return untrack(() => wrappedHandler._handler(e));
     };
+    wrappedHandler._handler = value;
     wrappedHandler._original = value;
     el._events[storageKey] = wrappedHandler;
     const eventOpts = value._eventOpts;