what-core 0.5.6 → 0.6.0

package/src/reactive.js

@@ -1,5 +1,11 @@
 // What Framework - Reactive Primitives
 // Signals + Effects: fine-grained reactivity without virtual DOM overhead
+//
+// Upgrades:
+// - Topological ordering: computed/effects sorted by _level to prevent diamond glitches
+// - Iterative computed evaluation: no recursion, handles 10K+ depth chains
+// - Ownership tree: createRoot children auto-dispose when parent disposes
+// - Performance: cached levels, lazy sort, fast-path notify, minimal allocation
 
 // Dev-mode flag — build tools can dead-code-eliminate when false
 export const __DEV__ = typeof process !== 'undefined'
@@ -17,8 +23,22 @@ export function __setDevToolsHooks(hooks) {
 
 let currentEffect = null;
 let currentRoot = null;
+let currentOwner = null;  // Ownership tree: tracks current owner context
+let insideComputed = false; // Track whether we're inside a computed() callback (dev-mode warning)
 let batchDepth = 0;
 let pendingEffects = [];
+let pendingNeedSort = false;  // Track whether pendingEffects actually needs sorting
+
+// WeakMap: subscriber Set → owning computed's inner effect (null/absent for signals)
+// Used for topological level computation.
+const subSetOwner = new WeakMap();
+
+// --- Iterative Computed Evaluation State ---
+// Uses a throw/catch trampoline to convert recursive computed evaluation
+// to iterative. When a computed fn() reads another dirty computed, instead
+// of recursing, we throw a sentinel that gets caught by the outer loop.
+const NEEDS_UPSTREAM = Symbol('needs_upstream');
+let iterativeEvalStack = null;  // array when inside evaluation loop, null otherwise
 
 // --- Signal ---
 // A reactive value. Reading inside an effect auto-tracks the dependency.
@@ -39,19 +59,33 @@ export function signal(initial, debugName) {
       return value;
     }
     // Write
+    if (__DEV__ && insideComputed) {
+      console.warn(
+        '[what] Signal.set() called inside a computed function. ' +
+        'This may cause infinite loops. Use effect() instead.' +
+        (debugName ? ` (signal: ${debugName})` : '')
+      );
+    }
     const nextVal = typeof args[0] === 'function' ? args[0](value) : args[0];
     if (Object.is(value, nextVal)) return;
     value = nextVal;
     if (__DEV__ && __devtools) __devtools.onSignalUpdate(sig);
-    notify(subs);
+    if (subs.size > 0) notify(subs);
   }
 
   sig.set = (next) => {
+    if (__DEV__ && insideComputed) {
+      console.warn(
+        '[what] Signal.set() called inside a computed function. ' +
+        'This may cause infinite loops. Use effect() instead.' +
+        (debugName ? ` (signal: ${debugName})` : '')
+      );
+    }
     const nextVal = typeof next === 'function' ? next(value) : next;
     if (Object.is(value, nextVal)) return;
     value = nextVal;
     if (__DEV__ && __devtools) __devtools.onSignalUpdate(sig);
-    notify(subs);
+    if (subs.size > 0) notify(subs);
   };
 
   sig.peek = () => value;
@@ -74,48 +108,159 @@ export function signal(initial, debugName) {
 
 // --- Computed ---
 // Derived signal. Lazy: only recomputes when a dependency changes AND it's read.
+// Topological level: max(dependency levels) + 1, computed from source signals (level 0).
 
 export function computed(fn) {
   let value, dirty = true;
   const subs = new Set();
 
   const inner = _createEffect(() => {
-    value = fn();
-    dirty = false;
+    const prevInsideComputed = insideComputed;
+    if (__DEV__) insideComputed = true;
+    try {
+      value = fn();
+      dirty = false;
+    } finally {
+      if (__DEV__) insideComputed = prevInsideComputed;
+    }
   }, true);
 
+  // Computed nodes start at level 1. Updated when graph structure changes.
+  inner._level = 1;
+  inner._computed = true;
+  inner._computedSubs = subs;
+
+  // Register this subscriber set as owned by this computed
+  subSetOwner.set(subs, inner);
+
+  // Store markDirty/isDirty closures on the inner effect for iterative eval
+  inner._markDirty = () => { dirty = true; };
+  inner._isDirty = () => dirty;
+
   function read() {
     if (currentEffect) {
       subs.add(currentEffect);
       currentEffect.deps.push(subs);
     }
-    if (dirty) _runEffect(inner);
+    if (dirty) _evaluateComputed(inner);
     return value;
   }
 
   // When a dependency changes, mark dirty AND propagate to our subscribers.
-  // This is how effects that read this computed know to re-run:
-  // signal changes → computed._onNotify → computed's subs get notified.
   inner._onNotify = () => {
     dirty = true;
-    notify(subs);
+    if (subs.size > 0) notify(subs);
   };
 
   read._signal = true;
   read.peek = () => {
-    if (dirty) _runEffect(inner);
+    if (dirty) _evaluateComputed(inner);
     return value;
   };
 
   return read;
 }
 
+// --- Iterative Computed Evaluation ---
+//
+// Problem: A chain of N dirty computeds causes O(N) recursive calls:
+// C_N.read() → eval → fn() → C_{N-1}.read() → eval → fn() → ... → C_1.read() → eval → fn()
+// This overflows the stack at ~3500 depth.
+//
+// Solution: Throw/catch trampoline. The outermost _evaluateComputed manages a
+// stack (array). When a computed's fn() reads another dirty computed during
+// evaluation, _evaluateComputed throws NEEDS_UPSTREAM. The outer loop catches
+// this, adds the upstream to the stack, and processes from the bottom up.
+// This converts O(N) call depth to O(1) per computed (just the outermost loop).
+
+function _evaluateComputed(computedEffect) {
+  if (iterativeEvalStack !== null) {
+    // We're inside the outermost evaluation loop, and a computed's fn()
+    // is reading another dirty computed. Push it onto the stack and throw
+    // to abort the current fn() so the outer loop can process it first.
+    iterativeEvalStack.push(computedEffect);
+    throw NEEDS_UPSTREAM;
+  }
+
+  // Outermost call — enter the iterative evaluation loop.
+  // The stack grows as we discover dirty upstream computeds.
+  const stack = [computedEffect];
+  iterativeEvalStack = stack;
+
+  try {
+    while (stack.length > 0) {
+      const current = stack[stack.length - 1];
+
+      if (!current._isDirty || !current._isDirty()) {
+        // Already clean — pop and continue
+        stack.pop();
+        continue;
+      }
+
+      // Pre-scan known deps: if any are dirty computeds, push them onto
+      // the stack first (bottom-up). This avoids the O(N^2) worst case
+      // where throw/catch restarts from the top on each dirty upstream.
+      let pushedUpstream = false;
+      const deps = current.deps;
+      for (let i = 0; i < deps.length; i++) {
+        const depOwner = subSetOwner.get(deps[i]);
+        if (depOwner && depOwner._computed && depOwner._isDirty && depOwner._isDirty()) {
+          stack.push(depOwner);
+          pushedUpstream = true;
+        }
+      }
+      if (pushedUpstream) {
+        // Process dirty upstreams first before re-evaluating current
+        continue;
+      }
+
+      // All known deps are clean — evaluate. throw/catch is fallback
+      // for newly-discovered deps only.
+      try {
+        const prevDepsLen = current.deps.length;
+        _runEffect(current);
+        // Only recompute level when graph structure changes
+        if (current.deps.length !== prevDepsLen) {
+          _updateLevel(current);
+        }
+        stack.pop(); // Successfully evaluated
+      } catch (err) {
+        if (err === NEEDS_UPSTREAM) {
+          // A dirty upstream was discovered and pushed onto the stack.
+          // Re-mark this computed dirty since its fn() was aborted mid-execution.
+          current._markDirty();
+          // The upstream is now at stack[stack.length-1]. Loop continues.
+        } else {
+          throw err; // Re-throw real errors
+        }
+      }
+    }
+  } finally {
+    iterativeEvalStack = null;
+  }
+}
+
+// Update the topological level of a computed/effect based on its current dependencies.
+function _updateLevel(e) {
+  let maxDepLevel = 0;
+  const deps = e.deps;
+  for (let i = 0; i < deps.length; i++) {
+    const owner = subSetOwner.get(deps[i]);
+    if (owner) {
+      const depLevel = owner._level;
+      if (depLevel > maxDepLevel) maxDepLevel = depLevel;
+    }
+  }
+  e._level = maxDepLevel + 1;
+}
+
 // --- Effect ---
 // Runs a function, auto-tracking signal reads. Re-runs when deps change.
 // Returns a dispose function.
 
 export function effect(fn, opts) {
   const e = _createEffect(fn);
+  e._level = 1;
   // First run: skip cleanup (deps is empty), just run and track
   const prev = currentEffect;
   currentEffect = e;
@@ -125,6 +270,8 @@ export function effect(fn, opts) {
   } finally {
     currentEffect = prev;
   }
+  // Compute level after first run based on actual dependencies (cached).
+  _updateLevel(e);
   // Mark as stable after first run — subsequent re-runs skip cleanup/re-subscribe
   if (opts?.stable) e._stable = true;
   const dispose = () => _disposeEffect(e);
@@ -151,6 +298,8 @@ export function batch(fn) {
 // --- Internals ---
 
 function _createEffect(fn, lazy) {
+  // Minimal object shape — computed() adds extra properties after creation.
+  // Keeping the base object small helps V8 optimize for the common (effect) case.
   const e = {
     fn,
     deps: [],            // array of subscriber sets (cheaper than Set for typical 1-3 deps)
@@ -159,6 +308,11 @@ function _createEffect(fn, lazy) {
     disposed: false,
     _pending: false,
     _stable: false,      // stable effects skip cleanup/re-subscribe on re-run
+    _level: 0,           // topological depth: signals=0, computed/effects=max(deps)+1
+    _computed: false,     // true for computed inner effects
+    _computedSubs: null,  // reference to the computed's subscriber set
+    _isDirty: null,       // function to check if computed is dirty (set by computed())
+    _markDirty: null,     // function to mark computed dirty (set by computed())
   };
   if (__DEV__ && __devtools) __devtools.onEffectCreate(e);
   return e;
@@ -168,7 +322,6 @@ function _runEffect(e) {
   if (e.disposed) return;
 
   // Stable effect fast path: deps don't change, skip cleanup/re-subscribe.
-  // Effect stays subscribed to its signals from the first run.
   if (e._stable) {
     if (e._cleanup) {
       try { e._cleanup(); } catch (err) {
@@ -209,6 +362,7 @@ function _runEffect(e) {
       e._cleanup = result;
     }
   } catch (err) {
+    if (err === NEEDS_UPSTREAM) throw err; // Iterative eval sentinel — not a real error
     if (__devtools?.onError) __devtools.onError(err, { type: 'effect', effect: e });
     throw err;
   } finally {
@@ -236,34 +390,107 @@ function cleanup(e) {
   deps.length = 0;
 }
 
+// --- Notification ---
+// Iterative notification to prevent stack overflow on deep computed chains.
+// Uses a reusable queue to avoid per-call array allocation.
+// When notify() encounters _onNotify callbacks (from computeds), those may
+// call notify() recursively. The queue drains iteratively in the outermost call.
+
+let notifyDepth = 0;        // Tracks recursive notify depth
+let notifyQueue = null;     // Reusable queue, allocated on first recursive call
+let notifyQueueLen = 0;     // Length of the queue
+
 function notify(subs) {
-  for (const e of subs) {
-    if (e.disposed) continue;
-    if (e._onNotify) {
-      e._onNotify();
-    } else if (batchDepth === 0 && e._stable) {
-      // Inline execution for stable effects: skip queue + flush + _runEffect overhead.
-      // Safe because stable effects have fixed deps (no re-subscribe needed).
-      const prev = currentEffect;
-      currentEffect = null;
-      try {
-        const result = e.fn();
-        if (typeof result === 'function') {
-          if (e._cleanup) try { e._cleanup(); } catch (err) {}
-          e._cleanup = result;
+  // Fast path: no recursive notifications in progress — iterate directly.
+  // This avoids array allocation for the common case (signal → effects).
+  if (notifyDepth === 0) {
+    notifyDepth = 1;
+    try {
+      for (const e of subs) {
+        if (e.disposed) continue;
+        if (e._onNotify) {
+          // Computed subscriber: mark dirty and propagate.
+          // _onNotify may call notify() recursively — tracked by notifyDepth.
+          e._onNotify();
+        } else if (batchDepth === 0 && e._stable) {
+          // Inline execution for stable effects
+          const prev = currentEffect;
+          currentEffect = null;
+          try {
+            const result = e.fn();
+            if (typeof result === 'function') {
+              if (e._cleanup) try { e._cleanup(); } catch (err) {}
+              e._cleanup = result;
+            }
+          } catch (err) {
+            if (__devtools?.onError) __devtools.onError(err, { type: 'effect', effect: e });
+            if (__DEV__) console.warn('[what] Error in stable effect:', err);
+          } finally {
+            currentEffect = prev;
+          }
+        } else if (!e._pending) {
+          e._pending = true;
+          const level = e._level;
+          const len = pendingEffects.length;
+          if (len > 0 && pendingEffects[len - 1]._level > level) {
+            pendingNeedSort = true;
+          }
+          pendingEffects.push(e);
         }
-      } catch (err) {
-        if (__devtools?.onError) __devtools.onError(err, { type: 'effect', effect: e });
-        if (__DEV__) console.warn('[what] Error in stable effect:', err);
-      } finally {
-        currentEffect = prev;
       }
-    } else if (!e._pending) {
-      e._pending = true;
-      pendingEffects.push(e);
+      // Drain any queued subscriber sets from recursive notify calls
+      if (notifyQueueLen > 0) {
+        let qi = 0;
+        while (qi < notifyQueueLen) {
+          const queuedSubs = notifyQueue[qi];
+          notifyQueue[qi] = null; // Allow GC
+          qi++;
+          for (const e of queuedSubs) {
+            if (e.disposed) continue;
+            if (e._onNotify) {
+              e._onNotify();
+            } else if (batchDepth === 0 && e._stable) {
+              const prev = currentEffect;
+              currentEffect = null;
+              try {
+                const result = e.fn();
+                if (typeof result === 'function') {
+                  if (e._cleanup) try { e._cleanup(); } catch (err) {}
+                  e._cleanup = result;
+                }
+              } catch (err) {
+                if (__devtools?.onError) __devtools.onError(err, { type: 'effect', effect: e });
+                if (__DEV__) console.warn('[what] Error in stable effect:', err);
+              } finally {
+                currentEffect = prev;
+              }
+            } else if (!e._pending) {
+              e._pending = true;
+              const level = e._level;
+              const len = pendingEffects.length;
+              if (len > 0 && pendingEffects[len - 1]._level > level) {
+                pendingNeedSort = true;
+              }
+              pendingEffects.push(e);
+            }
+          }
+        }
+        notifyQueueLen = 0;
+      }
+    } finally {
+      notifyDepth = 0;
     }
+    if (batchDepth === 0 && pendingEffects.length > 0) scheduleMicrotask();
+  } else {
+    // Recursive call — queue the subscriber set for the outermost call to drain.
+    if (notifyQueue === null) notifyQueue = [];
+    if (notifyQueueLen >= notifyQueue.length) {
+      notifyQueue.push(subs);
+    } else {
+      notifyQueue[notifyQueueLen] = subs;
+    }
+    notifyQueueLen++;
   }
-  if (batchDepth === 0 && pendingEffects.length > 0) scheduleMicrotask();
 }
 
 let microtaskScheduled = false;
@@ -282,10 +509,28 @@ function flush() {
   while (pendingEffects.length > 0 && iterations < 25) {
     const batch = pendingEffects;
     pendingEffects = [];
+
+    // Topological sort: execute effects in level order (lowest first).
+    // Fast paths:
+    // 1. Single effect — no sort needed (most common case for microtask flush)
+    // 2. Already sorted — skip sort (common when effects added in level order)
+    // 3. Multiple effects at different levels — sort required
+    if (batch.length > 1 && pendingNeedSort) {
+      batch.sort((a, b) => a._level - b._level);
+    }
+    pendingNeedSort = false;
+
     for (let i = 0; i < batch.length; i++) {
       const e = batch[i];
       e._pending = false;
-      if (!e.disposed && !e._onNotify) _runEffect(e);
+      if (!e.disposed && !e._onNotify) {
+        const prevDepsLen = e.deps.length;
+        _runEffect(e);
+        // Update level only if deps changed (graph structure change)
+        if (!e._computed && e.deps.length !== prevDepsLen) {
+          _updateLevel(e);
+        }
+      }
     }
     iterations++;
   }
@@ -309,9 +554,9 @@ function flush() {
 
 // --- Memo ---
 // Eager computed that only propagates when the value actually changes.
-// Reads deps eagerly (unlike lazy computed), but skips notifying subscribers
-// when the recomputed value is the same. Critical for patterns like:
-//   memo(() => selected() === item().id)  — 1000 memos, only 2 change
+// Fix: Instead of calling notify(subs) inline (which bypasses topological sort
+// and causes diamond-dependency glitches), push memo subscribers into
+// pendingEffects and let them go through the sorted flush() path.
 export function memo(fn) {
   let value;
   const subs = new Set();
@@ -320,11 +565,33 @@ export function memo(fn) {
     const next = fn();
     if (!Object.is(value, next)) {
       value = next;
-      notify(subs);
+      // Push subscribers into pendingEffects for topological flush
+      // instead of inline notify() which can cause diamond glitches
+      for (const sub of subs) {
+        if (sub.disposed) continue;
+        if (sub._onNotify) {
+          // Computed subscriber: mark dirty and propagate
+          sub._onNotify();
+        } else if (!sub._pending) {
+          sub._pending = true;
+          const level = sub._level;
+          const len = pendingEffects.length;
+          if (len > 0 && pendingEffects[len - 1]._level > level) {
+            pendingNeedSort = true;
+          }
+          pendingEffects.push(sub);
+        }
+      }
     }
   });
 
+  e._level = 1;
+
   _runEffect(e);
+  _updateLevel(e);
+
+  // Register subscriber set owner for level tracking
+  subSetOwner.set(subs, e);
 
   // Register with current root
   if (currentRoot) {
@@ -363,22 +630,103 @@ export function untrack(fn) {
   }
 }
 
+// --- getOwner / runWithOwner ---
+// Expose ownership context for advanced use cases (e.g., async operations
+// that need to register disposals with the correct owner).
+
+export function getOwner() {
+  return currentOwner;
+}
+
+export function runWithOwner(owner, fn) {
+  const prev = currentOwner;
+  const prevRoot = currentRoot;
+  currentOwner = owner;
+  currentRoot = owner;
+  try {
+    return fn();
+  } finally {
+    currentOwner = prev;
+    currentRoot = prevRoot;
+  }
+}
+
 // --- createRoot ---
-// Isolated reactive scope. All effects created inside are tracked and disposed together.
-// Essential for per-item cleanup in reactive lists.
+// Isolated reactive scope with ownership tree.
+// All effects created inside are tracked and disposed together.
+// Child createRoot scopes register with parent owner — disposing parent
+// automatically disposes all children (prevents orphaned subscriptions).
 export function createRoot(fn) {
   const prevRoot = currentRoot;
-  const root = { disposals: [], owner: currentRoot };
+  const prevOwner = currentOwner;
+  const root = {
+    disposals: [],
+    owner: currentOwner,     // parent owner for ownership tree
+    children: [],            // child roots (ownership tree)
+    _disposed: false,
+  };
+
+  // Register this root as a child of the parent owner
+  if (currentOwner) {
+    currentOwner.children.push(root);
+  }
+
   currentRoot = root;
+  currentOwner = root;
+
   try {
     const dispose = () => {
+      if (root._disposed) return;
+      root._disposed = true;
+
+      // Dispose children first (depth-first, reverse order)
+      for (let i = root.children.length - 1; i >= 0; i--) {
+        _disposeRoot(root.children[i]);
+      }
+      root.children.length = 0;
+
+      // Dispose own effects (reverse order for LIFO cleanup)
       for (let i = root.disposals.length - 1; i >= 0; i--) {
         root.disposals[i]();
       }
       root.disposals.length = 0;
+
+      // Remove from parent's children list
+      if (root.owner) {
+        const idx = root.owner.children.indexOf(root);
+        if (idx >= 0) root.owner.children.splice(idx, 1);
+      }
     };
     return fn(dispose);
   } finally {
     currentRoot = prevRoot;
+    currentOwner = prevOwner;
+  }
+}
+
+// Internal: dispose a root and all its children
+function _disposeRoot(root) {
+  if (root._disposed) return;
+  root._disposed = true;
+
+  // Dispose children first
+  for (let i = root.children.length - 1; i >= 0; i--) {
+    _disposeRoot(root.children[i]);
+  }
+  root.children.length = 0;
+
+  // Dispose own effects
+  for (let i = root.disposals.length - 1; i >= 0; i--) {
+    root.disposals[i]();
+  }
+  root.disposals.length = 0;
+}
+
+// --- onCleanup ---
+// Register a cleanup function with the current owner/root.
+// Runs when the owner is disposed.
+export function onCleanup(fn) {
+  if (currentRoot) {
+    currentRoot.disposals.push(fn);
   }
 }