what-core 0.5.5 → 0.5.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "what-core",
-  "version": "0.5.5",
+  "version": "0.5.6",
   "description": "What Framework - The closest framework to vanilla JS",
   "type": "module",
   "main": "src/index.js",

package/src/dom.js

@@ -544,7 +544,7 @@ function reconcileUnkeyed(parent, oldNodes, newVNodes, beforeMarker) {
       const node = createDOM(newVNode, parent);
       if (node) {
         const ref = getInsertionRef(oldNodes, beforeMarker);
-        parent.insertBefore(node, ref);
+        safeInsertBefore(parent, node, ref);
         newNodes.push(node);
       }
       continue;
@@ -659,14 +659,14 @@ function reconcileKeyed(parent, oldNodes, newVNodes, beforeMarker) {
 
       // Move if not in LIS
       if (!lisSet.has(i) && patched.parentNode) {
-        parent.insertBefore(patched, lastInserted);
+        safeInsertBefore(parent, patched, lastInserted);
       }
       lastInserted = patched;
     } else {
       // Create new node
       const node = createDOM(vnode, parent);
       if (node) {
-        parent.insertBefore(node, lastInserted);
+        safeInsertBefore(parent, node, lastInserted);
         lastInserted = node;
       }
       newNodes[i] = node;
@@ -725,6 +725,18 @@ function getInsertionRef(nodes, marker) {
   return marker ? marker.nextSibling : null;
 }
 
+// Safe insertBefore: guards against stale reference nodes from nested reconciliation.
+// When patchNode triggers a child component re-render (via propsSignal.set), the child's
+// effect can run synchronously and mutate the DOM tree, leaving the parent's reference
+// node detached. This helper falls back to appendChild when the ref is stale.
+function safeInsertBefore(parent, node, ref) {
+  if (ref && ref.parentNode === parent) {
+    parent.insertBefore(node, ref);
+  } else {
+    parent.appendChild(node);
+  }
+}
+
 // Helper: clean up array marker range (startMarker .. endMarker) and return a clean replacement node
 function cleanupArrayMarkers(parent, startMarker) {
   const endMarker = startMarker._arrayEnd;

package/src/render.js

@@ -136,7 +136,10 @@ function reconcileInsert(parent, value, current, marker) {
   for (let i = newNodes.length - 1; i >= 0; i--) {
     const node = newNodes[i];
     if (node.parentNode !== parent || node.nextSibling !== ref) {
-      parent.insertBefore(node, ref);
+      // Guard against stale ref from nested reconciliation
+      if (ref && ref.parentNode !== parent) ref = null;
+      if (ref) parent.insertBefore(node, ref);
+      else parent.appendChild(node);
     }
     ref = node;
   }
@@ -360,6 +363,8 @@ function _reconcileMiddle(parent, endMarker, oldItems, newItems, mappedNodes, di
     const mi = i - start;
     if (oldIndices[mi] === -1 || !inLIS[mi]) {
       // New item or moved item — insert
+      // Guard against stale nextSibling from nested reconciliation
+      if (nextSibling && nextSibling.parentNode !== parent) nextSibling = endMarker;
       parent.insertBefore(newMapped[i], nextSibling);
     }
     nextSibling = newMapped[i];
@@ -649,6 +654,8 @@ function reconcileKeyed(parent, endMarker, oldItems, newItems, mappedNodes, disp
   for (let i = newEnd; i >= start; i--) {
     const mi = i - start;
     if (oldIndices[mi] === -1 || !inLIS[mi]) {
+      // Guard against stale nextSibling from nested reconciliation
+      if (nextSibling && nextSibling.parentNode !== parent) nextSibling = endMarker;
       parent.insertBefore(newMapped[i], nextSibling);
     }
     nextSibling = newMapped[i];